12 years agoVersion 1.3.2 1.3.2
Richard Jones [Sat, 10 Apr 2010 20:54:04 +0000 (21:54 +0100)]
Version 1.3.2

12 years agoNew API: checksum-device for checksumming devices.
Richard Jones [Sat, 10 Apr 2010 20:23:27 +0000 (21:23 +0100)]
New API: checksum-device for checksumming devices.

Analogous to the usual 'checksum' call.

12 years agovirt-resize: Enhance virt-resize so it can expand partition content.
Richard Jones [Sat, 10 Apr 2010 12:38:26 +0000 (13:38 +0100)]
virt-resize: Enhance virt-resize so it can expand partition content.

Enhance virt-resize so it can expand "first level" partition
content, including ext/2/3/4/ntfs filesystems and PVs.

Also extensively update the documentation.

This has been tested on a variety of Linux and Windows guests.

12 years agovirt-list-partitions: Add -t / --total option.
Richard Jones [Sat, 10 Apr 2010 12:21:33 +0000 (13:21 +0100)]
virt-list-partitions: Add -t / --total option.

This option lists out block devices separately:

 $ virt-list-partitions -lht /tmp/WindowsResized.img
 /dev/sda1 ntfs 100.0M
 /dev/sda2 ntfs 11.9G
 /dev/sda device 12.0G

12 years agoBugfixes for virt-resize.
Richard Jones [Sat, 10 Apr 2010 12:35:31 +0000 (13:35 +0100)]
Bugfixes for virt-resize.

 - copy more than 64 boot loader sectors across, since real boot
   loaders (eg. for Windows) can be much larger than this
 - copy bootable flag and ID byte to new partitions
 - start the first partition on the new disk at the same sector
   offset as on the old disk
 - sync the disks before existing

12 years agoNew partition APIs: part_del, part_get_bootable, part_get/set_mbr_id
Richard Jones [Sat, 10 Apr 2010 12:19:43 +0000 (13:19 +0100)]
New partition APIs: part_del, part_get_bootable, part_get/set_mbr_id

These APIs flesh out further the partitioning API.

12 years agodaemon: More reliable parsing of the output from 'parted print'.
Richard Jones [Sat, 10 Apr 2010 12:17:50 +0000 (13:17 +0100)]
daemon: More reliable parsing of the output from 'parted print'.

Previously we used strtok.  However this has the problem that
strtok considers multiple delimiter characters to be like a single
delimiter, eg. "1:::2" would be parsed the same as "1:2".  In
other words, the previous code would skip over or fail if there
are empty fields.

12 years agodaemon: Make the RUN_PARTED macro take an error statement.
Richard Jones [Sat, 10 Apr 2010 12:16:19 +0000 (13:16 +0100)]
daemon: Make the RUN_PARTED macro take an error statement.

This allows us to make the RUN_PARTED macro do something else
along the error path, other than just returning -1.

12 years agoDocumentation: Clarify documentation on the bootable flag.
Richard Jones [Sat, 10 Apr 2010 12:14:54 +0000 (13:14 +0100)]
Documentation: Clarify documentation on the bootable flag.

12 years agoNew API: vgscan
Richard Jones [Sat, 10 Apr 2010 12:14:12 +0000 (13:14 +0100)]
New API: vgscan

Implement vgscan to allow for a full rescan of all LVM
PVs, VGs and LVs.

12 years agoNew API: ntfsresize.
Richard Jones [Sat, 10 Apr 2010 12:13:07 +0000 (13:13 +0100)]
New API: ntfsresize.

This implements the ntfsresize operation, using the external
program from ntfsprogs.

12 years agovirt-make-fs: Use Sys::Guestfs::Lib::feature_available helper function.
Richard Jones [Sat, 10 Apr 2010 12:20:52 +0000 (13:20 +0100)]
virt-make-fs: Use Sys::Guestfs::Lib::feature_available helper function.

12 years agoAllow aug-ls to take Augeas variable as argument (RHBZ#580016).
Richard Jones [Fri, 9 Apr 2010 08:40:59 +0000 (09:40 +0100)]
Allow aug-ls to take Augeas variable as argument (RHBZ#580016).

12 years agoRemove warning "No grub default" (RHBZ#580650).
Richard Jones [Thu, 8 Apr 2010 18:33:57 +0000 (19:33 +0100)]
Remove warning "No grub default" (RHBZ#580650).

12 years agoIf qemu dies during launch in "null vmchannel" mode, don't hang (RHBZ#579155).
Richard Jones [Thu, 8 Apr 2010 18:07:45 +0000 (19:07 +0100)]
If qemu dies during launch in "null vmchannel" mode, don't hang (RHBZ#579155).

Detect if qemu dies during launch by wait(2)-ing for it, and
then getting EOF on the qemu pipe.  This was broken in null
vmchannel mode, causing a hang.

12 years agoDon't kill self accidentally.
Richard Jones [Thu, 8 Apr 2010 18:06:00 +0000 (19:06 +0100)]
Don't kill self accidentally.

Always check that pid > 0 before calling kill (pid, 9).  The
issue was that sometimes pid == 0, and this ends up killing

12 years agoFix for "warning: unexpected connection from UID ..."
Richard Jones [Thu, 8 Apr 2010 17:53:40 +0000 (18:53 +0100)]
Fix for "warning: unexpected connection from UID ..."

This warning is currently a fatal error.  The code attempts
to retry the accept call, but because we don't reset sock = -1
the retry doesn't happen and it dies anyway.

Set sock = -1 so the retry attempt can happen.

12 years agoNew API calls to upload/download txz files (RHBZ#580556).
Richard Jones [Thu, 8 Apr 2010 15:07:32 +0000 (16:07 +0100)]
New API calls to upload/download txz files (RHBZ#580556).

12 years agoconfigure: Default to using Fedora 12 repo (was Fedora 11).
Richard Jones [Thu, 8 Apr 2010 14:49:14 +0000 (15:49 +0100)]
configure: Default to using Fedora 12 repo (was Fedora 11).

Fedora 11 is almost EOL at this point.

12 years agoVersion 1.3.1. 1.3.1
Richard Jones [Thu, 8 Apr 2010 14:17:07 +0000 (15:17 +0100)]
Version 1.3.1.

12 years agoNew tool: virt-make-fs for creating filesystems on devices.
Richard Jones [Wed, 7 Apr 2010 19:30:46 +0000 (20:30 +0100)]
New tool: virt-make-fs for creating filesystems on devices.

12 years agoCode cleanups related to RHBZ#580246.
Richard Jones [Wed, 7 Apr 2010 20:04:01 +0000 (21:04 +0100)]
Code cleanups related to RHBZ#580246.

This includes various code cleanups:

 (a) A regression test for RHBZ#580246.

 (b) Use write instead of fwrite to write out the tar file.  This is
     just because the error handling of write seems to be better
     specified and easier to use.

 (c) Use size_t instead of int for length.

 (d) Clearer debug messages when in verbose mode.

12 years agoFix tar-in command hangs when running out of disk space (RHBZ#580246).
Richard Jones [Thu, 8 Apr 2010 07:48:38 +0000 (08:48 +0100)]
Fix tar-in command hangs when running out of disk space (RHBZ#580246).

The problem was this sequence of events:

 (1) File transfer goes through OK.

 (2) pclose returns failure (because 'tar' subprocess failed)

 (3) We try to cancel the transfer by calling cancel_receive.

Step (3) fails because the transfer (as far as the library is
concerned) has succeeded, so causing a hang.

The more fundamental reason why we see steps (1) and (2) is that
'tar' does NOT fail immediately if there is a write error.  Instead
it continues reading and discarding the input until the end of the
input before giving "Error exit delayed from previous errors".
IMHO this is a bug with tar, since an ENOSPC write error should
be fatal for tar.

12 years agofish: Print extended help when the user types an unknown command first.
Richard Jones [Tue, 6 Apr 2010 22:54:08 +0000 (23:54 +0100)]
fish: Print extended help when the user types an unknown command first.

$ guestfish /tmp/disk.img
/tmp/disk.img: unknown command
Did you mean to open a disk image?  guestfish -a disk.img
For a list of commands:             guestfish -h
For complete documentation:         man guestfish

12 years agoCheck error returns from posix_fallocate (RHBZ#579664).
Richard Jones [Tue, 6 Apr 2010 10:03:03 +0000 (11:03 +0100)]
Check error returns from posix_fallocate (RHBZ#579664).

posix_fallocate has a non-standard way to return error indications.
Thus all our calls to posix_fallocate were effectively unchecked.  For

  $ guestfish alloc test.img 1P
  $ echo $?
  $ ll test.img
  -rw-rw-r--. 1 rjones rjones 0 2010-04-06 11:02 test.img
  $ rm test.img

With this change, errors are detected and reported properly:

  $ ./fish/guestfish alloc test.img 1P
  fallocate: File too large

This is a fix for:

12 years agoSigned/unsigned warning on 64 bit.
Richard Jones [Wed, 31 Mar 2010 12:19:34 +0000 (13:19 +0100)]
Signed/unsigned warning on 64 bit.

12 years agoNew API: guestfs_zero_device to zero whole devices.
Richard Jones [Wed, 31 Mar 2010 12:19:34 +0000 (13:19 +0100)]
New API: guestfs_zero_device to zero whole devices.

12 years agoPrettier POD CSS.
Richard W.M. Jones [Tue, 30 Mar 2010 20:07:27 +0000 (21:07 +0100)]
Prettier POD CSS.

12 years agoUpdate PO files. 1.0.89 1.2.0 1.3.0
Richard Jones [Tue, 30 Mar 2010 16:49:44 +0000 (17:49 +0100)]
Update PO files.

12 years agochmod +x virt-resize binary.
Richard Jones [Tue, 30 Mar 2010 16:49:24 +0000 (17:49 +0100)]
chmod +x virt-resize binary.

12 years agoFix EXTRA_DIST rule.
Richard Jones [Tue, 30 Mar 2010 16:49:06 +0000 (17:49 +0100)]
Fix EXTRA_DIST rule.

12 years agoPrepare for 1.0.89.
Richard Jones [Tue, 30 Mar 2010 16:05:56 +0000 (17:05 +0100)]
Prepare for 1.0.89.

12 years agoImproved version of virt-win-reg, supporting exporting and merging.
Richard Jones [Fri, 26 Mar 2010 17:14:04 +0000 (17:14 +0000)]
Improved version of virt-win-reg, supporting exporting and merging.

12 years agovirt-df: Match output with native (coreutils) 'df' command (RHBZ#578123).
Richard Jones [Tue, 30 Mar 2010 15:14:09 +0000 (16:14 +0100)]
virt-df: Match output with native (coreutils) 'df' command (RHBZ#578123).

This commit fixes the 'Use%' field in the output so it matches what
coreutils' 'df' command would print.

Firstly we change the calculation to use the space available to root,
not the space available to non-root.  This means it matches what 'df'
when run as root in the guest would show.

Secondly we display this rounded up to the next whole percent (ie. using
ceil), which is also what 'df' does.

Thirdly we change the regression test so it tests this.

Note that even with these changes you are not guaranteed to get precisely
the same figures from inside and outside the guest, as it depends on
how quiescent the guest is and how recently the superblock was synced.

Thanks: Rita Wu

12 years agotools: Add basic tests for the virt-* tools.
Richard Jones [Tue, 30 Mar 2010 13:18:44 +0000 (14:18 +0100)]
tools: Add basic tests for the virt-* tools.

12 years agotools: Sectional header for manpages in
Richard Jones [Tue, 30 Mar 2010 12:45:16 +0000 (13:45 +0100)]
tools: Sectional header for manpages in

12 years agotools: Rearrange list of tools in
Richard Jones [Tue, 30 Mar 2010 12:44:29 +0000 (13:44 +0100)]
tools: Rearrange list of tools in

12 years agodaemon: Set TERM=dumb inside the daemon.
Richard Jones [Tue, 30 Mar 2010 12:34:16 +0000 (13:34 +0100)]
daemon: Set TERM=dumb inside the daemon.

Since commit 977edb3185fe8f we have been passing TERM from the
library into the appliance (for the benefit of virt-rescue).
However this changes the output of parted, which I would argue
is a bug in parted:

 TERM=xterm /sbin/parted -m -- /dev/sda unit b print 2>&1 | hexdump -C
 00000000  1b 5b 3f 31 30 33 34 68  42 59 54 3b 0a 2f 64 65  |.[?1034hBYT;./de|

Notice the escape-sequence junk before the official "BYT;"

By setting TERM=dumb we avoid this.

12 years agoFix the error message when reply body is too large (RHBZ#509597).
Richard Jones [Sat, 27 Mar 2010 11:02:03 +0000 (11:02 +0000)]
Fix the error message when reply body is too large (RHBZ#509597).

12 years agotests: Move alarm(2) calls to the correct place in the tests.
Richard Jones [Sat, 27 Mar 2010 10:49:24 +0000 (10:49 +0000)]
tests: Move alarm(2) calls to the correct place in the tests.

This is a re-fix for RHBZ#505329.

12 years agoPrepare for 1.0.88. 1.0.88
Richard Jones [Fri, 26 Mar 2010 21:08:43 +0000 (21:08 +0000)]
Prepare for 1.0.88.

12 years agorescue: Pass $TERM from library into the virt-rescue appliance.
Richard Jones [Fri, 26 Mar 2010 20:08:45 +0000 (20:08 +0000)]
rescue: Pass $TERM from library into the virt-rescue appliance.

We set it on the kernel command line, then get it out from
there when the rescue appliance boots.

12 years agorescue: Sync disk on exit, and improve messaging.
Richard Jones [Fri, 26 Mar 2010 20:02:10 +0000 (20:02 +0000)]
rescue: Sync disk on exit, and improve messaging.

12 years agoConst-correctness fix.
Jim Meyering [Fri, 26 Mar 2010 20:01:45 +0000 (20:01 +0000)]
Const-correctness fix.

12 years agoappliance: Set $PATH instead of hard-coding paths to binaries everywhere.
Richard Jones [Fri, 26 Mar 2010 10:10:16 +0000 (10:10 +0000)]
appliance: Set $PATH instead of hard-coding paths to binaries everywhere.

Change the appliance so PATH includes common directories.  Thus
we don't need to hard-code paths to binaries (eg. "/sbin/fdisk")

12 years agoperl: use newSVpvn for variable length strings.
Richard Jones [Thu, 25 Mar 2010 19:44:22 +0000 (19:44 +0000)]
perl: use newSVpvn for variable length strings.

Previously we used newSVpv (str, len), but if len == 0 then
this means Perl tries to calculate the string length using
strlen(3).  This is not desirable when we know the length, in
which case we should use newSVpvn instead.

12 years agoUpdate PO files.
Richard Jones [Thu, 25 Mar 2010 16:03:42 +0000 (16:03 +0000)]
Update PO files.

12 years agoUpdate Spanish translation of libguestfs (RHBZ#576876).
Daniel Cabrera [Thu, 25 Mar 2010 16:03:01 +0000 (16:03 +0000)]
Update Spanish translation of libguestfs (RHBZ#576876).

12 years agoFix lvresize test on RHEL 5, by fixing guestfs_e2fsck_l.
Richard Jones [Wed, 24 Mar 2010 23:28:14 +0000 (23:28 +0000)]
Fix lvresize test on RHEL 5, by fixing guestfs_e2fsck_l.

The problem is that mkfs was making an ext2 filesystem,
which later we were checking with e4fsck.  e4fsck corrects
an "error" on the filesystem:
  /dev/VG/LV: Adding dirhash hint to filesystem.
e4fsck returns 1 (errors corrected) which we were interpreting
as an error return.

12 years agoUse ext4 dev tools on RHEL 5 (RHBZ#576688).
Richard Jones [Wed, 24 Mar 2010 22:02:34 +0000 (22:02 +0000)]
Use ext4 dev tools on RHEL 5 (RHBZ#576688).

12 years agoAdd support for minix filesystem (RHBZ#576689).
Richard Jones [Wed, 24 Mar 2010 21:21:23 +0000 (21:21 +0000)]
Add support for minix filesystem (RHBZ#576689).

12 years agoVersion 1.0.87. 1.0.87
Richard Jones [Tue, 23 Mar 2010 22:10:45 +0000 (22:10 +0000)]
Version 1.0.87.

12 years agoNew tools: virt-resize and virt-list-partitions.
Richard Jones [Mon, 22 Mar 2010 18:38:31 +0000 (18:38 +0000)]
New tools: virt-resize and virt-list-partitions.

Virt-resize is the main contribution here, a program which can
be used to expand and shrink partitions in disk images.

Virt-list-partitions is used as an ancillary tool for planning
resize operations.

12 years agoNew API: guestfs_copy_size to copy a fixed number of bytes.
Richard Jones [Mon, 22 Mar 2010 18:36:16 +0000 (18:36 +0000)]
New API: guestfs_copy_size to copy a fixed number of bytes.

This is similar to 'guestfs_dd', but it copies just a fixed
number of bytes from the source to the destination.  It's an
error if the source is too short or if the destination is too

12 years agoChange some _exit(0|1) to _exit(EXIT_SUCCESS|EXIT_FAILURE).
Richard W.M. Jones [Fri, 19 Mar 2010 17:21:05 +0000 (17:21 +0000)]
Change some _exit(0|1) to _exit(EXIT_SUCCESS|EXIT_FAILURE).

12 years agoMac OS X: Fix configure-time tests for Ruby.
Richard Jones [Mon, 22 Mar 2010 10:30:25 +0000 (10:30 +0000)]
Mac OS X: Fix configure-time tests for Ruby.

For ARCHFLAGS change, see:

We also add a test for the <guestfs.h> header and include
that header when testing the library.

12 years agoguestfs.h: Include <stdint.h>.
Richard Jones [Mon, 22 Mar 2010 10:29:18 +0000 (10:29 +0000)]
guestfs.h: Include <stdint.h>.

This allows programs to work if they just
  #include <guestfs.h>
and no other headers.  It's not useful in the general
case, but fixes some configure-time tests, particularly
the one for Ruby on OS X.

12 years agoocaml examples: Fix linking line so it uses local library.
Richard Jones [Mon, 22 Mar 2010 10:05:49 +0000 (10:05 +0000)]
ocaml examples: Fix linking line so it uses local library.

12 years agoMac OS X: Disable null vmchannel implementation.
Richard Jones [Sun, 21 Mar 2010 21:47:39 +0000 (21:47 +0000)]
Mac OS X: Disable null vmchannel implementation.

As far as I can tell, Darwin has no way to check the peer euid
of a _loopback_ TCP socket.  This is required for the "null vmchannel"
implementation to work securely.

Therefore disable this - Darwin will use one of the other supported
vmchannel implementations instead.

12 years agoMac OS X: 'xdr_uint32_t' is 'xdr_u_int32_t'
Richard Jones [Sun, 21 Mar 2010 20:41:41 +0000 (20:41 +0000)]
Mac OS X: 'xdr_uint32_t' is 'xdr_u_int32_t'

12 years agoMac OS X: For PATH_MAX, include <limits.h>
Richard Jones [Sun, 21 Mar 2010 19:45:50 +0000 (19:45 +0000)]
Mac OS X: For PATH_MAX, include <limits.h>

12 years agoMac OS X: setlocale function requires <locale.h> header file.
Richard Jones [Sun, 21 Mar 2010 19:30:25 +0000 (19:30 +0000)]
Mac OS X: setlocale function requires <locale.h> header file.

12 years agoMac OS X: implement readline functions.
Richard Jones [Sun, 21 Mar 2010 19:15:40 +0000 (19:15 +0000)]
Mac OS X: implement readline functions.

OS X has an older version of readline with some differences
in the names of functions.

12 years agoMac OS X: provide alternate implementation of posix_fallocate.
Richard Jones [Sun, 21 Mar 2010 19:13:43 +0000 (19:13 +0000)]
Mac OS X: provide alternate implementation of posix_fallocate.

12 years agoMac OS X: include <rpc/types.h> before <rpc/xdr.h>
Richard Jones [Sun, 21 Mar 2010 17:49:49 +0000 (17:49 +0000)]
Mac OS X: include <rpc/types.h> before <rpc/xdr.h>

In PortableXDR this is not included automatically so we
have to include it explicitly to get definitions for the
XDR types.

12 years agoMac OS X: include <string.h> in guestfs-actions.c
Richard Jones [Sun, 21 Mar 2010 17:49:09 +0000 (17:49 +0000)]
Mac OS X: include <string.h> in guestfs-actions.c

This is required because guestfs-actions.c uses 'memset'.

12 years agoMac OS X: Fix HAVE_GNU_CALLOC so it works when __GLIBC__ is not defined.
Richard Jones [Sun, 21 Mar 2010 17:16:04 +0000 (17:16 +0000)]
Mac OS X: Fix HAVE_GNU_CALLOC so it works when __GLIBC__ is not defined.

12 years agoMac OS X: strerror_r on Macs is not like GNU strerror_r.
Richard Jones [Sun, 21 Mar 2010 17:15:26 +0000 (17:15 +0000)]
Mac OS X: strerror_r on Macs is not like GNU strerror_r.

Really this should be turned into a configure-time test.
Perhaps one exists already?

12 years agoMac OS X: define MAX macro if not already defined.
Richard Jones [Sun, 21 Mar 2010 17:14:37 +0000 (17:14 +0000)]
Mac OS X: define MAX macro if not already defined.

12 years agoMac OS X: kill(2) requires <signal.h>
Richard Jones [Sun, 21 Mar 2010 17:14:15 +0000 (17:14 +0000)]
Mac OS X: kill(2) requires <signal.h>

12 years agogenerator: Small fix for GODI users.
Richard Jones [Sun, 21 Mar 2010 17:13:07 +0000 (17:13 +0000)]
generator: Small fix for GODI users.

GODI has an odd package layout, so the generator was unable to
find xml-light.  Add the GODI directory to the search path.

12 years agoIgnore m4/intmax.m4
Richard Jones [Sun, 21 Mar 2010 16:06:30 +0000 (16:06 +0000)]
Ignore m4/intmax.m4

12 years agoRemove out-of-date comment.
Richard Jones [Sun, 21 Mar 2010 16:04:09 +0000 (16:04 +0000)]
Remove out-of-date comment.

12 years agoconfigure: Add --disable-daemon and --disable-appliance options.
Richard Jones [Sun, 21 Mar 2010 16:03:16 +0000 (16:03 +0000)]
configure: Add --disable-daemon and --disable-appliance options.

Use these on any platforms where you don't want or need to
build the daemon/appliance combination.

12 years agoRun qemu with -nographic option.
Richard Jones [Sun, 21 Mar 2010 16:33:37 +0000 (16:33 +0000)]
Run qemu with -nographic option.

On Mac OS X this prevents a short "flash" as qemu opens a
toplevel window.

12 years agoconfigure: Move host_cpu definition to earlier in the file.
Richard Jones [Sun, 21 Mar 2010 16:32:27 +0000 (16:32 +0000)]
configure: Move host_cpu definition to earlier in the file.

12 years agoappliance: Run depmod to create modules.dep for the kernel.
Richard Jones [Sun, 21 Mar 2010 21:23:47 +0000 (21:23 +0000)]
appliance: Run depmod to create modules.dep for the kernel.

Since we disabled running new-kernel-pkg in febootstrap, this
has meant that the normal appliance has not had a modules.dep
file.  (Supermin was unaffected by this).

12 years agoMac OS X: Detect bindtextdomain.
Richard Jones [Sun, 21 Mar 2010 19:30:52 +0000 (19:30 +0000)]
Mac OS X: Detect bindtextdomain.

These are missing on Mac OS X.  I think you would need to install
a gettext package to get these.

12 years agoMac OS X: Use gnulib setenv module explicitly.
Richard Jones [Mon, 22 Mar 2010 08:29:17 +0000 (08:29 +0000)]
Mac OS X: Use gnulib setenv module explicitly.


12 years agoNew APIs: Query the relationship between LVM objects.
Richard Jones [Thu, 18 Mar 2010 13:48:03 +0000 (13:48 +0000)]
New APIs: Query the relationship between LVM objects.

These calls allow you to query the relationship between
LVM objects, for example, which PVs contain a VG, or which
LVs are contained in a VG.

See the example / test program 'regressions/'
for an example of how to do this from Perl.

12 years agodaemon: Add a trim utility function.
Richard Jones [Thu, 18 Mar 2010 13:46:26 +0000 (13:46 +0000)]
daemon: Add a trim utility function.

This function trims the whitespace from around a string.  It
does this in-place, so it can be called for malloc'd strings.

12 years agoadd_drive_ro adds readonly=on option if available.
Richard Jones [Tue, 16 Mar 2010 21:50:13 +0000 (21:50 +0000)]
add_drive_ro adds readonly=on option if available.

Change the add_drive_ro call so it adds the readonly=on option
if qemu supports that.

This just means that qemu will not try to open the drive with
O_RDWR, and should not otherwise change the behaviour of qemu or
libguestfs.  (In particular, writes to the read-only drive are
still permitted, and are just discarded when the handle is closed).

However it should alleviate RHBZ#571714 where udev was deciding
to incorrectly relabel a device because we had opened the device
for writing (even though we didn't actually write to it).

12 years agoAllow qemu_supports to run earlier.
Richard Jones [Tue, 16 Mar 2010 21:44:26 +0000 (21:44 +0000)]
Allow qemu_supports to run earlier.

Reimplement qemu_supports() internal function.  Allow it to run
before launch so we can test qemu features.  Document that you
should run guestfs_set_qemu as early as possible to make sure
these tests are reliable.

12 years agoAdd minimal vim to the appliance for virt-rescue.
Richard Jones [Tue, 16 Mar 2010 20:06:12 +0000 (20:06 +0000)]
Add minimal vim to the appliance for virt-rescue.

virt-rescue lacks an editor.  Add vim-minimal (Fedora)
or vim-tiny (Debian) to make up for this omission.

12 years agotests: Don't use <guestfs-internal.h> in tests.
Richard Jones [Tue, 16 Mar 2010 21:11:23 +0000 (21:11 +0000)]
tests: Don't use <guestfs-internal.h> in tests.

It was failing when including this header, as a consequence
of earlier commit 1f56debfcfdc35d6b0.

12 years agoguestfs.h: More adjustment to comments in the header file.
Richard Jones [Tue, 16 Mar 2010 11:50:39 +0000 (11:50 +0000)]
guestfs.h: More adjustment to comments in the header file.

12 years agoguestfs.h: Move some internal functions to the internal header.
Richard Jones [Tue, 16 Mar 2010 11:18:51 +0000 (11:18 +0000)]
guestfs.h: Move some internal functions to the internal header.

Functions like guestfs__send were never exported through the public
API (libguestfs.syms prevented that).  However they appeared in the
public header.  Move them to the internal header.

12 years agoRearrangement and comment changes in <guestfs.h> header file.
Richard Jones [Tue, 16 Mar 2010 11:15:28 +0000 (11:15 +0000)]
Rearrangement and comment changes in <guestfs.h> header file.

There should be no substantive change.

12 years agoPrepare for version 1.0.86. 1.0.86
Richard Jones [Fri, 12 Mar 2010 18:28:21 +0000 (18:28 +0000)]
Prepare for version 1.0.86.

12 years agoTab to space (whitespace fixes only).
Richard Jones [Fri, 12 Mar 2010 16:23:46 +0000 (16:23 +0000)]
Tab to space (whitespace fixes only).

12 years agoDocs: Change exit(1) -> exit(EXIT_FAILURE)
Richard Jones [Fri, 12 Mar 2010 16:23:14 +0000 (16:23 +0000)]
Docs: Change exit(1) -> exit(EXIT_FAILURE)

12 years agoRewrite libguestfs-supermin-helper in C.
Richard Jones [Fri, 12 Mar 2010 16:20:31 +0000 (16:20 +0000)]
Rewrite libguestfs-supermin-helper in C.

libguestfs-supermin-helper was previously a shell script.  Although
we had steadily optimized it, there were a number of intractable
hot spots:

  (1) cpio still reads input files in 512 byte chunks; this is *very*
    pessimal behaviour, particularly when SELinux is enabled.
  (2) the hostfiles globbing was done very inefficiently by the shell,
    with the shell rereading the same directory over and over again.

This is a rewrite of this shell script in C.  It is approximately
3 times faster without SELinux, and has an even greater speed difference
with SELinux.

The main features are:

  (a) It never frees memory, making it simpler.  The program is designed
    to run and exit in sub-second times, so this is acceptable.
  (b) It caches directory reads, making the globbing of host files much
    faster (measured this as ~ 4 x speed up).
  (c) It doesn't use external cpio, but instead contains code to write
    newc format cpio files, which is all that the kernel can read.  Unlike
    cpio, this code uses large buffers for reads and writes.
  (d) Ignores missing or unreadable hostfiles, whereas cpio gave a
  (e) Checks all return values from system calls.
  (f) With --verbose flag, it will print messages timing itself.

This passes all tests.

Updated with feedback from Jim Meyering.

12 years agoguestfish: Use xstrtoll to parse Int params (RHBZ#569757 RHBZ#567567).
Richard Jones [Fri, 12 Mar 2010 09:47:38 +0000 (09:47 +0000)]
guestfish: Use xstrtoll to parse Int params (RHBZ#569757 RHBZ#567567).

Change guestfish so it uses xstrtoll to parse Int (31 bit)
parameters.  This fixes two bugs on 32 bit platforms which
failed when long = 32 bits.  long long = 64 bits on both.

12 years agoSpecial case hostfiles handling for
Richard Jones [Fri, 12 Mar 2010 15:10:28 +0000 (15:10 +0000)]
Special case hostfiles handling for

The ntfs-3g project keeps bumping their soname, and this causes
dependency problems for the Fedora package.  The root of the problem
is we depend on /lib/<N>, but if <N> keeps bumping,
the dependency keeps breaking.

This commit changes the hostfiles (and hence dependency) to be on
/lib/* instead.  The downside to this is we could end
up pulling more files into the appliance than are strictly required,
but it will fix the Fedora packaging problems being felt by the
Fedora maintainer of ntfs-3g.

After applying this commit, the change to hostfiles looks like this:

@@ -1489,7 +1489,7 @@
@@ -1520,7 +1520,6 @@

12 years agoinspector: Read information about Windows guests from the Registry.
Richard Jones [Mon, 8 Mar 2010 19:31:12 +0000 (19:31 +0000)]
inspector: Read information about Windows guests from the Registry.

This commit changes substantially the way that we get information
about Windows guests.  We now use the Windows Registry to get
information such as the version, product name and much else.

This uses Win::Hivex (ie. the hivex library).  'reged' is no longer
needed or used.

As an incidental change, this also tries harder to search for
%systemroot%, in the case when we cannot find boot.ini (ie.
Windows Vista and more recent).  This ensures we can get more
detail from those versions of Windows.

12 years agoinspector: Add product_name field to output.
Richard Jones [Mon, 8 Mar 2010 19:27:02 +0000 (19:27 +0000)]
inspector: Add product_name field to output.

This is a free text string containing the "product name" of
the OS.  It's mainly useful for Windows guests, and a forthcoming
patch will get this field from the Windows Registry.

12 years agoinspector: Don't crash if $os->{kernels} does not exist.
Richard Jones [Mon, 8 Mar 2010 19:28:48 +0000 (19:28 +0000)]
inspector: Don't crash if $os->{kernels} does not exist.

ie. on Windows.

12 years agoinspector: Sort application names.
Richard Jones [Mon, 8 Mar 2010 19:24:48 +0000 (19:24 +0000)]
inspector: Sort application names.

This ensures the list of applications is stable.

12 years agoRemove plymouth libraries from the appliance.
Richard Jones [Mon, 8 Mar 2010 16:04:09 +0000 (16:04 +0000)]
Remove plymouth libraries from the appliance.

12 years agoSpanish translation of libguestfs (RHBZ#570181).
Daniel Cabrera [Wed, 3 Mar 2010 15:49:39 +0000 (15:49 +0000)]
Spanish translation of libguestfs (RHBZ#570181).