12 years agohivex: Add HIVEX_OPEN_WRITE flag to allow hive to be opened for writing.
Richard Jones [Mon, 18 Jan 2010 11:08:56 +0000 (11:08 +0000)]
hivex: Add HIVEX_OPEN_WRITE flag to allow hive to be opened for writing.

If this flag is omitted (as in the case for all existing callers)
then the hive is still opened read-only.

We add a 'writable' flag to the hive handle, and we change the way
that the hive file (data) is stored.  The data is still mmapped if
the file is opened read-only, since that is more efficient and allows
us to handle larger hives.  However if we need to write to the file
then we have to read it all into memory, since if we had to extend the
file we need to realloc that data.

Note the manpage section L</WRITING TO HIVE FILES> comes in a later

12 years agoTools for analyzing and reverse engineering hive files.
Richard Jones [Wed, 3 Feb 2010 17:35:53 +0000 (17:35 +0000)]
Tools for analyzing and reverse engineering hive files.

This commit is not of general interest.  It contains the tools which
I used to reverse engineer the hive format and to test changes.
Keeping these with the rest of the code is useful in case in future
we encounter a hive file that we fail to modify.

Note that the tools are not compiled by default.  You have to compile
each explicitly with:

  make -C hivex/tools <toolname>.opt

You will also need ocaml-extlib-devel and ocaml-bitstring-devel.

12 years agohivexsh: Change some exit(1) -> exit(EXIT_FAILURE)
Richard Jones [Wed, 3 Feb 2010 17:52:05 +0000 (17:52 +0000)]
hivexsh: Change some exit(1) -> exit(EXIT_FAILURE)

12 years agohivexsh: Only print final \n when interactive.
Richard Jones [Wed, 3 Feb 2010 17:50:51 +0000 (17:50 +0000)]
hivexsh: Only print final \n when interactive.

When hivexsh was called non-interactively, it would print an
annoying extra line.  Only print this line if we are being
used interactively.

12 years agohivexsh: Change handling of prompt argument to rl_gets()
Richard Jones [Wed, 3 Feb 2010 17:48:37 +0000 (17:48 +0000)]
hivexsh: Change handling of prompt argument to rl_gets()

Make the result of isatty into a global variable (is_tty).

Change the rl_gets() function so it takes the prompt string
instead of a "display prompt?" flag.  rl_gets() then consults
the global to find out if it should display the prompt at all.

12 years agoDocument that this flag is clear for default keys.
Richard Jones [Wed, 3 Feb 2010 17:45:20 +0000 (17:45 +0000)]
Document that this flag is clear for default keys.

12 years agoMisc documentation and gitignore update.
Richard Jones [Wed, 3 Feb 2010 17:44:39 +0000 (17:44 +0000)]
Misc documentation and gitignore update.

12 years agoMove htole*/le*toh macros into a separate header file.
Richard Jones [Wed, 3 Feb 2010 17:41:15 +0000 (17:41 +0000)]
Move htole*/le*toh macros into a separate header file.

This allows us to reuse these macros in hivexsh later.

12 years agoAdd Marathi translations (RHBZ#561671).
Sandeep Shedmake [Thu, 4 Feb 2010 08:50:14 +0000 (08:50 +0000)]
Add Marathi translations (RHBZ#561671).

12 years agoPolish translations (RHBZ#502533).
Piotr Drąg [Tue, 2 Feb 2010 22:08:24 +0000 (22:08 +0000)]
Polish translations (RHBZ#502533).

12 years agoUpdate PO files.
Richard Jones [Tue, 2 Feb 2010 08:49:56 +0000 (08:49 +0000)]
Update PO files.

12 years agoAdd Gujarti translations (Sweta Kothari) (RHBZ#560918).
Richard Jones [Tue, 2 Feb 2010 08:49:10 +0000 (08:49 +0000)]
Add Gujarti translations (Sweta Kothari) (RHBZ#560918).

12 years agoUpdate Oriya translations (thanks Manoj Kumar Giri) (RHBZ#559498).
Richard Jones [Mon, 1 Feb 2010 14:50:19 +0000 (14:50 +0000)]
Update Oriya translations (thanks Manoj Kumar Giri) (RHBZ#559498).

12 years agohivex: Reimplement hivexget as a simple shell script.
Richard Jones [Fri, 29 Jan 2010 19:12:34 +0000 (19:12 +0000)]
hivex: Reimplement hivexget as a simple shell script.

hivexget is currently a large C program.  Now that we have hivexsh
(the shell) we can reimplement hivexget as a simple bash script that
calls out to hivexsh.

12 years agohivex: Add 'hivexsh' program (shell for navigating registry hives).
Richard Jones [Fri, 29 Jan 2010 12:18:30 +0000 (12:18 +0000)]
hivex: Add 'hivexsh' program (shell for navigating registry hives).

12 years agoSet locale in C programs so l10n works (RHBZ#559962).
Richard Jones [Fri, 29 Jan 2010 14:56:13 +0000 (14:56 +0000)]
Set locale in C programs so l10n works (RHBZ#559962).

This commit adds the calls to setlocale &c to all of the current
C programs.

It also adds l10n support to hivexget and hivexml which lacked them

To test this, try:

LANG=pa_IN.UTF-8 guestfish --cmd-help

(You can only do this test after installing the package, or at
least the '' mo-file in the correct place).

12 years agoAnother unreadable file: /var/log/yum.log
Richard Jones [Fri, 29 Jan 2010 14:24:54 +0000 (14:24 +0000)]
Another unreadable file: /var/log/yum.log

12 years agoUpdate PO files.
Richard Jones [Fri, 29 Jan 2010 09:57:37 +0000 (09:57 +0000)]
Update PO files.

12 years agoAdd Tamil translation (RHBZ#559877) (thanks to I.Felix)
Richard Jones [Fri, 29 Jan 2010 09:57:12 +0000 (09:57 +0000)]
Add Tamil translation (RHBZ#559877) (thanks to I.Felix)

12 years agoUpdate Punjabi translation (RHBZ#559480) (thanks Jaswinder Singh)
Richard Jones [Fri, 29 Jan 2010 09:46:52 +0000 (09:46 +0000)]
Update Punjabi translation (RHBZ#559480) (thanks Jaswinder Singh)

12 years agoFix regressions/ when debugging is enabled (v2).
Richard Jones [Fri, 29 Jan 2010 09:02:14 +0000 (09:02 +0000)]
Fix regressions/ when debugging is enabled (v2).

The previous fix didn't cope with ordinary warnings emitted by
qemu (eg. "open /dev/kvm: No such file or directory").  This
is a hopefully more complete fix for the problem.

See also commit 3cd7ce75f1ce5048a4d9f6aeaf66aff3194e1096.

12 years agoFix regressions/ when debugging is enabled.
Richard Jones [Thu, 28 Jan 2010 22:35:16 +0000 (22:35 +0000)]
Fix regressions/ when debugging is enabled.

The regression test for RHBZ#557655 would fail if debugging was
enabled, because debug output would get mixed up with the test

To reproduce the error do:

LIBGUESTFS_DEBUG=1 make -C regressions check

This commit disables debug for just this test.

12 years agoImplement 'vgrename' and 'lvrename' APIs.
Richard Jones [Thu, 28 Jan 2010 22:06:27 +0000 (22:06 +0000)]
Implement 'vgrename' and 'lvrename' APIs.

12 years agoVersion 1.0.82. 1.0.82
Richard Jones [Thu, 28 Jan 2010 19:28:21 +0000 (19:28 +0000)]
Version 1.0.82.

12 years agohivex: Const-correctness fix on header_checksum (thanks Jim Meyering).
Richard Jones [Thu, 28 Jan 2010 17:39:06 +0000 (17:39 +0000)]
hivex: Const-correctness fix on header_checksum (thanks Jim Meyering).

12 years agohivex: Update some previously unknown nk-record fields.
Richard Jones [Thu, 28 Jan 2010 16:25:19 +0000 (16:25 +0000)]
hivex: Update some previously unknown nk-record fields.

Update these fields with what we found out from reverse engineering
the file.  Also bring the unknownX field names into line with

12 years agohivex: Fix calculation of block size for vk data blocks.
Richard Jones [Thu, 21 Jan 2010 17:07:42 +0000 (17:07 +0000)]
hivex: Fix calculation of block size for vk data blocks.

12 years agohivex: Display incorrect block size as unsigned in an error message.
Richard Jones [Thu, 21 Jan 2010 17:07:21 +0000 (17:07 +0000)]
hivex: Display incorrect block size as unsigned in an error message.

12 years agohivex: display bad block offset in hex
Richard Jones [Thu, 21 Jan 2010 16:19:49 +0000 (16:19 +0000)]
hivex: display bad block offset in hex

12 years agohivex: hive type in vk-record is an unsigned 32 bit int
Richard Jones [Thu, 21 Jan 2010 16:19:26 +0000 (16:19 +0000)]
hivex: hive type in vk-record is an unsigned 32 bit int

12 years agohivex: Add missing le32toh conversion around field access.
Richard Jones [Tue, 19 Jan 2010 15:21:06 +0000 (15:21 +0000)]
hivex: Add missing le32toh conversion around field access.

This was missing.  It only worked because we test on a little
endian platform.

12 years agohivex: Clarify some more fields.
Richard Jones [Tue, 19 Jan 2010 15:20:36 +0000 (15:20 +0000)]
hivex: Clarify some more fields.

Taken from documentation.

12 years agohivex: Modify children/values functions to return intermediate blocks.
Richard Jones [Tue, 19 Jan 2010 12:22:10 +0000 (12:22 +0000)]
hivex: Modify children/values functions to return intermediate blocks.

Modify the functions that return child subnodes and values so they
can also be used to return a list of the intermediate blocks.  This
is so we can delete those intermediate blocks (in a later commit).

We also introduce an offset_list structure which is used for collecting
lists of offsets, ie. lists of nodes, values or blocks.

Note that this commit should not change the semantics of the code.

12 years agohivex: Add value_any callback to the visitor.
Richard Jones [Tue, 19 Jan 2010 10:06:00 +0000 (10:06 +0000)]
hivex: Add value_any callback to the visitor.

The visitor currently contains lots of value_* callbacks, such as
value_string which is called back when the value has type string.

This is fine but it makes it complicated to deal with the case where
you just want to see 'a value', and don't care about its type.

The value_any callback allows visitors to see values generically.

12 years agohivex: Move header checksum code into a function.
Richard Jones [Mon, 18 Jan 2010 17:56:13 +0000 (17:56 +0000)]
hivex: Move header checksum code into a function.

This function can be reused later.

12 years agohivex: page 'offset_next' field is really 'page_size'.
Richard Jones [Mon, 18 Jan 2010 15:24:16 +0000 (15:24 +0000)]
hivex: page 'offset_next' field is really 'page_size'.

The documentation, as usual, is contradictory.  However this
field is definitely the page size in all observed registries.
Furthermore the following field marked 'unknown' is always
zero, although this contradicts what the
paper says.

12 years agohivex: Collect more statistics about registries.
Richard Jones [Mon, 18 Jan 2010 14:14:40 +0000 (14:14 +0000)]
hivex: Collect more statistics about registries.

12 years agohivex: Store filename in hive handle.
Richard Jones [Mon, 18 Jan 2010 10:58:06 +0000 (10:58 +0000)]
hivex: Store filename in hive handle.

12 years agoAdded Oriya translations (RHBZ#559498).
Richard Jones [Thu, 28 Jan 2010 10:46:01 +0000 (10:46 +0000)]
Added Oriya translations (RHBZ#559498).

Translation by Manoj Kumar Giri.

12 years agosupermin: Add special case for libgcc_s-*.so.N
Richard Jones [Thu, 28 Jan 2010 09:59:08 +0000 (09:59 +0000)]
supermin: Add special case for libgcc_s-*.so.N

Because this file contains the GCC version and a date, it frequently
changes on the host.  Create a special case so that this file is
matched using a wildcard for the version/date part of the name.

12 years agoAdded translations for Punjabi (pa-IN) (RHBZ#559480).
Richard Jones [Thu, 28 Jan 2010 09:49:27 +0000 (09:49 +0000)]
Added translations for Punjabi (pa-IN) (RHBZ#559480).

Translated by Jaswinder Singh.

Also updated pot files.

12 years agosupermin: Prevent multilib corruption (RHBZ#558593).
Richard Jones [Tue, 26 Jan 2010 10:45:14 +0000 (10:45 +0000)]
supermin: Prevent multilib corruption (RHBZ#558593).

On some combination of installing, upgrading and removing the base
libguestfs package on x86_64, multilib can corrupt libguestfs by
leaving a copy of /usr/bin/libguestfs-supermin-helper around which
references the wrong architecture (usually, contains links to the
i386-based appliance, when the x86_64 appliance should be constructed).

This commit changes libguestfs-supermin-helper so that the script is
the same on all architectures.  Instead, the library passes the
differences to the script (eg. $host_cpu).  Because the i386 and
x86_64 libraries should be at different locations (/usr/lib vs
/usr/lib64) this should prevent multilib from screwing things up.

Related links:

12 years agoAdded Telugu translations (RHBZ#559237).
Richard Jones [Wed, 27 Jan 2010 15:30:03 +0000 (15:30 +0000)]
Added Telugu translations (RHBZ#559237).

Also ran 'make -C po update-po' to update the POT file.

12 years agosupermin: Ignore more unreadable files found on RHEL 6.
Richard Jones [Mon, 25 Jan 2010 16:16:55 +0000 (16:16 +0000)]
supermin: Ignore more unreadable files found on RHEL 6.

12 years agoSync to latest Gnulib.
Richard Jones [Mon, 25 Jan 2010 12:22:36 +0000 (12:22 +0000)]
Sync to latest Gnulib.

12 years agoguestfish: Use xstrtol to parse integers (RHBZ#557655).
Richard Jones [Fri, 22 Jan 2010 11:01:06 +0000 (11:01 +0000)]
guestfish: Use xstrtol to parse integers (RHBZ#557655).

Current code uses atoi to parse the generator Int type and
atoll to parse the generator Int64 type.  The problem with the
ato* functions is that they don't cope with errors very well,
and they cannot parse numbers that begin with 0.. or 0x..
for octal and hexadecimal respectively.

This replaces the atoi call with a call to Gnulib xstrtol
and the atoll call with a call to Gnulib xstrtoll.

The generated code looks like this for all Int arguments:

    strtol_error xerr;
    long r;

    xerr = xstrtol (argv[0], NULL, 0, &r, "");
    if (xerr != LONGINT_OK) {
      fprintf (stderr,
               _("%s: %s: invalid integer parameter (%s returned %d)\n"),
               cmd, "memsize", "xstrtol", xerr);
      return -1;
    /* The Int type in the generator is a signed 31 bit int. */
    if (r < (-(2LL<<30)) || r > ((2LL<<30)-1)) {
      fprintf (stderr, _("%s: %s: integer out of range\n"), cmd, "memsize");
      return -1;
    /* The check above should ensure this assignment does not overflow. */
    memsize = r;

and like this for all Int64 arguments (note we don't need the
range check for these):

    strtol_error xerr;
    long long r;

    xerr = xstrtoll (argv[1], NULL, 0, &r, "");
    if (xerr != LONGINT_OK) {
      fprintf (stderr,
               _("%s: %s: invalid integer parameter (%s returned %d)\n"),
               cmd, "size", "xstrtoll", xerr);
      return -1;
    size = r;

Note this also fixes an unrelated bug in guestfish handling of
RBufferOut.  We were using 'fwrite' without checking the return
value, and this could have caused silent failures, eg. in the case
where there was not enough disk space to store the resulting file,
or even if the program was interrupted (but continued) during the

Replace this with Gnulib 'full-write', and check the return value
and report errors.

12 years agoAdd 'filesize' call.
Richard Jones [Mon, 25 Jan 2010 11:34:56 +0000 (11:34 +0000)]
Add 'filesize' call.

Returns the size of a file.  You can already do this with 'stat',
but this call is good for scripting.

12 years agoMissing crc kernel module on RHEL 6 / Linux 2.6.32 (fixes RHBZ#557195)
Richard Jones [Thu, 21 Jan 2010 10:54:34 +0000 (10:54 +0000)]
Missing crc kernel module on RHEL 6 / Linux 2.6.32 (fixes RHBZ#557195)

12 years agohivex: Various improvements in header parsing, thanks to better documentation.
Richard Jones [Fri, 15 Jan 2010 14:06:32 +0000 (14:06 +0000)]
hivex: Various improvements in header parsing, thanks to better documentation.

12 years agohivex: Print header fields. Print all offsets in hex (in debug output).
Richard Jones [Fri, 15 Jan 2010 12:42:02 +0000 (12:42 +0000)]
hivex: Print header fields.  Print all offsets in hex (in debug output).

12 years agohivex: Reenable checksum calculations, but don't check result.
Richard Jones [Fri, 15 Jan 2010 12:41:34 +0000 (12:41 +0000)]
hivex: Reenable checksum calculations, but don't check result.

12 years agohivex: Update documentation.
Richard Jones [Fri, 15 Jan 2010 12:40:56 +0000 (12:40 +0000)]
hivex: Update documentation.

12 years agohivex: Send all debug messages to stderr.
Richard Jones [Thu, 14 Jan 2010 16:46:13 +0000 (16:46 +0000)]
hivex: Send all debug messages to stderr.

12 years agohivex: Remove stray debugging message.
Richard Jones [Thu, 14 Jan 2010 16:45:59 +0000 (16:45 +0000)]
hivex: Remove stray debugging message.

12 years agohivex: Documentation: Add environment variables section.
Richard Jones [Thu, 14 Jan 2010 16:29:47 +0000 (16:29 +0000)]
hivex: Documentation: Add environment variables section.

12 years agohivex: Whitespace change.
Richard Jones [Thu, 14 Jan 2010 16:29:40 +0000 (16:29 +0000)]
hivex: Whitespace change.

12 years agohivex: Move STR* macros into C file.
Richard Jones [Thu, 14 Jan 2010 16:21:47 +0000 (16:21 +0000)]
hivex: Move STR* macros into C file.

Don't pollute the public header file with these macros.

12 years agohivex: Small updates to the documentation.
Richard Jones [Thu, 14 Jan 2010 13:26:46 +0000 (13:26 +0000)]
hivex: Small updates to the documentation.

12 years agoFix generation of HTML documentation for website.
Richard Jones [Wed, 13 Jan 2010 14:55:04 +0000 (14:55 +0000)]
Fix generation of HTML documentation for website.

12 years agoAdd guestfs.pod and guestfish.pod to EXTRA_DIST. 1.0.81
Richard Jones [Wed, 13 Jan 2010 13:08:30 +0000 (13:08 +0000)]
Add guestfs.pod and guestfish.pod to EXTRA_DIST.

12 years agoPrepare for version 1.0.81.
Richard Jones [Wed, 13 Jan 2010 13:03:28 +0000 (13:03 +0000)]
Prepare for version 1.0.81.

12 years agoUpdate to latest Gnulib.
Richard Jones [Wed, 13 Jan 2010 11:24:44 +0000 (11:24 +0000)]
Update to latest Gnulib.

12 years agoqemu: Upstream regression of -stdio serial option.
Richard Jones [Thu, 7 Jan 2010 12:21:42 +0000 (12:21 +0000)]
qemu: Upstream regression of -stdio serial option.

Best explained by the comment in the code:

    /* Newer versions of qemu (from around 2009/12) changed the
     * behaviour of monitors so that an implicit '-monitor stdio' is
     * assumed if we are in -nographic mode and there is no other
     * -monitor option.  Only a single stdio device is allowed, so
     * this broke the '-serial stdio' option.  There is a new flag
     * called -nodefaults which gets rid of all this default crud, so
     * let's use that to avoid this and any future surprises.

12 years agoinspector: Update example XML and RNG schema.
Richard Jones [Wed, 6 Jan 2010 09:55:57 +0000 (09:55 +0000)]
inspector: Update example XML and RNG schema.

This updates commit a59dcdbd1b0a28c960e3792165a13f2daf4f6c35.

12 years agoinspector: Make RPM application data more specific (RHBZ#552718).
Richard Jones [Tue, 5 Jan 2010 23:04:57 +0000 (23:04 +0000)]
inspector: Make RPM application data more specific (RHBZ#552718).

List applications with epoch, release and arch data.

If epoch is 0, don't store this as an empty string, but as
undefined, and don't output empty <epoch/> element in the XML.

12 years agoUse linker script to control visibility of symbols.
Richard Jones [Mon, 4 Jan 2010 15:39:49 +0000 (15:39 +0000)]
Use linker script to control visibility of symbols.

12 years agogenerator: Move all library generation code together.
Richard Jones [Mon, 4 Jan 2010 14:55:24 +0000 (14:55 +0000)]
generator: Move all library generation code together.

12 years agogenerator: Print total lines of generated code.
Richard Jones [Mon, 4 Jan 2010 14:40:08 +0000 (14:40 +0000)]
generator: Print total lines of generated code.

12 years agoC#: Add documentation about experimental nature of these bindings.
Richard Jones [Mon, 4 Jan 2010 14:51:36 +0000 (14:51 +0000)]
C#: Add documentation about experimental nature of these bindings.

12 years agoExperimental C# bindings.
Richard Jones [Sat, 2 Jan 2010 19:46:20 +0000 (19:46 +0000)]
Experimental C# bindings.

Tested in only limited situations, with Mono on Linux.

12 years agoUpdate copyright years.
Richard Jones [Sat, 2 Jan 2010 19:47:37 +0000 (19:47 +0000)]
Update copyright years.

12 years agoMove guestfs(3) and guestfish(1) man pages into subdirectories.
Richard Jones [Thu, 31 Dec 2009 12:26:04 +0000 (12:26 +0000)]
Move guestfs(3) and guestfish(1) man pages into subdirectories.

These manual pages have for a very long time 'lived' in the top
source directory.

Clean up this situation by moving those manual pages (plus associated
generated files) into the src/ and fish/ subdirectories respectively.

12 years agogenerator: Move src/guestfs-bindtests.c next to other src/ files.
Richard Jones [Thu, 31 Dec 2009 12:16:10 +0000 (12:16 +0000)]
generator: Move src/guestfs-bindtests.c next to other src/ files.

12 years agogenerator: Use Continuation Passing Style (CPS) in output_to function.
Richard Jones [Thu, 31 Dec 2009 11:51:48 +0000 (11:51 +0000)]
generator: Use Continuation Passing Style (CPS) in output_to function.

This makes the code simpler, shorter and less error-prone.

12 years agogenerator: Rename GPLv2 to GPLv2plus, LGPLv2 to LGPLv2plus.
Richard Jones [Thu, 31 Dec 2009 11:29:49 +0000 (11:29 +0000)]
generator: Rename GPLv2 to GPLv2plus, LGPLv2 to LGPLv2plus.

The licenses are "any later version", so reflect this in the
naming of the parameter to generate_header.

12 years agogenerated code: Set copyright years to 2009-xxxx when current year > 2009.
Richard Jones [Thu, 31 Dec 2009 11:22:26 +0000 (11:22 +0000)]
generated code: Set copyright years to 2009-xxxx when current year > 2009.

12 years agoRemove separate, combine this with
Richard Jones [Thu, 31 Dec 2009 11:20:56 +0000 (11:20 +0000)]
Remove separate, combine this with

This commit combines the previously separate ""
program which generated bindings for virt-inspector.

Having two separate programs caused no end of troubles for developers,
so we now combine them into a single program.

NOTE: OCaml xml-light is now *required* in order to rebuild the
generated code.

12 years agogenerator: Comment and whitespace changes only.
Richard Jones [Thu, 31 Dec 2009 10:52:08 +0000 (10:52 +0000)]
generator: Comment and whitespace changes only.

12 years agodaemon: Work around udevsettle issue (RHBZ#548121).
Richard Jones [Fri, 18 Dec 2009 19:20:37 +0000 (19:20 +0000)]
daemon: Work around udevsettle issue (RHBZ#548121).

12 years agoPrepare for 1.0.80. 1.0.80
Richard Jones [Wed, 16 Dec 2009 11:53:48 +0000 (11:53 +0000)]
Prepare for 1.0.80.

12 years agoInclude latest Polish translations (Piotr Drąg, RHBZ#502533).
Richard Jones [Wed, 16 Dec 2009 11:57:51 +0000 (11:57 +0000)]
Include latest Polish translations (Piotr Drąg, RHBZ#502533).

12 years agoUpdate PO files.
Richard Jones [Wed, 16 Dec 2009 11:55:21 +0000 (11:55 +0000)]
Update PO files.

12 years agobuild: Fix typo in filename.
Richard Jones [Wed, 16 Dec 2009 11:54:53 +0000 (11:54 +0000)]
build: Fix typo in filename.

12 years agobuild: Remove references to old contrib/ files which were removed.
Richard Jones [Wed, 16 Dec 2009 11:53:30 +0000 (11:53 +0000)]
build: Remove references to old contrib/ files which were removed.

12 years agoappliance: Special case handling for libbfd in the supermin appliance.
Richard Jones [Wed, 16 Dec 2009 11:15:26 +0000 (11:15 +0000)]
appliance: Special case handling for libbfd in the supermin appliance.

The libbfd library has a constantly changing, non-standard and
very long name, eg:


Just add a special case to deal with this.  This fixes the guestfs_strings
command, which relies on the external strings binary which uses this

12 years agoappliance: Ignore unreadable dbus helper programs.
Richard Jones [Wed, 16 Dec 2009 11:04:10 +0000 (11:04 +0000)]
appliance: Ignore unreadable dbus helper programs.

13 years agolib: Link with $(LTLIBTHREAD), required by Gnulib lock module.
Richard Jones [Mon, 7 Dec 2009 11:28:21 +0000 (11:28 +0000)]
lib: Link with $(LTLIBTHREAD), required by Gnulib lock module.

This fixes commit cada248a53858341c91f70392e8f5b6e47d9b4fe.

13 years agoappliance: Fix code which gets list of kernels.
Matthew Booth [Fri, 4 Dec 2009 15:38:09 +0000 (15:38 +0000)]
appliance: Fix code which gets list of kernels.

The first 'ls' command was failing, so the second 'ls' command
would never run at all.

13 years agoaccommodate leading "+" in git submodule output
Jim Meyering [Fri, 4 Dec 2009 15:34:41 +0000 (15:34 +0000)]
accommodate leading "+" in git submodule output

* (_submodule_hash): Also filter out "+".
* Likewise.

13 years agolib: Add thread-safety to global list of handles.
Richard Jones [Fri, 4 Dec 2009 14:35:55 +0000 (14:35 +0000)]
lib: Add thread-safety to global list of handles.

This commit uses the Gnulib 'lock' module to implement a mutex on
the global list of handles which is stored by the library.

Note that Gnulib nicely avoids explicitly linking with -lpthread
unless the application program itself links to -lpthread.  Locks
are only enabled in multithreaded applications.

$ ldd src/.libs/ =>  (0x00007fffcb7ff000) => /lib64/ (0x00007f96a4e6c000)
/lib64/ (0x00007f96a544d000)

Please enter the commit message for your changes. Lines starting

13 years agodaemon error handling: Define a new function reply_with_perror_errno.
Richard Jones [Mon, 30 Nov 2009 14:11:20 +0000 (14:11 +0000)]
daemon error handling: Define a new function reply_with_perror_errno.

This allows you to save the errno from a previous call and
pass it to reply_with_perror.

For example, original code:

  r = some_system_call ();
  err = errno;
  do_cleanup ();
  errno = err;
  if (r == -1) {
    reply_with_perror ("failed");
    return -1;

can in future be changed to:

  r = some_system_call ();
  err = errno;
  do_cleanup ();
  if (r == -1) {
    reply_with_perror_errno (err, "failed");
    return -1;

13 years agodaemon error handling: recursive_mkdir shouldn't need to set errno.
Richard Jones [Fri, 27 Nov 2009 14:14:21 +0000 (14:14 +0000)]
daemon error handling: recursive_mkdir shouldn't need to set errno.

13 years agodaemon error handling: Clear errno before calling stub functions.
Richard Jones [Mon, 30 Nov 2009 13:55:04 +0000 (13:55 +0000)]
daemon error handling: Clear errno before calling stub functions.

This just ensures that we accurately report errors, even if our
error path code doesn't set errno.  We won't end up with a bogus
errno left over from a previous call.

13 years agoWhitespace change.
Richard Jones [Fri, 27 Nov 2009 13:42:43 +0000 (13:42 +0000)]
Whitespace change.

13 years agovirt-rescue: Freshen documentation.
Richard Jones [Thu, 26 Nov 2009 22:33:52 +0000 (22:33 +0000)]
virt-rescue: Freshen documentation.

13 years agoguestfish: Freshen documentation.
Richard Jones [Thu, 26 Nov 2009 22:32:15 +0000 (22:32 +0000)]
guestfish: Freshen documentation.

13 years agodaemon: Move prototypes around to keep functions grouped logically.
Richard Jones [Thu, 26 Nov 2009 15:38:48 +0000 (15:38 +0000)]
daemon: Move prototypes around to keep functions grouped logically.

13 years agoFix error handling in 'zero' function.
Richard Jones [Thu, 26 Nov 2009 16:06:03 +0000 (16:06 +0000)]
Fix error handling in 'zero' function.

13 years agodaemon/Win32: Add contributed test script to test daemon using Wine.
Richard Jones [Thu, 26 Nov 2009 15:17:37 +0000 (15:17 +0000)]
daemon/Win32: Add contributed test script to test daemon using Wine.

This test script allows you to test limited features of the
Windows daemon by running it on a standard Fedora host using

Read contrib/README and contrib/ in detail
before using.

13 years agoIgnore guestfsd.exe (Windows daemon).
Richard Jones [Thu, 26 Nov 2009 14:42:54 +0000 (14:42 +0000)]
Ignore guestfsd.exe (Windows daemon).