libguestfs.git
14 years agogenerator: 'interface' is a reserved word in Java.
Richard Jones [Fri, 12 Feb 2010 11:46:40 +0000 (11:46 +0000)]
generator: 'interface' is a reserved word in Java.

14 years agoadd_cdrom: Update docs for adding ISO images.
Richard Jones [Fri, 12 Feb 2010 11:27:44 +0000 (11:27 +0000)]
add_cdrom: Update docs for adding ISO images.

See also RHBZ#563450 (NB: This commit does not fix the bug).

14 years agoUse mount-options instead of mount to avoid implicit -o sync.
Richard Jones [Tue, 9 Feb 2010 18:00:24 +0000 (18:00 +0000)]
Use mount-options instead of mount to avoid implicit -o sync.

guestfs_mount adds -o sync implicitly.  This causes a very large
performance problem for write-intensive programs (eg. virt-v2v).

Document this as a "gotcha".

Change the tests, guestfish, Sys::Guestfs::Lib, guestmount to use
mount-options instead.

(Note that this gotcha does not affect mount-ro).

The source of the performance problem was first identified by
Matthew Booth.

14 years agoAdd -enable-kvm option to qemu command line.
Richard Jones [Tue, 9 Feb 2010 16:30:18 +0000 (16:30 +0000)]
Add -enable-kvm option to qemu command line.

If the version of qemu being used supports -enable-kvm option,
then check if /dev/kvm is openable and add this option.

I have found this option makes no difference, although it is
*supposed* to enable KVM (hardware virtualization) support.

14 years agoNew API call: initrd-cat to list a file from an initrd.
Richard Jones [Tue, 9 Feb 2010 12:26:22 +0000 (12:26 +0000)]
New API call: initrd-cat to list a file from an initrd.

14 years agoRemove invalid Plural-Forms header from ml.po.
Richard Jones [Mon, 8 Feb 2010 22:51:19 +0000 (22:51 +0000)]
Remove invalid Plural-Forms header from ml.po.

14 years agoDocumentation: Added a section on libguestfs gotchas.
Richard Jones [Mon, 8 Feb 2010 16:44:41 +0000 (16:44 +0000)]
Documentation: Added a section on libguestfs gotchas.

14 years agoMake virtio block driver be the default for the appliance.
Richard Jones [Mon, 8 Feb 2010 10:18:31 +0000 (10:18 +0000)]
Make virtio block driver be the default for the appliance.

Previously this caused a serious performance regression,
but we believe this is now fixed:
https://bugzilla.redhat.com/show_bug.cgi?id=509383

14 years agoAdded Malayalam translations (RHBZ#562710).
Ani Peter [Mon, 8 Feb 2010 10:06:32 +0000 (10:06 +0000)]
Added Malayalam translations (RHBZ#562710).

14 years agoDistribute hivexsh.1.html HTML file.
Richard Jones [Fri, 5 Feb 2010 18:54:52 +0000 (18:54 +0000)]
Distribute hivexsh.1.html HTML file.

14 years agoUpdate PO files. 1.0.83
Richard Jones [Fri, 5 Feb 2010 18:40:14 +0000 (18:40 +0000)]
Update PO files.

14 years agoRHEL5: Keep old automake happy by defining docdir
Richard W.M. Jones [Fri, 5 Feb 2010 17:02:47 +0000 (17:02 +0000)]
RHEL5: Keep old automake happy by defining docdir

14 years agoAdd scripts to EXTRA_DIST.
Richard Jones [Fri, 5 Feb 2010 18:01:18 +0000 (18:01 +0000)]
Add scripts to EXTRA_DIST.

14 years agoUpdate PO files.
Richard Jones [Fri, 5 Feb 2010 17:19:30 +0000 (17:19 +0000)]
Update PO files.

14 years agoPrepare for version 1.0.83.
Richard Jones [Fri, 5 Feb 2010 17:19:21 +0000 (17:19 +0000)]
Prepare for version 1.0.83.

14 years agoAdd files to EXTRA_DIST.
Richard Jones [Fri, 5 Feb 2010 17:19:01 +0000 (17:19 +0000)]
Add files to EXTRA_DIST.

14 years agohivex: example6: Don't double backslashes.
Richard Jones [Fri, 5 Feb 2010 15:12:09 +0000 (15:12 +0000)]
hivex: example6: Don't double backslashes.

14 years agohivex: example6: Hypothetical addition of keys for viostor.
Richard Jones [Fri, 5 Feb 2010 15:05:36 +0000 (15:05 +0000)]
hivex: example6: Hypothetical addition of keys for viostor.

14 years agohivex: Fix handling of inline VKs.
Richard Jones [Fri, 5 Feb 2010 14:50:19 +0000 (14:50 +0000)]
hivex: Fix handling of inline VKs.

14 years agohivexsh: Set correct type for 'expandstring' values.
Richard Jones [Fri, 5 Feb 2010 13:47:32 +0000 (13:47 +0000)]
hivexsh: Set correct type for 'expandstring' values.

14 years agohivex: Documentation and cleanups.
Richard Jones [Fri, 5 Feb 2010 12:59:43 +0000 (12:59 +0000)]
hivex: Documentation and cleanups.

14 years agohivex: Make limits into macros.
Richard Jones [Fri, 5 Feb 2010 12:59:18 +0000 (12:59 +0000)]
hivex: Make limits into macros.

14 years agohivexsh: Remove unused variable.
Richard Jones [Fri, 5 Feb 2010 12:57:53 +0000 (12:57 +0000)]
hivexsh: Remove unused variable.

This removes an unused variable left over by
commit ab608f3948d903af64e814b2e67949a1a71d93a4.

14 years agohivex: Complete the implementation of adding child nodes.
Richard Jones [Thu, 4 Feb 2010 16:33:18 +0000 (16:33 +0000)]
hivex: Complete the implementation of adding child nodes.

14 years agohivex: More debugging around nk 'unknown2' field.
Richard Jones [Thu, 4 Feb 2010 18:42:58 +0000 (18:42 +0000)]
hivex: More debugging around nk 'unknown2' field.

14 years agohivex: Check hash fields in lf/lh records.
Richard Jones [Thu, 4 Feb 2010 17:59:11 +0000 (17:59 +0000)]
hivex: Check hash fields in lf/lh records.

14 years agohivexsh: del command: Fix error message.
Richard Jones [Thu, 4 Feb 2010 16:32:22 +0000 (16:32 +0000)]
hivexsh: del command: Fix error message.

14 years agohivexsh: lsval: Remove stray quotation mark.
Richard Jones [Thu, 4 Feb 2010 16:31:55 +0000 (16:31 +0000)]
hivexsh: lsval: Remove stray quotation mark.

14 years agohivexsh: cd command: fix error handling
Richard Jones [Thu, 4 Feb 2010 16:31:09 +0000 (16:31 +0000)]
hivexsh: cd command: fix error handling

The error behaviour of hivex_node_get_child is subtle, so the 'cd'
command wouldn't always report errors correctly.  This fixes it.

14 years agohivex: allocate_block should update valid block bitmap.
Richard Jones [Thu, 4 Feb 2010 16:29:32 +0000 (16:29 +0000)]
hivex: allocate_block should update valid block bitmap.

The internal allocate_block() function wasn't updating the bitmap,
so if you revisited a block which you had allocated in the same
session, you could get an EFAULT error.

14 years agohivex: More debug messages.
Richard Jones [Thu, 4 Feb 2010 16:29:11 +0000 (16:29 +0000)]
hivex: More debug messages.

14 years agohivex: Documentation update.
Richard Jones [Thu, 4 Feb 2010 16:28:26 +0000 (16:28 +0000)]
hivex: Documentation update.

ntreg_lf_record can have id "lf" (old-style hashes) or "lh" (new-
style hashes).

14 years agohivex: Some missing le32toh endianness conversions.
Richard Jones [Thu, 4 Feb 2010 16:27:58 +0000 (16:27 +0000)]
hivex: Some missing le32toh endianness conversions.

14 years agohivexsh: Document some peculiarities of the "cd" command.
Richard Jones [Thu, 4 Feb 2010 14:12:04 +0000 (14:12 +0000)]
hivexsh: Document some peculiarities of the "cd" command.

14 years agohivex: Implement deleting child nodes.
Richard Jones [Wed, 3 Feb 2010 18:10:38 +0000 (18:10 +0000)]
hivex: Implement deleting child nodes.

14 years agohivex: Add flags argument to internal get_children() function.
Richard Jones [Thu, 4 Feb 2010 13:24:27 +0000 (13:24 +0000)]
hivex: Add flags argument to internal get_children() function.

When we later call get_children to visit the intermediate
ri/lf/lh records, we have already deleted the subkey nk-records,
so checking that those nk-records are still valid is not very
helpful.

This commit adds a flag to turn these checks off.

14 years agohivex: Don't die on valid registries which have bad declared data lengths.
Richard Jones [Thu, 4 Feb 2010 13:26:04 +0000 (13:26 +0000)]
hivex: Don't die on valid registries which have bad declared data lengths.

Some apparently valid registries contain value data length
declarations which exceed the allocated block size for the
value.

Previously the code would return EFAULT for such registries.
However since these appear to be otherwise valid registries,
turn this into a warning and just use the allocated block size
as the data length (in other words, truncate the value).

14 years agohivex: Minimal registry example.
Richard Jones [Wed, 3 Feb 2010 18:09:52 +0000 (18:09 +0000)]
hivex: Minimal registry example.

This is the smallest registry you can make and still have it
load correctly in Windows regedit.

14 years agohivexsh: Add 'setval' and 'commit' commands.
Richard Jones [Wed, 3 Feb 2010 18:04:31 +0000 (18:04 +0000)]
hivexsh: Add 'setval' and 'commit' commands.

This adds the 'setval' and 'commit' commands to the hivex shell.

Also adds some example scripts showing use of these.

14 years agohivex: Begin implementation of writing to hives.
Richard Jones [Wed, 3 Feb 2010 17:59:03 +0000 (17:59 +0000)]
hivex: Begin implementation of writing to hives.

This implements hivex_node_set_values which is used to
delete the (key, value) pairs at a node and optionally
replace them with a new set.

This also implements hivex_commit which is used to commit
changes to hives back to disk.

14 years agohivex: Add HIVEX_OPEN_WRITE flag to allow hive to be opened for writing.
Richard Jones [Mon, 18 Jan 2010 11:08:56 +0000 (11:08 +0000)]
hivex: Add HIVEX_OPEN_WRITE flag to allow hive to be opened for writing.

If this flag is omitted (as in the case for all existing callers)
then the hive is still opened read-only.

We add a 'writable' flag to the hive handle, and we change the way
that the hive file (data) is stored.  The data is still mmapped if
the file is opened read-only, since that is more efficient and allows
us to handle larger hives.  However if we need to write to the file
then we have to read it all into memory, since if we had to extend the
file we need to realloc that data.

Note the manpage section L</WRITING TO HIVE FILES> comes in a later
commit.

14 years agoTools for analyzing and reverse engineering hive files.
Richard Jones [Wed, 3 Feb 2010 17:35:53 +0000 (17:35 +0000)]
Tools for analyzing and reverse engineering hive files.

This commit is not of general interest.  It contains the tools which
I used to reverse engineer the hive format and to test changes.
Keeping these with the rest of the code is useful in case in future
we encounter a hive file that we fail to modify.

Note that the tools are not compiled by default.  You have to compile
each explicitly with:

  make -C hivex/tools <toolname>.opt

You will also need ocaml-extlib-devel and ocaml-bitstring-devel.

14 years agohivexsh: Change some exit(1) -> exit(EXIT_FAILURE)
Richard Jones [Wed, 3 Feb 2010 17:52:05 +0000 (17:52 +0000)]
hivexsh: Change some exit(1) -> exit(EXIT_FAILURE)

14 years agohivexsh: Only print final \n when interactive.
Richard Jones [Wed, 3 Feb 2010 17:50:51 +0000 (17:50 +0000)]
hivexsh: Only print final \n when interactive.

When hivexsh was called non-interactively, it would print an
annoying extra line.  Only print this line if we are being
used interactively.

14 years agohivexsh: Change handling of prompt argument to rl_gets()
Richard Jones [Wed, 3 Feb 2010 17:48:37 +0000 (17:48 +0000)]
hivexsh: Change handling of prompt argument to rl_gets()

Make the result of isatty into a global variable (is_tty).

Change the rl_gets() function so it takes the prompt string
instead of a "display prompt?" flag.  rl_gets() then consults
the global to find out if it should display the prompt at all.

14 years agoDocument that this flag is clear for default keys.
Richard Jones [Wed, 3 Feb 2010 17:45:20 +0000 (17:45 +0000)]
Document that this flag is clear for default keys.

14 years agoMisc documentation and gitignore update.
Richard Jones [Wed, 3 Feb 2010 17:44:39 +0000 (17:44 +0000)]
Misc documentation and gitignore update.

14 years agoMove htole*/le*toh macros into a separate header file.
Richard Jones [Wed, 3 Feb 2010 17:41:15 +0000 (17:41 +0000)]
Move htole*/le*toh macros into a separate header file.

This allows us to reuse these macros in hivexsh later.

14 years agoAdd Marathi translations (RHBZ#561671).
Sandeep Shedmake [Thu, 4 Feb 2010 08:50:14 +0000 (08:50 +0000)]
Add Marathi translations (RHBZ#561671).

14 years agoPolish translations (RHBZ#502533).
Piotr Drąg [Tue, 2 Feb 2010 22:08:24 +0000 (22:08 +0000)]
Polish translations (RHBZ#502533).

14 years agoUpdate PO files.
Richard Jones [Tue, 2 Feb 2010 08:49:56 +0000 (08:49 +0000)]
Update PO files.

14 years agoAdd Gujarti translations (Sweta Kothari) (RHBZ#560918).
Richard Jones [Tue, 2 Feb 2010 08:49:10 +0000 (08:49 +0000)]
Add Gujarti translations (Sweta Kothari) (RHBZ#560918).

14 years agoUpdate Oriya translations (thanks Manoj Kumar Giri) (RHBZ#559498).
Richard Jones [Mon, 1 Feb 2010 14:50:19 +0000 (14:50 +0000)]
Update Oriya translations (thanks Manoj Kumar Giri) (RHBZ#559498).

14 years agohivex: Reimplement hivexget as a simple shell script.
Richard Jones [Fri, 29 Jan 2010 19:12:34 +0000 (19:12 +0000)]
hivex: Reimplement hivexget as a simple shell script.

hivexget is currently a large C program.  Now that we have hivexsh
(the shell) we can reimplement hivexget as a simple bash script that
calls out to hivexsh.

14 years agohivex: Add 'hivexsh' program (shell for navigating registry hives).
Richard Jones [Fri, 29 Jan 2010 12:18:30 +0000 (12:18 +0000)]
hivex: Add 'hivexsh' program (shell for navigating registry hives).

14 years agoSet locale in C programs so l10n works (RHBZ#559962).
Richard Jones [Fri, 29 Jan 2010 14:56:13 +0000 (14:56 +0000)]
Set locale in C programs so l10n works (RHBZ#559962).

This commit adds the calls to setlocale &c to all of the current
C programs.

It also adds l10n support to hivexget and hivexml which lacked them
previously.

To test this, try:

LANG=pa_IN.UTF-8 guestfish --cmd-help

(You can only do this test after installing the package, or at
least the 'pa.mo' mo-file in the correct place).

14 years agoAnother unreadable file: /var/log/yum.log
Richard Jones [Fri, 29 Jan 2010 14:24:54 +0000 (14:24 +0000)]
Another unreadable file: /var/log/yum.log

14 years agoUpdate PO files.
Richard Jones [Fri, 29 Jan 2010 09:57:37 +0000 (09:57 +0000)]
Update PO files.

14 years agoAdd Tamil translation (RHBZ#559877) (thanks to I.Felix)
Richard Jones [Fri, 29 Jan 2010 09:57:12 +0000 (09:57 +0000)]
Add Tamil translation (RHBZ#559877) (thanks to I.Felix)

14 years agoUpdate Punjabi translation (RHBZ#559480) (thanks Jaswinder Singh)
Richard Jones [Fri, 29 Jan 2010 09:46:52 +0000 (09:46 +0000)]
Update Punjabi translation (RHBZ#559480) (thanks Jaswinder Singh)

14 years agoFix regressions/rhbz557655.sh when debugging is enabled (v2).
Richard Jones [Fri, 29 Jan 2010 09:02:14 +0000 (09:02 +0000)]
Fix regressions/rhbz557655.sh when debugging is enabled (v2).

The previous fix didn't cope with ordinary warnings emitted by
qemu (eg. "open /dev/kvm: No such file or directory").  This
is a hopefully more complete fix for the problem.

See also commit 3cd7ce75f1ce5048a4d9f6aeaf66aff3194e1096.

14 years agoFix regressions/rhbz557655.sh when debugging is enabled.
Richard Jones [Thu, 28 Jan 2010 22:35:16 +0000 (22:35 +0000)]
Fix regressions/rhbz557655.sh when debugging is enabled.

The regression test for RHBZ#557655 would fail if debugging was
enabled, because debug output would get mixed up with the test
output.

To reproduce the error do:

LIBGUESTFS_DEBUG=1 make -C regressions TESTS=rhbz557655.sh check

This commit disables debug for just this test.

14 years agoImplement 'vgrename' and 'lvrename' APIs.
Richard Jones [Thu, 28 Jan 2010 22:06:27 +0000 (22:06 +0000)]
Implement 'vgrename' and 'lvrename' APIs.

14 years agoVersion 1.0.82. 1.0.82
Richard Jones [Thu, 28 Jan 2010 19:28:21 +0000 (19:28 +0000)]
Version 1.0.82.

14 years agohivex: Const-correctness fix on header_checksum (thanks Jim Meyering).
Richard Jones [Thu, 28 Jan 2010 17:39:06 +0000 (17:39 +0000)]
hivex: Const-correctness fix on header_checksum (thanks Jim Meyering).

14 years agohivex: Update some previously unknown nk-record fields.
Richard Jones [Thu, 28 Jan 2010 16:25:19 +0000 (16:25 +0000)]
hivex: Update some previously unknown nk-record fields.

Update these fields with what we found out from reverse engineering
the file.  Also bring the unknownX field names into line with
visualizer.ml.

14 years agohivex: Fix calculation of block size for vk data blocks.
Richard Jones [Thu, 21 Jan 2010 17:07:42 +0000 (17:07 +0000)]
hivex: Fix calculation of block size for vk data blocks.

14 years agohivex: Display incorrect block size as unsigned in an error message.
Richard Jones [Thu, 21 Jan 2010 17:07:21 +0000 (17:07 +0000)]
hivex: Display incorrect block size as unsigned in an error message.

14 years agohivex: display bad block offset in hex
Richard Jones [Thu, 21 Jan 2010 16:19:49 +0000 (16:19 +0000)]
hivex: display bad block offset in hex

14 years agohivex: hive type in vk-record is an unsigned 32 bit int
Richard Jones [Thu, 21 Jan 2010 16:19:26 +0000 (16:19 +0000)]
hivex: hive type in vk-record is an unsigned 32 bit int

14 years agohivex: Add missing le32toh conversion around field access.
Richard Jones [Tue, 19 Jan 2010 15:21:06 +0000 (15:21 +0000)]
hivex: Add missing le32toh conversion around field access.

This was missing.  It only worked because we test on a little
endian platform.

14 years agohivex: Clarify some more fields.
Richard Jones [Tue, 19 Jan 2010 15:20:36 +0000 (15:20 +0000)]
hivex: Clarify some more fields.

Taken from sentinelchicken.com documentation.

14 years agohivex: Modify children/values functions to return intermediate blocks.
Richard Jones [Tue, 19 Jan 2010 12:22:10 +0000 (12:22 +0000)]
hivex: Modify children/values functions to return intermediate blocks.

Modify the functions that return child subnodes and values so they
can also be used to return a list of the intermediate blocks.  This
is so we can delete those intermediate blocks (in a later commit).

We also introduce an offset_list structure which is used for collecting
lists of offsets, ie. lists of nodes, values or blocks.

Note that this commit should not change the semantics of the code.

14 years agohivex: Add value_any callback to the visitor.
Richard Jones [Tue, 19 Jan 2010 10:06:00 +0000 (10:06 +0000)]
hivex: Add value_any callback to the visitor.

The visitor currently contains lots of value_* callbacks, such as
value_string which is called back when the value has type string.

This is fine but it makes it complicated to deal with the case where
you just want to see 'a value', and don't care about its type.

The value_any callback allows visitors to see values generically.

14 years agohivex: Move header checksum code into a function.
Richard Jones [Mon, 18 Jan 2010 17:56:13 +0000 (17:56 +0000)]
hivex: Move header checksum code into a function.

This function can be reused later.

14 years agohivex: page 'offset_next' field is really 'page_size'.
Richard Jones [Mon, 18 Jan 2010 15:24:16 +0000 (15:24 +0000)]
hivex: page 'offset_next' field is really 'page_size'.

The documentation, as usual, is contradictory.  However this
field is definitely the page size in all observed registries.
Furthermore the following field marked 'unknown' is always
zero, although this contradicts what the sentinelchicken.com
paper says.

14 years agohivex: Collect more statistics about registries.
Richard Jones [Mon, 18 Jan 2010 14:14:40 +0000 (14:14 +0000)]
hivex: Collect more statistics about registries.

14 years agohivex: Store filename in hive handle.
Richard Jones [Mon, 18 Jan 2010 10:58:06 +0000 (10:58 +0000)]
hivex: Store filename in hive handle.

14 years agoAdded Oriya translations (RHBZ#559498).
Richard Jones [Thu, 28 Jan 2010 10:46:01 +0000 (10:46 +0000)]
Added Oriya translations (RHBZ#559498).

Translation by Manoj Kumar Giri.

14 years agosupermin: Add special case for libgcc_s-*.so.N
Richard Jones [Thu, 28 Jan 2010 09:59:08 +0000 (09:59 +0000)]
supermin: Add special case for libgcc_s-*.so.N

Because this file contains the GCC version and a date, it frequently
changes on the host.  Create a special case so that this file is
matched using a wildcard for the version/date part of the name.

14 years agoAdded translations for Punjabi (pa-IN) (RHBZ#559480).
Richard Jones [Thu, 28 Jan 2010 09:49:27 +0000 (09:49 +0000)]
Added translations for Punjabi (pa-IN) (RHBZ#559480).

Translated by Jaswinder Singh.

Also updated pot files.

14 years agosupermin: Prevent multilib corruption (RHBZ#558593).
Richard Jones [Tue, 26 Jan 2010 10:45:14 +0000 (10:45 +0000)]
supermin: Prevent multilib corruption (RHBZ#558593).

On some combination of installing, upgrading and removing the base
libguestfs package on x86_64, multilib can corrupt libguestfs by
leaving a copy of /usr/bin/libguestfs-supermin-helper around which
references the wrong architecture (usually, contains links to the
i386-based appliance, when the x86_64 appliance should be constructed).

This commit changes libguestfs-supermin-helper so that the script is
the same on all architectures.  Instead, the library passes the
differences to the script (eg. $host_cpu).  Because the i386 and
x86_64 libraries should be at different locations (/usr/lib vs
/usr/lib64) this should prevent multilib from screwing things up.

Related links:
https://bugzilla.redhat.com/show_bug.cgi?id=558593
http://rwmj.wordpress.com/2009/11/16/please-someone-shoot-multilib/#content
https://bugzilla.redhat.com/show_bug.cgi?id=235752

14 years agoAdded Telugu translations (RHBZ#559237).
Richard Jones [Wed, 27 Jan 2010 15:30:03 +0000 (15:30 +0000)]
Added Telugu translations (RHBZ#559237).

Also ran 'make -C po update-po' to update the POT file.

14 years agosupermin: Ignore more unreadable files found on RHEL 6.
Richard Jones [Mon, 25 Jan 2010 16:16:55 +0000 (16:16 +0000)]
supermin: Ignore more unreadable files found on RHEL 6.

14 years agoSync to latest Gnulib.
Richard Jones [Mon, 25 Jan 2010 12:22:36 +0000 (12:22 +0000)]
Sync to latest Gnulib.

14 years agoguestfish: Use xstrtol to parse integers (RHBZ#557655).
Richard Jones [Fri, 22 Jan 2010 11:01:06 +0000 (11:01 +0000)]
guestfish: Use xstrtol to parse integers (RHBZ#557655).

Current code uses atoi to parse the generator Int type and
atoll to parse the generator Int64 type.  The problem with the
ato* functions is that they don't cope with errors very well,
and they cannot parse numbers that begin with 0.. or 0x..
for octal and hexadecimal respectively.

This replaces the atoi call with a call to Gnulib xstrtol
and the atoll call with a call to Gnulib xstrtoll.

The generated code looks like this for all Int arguments:

  {
    strtol_error xerr;
    long r;

    xerr = xstrtol (argv[0], NULL, 0, &r, "");
    if (xerr != LONGINT_OK) {
      fprintf (stderr,
               _("%s: %s: invalid integer parameter (%s returned %d)\n"),
               cmd, "memsize", "xstrtol", xerr);
      return -1;
    }
    /* The Int type in the generator is a signed 31 bit int. */
    if (r < (-(2LL<<30)) || r > ((2LL<<30)-1)) {
      fprintf (stderr, _("%s: %s: integer out of range\n"), cmd, "memsize");
      return -1;
    }
    /* The check above should ensure this assignment does not overflow. */
    memsize = r;
  }

and like this for all Int64 arguments (note we don't need the
range check for these):

  {
    strtol_error xerr;
    long long r;

    xerr = xstrtoll (argv[1], NULL, 0, &r, "");
    if (xerr != LONGINT_OK) {
      fprintf (stderr,
               _("%s: %s: invalid integer parameter (%s returned %d)\n"),
               cmd, "size", "xstrtoll", xerr);
      return -1;
    }
    size = r;
  }

Note this also fixes an unrelated bug in guestfish handling of
RBufferOut.  We were using 'fwrite' without checking the return
value, and this could have caused silent failures, eg. in the case
where there was not enough disk space to store the resulting file,
or even if the program was interrupted (but continued) during the
write.

Replace this with Gnulib 'full-write', and check the return value
and report errors.

14 years agoAdd 'filesize' call.
Richard Jones [Mon, 25 Jan 2010 11:34:56 +0000 (11:34 +0000)]
Add 'filesize' call.

Returns the size of a file.  You can already do this with 'stat',
but this call is good for scripting.

14 years agoMissing crc kernel module on RHEL 6 / Linux 2.6.32 (fixes RHBZ#557195)
Richard Jones [Thu, 21 Jan 2010 10:54:34 +0000 (10:54 +0000)]
Missing crc kernel module on RHEL 6 / Linux 2.6.32 (fixes RHBZ#557195)

14 years agohivex: Various improvements in header parsing, thanks to better documentation.
Richard Jones [Fri, 15 Jan 2010 14:06:32 +0000 (14:06 +0000)]
hivex: Various improvements in header parsing, thanks to better documentation.

14 years agohivex: Print header fields. Print all offsets in hex (in debug output).
Richard Jones [Fri, 15 Jan 2010 12:42:02 +0000 (12:42 +0000)]
hivex: Print header fields.  Print all offsets in hex (in debug output).

14 years agohivex: Reenable checksum calculations, but don't check result.
Richard Jones [Fri, 15 Jan 2010 12:41:34 +0000 (12:41 +0000)]
hivex: Reenable checksum calculations, but don't check result.

14 years agohivex: Update documentation.
Richard Jones [Fri, 15 Jan 2010 12:40:56 +0000 (12:40 +0000)]
hivex: Update documentation.

14 years agohivex: Send all debug messages to stderr.
Richard Jones [Thu, 14 Jan 2010 16:46:13 +0000 (16:46 +0000)]
hivex: Send all debug messages to stderr.

14 years agohivex: Remove stray debugging message.
Richard Jones [Thu, 14 Jan 2010 16:45:59 +0000 (16:45 +0000)]
hivex: Remove stray debugging message.

14 years agohivex: Documentation: Add environment variables section.
Richard Jones [Thu, 14 Jan 2010 16:29:47 +0000 (16:29 +0000)]
hivex: Documentation: Add environment variables section.

14 years agohivex: Whitespace change.
Richard Jones [Thu, 14 Jan 2010 16:29:40 +0000 (16:29 +0000)]
hivex: Whitespace change.

14 years agohivex: Move STR* macros into C file.
Richard Jones [Thu, 14 Jan 2010 16:21:47 +0000 (16:21 +0000)]
hivex: Move STR* macros into C file.

Don't pollute the public header file with these macros.

14 years agohivex: Small updates to the documentation.
Richard Jones [Thu, 14 Jan 2010 13:26:46 +0000 (13:26 +0000)]
hivex: Small updates to the documentation.

14 years agoFix generation of HTML documentation for website.
Richard Jones [Wed, 13 Jan 2010 14:55:04 +0000 (14:55 +0000)]
Fix generation of HTML documentation for website.

14 years agoAdd guestfs.pod and guestfish.pod to EXTRA_DIST. 1.0.81
Richard Jones [Wed, 13 Jan 2010 13:08:30 +0000 (13:08 +0000)]
Add guestfs.pod and guestfish.pod to EXTRA_DIST.