Comment: compare_values should be able to promote numeric types.

diff --git a/lib/whenutils.ml b/lib/whenutils.ml
index 2db4103..aa59f18 100644 (file)
--- a/lib/whenutils.ml
+++ b/lib/whenutils.ml
@@ -533,6 +533,7 @@ and compare_values value1 value2 =
   | T_string s1, T_string s2 -> compare s1 s2
   | T_int i1, T_int i2 -> compare_big_int i1 i2
   | T_float f1, T_float f2 -> compare f1 f2
   | T_string s1, T_string s2 -> compare s1 s2
   | T_int i1, T_int i2 -> compare_big_int i1 i2
   | T_float f1, T_float f2 -> compare f1 f2

+    (* XXX BUG: int should be promoted to float in mixed numeric comparison *)

   | _ ->
     let value1 = string_of_variable value1
     and value2 = string_of_variable value2 in
   | _ ->
     let value1 = string_of_variable value1
     and value2 = string_of_variable value2 in