libguestfs.git
9 years agoNew APIs: Support for creating LUKS and managing keys.
Richard Jones [Thu, 22 Jul 2010 10:00:59 +0000 (11:00 +0100)]
New APIs: Support for creating LUKS and managing keys.

This commit adds four APIs for creating new LUKS devices
and key management.  These are:

  luks_format         Format a LUKS device with the default cipher.
  luks_format_cipher  Format with a chosen cipher.
  luks_add_key        Add another key to an existing device.
  luks_kill_slot      Delete a key from an existing device.

This enables all the significant functionality of the
cryptsetup luks* commands.

Note that you can obtain the UUID of a LUKS device already
by using vfs-uuid.

This also includes a regression test covering all the LUKS
functions.

9 years agoMove variable initialization close to variable use.
Richard Jones [Thu, 22 Jul 2010 15:51:05 +0000 (16:51 +0100)]
Move variable initialization close to variable use.

9 years agoRevert "add_drive_ro adds readonly=on option if available." (RHBZ#617200).
Richard Jones [Thu, 22 Jul 2010 13:39:36 +0000 (14:39 +0100)]
Revert "add_drive_ro adds readonly=on option if available." (RHBZ#617200).

Adding the readonly=on option is not so clever.  This causes
qemu to present the disk as read-only to the guest.  (The
expected behaviour of snapshots=on,readonly=on was that it
would open the disk O_RDONLY but present a writable disk to
the guest).

Since the guest sees a read-only disk, we are unable to do any
recovery if a filesystem on the disk is inconsistent.  This basically
prevents most accesses to live disk images.

What we really want is a qemu option which presents a writable
disk to the guest, but only opens the disk on the host side with
O_RDONLY, to alleviate the udev bug RHBZ#571714.

This reverts commit 676462684e05dd8341dd695762dd99a87d8ec022.

9 years agogenerator: Make documentation inside guestfish match man page.
Richard Jones [Thu, 22 Jul 2010 09:59:43 +0000 (10:59 +0100)]
generator: Make documentation inside guestfish match man page.

9 years agoVersion 1.5.1. 1.5.1
Richard Jones [Wed, 21 Jul 2010 20:40:21 +0000 (21:40 +0100)]
Version 1.5.1.

9 years agoNew APIs: Support for opening LUKS-encrypted disks.
Richard Jones [Wed, 21 Jul 2010 18:50:06 +0000 (19:50 +0100)]
New APIs: Support for opening LUKS-encrypted disks.

This adds support for opening LUKS-encrypted disks, via
three new APIs:

  luks_open:    Create a mapping for an encrypted disk.
  luks_open_ro: Same, but read-only mapping.
  luks_close:   Close a mapping.

A typical guestfish session using this functionality looks
like this:

  $ guestfish --ro -a encrypted.img
  ><fs> run
  ><fs> list-devices
  /dev/vda
  ><fs> list-partitions
  /dev/vda1
  /dev/vda2
  ><fs> vfs-type /dev/vda2
  crypto_LUKS
  ><fs> luks-open /dev/vda2 luksdev
  Enter key or passphrase ("key"):
  ><fs> vgscan
  ><fs> vg-activate-all true
  ><fs> pvs
  /dev/dm-0
  ><fs> vgs
  vg_f13x64encrypted
  ><fs> lvs
  /dev/vg_f13x64encrypted/lv_root
  /dev/vg_f13x64encrypted/lv_swap
  ><fs> mount /dev/vg_f13x64encrypted/lv_root /
  ><fs> ll /
  total 132
  dr-xr-xr-x.  24 root root  4096 Jul 21 12:01 .
  dr-xr-xr-x   20 root root     0 Jul 21 20:06 ..
  drwx------.   3 root root  4096 Jul 21 11:59 .dbus
  drwx------.   2 root root  4096 Jul 21 12:00 .pulse
  -rw-------.   1 root root   256 Jul 21 12:00 .pulse-cookie
  dr-xr-xr-x.   2 root root  4096 May 13 03:03 bin

NOT included in this patch:

 - An easier way to use this from guestfish.
 - Ability to create LUKS devices.
 - Ability to change LUKS keys on existing devices.
 - Direct access to the /dev/mapper device (eg. if it contains
   anything apart from VGs).

9 years agogenerator: Add 'Key' parameter type.
Richard Jones [Wed, 21 Jul 2010 11:52:51 +0000 (12:52 +0100)]
generator: Add 'Key' parameter type.

Add a 'Key' parameter type, used for passing sensitive key material
into libguestfs.

Eventually the plan is to mlock() key material into memory.  However
this is very difficult to achieve because the encoded XDR strings
end up in many places.  Therefore users should note that key material
passed to libguestfs might end up in swap.

The only difference between 'Key' and 'String' currently is that
guestfish requests the key from /dev/tty with echoing turned off.

9 years agogenerator: Remove unnecessary parameter.
Richard Jones [Wed, 21 Jul 2010 11:52:10 +0000 (12:52 +0100)]
generator: Remove unnecessary parameter.

The 'name' parameter is not used on the right hand side of the
match, so it can be removed.

9 years agodf: Minimize the number of times we launch the libguestfs appliance.
Richard Jones [Fri, 16 Jul 2010 17:11:56 +0000 (18:11 +0100)]
df: Minimize the number of times we launch the libguestfs appliance.

This commit greatly improves the performance of the 'virt-df'
command by batching as many disks as possible onto a single appliance.
In many situations this means the appliance is launched only once,
versus one launch per domain as before.

However doing it this way is a lot more complex:

(1) Because of limits in Linux and virtio-blk, we can only attach
26 disks maximum at a time to the appliance.

(2) We have to use LVM filters (lvm-set-filter) to confine LVM to
the disks of a single guest.

9 years agoNew APIs: lvm-set-filter and lvm-clear-filter.
Richard Jones [Fri, 16 Jul 2010 12:01:21 +0000 (13:01 +0100)]
New APIs: lvm-set-filter and lvm-clear-filter.

These APIs allow you to change the device filter, the list of
block devices that LVM "sees".  Either you can set it to a fixed
list of devices / partitions, or you can clear it so that LVM sees
everything.

9 years agoUse an unsigned type (size_t) for all loop iterators.
Richard Jones [Fri, 16 Jul 2010 11:58:54 +0000 (12:58 +0100)]
Use an unsigned type (size_t) for all loop iterators.

This resolves a warning from gcc 4.5:
  assuming signed overflow does not occur when simplifying
    conditional to constant

This page explains the issues in some detail:
  http://www.airs.com/blog/archives/120

9 years agogenerator: Don't hard-code name in DeviceList check.
Richard Jones [Fri, 16 Jul 2010 11:57:24 +0000 (12:57 +0100)]
generator: Don't hard-code name in DeviceList check.

Only one function currently uses DeviceList.  The generated code
unfortunately hard-coded the argument name from that function.

9 years agobuild: Don't warn about 'long long'.
Richard Jones [Fri, 16 Jul 2010 11:55:17 +0000 (12:55 +0100)]
build: Don't warn about 'long long'.

Various language bindings simply need this, so we have to allow
it even though it's a GCC extension.

9 years agodoc: Add guestfish 'lvcreate 1M' gotcha.
Richard Jones [Fri, 16 Jul 2010 14:17:01 +0000 (15:17 +0100)]
doc: Add guestfish 'lvcreate 1M' gotcha.

9 years agotar: Remove redundant use statement.
Richard Jones [Sun, 11 Jul 2010 22:11:45 +0000 (23:11 +0100)]
tar: Remove redundant use statement.

9 years agoedit: Clean up temporary files.
Richard Jones [Sun, 11 Jul 2010 22:11:08 +0000 (23:11 +0100)]
edit: Clean up temporary files.

Note to self: The 'tempfile' function does *not* default to
removing files with the program exits!

9 years agoedit: Add -b (backup) option and make uploading more robust.
Richard Jones [Sun, 11 Jul 2010 22:09:07 +0000 (23:09 +0100)]
edit: Add -b (backup) option and make uploading more robust.

9 years agoedit: Add -e 'expr' option to non-interactively apply expression to the file.
Richard Jones [Sun, 11 Jul 2010 15:46:15 +0000 (16:46 +0100)]
edit: Add -e 'expr' option to non-interactively apply expression to the file.

(Suggested by Justin Clift).

9 years agoPrepare for new development branch, starting at 1.5.0.
Richard Jones [Thu, 8 Jul 2010 10:54:50 +0000 (11:54 +0100)]
Prepare for new development branch, starting at 1.5.0.

Add BUGS and RELEASE-NOTES to EXTRA_DIST.

Also update the RELEASE-NOTES file.

9 years agoMake tmp directory world readable (RHBZ#610880).
Richard Jones [Fri, 2 Jul 2010 16:52:51 +0000 (17:52 +0100)]
Make tmp directory world readable (RHBZ#610880).

If you have a restrictive umask (0077 for example) then
files in the tmp directory would be created with 0600
permissions.  Example:

drwx------.  2 rjones rjones     4096 Jul  2 17:52 .
drwxrwxrwt. 57 root   root     102400 Jul  2 17:52 ..
-rw-------.  1 rjones rjones 86328832 Jul  2 17:52 initrd
lrwxrwxrwx.  1 rjones rjones       46 Jul  2 17:52 kernel -> /boot/vmlinuz-2.6.33-0.40.rc7.git0.fc13.x86_64

This in itself is not a problem.  However in virt-v2v we also
change UID:GID and the result is that qemu is unable to read
the initrd file:

qemu: could not load initial ram disk '/tmp/libguestfs2ssynP/initrd'

With this patch we make the tmp directory and the files
world readable.  After the patch:

$ ls -la /tmp/libguestfsJFVzPg/
total 116192
drwxr-xr-x.  2 rjones rjones      4096 Jul  2 18:03 .
drwxrwxrwt. 56 root   root      102400 Jul  2 18:03 ..
-rw-r--r--.  1 rjones rjones 118869504 Jul  2 18:03 initrd
lrwxrwxrwx.  1 rjones rjones        46 Jul  2 18:03 kernel -> /boot/vmlinuz-2.6.33-0.40.rc7.git0.fc13.x86_64

9 years agofish: Don't fail if -m and --listen flags are both given (RHBZ#612178).
Richard Jones [Wed, 7 Jul 2010 14:01:38 +0000 (15:01 +0100)]
fish: Don't fail if -m and --listen flags are both given (RHBZ#612178).

Testing this against a Fedora disk image:

$ ./fish/guestfish --ro -a F13.img -m /dev/sda1 --listen
export GUESTFISH_PID=6033
$ ./fish/guestfish --remote=6033 -- ping-daemon
$ ./fish/guestfish --remote=6033 -- ping-daemon
$ ./fish/guestfish --remote=6033 -- exit

Without this fix the first remote command would fail because
qemu would have already been killed.

9 years agotodo: Add comment about progress of long-running operations.
Richard Jones [Fri, 2 Jul 2010 19:12:41 +0000 (20:12 +0100)]
todo: Add comment about progress of long-running operations.

9 years agoinspector: Improve error message when YAML::Any library is not installed.
Richard Jones [Fri, 2 Jul 2010 09:50:38 +0000 (10:50 +0100)]
inspector: Improve error message when YAML::Any library is not installed.

9 years agoExplicitly depend on e2fsprogs.
Richard Jones [Mon, 28 Jun 2010 12:51:42 +0000 (13:51 +0100)]
Explicitly depend on e2fsprogs.

See: http://lists.fedoraproject.org/pipermail/devel/2010-June/137953.html

9 years agoFix gfs2 support by adding required kernel modules.
Richard Jones [Mon, 28 Jun 2010 08:13:36 +0000 (09:13 +0100)]
Fix gfs2 support by adding required kernel modules.

9 years agoVersion 1.3.21. 1.3.21
Richard Jones [Wed, 16 Jun 2010 15:12:52 +0000 (16:12 +0100)]
Version 1.3.21.

9 years agoocaml: Fix thread safety of strings in bindings (RHBZ#604691).
Richard Jones [Wed, 16 Jun 2010 14:25:45 +0000 (15:25 +0100)]
ocaml: Fix thread safety of strings in bindings (RHBZ#604691).

There's a thread safety issue with the current OCaml bindings which
is well explained in the bug report:

https://bugzilla.redhat.com/show_bug.cgi?id=604691

This commit fixes the safety issue by copying strings temporarily
before releasing the thread lock.  Updated code looks like this:

  char *filename = guestfs_safe_strdup (g, String_val (filenamev));
  int r;

  caml_enter_blocking_section ();
  r = guestfs_add_drive_ro (g, filename);
  caml_leave_blocking_section ();
  free (filename);
  if (r == -1)
    ocaml_guestfs_raise_error (g, "add_drive_ro");

Also included is a regression test.

9 years agoTODO: Add a note about impl of list-filesystems.
Richard Jones [Wed, 16 Jun 2010 13:29:39 +0000 (14:29 +0100)]
TODO: Add a note about impl of list-filesystems.

9 years agotodo: More ideas for TODO list.
Richard Jones [Tue, 15 Jun 2010 10:15:30 +0000 (11:15 +0100)]
todo: More ideas for TODO list.

9 years agoUpdate Spanish translations (RHBZ#603870).
Richard Jones [Tue, 15 Jun 2010 10:15:06 +0000 (11:15 +0100)]
Update Spanish translations (RHBZ#603870).

9 years agoperl: Check all images are defined in first param of open_guest.
Richard Jones [Fri, 11 Jun 2010 09:40:48 +0000 (10:40 +0100)]
perl: Check all images are defined in first param of open_guest.

9 years agoperl: Add explicit close() method (RHBZ#602592).
Richard Jones [Thu, 10 Jun 2010 14:25:43 +0000 (15:25 +0100)]
perl: Add explicit close() method (RHBZ#602592).

This add an optional explicit $g->close method which may be
used to force the handle to be closed immediately.  Note the
provisos about this method in the manual page entry.  Callers
should *not* normally use this method.

The implementation of the handle also changes.  Before, the
handle was a blessed reference to an integer (the integer
being the pointer to the C guestfs_h handle).  Now we change
this to a hashref containing currently the following field:

  _g => pointer to C guestfs_h handle (as an integer)

If this field is not present, it means that the handle has been
explicitly closed.  This avoids double-freeing the handle.

The user may add their own fields to this hash in order to store
per-handle data.  However any fields whose names begin with
an underscore are reserved for use by the Perl bindings.

This commit also adds a regression test.

This commit also changes the existing warning when you call
a method without a Sys::Guestfs handle as the first parameter,
into an error.  This is because such cases are always errors.

9 years agoAdd error callback (RHBZ#602599).
Richard Jones [Thu, 10 Jun 2010 11:38:57 +0000 (12:38 +0100)]
Add error callback (RHBZ#602599).

Read the note in the man page before using this feature.

9 years agoFix typo in documentation of guestfs_set_launch_done_callback.
Richard Jones [Thu, 10 Jun 2010 11:26:06 +0000 (12:26 +0100)]
Fix typo in documentation of guestfs_set_launch_done_callback.

9 years agoVersion 1.3.20. 1.3.20
Richard Jones [Tue, 8 Jun 2010 17:17:37 +0000 (18:17 +0100)]
Version 1.3.20.

9 years agoRevert "perl: Rerun configure if MAX_PROC_NR changes."
Richard Jones [Tue, 8 Jun 2010 17:17:46 +0000 (18:17 +0100)]
Revert "perl: Rerun configure if MAX_PROC_NR changes."

This reverts commit f8ee7869f4836427109959cf20e299a31fa86eaf.

9 years agoTODO: Freeze/thaw filesystems.
Richard Jones [Tue, 8 Jun 2010 17:12:32 +0000 (18:12 +0100)]
TODO: Freeze/thaw filesystems.

9 years agoTODO: Need to add regression test for virt-inspector.
Richard Jones [Tue, 8 Jun 2010 17:11:16 +0000 (18:11 +0100)]
TODO: Need to add regression test for virt-inspector.

9 years agoTODO: 'file' command should be fixed.
Richard Jones [Tue, 8 Jun 2010 17:04:17 +0000 (18:04 +0100)]
TODO: 'file' command should be fixed.

9 years agovirt-df: Disallow -h and --csv options together (RHBZ#600977).
Richard Jones [Tue, 8 Jun 2010 15:44:18 +0000 (16:44 +0100)]
virt-df: Disallow -h and --csv options together (RHBZ#600977).

Before this commit, if you used the -h and --csv options together
you would get these warnings from virt-df:

$ virt-df -h --csv Guest
Virtual Machine,Filesystem,Size,Used,Available,Use%
Argument "13.5G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "4.7G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "8.1G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
"/dev/vg_trick/RHEL55x64","/dev/VolGroup00/LogVol00",13,4,8,34.8%
Argument "98.7M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "18.8M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "74.9M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
"/dev/vg_trick/RHEL55x64","/dev/vda1",98,18,74,19.0%

We could fix this so that the human-readable numbers get written
into the CSV file.  However would probably be wrong for most uses
of the CSV format (databases and spreadsheets) since they would not
be able to interpret these human-readable numbers, or worse could
misinterpret, eg. thinking that "1M" and "1G" are both 1.

Therefore this commit disallows this combination of options.

9 years agofile: Fix file command on /dev/VG/LV paths (RHBZ#582484).
Richard Jones [Tue, 8 Jun 2010 15:04:01 +0000 (16:04 +0100)]
file: Fix file command on /dev/VG/LV paths (RHBZ#582484).

Previous commit 4df593496e116dfb635731c058b7627e81fc179c broke the
"file" command on logical volume paths, since these are symbolic
links.  We *should* follow these (only).

This inadvertantly broke virt-inspector too, which indicates that
we need more regression testing in this area.  Since carrying whole
Fedora images around could make the distribution even larger than
now, I'm not sure at the moment how to do this.

Thanks to Matt Booth for diagnosing this bug.

9 years agoUse the noop scheduler inside the appliance.
Richard Jones [Mon, 7 Jun 2010 14:29:31 +0000 (15:29 +0100)]
Use the noop scheduler inside the appliance.

In my limited tests, this seems to make a small but noticable
difference, improving the performance of some straightforward
read operations by a little over 10%.

For more information see:
http://kbase.redhat.com/faq/docs/DOC-5428

9 years agoAdd release notes.
Richard Jones [Fri, 4 Jun 2010 17:44:49 +0000 (18:44 +0100)]
Add release notes.

To generate the "Bugs fixed" list, run the bugs-in-changelog script
like this:

  ./bugs-in-changelog 1.0.89..

9 years agoVersion 1.3.19. 1.3.19
Richard Jones [Fri, 4 Jun 2010 15:38:55 +0000 (16:38 +0100)]
Version 1.3.19.

Update BUGS and PO files.

9 years agofile: Restrict to regular files (RHBZ#582484).
Richard Jones [Fri, 4 Jun 2010 10:45:06 +0000 (11:45 +0100)]
file: Restrict to regular files (RHBZ#582484).

The file call can hang if called on char devices (because we are
using the file -s option).

This is hard to solve cleanly without adding another file API.

However this restricts file to regular files, unless called explicitly
with a /dev/ path.  For non-regular files, it will now return a
string like "directory".

There is a small semantic change for symbolic links.  Previously
it would not have worked at all on absolute links (or rather, the
results would have been undefined).  It would have treated relative
symlinks to regular files as the regular file itself.  Now it will
return the string "symbolic link" in both cases.

This commit also makes the API safe when called on untrusted
filesystems.  Previously a filesystem might have been set up so
that (eg) /etc/redhat-release was a char device, which would have
caused virt-inspector and virt-v2v to hang.  Now it will not hang.

9 years agotouch: Restrict touch to regular files only (RHBZ#582484).
Richard Jones [Fri, 4 Jun 2010 10:55:54 +0000 (11:55 +0100)]
touch: Restrict touch to regular files only (RHBZ#582484).

9 years agodaemon: Rearrange code in 'file' command.
Richard Jones [Fri, 4 Jun 2010 10:23:01 +0000 (11:23 +0100)]
daemon: Rearrange code in 'file' command.

  path = path to access file (/sysroot/.. or /dev/..)
  display_path = original path, saved so we can display it
  buf = optional buffer which is freed along return codepaths

There should be no change to the semantics of the code.

9 years agognulib: Ignore asm-underscore.m4 in the correct place.
Richard Jones [Fri, 4 Jun 2010 10:21:58 +0000 (11:21 +0100)]
gnulib: Ignore asm-underscore.m4 in the correct place.

9 years agoUpdate to latest gnulib.
Richard Jones [Fri, 4 Jun 2010 08:46:34 +0000 (09:46 +0100)]
Update to latest gnulib.

9 years agomkfs-b: Map block size to cluster size for VFAT and NTFS partitions (RHBZ#599464).
Richard Jones [Thu, 3 Jun 2010 13:03:08 +0000 (14:03 +0100)]
mkfs-b: Map block size to cluster size for VFAT and NTFS partitions (RHBZ#599464).

This also adds a regression test for VFAT and (conditionally)
NTFS filesystems.

9 years agomkfs-b: Check that blocksize parameter is > 0 and a power of 2.
Richard Jones [Thu, 3 Jun 2010 13:01:18 +0000 (14:01 +0100)]
mkfs-b: Check that blocksize parameter is > 0 and a power of 2.

9 years agogenerator: Allow individual tests to depend on daemon features.
Richard Jones [Thu, 3 Jun 2010 13:31:58 +0000 (14:31 +0100)]
generator: Allow individual tests to depend on daemon features.

Using IfAvailable "featurename" we allow individual tests to
only run if the feature is available in the daemon.

This will allow us to extend testing to a lot more optional
features such as NTFS.

9 years agotests: Factor out common code into 'is_available' function.
Richard Jones [Thu, 3 Jun 2010 13:30:36 +0000 (14:30 +0100)]
tests: Factor out common code into 'is_available' function.

This commit is just code motion.

9 years agogrub-install: Enable grub-install tests and create explicit device.map file.
Richard Jones [Thu, 3 Jun 2010 10:49:38 +0000 (11:49 +0100)]
grub-install: Enable grub-install tests and create explicit device.map file.

9 years agogrub-install: In docs suggest manually creating device.map (RHBZ#484986).
Richard Jones [Thu, 3 Jun 2010 10:48:41 +0000 (11:48 +0100)]
grub-install: In docs suggest manually creating device.map (RHBZ#484986).

9 years agoVersion 1.3.18. 1.3.18
Richard Jones [Wed, 2 Jun 2010 17:47:30 +0000 (18:47 +0100)]
Version 1.3.18.

Update BUGS and PO files.

9 years agoRHEL 6: sr_mod.ko is needed for RHEL 6 to see CD-ROM devices (RHBZ#598807).
Richard Jones [Wed, 2 Jun 2010 16:12:59 +0000 (17:12 +0100)]
RHEL 6: sr_mod.ko is needed for RHEL 6 to see CD-ROM devices (RHBZ#598807).

9 years agoparted: Check partition number >= 1 in several calls.
Richard Jones [Wed, 2 Jun 2010 14:35:58 +0000 (15:35 +0100)]
parted: Check partition number >= 1 in several calls.

9 years agodaemon: Parse output of old parted which didn't support -m option (RHBZ#598309).
Richard Jones [Wed, 2 Jun 2010 11:32:33 +0000 (12:32 +0100)]
daemon: Parse output of old parted which didn't support -m option (RHBZ#598309).

This fixes the following commands when run with RHEL 5-era parted:

  get-bootable
  get-parttype
  part-list

9 years agodaemon: count_strings function returns size_t
Richard Jones [Wed, 2 Jun 2010 11:31:40 +0000 (12:31 +0100)]
daemon: count_strings function returns size_t

9 years agobase64-in: Ignore garbage characters in input.
Richard Jones [Wed, 2 Jun 2010 14:10:38 +0000 (15:10 +0100)]
base64-in: Ignore garbage characters in input.

On RHEL 5 you have to specify the -i option to get the
external 'base64' command to ignore \n characters.  (The
Fedora version seems to ignore these characters anyway).

Add this option so the tests can pass on RHEL 5.

9 years agoresize2fs: Document this command also works with ext4 (thanks Yufang Zhang).
Richard Jones [Wed, 2 Jun 2010 12:27:19 +0000 (13:27 +0100)]
resize2fs: Document this command also works with ext4 (thanks Yufang Zhang).

9 years agofish: help command return error for non-existent commands (RHBZ#597145).
Richard Jones [Tue, 1 Jun 2010 15:27:33 +0000 (16:27 +0100)]
fish: help command return error for non-existent commands (RHBZ#597145).

With this change, the exit status indicates error for non-existent
commands.

$ guestfish -h foo
foo: command not known, use -h to list all commands
$ echo $?
1
$ guestfish help foo
foo: command not known, use -h to list all commands
$ echo $?
1

9 years agodaemon: write-file: Check range of size parameter (RHBZ#597135).
Richard Jones [Tue, 1 Jun 2010 15:18:53 +0000 (16:18 +0100)]
daemon: write-file: Check range of size parameter (RHBZ#597135).

This also adds a regression test.

9 years agodaemon: Limit label lengths (RHBZ#597118).
Richard Jones [Tue, 1 Jun 2010 14:50:14 +0000 (15:50 +0100)]
daemon: Limit label lengths (RHBZ#597118).

9 years agoUpdate BUGS and PO files.
Richard Jones [Wed, 2 Jun 2010 12:36:19 +0000 (13:36 +0100)]
Update BUGS and PO files.

9 years agoFix and deprecate get_e2label and get_e2uuid (RHBZ#597112).
Richard Jones [Tue, 1 Jun 2010 13:04:51 +0000 (14:04 +0100)]
Fix and deprecate get_e2label and get_e2uuid (RHBZ#597112).

Fix these calls (see description in RHBZ#597112), but also
deprecate them since the new calls vfs_label and vfs_uuid can
work on any filesystem type.

This also adds a regression test for the original bug reported
in RHBZ#597112.

9 years agoNew APIs: vfs-label and vfs-uuid return label and uuid for many fs types.
Richard Jones [Tue, 1 Jun 2010 12:57:12 +0000 (13:57 +0100)]
New APIs: vfs-label and vfs-uuid return label and uuid for many fs types.

These APIs generalize the existing 'get-e2label' and 'get-e2uuid'
calls, to provide calls which should be able to get the label
and UUID for most filesystem types.  These use 'blkid' to do the
work.

I have tested that the blkid commands themselves work on RHEL 5.

(Suggested by Yufang Zhang).

9 years agodaemon: Kill blkid cache to improve reliability of blkid commands.
Richard Jones [Tue, 1 Jun 2010 14:27:57 +0000 (15:27 +0100)]
daemon: Kill blkid cache to improve reliability of blkid commands.

By killing the cache file, we make blkid work in situations such
as a just-created filesystem.

9 years agodaemon: Generalize the implementation of vfs-type.
Richard Jones [Tue, 1 Jun 2010 12:39:25 +0000 (13:39 +0100)]
daemon: Generalize the implementation of vfs-type.

Note that there is no change to the semantics of the code.

9 years agotodo: Should generate -N option.
Richard Jones [Fri, 28 May 2010 19:08:01 +0000 (20:08 +0100)]
todo: Should generate -N option.

9 years agotodo: Remove implemented resize functions from TODO file.
Richard Jones [Fri, 28 May 2010 19:05:56 +0000 (20:05 +0100)]
todo: Remove implemented resize functions from TODO file.

9 years agoMake the supermin appliance include local augeas lenses
Matthew Booth [Thu, 27 May 2010 14:47:51 +0000 (15:47 +0100)]
Make the supermin appliance include local augeas lenses

9 years agoRely on new augeas lens for modules.conf and conf.modules
Matthew Booth [Thu, 27 May 2010 14:47:50 +0000 (15:47 +0100)]
Rely on new augeas lens for modules.conf and conf.modules

Latest augeas includes a lens for /etc/modules.conf. If this new lens is
present, the code to force the Modprobe lens to try to match /etc/modules.conf
as well results in /etc/modules.conf not being parsed at all. This results in
modprobe_aliases in virt-inspector output being empty.

This change is equivalent to change cfd28d1140393667913689b7b9bcf21c8bfe592c
from virt-v2v.

An effect of this change is that the Modules_conf augeas lens is now required
for correct operation on guests which use /etc/modules.conf.

Fixes RHBZ#596776

9 years agoUpdates to Spanish translation (RHBZ#596763).
Daniel Cabrera [Thu, 27 May 2010 14:20:37 +0000 (15:20 +0100)]
Updates to Spanish translation (RHBZ#596763).

9 years agoVersion 1.3.17. 1.3.17
Richard Jones [Thu, 27 May 2010 11:03:43 +0000 (12:03 +0100)]
Version 1.3.17.

9 years agoFix documentation for vfs-type to reflect reality.
Richard Jones [Thu, 27 May 2010 09:37:43 +0000 (10:37 +0100)]
Fix documentation for vfs-type to reflect reality.

9 years agoClarify documentation on distro backports in version command.
Richard Jones [Thu, 27 May 2010 09:32:51 +0000 (10:32 +0100)]
Clarify documentation on distro backports in version command.

9 years agoAdd reference to version number documentation to version command.
Richard Jones [Thu, 27 May 2010 09:31:07 +0000 (10:31 +0100)]
Add reference to version number documentation to version command.

9 years agoClarify sparse behaviour of truncate-size command.
Richard Jones [Thu, 27 May 2010 09:25:18 +0000 (10:25 +0100)]
Clarify sparse behaviour of truncate-size command.

9 years agoFix typo in documentation of guestfs_readlinklist.
Richard Jones [Thu, 27 May 2010 09:03:47 +0000 (10:03 +0100)]
Fix typo in documentation of guestfs_readlinklist.

9 years agoFix missing word in docuentation of guestfs_readdir.
Richard Jones [Thu, 27 May 2010 09:01:25 +0000 (10:01 +0100)]
Fix missing word in docuentation of guestfs_readdir.

9 years agoRevise documentation on creating files.
Richard Jones [Thu, 27 May 2010 08:49:28 +0000 (09:49 +0100)]
Revise documentation on creating files.

9 years agoNew API: fallocate64 (replaces fallocate).
Richard Jones [Thu, 27 May 2010 08:48:22 +0000 (09:48 +0100)]
New API: fallocate64 (replaces fallocate).

guestfs_fallocate takes an integer for the length, effectively
limiting it to creating 1GB files.  This new call takes an int64_t
for the length, but is otherwise identical.

9 years agoFix typo in description of echo-daemon command.
Richard Jones [Wed, 26 May 2010 22:42:43 +0000 (23:42 +0100)]
Fix typo in description of echo-daemon command.

9 years agoVersion 1.3.16. 1.3.16
Richard Jones [Tue, 25 May 2010 22:17:58 +0000 (23:17 +0100)]
Version 1.3.16.

9 years agoAdd bash complation script to EXTRA_DIST.
Richard Jones [Tue, 25 May 2010 22:16:23 +0000 (23:16 +0100)]
Add bash complation script to EXTRA_DIST.

9 years agoVersion 1.3.15. 1.3.15
Richard Jones [Tue, 25 May 2010 21:45:45 +0000 (22:45 +0100)]
Version 1.3.15.

9 years agoAdd tests for available-all-groups command.
Richard Jones [Tue, 25 May 2010 21:24:12 +0000 (22:24 +0100)]
Add tests for available-all-groups command.

9 years agofish: First pass at guestfish bash completion script.
Richard Jones [Tue, 25 May 2010 19:13:55 +0000 (20:13 +0100)]
fish: First pass at guestfish bash completion script.

9 years agofish: Don't eat words when completing case-insensitive paths (RHBZ#582993).
Richard Jones [Tue, 25 May 2010 12:54:11 +0000 (13:54 +0100)]
fish: Don't eat words when completing case-insensitive paths (RHBZ#582993).

9 years agofish: Sort returned paths so the list is stable across multiple calls.
Richard Jones [Tue, 25 May 2010 12:52:53 +0000 (13:52 +0100)]
fish: Sort returned paths so the list is stable across multiple calls.

9 years agofish: Document test1.img, test2.img etc used by -N option in FILES section.
Richard Jones [Tue, 25 May 2010 12:52:17 +0000 (13:52 +0100)]
fish: Document test1.img, test2.img etc used by -N option in FILES section.

9 years agofish: Create a separate FILES section in the manpage.
Richard Jones [Tue, 25 May 2010 12:51:58 +0000 (13:51 +0100)]
fish: Create a separate FILES section in the manpage.

9 years agofish: Move 'EXIT CODE' section to a more logical place in the documentation.
Richard Jones [Tue, 25 May 2010 12:41:39 +0000 (13:41 +0100)]
fish: Move 'EXIT CODE' section to a more logical place in the documentation.

9 years agoresize: Refresh the examples in the documentation.
Richard Jones [Tue, 25 May 2010 10:45:23 +0000 (11:45 +0100)]
resize: Refresh the examples in the documentation.

The documentation was previously very intimidating.  Bring some
common, simple examples up to the top of the page in a separate
section.

9 years agofish: Make the read/write warning more prominent.
Richard Jones [Tue, 25 May 2010 10:44:43 +0000 (11:44 +0100)]
fish: Make the read/write warning more prominent.

Follow the example on other manual pages by making the warning
more prominent.

9 years agofish: New command: 'supported'
Richard Jones [Tue, 25 May 2010 10:28:09 +0000 (11:28 +0100)]
fish: New command: 'supported'

This checks all available optional groups and prints out which
ones are supported by the daemon.  Note you must launch the appliance
first.

Example:

><fs> supported
      augeas yes
     inotify yes
 linuxfsuuid yes
linuxmodules yes
 linuxxattrs yes
        lvm2 yes
       mknod yes
      ntfs3g yes
   ntfsprogs yes
    realpath yes
       scrub yes
     selinux yes
          xz yes
    zerofree yes

9 years agoNew API: available-all-groups to return list of all optional groups.
Richard Jones [Tue, 25 May 2010 10:27:49 +0000 (11:27 +0100)]
New API: available-all-groups to return list of all optional groups.

9 years agoperl: Rerun configure if MAX_PROC_NR changes.
Richard Jones [Tue, 25 May 2010 10:25:12 +0000 (11:25 +0100)]
perl: Rerun configure if MAX_PROC_NR changes.

If MAX_PROC_NR changes (because a new API has been added to the
generator) then we need to rerun configure in order to set the
Makefile's ${MAX_PROC_NR} variable, in order to rebuild Makefile.PL.