13 years agoFix networking in the appliance.
Matthew Booth [Wed, 27 Oct 2010 09:55:24 +0000 (10:55 +0100)]
Fix networking in the appliance.

Commit 4963be85 re-introduced networking to the appliance,
but didn't configure the custom network the appliance expects
since we switched to link local addressing. This patch
configures QEMU to use the custom network again.

Note that you still need to use guestfs_set_network (g, 1)
to enable user networking.

13 years agoDon't include control characters in BufferIn trace output (RHBZ#646822).
Matthew Booth [Tue, 26 Oct 2010 12:54:17 +0000 (13:54 +0100)]
Don't include control characters in BufferIn trace output (RHBZ#646822).

The example below shows what the output looks like for a large
random buffer.

$ guestfish -N fs -m /dev/sda1 -x -- \
    touch /test : \
    pwrite /test "$(dd if=/dev/urandom bs=128k count=1)" 0
pwrite "/test" "\x7f\xa0/\xb3\x80\xd3\xbc\xc3\xc3.\xb1\xe0\x1b\xafC\x06\xd5;\x0ajJ[o\xc1\xdd\xae\x1f\xce\xb2\x8d\xb3\xd0\x11\xcc$%\xe6<\xc7\xc7\xe7BU*\xc4l%\xaa\xea\xe9\x1an\xda]\xc6I\x0eC\xf9;\xec\x12a\x1f\xeaRH\xb2P\xd6+\xc4\xe6\xa5bW\x99\\x9d\xc8\x9bJ\xef\x99-\x16:h5\xe2\x0f\xa2\xa08\x9bU\x0b$\x138\xcf\xd4j\x9b\x83{%\xac0\xdaa1Xx\xbd`\x8e\xdd\x82\x87\x07\x98\xd2\x9ed\x8bq\xd0\x1f5\x8f\xab\xad4z1\xda\xc4b\xc1\xbc\x0f\xaa\xea\xc1\x15(\xfd1\xc2\x0bF\xe6\x9e\xb0+/g\\xab\xb0b\xde_\xca\xf9\xad\xe1?%\x17\xad\x98\xa4e\xc1\xe0f'\x89\xe9>\xff\xadhYi\xe7\x8c]%\xef\xe0\xa1R\xe5\xd5\x03K\xefI\xdf\xad\xd3\x82\xdb\x0f\xdd\xc3\x8f"\xf1G\xea\xf9r\xdd\xff\x88\x81\xb7\xf2\x0e\x0f\x1d;:\xf2F1\xdb\xb5D\xa1^\x928\xf5\x8e)\xab\xc4\xc3H(\xd0ol\xc6\xe4\xd6\xa3L\x1c\x06\xf4"<truncated, original size 130567 bytes> 0

13 years agodaemon: Print failed path in stat command errors.
Richard W.M. Jones [Mon, 25 Oct 2010 11:54:59 +0000 (12:54 +0100)]
daemon: Print failed path in stat command errors.

13 years agofish: Fix too-short allocation in tilde expansion (RHBZ#636061).
Karel Klíč [Mon, 25 Oct 2010 11:48:36 +0000 (12:48 +0100)]
fish: Fix too-short allocation in tilde expansion (RHBZ#636061).

13 years agoUpdate Polish translations (RHBZ#502533).
Piotr Drąg [Sat, 23 Oct 2010 11:52:35 +0000 (12:52 +0100)]
Update Polish translations (RHBZ#502533).

13 years agofish: Quote optional argument name in error message.
Richard W.M. Jones [Sat, 23 Oct 2010 09:45:25 +0000 (10:45 +0100)]
fish: Quote optional argument name in error message.

13 years agofish: Reject unknown opt args (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Sat, 23 Oct 2010 09:45:06 +0000 (10:45 +0100)]
fish: Reject unknown opt args (RHBZ#642934,CVE-2010-3851).

This updates commit 0c1d3c02a8147617ee0646e37d011235abdd2c22.

13 years agofuse: Add --format option to docs (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Sat, 23 Oct 2010 09:23:45 +0000 (10:23 +0100)]
fuse: Add --format option to docs (RHBZ#642934,CVE-2010-3851).

This updates commit 44c5ee1163918bd5c9e6aa6c292f0c3bb15b7b25.

Document the --format option in the guestmount manual page.

13 years agoVersion 1.5.23. 1.5.23
Richard W.M. Jones [Fri, 22 Oct 2010 22:12:16 +0000 (23:12 +0100)]
Version 1.5.23.

13 years agoresize: Specify format of input, output disk (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Fri, 22 Oct 2010 11:48:25 +0000 (12:48 +0100)]
resize: Specify format of input, output disk (RHBZ#642934,CVE-2010-3851).

This adds two new options: --format specifies the format of the
input disk, and --output-format specified the format of the output

Requiring the format of the output disk seems a bit strange at first:
after all, this is the disk that the virt-resize user has to create.
However it is needed because we sometimes reopen this disk, after
copying data over the first sector, and in theory a raw-format guest
could write a qcow2 header here and have it copied to the output
disk, which we would subsequently reopen.

13 years agovirt-make-fs: Specify format of disk (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Thu, 21 Oct 2010 22:33:15 +0000 (23:33 +0100)]
virt-make-fs: Specify format of disk (RHBZ#642934,CVE-2010-3851).

13 years agodf: Specify format of disks (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Thu, 21 Oct 2010 22:06:24 +0000 (23:06 +0100)]
df: Specify format of disks (RHBZ#642934,CVE-2010-3851).

The format parameter is taken from libvirt if available, else
the user should supply the '--format' parameter (eg. for local
disk files).

13 years agotools: Specify format of disks (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Fri, 22 Oct 2010 09:59:53 +0000 (10:59 +0100)]
tools: Specify format of disks (RHBZ#642934,CVE-2010-3851).

Sys::Guestfs::Lib is changed in two ways: firstly we take the format
string from libvirt and pass it to add_drive_opts.  Secondly we allow
an extra format =>  parameter to open_guest which allows the
format to be specified for disk images.

All the tools are changed to add an extra --format parameter allowing
the format to be specified for direct disk images.

13 years agofuse: Specify format of disks (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Fri, 22 Oct 2010 14:01:55 +0000 (15:01 +0100)]
fuse: Specify format of disks (RHBZ#642934,CVE-2010-3851).

For command line disk images, specify the format using --format option
in the same way as for guestfish.

13 years agofish: Specify format of disks (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Thu, 21 Oct 2010 22:05:26 +0000 (23:05 +0100)]
fish: Specify format of disks (RHBZ#642934,CVE-2010-3851).

For libvirt guests, the disk format is copied from libvirt (if
libvirt knows it).

For command line disk images, you can use --format to override
format auto-detection.

13 years agogenerator: Optional arguments, add-drive-opts (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Wed, 20 Oct 2010 10:34:57 +0000 (11:34 +0100)]
generator: Optional arguments, add-drive-opts (RHBZ#642934,CVE-2010-3851).

This large commit changes the generator so that optional arguments
can be supported for functions.

The model for arguments (known as the "style") is changed from
(ret, args) to (ret, args, optargs) where optargs is a more limited
list of arguments.

One function has been added which takes optional arguments, it is
"add-drive-opts", modelled as:

  (RErr, [String "filename"], #required
         [Bool "readonly"; String "format"; String "iface"]) #optional

Note that this function is processed in the library (does not go over
the RPC protocol to the daemon).  This has allowed us to simplify
the current implementation by omitting changes related to RPC or the
daemon, although we plan to add these at some point in the future.

From C this function can be called in 3 different ways as in these

  guestfs_add_drive_opts (g, filename,
                          GUESTFS_ADD_DRIVE_OPTS_READONLY, 1,

(the argument(s) between 'filename' and '-1' are the optional ones).

  guestfs_add_drive_opts_va (g, filename, args);

where 'args' is a va_list.  This works like the first version.

  struct guestfs_add_drive_opts_argv optargs = {
    .readonly = 1,
  guestfs_add_drive_opts_argv (g, filename, &optargs);

This last form lets you construct lists of optional arguments, and
is used by guestfish and the language bindings.

In guestfish optional arguments are used like this:

  add-drive-opts filename readonly:true

In OCaml these are mapped naturally to OCaml optional arguments, eg:

  g#add_drive_opts ~readonly:true filename;

In Perl these are mapped to extra arguments, eg:

  $g->add_drive_opts ($filename, readonly => 1);

In Python these are mapped to optional arguments, eg:

  g.add_drive_opts ("file", readonly = 1, format = "qcow2")

In Ruby these are mapped to a final hash argument, eg:

  g.add_drive_opts("file", {})
  g.add_drive_opts("file", :readonly => 1)
  g.add_drive_opts("file", :readonly => 1, :iface => "virtio")

In PHP these are mapped to extra parameters.  This is not quite
accurate since you cannot omit arbitrary optional parameters, but
there's not much than can be done within the limitations of PHP
as a language.

Unimplemented in: Haskell, C#, Java.

13 years agogenerator: Rearrange argt logically (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Wed, 20 Oct 2010 09:49:59 +0000 (10:49 +0100)]
generator: Rearrange argt logically (RHBZ#642934,CVE-2010-3851).

This structure has accreted over time.  Rearrange the types
into a logical order.

13 years agodaemon: Use stdint UINT64_C instead of <const>ULL.
Richard W.M. Jones [Fri, 22 Oct 2010 16:10:49 +0000 (17:10 +0100)]
daemon: Use stdint UINT64_C instead of <const>ULL.

13 years agoinspector: Add comment about why --fish option implies write mode.
Richard W.M. Jones [Fri, 22 Oct 2010 11:13:07 +0000 (12:13 +0100)]
inspector: Add comment about why --fish option implies write mode.

13 years agophp: Create test file properly before running test.
Richard W.M. Jones [Thu, 21 Oct 2010 17:47:44 +0000 (18:47 +0100)]
php: Create test file properly before running test.

13 years agophp: Note that tests are testing the wrong thing.
Richard W.M. Jones [Thu, 21 Oct 2010 17:41:56 +0000 (18:41 +0100)]
php: Note that tests are testing the wrong thing.

13 years agoruby: Run tests one at a time, instead of in parallel.
Richard W.M. Jones [Thu, 21 Oct 2010 15:39:04 +0000 (16:39 +0100)]
ruby: Run tests one at a time, instead of in parallel.

13 years agogenerator: Refactor code for Perl bindings.
Richard W.M. Jones [Thu, 21 Oct 2010 12:59:36 +0000 (13:59 +0100)]
generator: Refactor code for Perl bindings.

This simplifies the code that generates the Perl bindings
by removing repeated sections.

13 years agogenerator: Missing newline character.
Richard W.M. Jones [Thu, 21 Oct 2010 10:59:49 +0000 (11:59 +0100)]
generator: Missing newline character.

13 years agofish: Change 'int argc' to 'size_t argc' throughout.
Richard W.M. Jones [Thu, 21 Oct 2010 09:50:25 +0000 (10:50 +0100)]
fish: Change 'int argc' to 'size_t argc' throughout.

13 years agogenerator: Remove unused parameter.
Richard W.M. Jones [Wed, 20 Oct 2010 12:35:43 +0000 (13:35 +0100)]
generator: Remove unused parameter.

generate_c_call_args optional decl parameter is never actually
used, so remove it.

13 years agoVersion 1.5.22. 1.5.22
Richard W.M. Jones [Tue, 19 Oct 2010 14:18:15 +0000 (15:18 +0100)]
Version 1.5.22.

13 years agovirt-resize: Document guest boot stops at "GRUB" (RHBZ#640961).
Richard W.M. Jones [Mon, 18 Oct 2010 13:34:28 +0000 (14:34 +0100)]
virt-resize: Document guest boot stops at "GRUB" (RHBZ#640961).

13 years agodf: Correctly quote libvirt domain and filesystem in --csv mode (RHBZ#639986).
Richard W.M. Jones [Mon, 18 Oct 2010 13:18:58 +0000 (14:18 +0100)]
df: Correctly quote libvirt domain and filesystem in --csv mode (RHBZ#639986).

This fixes virt-df --csv when used with libvirt domains that contain
quotes, spaces, commas and other lesser-used characters.

13 years agovirt-resize: Document qcow2 output format (RHBZ#642826).
Richard W.M. Jones [Mon, 18 Oct 2010 12:35:06 +0000 (13:35 +0100)]
virt-resize: Document qcow2 output format (RHBZ#642826).

13 years agovirt-resize: List truncate(1) in SEE ALSO section.
Richard W.M. Jones [Mon, 18 Oct 2010 12:33:02 +0000 (13:33 +0100)]
virt-resize: List truncate(1) in SEE ALSO section.

13 years agotools: Add section describing quoting libvirt domain names to docs (RHBZ#643624)
Richard W.M. Jones [Mon, 18 Oct 2010 12:18:20 +0000 (13:18 +0100)]
tools: Add section describing quoting libvirt domain names to docs (RHBZ#643624)

13 years agoparted: Don't return "loop" for non-partitioned devices (RHBZ#634246).
Richard W.M. Jones [Mon, 18 Oct 2010 11:56:54 +0000 (12:56 +0100)]
parted: Don't return "loop" for non-partitioned devices (RHBZ#634246).

If you ran part-get-parttype command on a device which didn't
contain a partition, it used to return the string "loop".  This
is an internal representation that parted uses.  We should instead
return an error because part-get-parttype makes no sense for
devices which are not partitioned.

13 years agocontrib: Note about what needs to be done for visualization.
Richard W.M. Jones [Mon, 18 Oct 2010 11:44:08 +0000 (12:44 +0100)]
contrib: Note about what needs to be done for visualization.

13 years agotodo: Add wishlist items to to-do list.
Richard W.M. Jones [Mon, 18 Oct 2010 11:41:41 +0000 (12:41 +0100)]
todo: Add wishlist items to to-do list.

13 years agotodo: Add note about using blktrace.
Richard W.M. Jones [Wed, 6 Oct 2010 15:38:12 +0000 (16:38 +0100)]
todo: Add note about using blktrace.

13 years agocontrib: More trace visualization.
Richard W.M. Jones [Wed, 6 Oct 2010 10:30:02 +0000 (11:30 +0100)]
contrib: More trace visualization.

13 years agodebug: Add qtrace <device> on|off to allow selective traces.
Richard W.M. Jones [Wed, 6 Oct 2010 09:19:20 +0000 (10:19 +0100)]
debug: Add qtrace <device> on|off to allow selective traces.

13 years agopart-disk: Align whole disk partition to 64 sectors.
Richard W.M. Jones [Wed, 6 Oct 2010 08:08:39 +0000 (09:08 +0100)]
part-disk: Align whole disk partition to 64 sectors.

Change the part-disk command so it aligns the partition to
64 sectors (instead of 1 or 34 sectors as now).  This should
ensure that the filesystem contained within is aligned.

13 years agocontrib: Fix small mistake in README file.
Richard W.M. Jones [Tue, 5 Oct 2010 21:48:37 +0000 (22:48 +0100)]
contrib: Fix small mistake in README file.

13 years agocontrib: Update README files.
Richard W.M. Jones [Tue, 5 Oct 2010 21:21:43 +0000 (22:21 +0100)]
contrib: Update README files.

13 years agocontrib: Visualizing block device access and alignment.
Richard W.M. Jones [Tue, 5 Oct 2010 21:19:15 +0000 (22:19 +0100)]
contrib: Visualizing block device access and alignment.

13 years agoocaml: Add g#ocaml_handle method.
Richard W.M. Jones [Mon, 4 Oct 2010 19:34:36 +0000 (20:34 +0100)]
ocaml: Add g#ocaml_handle method.

13 years agoocaml: Document g#close () method for objects.
Richard W.M. Jones [Mon, 4 Oct 2010 19:33:14 +0000 (20:33 +0100)]
ocaml: Document g#close () method for objects.

13 years agoocaml: Create the handle when the object is instantiated.
Richard W.M. Jones [Mon, 4 Oct 2010 19:29:05 +0000 (20:29 +0100)]
ocaml: Create the handle when the object is instantiated.

Previously we had only one handle shared between all objects .. oops.
This fixes commit 67636f721056d2f2250b0ff8acd981a0294536a9.

13 years agoocaml: Add alternate object-oriented programming style.
Richard W.M. Jones [Sun, 3 Oct 2010 20:18:25 +0000 (21:18 +0100)]
ocaml: Add alternate object-oriented programming style.

In original style:

let () =
  let filename = Sys.argv.(1) in
  let g = Guestfs.create () in
  Guestfs.add_drive_ro g filename;
  Guestfs.launch g;
  let roots = Guestfs.inspect_os g in
  print_endline (Guestfs.inspect_get_product_name g roots.(0))

The same code in the new OO style:

let () =
  let filename = Sys.argv.(1) in
  let g = new Guestfs.guestfs in
  g#add_drive_ro filename;
  g#launch ();
  let roots = g#inspect_os () in
  print_endline (g#inspect_get_product_name roots.(0))

13 years agotest-copy: Skip this test if /dev/fd is missing, because of broken mock 1.1.4.
Richard W.M. Jones [Sat, 2 Oct 2010 08:10:22 +0000 (09:10 +0100)]
test-copy: Skip this test if /dev/fd is missing, because of broken mock 1.1.4.

13 years agotest-virt-resize: Skip this test on 32 bit hosts.
Richard W.M. Jones [Sat, 2 Oct 2010 08:07:42 +0000 (09:07 +0100)]
test-virt-resize: Skip this test on 32 bit hosts.

13 years agoVersion 1.5.21. 1.5.21
Richard W.M. Jones [Fri, 1 Oct 2010 20:04:07 +0000 (21:04 +0100)]
Version 1.5.21.

13 years agofish: Fix glob command (RHBZ#635969).
Richard W.M. Jones [Fri, 1 Oct 2010 09:46:38 +0000 (10:46 +0100)]
fish: Fix glob command (RHBZ#635969).

This is a fix for the glob command in guestfish which was inadvertently
broken in commit c359347dd42c9f5b875630537ee3641264826b89.

This also appears to fix:
  glob echo mkfs ext2 /dev/vd[b-t]1 prints garbage

13 years agoAdd test for virt-resize.
Richard W.M. Jones [Mon, 27 Sep 2010 16:06:14 +0000 (17:06 +0100)]
Add test for virt-resize.

This tests a number of things which have caused problems for us:

 - resizing PVs and LV content
 - handling GPT format disks
 - using qcow2 as a target disk format
 - shrinking disk images

Note that the disk content is empty (not a real VM), but this is
adequate since all we want to test are the operations and calculations
done by virt-resize.  We are not interested here in whether e2fsprogs
and LVM actually works.

13 years agoresize: Fix handling of GPT and qcow2 (RHBZ#633766, RHBZ#633096).
Richard W.M. Jones [Mon, 27 Sep 2010 16:00:45 +0000 (17:00 +0100)]
resize: Fix handling of GPT and qcow2 (RHBZ#633766, RHBZ#633096).

Previously we copied the bootloader data directly from the
source disk image to the target disk image using host file
operations (before launching libguestfs).  This has two problems:
firstly it has no chance of working with qcow2, and secondly
it didn't behave properly with GPT.

This changes the code so that everything is done through
libguestfs.  Block device sizes are now calculated properly
for qcow2 (RHBZ#633096) because this is done using the libguestfs
blockdev_getsize64 call.  The partition table is still created
by parted, but to workaround a bug in parted this is done before
copying the bootloader.  Finally the bootloader copy is done
using the new APIs pread-device and pwrite-device.

Shrinking now works, at least for simple cases (RHBZ#633766).

13 years agoNew API: pread-device, partial read for devices.
Richard W.M. Jones [Mon, 27 Sep 2010 11:00:10 +0000 (12:00 +0100)]
New API: pread-device, partial read for devices.

13 years agopread: Check count and offset parameters are not negative.
Richard W.M. Jones [Mon, 27 Sep 2010 09:51:38 +0000 (10:51 +0100)]
pread: Check count and offset parameters are not negative.

13 years agoFreshen POD (manual pages) stylesheet.
Richard W.M. Jones [Mon, 27 Sep 2010 09:12:22 +0000 (10:12 +0100)]
Freshen POD (manual pages) stylesheet.

13 years agoVersion 1.5.20. 1.5.20
Richard W.M. Jones [Sun, 26 Sep 2010 21:41:24 +0000 (22:41 +0100)]
Version 1.5.20.

13 years agoNew API: pwrite-device
Richard W.M. Jones [Sun, 26 Sep 2010 17:00:11 +0000 (18:00 +0100)]
New API: pwrite-device

This is the same as the existing 'pwrite' API call, but allows you
to write to a device.

13 years agopwrite: Check offset is not negative.
Richard W.M. Jones [Sun, 26 Sep 2010 16:59:50 +0000 (17:59 +0100)]
pwrite: Check offset is not negative.

13 years agofish: Refresh guestfish documentation.
Richard W.M. Jones [Sun, 26 Sep 2010 21:21:10 +0000 (22:21 +0100)]
fish: Refresh guestfish documentation.

13 years agoDocument ambiguity between devices and paths in API.
Richard W.M. Jones [Sun, 26 Sep 2010 18:34:46 +0000 (19:34 +0100)]
Document ambiguity between devices and paths in API.

13 years agoDocument accurately how supermin appliance uses /tmp as a cache.
Richard W.M. Jones [Fri, 24 Sep 2010 18:28:01 +0000 (19:28 +0100)]
Document accurately how supermin appliance uses /tmp as a cache.

13 years agoAllow $TMPDIR to override most temporary directory uses.
Richard W.M. Jones [Fri, 24 Sep 2010 17:54:37 +0000 (18:54 +0100)]
Allow $TMPDIR to override most temporary directory uses.

Be more consistent in allowing the user to override use of the
temporary directory by specifying $TMPDIR.  Also prefer P_tmpdir
macro (defined in <stdio.h>) if that is defined, rather than
hard-coding "/tmp" for the fallback location.

13 years agoCall blockdev --rereadpt then udev_settle after sfdisk commands.
Richard W.M. Jones [Fri, 24 Sep 2010 17:53:21 +0000 (18:53 +0100)]
Call blockdev --rereadpt then udev_settle after sfdisk commands.

This updates commit 956fc5a3feacc970ea763697bf28fb686c875408 so
that we call udev_settle after rereading the partition table.  This
ensures that the devices nodes for the new partitions have been

13 years agoUpdate Spanish translations (RHBZ#636918).
Daniel Cabrera [Thu, 23 Sep 2010 17:11:35 +0000 (18:11 +0100)]
Update Spanish translations (RHBZ#636918).

13 years agoUpdate Polish translations (RHBZ#502533).
Piotr Drąg [Thu, 23 Sep 2010 13:45:50 +0000 (14:45 +0100)]
Update Polish translations (RHBZ#502533).

13 years agoVersion 1.5.19. 1.5.19
Richard W.M. Jones [Wed, 22 Sep 2010 20:50:46 +0000 (21:50 +0100)]
Version 1.5.19.

13 years agoregressions: Test just-built guestfish.
Richard W.M. Jones [Wed, 22 Sep 2010 16:43:34 +0000 (17:43 +0100)]
regressions: Test just-built guestfish.

Instead of testing the installed /usr/bin/guestfish.

This fixes commit ddda0f7bd00a37274dae38f4ce93955b8cfdf7d7.

13 years agoCall blockdev --rereadpt after sfdisk commands.
Richard W.M. Jones [Wed, 22 Sep 2010 15:35:52 +0000 (16:35 +0100)]
Call blockdev --rereadpt after sfdisk commands.

On fast machines sfdisk has some sort of race where it
fails to re-read the partition table it has just created
(it's not clear if this is a race in sfdisk, the kernel or
some other component).

This commit works around the problem by calling
blockdev --rereadpt after sfdisk operations, which
experience shows is enough to stop the problem from

13 years agoVersion 1.5.18. 1.5.18
Richard W.M. Jones [Wed, 22 Sep 2010 14:37:34 +0000 (15:37 +0100)]
Version 1.5.18.

13 years agoTest guestfish -a and guestfish -d options.
Richard W.M. Jones [Wed, 22 Sep 2010 13:10:58 +0000 (14:10 +0100)]
Test guestfish -a and guestfish -d options.

Since these options were both broken in released version 1.5.17,
best to have a regression test to catch this in future.

13 years agoappliance: Ignore unreadable dbus service file (Fedora 15).
Richard Jones [Wed, 22 Sep 2010 13:10:13 +0000 (14:10 +0100)]
appliance: Ignore unreadable dbus service file (Fedora 15).

13 years agofish: Fix segfault in free_drives() function.
Richard W.M. Jones [Wed, 22 Sep 2010 10:59:58 +0000 (11:59 +0100)]
fish: Fix segfault in free_drives() function.

This updates commit 8ea62c8d7f3f7f7e4057b93105cf979271aa13f4
so it doesn't try to free the optarg (stack-allocated) strings.

13 years agoVersion 1.5.17. 1.5.17
Richard W.M. Jones [Tue, 21 Sep 2010 20:57:50 +0000 (21:57 +0100)]
Version 1.5.17.

13 years agoUpdate release notes for new features in 1.5 branch.
Richard W.M. Jones [Tue, 21 Sep 2010 21:49:18 +0000 (22:49 +0100)]
Update release notes for new features in 1.5 branch.

13 years agofish: Implement 'hexedit' command.
Richard W.M. Jones [Sat, 18 Sep 2010 09:09:04 +0000 (10:09 +0100)]
fish: Implement 'hexedit' command.

13 years agoNew APIs: upload-offset and download-offset
Richard W.M. Jones [Mon, 20 Sep 2010 17:23:58 +0000 (18:23 +0100)]
New APIs: upload-offset and download-offset

These APIs allow you to efficiently write and read parts of
files or devices.

13 years agoleak: Clear history before exiting guestfish.
Richard W.M. Jones [Tue, 21 Sep 2010 18:49:08 +0000 (19:49 +0100)]
leak: Clear history before exiting guestfish.

Clear the in-memory history before exiting.  This removes
some but not all memory leaks associated with using the GNU
History library.  As far as I can tell it is not possible to
free up everything used by GNU History.

(Found by valgrind).

13 years agoleak: Free list of drives and mountpoints in guestfish.
Richard W.M. Jones [Tue, 21 Sep 2010 18:40:23 +0000 (19:40 +0100)]
leak: Free list of drives and mountpoints in guestfish.

Previously the list of -a, -d, -m, -N parameters were leaked.  This
change frees them explicitly.

This is not such an important fix since guestfish is a one-shot
program, but it aids in finding other leaks in future.

(Found by valgrind).

13 years agoleak: Free PCRE regexps when library is unloaded.
Richard W.M. Jones [Tue, 21 Sep 2010 18:38:50 +0000 (19:38 +0100)]
leak: Free PCRE regexps when library is unloaded.

The compiled PCRE regexps used for inspection were being leaked when
the library was unloaded.

(Found by valgrind).

13 years agoleak: Appliance name was leaked during guestfs_launch.
Richard W.M. Jones [Tue, 21 Sep 2010 18:37:24 +0000 (19:37 +0100)]
leak: Appliance name was leaked during guestfs_launch.

This frees the string containing the name of the appliance
which was previously being leaked during launch.

(Found by valgrind).

13 years agoAdd more exclusions to .gitignore.
Matthew Booth [Tue, 21 Sep 2010 12:22:58 +0000 (13:22 +0100)]
Add more exclusions to .gitignore.

13 years agoFix appliance build dependency problem
Matthew Booth [Tue, 21 Sep 2010 09:50:41 +0000 (10:50 +0100)]
Fix appliance build dependency problem

The appliance was being completely rebuilt every time guestfsd was updated. This
was because depended on guestfsd, which it had to do because it
called to install guestfsd.

This fix removes the call to in, and therefore the dependency
on guestfsd. The Makefile already includes a rule to run when guestfsd
is updated, so this was unnecessary.

13 years agofish: Add --echo-keys option to allow passphrases/keys to be echoed.
Richard W.M. Jones [Tue, 21 Sep 2010 07:53:44 +0000 (08:53 +0100)]
fish: Add --echo-keys option to allow passphrases/keys to be echoed.

See also:

13 years agodf: Add --one-per-guest option for using one appliance per guest.
Richard W.M. Jones [Sun, 19 Sep 2010 14:55:46 +0000 (15:55 +0100)]
df: Add --one-per-guest option for using one appliance per guest.

13 years agoFix error launching libguestfs when euid != uid.
Richard W.M. Jones [Mon, 20 Sep 2010 13:02:06 +0000 (14:02 +0100)]
Fix error launching libguestfs when euid != uid.

When writing to a RHEV target, virt-v2v launches the libguestfs
appliance with euid:egid = 36:36, which is required to write to
an NFS target using root_squash.

Since we changed to using a cached appliance, this causes an error on
start up, as the cached files are owned by root, but the cache directory
is owned by 36:36.  The reason is that bash resets euid to uid and
egid to gid so when febootstrap-supermin-helper is executed, it runs as
root:root.  The cache directory was created by libguestfs directly so
it has the correct ownership.

This patch fixes the issue by using explicit fork/exec instead of
system (ie. not going via a shell) and by setting the real UID and
GID to the effective UID and GID before execing.

13 years agotodo: Suggest removing repo name from appliance name.
Richard W.M. Jones [Mon, 20 Sep 2010 12:06:13 +0000 (13:06 +0100)]
todo: Suggest removing repo name from appliance name.

13 years agogenerator: Generate guestfish-only commands.
Richard W.M. Jones [Sat, 18 Sep 2010 08:38:05 +0000 (09:38 +0100)]
generator: Generate guestfish-only commands.

The guestfish-only commands such as 'alloc' and 'edit' are
now generated from one place in the generator instead of being
spread around ad-hoc in the C code.

13 years agofish: In guestfish(1) turn command references into links.
Richard W.M. Jones [Sat, 18 Sep 2010 07:57:30 +0000 (08:57 +0100)]
fish: In guestfish(1) turn command references into links.

13 years agofish: Correction for online help for 'edit' and 'more' commands.
Richard W.M. Jones [Fri, 17 Sep 2010 13:35:43 +0000 (14:35 +0100)]
fish: Correction for online help for 'edit' and 'more' commands.

This corrects commit b5c287bcd456bdb02d8ec0443483df34f4fd6b5d
and commit 639ca1828b167bf59353f0cd3c8c79c6289bbd5d.

13 years agoVersion 1.5.16. 1.5.16
Richard Jones [Wed, 15 Sep 2010 21:12:35 +0000 (22:12 +0100)]
Version 1.5.16.

13 years agoconfigure: Make "fedora-13" the default repository.
Richard Jones [Wed, 15 Sep 2010 21:08:35 +0000 (22:08 +0100)]
configure: Make "fedora-13" the default repository.

13 years agofish: If -m option fails, suggest a mountpoint.
Richard Jones [Wed, 15 Sep 2010 20:47:37 +0000 (21:47 +0100)]
fish: If -m option fails, suggest a mountpoint.

13 years agotodo: Remove section since we now have list-filesystems API.
Richard Jones [Wed, 15 Sep 2010 19:49:32 +0000 (20:49 +0100)]
todo: Remove section since we now have list-filesystems API.

13 years agoVersion 1.5.15. 1.5.15
Richard Jones [Wed, 15 Sep 2010 19:35:06 +0000 (20:35 +0100)]
Version 1.5.15.

13 years agoNew API: list-filesystems: list filesystems
Richard Jones [Wed, 15 Sep 2010 16:22:29 +0000 (17:22 +0100)]
New API: list-filesystems: list filesystems

This API is a simpler replacement for the guestfish commands
list-devices / list-partitions / lvs, in the case where you are
just examining a guest by hand to see what it contains.

Typical usage and output in guestfish is like this:

$ guestfish --ro -a /dev/vg_trick/F13x64
><fs> run
><fs> list-filesystems
/dev/vda1: ext4
/dev/vg_f13x64/lv_root: ext4
/dev/vg_f13x64/lv_swap: swap

It can also be used to replace programs that try to mount
devices to determine if they are mountable filesystems.

13 years agoNew API: part-to-dev: Convert partition name to device name.
Richard Jones [Wed, 15 Sep 2010 15:39:36 +0000 (16:39 +0100)]
New API: part-to-dev: Convert partition name to device name.

This adds a formal API for going from a partition to the containing
device, eg. /dev/sda1 -> /dev/sda

13 years agogenerator: Add TestOutputDevice.
Richard Jones [Wed, 15 Sep 2010 16:15:44 +0000 (17:15 +0100)]
generator: Add TestOutputDevice.

This is for testing functions that return a device or partition
name, so that we can compare the return value with the canonical
device name (eg. "/dev/vda1" == "/dev/sda1").

13 years agotodo: More use of libblkid.
Richard Jones [Wed, 15 Sep 2010 15:37:24 +0000 (16:37 +0100)]
todo: More use of libblkid.

13 years agofish: In usage message use new-style -i option syntax.
Richard Jones [Tue, 14 Sep 2010 21:29:08 +0000 (22:29 +0100)]
fish: In usage message use new-style -i option syntax.

13 years agofish: Update copyright dates in usage message.
Richard Jones [Tue, 14 Sep 2010 21:28:10 +0000 (22:28 +0100)]
fish: Update copyright dates in usage message.