libguestfs.git
13 years agosupermin: If disabled, don't compile in supermin code or check for supermin.
Richard W.M. Jones [Mon, 8 Nov 2010 12:46:31 +0000 (12:46 +0000)]
supermin: If disabled, don't compile in supermin code or check for supermin.

If supermin is disabled at compile time and the user just wants to
use the ordinary appliance, there is no need to compile in all
the supermin code, and in particular there is no need to check
for the supermin appliance (which involves running
febootstrap-supermin-helper that probably doesn't exist).

This fixes a warning message observed under Debian w/o supermin:

  sh: febootstrap-supermin-helper: command not found

13 years agofish: Add --rw option (does nothing yet).
Richard W.M. Jones [Fri, 5 Nov 2010 18:36:02 +0000 (18:36 +0000)]
fish: Add --rw option (does nothing yet).

This adds the guestfish --rw option, intended in future
to be required for writing to disk images.

At the moment this does not change the default and so does
nothing.  This patch is intended for backporting to the
stable branches so that we can start to introduce scripts
which use 'guestfish --rw'.

13 years agoAdd missing generated files to the tarball (thanks maksbotan).
Richard W.M. Jones [Sun, 7 Nov 2010 09:54:51 +0000 (09:54 +0000)]
Add missing generated files to the tarball (thanks maksbotan).

C# bindings were omitted entirely.  Add a Makefile.am for this
directory even though we don't build these.

Because of a missing backslash, some POD files were not being
included.

13 years agofish: Add --listen --csh to for csh, tcsh compatibility.
Richard W.M. Jones [Fri, 5 Nov 2010 15:17:45 +0000 (15:17 +0000)]
fish: Add --listen --csh to for csh, tcsh compatibility.

(Thanks Eric Blake).

13 years agofish: Suggest safer form of eval.
Richard W.M. Jones [Fri, 5 Nov 2010 15:07:11 +0000 (15:07 +0000)]
fish: Suggest safer form of eval.

eval "$(guestfish --listen)"

instead of various other forms.

(Thanks Eric Blake).

13 years agofish: More portable export sh statment.
Richard W.M. Jones [Fri, 5 Nov 2010 15:04:08 +0000 (15:04 +0000)]
fish: More portable export sh statment.

Don't depend on bash, but allow sh/dash/etc format:
GUESTFISH_PID=nn; export GUESTFISH_PID

(Thanks Eric Blake).

13 years agoNew API: inspect-get-roots to return roots from last inspection.
Richard W.M. Jones [Fri, 5 Nov 2010 13:43:08 +0000 (13:43 +0000)]
New API: inspect-get-roots to return roots from last inspection.

Return the roots found by the last call to inspect-os, but
without redoing the whole inspection.

13 years agogenerator: Don't die if an API call isn't listed in API versions file.
Richard W.M. Jones [Fri, 5 Nov 2010 13:42:07 +0000 (13:42 +0000)]
generator: Don't die if an API call isn't listed in API versions file.

For example, it may just have been added.

13 years agoVersion 1.7.2. 1.7.2
Richard W.M. Jones [Fri, 5 Nov 2010 12:20:21 +0000 (12:20 +0000)]
Version 1.7.2.

13 years agoconfigure: Test for 'kvm' binary.
Guido Günther [Fri, 5 Nov 2010 12:24:32 +0000 (12:24 +0000)]
configure: Test for 'kvm' binary.

13 years agoInclude <stdarg.h> in public header.
Guido Günther [Fri, 5 Nov 2010 12:23:11 +0000 (12:23 +0000)]
Include <stdarg.h> in public header.

Public headers use va_list, and this gives an error unless <stdarg.h>
had been included before the header.

13 years agoDon't print out key material in trace output.
Richard W.M. Jones [Fri, 5 Nov 2010 11:54:54 +0000 (11:54 +0000)]
Don't print out key material in trace output.

13 years agofish: '-i' option automatically handles whole-disk encryption.
Richard W.M. Jones [Fri, 5 Nov 2010 11:39:24 +0000 (11:39 +0000)]
fish: '-i' option automatically handles whole-disk encryption.

This feature is also available in guestmount because of the
shared option parsing code.

You don't need to do anything to enable it, just using -i
will attempt decryption of encrypted partitions.

Only works for simple Fedora whole-disk encryption.  It's a
work-in-progress to make it work for other types of encryption.

13 years agodocs: Fix API support script.
Richard W.M. Jones [Thu, 4 Nov 2010 17:43:17 +0000 (17:43 +0000)]
docs: Fix API support script.

Before libguestfs 1.0.69 we needed to look in src/guestfs.c to
see all the API calls.

13 years agofish: Fix missing guestfish commands in HTML docs.
Richard W.M. Jones [Thu, 4 Nov 2010 17:23:21 +0000 (17:23 +0000)]
fish: Fix missing guestfish commands in HTML docs.

13 years agofish: Make the 'help' command more helpful.
Richard W.M. Jones [Thu, 4 Nov 2010 17:04:03 +0000 (17:04 +0000)]
fish: Make the 'help' command more helpful.

13 years agodocs: Which API calls were first supported in which upstream versions.
Richard W.M. Jones [Thu, 4 Nov 2010 08:43:10 +0000 (08:43 +0000)]
docs: Which API calls were first supported in which upstream versions.

Run src/api-support/update-from-tarballs.sh (this won't work
unless you have a local copy of the tarballs from the website).

src/api-support/added contains the result of running the
script, a list of pairs: (API name, version first appeared).

13 years agovirt-win-reg: Current is the control set Windows chooses at boot.
Richard W.M. Jones [Wed, 3 Nov 2010 23:17:51 +0000 (23:17 +0000)]
virt-win-reg: Current is the control set Windows chooses at boot.

13 years agoHACKING: Mention PHP bindings.
Richard W.M. Jones [Wed, 3 Nov 2010 22:23:55 +0000 (22:23 +0000)]
HACKING: Mention PHP bindings.

13 years agodocs: Indent *_va and *_argv functions correctly.
Richard W.M. Jones [Wed, 3 Nov 2010 22:11:22 +0000 (22:11 +0000)]
docs: Indent *_va and *_argv functions correctly.

This fixes commit f661db2c393d1b7e4211c55682b7fac82a70e36d.

13 years agoVersion 1.7.1. 1.7.1
Richard W.M. Jones [Wed, 3 Nov 2010 21:09:51 +0000 (21:09 +0000)]
Version 1.7.1.

13 years agofish: Use a perfect hash for faster command lookups.
Richard W.M. Jones [Wed, 3 Nov 2010 20:34:42 +0000 (20:34 +0000)]
fish: Use a perfect hash for faster command lookups.

Existing command lookups are approx O(n^2).  Replace this
with a perfect hash implementation which should be a lot
faster.

13 years agogenerator: Properly lay out and indent multi-line C function decls.
Richard W.M. Jones [Wed, 3 Nov 2010 19:26:10 +0000 (19:26 +0000)]
generator: Properly lay out and indent multi-line C function decls.

13 years agodocs: Clarify no additional error available from guestfs_create.
Richard W.M. Jones [Wed, 3 Nov 2010 18:33:31 +0000 (18:33 +0000)]
docs: Clarify no additional error available from guestfs_create.

13 years agodocs: Clarify default error handler.
Richard W.M. Jones [Wed, 3 Nov 2010 18:29:58 +0000 (18:29 +0000)]
docs: Clarify default error handler.

13 years agodocs: Error strings are in fact localized, documentation was wrong.
Richard W.M. Jones [Wed, 3 Nov 2010 18:02:08 +0000 (18:02 +0000)]
docs: Error strings are in fact localized, documentation was wrong.

13 years agodocs: Clarify, not every function that returns int returns -1 for errors.
Richard W.M. Jones [Wed, 3 Nov 2010 18:01:48 +0000 (18:01 +0000)]
docs: Clarify, not every function that returns int returns -1 for errors.

13 years agocapitests: Test guestfs_last_errno call.
Richard W.M. Jones [Wed, 3 Nov 2010 17:24:50 +0000 (17:24 +0000)]
capitests: Test guestfs_last_errno call.

13 years agofuse: Use guestfs_last_errno instead of errno-reversal-hack.
Richard W.M. Jones [Wed, 3 Nov 2010 16:15:48 +0000 (16:15 +0000)]
fuse: Use guestfs_last_errno instead of errno-reversal-hack.

13 years agolib: Expose errno through new API guestfs_last_errno.
Richard W.M. Jones [Wed, 3 Nov 2010 15:49:36 +0000 (15:49 +0000)]
lib: Expose errno through new API guestfs_last_errno.

If either the daemon sends back an errno, or a system call
fails in the library, save the errno in the handle and then
make it available to callers through the guestfs_last_errno
function.

13 years agodaemon: Send back the errno as a string.
Richard W.M. Jones [Wed, 3 Nov 2010 12:53:00 +0000 (12:53 +0000)]
daemon: Send back the errno as a string.

This changes the protocol again so that if the errno is available,
it is converted to a string (like "EIO") and sent back over the
protocol to the library.

In this commit the library just discards the string.

13 years agocapitests: Test guestfs_add_drive_opts with optional args from C.
Richard W.M. Jones [Wed, 3 Nov 2010 17:00:29 +0000 (17:00 +0000)]
capitests: Test guestfs_add_drive_opts with optional args from C.

13 years agocapitests: Test some basic aspects of the C API.
Richard W.M. Jones [Wed, 3 Nov 2010 16:56:34 +0000 (16:56 +0000)]
capitests: Test some basic aspects of the C API.

13 years agocapitests: Use ftruncate instead of seek + write to create test files.
Richard W.M. Jones [Wed, 3 Nov 2010 17:37:07 +0000 (17:37 +0000)]
capitests: Use ftruncate instead of seek + write to create test files.

13 years agocapitests: Don't open test files with O_NONBLOCK.
Richard W.M. Jones [Wed, 3 Nov 2010 17:34:27 +0000 (17:34 +0000)]
capitests: Don't open test files with O_NONBLOCK.

I have no idea why we were doing this.

13 years agocapitests: Set path in TESTS_ENVIRONMENT instead of in tests.c
Richard W.M. Jones [Wed, 3 Nov 2010 17:26:00 +0000 (17:26 +0000)]
capitests: Set path in TESTS_ENVIRONMENT instead of in tests.c

By exporting LIBGUESTFS_PATH with the right path to the appliance,
we no longer need to hard code the path in tests.c

13 years agogenerator: Remove unnecessary macro redefinitions.
Richard W.M. Jones [Wed, 3 Nov 2010 15:46:46 +0000 (15:46 +0000)]
generator: Remove unnecessary macro redefinitions.

These macros are already defined in guestfs-internals.h

13 years agoDefine internal safe_calloc shorthand.
Richard W.M. Jones [Wed, 3 Nov 2010 15:48:04 +0000 (15:48 +0000)]
Define internal safe_calloc shorthand.

13 years agodaemon: Don't use ../src path to include generator_protocol.h
Richard W.M. Jones [Wed, 3 Nov 2010 12:52:24 +0000 (12:52 +0000)]
daemon: Don't use ../src path to include generator_protocol.h

This file is already hard-linked into the current directory, so
the relative path is not required.

13 years agotests: Remove use of sfdisk from tests.
Richard W.M. Jones [Tue, 2 Nov 2010 20:57:40 +0000 (20:57 +0000)]
tests: Remove use of sfdisk from tests.

Some older tests used sfdisk to create partitions for the
tests.  sfdisk is buggy (more so than parted -- what is it
with partitioning tools?) so replace these tests with
equivalent part-* commands.

13 years agodaemon: Tolerate failure of blockdev --rereadpt after sfdisk.
Richard W.M. Jones [Tue, 2 Nov 2010 20:33:06 +0000 (20:33 +0000)]
daemon: Tolerate failure of blockdev --rereadpt after sfdisk.

See commit 840536ea5a0568296dfd3e483442c76b93c5a949
and commit 956fc5a3feacc970ea763697bf28fb686c875408.

13 years agobinary: Link guestmount static binary with -lm.
Richard W.M. Jones [Tue, 2 Nov 2010 17:05:58 +0000 (17:05 +0000)]
binary: Link guestmount static binary with -lm.

This is indirectly required via the new shared guestfish
C inspection code by libxml2.

13 years agowebsite: Distribute BUGS and RELEASE-NOTES files to website.
Richard W.M. Jones [Tue, 2 Nov 2010 17:05:43 +0000 (17:05 +0000)]
website: Distribute BUGS and RELEASE-NOTES files to website.

13 years agoVersion 1.7.0. 1.7.0
Richard W.M. Jones [Tue, 2 Nov 2010 16:23:58 +0000 (16:23 +0000)]
Version 1.7.0.

13 years agoFinal RELEASE-NOTES file for version 1.6.0.
Richard W.M. Jones [Tue, 2 Nov 2010 16:18:30 +0000 (16:18 +0000)]
Final RELEASE-NOTES file for version 1.6.0.

13 years agoinspect: Add support for MeeGo.
Richard W.M. Jones [Tue, 2 Nov 2010 10:11:04 +0000 (10:11 +0000)]
inspect: Add support for MeeGo.

13 years agoVersion 1.5.26. 1.5.26
Richard W.M. Jones [Fri, 29 Oct 2010 14:49:36 +0000 (15:49 +0100)]
Version 1.5.26.

13 years agoinspect: Add support for Ubuntu.
Richard Jones [Fri, 29 Oct 2010 10:54:34 +0000 (11:54 +0100)]
inspect: Add support for Ubuntu.

13 years agoinspect: Add detection of Gentoo.
Richard Jones [Fri, 29 Oct 2010 09:53:05 +0000 (10:53 +0100)]
inspect: Add detection of Gentoo.

13 years agoinspect: Add detection of Arch Linux.
Richard Jones [Fri, 29 Oct 2010 09:32:53 +0000 (10:32 +0100)]
inspect: Add detection of Arch Linux.

13 years agoinspect: Add detection of Pardus.
Richard Jones [Fri, 29 Oct 2010 09:21:33 +0000 (10:21 +0100)]
inspect: Add detection of Pardus.

13 years agoinspect: Generic parsing of MAJOR.MINOR in product names.
Richard Jones [Fri, 29 Oct 2010 09:50:39 +0000 (10:50 +0100)]
inspect: Generic parsing of MAJOR.MINOR in product names.

13 years agoinspect: Generic parsing of release files.
Richard Jones [Fri, 29 Oct 2010 09:49:38 +0000 (10:49 +0100)]
inspect: Generic parsing of release files.

13 years agoinspector: Sort <filesystems> section.
Richard Jones [Fri, 29 Oct 2010 09:23:28 +0000 (10:23 +0100)]
inspector: Sort <filesystems> section.

13 years agoinspect: Ignore Pardus "/.swap" swapfile.
Richard W.M. Jones [Fri, 29 Oct 2010 08:46:59 +0000 (09:46 +0100)]
inspect: Ignore Pardus "/.swap" swapfile.

13 years agoautogen: Touch ocaml/.depend
Richard Jones [Fri, 29 Oct 2010 08:53:57 +0000 (09:53 +0100)]
autogen: Touch ocaml/.depend

13 years agoinspector: List Debian packages.
Richard W.M. Jones [Thu, 28 Oct 2010 21:56:11 +0000 (22:56 +0100)]
inspector: List Debian packages.

List Debian packages by downloading and parsing the file
/var/lib/dpkg/status.

13 years agoinspector: Introductory documentation for XML format.
Richard W.M. Jones [Thu, 28 Oct 2010 21:32:50 +0000 (22:32 +0100)]
inspector: Introductory documentation for XML format.

13 years agoinspector: Debian package format 'deb' instead of 'dpkg'.
Richard W.M. Jones [Thu, 28 Oct 2010 21:32:05 +0000 (22:32 +0100)]
inspector: Debian package format 'deb' instead of 'dpkg'.

13 years agoinspector: Return canonical block device paths in XML.
Richard W.M. Jones [Thu, 28 Oct 2010 21:29:43 +0000 (22:29 +0100)]
inspector: Return canonical block device paths in XML.

13 years agoVersion 1.5.25. 1.5.25
Richard W.M. Jones [Thu, 28 Oct 2010 17:46:13 +0000 (18:46 +0100)]
Version 1.5.25.

13 years agoEnsure atomic creation of a cached appliance
Matthew Booth [Thu, 28 Oct 2010 14:19:14 +0000 (15:19 +0100)]
Ensure atomic creation of a cached appliance

Cached appliances are discovered by their predictable path. Previously we were
creating a cached appliance directly in this predictable path. This had at least
2 undesirable effects:

* Interrupting appliance creation would leave a corrupt appliance
* 2 processes could simultaneously attempt to create the same appliance, causing
  corruption.

This patch causes the cached appliance to be created in a temporary directory,
and then renamed to the predictable path. As rename is an atomic operation, this
makes the whole creation atomic.

This patch also changes the predictable path to have a prefix of 'guestfs.'.
This will make it simpler for system administrators to clean up old cached
appliances.

This patch resolves RHBZ#639405

13 years agoCall febootstrap-supermin-helper using the new -u and -g options
Matthew Booth [Thu, 28 Oct 2010 14:19:13 +0000 (15:19 +0100)]
Call febootstrap-supermin-helper using the new -u and -g options

Use febootstrap-supermin-helper's new -u and -g command line options to setuid,
rather than doing it in libguestfs.

This resolves an issue with the generation of the cached appliance checksum. The
checksum was being generated by a call to febootstrap-supermin-helper through
popen(). Unfortunately, a bash misfeature meant that euid would be reset to uid,
and the checksum was generated for uid, not euid. When virt-v2v is writing to a
RHEV target, uid == 0 and euid == 36, which resulted in a cached appliance being
created for root with permissions for uid 36.

Note this requires febootstrap 2.10.

13 years agoLog the febootstrap-supermin-helper command line
Matthew Booth [Thu, 28 Oct 2010 14:19:12 +0000 (15:19 +0100)]
Log the febootstrap-supermin-helper command line

A side-effect of change 17e7cb9937a63ed8f9bb0fb6ac7302758be76846 was the the
febootstrap-supermin-helper was no longer logged. This change adds it back using
the new guestfs___print_timestamped_argv internal function.

13 years agoNew internal function guestfs___print_timestamped_argv
Matthew Booth [Thu, 28 Oct 2010 14:19:11 +0000 (15:19 +0100)]
New internal function guestfs___print_timestamped_argv

This function generalises the existing print_cmdline used to output the qemu
command line to output any given command line, and exports it to other modules.
It also adds a timestamp to the old print_cmdline output for consistency with
guestfs___print_timestamped_message.

13 years agolist-filesystems: Use core list-filesystems API (RHBZ#642933).
Richard W.M. Jones [Thu, 28 Oct 2010 12:41:12 +0000 (13:41 +0100)]
list-filesystems: Use core list-filesystems API (RHBZ#642933).

Change virt-list-filesystems to use the core inspection API
instead of the deprecated Sys::Guestfs::Lib::get_partitions
function.

13 years agoSys::Guestfs::Lib: deprecate get_partitions (RHBZ#642933).
Richard W.M. Jones [Thu, 28 Oct 2010 12:40:23 +0000 (13:40 +0100)]
Sys::Guestfs::Lib: deprecate get_partitions (RHBZ#642933).

However the code is left since this function is used
by virt-v2v amongst others.

13 years agoinspector: Rewrite virt-inspector (RHBZ#642930).
Richard W.M. Jones [Thu, 28 Oct 2010 10:31:23 +0000 (11:31 +0100)]
inspector: Rewrite virt-inspector (RHBZ#642930).

Rewrite virt-inspector:

 - remove old and unsupportable features
 - use the C inspection API
 - don't run programs from the guest

The RNG has been updated to reflect the new XML-only output.

The new example files show the new XML output.

13 years agotools: Use C API for inspection (RHBZ#642930).
Richard W.M. Jones [Wed, 27 Oct 2010 15:06:11 +0000 (16:06 +0100)]
tools: Use C API for inspection (RHBZ#642930).

Update the following tools to use the C API for inspection:

 - virt-cat
 - virt-edit
 - virt-ls
 - virt-tar
 - virt-win-reg

None of the tools in the tools/ directory now use the deprecated
Perl inspection APIs.

13 years agoNew API: inspect-get-windows-systemroot to get systemroot.
Richard W.M. Jones [Wed, 27 Oct 2010 15:47:33 +0000 (16:47 +0100)]
New API: inspect-get-windows-systemroot to get systemroot.

We are already using heuristics in the C inspection code to
determine the Windows %SYSTEMROOT% directory.  This change
just exposes this information through the API.

13 years agoSys::Guestfs::Lib: deprecate inspection functions (RHBZ#642930).
Richard W.M. Jones [Wed, 27 Oct 2010 14:47:45 +0000 (15:47 +0100)]
Sys::Guestfs::Lib: deprecate inspection functions (RHBZ#642930).

Deprecate the guest inspection functions in this module, remove
documentation, and point users at the core API functions instead.

However we will keep the code here since it is used by virt-v2v
and virt-inspector.

13 years agodaemon: Fix /dev/mapper paths from mounts and mountpoints (RHBZ#646432).
Richard W.M. Jones [Wed, 27 Oct 2010 13:51:17 +0000 (14:51 +0100)]
daemon: Fix /dev/mapper paths from mounts and mountpoints (RHBZ#646432).

Make the LV paths returned by these two commands canonical.

13 years agoedit: Clean up tmp file handling in virt-edit.
Richard W.M. Jones [Thu, 28 Oct 2010 10:58:56 +0000 (11:58 +0100)]
edit: Clean up tmp file handling in virt-edit.

This was probably not a security issue, but this change
makes the code cleaner by not opening the tmp file twice.

Also be more careful about error checking in close syscall.

13 years agodoc: Warn about security implications of running commands.
Richard W.M. Jones [Wed, 27 Oct 2010 16:32:21 +0000 (17:32 +0100)]
doc: Warn about security implications of running commands.

13 years agovirt-ls: Small fix to documentation.
Richard W.M. Jones [Wed, 27 Oct 2010 14:33:35 +0000 (15:33 +0100)]
virt-ls: Small fix to documentation.

13 years agoRemove ocaml/.depend from git.
Matthew Booth [Thu, 28 Oct 2010 14:15:07 +0000 (15:15 +0100)]
Remove ocaml/.depend from git.

ocaml/.depend is automatically generated. This patch removes it from git.

13 years agoVersion 1.5.24. 1.5.24
Richard W.M. Jones [Wed, 27 Oct 2010 11:21:02 +0000 (12:21 +0100)]
Version 1.5.24.

13 years agoDisable test for RHBZ#576879 comment 5.
Richard W.M. Jones [Wed, 27 Oct 2010 11:17:26 +0000 (12:17 +0100)]
Disable test for RHBZ#576879 comment 5.

This test has started to hang, for reasons we don't understand.

13 years agoUnify guestfish and guestmount options processing (RHBZ#642932).
Richard W.M. Jones [Tue, 26 Oct 2010 14:28:28 +0000 (15:28 +0100)]
Unify guestfish and guestmount options processing (RHBZ#642932).

In guestfish, factor out the processing of the options -a, -c,
-d, -i, -m, -n, -r, -v, -V, -x into a separate set of files:
options.c, options.h, inspect.c, virt.c.

Change guestmount so that it uses these same files (from the
../fish directory) to process the same options.

This unifies the handling of these options between the two programs.
It also adds the useful inspection feature to guestmount, so you
can now do:

  guestmount -d Guest -i --ro mnt/

13 years agodf: Add --uuid option to print guest UUIDs instead of names (RHBZ#646821).
Richard W.M. Jones [Tue, 26 Oct 2010 12:01:47 +0000 (13:01 +0100)]
df: Add --uuid option to print guest UUIDs instead of names (RHBZ#646821).

13 years agotodo: Remove obsolete items from TODO file.
Richard W.M. Jones [Tue, 26 Oct 2010 11:46:26 +0000 (12:46 +0100)]
todo: Remove obsolete items from TODO file.

13 years agoDocument problems mixing mkmountpoint and umount-all (RHBZ#599503).
Richard W.M. Jones [Tue, 26 Oct 2010 09:44:11 +0000 (10:44 +0100)]
Document problems mixing mkmountpoint and umount-all (RHBZ#599503).

13 years agoappliance: Repo name is not Fedora-specific.
Richard W.M. Jones [Tue, 26 Oct 2010 09:04:56 +0000 (10:04 +0100)]
appliance: Repo name is not Fedora-specific.

The --with-repo parameter is also used by Debian to specify
the Debian software repository, so remove references to
Fedora.

13 years agoappliance: Remove repo from appliance filename (RHBZ#638901).
Richard W.M. Jones [Tue, 26 Oct 2010 09:03:50 +0000 (10:03 +0100)]
appliance: Remove repo from appliance filename (RHBZ#638901).

There's no need to have the appliance filename contain the
repository name it was built from, and this change gives
downstream users more freedom to mix and match libraries
and appliances if they want to.

13 years agoinspection: Ignore floppy disks and CD-ROM drives (RHBZ#642929).
Richard W.M. Jones [Tue, 26 Oct 2010 08:56:55 +0000 (09:56 +0100)]
inspection: Ignore floppy disks and CD-ROM drives (RHBZ#642929).

13 years agoEnable autosync by default.
Richard W.M. Jones [Mon, 25 Oct 2010 12:22:17 +0000 (13:22 +0100)]
Enable autosync by default.

13 years ago/dev/mapper paths should not be returned from C inspection APIs (RHBZ#638899).
Richard W.M. Jones [Mon, 25 Oct 2010 11:59:50 +0000 (12:59 +0100)]
/dev/mapper paths should not be returned from C inspection APIs (RHBZ#638899).

With this patch, /dev/mapper paths do not appear in the output
of guestfs_inspect_os, as you can see from this example:

Welcome to guestfish, the libguestfs filesystem interactive shell for
editing virtual machine filesystems.

Type: 'help' for a list of commands
      'man' to read the manual
      'quit' to quit the shell

Operating system: Fedora release 13 (Goddard)
/dev/vg_f13x64/lv_root mounted on /              <--- NB
/dev/vda1 mounted on /boot

13 years agoNew API: lvm-canonical-lv-name: make LV name canonical.
Richard W.M. Jones [Mon, 25 Oct 2010 11:52:49 +0000 (12:52 +0100)]
New API: lvm-canonical-lv-name: make LV name canonical.

When logical volume names appear in places like /etc/fstab
files they can have the form "/dev/mapper/foo-bar".  This
function takes such names and makes them canonical.

Note that this operation cannot be performed using the current
API, because 'guestfs_stat' does not work on device names, and
we don't really want to make a 'stat-device' call since that
exposes too much non-useful detail about the appliance.

With this patch you can do this:

><fs> debug ll /dev/mapper
total 8
drwxrwxr-x  2 root root   4096 Oct 25 12:51 .
drwxr-xr-x 16 root root   4096 Oct 25 12:51 ..
crw-------  1 root root 10, 62 Oct 25 12:51 control
lrwxrwxrwx  1 root root      7 Oct 25 12:51 vg_f13x64-lv_root -> ../dm-0
lrwxrwxrwx  1 root root      7 Oct 25 12:51 vg_f13x64-lv_swap -> ../dm-1

><fs> lvm-canonical-lv-name /dev/mapper/vg_f13x64-lv_root
/dev/vg_f13x64/lv_root
><fs> lvm-canonical-lv-name /dev/mapper/vg_f13x64-lv_swap
/dev/vg_f13x64/lv_swap
><fs> lvm-canonical-lv-name /dev/mapper/foo
libguestfs: error: lvm_canonical_lv_name: lvm_canonical_lv_name_stub: /dev/mapper/foo: No such file or directory
><fs> lvm-canonical-lv-name /dev/mapper/control
libguestfs: error: lvm_canonical_lv_name: /dev/mapper/control: not a logical volume
><fs> lvm-canonical-lv-name /dev/vg_f13x64/lv_root
/dev/vg_f13x64/lv_root

13 years agorescue: Add --network option.
Richard W.M. Jones [Wed, 27 Oct 2010 09:33:14 +0000 (10:33 +0100)]
rescue: Add --network option.

This enables networking in the rescue shell.

13 years agoDon't use kernel module whitelist with ext2-based appliance.
Richard W.M. Jones [Wed, 27 Oct 2010 09:31:41 +0000 (10:31 +0100)]
Don't use kernel module whitelist with ext2-based appliance.

Since the ext2-based appliance is cached, and since it is not
all loaded into memory (as with the initrd), we might as well
put all the kernel modules in there.

Note the kmod.whitelist.in file is still used for building the
ordinary appliance.

13 years agoFix networking in the appliance.
Matthew Booth [Wed, 27 Oct 2010 09:55:24 +0000 (10:55 +0100)]
Fix networking in the appliance.

Commit 4963be85 re-introduced networking to the appliance,
but didn't configure the custom network the appliance expects
since we switched to link local addressing. This patch
configures QEMU to use the custom network again.

Note that you still need to use guestfs_set_network (g, 1)
to enable user networking.

13 years agoDon't include control characters in BufferIn trace output (RHBZ#646822).
Matthew Booth [Tue, 26 Oct 2010 12:54:17 +0000 (13:54 +0100)]
Don't include control characters in BufferIn trace output (RHBZ#646822).

The example below shows what the output looks like for a large
random buffer.

$ guestfish -N fs -m /dev/sda1 -x -- \
    touch /test : \
    pwrite /test "$(dd if=/dev/urandom bs=128k count=1)" 0
[...]
pwrite "/test" "\x7f\xa0/\xb3\x80\xd3\xbc\xc3\xc3.\xb1\xe0\x1b\xafC\x06\xd5;\x0ajJ[o\xc1\xdd\xae\x1f\xce\xb2\x8d\xb3\xd0\x11\xcc$%\xe6<\xc7\xc7\xe7BU*\xc4l%\xaa\xea\xe9\x1an\xda]\xc6I\x0eC\xf9;\xec\x12a\x1f\xeaRH\xb2P\xd6+\xc4\xe6\xa5bW\x99\\x9d\xc8\x9bJ\xef\x99-\x16:h5\xe2\x0f\xa2\xa08\x9bU\x0b$\x138\xcf\xd4j\x9b\x83{%\xac0\xdaa1Xx\xbd`\x8e\xdd\x82\x87\x07\x98\xd2\x9ed\x8bq\xd0\x1f5\x8f\xab\xad4z1\xda\xc4b\xc1\xbc\x0f\xaa\xea\xc1\x15(\xfd1\xc2\x0bF\xe6\x9e\xb0+/g\\xab\xb0b\xde_\xca\xf9\xad\xe1?%\x17\xad\x98\xa4e\xc1\xe0f'\x89\xe9>\xff\xadhYi\xe7\x8c]%\xef\xe0\xa1R\xe5\xd5\x03K\xefI\xdf\xad\xd3\x82\xdb\x0f\xdd\xc3\x8f"\xf1G\xea\xf9r\xdd\xff\x88\x81\xb7\xf2\x0e\x0f\x1d;:\xf2F1\xdb\xb5D\xa1^\x928\xf5\x8e)\xab\xc4\xc3H(\xd0ol\xc6\xe4\xd6\xa3L\x1c\x06\xf4"<truncated, original size 130567 bytes> 0
[...]

13 years agodaemon: Print failed path in stat command errors.
Richard W.M. Jones [Mon, 25 Oct 2010 11:54:59 +0000 (12:54 +0100)]
daemon: Print failed path in stat command errors.

13 years agofish: Fix too-short allocation in tilde expansion (RHBZ#636061).
Karel Klíč [Mon, 25 Oct 2010 11:48:36 +0000 (12:48 +0100)]
fish: Fix too-short allocation in tilde expansion (RHBZ#636061).

13 years agoUpdate Polish translations (RHBZ#502533).
Piotr Drąg [Sat, 23 Oct 2010 11:52:35 +0000 (12:52 +0100)]
Update Polish translations (RHBZ#502533).

13 years agofish: Quote optional argument name in error message.
Richard W.M. Jones [Sat, 23 Oct 2010 09:45:25 +0000 (10:45 +0100)]
fish: Quote optional argument name in error message.

13 years agofish: Reject unknown opt args (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Sat, 23 Oct 2010 09:45:06 +0000 (10:45 +0100)]
fish: Reject unknown opt args (RHBZ#642934,CVE-2010-3851).

This updates commit 0c1d3c02a8147617ee0646e37d011235abdd2c22.

13 years agofuse: Add --format option to docs (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Sat, 23 Oct 2010 09:23:45 +0000 (10:23 +0100)]
fuse: Add --format option to docs (RHBZ#642934,CVE-2010-3851).

This updates commit 44c5ee1163918bd5c9e6aa6c292f0c3bb15b7b25.

Document the --format option in the guestmount manual page.

13 years agoVersion 1.5.23. 1.5.23
Richard W.M. Jones [Fri, 22 Oct 2010 22:12:16 +0000 (23:12 +0100)]
Version 1.5.23.

13 years agoresize: Specify format of input, output disk (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Fri, 22 Oct 2010 11:48:25 +0000 (12:48 +0100)]
resize: Specify format of input, output disk (RHBZ#642934,CVE-2010-3851).

This adds two new options: --format specifies the format of the
input disk, and --output-format specified the format of the output
disk.

Requiring the format of the output disk seems a bit strange at first:
after all, this is the disk that the virt-resize user has to create.
However it is needed because we sometimes reopen this disk, after
copying data over the first sector, and in theory a raw-format guest
could write a qcow2 header here and have it copied to the output
disk, which we would subsequently reopen.