12 years agoGenerate a dummy 'Fedora' fedora.img in images directory for use by tests.
Richard W.M. Jones [Thu, 11 Nov 2010 16:20:25 +0000 (16:20 +0000)]
Generate a dummy 'Fedora' fedora.img in images directory for use by tests.

We were generating this dummy 'Fedora' image already in the
tools directory.  It contains just enough Fedora-like files
to fool our inspection code and thus to test the tools.

This is general enough that we can use it everywhere.

12 years agoDefend all typedefs in <guestfs.h> with #ifdefs.
Richard W.M. Jones [Thu, 11 Nov 2010 12:14:37 +0000 (12:14 +0000)]
Defend all typedefs in <guestfs.h> with #ifdefs.

This allows other libraries to redefine those typedefs
if they need to use but not depend on <guestfs.h>.

12 years agolib: Make <guestfs.h> be completely generated.
Richard W.M. Jones [Thu, 11 Nov 2010 11:51:02 +0000 (11:51 +0000)]
lib: Make <guestfs.h> be completely generated.

This removes the 'not-quite-separate' guestfs-actions.h and
guestfs-structs.h files.

12 years agoFix small typo in a comment in src/
Richard W.M. Jones [Thu, 11 Nov 2010 11:49:49 +0000 (11:49 +0000)]
Fix small typo in a comment in src/

12 years agocapitests: Add the code to test (proposed) add-libvirt-dom C API.
Richard W.M. Jones [Wed, 10 Nov 2010 11:31:01 +0000 (11:31 +0000)]
capitests: Add the code to test (proposed) add-libvirt-dom C API.

This API was dropped as there are some problems with it.  This
commit adds the original test code, but commented out.

12 years agofish: Use core add-domain API to implement '-d' option.
Richard Jones [Tue, 9 Nov 2010 18:56:00 +0000 (18:56 +0000)]
fish: Use core add-domain API to implement '-d' option.

This also makes libxml2 and libvirt into optional dependencies.
If they are missing then the core API will print an error, as
will the '-d' option to guestfish.

12 years agoNew API: add-domain
Richard Jones [Tue, 9 Nov 2010 18:53:01 +0000 (18:53 +0000)]
New API: add-domain

This new API allows you to add the disks from a libvirt

In guestfish you can use the 'domain' command to access the
API, eg:

><fs> domain Fedora14 libvirturi:qemu:///system

The returned number is the number of disks that were added.

Also here is a proposed (but commented out) low-level API
which would allow you to add a domain from a virDomainPtr.
However there are several problems with this API -- see discussion
on the list:

12 years agogenerator: Add Pointer parameter type to the generator.
Richard Jones [Tue, 9 Nov 2010 12:08:06 +0000 (12:08 +0000)]
generator: Add Pointer parameter type to the generator.

This allows generic "foo *bar" pointers to be passed to
library functions (not to daemon functions).

In the language bindings (except Perl) these are handled
as generic int64s with the assumption being that any
pointer can be converted to and from this.  There is room
to add specific support for some pointer types in future
by specializing the match cases.  However this is inherently
tricky because it depends on the implementation details of
other bindings (eg. to support virDomainPtr in OCaml depends
on the implementation details of the ocaml-libvirt project).

Perl is slightly different in that you have to supply a
typemap.  Again this would depend on the implementation
detail of an external library unless you supplied a generic
typemap for int64.

12 years agoNew API: debug-cmdline for printing QEMU command line (internal only).
Richard W.M. Jones [Wed, 10 Nov 2010 10:32:33 +0000 (10:32 +0000)]
New API: debug-cmdline for printing QEMU command line (internal only).

This is an internal-only debugging API so may be changed or
removed at any time in the future.

12 years agoAdd internal facility to checkpoint and roll back the command line.
Richard Jones [Tue, 9 Nov 2010 18:50:57 +0000 (18:50 +0000)]
Add internal facility to checkpoint and roll back the command line.

This internal interface can be used to ensure that certain
operations are atomic.

12 years agolib: Make pcre, libmagic and hivex libraries optional.
Richard Jones [Tue, 9 Nov 2010 15:59:40 +0000 (15:59 +0000)]
lib: Make pcre, libmagic and hivex libraries optional.

This change makes these libraries optional.  If they are not
available at compile time then certain core API features will
be disabled (see below).

This also changes PCRE detection to use pkg-config instead
of the ad hoc autoconf checks.

The large inspect.c file has been split out into separate
function-specific files.

  file-architecture: requires pcre & libmagic
  inspection: requires pcre & hivex

12 years agoDon't include debug* commands in the documentation.
Richard W.M. Jones [Wed, 10 Nov 2010 10:32:12 +0000 (10:32 +0000)]
Don't include debug* commands in the documentation.

12 years agocapitests: Add whitespace in Makefile.
Richard W.M. Jones [Wed, 10 Nov 2010 10:51:46 +0000 (10:51 +0000)]
capitests: Add whitespace in Makefile.

12 years agoinspect: win64 regexp was dead code.
Richard Jones [Tue, 9 Nov 2010 15:10:32 +0000 (15:10 +0000)]
inspect: win64 regexp was dead code.

12 years agolib: Augeas (client side) is not needed by the library.
Richard Jones [Tue, 9 Nov 2010 14:50:23 +0000 (14:50 +0000)]
lib: Augeas (client side) is not needed by the library.

However it is used by the daemon.

12 years agoocaml: Error on compiler warnings.
Richard Jones [Tue, 9 Nov 2010 12:05:08 +0000 (12:05 +0000)]
ocaml: Error on compiler warnings.

12 years agoruby: Remove extra space before parenthesis.
Richard Jones [Tue, 9 Nov 2010 12:04:29 +0000 (12:04 +0000)]
ruby: Remove extra space before parenthesis.

12 years agoRevert "autogen: Touch ocaml/.depend"
Richard Jones [Mon, 8 Nov 2010 22:36:24 +0000 (22:36 +0000)]
Revert "autogen: Touch ocaml/.depend"

This reverts commit a0f85ba643990da25b6afe6a2bbd2407cf312c73.

12 years agoRevert "Remove ocaml/.depend from git."
Richard Jones [Mon, 8 Nov 2010 22:35:13 +0000 (22:35 +0000)]
Revert "Remove ocaml/.depend from git."

This reverts commit 064569bcbf854a9cf588ce31851d987d5f114ec8.

This commit does the wrong thing: creating an empty ocaml/.depend
file is wrong because building the OCaml bindings will fail.
Not having this file will prevent automake from running.  Therefore
this file has to exist with the correct content in git.

12 years agoVersion 1.7.3. 1.7.3
Richard W.M. Jones [Mon, 8 Nov 2010 15:52:07 +0000 (15:52 +0000)]
Version 1.7.3.

12 years agobuild: Create an AUTHORS file.
Richard W.M. Jones [Mon, 8 Nov 2010 15:29:35 +0000 (15:29 +0000)]
build: Create an AUTHORS file.

12 years agobuild: Don't try to rebuild po-docs/<lang> if no po4a.
Maxim Koltsov [Mon, 8 Nov 2010 15:10:14 +0000 (15:10 +0000)]
build: Don't try to rebuild po-docs/<lang> if no po4a.

12 years agobuild: Add ./configure --disable-php option.
Maxim Koltsov [Mon, 8 Nov 2010 15:08:01 +0000 (15:08 +0000)]
build: Add ./configure --disable-php option.

This disables the PHP language bindings.

12 years agobuild: Test for virt tools Perl libraries conditionally.
Richard W.M. Jones [Mon, 8 Nov 2010 14:53:48 +0000 (14:53 +0000)]
build: Test for virt tools Perl libraries conditionally.

Only test for these if $PERL is defined, and use $PERL as
the interpreter.

12 years agobuild: Add ./configure --disable-haskell option.
Maxim Koltsov [Mon, 8 Nov 2010 14:46:46 +0000 (14:46 +0000)]
build: Add ./configure --disable-haskell option.

This disables the Haskell language bindings.

12 years agobuild: Add ./configure --disable-ruby option.
Maxim Koltsov [Mon, 8 Nov 2010 14:35:13 +0000 (14:35 +0000)]
build: Add ./configure --disable-ruby option.

This disables the Ruby language bindings.

12 years agobuild: Warn if Python include or site-packages not found.
Maxim Koltsov [Mon, 8 Nov 2010 14:27:27 +0000 (14:27 +0000)]
build: Warn if Python include or site-packages not found.

12 years agobuild: Add ./configure --disable-python option.
Maxim Koltsov [Mon, 8 Nov 2010 14:24:59 +0000 (14:24 +0000)]
build: Add ./configure --disable-python option.

This disables the Python language bindings.

12 years agobuild: Add ./configure --disable-perl option.
Maxim Koltsov [Mon, 8 Nov 2010 14:16:15 +0000 (14:16 +0000)]
build: Add ./configure --disable-perl option.

This disables the Perl bindings.

12 years agoocaml: Remove the old OCaml viewer program.
Richard W.M. Jones [Mon, 8 Nov 2010 13:59:44 +0000 (13:59 +0000)]
ocaml: Remove the old OCaml viewer program.

This program is obsolete and the code has been reused for
guestfs-browser here:

12 years agobuild: Add ./configure --disable-ocaml option.
Maxim Koltsov [Mon, 8 Nov 2010 13:55:49 +0000 (13:55 +0000)]
build: Add ./configure --disable-ocaml option.

This can be used to disable the OCaml bindings.  Note that
OCaml is still required in any case where you need to rerun
the generator.

12 years agobuild: Add ./configure --disable-fuse option.
Maxim Koltsov [Mon, 8 Nov 2010 13:12:53 +0000 (13:12 +0000)]
build: Add ./configure --disable-fuse option.

If this option is specified, FUSE support is unconditionally

12 years agosupermin: If disabled, don't compile in supermin code or check for supermin.
Richard W.M. Jones [Mon, 8 Nov 2010 12:46:31 +0000 (12:46 +0000)]
supermin: If disabled, don't compile in supermin code or check for supermin.

If supermin is disabled at compile time and the user just wants to
use the ordinary appliance, there is no need to compile in all
the supermin code, and in particular there is no need to check
for the supermin appliance (which involves running
febootstrap-supermin-helper that probably doesn't exist).

This fixes a warning message observed under Debian w/o supermin:

  sh: febootstrap-supermin-helper: command not found

12 years agofish: Add --rw option (does nothing yet).
Richard W.M. Jones [Fri, 5 Nov 2010 18:36:02 +0000 (18:36 +0000)]
fish: Add --rw option (does nothing yet).

This adds the guestfish --rw option, intended in future
to be required for writing to disk images.

At the moment this does not change the default and so does
nothing.  This patch is intended for backporting to the
stable branches so that we can start to introduce scripts
which use 'guestfish --rw'.

12 years agoAdd missing generated files to the tarball (thanks maksbotan).
Richard W.M. Jones [Sun, 7 Nov 2010 09:54:51 +0000 (09:54 +0000)]
Add missing generated files to the tarball (thanks maksbotan).

C# bindings were omitted entirely.  Add a for this
directory even though we don't build these.

Because of a missing backslash, some POD files were not being

12 years agofish: Add --listen --csh to for csh, tcsh compatibility.
Richard W.M. Jones [Fri, 5 Nov 2010 15:17:45 +0000 (15:17 +0000)]
fish: Add --listen --csh to for csh, tcsh compatibility.

(Thanks Eric Blake).

12 years agofish: Suggest safer form of eval.
Richard W.M. Jones [Fri, 5 Nov 2010 15:07:11 +0000 (15:07 +0000)]
fish: Suggest safer form of eval.

eval "$(guestfish --listen)"

instead of various other forms.

(Thanks Eric Blake).

12 years agofish: More portable export sh statment.
Richard W.M. Jones [Fri, 5 Nov 2010 15:04:08 +0000 (15:04 +0000)]
fish: More portable export sh statment.

Don't depend on bash, but allow sh/dash/etc format:

(Thanks Eric Blake).

12 years agoNew API: inspect-get-roots to return roots from last inspection.
Richard W.M. Jones [Fri, 5 Nov 2010 13:43:08 +0000 (13:43 +0000)]
New API: inspect-get-roots to return roots from last inspection.

Return the roots found by the last call to inspect-os, but
without redoing the whole inspection.

12 years agogenerator: Don't die if an API call isn't listed in API versions file.
Richard W.M. Jones [Fri, 5 Nov 2010 13:42:07 +0000 (13:42 +0000)]
generator: Don't die if an API call isn't listed in API versions file.

For example, it may just have been added.

12 years agoVersion 1.7.2. 1.7.2
Richard W.M. Jones [Fri, 5 Nov 2010 12:20:21 +0000 (12:20 +0000)]
Version 1.7.2.

12 years agoconfigure: Test for 'kvm' binary.
Guido Günther [Fri, 5 Nov 2010 12:24:32 +0000 (12:24 +0000)]
configure: Test for 'kvm' binary.

12 years agoInclude <stdarg.h> in public header.
Guido Günther [Fri, 5 Nov 2010 12:23:11 +0000 (12:23 +0000)]
Include <stdarg.h> in public header.

Public headers use va_list, and this gives an error unless <stdarg.h>
had been included before the header.

12 years agoDon't print out key material in trace output.
Richard W.M. Jones [Fri, 5 Nov 2010 11:54:54 +0000 (11:54 +0000)]
Don't print out key material in trace output.

12 years agofish: '-i' option automatically handles whole-disk encryption.
Richard W.M. Jones [Fri, 5 Nov 2010 11:39:24 +0000 (11:39 +0000)]
fish: '-i' option automatically handles whole-disk encryption.

This feature is also available in guestmount because of the
shared option parsing code.

You don't need to do anything to enable it, just using -i
will attempt decryption of encrypted partitions.

Only works for simple Fedora whole-disk encryption.  It's a
work-in-progress to make it work for other types of encryption.

12 years agodocs: Fix API support script.
Richard W.M. Jones [Thu, 4 Nov 2010 17:43:17 +0000 (17:43 +0000)]
docs: Fix API support script.

Before libguestfs 1.0.69 we needed to look in src/guestfs.c to
see all the API calls.

12 years agofish: Fix missing guestfish commands in HTML docs.
Richard W.M. Jones [Thu, 4 Nov 2010 17:23:21 +0000 (17:23 +0000)]
fish: Fix missing guestfish commands in HTML docs.

12 years agofish: Make the 'help' command more helpful.
Richard W.M. Jones [Thu, 4 Nov 2010 17:04:03 +0000 (17:04 +0000)]
fish: Make the 'help' command more helpful.

12 years agodocs: Which API calls were first supported in which upstream versions.
Richard W.M. Jones [Thu, 4 Nov 2010 08:43:10 +0000 (08:43 +0000)]
docs: Which API calls were first supported in which upstream versions.

Run src/api-support/ (this won't work
unless you have a local copy of the tarballs from the website).

src/api-support/added contains the result of running the
script, a list of pairs: (API name, version first appeared).

12 years agovirt-win-reg: Current is the control set Windows chooses at boot.
Richard W.M. Jones [Wed, 3 Nov 2010 23:17:51 +0000 (23:17 +0000)]
virt-win-reg: Current is the control set Windows chooses at boot.

12 years agoHACKING: Mention PHP bindings.
Richard W.M. Jones [Wed, 3 Nov 2010 22:23:55 +0000 (22:23 +0000)]
HACKING: Mention PHP bindings.

12 years agodocs: Indent *_va and *_argv functions correctly.
Richard W.M. Jones [Wed, 3 Nov 2010 22:11:22 +0000 (22:11 +0000)]
docs: Indent *_va and *_argv functions correctly.

This fixes commit f661db2c393d1b7e4211c55682b7fac82a70e36d.

12 years agoVersion 1.7.1. 1.7.1
Richard W.M. Jones [Wed, 3 Nov 2010 21:09:51 +0000 (21:09 +0000)]
Version 1.7.1.

12 years agofish: Use a perfect hash for faster command lookups.
Richard W.M. Jones [Wed, 3 Nov 2010 20:34:42 +0000 (20:34 +0000)]
fish: Use a perfect hash for faster command lookups.

Existing command lookups are approx O(n^2).  Replace this
with a perfect hash implementation which should be a lot

12 years agogenerator: Properly lay out and indent multi-line C function decls.
Richard W.M. Jones [Wed, 3 Nov 2010 19:26:10 +0000 (19:26 +0000)]
generator: Properly lay out and indent multi-line C function decls.

12 years agodocs: Clarify no additional error available from guestfs_create.
Richard W.M. Jones [Wed, 3 Nov 2010 18:33:31 +0000 (18:33 +0000)]
docs: Clarify no additional error available from guestfs_create.

12 years agodocs: Clarify default error handler.
Richard W.M. Jones [Wed, 3 Nov 2010 18:29:58 +0000 (18:29 +0000)]
docs: Clarify default error handler.

12 years agodocs: Error strings are in fact localized, documentation was wrong.
Richard W.M. Jones [Wed, 3 Nov 2010 18:02:08 +0000 (18:02 +0000)]
docs: Error strings are in fact localized, documentation was wrong.

12 years agodocs: Clarify, not every function that returns int returns -1 for errors.
Richard W.M. Jones [Wed, 3 Nov 2010 18:01:48 +0000 (18:01 +0000)]
docs: Clarify, not every function that returns int returns -1 for errors.

12 years agocapitests: Test guestfs_last_errno call.
Richard W.M. Jones [Wed, 3 Nov 2010 17:24:50 +0000 (17:24 +0000)]
capitests: Test guestfs_last_errno call.

12 years agofuse: Use guestfs_last_errno instead of errno-reversal-hack.
Richard W.M. Jones [Wed, 3 Nov 2010 16:15:48 +0000 (16:15 +0000)]
fuse: Use guestfs_last_errno instead of errno-reversal-hack.

12 years agolib: Expose errno through new API guestfs_last_errno.
Richard W.M. Jones [Wed, 3 Nov 2010 15:49:36 +0000 (15:49 +0000)]
lib: Expose errno through new API guestfs_last_errno.

If either the daemon sends back an errno, or a system call
fails in the library, save the errno in the handle and then
make it available to callers through the guestfs_last_errno

12 years agodaemon: Send back the errno as a string.
Richard W.M. Jones [Wed, 3 Nov 2010 12:53:00 +0000 (12:53 +0000)]
daemon: Send back the errno as a string.

This changes the protocol again so that if the errno is available,
it is converted to a string (like "EIO") and sent back over the
protocol to the library.

In this commit the library just discards the string.

12 years agocapitests: Test guestfs_add_drive_opts with optional args from C.
Richard W.M. Jones [Wed, 3 Nov 2010 17:00:29 +0000 (17:00 +0000)]
capitests: Test guestfs_add_drive_opts with optional args from C.

12 years agocapitests: Test some basic aspects of the C API.
Richard W.M. Jones [Wed, 3 Nov 2010 16:56:34 +0000 (16:56 +0000)]
capitests: Test some basic aspects of the C API.

12 years agocapitests: Use ftruncate instead of seek + write to create test files.
Richard W.M. Jones [Wed, 3 Nov 2010 17:37:07 +0000 (17:37 +0000)]
capitests: Use ftruncate instead of seek + write to create test files.

12 years agocapitests: Don't open test files with O_NONBLOCK.
Richard W.M. Jones [Wed, 3 Nov 2010 17:34:27 +0000 (17:34 +0000)]
capitests: Don't open test files with O_NONBLOCK.

I have no idea why we were doing this.

12 years agocapitests: Set path in TESTS_ENVIRONMENT instead of in tests.c
Richard W.M. Jones [Wed, 3 Nov 2010 17:26:00 +0000 (17:26 +0000)]
capitests: Set path in TESTS_ENVIRONMENT instead of in tests.c

By exporting LIBGUESTFS_PATH with the right path to the appliance,
we no longer need to hard code the path in tests.c

12 years agogenerator: Remove unnecessary macro redefinitions.
Richard W.M. Jones [Wed, 3 Nov 2010 15:46:46 +0000 (15:46 +0000)]
generator: Remove unnecessary macro redefinitions.

These macros are already defined in guestfs-internals.h

12 years agoDefine internal safe_calloc shorthand.
Richard W.M. Jones [Wed, 3 Nov 2010 15:48:04 +0000 (15:48 +0000)]
Define internal safe_calloc shorthand.

12 years agodaemon: Don't use ../src path to include generator_protocol.h
Richard W.M. Jones [Wed, 3 Nov 2010 12:52:24 +0000 (12:52 +0000)]
daemon: Don't use ../src path to include generator_protocol.h

This file is already hard-linked into the current directory, so
the relative path is not required.

12 years agotests: Remove use of sfdisk from tests.
Richard W.M. Jones [Tue, 2 Nov 2010 20:57:40 +0000 (20:57 +0000)]
tests: Remove use of sfdisk from tests.

Some older tests used sfdisk to create partitions for the
tests.  sfdisk is buggy (more so than parted -- what is it
with partitioning tools?) so replace these tests with
equivalent part-* commands.

12 years agodaemon: Tolerate failure of blockdev --rereadpt after sfdisk.
Richard W.M. Jones [Tue, 2 Nov 2010 20:33:06 +0000 (20:33 +0000)]
daemon: Tolerate failure of blockdev --rereadpt after sfdisk.

See commit 840536ea5a0568296dfd3e483442c76b93c5a949
and commit 956fc5a3feacc970ea763697bf28fb686c875408.

12 years agobinary: Link guestmount static binary with -lm.
Richard W.M. Jones [Tue, 2 Nov 2010 17:05:58 +0000 (17:05 +0000)]
binary: Link guestmount static binary with -lm.

This is indirectly required via the new shared guestfish
C inspection code by libxml2.

12 years agowebsite: Distribute BUGS and RELEASE-NOTES files to website.
Richard W.M. Jones [Tue, 2 Nov 2010 17:05:43 +0000 (17:05 +0000)]
website: Distribute BUGS and RELEASE-NOTES files to website.

12 years agoVersion 1.7.0. 1.7.0
Richard W.M. Jones [Tue, 2 Nov 2010 16:23:58 +0000 (16:23 +0000)]
Version 1.7.0.

12 years agoFinal RELEASE-NOTES file for version 1.6.0.
Richard W.M. Jones [Tue, 2 Nov 2010 16:18:30 +0000 (16:18 +0000)]
Final RELEASE-NOTES file for version 1.6.0.

12 years agoinspect: Add support for MeeGo.
Richard W.M. Jones [Tue, 2 Nov 2010 10:11:04 +0000 (10:11 +0000)]
inspect: Add support for MeeGo.

12 years agoVersion 1.5.26. 1.5.26
Richard W.M. Jones [Fri, 29 Oct 2010 14:49:36 +0000 (15:49 +0100)]
Version 1.5.26.

12 years agoinspect: Add support for Ubuntu.
Richard Jones [Fri, 29 Oct 2010 10:54:34 +0000 (11:54 +0100)]
inspect: Add support for Ubuntu.

12 years agoinspect: Add detection of Gentoo.
Richard Jones [Fri, 29 Oct 2010 09:53:05 +0000 (10:53 +0100)]
inspect: Add detection of Gentoo.

12 years agoinspect: Add detection of Arch Linux.
Richard Jones [Fri, 29 Oct 2010 09:32:53 +0000 (10:32 +0100)]
inspect: Add detection of Arch Linux.

12 years agoinspect: Add detection of Pardus.
Richard Jones [Fri, 29 Oct 2010 09:21:33 +0000 (10:21 +0100)]
inspect: Add detection of Pardus.

12 years agoinspect: Generic parsing of MAJOR.MINOR in product names.
Richard Jones [Fri, 29 Oct 2010 09:50:39 +0000 (10:50 +0100)]
inspect: Generic parsing of MAJOR.MINOR in product names.

12 years agoinspect: Generic parsing of release files.
Richard Jones [Fri, 29 Oct 2010 09:49:38 +0000 (10:49 +0100)]
inspect: Generic parsing of release files.

12 years agoinspector: Sort <filesystems> section.
Richard Jones [Fri, 29 Oct 2010 09:23:28 +0000 (10:23 +0100)]
inspector: Sort <filesystems> section.

12 years agoinspect: Ignore Pardus "/.swap" swapfile.
Richard W.M. Jones [Fri, 29 Oct 2010 08:46:59 +0000 (09:46 +0100)]
inspect: Ignore Pardus "/.swap" swapfile.

12 years agoautogen: Touch ocaml/.depend
Richard Jones [Fri, 29 Oct 2010 08:53:57 +0000 (09:53 +0100)]
autogen: Touch ocaml/.depend

12 years agoinspector: List Debian packages.
Richard W.M. Jones [Thu, 28 Oct 2010 21:56:11 +0000 (22:56 +0100)]
inspector: List Debian packages.

List Debian packages by downloading and parsing the file

12 years agoinspector: Introductory documentation for XML format.
Richard W.M. Jones [Thu, 28 Oct 2010 21:32:50 +0000 (22:32 +0100)]
inspector: Introductory documentation for XML format.

12 years agoinspector: Debian package format 'deb' instead of 'dpkg'.
Richard W.M. Jones [Thu, 28 Oct 2010 21:32:05 +0000 (22:32 +0100)]
inspector: Debian package format 'deb' instead of 'dpkg'.

12 years agoinspector: Return canonical block device paths in XML.
Richard W.M. Jones [Thu, 28 Oct 2010 21:29:43 +0000 (22:29 +0100)]
inspector: Return canonical block device paths in XML.

12 years agoVersion 1.5.25. 1.5.25
Richard W.M. Jones [Thu, 28 Oct 2010 17:46:13 +0000 (18:46 +0100)]
Version 1.5.25.

12 years agoEnsure atomic creation of a cached appliance
Matthew Booth [Thu, 28 Oct 2010 14:19:14 +0000 (15:19 +0100)]
Ensure atomic creation of a cached appliance

Cached appliances are discovered by their predictable path. Previously we were
creating a cached appliance directly in this predictable path. This had at least
2 undesirable effects:

* Interrupting appliance creation would leave a corrupt appliance
* 2 processes could simultaneously attempt to create the same appliance, causing

This patch causes the cached appliance to be created in a temporary directory,
and then renamed to the predictable path. As rename is an atomic operation, this
makes the whole creation atomic.

This patch also changes the predictable path to have a prefix of 'guestfs.'.
This will make it simpler for system administrators to clean up old cached

This patch resolves RHBZ#639405

12 years agoCall febootstrap-supermin-helper using the new -u and -g options
Matthew Booth [Thu, 28 Oct 2010 14:19:13 +0000 (15:19 +0100)]
Call febootstrap-supermin-helper using the new -u and -g options

Use febootstrap-supermin-helper's new -u and -g command line options to setuid,
rather than doing it in libguestfs.

This resolves an issue with the generation of the cached appliance checksum. The
checksum was being generated by a call to febootstrap-supermin-helper through
popen(). Unfortunately, a bash misfeature meant that euid would be reset to uid,
and the checksum was generated for uid, not euid. When virt-v2v is writing to a
RHEV target, uid == 0 and euid == 36, which resulted in a cached appliance being
created for root with permissions for uid 36.

Note this requires febootstrap 2.10.

12 years agoLog the febootstrap-supermin-helper command line
Matthew Booth [Thu, 28 Oct 2010 14:19:12 +0000 (15:19 +0100)]
Log the febootstrap-supermin-helper command line

A side-effect of change 17e7cb9937a63ed8f9bb0fb6ac7302758be76846 was the the
febootstrap-supermin-helper was no longer logged. This change adds it back using
the new guestfs___print_timestamped_argv internal function.

12 years agoNew internal function guestfs___print_timestamped_argv
Matthew Booth [Thu, 28 Oct 2010 14:19:11 +0000 (15:19 +0100)]
New internal function guestfs___print_timestamped_argv

This function generalises the existing print_cmdline used to output the qemu
command line to output any given command line, and exports it to other modules.
It also adds a timestamp to the old print_cmdline output for consistency with

12 years agolist-filesystems: Use core list-filesystems API (RHBZ#642933).
Richard W.M. Jones [Thu, 28 Oct 2010 12:41:12 +0000 (13:41 +0100)]
list-filesystems: Use core list-filesystems API (RHBZ#642933).

Change virt-list-filesystems to use the core inspection API
instead of the deprecated Sys::Guestfs::Lib::get_partitions

12 years agoSys::Guestfs::Lib: deprecate get_partitions (RHBZ#642933).
Richard W.M. Jones [Thu, 28 Oct 2010 12:40:23 +0000 (13:40 +0100)]
Sys::Guestfs::Lib: deprecate get_partitions (RHBZ#642933).

However the code is left since this function is used
by virt-v2v amongst others.

12 years agoinspector: Rewrite virt-inspector (RHBZ#642930).
Richard W.M. Jones [Thu, 28 Oct 2010 10:31:23 +0000 (11:31 +0100)]
inspector: Rewrite virt-inspector (RHBZ#642930).

Rewrite virt-inspector:

 - remove old and unsupportable features
 - use the C inspection API
 - don't run programs from the guest

The RNG has been updated to reflect the new XML-only output.

The new example files show the new XML output.