libguestfs.git
9 years agocapitests: Test guestfs_add_drive_opts with optional args from C.
Richard W.M. Jones [Wed, 3 Nov 2010 17:00:29 +0000 (17:00 +0000)]
capitests: Test guestfs_add_drive_opts with optional args from C.

9 years agocapitests: Test some basic aspects of the C API.
Richard W.M. Jones [Wed, 3 Nov 2010 16:56:34 +0000 (16:56 +0000)]
capitests: Test some basic aspects of the C API.

9 years agocapitests: Use ftruncate instead of seek + write to create test files.
Richard W.M. Jones [Wed, 3 Nov 2010 17:37:07 +0000 (17:37 +0000)]
capitests: Use ftruncate instead of seek + write to create test files.

9 years agocapitests: Don't open test files with O_NONBLOCK.
Richard W.M. Jones [Wed, 3 Nov 2010 17:34:27 +0000 (17:34 +0000)]
capitests: Don't open test files with O_NONBLOCK.

I have no idea why we were doing this.

9 years agocapitests: Set path in TESTS_ENVIRONMENT instead of in tests.c
Richard W.M. Jones [Wed, 3 Nov 2010 17:26:00 +0000 (17:26 +0000)]
capitests: Set path in TESTS_ENVIRONMENT instead of in tests.c

By exporting LIBGUESTFS_PATH with the right path to the appliance,
we no longer need to hard code the path in tests.c

9 years agogenerator: Remove unnecessary macro redefinitions.
Richard W.M. Jones [Wed, 3 Nov 2010 15:46:46 +0000 (15:46 +0000)]
generator: Remove unnecessary macro redefinitions.

These macros are already defined in guestfs-internals.h

9 years agoDefine internal safe_calloc shorthand.
Richard W.M. Jones [Wed, 3 Nov 2010 15:48:04 +0000 (15:48 +0000)]
Define internal safe_calloc shorthand.

9 years agodaemon: Don't use ../src path to include generator_protocol.h
Richard W.M. Jones [Wed, 3 Nov 2010 12:52:24 +0000 (12:52 +0000)]
daemon: Don't use ../src path to include generator_protocol.h

This file is already hard-linked into the current directory, so
the relative path is not required.

9 years agotests: Remove use of sfdisk from tests.
Richard W.M. Jones [Tue, 2 Nov 2010 20:57:40 +0000 (20:57 +0000)]
tests: Remove use of sfdisk from tests.

Some older tests used sfdisk to create partitions for the
tests.  sfdisk is buggy (more so than parted -- what is it
with partitioning tools?) so replace these tests with
equivalent part-* commands.

9 years agodaemon: Tolerate failure of blockdev --rereadpt after sfdisk.
Richard W.M. Jones [Tue, 2 Nov 2010 20:33:06 +0000 (20:33 +0000)]
daemon: Tolerate failure of blockdev --rereadpt after sfdisk.

See commit 840536ea5a0568296dfd3e483442c76b93c5a949
and commit 956fc5a3feacc970ea763697bf28fb686c875408.

9 years agobinary: Link guestmount static binary with -lm.
Richard W.M. Jones [Tue, 2 Nov 2010 17:05:58 +0000 (17:05 +0000)]
binary: Link guestmount static binary with -lm.

This is indirectly required via the new shared guestfish
C inspection code by libxml2.

9 years agowebsite: Distribute BUGS and RELEASE-NOTES files to website.
Richard W.M. Jones [Tue, 2 Nov 2010 17:05:43 +0000 (17:05 +0000)]
website: Distribute BUGS and RELEASE-NOTES files to website.

9 years agoVersion 1.7.0. 1.7.0
Richard W.M. Jones [Tue, 2 Nov 2010 16:23:58 +0000 (16:23 +0000)]
Version 1.7.0.

9 years agoFinal RELEASE-NOTES file for version 1.6.0.
Richard W.M. Jones [Tue, 2 Nov 2010 16:18:30 +0000 (16:18 +0000)]
Final RELEASE-NOTES file for version 1.6.0.

9 years agoinspect: Add support for MeeGo.
Richard W.M. Jones [Tue, 2 Nov 2010 10:11:04 +0000 (10:11 +0000)]
inspect: Add support for MeeGo.

9 years agoVersion 1.5.26. 1.5.26
Richard W.M. Jones [Fri, 29 Oct 2010 14:49:36 +0000 (15:49 +0100)]
Version 1.5.26.

9 years agoinspect: Add support for Ubuntu.
Richard Jones [Fri, 29 Oct 2010 10:54:34 +0000 (11:54 +0100)]
inspect: Add support for Ubuntu.

9 years agoinspect: Add detection of Gentoo.
Richard Jones [Fri, 29 Oct 2010 09:53:05 +0000 (10:53 +0100)]
inspect: Add detection of Gentoo.

9 years agoinspect: Add detection of Arch Linux.
Richard Jones [Fri, 29 Oct 2010 09:32:53 +0000 (10:32 +0100)]
inspect: Add detection of Arch Linux.

9 years agoinspect: Add detection of Pardus.
Richard Jones [Fri, 29 Oct 2010 09:21:33 +0000 (10:21 +0100)]
inspect: Add detection of Pardus.

9 years agoinspect: Generic parsing of MAJOR.MINOR in product names.
Richard Jones [Fri, 29 Oct 2010 09:50:39 +0000 (10:50 +0100)]
inspect: Generic parsing of MAJOR.MINOR in product names.

9 years agoinspect: Generic parsing of release files.
Richard Jones [Fri, 29 Oct 2010 09:49:38 +0000 (10:49 +0100)]
inspect: Generic parsing of release files.

9 years agoinspector: Sort <filesystems> section.
Richard Jones [Fri, 29 Oct 2010 09:23:28 +0000 (10:23 +0100)]
inspector: Sort <filesystems> section.

9 years agoinspect: Ignore Pardus "/.swap" swapfile.
Richard W.M. Jones [Fri, 29 Oct 2010 08:46:59 +0000 (09:46 +0100)]
inspect: Ignore Pardus "/.swap" swapfile.

9 years agoautogen: Touch ocaml/.depend
Richard Jones [Fri, 29 Oct 2010 08:53:57 +0000 (09:53 +0100)]
autogen: Touch ocaml/.depend

9 years agoinspector: List Debian packages.
Richard W.M. Jones [Thu, 28 Oct 2010 21:56:11 +0000 (22:56 +0100)]
inspector: List Debian packages.

List Debian packages by downloading and parsing the file
/var/lib/dpkg/status.

9 years agoinspector: Introductory documentation for XML format.
Richard W.M. Jones [Thu, 28 Oct 2010 21:32:50 +0000 (22:32 +0100)]
inspector: Introductory documentation for XML format.

9 years agoinspector: Debian package format 'deb' instead of 'dpkg'.
Richard W.M. Jones [Thu, 28 Oct 2010 21:32:05 +0000 (22:32 +0100)]
inspector: Debian package format 'deb' instead of 'dpkg'.

9 years agoinspector: Return canonical block device paths in XML.
Richard W.M. Jones [Thu, 28 Oct 2010 21:29:43 +0000 (22:29 +0100)]
inspector: Return canonical block device paths in XML.

9 years agoVersion 1.5.25. 1.5.25
Richard W.M. Jones [Thu, 28 Oct 2010 17:46:13 +0000 (18:46 +0100)]
Version 1.5.25.

9 years agoEnsure atomic creation of a cached appliance
Matthew Booth [Thu, 28 Oct 2010 14:19:14 +0000 (15:19 +0100)]
Ensure atomic creation of a cached appliance

Cached appliances are discovered by their predictable path. Previously we were
creating a cached appliance directly in this predictable path. This had at least
2 undesirable effects:

* Interrupting appliance creation would leave a corrupt appliance
* 2 processes could simultaneously attempt to create the same appliance, causing
  corruption.

This patch causes the cached appliance to be created in a temporary directory,
and then renamed to the predictable path. As rename is an atomic operation, this
makes the whole creation atomic.

This patch also changes the predictable path to have a prefix of 'guestfs.'.
This will make it simpler for system administrators to clean up old cached
appliances.

This patch resolves RHBZ#639405

9 years agoCall febootstrap-supermin-helper using the new -u and -g options
Matthew Booth [Thu, 28 Oct 2010 14:19:13 +0000 (15:19 +0100)]
Call febootstrap-supermin-helper using the new -u and -g options

Use febootstrap-supermin-helper's new -u and -g command line options to setuid,
rather than doing it in libguestfs.

This resolves an issue with the generation of the cached appliance checksum. The
checksum was being generated by a call to febootstrap-supermin-helper through
popen(). Unfortunately, a bash misfeature meant that euid would be reset to uid,
and the checksum was generated for uid, not euid. When virt-v2v is writing to a
RHEV target, uid == 0 and euid == 36, which resulted in a cached appliance being
created for root with permissions for uid 36.

Note this requires febootstrap 2.10.

9 years agoLog the febootstrap-supermin-helper command line
Matthew Booth [Thu, 28 Oct 2010 14:19:12 +0000 (15:19 +0100)]
Log the febootstrap-supermin-helper command line

A side-effect of change 17e7cb9937a63ed8f9bb0fb6ac7302758be76846 was the the
febootstrap-supermin-helper was no longer logged. This change adds it back using
the new guestfs___print_timestamped_argv internal function.

9 years agoNew internal function guestfs___print_timestamped_argv
Matthew Booth [Thu, 28 Oct 2010 14:19:11 +0000 (15:19 +0100)]
New internal function guestfs___print_timestamped_argv

This function generalises the existing print_cmdline used to output the qemu
command line to output any given command line, and exports it to other modules.
It also adds a timestamp to the old print_cmdline output for consistency with
guestfs___print_timestamped_message.

9 years agolist-filesystems: Use core list-filesystems API (RHBZ#642933).
Richard W.M. Jones [Thu, 28 Oct 2010 12:41:12 +0000 (13:41 +0100)]
list-filesystems: Use core list-filesystems API (RHBZ#642933).

Change virt-list-filesystems to use the core inspection API
instead of the deprecated Sys::Guestfs::Lib::get_partitions
function.

9 years agoSys::Guestfs::Lib: deprecate get_partitions (RHBZ#642933).
Richard W.M. Jones [Thu, 28 Oct 2010 12:40:23 +0000 (13:40 +0100)]
Sys::Guestfs::Lib: deprecate get_partitions (RHBZ#642933).

However the code is left since this function is used
by virt-v2v amongst others.

9 years agoinspector: Rewrite virt-inspector (RHBZ#642930).
Richard W.M. Jones [Thu, 28 Oct 2010 10:31:23 +0000 (11:31 +0100)]
inspector: Rewrite virt-inspector (RHBZ#642930).

Rewrite virt-inspector:

 - remove old and unsupportable features
 - use the C inspection API
 - don't run programs from the guest

The RNG has been updated to reflect the new XML-only output.

The new example files show the new XML output.

9 years agotools: Use C API for inspection (RHBZ#642930).
Richard W.M. Jones [Wed, 27 Oct 2010 15:06:11 +0000 (16:06 +0100)]
tools: Use C API for inspection (RHBZ#642930).

Update the following tools to use the C API for inspection:

 - virt-cat
 - virt-edit
 - virt-ls
 - virt-tar
 - virt-win-reg

None of the tools in the tools/ directory now use the deprecated
Perl inspection APIs.

9 years agoNew API: inspect-get-windows-systemroot to get systemroot.
Richard W.M. Jones [Wed, 27 Oct 2010 15:47:33 +0000 (16:47 +0100)]
New API: inspect-get-windows-systemroot to get systemroot.

We are already using heuristics in the C inspection code to
determine the Windows %SYSTEMROOT% directory.  This change
just exposes this information through the API.

9 years agoSys::Guestfs::Lib: deprecate inspection functions (RHBZ#642930).
Richard W.M. Jones [Wed, 27 Oct 2010 14:47:45 +0000 (15:47 +0100)]
Sys::Guestfs::Lib: deprecate inspection functions (RHBZ#642930).

Deprecate the guest inspection functions in this module, remove
documentation, and point users at the core API functions instead.

However we will keep the code here since it is used by virt-v2v
and virt-inspector.

9 years agodaemon: Fix /dev/mapper paths from mounts and mountpoints (RHBZ#646432).
Richard W.M. Jones [Wed, 27 Oct 2010 13:51:17 +0000 (14:51 +0100)]
daemon: Fix /dev/mapper paths from mounts and mountpoints (RHBZ#646432).

Make the LV paths returned by these two commands canonical.

9 years agoedit: Clean up tmp file handling in virt-edit.
Richard W.M. Jones [Thu, 28 Oct 2010 10:58:56 +0000 (11:58 +0100)]
edit: Clean up tmp file handling in virt-edit.

This was probably not a security issue, but this change
makes the code cleaner by not opening the tmp file twice.

Also be more careful about error checking in close syscall.

9 years agodoc: Warn about security implications of running commands.
Richard W.M. Jones [Wed, 27 Oct 2010 16:32:21 +0000 (17:32 +0100)]
doc: Warn about security implications of running commands.

9 years agovirt-ls: Small fix to documentation.
Richard W.M. Jones [Wed, 27 Oct 2010 14:33:35 +0000 (15:33 +0100)]
virt-ls: Small fix to documentation.

9 years agoRemove ocaml/.depend from git.
Matthew Booth [Thu, 28 Oct 2010 14:15:07 +0000 (15:15 +0100)]
Remove ocaml/.depend from git.

ocaml/.depend is automatically generated. This patch removes it from git.

9 years agoVersion 1.5.24. 1.5.24
Richard W.M. Jones [Wed, 27 Oct 2010 11:21:02 +0000 (12:21 +0100)]
Version 1.5.24.

9 years agoDisable test for RHBZ#576879 comment 5.
Richard W.M. Jones [Wed, 27 Oct 2010 11:17:26 +0000 (12:17 +0100)]
Disable test for RHBZ#576879 comment 5.

This test has started to hang, for reasons we don't understand.

9 years agoUnify guestfish and guestmount options processing (RHBZ#642932).
Richard W.M. Jones [Tue, 26 Oct 2010 14:28:28 +0000 (15:28 +0100)]
Unify guestfish and guestmount options processing (RHBZ#642932).

In guestfish, factor out the processing of the options -a, -c,
-d, -i, -m, -n, -r, -v, -V, -x into a separate set of files:
options.c, options.h, inspect.c, virt.c.

Change guestmount so that it uses these same files (from the
../fish directory) to process the same options.

This unifies the handling of these options between the two programs.
It also adds the useful inspection feature to guestmount, so you
can now do:

  guestmount -d Guest -i --ro mnt/

9 years agodf: Add --uuid option to print guest UUIDs instead of names (RHBZ#646821).
Richard W.M. Jones [Tue, 26 Oct 2010 12:01:47 +0000 (13:01 +0100)]
df: Add --uuid option to print guest UUIDs instead of names (RHBZ#646821).

9 years agotodo: Remove obsolete items from TODO file.
Richard W.M. Jones [Tue, 26 Oct 2010 11:46:26 +0000 (12:46 +0100)]
todo: Remove obsolete items from TODO file.

9 years agoDocument problems mixing mkmountpoint and umount-all (RHBZ#599503).
Richard W.M. Jones [Tue, 26 Oct 2010 09:44:11 +0000 (10:44 +0100)]
Document problems mixing mkmountpoint and umount-all (RHBZ#599503).

9 years agoappliance: Repo name is not Fedora-specific.
Richard W.M. Jones [Tue, 26 Oct 2010 09:04:56 +0000 (10:04 +0100)]
appliance: Repo name is not Fedora-specific.

The --with-repo parameter is also used by Debian to specify
the Debian software repository, so remove references to
Fedora.

9 years agoappliance: Remove repo from appliance filename (RHBZ#638901).
Richard W.M. Jones [Tue, 26 Oct 2010 09:03:50 +0000 (10:03 +0100)]
appliance: Remove repo from appliance filename (RHBZ#638901).

There's no need to have the appliance filename contain the
repository name it was built from, and this change gives
downstream users more freedom to mix and match libraries
and appliances if they want to.

9 years agoinspection: Ignore floppy disks and CD-ROM drives (RHBZ#642929).
Richard W.M. Jones [Tue, 26 Oct 2010 08:56:55 +0000 (09:56 +0100)]
inspection: Ignore floppy disks and CD-ROM drives (RHBZ#642929).

9 years agoEnable autosync by default.
Richard W.M. Jones [Mon, 25 Oct 2010 12:22:17 +0000 (13:22 +0100)]
Enable autosync by default.

9 years ago/dev/mapper paths should not be returned from C inspection APIs (RHBZ#638899).
Richard W.M. Jones [Mon, 25 Oct 2010 11:59:50 +0000 (12:59 +0100)]
/dev/mapper paths should not be returned from C inspection APIs (RHBZ#638899).

With this patch, /dev/mapper paths do not appear in the output
of guestfs_inspect_os, as you can see from this example:

Welcome to guestfish, the libguestfs filesystem interactive shell for
editing virtual machine filesystems.

Type: 'help' for a list of commands
      'man' to read the manual
      'quit' to quit the shell

Operating system: Fedora release 13 (Goddard)
/dev/vg_f13x64/lv_root mounted on /              <--- NB
/dev/vda1 mounted on /boot

9 years agoNew API: lvm-canonical-lv-name: make LV name canonical.
Richard W.M. Jones [Mon, 25 Oct 2010 11:52:49 +0000 (12:52 +0100)]
New API: lvm-canonical-lv-name: make LV name canonical.

When logical volume names appear in places like /etc/fstab
files they can have the form "/dev/mapper/foo-bar".  This
function takes such names and makes them canonical.

Note that this operation cannot be performed using the current
API, because 'guestfs_stat' does not work on device names, and
we don't really want to make a 'stat-device' call since that
exposes too much non-useful detail about the appliance.

With this patch you can do this:

><fs> debug ll /dev/mapper
total 8
drwxrwxr-x  2 root root   4096 Oct 25 12:51 .
drwxr-xr-x 16 root root   4096 Oct 25 12:51 ..
crw-------  1 root root 10, 62 Oct 25 12:51 control
lrwxrwxrwx  1 root root      7 Oct 25 12:51 vg_f13x64-lv_root -> ../dm-0
lrwxrwxrwx  1 root root      7 Oct 25 12:51 vg_f13x64-lv_swap -> ../dm-1

><fs> lvm-canonical-lv-name /dev/mapper/vg_f13x64-lv_root
/dev/vg_f13x64/lv_root
><fs> lvm-canonical-lv-name /dev/mapper/vg_f13x64-lv_swap
/dev/vg_f13x64/lv_swap
><fs> lvm-canonical-lv-name /dev/mapper/foo
libguestfs: error: lvm_canonical_lv_name: lvm_canonical_lv_name_stub: /dev/mapper/foo: No such file or directory
><fs> lvm-canonical-lv-name /dev/mapper/control
libguestfs: error: lvm_canonical_lv_name: /dev/mapper/control: not a logical volume
><fs> lvm-canonical-lv-name /dev/vg_f13x64/lv_root
/dev/vg_f13x64/lv_root

9 years agorescue: Add --network option.
Richard W.M. Jones [Wed, 27 Oct 2010 09:33:14 +0000 (10:33 +0100)]
rescue: Add --network option.

This enables networking in the rescue shell.

9 years agoDon't use kernel module whitelist with ext2-based appliance.
Richard W.M. Jones [Wed, 27 Oct 2010 09:31:41 +0000 (10:31 +0100)]
Don't use kernel module whitelist with ext2-based appliance.

Since the ext2-based appliance is cached, and since it is not
all loaded into memory (as with the initrd), we might as well
put all the kernel modules in there.

Note the kmod.whitelist.in file is still used for building the
ordinary appliance.

9 years agoFix networking in the appliance.
Matthew Booth [Wed, 27 Oct 2010 09:55:24 +0000 (10:55 +0100)]
Fix networking in the appliance.

Commit 4963be85 re-introduced networking to the appliance,
but didn't configure the custom network the appliance expects
since we switched to link local addressing. This patch
configures QEMU to use the custom network again.

Note that you still need to use guestfs_set_network (g, 1)
to enable user networking.

9 years agoDon't include control characters in BufferIn trace output (RHBZ#646822).
Matthew Booth [Tue, 26 Oct 2010 12:54:17 +0000 (13:54 +0100)]
Don't include control characters in BufferIn trace output (RHBZ#646822).

The example below shows what the output looks like for a large
random buffer.

$ guestfish -N fs -m /dev/sda1 -x -- \
    touch /test : \
    pwrite /test "$(dd if=/dev/urandom bs=128k count=1)" 0
[...]
pwrite "/test" "\x7f\xa0/\xb3\x80\xd3\xbc\xc3\xc3.\xb1\xe0\x1b\xafC\x06\xd5;\x0ajJ[o\xc1\xdd\xae\x1f\xce\xb2\x8d\xb3\xd0\x11\xcc$%\xe6<\xc7\xc7\xe7BU*\xc4l%\xaa\xea\xe9\x1an\xda]\xc6I\x0eC\xf9;\xec\x12a\x1f\xeaRH\xb2P\xd6+\xc4\xe6\xa5bW\x99\\x9d\xc8\x9bJ\xef\x99-\x16:h5\xe2\x0f\xa2\xa08\x9bU\x0b$\x138\xcf\xd4j\x9b\x83{%\xac0\xdaa1Xx\xbd`\x8e\xdd\x82\x87\x07\x98\xd2\x9ed\x8bq\xd0\x1f5\x8f\xab\xad4z1\xda\xc4b\xc1\xbc\x0f\xaa\xea\xc1\x15(\xfd1\xc2\x0bF\xe6\x9e\xb0+/g\\xab\xb0b\xde_\xca\xf9\xad\xe1?%\x17\xad\x98\xa4e\xc1\xe0f'\x89\xe9>\xff\xadhYi\xe7\x8c]%\xef\xe0\xa1R\xe5\xd5\x03K\xefI\xdf\xad\xd3\x82\xdb\x0f\xdd\xc3\x8f"\xf1G\xea\xf9r\xdd\xff\x88\x81\xb7\xf2\x0e\x0f\x1d;:\xf2F1\xdb\xb5D\xa1^\x928\xf5\x8e)\xab\xc4\xc3H(\xd0ol\xc6\xe4\xd6\xa3L\x1c\x06\xf4"<truncated, original size 130567 bytes> 0
[...]

9 years agodaemon: Print failed path in stat command errors.
Richard W.M. Jones [Mon, 25 Oct 2010 11:54:59 +0000 (12:54 +0100)]
daemon: Print failed path in stat command errors.

9 years agofish: Fix too-short allocation in tilde expansion (RHBZ#636061).
Karel Klíč [Mon, 25 Oct 2010 11:48:36 +0000 (12:48 +0100)]
fish: Fix too-short allocation in tilde expansion (RHBZ#636061).

9 years agoUpdate Polish translations (RHBZ#502533).
Piotr Drąg [Sat, 23 Oct 2010 11:52:35 +0000 (12:52 +0100)]
Update Polish translations (RHBZ#502533).

9 years agofish: Quote optional argument name in error message.
Richard W.M. Jones [Sat, 23 Oct 2010 09:45:25 +0000 (10:45 +0100)]
fish: Quote optional argument name in error message.

9 years agofish: Reject unknown opt args (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Sat, 23 Oct 2010 09:45:06 +0000 (10:45 +0100)]
fish: Reject unknown opt args (RHBZ#642934,CVE-2010-3851).

This updates commit 0c1d3c02a8147617ee0646e37d011235abdd2c22.

9 years agofuse: Add --format option to docs (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Sat, 23 Oct 2010 09:23:45 +0000 (10:23 +0100)]
fuse: Add --format option to docs (RHBZ#642934,CVE-2010-3851).

This updates commit 44c5ee1163918bd5c9e6aa6c292f0c3bb15b7b25.

Document the --format option in the guestmount manual page.

9 years agoVersion 1.5.23. 1.5.23
Richard W.M. Jones [Fri, 22 Oct 2010 22:12:16 +0000 (23:12 +0100)]
Version 1.5.23.

9 years agoresize: Specify format of input, output disk (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Fri, 22 Oct 2010 11:48:25 +0000 (12:48 +0100)]
resize: Specify format of input, output disk (RHBZ#642934,CVE-2010-3851).

This adds two new options: --format specifies the format of the
input disk, and --output-format specified the format of the output
disk.

Requiring the format of the output disk seems a bit strange at first:
after all, this is the disk that the virt-resize user has to create.
However it is needed because we sometimes reopen this disk, after
copying data over the first sector, and in theory a raw-format guest
could write a qcow2 header here and have it copied to the output
disk, which we would subsequently reopen.

9 years agovirt-make-fs: Specify format of disk (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Thu, 21 Oct 2010 22:33:15 +0000 (23:33 +0100)]
virt-make-fs: Specify format of disk (RHBZ#642934,CVE-2010-3851).

9 years agodf: Specify format of disks (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Thu, 21 Oct 2010 22:06:24 +0000 (23:06 +0100)]
df: Specify format of disks (RHBZ#642934,CVE-2010-3851).

The format parameter is taken from libvirt if available, else
the user should supply the '--format' parameter (eg. for local
disk files).

9 years agotools: Specify format of disks (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Fri, 22 Oct 2010 09:59:53 +0000 (10:59 +0100)]
tools: Specify format of disks (RHBZ#642934,CVE-2010-3851).

Sys::Guestfs::Lib is changed in two ways: firstly we take the format
string from libvirt and pass it to add_drive_opts.  Secondly we allow
an extra format =>  parameter to open_guest which allows the
format to be specified for disk images.

All the tools are changed to add an extra --format parameter allowing
the format to be specified for direct disk images.

9 years agofuse: Specify format of disks (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Fri, 22 Oct 2010 14:01:55 +0000 (15:01 +0100)]
fuse: Specify format of disks (RHBZ#642934,CVE-2010-3851).

For command line disk images, specify the format using --format option
in the same way as for guestfish.

9 years agofish: Specify format of disks (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Thu, 21 Oct 2010 22:05:26 +0000 (23:05 +0100)]
fish: Specify format of disks (RHBZ#642934,CVE-2010-3851).

For libvirt guests, the disk format is copied from libvirt (if
libvirt knows it).

For command line disk images, you can use --format to override
format auto-detection.

9 years agogenerator: Optional arguments, add-drive-opts (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Wed, 20 Oct 2010 10:34:57 +0000 (11:34 +0100)]
generator: Optional arguments, add-drive-opts (RHBZ#642934,CVE-2010-3851).

This large commit changes the generator so that optional arguments
can be supported for functions.

The model for arguments (known as the "style") is changed from
(ret, args) to (ret, args, optargs) where optargs is a more limited
list of arguments.

One function has been added which takes optional arguments, it is
"add-drive-opts", modelled as:

  (RErr, [String "filename"], #required
         [Bool "readonly"; String "format"; String "iface"]) #optional

Note that this function is processed in the library (does not go over
the RPC protocol to the daemon).  This has allowed us to simplify
the current implementation by omitting changes related to RPC or the
daemon, although we plan to add these at some point in the future.

From C this function can be called in 3 different ways as in these
examples:

  guestfs_add_drive_opts (g, filename,
                          GUESTFS_ADD_DRIVE_OPTS_READONLY, 1,
  GUESTFS_ADD_DRIVE_OPTS_FORMAT, "raw",
                          -1);

(the argument(s) between 'filename' and '-1' are the optional ones).

  guestfs_add_drive_opts_va (g, filename, args);

where 'args' is a va_list.  This works like the first version.

  struct guestfs_add_drive_opts_argv optargs = {
    .bitmask = GUESTFS_ADD_DRIVE_OPTS_READONLY_BITMASK,
    .readonly = 1,
  }
  guestfs_add_drive_opts_argv (g, filename, &optargs);

This last form lets you construct lists of optional arguments, and
is used by guestfish and the language bindings.

In guestfish optional arguments are used like this:

  add-drive-opts filename readonly:true

In OCaml these are mapped naturally to OCaml optional arguments, eg:

  g#add_drive_opts ~readonly:true filename;

In Perl these are mapped to extra arguments, eg:

  $g->add_drive_opts ($filename, readonly => 1);

In Python these are mapped to optional arguments, eg:

  g.add_drive_opts ("file", readonly = 1, format = "qcow2")

In Ruby these are mapped to a final hash argument, eg:

  g.add_drive_opts("file", {})
  g.add_drive_opts("file", :readonly => 1)
  g.add_drive_opts("file", :readonly => 1, :iface => "virtio")

In PHP these are mapped to extra parameters.  This is not quite
accurate since you cannot omit arbitrary optional parameters, but
there's not much than can be done within the limitations of PHP
as a language.

Unimplemented in: Haskell, C#, Java.

9 years agogenerator: Rearrange argt logically (RHBZ#642934,CVE-2010-3851).
Richard W.M. Jones [Wed, 20 Oct 2010 09:49:59 +0000 (10:49 +0100)]
generator: Rearrange argt logically (RHBZ#642934,CVE-2010-3851).

This structure has accreted over time.  Rearrange the types
into a logical order.

9 years agodaemon: Use stdint UINT64_C instead of <const>ULL.
Richard W.M. Jones [Fri, 22 Oct 2010 16:10:49 +0000 (17:10 +0100)]
daemon: Use stdint UINT64_C instead of <const>ULL.

9 years agoinspector: Add comment about why --fish option implies write mode.
Richard W.M. Jones [Fri, 22 Oct 2010 11:13:07 +0000 (12:13 +0100)]
inspector: Add comment about why --fish option implies write mode.

9 years agophp: Create test file properly before running test.
Richard W.M. Jones [Thu, 21 Oct 2010 17:47:44 +0000 (18:47 +0100)]
php: Create test file properly before running test.

9 years agophp: Note that tests are testing the wrong thing.
Richard W.M. Jones [Thu, 21 Oct 2010 17:41:56 +0000 (18:41 +0100)]
php: Note that tests are testing the wrong thing.

9 years agoruby: Run tests one at a time, instead of in parallel.
Richard W.M. Jones [Thu, 21 Oct 2010 15:39:04 +0000 (16:39 +0100)]
ruby: Run tests one at a time, instead of in parallel.

9 years agogenerator: Refactor code for Perl bindings.
Richard W.M. Jones [Thu, 21 Oct 2010 12:59:36 +0000 (13:59 +0100)]
generator: Refactor code for Perl bindings.

This simplifies the code that generates the Perl bindings
by removing repeated sections.

9 years agogenerator: Missing newline character.
Richard W.M. Jones [Thu, 21 Oct 2010 10:59:49 +0000 (11:59 +0100)]
generator: Missing newline character.

9 years agofish: Change 'int argc' to 'size_t argc' throughout.
Richard W.M. Jones [Thu, 21 Oct 2010 09:50:25 +0000 (10:50 +0100)]
fish: Change 'int argc' to 'size_t argc' throughout.

9 years agogenerator: Remove unused parameter.
Richard W.M. Jones [Wed, 20 Oct 2010 12:35:43 +0000 (13:35 +0100)]
generator: Remove unused parameter.

generate_c_call_args optional decl parameter is never actually
used, so remove it.

9 years agoVersion 1.5.22. 1.5.22
Richard W.M. Jones [Tue, 19 Oct 2010 14:18:15 +0000 (15:18 +0100)]
Version 1.5.22.

9 years agovirt-resize: Document guest boot stops at "GRUB" (RHBZ#640961).
Richard W.M. Jones [Mon, 18 Oct 2010 13:34:28 +0000 (14:34 +0100)]
virt-resize: Document guest boot stops at "GRUB" (RHBZ#640961).

9 years agodf: Correctly quote libvirt domain and filesystem in --csv mode (RHBZ#639986).
Richard W.M. Jones [Mon, 18 Oct 2010 13:18:58 +0000 (14:18 +0100)]
df: Correctly quote libvirt domain and filesystem in --csv mode (RHBZ#639986).

This fixes virt-df --csv when used with libvirt domains that contain
quotes, spaces, commas and other lesser-used characters.

9 years agovirt-resize: Document qcow2 output format (RHBZ#642826).
Richard W.M. Jones [Mon, 18 Oct 2010 12:35:06 +0000 (13:35 +0100)]
virt-resize: Document qcow2 output format (RHBZ#642826).

9 years agovirt-resize: List truncate(1) in SEE ALSO section.
Richard W.M. Jones [Mon, 18 Oct 2010 12:33:02 +0000 (13:33 +0100)]
virt-resize: List truncate(1) in SEE ALSO section.

9 years agotools: Add section describing quoting libvirt domain names to docs (RHBZ#643624)
Richard W.M. Jones [Mon, 18 Oct 2010 12:18:20 +0000 (13:18 +0100)]
tools: Add section describing quoting libvirt domain names to docs (RHBZ#643624)

9 years agoparted: Don't return "loop" for non-partitioned devices (RHBZ#634246).
Richard W.M. Jones [Mon, 18 Oct 2010 11:56:54 +0000 (12:56 +0100)]
parted: Don't return "loop" for non-partitioned devices (RHBZ#634246).

If you ran part-get-parttype command on a device which didn't
contain a partition, it used to return the string "loop".  This
is an internal representation that parted uses.  We should instead
return an error because part-get-parttype makes no sense for
devices which are not partitioned.

9 years agocontrib: Note about what needs to be done for visualization.
Richard W.M. Jones [Mon, 18 Oct 2010 11:44:08 +0000 (12:44 +0100)]
contrib: Note about what needs to be done for visualization.

9 years agotodo: Add wishlist items to to-do list.
Richard W.M. Jones [Mon, 18 Oct 2010 11:41:41 +0000 (12:41 +0100)]
todo: Add wishlist items to to-do list.

9 years agotodo: Add note about using blktrace.
Richard W.M. Jones [Wed, 6 Oct 2010 15:38:12 +0000 (16:38 +0100)]
todo: Add note about using blktrace.

9 years agocontrib: More trace visualization.
Richard W.M. Jones [Wed, 6 Oct 2010 10:30:02 +0000 (11:30 +0100)]
contrib: More trace visualization.

9 years agodebug: Add qtrace <device> on|off to allow selective traces.
Richard W.M. Jones [Wed, 6 Oct 2010 09:19:20 +0000 (10:19 +0100)]
debug: Add qtrace <device> on|off to allow selective traces.

9 years agopart-disk: Align whole disk partition to 64 sectors.
Richard W.M. Jones [Wed, 6 Oct 2010 08:08:39 +0000 (09:08 +0100)]
part-disk: Align whole disk partition to 64 sectors.

Change the part-disk command so it aligns the partition to
64 sectors (instead of 1 or 34 sectors as now).  This should
ensure that the filesystem contained within is aligned.

9 years agocontrib: Fix small mistake in README file.
Richard W.M. Jones [Tue, 5 Oct 2010 21:48:37 +0000 (22:48 +0100)]
contrib: Fix small mistake in README file.

9 years agocontrib: Update README files.
Richard W.M. Jones [Tue, 5 Oct 2010 21:21:43 +0000 (22:21 +0100)]
contrib: Update README files.