12 years agovirt-df: Match output with native (coreutils) 'df' command (RHBZ#578123).
Richard Jones [Tue, 30 Mar 2010 15:14:09 +0000 (16:14 +0100)]
virt-df: Match output with native (coreutils) 'df' command (RHBZ#578123).

This commit fixes the 'Use%' field in the output so it matches what
coreutils' 'df' command would print.

Firstly we change the calculation to use the space available to root,
not the space available to non-root.  This means it matches what 'df'
when run as root in the guest would show.

Secondly we display this rounded up to the next whole percent (ie. using
ceil), which is also what 'df' does.

Thirdly we change the regression test so it tests this.

Note that even with these changes you are not guaranteed to get precisely
the same figures from inside and outside the guest, as it depends on
how quiescent the guest is and how recently the superblock was synced.

Thanks: Rita Wu

12 years agotools: Add basic tests for the virt-* tools.
Richard Jones [Tue, 30 Mar 2010 13:18:44 +0000 (14:18 +0100)]
tools: Add basic tests for the virt-* tools.

12 years agotools: Sectional header for manpages in
Richard Jones [Tue, 30 Mar 2010 12:45:16 +0000 (13:45 +0100)]
tools: Sectional header for manpages in

12 years agotools: Rearrange list of tools in
Richard Jones [Tue, 30 Mar 2010 12:44:29 +0000 (13:44 +0100)]
tools: Rearrange list of tools in

12 years agodaemon: Set TERM=dumb inside the daemon.
Richard Jones [Tue, 30 Mar 2010 12:34:16 +0000 (13:34 +0100)]
daemon: Set TERM=dumb inside the daemon.

Since commit 977edb3185fe8f we have been passing TERM from the
library into the appliance (for the benefit of virt-rescue).
However this changes the output of parted, which I would argue
is a bug in parted:

 TERM=xterm /sbin/parted -m -- /dev/sda unit b print 2>&1 | hexdump -C
 00000000  1b 5b 3f 31 30 33 34 68  42 59 54 3b 0a 2f 64 65  |.[?1034hBYT;./de|

Notice the escape-sequence junk before the official "BYT;"

By setting TERM=dumb we avoid this.

12 years agoFix the error message when reply body is too large (RHBZ#509597).
Richard Jones [Sat, 27 Mar 2010 11:02:03 +0000 (11:02 +0000)]
Fix the error message when reply body is too large (RHBZ#509597).

12 years agotests: Move alarm(2) calls to the correct place in the tests.
Richard Jones [Sat, 27 Mar 2010 10:49:24 +0000 (10:49 +0000)]
tests: Move alarm(2) calls to the correct place in the tests.

This is a re-fix for RHBZ#505329.

12 years agoPrepare for 1.0.88. 1.0.88
Richard Jones [Fri, 26 Mar 2010 21:08:43 +0000 (21:08 +0000)]
Prepare for 1.0.88.

12 years agorescue: Pass $TERM from library into the virt-rescue appliance.
Richard Jones [Fri, 26 Mar 2010 20:08:45 +0000 (20:08 +0000)]
rescue: Pass $TERM from library into the virt-rescue appliance.

We set it on the kernel command line, then get it out from
there when the rescue appliance boots.

12 years agorescue: Sync disk on exit, and improve messaging.
Richard Jones [Fri, 26 Mar 2010 20:02:10 +0000 (20:02 +0000)]
rescue: Sync disk on exit, and improve messaging.

12 years agoConst-correctness fix.
Jim Meyering [Fri, 26 Mar 2010 20:01:45 +0000 (20:01 +0000)]
Const-correctness fix.

12 years agoappliance: Set $PATH instead of hard-coding paths to binaries everywhere.
Richard Jones [Fri, 26 Mar 2010 10:10:16 +0000 (10:10 +0000)]
appliance: Set $PATH instead of hard-coding paths to binaries everywhere.

Change the appliance so PATH includes common directories.  Thus
we don't need to hard-code paths to binaries (eg. "/sbin/fdisk")

12 years agoperl: use newSVpvn for variable length strings.
Richard Jones [Thu, 25 Mar 2010 19:44:22 +0000 (19:44 +0000)]
perl: use newSVpvn for variable length strings.

Previously we used newSVpv (str, len), but if len == 0 then
this means Perl tries to calculate the string length using
strlen(3).  This is not desirable when we know the length, in
which case we should use newSVpvn instead.

12 years agoUpdate PO files.
Richard Jones [Thu, 25 Mar 2010 16:03:42 +0000 (16:03 +0000)]
Update PO files.

12 years agoUpdate Spanish translation of libguestfs (RHBZ#576876).
Daniel Cabrera [Thu, 25 Mar 2010 16:03:01 +0000 (16:03 +0000)]
Update Spanish translation of libguestfs (RHBZ#576876).

12 years agoFix lvresize test on RHEL 5, by fixing guestfs_e2fsck_l.
Richard Jones [Wed, 24 Mar 2010 23:28:14 +0000 (23:28 +0000)]
Fix lvresize test on RHEL 5, by fixing guestfs_e2fsck_l.

The problem is that mkfs was making an ext2 filesystem,
which later we were checking with e4fsck.  e4fsck corrects
an "error" on the filesystem:
  /dev/VG/LV: Adding dirhash hint to filesystem.
e4fsck returns 1 (errors corrected) which we were interpreting
as an error return.

12 years agoUse ext4 dev tools on RHEL 5 (RHBZ#576688).
Richard Jones [Wed, 24 Mar 2010 22:02:34 +0000 (22:02 +0000)]
Use ext4 dev tools on RHEL 5 (RHBZ#576688).

12 years agoAdd support for minix filesystem (RHBZ#576689).
Richard Jones [Wed, 24 Mar 2010 21:21:23 +0000 (21:21 +0000)]
Add support for minix filesystem (RHBZ#576689).

12 years agoVersion 1.0.87. 1.0.87
Richard Jones [Tue, 23 Mar 2010 22:10:45 +0000 (22:10 +0000)]
Version 1.0.87.

12 years agoNew tools: virt-resize and virt-list-partitions.
Richard Jones [Mon, 22 Mar 2010 18:38:31 +0000 (18:38 +0000)]
New tools: virt-resize and virt-list-partitions.

Virt-resize is the main contribution here, a program which can
be used to expand and shrink partitions in disk images.

Virt-list-partitions is used as an ancillary tool for planning
resize operations.

12 years agoNew API: guestfs_copy_size to copy a fixed number of bytes.
Richard Jones [Mon, 22 Mar 2010 18:36:16 +0000 (18:36 +0000)]
New API: guestfs_copy_size to copy a fixed number of bytes.

This is similar to 'guestfs_dd', but it copies just a fixed
number of bytes from the source to the destination.  It's an
error if the source is too short or if the destination is too

12 years agoChange some _exit(0|1) to _exit(EXIT_SUCCESS|EXIT_FAILURE).
Richard W.M. Jones [Fri, 19 Mar 2010 17:21:05 +0000 (17:21 +0000)]
Change some _exit(0|1) to _exit(EXIT_SUCCESS|EXIT_FAILURE).

12 years agoMac OS X: Fix configure-time tests for Ruby.
Richard Jones [Mon, 22 Mar 2010 10:30:25 +0000 (10:30 +0000)]
Mac OS X: Fix configure-time tests for Ruby.

For ARCHFLAGS change, see:

We also add a test for the <guestfs.h> header and include
that header when testing the library.

12 years agoguestfs.h: Include <stdint.h>.
Richard Jones [Mon, 22 Mar 2010 10:29:18 +0000 (10:29 +0000)]
guestfs.h: Include <stdint.h>.

This allows programs to work if they just
  #include <guestfs.h>
and no other headers.  It's not useful in the general
case, but fixes some configure-time tests, particularly
the one for Ruby on OS X.

12 years agoocaml examples: Fix linking line so it uses local library.
Richard Jones [Mon, 22 Mar 2010 10:05:49 +0000 (10:05 +0000)]
ocaml examples: Fix linking line so it uses local library.

12 years agoMac OS X: Disable null vmchannel implementation.
Richard Jones [Sun, 21 Mar 2010 21:47:39 +0000 (21:47 +0000)]
Mac OS X: Disable null vmchannel implementation.

As far as I can tell, Darwin has no way to check the peer euid
of a _loopback_ TCP socket.  This is required for the "null vmchannel"
implementation to work securely.

Therefore disable this - Darwin will use one of the other supported
vmchannel implementations instead.

12 years agoMac OS X: 'xdr_uint32_t' is 'xdr_u_int32_t'
Richard Jones [Sun, 21 Mar 2010 20:41:41 +0000 (20:41 +0000)]
Mac OS X: 'xdr_uint32_t' is 'xdr_u_int32_t'

12 years agoMac OS X: For PATH_MAX, include <limits.h>
Richard Jones [Sun, 21 Mar 2010 19:45:50 +0000 (19:45 +0000)]
Mac OS X: For PATH_MAX, include <limits.h>

12 years agoMac OS X: setlocale function requires <locale.h> header file.
Richard Jones [Sun, 21 Mar 2010 19:30:25 +0000 (19:30 +0000)]
Mac OS X: setlocale function requires <locale.h> header file.

12 years agoMac OS X: implement readline functions.
Richard Jones [Sun, 21 Mar 2010 19:15:40 +0000 (19:15 +0000)]
Mac OS X: implement readline functions.

OS X has an older version of readline with some differences
in the names of functions.

12 years agoMac OS X: provide alternate implementation of posix_fallocate.
Richard Jones [Sun, 21 Mar 2010 19:13:43 +0000 (19:13 +0000)]
Mac OS X: provide alternate implementation of posix_fallocate.

12 years agoMac OS X: include <rpc/types.h> before <rpc/xdr.h>
Richard Jones [Sun, 21 Mar 2010 17:49:49 +0000 (17:49 +0000)]
Mac OS X: include <rpc/types.h> before <rpc/xdr.h>

In PortableXDR this is not included automatically so we
have to include it explicitly to get definitions for the
XDR types.

12 years agoMac OS X: include <string.h> in guestfs-actions.c
Richard Jones [Sun, 21 Mar 2010 17:49:09 +0000 (17:49 +0000)]
Mac OS X: include <string.h> in guestfs-actions.c

This is required because guestfs-actions.c uses 'memset'.

12 years agoMac OS X: Fix HAVE_GNU_CALLOC so it works when __GLIBC__ is not defined.
Richard Jones [Sun, 21 Mar 2010 17:16:04 +0000 (17:16 +0000)]
Mac OS X: Fix HAVE_GNU_CALLOC so it works when __GLIBC__ is not defined.

12 years agoMac OS X: strerror_r on Macs is not like GNU strerror_r.
Richard Jones [Sun, 21 Mar 2010 17:15:26 +0000 (17:15 +0000)]
Mac OS X: strerror_r on Macs is not like GNU strerror_r.

Really this should be turned into a configure-time test.
Perhaps one exists already?

12 years agoMac OS X: define MAX macro if not already defined.
Richard Jones [Sun, 21 Mar 2010 17:14:37 +0000 (17:14 +0000)]
Mac OS X: define MAX macro if not already defined.

12 years agoMac OS X: kill(2) requires <signal.h>
Richard Jones [Sun, 21 Mar 2010 17:14:15 +0000 (17:14 +0000)]
Mac OS X: kill(2) requires <signal.h>

12 years agogenerator: Small fix for GODI users.
Richard Jones [Sun, 21 Mar 2010 17:13:07 +0000 (17:13 +0000)]
generator: Small fix for GODI users.

GODI has an odd package layout, so the generator was unable to
find xml-light.  Add the GODI directory to the search path.

12 years agoIgnore m4/intmax.m4
Richard Jones [Sun, 21 Mar 2010 16:06:30 +0000 (16:06 +0000)]
Ignore m4/intmax.m4

12 years agoRemove out-of-date comment.
Richard Jones [Sun, 21 Mar 2010 16:04:09 +0000 (16:04 +0000)]
Remove out-of-date comment.

12 years agoconfigure: Add --disable-daemon and --disable-appliance options.
Richard Jones [Sun, 21 Mar 2010 16:03:16 +0000 (16:03 +0000)]
configure: Add --disable-daemon and --disable-appliance options.

Use these on any platforms where you don't want or need to
build the daemon/appliance combination.

12 years agoRun qemu with -nographic option.
Richard Jones [Sun, 21 Mar 2010 16:33:37 +0000 (16:33 +0000)]
Run qemu with -nographic option.

On Mac OS X this prevents a short "flash" as qemu opens a
toplevel window.

12 years agoconfigure: Move host_cpu definition to earlier in the file.
Richard Jones [Sun, 21 Mar 2010 16:32:27 +0000 (16:32 +0000)]
configure: Move host_cpu definition to earlier in the file.

12 years agoappliance: Run depmod to create modules.dep for the kernel.
Richard Jones [Sun, 21 Mar 2010 21:23:47 +0000 (21:23 +0000)]
appliance: Run depmod to create modules.dep for the kernel.

Since we disabled running new-kernel-pkg in febootstrap, this
has meant that the normal appliance has not had a modules.dep
file.  (Supermin was unaffected by this).

12 years agoMac OS X: Detect bindtextdomain.
Richard Jones [Sun, 21 Mar 2010 19:30:52 +0000 (19:30 +0000)]
Mac OS X: Detect bindtextdomain.

These are missing on Mac OS X.  I think you would need to install
a gettext package to get these.

12 years agoMac OS X: Use gnulib setenv module explicitly.
Richard Jones [Mon, 22 Mar 2010 08:29:17 +0000 (08:29 +0000)]
Mac OS X: Use gnulib setenv module explicitly.


12 years agoNew APIs: Query the relationship between LVM objects.
Richard Jones [Thu, 18 Mar 2010 13:48:03 +0000 (13:48 +0000)]
New APIs: Query the relationship between LVM objects.

These calls allow you to query the relationship between
LVM objects, for example, which PVs contain a VG, or which
LVs are contained in a VG.

See the example / test program 'regressions/'
for an example of how to do this from Perl.

12 years agodaemon: Add a trim utility function.
Richard Jones [Thu, 18 Mar 2010 13:46:26 +0000 (13:46 +0000)]
daemon: Add a trim utility function.

This function trims the whitespace from around a string.  It
does this in-place, so it can be called for malloc'd strings.

12 years agoadd_drive_ro adds readonly=on option if available.
Richard Jones [Tue, 16 Mar 2010 21:50:13 +0000 (21:50 +0000)]
add_drive_ro adds readonly=on option if available.

Change the add_drive_ro call so it adds the readonly=on option
if qemu supports that.

This just means that qemu will not try to open the drive with
O_RDWR, and should not otherwise change the behaviour of qemu or
libguestfs.  (In particular, writes to the read-only drive are
still permitted, and are just discarded when the handle is closed).

However it should alleviate RHBZ#571714 where udev was deciding
to incorrectly relabel a device because we had opened the device
for writing (even though we didn't actually write to it).

12 years agoAllow qemu_supports to run earlier.
Richard Jones [Tue, 16 Mar 2010 21:44:26 +0000 (21:44 +0000)]
Allow qemu_supports to run earlier.

Reimplement qemu_supports() internal function.  Allow it to run
before launch so we can test qemu features.  Document that you
should run guestfs_set_qemu as early as possible to make sure
these tests are reliable.

12 years agoAdd minimal vim to the appliance for virt-rescue.
Richard Jones [Tue, 16 Mar 2010 20:06:12 +0000 (20:06 +0000)]
Add minimal vim to the appliance for virt-rescue.

virt-rescue lacks an editor.  Add vim-minimal (Fedora)
or vim-tiny (Debian) to make up for this omission.

12 years agotests: Don't use <guestfs-internal.h> in tests.
Richard Jones [Tue, 16 Mar 2010 21:11:23 +0000 (21:11 +0000)]
tests: Don't use <guestfs-internal.h> in tests.

It was failing when including this header, as a consequence
of earlier commit 1f56debfcfdc35d6b0.

12 years agoguestfs.h: More adjustment to comments in the header file.
Richard Jones [Tue, 16 Mar 2010 11:50:39 +0000 (11:50 +0000)]
guestfs.h: More adjustment to comments in the header file.

12 years agoguestfs.h: Move some internal functions to the internal header.
Richard Jones [Tue, 16 Mar 2010 11:18:51 +0000 (11:18 +0000)]
guestfs.h: Move some internal functions to the internal header.

Functions like guestfs__send were never exported through the public
API (libguestfs.syms prevented that).  However they appeared in the
public header.  Move them to the internal header.

12 years agoRearrangement and comment changes in <guestfs.h> header file.
Richard Jones [Tue, 16 Mar 2010 11:15:28 +0000 (11:15 +0000)]
Rearrangement and comment changes in <guestfs.h> header file.

There should be no substantive change.

12 years agoPrepare for version 1.0.86. 1.0.86
Richard Jones [Fri, 12 Mar 2010 18:28:21 +0000 (18:28 +0000)]
Prepare for version 1.0.86.

12 years agoTab to space (whitespace fixes only).
Richard Jones [Fri, 12 Mar 2010 16:23:46 +0000 (16:23 +0000)]
Tab to space (whitespace fixes only).

12 years agoDocs: Change exit(1) -> exit(EXIT_FAILURE)
Richard Jones [Fri, 12 Mar 2010 16:23:14 +0000 (16:23 +0000)]
Docs: Change exit(1) -> exit(EXIT_FAILURE)

12 years agoRewrite libguestfs-supermin-helper in C.
Richard Jones [Fri, 12 Mar 2010 16:20:31 +0000 (16:20 +0000)]
Rewrite libguestfs-supermin-helper in C.

libguestfs-supermin-helper was previously a shell script.  Although
we had steadily optimized it, there were a number of intractable
hot spots:

  (1) cpio still reads input files in 512 byte chunks; this is *very*
    pessimal behaviour, particularly when SELinux is enabled.
  (2) the hostfiles globbing was done very inefficiently by the shell,
    with the shell rereading the same directory over and over again.

This is a rewrite of this shell script in C.  It is approximately
3 times faster without SELinux, and has an even greater speed difference
with SELinux.

The main features are:

  (a) It never frees memory, making it simpler.  The program is designed
    to run and exit in sub-second times, so this is acceptable.
  (b) It caches directory reads, making the globbing of host files much
    faster (measured this as ~ 4 x speed up).
  (c) It doesn't use external cpio, but instead contains code to write
    newc format cpio files, which is all that the kernel can read.  Unlike
    cpio, this code uses large buffers for reads and writes.
  (d) Ignores missing or unreadable hostfiles, whereas cpio gave a
  (e) Checks all return values from system calls.
  (f) With --verbose flag, it will print messages timing itself.

This passes all tests.

Updated with feedback from Jim Meyering.

12 years agoguestfish: Use xstrtoll to parse Int params (RHBZ#569757 RHBZ#567567).
Richard Jones [Fri, 12 Mar 2010 09:47:38 +0000 (09:47 +0000)]
guestfish: Use xstrtoll to parse Int params (RHBZ#569757 RHBZ#567567).

Change guestfish so it uses xstrtoll to parse Int (31 bit)
parameters.  This fixes two bugs on 32 bit platforms which
failed when long = 32 bits.  long long = 64 bits on both.

12 years agoSpecial case hostfiles handling for
Richard Jones [Fri, 12 Mar 2010 15:10:28 +0000 (15:10 +0000)]
Special case hostfiles handling for

The ntfs-3g project keeps bumping their soname, and this causes
dependency problems for the Fedora package.  The root of the problem
is we depend on /lib/<N>, but if <N> keeps bumping,
the dependency keeps breaking.

This commit changes the hostfiles (and hence dependency) to be on
/lib/* instead.  The downside to this is we could end
up pulling more files into the appliance than are strictly required,
but it will fix the Fedora packaging problems being felt by the
Fedora maintainer of ntfs-3g.

After applying this commit, the change to hostfiles looks like this:

@@ -1489,7 +1489,7 @@
@@ -1520,7 +1520,6 @@

12 years agoinspector: Read information about Windows guests from the Registry.
Richard Jones [Mon, 8 Mar 2010 19:31:12 +0000 (19:31 +0000)]
inspector: Read information about Windows guests from the Registry.

This commit changes substantially the way that we get information
about Windows guests.  We now use the Windows Registry to get
information such as the version, product name and much else.

This uses Win::Hivex (ie. the hivex library).  'reged' is no longer
needed or used.

As an incidental change, this also tries harder to search for
%systemroot%, in the case when we cannot find boot.ini (ie.
Windows Vista and more recent).  This ensures we can get more
detail from those versions of Windows.

12 years agoinspector: Add product_name field to output.
Richard Jones [Mon, 8 Mar 2010 19:27:02 +0000 (19:27 +0000)]
inspector: Add product_name field to output.

This is a free text string containing the "product name" of
the OS.  It's mainly useful for Windows guests, and a forthcoming
patch will get this field from the Windows Registry.

12 years agoinspector: Don't crash if $os->{kernels} does not exist.
Richard Jones [Mon, 8 Mar 2010 19:28:48 +0000 (19:28 +0000)]
inspector: Don't crash if $os->{kernels} does not exist.

ie. on Windows.

12 years agoinspector: Sort application names.
Richard Jones [Mon, 8 Mar 2010 19:24:48 +0000 (19:24 +0000)]
inspector: Sort application names.

This ensures the list of applications is stable.

12 years agoRemove plymouth libraries from the appliance.
Richard Jones [Mon, 8 Mar 2010 16:04:09 +0000 (16:04 +0000)]
Remove plymouth libraries from the appliance.

12 years agoSpanish translation of libguestfs (RHBZ#570181).
Daniel Cabrera [Wed, 3 Mar 2010 15:49:39 +0000 (15:49 +0000)]
Spanish translation of libguestfs (RHBZ#570181).

12 years agoMore complete fix for bash regexp quoting bug.
Richard Jones [Tue, 2 Mar 2010 10:34:20 +0000 (10:34 +0000)]
More complete fix for bash regexp quoting bug.

Commit 457fccae1b665347 was not a complete fix, in that it
didn't work properly on RHEL 5 era bash (3.2.x).  For example:
  [[ "$file" =~ ^lib(.*)\.so\.([0-9]+)\. ]] && \
    echo "lib${BASH_REMATCH[1]}.so.${BASH_REMATCH[2]}.*"

would on those old shells print:*

It seems the final \. was being treated as a plain period (ie.
match anything).

The only way to work around this incompatibility is to assign the
patterns to variables and match on those, ie:

  [[ "$file" =~ $p ]] && ...

This works in both old and new shells.

12 years agoPrepare for version 1.0.85. 1.0.85
Richard Jones [Mon, 1 Mar 2010 13:49:25 +0000 (13:49 +0000)]
Prepare for version 1.0.85.

Update PO files.

12 years agofuse: Fix typo in test.
Richard Jones [Mon, 1 Mar 2010 14:17:12 +0000 (14:17 +0000)]
fuse: Fix typo in test.

12 years agobuild: Fix for bash quoting in (RHBZ#566511 RHBZ#566512)
Richard Jones [Mon, 1 Mar 2010 13:32:34 +0000 (13:32 +0000)]
build: Fix for bash quoting in (RHBZ#566511 RHBZ#566512)

Bash changed how the =~ operator worked, see bash FAQ question
E14 and

This also stops stray "builddir" (yum database) files being
incorporated into supermin hostfiles in Koji (RHBZ#566512).

12 years agoUpdated Polish translations (RHBZ#502533).
Piotr Drąg [Mon, 1 Mar 2010 09:38:07 +0000 (09:38 +0000)]
Updated Polish translations (RHBZ#502533).

12 years agoRemove bogus msgstr from kn.po.
Richard Jones [Thu, 25 Feb 2010 20:02:38 +0000 (20:02 +0000)]
Remove bogus msgstr from kn.po.

12 years agoList application in Debian based vm images
Guido Günther [Wed, 24 Feb 2010 08:07:56 +0000 (09:07 +0100)]
List application in Debian based vm images

attached patch adds the code to list applications installed in Debian
based vm images.
 -- Guido

>From 9427a14725b33415058a0713923c62bd231504ec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= <>
Date: Tue, 23 Feb 2010 21:05:02 +0100
Subject: [PATCH 2/2] Add application listing for Debian

12 years agoDebian package format
Guido Günther [Wed, 24 Feb 2010 08:06:23 +0000 (09:06 +0100)]
Debian package format

Minor nitpick: the Debian folks usually refer to deb as the package format not dpkg.
 -- Guido

>From 7a9665d40e0a3109833de10f17831ae06fc8885a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= <>
Date: Tue, 23 Feb 2010 21:04:37 +0100
Subject: [PATCH 1/2] Debina package format is called 'deb' not 'dpkg'

12 years agocheck for grub/menu.lst too
Guido Günther [Tue, 23 Feb 2010 19:42:48 +0000 (20:42 +0100)]
check for grub/menu.lst too

On Tue, Feb 23, 2010 at 08:07:14PM +0100, Guido Günther wrote:
> On Tue, Feb 23, 2010 at 07:52:43PM +0100, Guido Günther wrote:
> > Hi,
> > attached patch makes virt-inspector find the kernels on Debian systems.
> > Since there is no /etc/grub.conf it falls back to
> > $grubpartition/grub/menu.lst.
> Patch got somehow broken. New version fortchcoming. Sorry for the noise.
Attached now. No idea where the 'if' went in the first version ;)
 -- Guido

>From d30b4946f017ff8bde9d4ff62f93c418a707d9e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= <>
Date: Tue, 23 Feb 2010 19:50:40 +0100
Subject: [PATCH] Check for grub/menu.lst if /etc/grub.conf can't be found

12 years agoUse 'service' if installed
Guido Günther [Tue, 23 Feb 2010 17:55:56 +0000 (18:55 +0100)]
Use 'service' if installed

attached patch should make:;a=blob;f=debian/patches/0003-appliance-Use-service-udev-start-instead-of-running-.patch;h=c9e6b8489807d4fb1247cb6a8b6f9799bad2a09e;hb=d3a21b5b6850fc3c6e7903d0f5cafa3eb4197d49;a=blob;f=debian/patches/0004-Ubuntu-Prefer-starting-udev-by-hand-instead-of-using.patch;h=64b65a971b186e6ab1c9351e94b46d6f5aa242e0;hb=d3a21b5b6850fc3c6e7903d0f5cafa3eb4197d49

superflous. If there's an init script it uses 'service' or falls back to
calling the init script directly if it isn't there, otherwise it starts
udev directly. Tested on Debian only so far. The patch is based on
Rich's above two patches.
 -- Guido

From: =?UTF-8?q?Guido=20G=C3=BCnther?= <>
Date: Tue, 23 Feb 2010 18:49:34 +0100
Subject: [PATCH] Check for service and use it if it's there

Based on Richard's two patches for the Ubuntu build.

12 years agoUpdate PO files.
Richard Jones [Wed, 24 Feb 2010 10:33:27 +0000 (10:33 +0000)]
Update PO files.

12 years agoAdded Kannada translations (RHBZ#567860).
Shankar Prasad [Wed, 24 Feb 2010 10:32:03 +0000 (10:32 +0000)]
Added Kannada translations (RHBZ#567860).

12 years agoSpin off hivex as a separate upstream project.
Richard Jones [Mon, 22 Feb 2010 12:53:16 +0000 (12:53 +0000)]
Spin off hivex as a separate upstream project.

This commit makes the semi-independent hivex library into a
separate upstream project.  The git repo for hivex is now:;a=summary

Downloads of hivex are available here:

All questions, patches, bugs etc should be sent to the libguestfs
mailing list and bug tracker.

12 years agoenable scrub on Debian
Guido Günther [Sun, 21 Feb 2010 15:07:20 +0000 (16:07 +0100)]
enable scrub on Debian

12 years agohivexsh: Print hex bytes >= 0x80 correctly.
Richard Jones [Fri, 19 Feb 2010 13:51:07 +0000 (13:51 +0000)]
hivexsh: Print hex bytes >= 0x80 correctly.

These were being interpreted as signed chars, and thus printed
as "ffffff80" etc.

12 years agoRemove unused Perl modules.
Richard Jones [Fri, 19 Feb 2010 13:50:31 +0000 (13:50 +0000)]
Remove unused Perl modules.

These were 'use'd but not actually used.

12 years agoUpdate PO files.
Richard Jones [Tue, 16 Feb 2010 08:06:04 +0000 (08:06 +0000)]
Update PO files.

12 years agoAdd Hindi translations (RHBZ#565759).
Rajesh Ranjan [Tue, 16 Feb 2010 08:04:59 +0000 (08:04 +0000)]
Add Hindi translations (RHBZ#565759).

12 years agoTurn ProtocolLimitWarning into link to documentation section.
Richard Jones [Mon, 15 Feb 2010 23:15:17 +0000 (23:15 +0000)]
Turn ProtocolLimitWarning into link to documentation section.

12 years agoinitrd-cat: Needs ProtocolLimitWarning.
Richard Jones [Mon, 15 Feb 2010 22:58:22 +0000 (22:58 +0000)]
initrd-cat: Needs ProtocolLimitWarning.

12 years agoRemove references to FTP, replace with FUSE.
Richard Jones [Mon, 15 Feb 2010 22:53:40 +0000 (22:53 +0000)]
Remove references to FTP, replace with FUSE.

We originally intended to implement an FTP server (and before
than, an NFS server).  But we didn't implement either.  We
did however implement a FUSE service (guestmount) which takes
the place of both.

12 years agoRemove some unused variables.
Richard Jones [Mon, 15 Feb 2010 15:55:38 +0000 (15:55 +0000)]
Remove some unused variables.

Since we have to compile with -Wno-unused-variables, we don't
spot unused variables in code.  I found these by compiling the
code in Ubuntu.

12 years agoDistribute .gitignore files.
Richard Jones [Mon, 15 Feb 2010 15:34:34 +0000 (15:34 +0000)]
Distribute .gitignore files.

These are useful for Debian since they keep the tarball unpacked
in git.

12 years agoAdd 'make quickcheck' rule to run a quick check.
Richard Jones [Mon, 15 Feb 2010 15:33:13 +0000 (15:33 +0000)]
Add 'make quickcheck' rule to run a quick check.

12 years agoVersion 1.0.84. 1.0.84
Richard Jones [Fri, 12 Feb 2010 19:43:17 +0000 (19:43 +0000)]
Version 1.0.84.

12 years agodaemon: Don't need to prefix error messages with the command name.
Richard Jones [Fri, 12 Feb 2010 14:06:25 +0000 (14:06 +0000)]
daemon: Don't need to prefix error messages with the command name.

The RPC stubs already prefix the command name to error messages.
The daemon doesn't have to do this.  As a (small) benefit this also
makes the daemon slightly smaller.

Code in the daemon such as:

  if (argv[0] == NULL) {
    reply_with_error ("passed an empty list");
    return NULL;

now results in error messages like this:

  ><fs> command ""
  libguestfs: error: command: passed an empty list

(whereas previously you would have seen ..command: command:..)

12 years agogenerator: Don't prefix error messages with command name.
Richard Jones [Fri, 12 Feb 2010 13:42:57 +0000 (13:42 +0000)]
generator: Don't prefix error messages with command name.

The command name is already being added by the RPC stubs, so
adding it again in Perl and C# just results in doubled error messages
  foo: foo: the error

12 years agoSys::Guestfs::Lib::open_guest: Add interface parameter.
Richard Jones [Fri, 12 Feb 2010 12:13:40 +0000 (12:13 +0000)]
Sys::Guestfs::Lib::open_guest: Add interface parameter.

This allows you to override the default QEMU block device emulation.

12 years agoSys::Guestfs::Lib::open_guest: Remove freeform parameters.
Richard Jones [Fri, 12 Feb 2010 12:08:58 +0000 (12:08 +0000)]
Sys::Guestfs::Lib::open_guest: Remove freeform parameters.

Remove the ability to pass freeform parameters to Sys::Virt->new.
We don't use it, it makes the code more complex to modify, and
indeed there are no other args that Sys::Virt->new supports so
this would never be used.

Also change $readwrite to $rw to match parameter name.

12 years agoNew APIs: add-drive{,-ro}-with-if allows you to set QEMU block emulation.
Richard Jones [Fri, 12 Feb 2010 11:47:18 +0000 (11:47 +0000)]
New APIs: add-drive{,-ro}-with-if allows you to set QEMU block emulation.

The default if=... comes from configure time (currently it
defaults to if=virtio).

This change allows you to set the QEMU block emulation.

We don't think this will be used very often, but virt-v2v
requires it in order to work around a subtle problem with
running 'mkinitrd' in an appliance attached to a guest.

12 years agogenerator: 'interface' is a reserved word in Java.
Richard Jones [Fri, 12 Feb 2010 11:46:40 +0000 (11:46 +0000)]
generator: 'interface' is a reserved word in Java.

12 years agoadd_cdrom: Update docs for adding ISO images.
Richard Jones [Fri, 12 Feb 2010 11:27:44 +0000 (11:27 +0000)]
add_cdrom: Update docs for adding ISO images.

See also RHBZ#563450 (NB: This commit does not fix the bug).

12 years agoUse mount-options instead of mount to avoid implicit -o sync.
Richard Jones [Tue, 9 Feb 2010 18:00:24 +0000 (18:00 +0000)]
Use mount-options instead of mount to avoid implicit -o sync.

guestfs_mount adds -o sync implicitly.  This causes a very large
performance problem for write-intensive programs (eg. virt-v2v).

Document this as a "gotcha".

Change the tests, guestfish, Sys::Guestfs::Lib, guestmount to use
mount-options instead.

(Note that this gotcha does not affect mount-ro).

The source of the performance problem was first identified by
Matthew Booth.