Fix guestfs___rollback_cmdline when pos == 0.
authorRichard W.M. Jones <rjones@redhat.com>
Sun, 8 May 2011 14:13:23 +0000 (15:13 +0100)
committerRichard W.M. Jones <rjones@redhat.com>
Sun, 8 May 2011 14:13:23 +0000 (15:13 +0100)
Because of the previous change to size_t, when pos == 0 the loop would
wrap around and cause a segmentation fault.

This fixes a regression introduced by
commit 10167cea98f93a74abe63f0a54d3a662997e7489.

src/launch.c

index 8dfeb31..ecc0464 100644 (file)
@@ -117,7 +117,7 @@ guestfs___rollback_cmdline (guestfs_h *g, size_t pos)
 
   assert (g->cmdline_size >= pos);
 
-  for (i = g->cmdline_size - 1; i >= pos; --i)
+  for (i = pos; i < g->cmdline_size; ++i)
     free (g->cmdline[i]);
 
   g->cmdline_size = pos;