Richard W.M. Jones [Thu, 21 Oct 2010 10:59:49 +0000 (11:59 +0100)]
generator: Missing newline character.
Richard W.M. Jones [Thu, 21 Oct 2010 09:50:25 +0000 (10:50 +0100)]
fish: Change 'int argc' to 'size_t argc' throughout.
Richard W.M. Jones [Wed, 20 Oct 2010 12:35:43 +0000 (13:35 +0100)]
generator: Remove unused parameter.
generate_c_call_args optional decl parameter is never actually
used, so remove it.
Richard W.M. Jones [Tue, 19 Oct 2010 14:18:15 +0000 (15:18 +0100)]
Version 1.5.22.
Richard W.M. Jones [Mon, 18 Oct 2010 13:34:28 +0000 (14:34 +0100)]
virt-resize: Document guest boot stops at "GRUB" (RHBZ#640961).
Richard W.M. Jones [Mon, 18 Oct 2010 13:18:58 +0000 (14:18 +0100)]
df: Correctly quote libvirt domain and filesystem in --csv mode (RHBZ#639986).
This fixes virt-df --csv when used with libvirt domains that contain
quotes, spaces, commas and other lesser-used characters.
Richard W.M. Jones [Mon, 18 Oct 2010 12:35:06 +0000 (13:35 +0100)]
virt-resize: Document qcow2 output format (RHBZ#642826).
Richard W.M. Jones [Mon, 18 Oct 2010 12:33:02 +0000 (13:33 +0100)]
virt-resize: List truncate(1) in SEE ALSO section.
Richard W.M. Jones [Mon, 18 Oct 2010 12:18:20 +0000 (13:18 +0100)]
tools: Add section describing quoting libvirt domain names to docs (RHBZ#643624)
Richard W.M. Jones [Mon, 18 Oct 2010 11:56:54 +0000 (12:56 +0100)]
parted: Don't return "loop" for non-partitioned devices (RHBZ#634246).
If you ran part-get-parttype command on a device which didn't
contain a partition, it used to return the string "loop". This
is an internal representation that parted uses. We should instead
return an error because part-get-parttype makes no sense for
devices which are not partitioned.
Richard W.M. Jones [Mon, 18 Oct 2010 11:44:08 +0000 (12:44 +0100)]
contrib: Note about what needs to be done for visualization.
Richard W.M. Jones [Mon, 18 Oct 2010 11:41:41 +0000 (12:41 +0100)]
todo: Add wishlist items to to-do list.
Richard W.M. Jones [Wed, 6 Oct 2010 15:38:12 +0000 (16:38 +0100)]
todo: Add note about using blktrace.
Richard W.M. Jones [Wed, 6 Oct 2010 10:30:02 +0000 (11:30 +0100)]
contrib: More trace visualization.
Richard W.M. Jones [Wed, 6 Oct 2010 09:19:20 +0000 (10:19 +0100)]
debug: Add qtrace <device> on|off to allow selective traces.
Richard W.M. Jones [Wed, 6 Oct 2010 08:08:39 +0000 (09:08 +0100)]
part-disk: Align whole disk partition to 64 sectors.
Change the part-disk command so it aligns the partition to
64 sectors (instead of 1 or 34 sectors as now). This should
ensure that the filesystem contained within is aligned.
Richard W.M. Jones [Tue, 5 Oct 2010 21:48:37 +0000 (22:48 +0100)]
contrib: Fix small mistake in README file.
Richard W.M. Jones [Tue, 5 Oct 2010 21:21:43 +0000 (22:21 +0100)]
contrib: Update README files.
Richard W.M. Jones [Tue, 5 Oct 2010 21:19:15 +0000 (22:19 +0100)]
contrib: Visualizing block device access and alignment.
Richard W.M. Jones [Mon, 4 Oct 2010 19:34:36 +0000 (20:34 +0100)]
ocaml: Add g#ocaml_handle method.
Richard W.M. Jones [Mon, 4 Oct 2010 19:33:14 +0000 (20:33 +0100)]
ocaml: Document g#close () method for objects.
Richard W.M. Jones [Mon, 4 Oct 2010 19:29:05 +0000 (20:29 +0100)]
ocaml: Create the handle when the object is instantiated.
Previously we had only one handle shared between all objects .. oops.
This fixes commit
67636f721056d2f2250b0ff8acd981a0294536a9.
Richard W.M. Jones [Sun, 3 Oct 2010 20:18:25 +0000 (21:18 +0100)]
ocaml: Add alternate object-oriented programming style.
In original style:
let () =
let filename = Sys.argv.(1) in
let g = Guestfs.create () in
Guestfs.add_drive_ro g filename;
Guestfs.launch g;
let roots = Guestfs.inspect_os g in
print_endline (Guestfs.inspect_get_product_name g roots.(0))
The same code in the new OO style:
let () =
let filename = Sys.argv.(1) in
let g = new Guestfs.guestfs in
g#add_drive_ro filename;
g#launch ();
let roots = g#inspect_os () in
print_endline (g#inspect_get_product_name roots.(0))
Richard W.M. Jones [Sat, 2 Oct 2010 08:10:22 +0000 (09:10 +0100)]
test-copy: Skip this test if /dev/fd is missing, because of broken mock 1.1.4.
Richard W.M. Jones [Sat, 2 Oct 2010 08:07:42 +0000 (09:07 +0100)]
test-virt-resize: Skip this test on 32 bit hosts.
Richard W.M. Jones [Fri, 1 Oct 2010 20:04:07 +0000 (21:04 +0100)]
Version 1.5.21.
Richard W.M. Jones [Fri, 1 Oct 2010 09:46:38 +0000 (10:46 +0100)]
fish: Fix glob command (RHBZ#635969).
This is a fix for the glob command in guestfish which was inadvertently
broken in commit
c359347dd42c9f5b875630537ee3641264826b89.
This also appears to fix:
https://bugzilla.redhat.com/show_bug.cgi?id=635969
glob echo mkfs ext2 /dev/vd[b-t]1 prints garbage
Richard W.M. Jones [Mon, 27 Sep 2010 16:06:14 +0000 (17:06 +0100)]
Add test for virt-resize.
This tests a number of things which have caused problems for us:
- resizing PVs and LV content
- handling GPT format disks
- using qcow2 as a target disk format
- shrinking disk images
Note that the disk content is empty (not a real VM), but this is
adequate since all we want to test are the operations and calculations
done by virt-resize. We are not interested here in whether e2fsprogs
and LVM actually works.
Richard W.M. Jones [Mon, 27 Sep 2010 16:00:45 +0000 (17:00 +0100)]
resize: Fix handling of GPT and qcow2 (RHBZ#633766, RHBZ#633096).
Previously we copied the bootloader data directly from the
source disk image to the target disk image using host file
operations (before launching libguestfs). This has two problems:
firstly it has no chance of working with qcow2, and secondly
it didn't behave properly with GPT.
This changes the code so that everything is done through
libguestfs. Block device sizes are now calculated properly
for qcow2 (RHBZ#633096) because this is done using the libguestfs
blockdev_getsize64 call. The partition table is still created
by parted, but to workaround a bug in parted this is done before
copying the bootloader. Finally the bootloader copy is done
using the new APIs pread-device and pwrite-device.
Shrinking now works, at least for simple cases (RHBZ#633766).
Richard W.M. Jones [Mon, 27 Sep 2010 11:00:10 +0000 (12:00 +0100)]
New API: pread-device, partial read for devices.
Richard W.M. Jones [Mon, 27 Sep 2010 09:51:38 +0000 (10:51 +0100)]
pread: Check count and offset parameters are not negative.
Richard W.M. Jones [Mon, 27 Sep 2010 09:12:22 +0000 (10:12 +0100)]
Freshen POD (manual pages) stylesheet.
Richard W.M. Jones [Sun, 26 Sep 2010 21:41:24 +0000 (22:41 +0100)]
Version 1.5.20.
Richard W.M. Jones [Sun, 26 Sep 2010 17:00:11 +0000 (18:00 +0100)]
New API: pwrite-device
This is the same as the existing 'pwrite' API call, but allows you
to write to a device.
Richard W.M. Jones [Sun, 26 Sep 2010 16:59:50 +0000 (17:59 +0100)]
pwrite: Check offset is not negative.
Richard W.M. Jones [Sun, 26 Sep 2010 21:21:10 +0000 (22:21 +0100)]
fish: Refresh guestfish documentation.
Richard W.M. Jones [Sun, 26 Sep 2010 18:34:46 +0000 (19:34 +0100)]
Document ambiguity between devices and paths in API.
Richard W.M. Jones [Fri, 24 Sep 2010 18:28:01 +0000 (19:28 +0100)]
Document accurately how supermin appliance uses /tmp as a cache.
Richard W.M. Jones [Fri, 24 Sep 2010 17:54:37 +0000 (18:54 +0100)]
Allow $TMPDIR to override most temporary directory uses.
Be more consistent in allowing the user to override use of the
temporary directory by specifying $TMPDIR. Also prefer P_tmpdir
macro (defined in <stdio.h>) if that is defined, rather than
hard-coding "/tmp" for the fallback location.
Richard W.M. Jones [Fri, 24 Sep 2010 17:53:21 +0000 (18:53 +0100)]
Call blockdev --rereadpt then udev_settle after sfdisk commands.
This updates commit
956fc5a3feacc970ea763697bf28fb686c875408 so
that we call udev_settle after rereading the partition table. This
ensures that the devices nodes for the new partitions have been
created.
Daniel Cabrera [Thu, 23 Sep 2010 17:11:35 +0000 (18:11 +0100)]
Update Spanish translations (RHBZ#636918).
Piotr Drąg [Thu, 23 Sep 2010 13:45:50 +0000 (14:45 +0100)]
Update Polish translations (RHBZ#502533).
Richard W.M. Jones [Wed, 22 Sep 2010 20:50:46 +0000 (21:50 +0100)]
Version 1.5.19.
Richard W.M. Jones [Wed, 22 Sep 2010 16:43:34 +0000 (17:43 +0100)]
regressions: Test just-built guestfish.
Instead of testing the installed /usr/bin/guestfish.
This fixes commit
ddda0f7bd00a37274dae38f4ce93955b8cfdf7d7.
Richard W.M. Jones [Wed, 22 Sep 2010 15:35:52 +0000 (16:35 +0100)]
Call blockdev --rereadpt after sfdisk commands.
On fast machines sfdisk has some sort of race where it
fails to re-read the partition table it has just created
(it's not clear if this is a race in sfdisk, the kernel or
some other component).
This commit works around the problem by calling
blockdev --rereadpt after sfdisk operations, which
experience shows is enough to stop the problem from
happening.
Richard W.M. Jones [Wed, 22 Sep 2010 14:37:34 +0000 (15:37 +0100)]
Version 1.5.18.
Richard W.M. Jones [Wed, 22 Sep 2010 13:10:58 +0000 (14:10 +0100)]
Test guestfish -a and guestfish -d options.
Since these options were both broken in released version 1.5.17,
best to have a regression test to catch this in future.
Richard Jones [Wed, 22 Sep 2010 13:10:13 +0000 (14:10 +0100)]
appliance: Ignore unreadable dbus service file (Fedora 15).
Richard W.M. Jones [Wed, 22 Sep 2010 10:59:58 +0000 (11:59 +0100)]
fish: Fix segfault in free_drives() function.
This updates commit
8ea62c8d7f3f7f7e4057b93105cf979271aa13f4
so it doesn't try to free the optarg (stack-allocated) strings.
Richard W.M. Jones [Tue, 21 Sep 2010 20:57:50 +0000 (21:57 +0100)]
Version 1.5.17.
Richard W.M. Jones [Tue, 21 Sep 2010 21:49:18 +0000 (22:49 +0100)]
Update release notes for new features in 1.5 branch.
Richard W.M. Jones [Sat, 18 Sep 2010 09:09:04 +0000 (10:09 +0100)]
fish: Implement 'hexedit' command.
Richard W.M. Jones [Mon, 20 Sep 2010 17:23:58 +0000 (18:23 +0100)]
New APIs: upload-offset and download-offset
These APIs allow you to efficiently write and read parts of
files or devices.
Richard W.M. Jones [Tue, 21 Sep 2010 18:49:08 +0000 (19:49 +0100)]
leak: Clear history before exiting guestfish.
Clear the in-memory history before exiting. This removes
some but not all memory leaks associated with using the GNU
History library. As far as I can tell it is not possible to
free up everything used by GNU History.
(Found by valgrind).
Richard W.M. Jones [Tue, 21 Sep 2010 18:40:23 +0000 (19:40 +0100)]
leak: Free list of drives and mountpoints in guestfish.
Previously the list of -a, -d, -m, -N parameters were leaked. This
change frees them explicitly.
This is not such an important fix since guestfish is a one-shot
program, but it aids in finding other leaks in future.
(Found by valgrind).
Richard W.M. Jones [Tue, 21 Sep 2010 18:38:50 +0000 (19:38 +0100)]
leak: Free PCRE regexps when library is unloaded.
The compiled PCRE regexps used for inspection were being leaked when
the library was unloaded.
(Found by valgrind).
Richard W.M. Jones [Tue, 21 Sep 2010 18:37:24 +0000 (19:37 +0100)]
leak: Appliance name was leaked during guestfs_launch.
This frees the string containing the name of the appliance
which was previously being leaked during launch.
(Found by valgrind).
Matthew Booth [Tue, 21 Sep 2010 12:22:58 +0000 (13:22 +0100)]
Add more exclusions to .gitignore.
Matthew Booth [Tue, 21 Sep 2010 09:50:41 +0000 (10:50 +0100)]
Fix appliance build dependency problem
The appliance was being completely rebuilt every time guestfsd was updated. This
was because make.sh depended on guestfsd, which it had to do because it
called update.sh to install guestfsd.
This fix removes the call to update.sh in make.sh, and therefore the dependency
on guestfsd. The Makefile already includes a rule to run update.sh when guestfsd
is updated, so this was unnecessary.
Richard W.M. Jones [Tue, 21 Sep 2010 07:53:44 +0000 (08:53 +0100)]
fish: Add --echo-keys option to allow passphrases/keys to be echoed.
See also:
http://catless.ncl.ac.uk/Risks/26.17.html#subj13.3
Richard W.M. Jones [Sun, 19 Sep 2010 14:55:46 +0000 (15:55 +0100)]
df: Add --one-per-guest option for using one appliance per guest.
Richard W.M. Jones [Mon, 20 Sep 2010 13:02:06 +0000 (14:02 +0100)]
Fix error launching libguestfs when euid != uid.
When writing to a RHEV target, virt-v2v launches the libguestfs
appliance with euid:egid = 36:36, which is required to write to
an NFS target using root_squash.
Since we changed to using a cached appliance, this causes an error on
start up, as the cached files are owned by root, but the cache directory
is owned by 36:36. The reason is that bash resets euid to uid and
egid to gid so when febootstrap-supermin-helper is executed, it runs as
root:root. The cache directory was created by libguestfs directly so
it has the correct ownership.
This patch fixes the issue by using explicit fork/exec instead of
system (ie. not going via a shell) and by setting the real UID and
GID to the effective UID and GID before execing.
Richard W.M. Jones [Mon, 20 Sep 2010 12:06:13 +0000 (13:06 +0100)]
todo: Suggest removing repo name from appliance name.
Richard W.M. Jones [Sat, 18 Sep 2010 08:38:05 +0000 (09:38 +0100)]
generator: Generate guestfish-only commands.
The guestfish-only commands such as 'alloc' and 'edit' are
now generated from one place in the generator instead of being
spread around ad-hoc in the C code.
Richard W.M. Jones [Sat, 18 Sep 2010 07:57:30 +0000 (08:57 +0100)]
fish: In guestfish(1) turn command references into links.
Richard W.M. Jones [Fri, 17 Sep 2010 13:35:43 +0000 (14:35 +0100)]
fish: Correction for online help for 'edit' and 'more' commands.
This corrects commit
b5c287bcd456bdb02d8ec0443483df34f4fd6b5d
and commit
639ca1828b167bf59353f0cd3c8c79c6289bbd5d.
Richard Jones [Wed, 15 Sep 2010 21:12:35 +0000 (22:12 +0100)]
Version 1.5.16.
Richard Jones [Wed, 15 Sep 2010 21:08:35 +0000 (22:08 +0100)]
configure: Make "fedora-13" the default repository.
Richard Jones [Wed, 15 Sep 2010 20:47:37 +0000 (21:47 +0100)]
fish: If -m option fails, suggest a mountpoint.
Richard Jones [Wed, 15 Sep 2010 19:49:32 +0000 (20:49 +0100)]
todo: Remove section since we now have list-filesystems API.
Richard Jones [Wed, 15 Sep 2010 19:35:06 +0000 (20:35 +0100)]
Version 1.5.15.
Richard Jones [Wed, 15 Sep 2010 16:22:29 +0000 (17:22 +0100)]
New API: list-filesystems: list filesystems
This API is a simpler replacement for the guestfish commands
list-devices / list-partitions / lvs, in the case where you are
just examining a guest by hand to see what it contains.
Typical usage and output in guestfish is like this:
$ guestfish --ro -a /dev/vg_trick/F13x64
><fs> run
><fs> list-filesystems
/dev/vda1: ext4
/dev/vg_f13x64/lv_root: ext4
/dev/vg_f13x64/lv_swap: swap
It can also be used to replace programs that try to mount
devices to determine if they are mountable filesystems.
Richard Jones [Wed, 15 Sep 2010 15:39:36 +0000 (16:39 +0100)]
New API: part-to-dev: Convert partition name to device name.
This adds a formal API for going from a partition to the containing
device, eg. /dev/sda1 -> /dev/sda
Richard Jones [Wed, 15 Sep 2010 16:15:44 +0000 (17:15 +0100)]
generator: Add TestOutputDevice.
This is for testing functions that return a device or partition
name, so that we can compare the return value with the canonical
device name (eg. "/dev/vda1" == "/dev/sda1").
Richard Jones [Wed, 15 Sep 2010 15:37:24 +0000 (16:37 +0100)]
todo: More use of libblkid.
Richard Jones [Tue, 14 Sep 2010 21:29:08 +0000 (22:29 +0100)]
fish: In usage message use new-style -i option syntax.
Richard Jones [Tue, 14 Sep 2010 21:28:10 +0000 (22:28 +0100)]
fish: Update copyright dates in usage message.
Richard Jones [Tue, 14 Sep 2010 21:27:06 +0000 (22:27 +0100)]
fish: Remove extraneous space from usage message.
Richard Jones [Tue, 14 Sep 2010 21:17:24 +0000 (22:17 +0100)]
todo: More ideas.
Richard Jones [Tue, 14 Sep 2010 12:29:59 +0000 (13:29 +0100)]
Version 1.5.14.
Richard Jones [Tue, 14 Sep 2010 11:24:54 +0000 (12:24 +0100)]
configure: Check for virtio-serial support in qemu.
All other vmchannel methods are obsolete, but we were still trying
to check for them. This replaces all of them with a simple check
for virtio-serial.
Richard Jones [Tue, 14 Sep 2010 11:24:12 +0000 (12:24 +0100)]
pardus: Check for cpio in configure.
Richard Jones [Mon, 13 Sep 2010 18:06:39 +0000 (19:06 +0100)]
Update Spanish translation (RHBZ#633357).
Richard Jones [Mon, 13 Sep 2010 15:01:53 +0000 (16:01 +0100)]
build: Add run-test-tool-locally to EXTRA_DIST.
Richard Jones [Mon, 13 Sep 2010 13:47:43 +0000 (14:47 +0100)]
Version 1.5.13.
Richard Jones [Mon, 13 Sep 2010 13:49:16 +0000 (14:49 +0100)]
appliance: Disable setting scheduler to noop.
This is a workaround until
https://bugzilla.redhat.com/show_bug.cgi?id=630583
is fixed (bug in Linux 2.6.36).
Richard Jones [Mon, 13 Sep 2010 13:45:18 +0000 (14:45 +0100)]
ubuntu: Remove bogus debirf file.
Richard Jones [Mon, 13 Sep 2010 13:44:46 +0000 (14:44 +0100)]
ubuntu: Add linux-image to the packagelist.
It seems that linux-image (ie. the kernel) is omitted in some
versions of the base packages.
Richard Jones [Mon, 13 Sep 2010 13:44:05 +0000 (14:44 +0100)]
ubuntu: /proc can be a symlink
If it's a symlink then the succeeding mount commnd will fail.
Remove it and make a /proc directory.
Richard Jones [Mon, 13 Sep 2010 13:42:47 +0000 (14:42 +0100)]
build: 'make quickcheck' rule now uses new run-test-tool-locally script.
Richard Jones [Sat, 11 Sep 2010 16:16:22 +0000 (17:16 +0100)]
build: hivex is required.
hivex library has been required since we moved the inspection
code to C. Check for this in configure.ac.
Richard Jones [Sat, 11 Sep 2010 12:14:45 +0000 (13:14 +0100)]
Version 1.5.12.
Richard Jones [Sat, 11 Sep 2010 12:41:26 +0000 (13:41 +0100)]
build: require Augeas for library.
Augeas has been required since we moved the inspection code to C,
however we were not correctly enforcing this in configure.ac, nor
correctly linking to the library until now.
Richard Jones [Sat, 11 Sep 2010 12:20:59 +0000 (13:20 +0100)]
generator: Provide no-op generator if no OCaml compiler.
Richard Jones [Sat, 11 Sep 2010 12:14:04 +0000 (13:14 +0100)]
build: Don't distribute src/generator.ml, no longer exists.
Richard Jones [Sat, 11 Sep 2010 11:19:25 +0000 (12:19 +0100)]
generator: Calculate MD5 of test.iso at runtime.
Because this used to be compiled into the C test, it changed
every time the ISO was rebuilt (which because of Makefile deps
was every run).
Now it is calculated at runtime so the C test file doesn't keep
changing.
Richard Jones [Sat, 11 Sep 2010 11:05:03 +0000 (12:05 +0100)]
generator: Don't use real uuidgen for UUIDs.
This was one reason why capitests/tests.c changed every time the
generator was run.
Richard Jones [Sat, 11 Sep 2010 08:25:12 +0000 (09:25 +0100)]
Split generator into separate source files.
'src/generator.ml' is no more. Instead the generator is logically
split up over many different source files.
Read generator/README for help and tips.
We compile the generator down to bytecode, not native code. This
means it will run more slowly, but is done for maximum portability.
Richard Jones [Sat, 11 Sep 2010 07:11:43 +0000 (08:11 +0100)]
syntax: Replace -a and -o with && and || for portability.
Richard Jones [Fri, 10 Sep 2010 22:00:07 +0000 (23:00 +0100)]
syntax: Use exit (EXIT_SUCCESS) instead of hard-coded number.