Richard Jones [Wed, 15 Sep 2010 21:08:35 +0000 (22:08 +0100)]
configure: Make "fedora-13" the default repository.
(cherry picked from commit
6b2ae9a8b0efba044f4d409b70211aba450a6899)
Richard Jones [Tue, 14 Sep 2010 21:28:10 +0000 (22:28 +0100)]
fish: Update copyright dates in usage message.
(cherry picked from commit
42b62b8240a9b32f0a198105b03cfadaf97a7a7b)
Richard Jones [Tue, 14 Sep 2010 21:27:06 +0000 (22:27 +0100)]
fish: Remove extraneous space from usage message.
(cherry picked from commit
31a2c006cd6486f0ca5afb11e42bcc412385a074)
Richard Jones [Mon, 13 Sep 2010 13:49:16 +0000 (14:49 +0100)]
appliance: Disable setting scheduler to noop.
This is a workaround until
https://bugzilla.redhat.com/show_bug.cgi?id=630583
is fixed (bug in Linux 2.6.36).
(cherry picked from commit
7419335e1113f28fd17b512992df22eb28cb4c05)
Richard Jones [Sat, 11 Sep 2010 11:05:03 +0000 (12:05 +0100)]
generator: Don't use real uuidgen for UUIDs.
This was one reason why capitests/tests.c changed every time the
generator was run.
Cherry picked from commit
451a28349b11fe08cb3f7ca84e58b6e69646707b.
Richard Jones [Sat, 11 Sep 2010 07:11:43 +0000 (08:11 +0100)]
syntax: Replace -a and -o with && and || for portability.
Cherry picked from commit
264629b9f0ace1062b453b2d0ae55e48385189d3
and backported to stable-1.4.
Richard Jones [Fri, 10 Sep 2010 22:00:07 +0000 (23:00 +0100)]
syntax: Use exit (EXIT_SUCCESS) instead of hard-coded number.
(cherry picked from commit
431503d007b22bf10226843cca84628544fadca9)
Richard Jones [Fri, 10 Sep 2010 21:51:39 +0000 (22:51 +0100)]
syntax: Replace _prohibit_regexp with _sc_search_regexp.
(cherry picked from commit
3d994f3d8e12356223d37c1b45ebe2eb39ef28a6)
Richard Jones [Thu, 9 Sep 2010 21:20:28 +0000 (22:20 +0100)]
daemon: Move 'exists', 'is-file' and 'is-dir' to separate file.
This commit is just code movement.
(cherry picked from commit
3a99114360636806078bbf614c241e89661bcc7f)
Richard Jones [Thu, 9 Sep 2010 21:42:57 +0000 (22:42 +0100)]
generator: Fix incorrect shortdesc in docs for 'is-dir' command.
(cherry picked from commit
55b6e18f95950b1a2ec69d549c9e6c8a5758d166)
Richard Jones [Thu, 9 Sep 2010 21:42:26 +0000 (22:42 +0100)]
generator: Fix documentation for 'is-file' command.
(cherry picked from commit
22aa9268f548eab9763311a080859d8cf2257a93)
Richard Jones [Thu, 9 Sep 2010 13:11:32 +0000 (14:11 +0100)]
fish: Fix 'more' command to work with any file.
(cherry picked from commit
639ca1828b167bf59353f0cd3c8c79c6289bbd5d)
Richard Jones [Thu, 9 Sep 2010 13:11:20 +0000 (14:11 +0100)]
fish: Fix 'edit' command to work with any file.
(cherry picked from commit
b5c287bcd456bdb02d8ec0443483df34f4fd6b5d)
Richard Jones [Thu, 9 Sep 2010 12:53:08 +0000 (13:53 +0100)]
guestfs: Reference guestfs-browser architecture in threads documentation.
(cherry picked from commit
13be76168260ee57e3d134177066ca7ceb984092)
Richard Jones [Thu, 9 Sep 2010 12:52:32 +0000 (13:52 +0100)]
guestfs: More accurate documentation for initial message.
(cherry picked from commit
e2ef068cb7d18f0c0d4931f97332a38ea4ea2477)
Richard Jones [Thu, 9 Sep 2010 12:51:52 +0000 (13:51 +0100)]
guestfs: Remove traces of documentation for non-existent 'low-level API'
(cherry picked from commit
6d9f8f5c140c3116fb0292fcf73f560812c7d5fb)
Richard Jones [Thu, 9 Sep 2010 11:00:36 +0000 (12:00 +0100)]
guestfs: Fix typo in man page.
(cherry picked from commit
f3c05da4f9c226c18476eb135dfcb5875d65bf63)
Richard Jones [Wed, 8 Sep 2010 09:23:28 +0000 (10:23 +0100)]
fish: Improve appearance of guestfish -N help output.
(cherry picked from commit
45f72c804b6fa76d94b7195bd5faea8c0d6f6b3d)
Richard Jones [Wed, 8 Sep 2010 08:05:18 +0000 (09:05 +0100)]
fish: Generate list of prepared disk image types.
This commit shouldn't change the semantics of the code.
Cherry picked from commit
60cdd02b02578b427ca3926d566811c6bb7a9970.
Richard Jones [Wed, 8 Sep 2010 13:27:58 +0000 (14:27 +0100)]
Version 1.4.5.
Richard Jones [Wed, 8 Sep 2010 15:42:06 +0000 (16:42 +0100)]
daemon: Fix debug-upload command if compiled without --enable-debug.
This was an upstream bug which we never encountered, and meanwhile
was fixed upstream by removing the conditional --enable-debug code.
Richard Jones [Mon, 6 Sep 2010 09:13:31 +0000 (10:13 +0100)]
test-tool: Add a 'run-test-tool-locally' script.
This can be used to run the test tool without installing it.
It sets the environment variables and command line arguments
up correctly to run the tool from the build directory.
(cherry picked from commit
06c906168c0a96662ad47473cfe5f2fb3c316757)
Richard Jones [Mon, 6 Sep 2010 09:03:38 +0000 (10:03 +0100)]
daemon: Don't warn about 'long long' usage.
This removes a fatal warning (-Werror) which stops compilation
on 32 bit machines.
(cherry picked from commit
aa96881a512a144f4611a8e7c9801be9bb7ff9cf)
Richard Jones [Thu, 2 Sep 2010 21:27:35 +0000 (22:27 +0100)]
build: guestfs-structs.h was missing from libguestfs_la_SOURCES.
(cherry picked from commit
5fc69ce3ece5e4d4a3da9d78da244c4fa301b5ac)
Richard Jones [Thu, 2 Sep 2010 10:11:55 +0000 (11:11 +0100)]
perl: Document handle is a hashref.
For details see commit
eb566f7dc7974b42ac65729a2e5e5bcee329a0a9.
(cherry picked from commit
b8b0c99b46172712aa190f70182734934587af7b)
Richard Jones [Thu, 2 Sep 2010 09:58:28 +0000 (10:58 +0100)]
perl: Add documentation about testing availability of methods and features.
(cherry picked from commit
0f24424f357e854a9da382de11e4fe81305c8743)
Richard Jones [Wed, 1 Sep 2010 12:19:05 +0000 (13:19 +0100)]
Consistent use of 'void *opaque' to refer to opaque pointer in C API.
We inconsistently used 'void *data' or 'void *opaque' all over to
refer to the same thing. Use 'void *opaque' in all places in the
published API and documentation.
Cherry picked from commit
867319ec5f9030d3c14c32e3302606f2bf11ac27.
Richard Jones [Sat, 28 Aug 2010 12:13:56 +0000 (13:13 +0100)]
Version 1.4.4.
Richard Jones [Fri, 27 Aug 2010 12:38:49 +0000 (13:38 +0100)]
build: Don't add version extra string to the version number.
If this string was non-empty, then it broke a lot of things because
autoconf and other parts of the build system were expecting this
string to contain a simple MAJOR.MINOR.RELEASE version number.
This requires changes to guestfish and guestmount so they use the
guestfs_version API to fetch the version from the library. (The
Perl tools were already doing it this way). In a way this is more
accurate, because it's no longer hard-coded in the binary, but
fetched from the dynamically linked libguestfs.so.
(cherry picked from commit
4932fdca3ca1e9002164a1c0b73876f32739d34d)
Richard Jones [Thu, 26 Aug 2010 21:49:25 +0000 (22:49 +0100)]
Version 1.4.3.
Richard Jones [Thu, 26 Aug 2010 14:55:34 +0000 (15:55 +0100)]
rescue: Fix typo in comment.
(cherry picked from commit
daead56fae46a4fedfef176fa3ed1ba37f88a078)
Richard Jones [Wed, 25 Aug 2010 10:41:17 +0000 (11:41 +0100)]
Rename global 'xdr_str'.
Two bits of XDR both contained a definition called 'str' which
means that 'xdr_str' was being exported globally twice. Because
of the linker script this didn't affect us. But it's best to
rename this global so that conflicts cannot arise.
(cherry picked from commit
27ef6f9171127afd248f38d280cf3d0eae51fdaf)
Daniel Berrange [Tue, 24 Aug 2010 13:27:15 +0000 (14:27 +0100)]
Add -nodefconfig command line option to qemu.
Without this option, qemu will read some defaults from /etc/qemu/
configuration files.
(cherry picked from commit
6d15d4e7c27477507ba355384a340ce86cec617b)
Richard Jones [Mon, 23 Aug 2010 21:58:51 +0000 (22:58 +0100)]
Don't print debug messages when not in verbose mode.
Don't print them because no one's listening ...
(cherry picked from commit
5c1346dae72064f7fd9c2afe5517afc6f050cd9a)
Richard Jones [Mon, 23 Aug 2010 11:54:27 +0000 (12:54 +0100)]
Make print_timestamped_message into a cross-module function.
This is just code movement.
(cherry picked from commit
4b753c62089be663ac722e4a875bb061d259e87d)
Richard Jones [Mon, 23 Aug 2010 11:53:11 +0000 (12:53 +0100)]
Factor out code for locating the temporary directory.
This is just code movement.
For stable-1.4 branch, cherry picked from
commit
a2d4a8bf073c3551d174bd6c406e0cf3d27fb560
and backported.
Richard Jones [Sat, 21 Aug 2010 11:45:51 +0000 (12:45 +0100)]
Whitespace change: Add blank line between structures and functions.
(cherry picked from commit
4d2f1632ad655130fafab3bf7fe8fa5cb59705d8)
Richard Jones [Sat, 21 Aug 2010 09:39:39 +0000 (10:39 +0100)]
appliance: Remove some obsolete testing rules from Makefile.am
This haven't been used -- and haven't worked -- for a long time.
(cherry picked from commit
c56fa58721a710aeb4a41bd73a472354a2128069)
Richard Jones [Tue, 17 Aug 2010 10:26:54 +0000 (11:26 +0100)]
generator: No need to redefine safe_* macros.
These are already defined in "guestfs-internal.h" which is
included in the .c file.
(cherry picked from commit
3cd272fc6acb043b4002dbcbbf741cecbc4820be)
Richard Jones [Tue, 17 Aug 2010 10:26:26 +0000 (11:26 +0100)]
Add safe_strndup call.
(cherry picked from commit
3905cc7ab496549b6ca0a0f67ec61d1d16968c33)
Richard Jones [Tue, 17 Aug 2010 14:39:36 +0000 (15:39 +0100)]
Version 1.4.2.
Richard Jones [Sat, 31 Jul 2010 13:35:07 +0000 (14:35 +0100)]
generator: Fix typo in error message for RConstOptString.
(cherry picked from commit
29925244c1be2d1d5f71d46eba205278624a1366)
Richard Jones [Wed, 28 Jul 2010 11:38:36 +0000 (12:38 +0100)]
Rename internal functions.
This is an update to commit
41f25ab3df5f306ac717fa7a6efd58328d30c1ae.
Internal functions should be named guestfs___* (3 underscores) to
avoid clashing with the implementation of actions (2 underscores).
(cherry picked from commit
737181bcd7b1de8c3a613d6282030c34efa78fb6)
Richard Jones [Tue, 27 Jul 2010 12:01:39 +0000 (13:01 +0100)]
Rearrange library code into separate files.
We split the library code into these separate files:
- guestfs.c: creating handles, closing handles, handle-related variables
- actions.c: generated library-side stubs for each action
- bindtests.c: generated code to test bindings
- launch.c: launching the appliance
- proto.c: the library side of the daemon communications protocol
This is just code movement.
Cherry picked from commit
41f25ab3df5f306ac717fa7a6efd58328d30c1ae
and rebased for stable branch.
Richard Jones [Tue, 27 Jul 2010 11:29:59 +0000 (12:29 +0100)]
Rename guestfs-{actions,bindtests}.c to {actions,bindtests}.c
Rename these two generated files, in preparation for splitting
up the main src/guestfs.c file.
(cherry picked from commit
a617f521a4f695a63ced1c734128dc6c05b7024f)
Richard Jones [Thu, 22 Jul 2010 15:49:06 +0000 (16:49 +0100)]
regressions: Don't print misleading 'Expect error ...' lines.
Some tests in the regressions directory deliberately print
error messages. As long as they still PASS, this is OK.
However these tests also printed some misleading messages
about what error to expect. Since error messages were slightly
different across distros, these messages were not accurate.
Therefore remove these messages, and replace with a general
message before all tests telling users not to worry about
errors from the tests as long as the tests don't fail.
(cherry picked from commit
e7ee6eebed6ee3a5b56c0482ba2770e697d8febc)
Richard Jones [Thu, 22 Jul 2010 15:51:05 +0000 (16:51 +0100)]
Move variable initialization close to variable use.
(cherry picked from commit
2fd8c259d3daa88b0cdf98090bb57f3dbd178432)
Richard Jones [Thu, 22 Jul 2010 13:39:36 +0000 (14:39 +0100)]
Revert "add_drive_ro adds readonly=on option if available." (RHBZ#617200).
Adding the readonly=on option is not so clever. This causes
qemu to present the disk as read-only to the guest. (The
expected behaviour of snapshots=on,readonly=on was that it
would open the disk O_RDONLY but present a writable disk to
the guest).
Since the guest sees a read-only disk, we are unable to do any
recovery if a filesystem on the disk is inconsistent. This basically
prevents most accesses to live disk images.
What we really want is a qemu option which presents a writable
disk to the guest, but only opens the disk on the host side with
O_RDONLY, to alleviate the udev bug RHBZ#571714.
This reverts commit
676462684e05dd8341dd695762dd99a87d8ec022.
(cherry picked from commit
799d52be4f08f6c70c0e8ba1aa7367ba4cdd78c4)
Richard Jones [Wed, 21 Jul 2010 11:52:10 +0000 (12:52 +0100)]
generator: Remove unnecessary parameter.
The 'name' parameter is not used on the right hand side of the
match, so it can be removed.
(cherry picked from commit
2e7da2a2f3bbc6d6db148d7dc2ce238bf56f34db)
Richard Jones [Fri, 16 Jul 2010 11:58:54 +0000 (12:58 +0100)]
Use an unsigned type (size_t) for all loop iterators.
This resolves a warning from gcc 4.5:
assuming signed overflow does not occur when simplifying
conditional to constant
This page explains the issues in some detail:
http://www.airs.com/blog/archives/120
(cherry picked from commit
321ca1ef91a90cec5b94058b84420e8018e3f1d8)
Richard Jones [Fri, 16 Jul 2010 11:57:24 +0000 (12:57 +0100)]
generator: Don't hard-code name in DeviceList check.
Only one function currently uses DeviceList. The generated code
unfortunately hard-coded the argument name from that function.
(cherry picked from commit
aac51942aab63a9355ad6724345ea923148bf2a9)
Richard Jones [Fri, 16 Jul 2010 11:55:17 +0000 (12:55 +0100)]
build: Don't warn about 'long long'.
Various language bindings simply need this, so we have to allow
it even though it's a GCC extension.
(cherry picked from commit
0c0976496dafda4d172c5a7fc787d6a87d5bce8d)
Richard Jones [Fri, 16 Jul 2010 14:17:01 +0000 (15:17 +0100)]
doc: Add guestfish 'lvcreate 1M' gotcha.
(cherry picked from commit
5b77be72bc4e46c7a53a24f1eb4cbd107a708f17)
Richard Jones [Mon, 12 Jul 2010 07:49:29 +0000 (08:49 +0100)]
Version 1.4.1
Richard Jones [Sun, 11 Jul 2010 22:11:45 +0000 (23:11 +0100)]
tar: Remove redundant use statement.
(cherry picked from commit
70d27f6e796097630134bd8ebc2b65a65b1bf5c4)
Richard Jones [Sun, 11 Jul 2010 22:11:08 +0000 (23:11 +0100)]
edit: Clean up temporary files.
Note to self: The 'tempfile' function does *not* default to
removing files with the program exits!
For stable-1.4 branch:
- Cherry picked from commit
10ea14a3f1adb7023dd0601e4759bd24a030a1c3
- Rebased
Richard Jones [Thu, 8 Jul 2010 10:55:57 +0000 (11:55 +0100)]
Prepare for new stable branch, starting at version 1.4.0.
Add BUGS and RELEASE-NOTES to EXTRA_DIST.
Update RELEASE-NOTES by copying the final file from the
development branch.
Richard Jones [Wed, 7 Jul 2010 14:01:38 +0000 (15:01 +0100)]
fish: Don't fail if -m and --listen flags are both given (RHBZ#612178).
Testing this against a Fedora disk image:
$ ./fish/guestfish --ro -a F13.img -m /dev/sda1 --listen
export GUESTFISH_PID=6033
$ ./fish/guestfish --remote=6033 -- ping-daemon
$ ./fish/guestfish --remote=6033 -- ping-daemon
$ ./fish/guestfish --remote=6033 -- exit
Without this fix the first remote command would fail because
qemu would have already been killed.
Richard Jones [Fri, 2 Jul 2010 19:12:41 +0000 (20:12 +0100)]
todo: Add comment about progress of long-running operations.
Richard Jones [Fri, 2 Jul 2010 09:50:38 +0000 (10:50 +0100)]
inspector: Improve error message when YAML::Any library is not installed.
Richard Jones [Mon, 28 Jun 2010 12:51:42 +0000 (13:51 +0100)]
Explicitly depend on e2fsprogs.
See: http://lists.fedoraproject.org/pipermail/devel/2010-June/137953.html
Richard Jones [Mon, 28 Jun 2010 08:13:36 +0000 (09:13 +0100)]
Fix gfs2 support by adding required kernel modules.
Richard Jones [Wed, 16 Jun 2010 15:12:52 +0000 (16:12 +0100)]
Version 1.3.21.
Richard Jones [Wed, 16 Jun 2010 14:25:45 +0000 (15:25 +0100)]
ocaml: Fix thread safety of strings in bindings (RHBZ#604691).
There's a thread safety issue with the current OCaml bindings which
is well explained in the bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=604691
This commit fixes the safety issue by copying strings temporarily
before releasing the thread lock. Updated code looks like this:
char *filename = guestfs_safe_strdup (g, String_val (filenamev));
int r;
caml_enter_blocking_section ();
r = guestfs_add_drive_ro (g, filename);
caml_leave_blocking_section ();
free (filename);
if (r == -1)
ocaml_guestfs_raise_error (g, "add_drive_ro");
Also included is a regression test.
Richard Jones [Wed, 16 Jun 2010 13:29:39 +0000 (14:29 +0100)]
TODO: Add a note about impl of list-filesystems.
Richard Jones [Tue, 15 Jun 2010 10:15:30 +0000 (11:15 +0100)]
todo: More ideas for TODO list.
Richard Jones [Tue, 15 Jun 2010 10:15:06 +0000 (11:15 +0100)]
Update Spanish translations (RHBZ#603870).
Richard Jones [Fri, 11 Jun 2010 09:40:48 +0000 (10:40 +0100)]
perl: Check all images are defined in first param of open_guest.
Richard Jones [Thu, 10 Jun 2010 14:25:43 +0000 (15:25 +0100)]
perl: Add explicit close() method (RHBZ#602592).
This add an optional explicit $g->close method which may be
used to force the handle to be closed immediately. Note the
provisos about this method in the manual page entry. Callers
should *not* normally use this method.
The implementation of the handle also changes. Before, the
handle was a blessed reference to an integer (the integer
being the pointer to the C guestfs_h handle). Now we change
this to a hashref containing currently the following field:
_g => pointer to C guestfs_h handle (as an integer)
If this field is not present, it means that the handle has been
explicitly closed. This avoids double-freeing the handle.
The user may add their own fields to this hash in order to store
per-handle data. However any fields whose names begin with
an underscore are reserved for use by the Perl bindings.
This commit also adds a regression test.
This commit also changes the existing warning when you call
a method without a Sys::Guestfs handle as the first parameter,
into an error. This is because such cases are always errors.
Richard Jones [Thu, 10 Jun 2010 11:38:57 +0000 (12:38 +0100)]
Add error callback (RHBZ#602599).
Read the note in the man page before using this feature.
Richard Jones [Thu, 10 Jun 2010 11:26:06 +0000 (12:26 +0100)]
Fix typo in documentation of guestfs_set_launch_done_callback.
Richard Jones [Tue, 8 Jun 2010 17:17:37 +0000 (18:17 +0100)]
Version 1.3.20.
Richard Jones [Tue, 8 Jun 2010 17:17:46 +0000 (18:17 +0100)]
Revert "perl: Rerun configure if MAX_PROC_NR changes."
This reverts commit
f8ee7869f4836427109959cf20e299a31fa86eaf.
Richard Jones [Tue, 8 Jun 2010 17:12:32 +0000 (18:12 +0100)]
TODO: Freeze/thaw filesystems.
Richard Jones [Tue, 8 Jun 2010 17:11:16 +0000 (18:11 +0100)]
TODO: Need to add regression test for virt-inspector.
Richard Jones [Tue, 8 Jun 2010 17:04:17 +0000 (18:04 +0100)]
TODO: 'file' command should be fixed.
Richard Jones [Tue, 8 Jun 2010 15:44:18 +0000 (16:44 +0100)]
virt-df: Disallow -h and --csv options together (RHBZ#600977).
Before this commit, if you used the -h and --csv options together
you would get these warnings from virt-df:
$ virt-df -h --csv Guest
Virtual Machine,Filesystem,Size,Used,Available,Use%
Argument "13.5G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "4.7G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "8.1G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
"/dev/vg_trick/RHEL55x64","/dev/VolGroup00/LogVol00",13,4,8,34.8%
Argument "98.7M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "18.8M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "74.9M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
"/dev/vg_trick/RHEL55x64","/dev/vda1",98,18,74,19.0%
We could fix this so that the human-readable numbers get written
into the CSV file. However would probably be wrong for most uses
of the CSV format (databases and spreadsheets) since they would not
be able to interpret these human-readable numbers, or worse could
misinterpret, eg. thinking that "1M" and "1G" are both 1.
Therefore this commit disallows this combination of options.
Richard Jones [Tue, 8 Jun 2010 15:04:01 +0000 (16:04 +0100)]
file: Fix file command on /dev/VG/LV paths (RHBZ#582484).
Previous commit
4df593496e116dfb635731c058b7627e81fc179c broke the
"file" command on logical volume paths, since these are symbolic
links. We *should* follow these (only).
This inadvertantly broke virt-inspector too, which indicates that
we need more regression testing in this area. Since carrying whole
Fedora images around could make the distribution even larger than
now, I'm not sure at the moment how to do this.
Thanks to Matt Booth for diagnosing this bug.
Richard Jones [Mon, 7 Jun 2010 14:29:31 +0000 (15:29 +0100)]
Use the noop scheduler inside the appliance.
In my limited tests, this seems to make a small but noticable
difference, improving the performance of some straightforward
read operations by a little over 10%.
For more information see:
http://kbase.redhat.com/faq/docs/DOC-5428
Richard Jones [Fri, 4 Jun 2010 17:44:49 +0000 (18:44 +0100)]
Add release notes.
To generate the "Bugs fixed" list, run the bugs-in-changelog script
like this:
./bugs-in-changelog 1.0.89..
Richard Jones [Fri, 4 Jun 2010 15:38:55 +0000 (16:38 +0100)]
Version 1.3.19.
Update BUGS and PO files.
Richard Jones [Fri, 4 Jun 2010 10:45:06 +0000 (11:45 +0100)]
file: Restrict to regular files (RHBZ#582484).
The file call can hang if called on char devices (because we are
using the file -s option).
This is hard to solve cleanly without adding another file API.
However this restricts file to regular files, unless called explicitly
with a /dev/ path. For non-regular files, it will now return a
string like "directory".
There is a small semantic change for symbolic links. Previously
it would not have worked at all on absolute links (or rather, the
results would have been undefined). It would have treated relative
symlinks to regular files as the regular file itself. Now it will
return the string "symbolic link" in both cases.
This commit also makes the API safe when called on untrusted
filesystems. Previously a filesystem might have been set up so
that (eg) /etc/redhat-release was a char device, which would have
caused virt-inspector and virt-v2v to hang. Now it will not hang.
Richard Jones [Fri, 4 Jun 2010 10:55:54 +0000 (11:55 +0100)]
touch: Restrict touch to regular files only (RHBZ#582484).
Richard Jones [Fri, 4 Jun 2010 10:23:01 +0000 (11:23 +0100)]
daemon: Rearrange code in 'file' command.
path = path to access file (/sysroot/.. or /dev/..)
display_path = original path, saved so we can display it
buf = optional buffer which is freed along return codepaths
There should be no change to the semantics of the code.
Richard Jones [Fri, 4 Jun 2010 10:21:58 +0000 (11:21 +0100)]
gnulib: Ignore asm-underscore.m4 in the correct place.
Richard Jones [Fri, 4 Jun 2010 08:46:34 +0000 (09:46 +0100)]
Update to latest gnulib.
Richard Jones [Thu, 3 Jun 2010 13:03:08 +0000 (14:03 +0100)]
mkfs-b: Map block size to cluster size for VFAT and NTFS partitions (RHBZ#599464).
This also adds a regression test for VFAT and (conditionally)
NTFS filesystems.
Richard Jones [Thu, 3 Jun 2010 13:01:18 +0000 (14:01 +0100)]
mkfs-b: Check that blocksize parameter is > 0 and a power of 2.
Richard Jones [Thu, 3 Jun 2010 13:31:58 +0000 (14:31 +0100)]
generator: Allow individual tests to depend on daemon features.
Using IfAvailable "featurename" we allow individual tests to
only run if the feature is available in the daemon.
This will allow us to extend testing to a lot more optional
features such as NTFS.
Richard Jones [Thu, 3 Jun 2010 13:30:36 +0000 (14:30 +0100)]
tests: Factor out common code into 'is_available' function.
This commit is just code motion.
Richard Jones [Thu, 3 Jun 2010 10:49:38 +0000 (11:49 +0100)]
grub-install: Enable grub-install tests and create explicit device.map file.
Richard Jones [Thu, 3 Jun 2010 10:48:41 +0000 (11:48 +0100)]
grub-install: In docs suggest manually creating device.map (RHBZ#484986).
Richard Jones [Wed, 2 Jun 2010 17:47:30 +0000 (18:47 +0100)]
Version 1.3.18.
Update BUGS and PO files.
Richard Jones [Wed, 2 Jun 2010 16:12:59 +0000 (17:12 +0100)]
RHEL 6: sr_mod.ko is needed for RHEL 6 to see CD-ROM devices (RHBZ#598807).
Richard Jones [Wed, 2 Jun 2010 14:35:58 +0000 (15:35 +0100)]
parted: Check partition number >= 1 in several calls.
Richard Jones [Wed, 2 Jun 2010 11:32:33 +0000 (12:32 +0100)]
daemon: Parse output of old parted which didn't support -m option (RHBZ#598309).
This fixes the following commands when run with RHEL 5-era parted:
get-bootable
get-parttype
part-list
Richard Jones [Wed, 2 Jun 2010 11:31:40 +0000 (12:31 +0100)]
daemon: count_strings function returns size_t
Richard Jones [Wed, 2 Jun 2010 14:10:38 +0000 (15:10 +0100)]
base64-in: Ignore garbage characters in input.
On RHEL 5 you have to specify the -i option to get the
external 'base64' command to ignore \n characters. (The
Fedora version seems to ignore these characters anyway).
Add this option so the tests can pass on RHEL 5.
Richard Jones [Wed, 2 Jun 2010 12:27:19 +0000 (13:27 +0100)]
resize2fs: Document this command also works with ext4 (thanks Yufang Zhang).
Richard Jones [Tue, 1 Jun 2010 15:27:33 +0000 (16:27 +0100)]
fish: help command return error for non-existent commands (RHBZ#597145).
With this change, the exit status indicates error for non-existent
commands.
$ guestfish -h foo
foo: command not known, use -h to list all commands
$ echo $?
1
$ guestfish help foo
foo: command not known, use -h to list all commands
$ echo $?
1