libguestfs.git
11 years agoedit.c: avoid warning about signed/unsigned comparison
Jim Meyering [Fri, 21 Aug 2009 12:41:49 +0000 (14:41 +0200)]
edit.c: avoid warning about signed/unsigned comparison

* fish/edit.c (load_file): Change type of param from int to size_t.
(do_edit): Adjust caller.

11 years agoRemove virt-v2v. New repo: http://gitorious.org/virt-v2v/
Richard Jones [Thu, 20 Aug 2009 15:28:35 +0000 (16:28 +0100)]
Remove virt-v2v.  New repo: gitorious.org/virt-v2v/

11 years agodaemon: diagnose socket write failure
Jim Meyering [Thu, 20 Aug 2009 10:29:46 +0000 (12:29 +0200)]
daemon: diagnose socket write failure

* daemon/proto.c (send_chunk): Don't ignore socket-write error.
* daemon/proto.c (send_file_end): Return "int", not void,
so we can propagate send_chunk failure to caller.
* daemon/daemon.h (send_file_end): Update prototype.
* daemon/tar.c (do_tar_out, do_tgz_out): Update uses of send_file_end.
* daemon/upload.c (do_download): Likewise.

11 years agotests: Found three more references to the squashfs, replaced with ISO.
Richard W.M. Jones [Wed, 19 Aug 2009 20:37:56 +0000 (21:37 +0100)]
tests: Found three more references to the squashfs, replaced with ISO.

11 years agotests: namemax on ISO devices is 255 1.0.68
Richard Jones [Wed, 19 Aug 2009 16:51:40 +0000 (17:51 +0100)]
tests: namemax on ISO devices is 255

Was 256 for the old squashfs device.

11 years agoCleanup initialisation of hash entries in Lib.pm
Matthew Booth [Wed, 19 Aug 2009 14:51:27 +0000 (15:51 +0100)]
Cleanup initialisation of hash entries in Lib.pm

11 years agotests: Use ISO instead of squashfs.
Richard Jones [Wed, 19 Aug 2009 14:09:27 +0000 (15:09 +0100)]
tests: Use ISO instead of squashfs.

The squashfs format changes too much.  Use an ISO file for
the tests instead.

11 years agomke2fs: Use e4fsprogs programs if available.
Richard W.M. Jones [Wed, 19 Aug 2009 13:03:35 +0000 (14:03 +0100)]
mke2fs: Use e4fsprogs programs if available.

On RHEL 5, mke2fs is ancient, and there is a non-standard "mke4fs"
binary which acts like the more recent mke2fs on Fedora.  Since there
are several annoyances and actual bugs in the ancient RHEL 5 mke2fs,
use mke4fs instead if it's available.

11 years agotests: modprobe fat instead of ext2 module.
Richard W.M. Jones [Wed, 19 Aug 2009 13:02:08 +0000 (14:02 +0100)]
tests: modprobe fat instead of ext2 module.

On RHEL 5, ext2 is compiled into the kernel, so trying to modprobe
it will fail.  I've checked that fat.ko is always a module on the
platforms we care about (RHEL 5, Fedora 11, Debian), so use that
to test instead.

11 years agotests: Conditionally skip UUID tests.
Richard W.M. Jones [Wed, 19 Aug 2009 13:01:13 +0000 (14:01 +0100)]
tests: Conditionally skip UUID tests.

More tests introduced which break with old e2fsprogs that didn't
support UUIDs.  Skip those tests when the old platform is
detected.

Also tidy up this code a little.

11 years agoavoid build failure due to Haskell keyword clash
Jim Meyering [Wed, 19 Aug 2009 12:30:02 +0000 (14:30 +0200)]
avoid build failure due to Haskell keyword clash

* src/generator.ml: Fix this particular problem by
renaming the "module" parameter to "modulename".
Avoid the general problem by ensuring that no parameter name is
in the set of nearly all Haskell, OCaml and C reserved words.
(zfile): Adjust one more offender: s/method/meth/.

11 years agoExport inspect_linux_kernel in Lib.pm
Matthew Booth [Wed, 19 Aug 2009 11:52:16 +0000 (12:52 +0100)]
Export inspect_linux_kernel in Lib.pm

11 years agoAdd boot/grub_fs to output
Matthew Booth [Wed, 19 Aug 2009 10:42:46 +0000 (11:42 +0100)]
Add boot/grub_fs to output

If present, this gives the mount point of the filesystem which contains grub.
All entries in grub.conf will be relative to this filesystem.

11 years agoguestfish: detect more failed syscalls
Jim Meyering [Wed, 19 Aug 2009 08:01:07 +0000 (10:01 +0200)]
guestfish: detect more failed syscalls

* fish/fish.c (issue_command): Detect/diagnose more failed syscalls.

11 years agoPrepare for version 1.0.68.
Richard Jones [Wed, 19 Aug 2009 08:44:51 +0000 (09:44 +0100)]
Prepare for version 1.0.68.

11 years agoguestfs_launch: Correct checks for dup failure.
Richard Jones [Wed, 19 Aug 2009 08:37:44 +0000 (09:37 +0100)]
guestfs_launch: Correct checks for dup failure.

11 years agoUpdated PO files.
Richard Jones [Wed, 19 Aug 2009 08:10:24 +0000 (09:10 +0100)]
Updated PO files.

11 years agobuild: Comment out some unused macros.
Richard Jones [Wed, 19 Aug 2009 08:09:47 +0000 (09:09 +0100)]
build: Comment out some unused macros.

GCC 4.4.1 warns about some unused macros.  Comment these out
while they are not used.

11 years agobuild: new configure-time option: --enable-gcc-warnings
Jim Meyering [Tue, 18 Aug 2009 12:56:48 +0000 (14:56 +0200)]
build: new configure-time option: --enable-gcc-warnings

* configure.ac: Define/configure it.
* src/Makefile.am: Use new variables.

11 years agosuppress warnings from -Wmissing-noreturn
Jim Meyering [Tue, 18 Aug 2009 13:39:26 +0000 (15:39 +0200)]
suppress warnings from -Wmissing-noreturn

Even though these functions are marked as "not implemented yet",
and they will surely return a value once implemented, ...
* src/guestfs.c (select_add_timeout): Declare with noreturn attribute.
(select_remove_timeout): Likewise.

11 years agosuppress a warning from -Wswitch-default
Jim Meyering [Tue, 18 Aug 2009 13:35:32 +0000 (15:35 +0200)]
suppress a warning from -Wswitch-default

* src/guestfs.c (guestfs_end_busy): Add a "default:" label.

11 years agosuppress signed/unsigned-comparison warnings
Jim Meyering [Tue, 18 Aug 2009 13:32:40 +0000 (15:32 +0200)]
suppress signed/unsigned-comparison warnings

* src/guestfs.c [struct guestfs_h] (msg_in_size, msg_in_allocated):
(msg_out_size, msg_out_allocated): Change type from int to unsigned int.

11 years agobuild: don't perform arithmetic on void* pointers
Jim Meyering [Tue, 18 Aug 2009 13:23:35 +0000 (15:23 +0200)]
build: don't perform arithmetic on void* pointers

* src/guestfs.c (receive_file_data_sync, xread, xwrite): Use char*.

11 years agogenerator.ml: suppress signed/unsigned-compare warnings
Jim Meyering [Tue, 18 Aug 2009 13:12:26 +0000 (15:12 +0200)]
generator.ml: suppress signed/unsigned-compare warnings

* src/generator.ml (check_reply_header): Emit parameter declarations
that are unsigned, so as to avoid signed/unsigned-compare warnings.

11 years agobuild: suppress an ignored-dup-return-value warning
Jim Meyering [Tue, 18 Aug 2009 13:03:55 +0000 (15:03 +0200)]
build: suppress an ignored-dup-return-value warning

* src/guestfs.c (guestfs_launch): Handle dup failure.

11 years agobuild: suppress an ignored-write-return-value warning
Jim Meyering [Tue, 18 Aug 2009 12:55:59 +0000 (14:55 +0200)]
build: suppress an ignored-write-return-value warning

* bootstrap (modules): Add ignore-value.
* src/guestfs.c: Include "ignore-value.h".
(stdout_event): Ignore failure to write to stderr.
Also, prefer STDERR_FILENO over the literal "2".
* src/Makefile.am (libguestfs_la_CPPFLAGS): Include gnulib's .h files.
(libprotocol_la_CFLAGS): Remove -Wall -Wno-unused.

11 years agoNew 'modprobe' command.
Matthew Booth [Tue, 18 Aug 2009 14:06:20 +0000 (15:06 +0100)]
New 'modprobe' command.

Allow kernel modules to be loaded into the appliance.

11 years agoavoid compiler warnings about unused vars in generated code
Jim Meyering [Tue, 18 Aug 2009 08:15:57 +0000 (10:15 +0200)]
avoid compiler warnings about unused vars in generated code

* fish/Makefile.am: Compile rc_protocol.c into a convenience library,
so it can have its own CFLAGS, and link that into guestfish.

generator.ml: Use TABs, not spaces for indentation.

11 years agogenerator: Small code rearrangement.
Richard Jones [Tue, 18 Aug 2009 08:16:56 +0000 (09:16 +0100)]
generator: Small code rearrangement.

Move code which updates pod2text memo file into a separate function.

11 years agogenerator.ml: do not emit unused print_* functions
Jim Meyering [Mon, 17 Aug 2009 18:44:01 +0000 (20:44 +0200)]
generator.ml: do not emit unused print_* functions

* src/generator.ml: Do not emit functions like print_xattr,
print_lvm_vg, print_inotify_event, that are not used.

11 years agogenerator.ml: do not emit unused print_*_list functions
Jim Meyering [Mon, 17 Aug 2009 18:28:34 +0000 (20:28 +0200)]
generator.ml: do not emit unused print_*_list functions

* src/generator.ml (emit_print_list_function): New function.
Emit a function definition only if it will be used.

11 years agogenerator.ml: avoid warnings in generated tests.c
Jim Meyering [Mon, 17 Aug 2009 16:47:46 +0000 (18:47 +0200)]
generator.ml: avoid warnings in generated tests.c

* src/generator.ml: Avoid warnings in generated tests.c, regarding
print_strings, and in exercising any function that takes a StringList
or DeviceList parameter.
(print_strings): Change param type to "char *const *s".
Declare fully-const initializer for each list-taking function use.
Cast *List argument to "(char **)".

11 years agoavoid compiler warnings about unused vars in generated code
Jim Meyering [Mon, 17 Aug 2009 16:44:37 +0000 (18:44 +0200)]
avoid compiler warnings about unused vars in generated code

* src/Makefile.am: Compile protocol.c into a convenience library, so it
can have its own CFLAGS, and link that with the destination one.

11 years agoImplement 'debug ls' and 'debug ll' commands.
Richard Jones [Tue, 18 Aug 2009 07:56:18 +0000 (08:56 +0100)]
Implement 'debug ls' and 'debug ll' commands.

These commands can be used to list files in the appliance.

11 years agogenerator.ml: Use TABs, not spaces for indentation.
Jim Meyering [Mon, 17 Aug 2009 19:14:34 +0000 (21:14 +0200)]
generator.ml: Use TABs, not spaces for indentation.

11 years agoIgnore manywarnings.m4 / warnings.m4.
Richard W.M. Jones [Mon, 17 Aug 2009 11:27:43 +0000 (12:27 +0100)]
Ignore manywarnings.m4 / warnings.m4.

11 years agojava: Small fix to Java bindings.
Richard W.M. Jones [Mon, 17 Aug 2009 11:26:58 +0000 (12:26 +0100)]
java: Small fix to Java bindings.

Missing declaration of local variable 'i'.

11 years agoHACKING: Document make targets and ./configure --enable-gcc-warnings.
Richard W.M. Jones [Mon, 17 Aug 2009 11:23:32 +0000 (12:23 +0100)]
HACKING: Document make targets and ./configure --enable-gcc-warnings.

11 years agoRemove redundant macro.
Richard W.M. Jones [Mon, 17 Aug 2009 11:23:16 +0000 (12:23 +0100)]
Remove redundant macro.

11 years agoindent with spaces, not TABs
Jim Meyering [Mon, 17 Aug 2009 09:56:10 +0000 (11:56 +0200)]
indent with spaces, not TABs

11 years agodaemon: enable -Werror and many gcc warnings when --enable-gcc-warnings
Jim Meyering [Mon, 17 Aug 2009 08:35:05 +0000 (10:35 +0200)]
daemon: enable -Werror and many gcc warnings when --enable-gcc-warnings

* daemon/m4/gnulib-cache.m4: Add two modules: manywarnings, warnings.
* daemon/configure.ac: Implement --enable-gcc-warnings, and selectively
disable a few warning options that are either not useful or that provoke
too many warnings for now.
Define and AC_SUBST WARN_CFLAGS and WERROR_CFLAGS.
* daemon/Makefile.am (guestfsd_CFLAGS): Use $(WARN_CFLAGS)
and $(WERROR_CFLAGS), rather than just -Wall.

11 years agoxattr.c: avoid warning about comparison between signed and unsigned
Jim Meyering [Mon, 17 Aug 2009 08:30:52 +0000 (10:30 +0200)]
xattr.c: avoid warning about comparison between signed and unsigned

* daemon/xattr.c (getxattrs): Use an unsigned index.

11 years agoguestfsd: don't ignore failed write-to-socket
Jim Meyering [Mon, 17 Aug 2009 08:25:42 +0000 (10:25 +0200)]
guestfsd: don't ignore failed write-to-socket

* daemon/proto.c (reply): Fix typo that would cause us to ignore
failed write-to-socket.

11 years agodaemon.h: avoid warning about possible noreturn function
Jim Meyering [Mon, 17 Aug 2009 07:51:52 +0000 (09:51 +0200)]
daemon.h: avoid warning about possible noreturn function

* daemon/daemon.h (main_loop): Use "noreturn" attribute.

11 years agosfdisk.c, fallocate.c: use a string literal as format
Jim Meyering [Mon, 17 Aug 2009 07:43:18 +0000 (09:43 +0200)]
sfdisk.c, fallocate.c: use a string literal as format

* daemon/fallocate.c (do_fallocate): Format was not a string literal.
* daemon/sfdisk.c (sfdisk): Likewise.

11 years agowc, blockdev: avoid warnings about discarding "const" qualifiers
Jim Meyering [Mon, 17 Aug 2009 07:40:16 +0000 (09:40 +0200)]
wc, blockdev: avoid warnings about discarding "const" qualifiers

* daemon/wc.c (wc): Make "flag" param const.
* daemon/blockdev.c (call_blockdev): Likewise, for "switc".

11 years agodaemon/zero: don't ignore write and close errors
Jim Meyering [Mon, 17 Aug 2009 07:38:50 +0000 (09:38 +0200)]
daemon/zero: don't ignore write and close errors

* daemon/zero.c (do_zero): Detect write and close errors.

11 years agoguestfsd.c: don't perform arithmetic on void pointers
Jim Meyering [Mon, 17 Aug 2009 07:24:47 +0000 (09:24 +0200)]
guestfsd.c: don't perform arithmetic on void pointers

* daemon/guestfsd.c (xread, xwrite): Use char* pointers instead.

11 years agocommand.c: avoid shadowing a global function
Jim Meyering [Mon, 17 Aug 2009 07:16:20 +0000 (09:16 +0200)]
command.c: avoid shadowing a global function

* daemon/command.c (do_sh_lines, do_sh): Do not shadow global "command".

11 years agoavoid warning about old-style no-param function definition
Jim Meyering [Mon, 17 Aug 2009 07:15:34 +0000 (09:15 +0200)]
avoid warning about old-style no-param function definition

* daemon/df.c (do_df, do_df_h): Add "void".
* sync.c (do_sync): Likewise.

11 years agogenerator.ml: emit slightly prettier code
Jim Meyering [Mon, 17 Aug 2009 06:49:00 +0000 (08:49 +0200)]
generator.ml: emit slightly prettier code

* src/generator.ml: Emit a few omitted newlines.

11 years agopython: avoid "_POSIX_C_SOURCE" redefinition warning
Jim Meyering [Fri, 14 Aug 2009 14:54:44 +0000 (16:54 +0200)]
python: avoid "_POSIX_C_SOURCE" redefinition warning

* src/generator.ml: Include <Python.h> *before* <stdio.h>
to avoid redefinition warning about "_POSIX_C_SOURCE".

11 years agoadjust const "**" pointers to avoid warnings
Jim Meyering [Fri, 7 Aug 2009 07:38:37 +0000 (09:38 +0200)]
adjust const "**" pointers to avoid warnings

Also, ...
* src/generator.ml: Add DeviceList type, and propagate that change
out to all calling/interface code.

11 years agotest-tool: Recognize '-t timeout' as an option.
Richard Jones [Sun, 16 Aug 2009 10:15:10 +0000 (11:15 +0100)]
test-tool: Recognize '-t timeout' as an option.

11 years agoNew commands: mkfs-b, mke2journal*, mke2fs-J*
Richard W.M. Jones [Sat, 15 Aug 2009 17:03:21 +0000 (18:03 +0100)]
New commands: mkfs-b, mke2journal*, mke2fs-J*

mkfs-b: Pass the -b (blocksize) parameter to mkfs.

mke2journal and friends: Lets you create external ext2 journals on
devices.

mke2fs-J and friends: Lets you create ext2/3/4 filesystems with
external journals.

11 years agogenerator: Generate the UUIDs for tests randomly.
Richard W.M. Jones [Sat, 15 Aug 2009 17:02:08 +0000 (18:02 +0100)]
generator: Generate the UUIDs for tests randomly.

Adds a uuidgen function which gets the random UUID from the
uuid program.  Uses this for tests.

11 years agoMerge branch '226-elide'
Jim Meyering [Fri, 14 Aug 2009 20:05:39 +0000 (22:05 +0200)]
Merge branch '226-elide'

11 years agobuild: avoid "make sytnax-check" failure
Jim Meyering [Fri, 14 Aug 2009 19:01:48 +0000 (21:01 +0200)]
build: avoid "make sytnax-check" failure

* daemon/configure.ac: Change a leading TAB to 8 spaces.

11 years agogenerator.ml: don't emit unused functions
Jim Meyering [Fri, 14 Aug 2009 17:33:35 +0000 (19:33 +0200)]
generator.ml: don't emit unused functions

* src/generator.ml: Use "rstructs_used" to emit definitions only for
put_TYPE_list functions that are used.

11 years agogenerator.ml: factor out a function
Jim Meyering [Fri, 14 Aug 2009 17:12:18 +0000 (19:12 +0200)]
generator.ml: factor out a function

* src/generator.ml (emit_put_list_function): New function.

11 years agoWork out which RStruct/RStructList structs are really used, and how.
Richard W.M. Jones [Fri, 14 Aug 2009 15:54:55 +0000 (16:54 +0100)]
Work out which RStruct/RStructList structs are really used, and how.

11 years agoguestfish: Add --selinux option.
Richard Jones [Thu, 13 Aug 2009 19:45:06 +0000 (20:45 +0100)]
guestfish: Add --selinux option.

11 years agoVersion 1.0.67. 1.0.67
Richard Jones [Thu, 13 Aug 2009 16:27:38 +0000 (17:27 +0100)]
Version 1.0.67.

11 years agotests: increase likelihood that heap abuse triggers failure
Jim Meyering [Thu, 13 Aug 2009 16:29:59 +0000 (18:29 +0200)]
tests: increase likelihood that heap abuse triggers failure

* regressions/Makefile.am (TESTS_ENVIRONMENT): Always set
MALLOC_PERTURB_ to a random value in 1..255.

11 years agoappliance: Remove /usr/sbin/tcpd - it's unreadable on RHEL 5.4.
Richard Jones [Thu, 13 Aug 2009 16:23:25 +0000 (17:23 +0100)]
appliance: Remove /usr/sbin/tcpd - it's unreadable on RHEL 5.4.

11 years agoappliance: Replace LANG=C with LC_ALL=C
Richard Jones [Thu, 13 Aug 2009 16:16:14 +0000 (17:16 +0100)]
appliance: Replace LANG=C with LC_ALL=C

11 years agoumount: Enable device name translation for device parameter.
Richard Jones [Thu, 13 Aug 2009 15:41:37 +0000 (16:41 +0100)]
umount: Enable device name translation for device parameter.

11 years agomount: Check mountpoints are absolute paths.
Richard Jones [Thu, 13 Aug 2009 14:00:38 +0000 (15:00 +0100)]
mount: Check mountpoints are absolute paths.

11 years agoselinux: Don't fail if libselinux is not found.
Richard Jones [Thu, 13 Aug 2009 13:43:57 +0000 (14:43 +0100)]
selinux: Don't fail if libselinux is not found.

11 years agoMisc parameters which are String but should be Pathname.
Richard Jones [Thu, 13 Aug 2009 13:41:52 +0000 (14:41 +0100)]
Misc parameters which are String but should be Pathname.

11 years agoIn rmmountpoint, have to explicitly check for ABS_PATH (*not* NEED_ROOT).
Richard Jones [Thu, 13 Aug 2009 13:41:05 +0000 (14:41 +0100)]
In rmmountpoint, have to explicitly check for ABS_PATH (*not* NEED_ROOT).

11 years agoinotify-add-watch does not need to explicitly check for ABS_PATH.
Richard Jones [Thu, 13 Aug 2009 13:39:59 +0000 (14:39 +0100)]
inotify-add-watch does not need to explicitly check for ABS_PATH.

11 years agocp/cp-a/mv parameters marked as Pathname.
Richard Jones [Thu, 13 Aug 2009 13:39:31 +0000 (14:39 +0100)]
cp/cp-a/mv parameters marked as Pathname.

11 years agodo_equal does not need to explicitly check for NEED_ROOT/ABS_PATH.
Richard Jones [Thu, 13 Aug 2009 13:37:43 +0000 (14:37 +0100)]
do_equal does not need to explicitly check for NEED_ROOT/ABS_PATH.

11 years agogenerator.ml: convert leading TABs to spaces
Jim Meyering [Thu, 13 Aug 2009 12:47:00 +0000 (14:47 +0200)]
generator.ml: convert leading TABs to spaces

11 years agosfdisk: guard against buffer overflow
Jim Meyering [Wed, 12 Aug 2009 19:16:30 +0000 (21:16 +0200)]
sfdisk: guard against buffer overflow

* daemon/sfdisk.c (sfdisk): Don't let outrageous "extra_flag"
or "device" strings overflow a fixed-size buffer.

11 years agodo_umount: don't use RESOLVE_DEVICE anymore
Jim Meyering [Wed, 12 Aug 2009 07:49:24 +0000 (09:49 +0200)]
do_umount: don't use RESOLVE_DEVICE anymore

* daemon/mount.c (do_umount): Don't use RESOLVE_DEVICE here,
now that the caller always invokes REQUIRE_ROOT_OR_RESOLVE_DEVICE.

11 years agogenerator.ml: factor out "pr_args n" function
Jim Meyering [Wed, 12 Aug 2009 08:57:03 +0000 (10:57 +0200)]
generator.ml: factor out "pr_args n" function

11 years agogenerator.ml: finish adding Dev_or_Path support
Jim Meyering [Tue, 11 Aug 2009 16:07:17 +0000 (18:07 +0200)]
generator.ml: finish adding Dev_or_Path support

* src/generator.ml: Update all rules to handle Dev_or_Path.
(the above changes to generator.ml are mostly mechanical)
Emit a use of REQUIRE_ROOT_OR_RESOLVE_DEVICE.
* daemon/upload.c (do_download): Remove use of
REQUIRE_ROOT_OR_RESOLVE_DEVICE, now that it's automatically done
in calling code.
* daemon/file.c (do_file): Likewise.

11 years agogenerator.ml: add type: Dev_or_Path
Jim Meyering [Tue, 11 Aug 2009 15:38:05 +0000 (17:38 +0200)]
generator.ml: add type: Dev_or_Path

* src/generator.ml (file, download): Use it.

11 years agogenerator.ml: constify do_mkdtemp
Jim Meyering [Tue, 11 Aug 2009 15:17:08 +0000 (17:17 +0200)]
generator.ml: constify do_mkdtemp

* daemon/dir.c (do_mkdtemp): Rewrite for a "const" parameter.
* src/generator.ml (mkdtemp): Declare parameter to be of type Pathname.

11 years agogenerator.ml: move String/Device decls "down" to definition
Jim Meyering [Tue, 11 Aug 2009 14:17:41 +0000 (16:17 +0200)]
generator.ml: move String/Device decls "down" to definition

11 years agogenerator.ml: use new "Pathname" designation
Jim Meyering [Tue, 11 Aug 2009 13:59:56 +0000 (15:59 +0200)]
generator.ml: use new "Pathname" designation

Nearly every file-related function in daemons/*.c is affected:
Remove this pair of statements from each affected do_* function:
-  NEED_ROOT (return -1);
-  ABS_PATH (dir, return -1);
and change the type of the corresponding parameter to "const char *".
* src/generator.ml: Emit NEED_ROOT just once, even when there are two or
more Pathname args.

11 years agogenerator.ml: new type, "Pathname"
Jim Meyering [Tue, 11 Aug 2009 10:16:51 +0000 (12:16 +0200)]
generator.ml: new type, "Pathname"

* src/generator.ml: Emit NEED_ROOT and ABS_PATH into generated
stubs.c, rather than requiring they be added manually at the start
of each and every do_* function that operates on a "path" parameter.
Update grammar: Pathname is just a String, with the above exception.
Do not update augeas "path" parameters, since they are not file names,
but rather ":"-separated search paths.  Except aug_init, for which
"path" *is* a file name.

11 years agogenerator.ml: emit "const char *" for Device and String params
Jim Meyering [Tue, 11 Aug 2009 09:56:33 +0000 (11:56 +0200)]
generator.ml: emit "const char *" for Device and String params

* src/generator.ml: Emit "const char *", not "char *" for Device and
String params, now that the non-const code is hoisted into the calling
code in stubs.c.

11 years agofix daemon.h's use of NEED_ROOT-in-#define
Jim Meyering [Mon, 10 Aug 2009 21:15:25 +0000 (23:15 +0200)]
fix daemon.h's use of NEED_ROOT-in-#define

11 years agoupdate all NEED_ROOT uses
Jim Meyering [Mon, 10 Aug 2009 21:11:01 +0000 (23:11 +0200)]
update all NEED_ROOT uses

run this command:
  git grep -l -w NEED_ROOT|xargs perl -pi -e \
    's/(NEED_ROOT) \((.*?)\)/$1 (return $2)/'

11 years ago* src/generator.ml: Change all `String "device"' to `Device "device"'.
Jim Meyering [Mon, 10 Aug 2009 21:07:21 +0000 (23:07 +0200)]
* src/generator.ml: Change all `String "device"' to `Device "device"'.

Then update each affected function, removing each uses of RESOLVE_DEVICE,
now that it's generated in caller from stub.c.
* daemon/blockdev.c (call_blockdev): Remove use of RESOLVE_DEVICE.
* daemon/devsparts.c (do_mkfs): Likewise.
* daemon/ext2.c (do_e2fsck_f, do_get_e2label, do_get_e2uuid): Likewise.
(do_resize2fs, do_set_e2label, do_set_e2uuid, do_tune2fs_l): Likewise.
* daemon/fsck.c (do_fsck): Likewise.
* daemon/grub.c (do_grub_install): Likewise.
* daemon/lvm.c (do_lvremove, do_pvcreate, do_pvremove): Likewise.
(do_pvresize): Likewise.
* daemon/mount.c (do_mount_vfs): Likewise.
* daemon/ntfs.c (do_ntfs_3g_probe): Likewise.
* daemon/scrub.c (do_scrub_device): Likewise.
* daemon/sfdisk.c (sfdisk, sfdisk_flag): Likewise.
* daemon/swap.c (do_mkswap, do_mkswap_L, do_mkswap_U): Likewise.
(do_swapoff_device, do_swapon_device): Likewise.
* daemon/zero.c (do_zero): Likewise.
* daemon/zerofree.c (do_zerofree): Likewise.

11 years agoupdate generator to emit each RESOLVE_DEVICE call
Jim Meyering [Mon, 10 Aug 2009 20:50:00 +0000 (22:50 +0200)]
update generator to emit each RESOLVE_DEVICE call

* src/generator.ml: Emit RESOLVE_DEVICE (device, goto done);
just before each Device-enabled do_$FUNCTION.

11 years agos/NEED_ROOT_OR_IS_DEVICE/REQUIRE_ROOT_OR_RESOLVE_DEVICE/
Jim Meyering [Mon, 10 Aug 2009 17:10:14 +0000 (19:10 +0200)]
s/NEED_ROOT_OR_IS_DEVICE/REQUIRE_ROOT_OR_RESOLVE_DEVICE/

11 years agoguestfsd.c: correct s/IS_DEVICE/RESOLVE_DEVICE/ in another comment
Jim Meyering [Mon, 10 Aug 2009 17:08:11 +0000 (19:08 +0200)]
guestfsd.c: correct s/IS_DEVICE/RESOLVE_DEVICE/ in another comment

11 years agomanually adjust ABS_PATH uses for new semantics
Jim Meyering [Mon, 10 Aug 2009 21:13:31 +0000 (23:13 +0200)]
manually adjust ABS_PATH uses for new semantics

* daemon/file.c (do_cat): fix an ABS_PATH use

11 years agoupdate all uses of ABS_PATH
Jim Meyering [Mon, 10 Aug 2009 17:03:36 +0000 (19:03 +0200)]
update all uses of ABS_PATH

run this command:
  git grep -l -w ABS_PATH|xargs perl -pi -e \
    's/(?:ABS_PATH)( \(.*?,) (.*?)\)/ABS_PATH$1 return $2)/'

11 years agopropagate semantic changes to NEED_ROOT, NEED_ROOT_OR_IS_DEVICE
Jim Meyering [Mon, 10 Aug 2009 17:02:12 +0000 (19:02 +0200)]
propagate semantic changes to NEED_ROOT, NEED_ROOT_OR_IS_DEVICE

changing IS_DEVICE semantics leads to changing semantics of
NEED_ROOT_OR_IS_DEVICE and NEED_ROOT, too.
* daemon/daemon.h: Update definitions.

11 years agoconvert the last few, manually
Jim Meyering [Mon, 10 Aug 2009 16:54:51 +0000 (18:54 +0200)]
convert the last few, manually

11 years agochange almost all uses: s/IS_DEVICE/RESOLVE_DEVICE/
Jim Meyering [Mon, 10 Aug 2009 16:51:32 +0000 (18:51 +0200)]
change almost all uses: s/IS_DEVICE/RESOLVE_DEVICE/

Use this command:
  git grep -l -w IS_DEVICE|xargs perl -pi -e \
    's/\b(?:IS_DEVICE)\b( \(.*?,) (.*?)\)/RESOLVE_DEVICE$1 return $2)/'

11 years ago* daemon/daemon.h (RESOLVE_DEVICE): Rename from IS_DEVICE.
Jim Meyering [Mon, 10 Aug 2009 16:49:55 +0000 (18:49 +0200)]
* daemon/daemon.h (RESOLVE_DEVICE): Rename from IS_DEVICE.

Change parameter from "errcode" (which would be returned) to "fail_stmt"
so that a caller can specify e.g., "goto done" upon failure.

11 years agogenerator.ml: define new String-like type: "Device"
Jim Meyering [Mon, 10 Aug 2009 16:17:05 +0000 (18:17 +0200)]
generator.ml: define new String-like type: "Device"

11 years agoDon't assume grub is on a separate boot filesystem
Matthew Booth [Thu, 13 Aug 2009 10:48:27 +0000 (11:48 +0100)]
Don't assume grub is on a separate boot filesystem

Paths in grub.conf are relative to the filesystem containing it. grub parsing
currently assumes that it is on /boot, and will fail if it isn't, for example
because a guest only has a single partition.

This patch makes grub parsing work harder to work out what grub paths are
relative to. Firstly, it looks for a previous detected 'linux-grub' filesystem.
If this isn't found, it tries to work out which filesystem contains
/boot/grub/menu.lst and uses that.

11 years agoadd_drive: Don't use cache=off if not supported by underlying filesystem.
Richard W.M. Jones [Wed, 12 Aug 2009 21:12:20 +0000 (22:12 +0100)]
add_drive: Don't use cache=off if not supported by underlying filesystem.

If you use the guestfs_add_drive function, then currently it
generates a qemu command line element like:

  -drive ...,cache=off,...

This causes qemu to try to open the device with O_DIRECT.
Unfortunately some filesystems don't support this flag, notably tmpfs,
which means you can't use libguestfs in conjunction with tmpfs.  On
some systems /tmp is a tmpfs filesystem.

This patch fixes this so that if the filesystem doesn't support
O_DIRECT, then we omit the cache=off parameter.  This seems reasonable
from a reliability point of view, because if you're using tmpfs then
you probably didn't expect reliability in the case where your system
suddenly powers off.