libguestfs.git
10 years agodaemon: count_strings function returns size_t
Richard Jones [Wed, 2 Jun 2010 11:31:40 +0000 (12:31 +0100)]
daemon: count_strings function returns size_t

10 years agobase64-in: Ignore garbage characters in input.
Richard Jones [Wed, 2 Jun 2010 14:10:38 +0000 (15:10 +0100)]
base64-in: Ignore garbage characters in input.

On RHEL 5 you have to specify the -i option to get the
external 'base64' command to ignore \n characters.  (The
Fedora version seems to ignore these characters anyway).

Add this option so the tests can pass on RHEL 5.

10 years agoresize2fs: Document this command also works with ext4 (thanks Yufang Zhang).
Richard Jones [Wed, 2 Jun 2010 12:27:19 +0000 (13:27 +0100)]
resize2fs: Document this command also works with ext4 (thanks Yufang Zhang).

10 years agofish: help command return error for non-existent commands (RHBZ#597145).
Richard Jones [Tue, 1 Jun 2010 15:27:33 +0000 (16:27 +0100)]
fish: help command return error for non-existent commands (RHBZ#597145).

With this change, the exit status indicates error for non-existent
commands.

$ guestfish -h foo
foo: command not known, use -h to list all commands
$ echo $?
1
$ guestfish help foo
foo: command not known, use -h to list all commands
$ echo $?
1

10 years agodaemon: write-file: Check range of size parameter (RHBZ#597135).
Richard Jones [Tue, 1 Jun 2010 15:18:53 +0000 (16:18 +0100)]
daemon: write-file: Check range of size parameter (RHBZ#597135).

This also adds a regression test.

10 years agodaemon: Limit label lengths (RHBZ#597118).
Richard Jones [Tue, 1 Jun 2010 14:50:14 +0000 (15:50 +0100)]
daemon: Limit label lengths (RHBZ#597118).

10 years agoUpdate BUGS and PO files.
Richard Jones [Wed, 2 Jun 2010 12:36:19 +0000 (13:36 +0100)]
Update BUGS and PO files.

10 years agoFix and deprecate get_e2label and get_e2uuid (RHBZ#597112).
Richard Jones [Tue, 1 Jun 2010 13:04:51 +0000 (14:04 +0100)]
Fix and deprecate get_e2label and get_e2uuid (RHBZ#597112).

Fix these calls (see description in RHBZ#597112), but also
deprecate them since the new calls vfs_label and vfs_uuid can
work on any filesystem type.

This also adds a regression test for the original bug reported
in RHBZ#597112.

10 years agoNew APIs: vfs-label and vfs-uuid return label and uuid for many fs types.
Richard Jones [Tue, 1 Jun 2010 12:57:12 +0000 (13:57 +0100)]
New APIs: vfs-label and vfs-uuid return label and uuid for many fs types.

These APIs generalize the existing 'get-e2label' and 'get-e2uuid'
calls, to provide calls which should be able to get the label
and UUID for most filesystem types.  These use 'blkid' to do the
work.

I have tested that the blkid commands themselves work on RHEL 5.

(Suggested by Yufang Zhang).

10 years agodaemon: Kill blkid cache to improve reliability of blkid commands.
Richard Jones [Tue, 1 Jun 2010 14:27:57 +0000 (15:27 +0100)]
daemon: Kill blkid cache to improve reliability of blkid commands.

By killing the cache file, we make blkid work in situations such
as a just-created filesystem.

10 years agodaemon: Generalize the implementation of vfs-type.
Richard Jones [Tue, 1 Jun 2010 12:39:25 +0000 (13:39 +0100)]
daemon: Generalize the implementation of vfs-type.

Note that there is no change to the semantics of the code.

10 years agotodo: Should generate -N option.
Richard Jones [Fri, 28 May 2010 19:08:01 +0000 (20:08 +0100)]
todo: Should generate -N option.

10 years agotodo: Remove implemented resize functions from TODO file.
Richard Jones [Fri, 28 May 2010 19:05:56 +0000 (20:05 +0100)]
todo: Remove implemented resize functions from TODO file.

10 years agoMake the supermin appliance include local augeas lenses
Matthew Booth [Thu, 27 May 2010 14:47:51 +0000 (15:47 +0100)]
Make the supermin appliance include local augeas lenses

10 years agoRely on new augeas lens for modules.conf and conf.modules
Matthew Booth [Thu, 27 May 2010 14:47:50 +0000 (15:47 +0100)]
Rely on new augeas lens for modules.conf and conf.modules

Latest augeas includes a lens for /etc/modules.conf. If this new lens is
present, the code to force the Modprobe lens to try to match /etc/modules.conf
as well results in /etc/modules.conf not being parsed at all. This results in
modprobe_aliases in virt-inspector output being empty.

This change is equivalent to change cfd28d1140393667913689b7b9bcf21c8bfe592c
from virt-v2v.

An effect of this change is that the Modules_conf augeas lens is now required
for correct operation on guests which use /etc/modules.conf.

Fixes RHBZ#596776

10 years agoUpdates to Spanish translation (RHBZ#596763).
Daniel Cabrera [Thu, 27 May 2010 14:20:37 +0000 (15:20 +0100)]
Updates to Spanish translation (RHBZ#596763).

10 years agoVersion 1.3.17. 1.3.17
Richard Jones [Thu, 27 May 2010 11:03:43 +0000 (12:03 +0100)]
Version 1.3.17.

10 years agoFix documentation for vfs-type to reflect reality.
Richard Jones [Thu, 27 May 2010 09:37:43 +0000 (10:37 +0100)]
Fix documentation for vfs-type to reflect reality.

10 years agoClarify documentation on distro backports in version command.
Richard Jones [Thu, 27 May 2010 09:32:51 +0000 (10:32 +0100)]
Clarify documentation on distro backports in version command.

10 years agoAdd reference to version number documentation to version command.
Richard Jones [Thu, 27 May 2010 09:31:07 +0000 (10:31 +0100)]
Add reference to version number documentation to version command.

10 years agoClarify sparse behaviour of truncate-size command.
Richard Jones [Thu, 27 May 2010 09:25:18 +0000 (10:25 +0100)]
Clarify sparse behaviour of truncate-size command.

10 years agoFix typo in documentation of guestfs_readlinklist.
Richard Jones [Thu, 27 May 2010 09:03:47 +0000 (10:03 +0100)]
Fix typo in documentation of guestfs_readlinklist.

10 years agoFix missing word in docuentation of guestfs_readdir.
Richard Jones [Thu, 27 May 2010 09:01:25 +0000 (10:01 +0100)]
Fix missing word in docuentation of guestfs_readdir.

10 years agoRevise documentation on creating files.
Richard Jones [Thu, 27 May 2010 08:49:28 +0000 (09:49 +0100)]
Revise documentation on creating files.

10 years agoNew API: fallocate64 (replaces fallocate).
Richard Jones [Thu, 27 May 2010 08:48:22 +0000 (09:48 +0100)]
New API: fallocate64 (replaces fallocate).

guestfs_fallocate takes an integer for the length, effectively
limiting it to creating 1GB files.  This new call takes an int64_t
for the length, but is otherwise identical.

10 years agoFix typo in description of echo-daemon command.
Richard Jones [Wed, 26 May 2010 22:42:43 +0000 (23:42 +0100)]
Fix typo in description of echo-daemon command.

10 years agoVersion 1.3.16. 1.3.16
Richard Jones [Tue, 25 May 2010 22:17:58 +0000 (23:17 +0100)]
Version 1.3.16.

10 years agoAdd bash complation script to EXTRA_DIST.
Richard Jones [Tue, 25 May 2010 22:16:23 +0000 (23:16 +0100)]
Add bash complation script to EXTRA_DIST.

10 years agoVersion 1.3.15. 1.3.15
Richard Jones [Tue, 25 May 2010 21:45:45 +0000 (22:45 +0100)]
Version 1.3.15.

10 years agoAdd tests for available-all-groups command.
Richard Jones [Tue, 25 May 2010 21:24:12 +0000 (22:24 +0100)]
Add tests for available-all-groups command.

10 years agofish: First pass at guestfish bash completion script.
Richard Jones [Tue, 25 May 2010 19:13:55 +0000 (20:13 +0100)]
fish: First pass at guestfish bash completion script.

10 years agofish: Don't eat words when completing case-insensitive paths (RHBZ#582993).
Richard Jones [Tue, 25 May 2010 12:54:11 +0000 (13:54 +0100)]
fish: Don't eat words when completing case-insensitive paths (RHBZ#582993).

10 years agofish: Sort returned paths so the list is stable across multiple calls.
Richard Jones [Tue, 25 May 2010 12:52:53 +0000 (13:52 +0100)]
fish: Sort returned paths so the list is stable across multiple calls.

10 years agofish: Document test1.img, test2.img etc used by -N option in FILES section.
Richard Jones [Tue, 25 May 2010 12:52:17 +0000 (13:52 +0100)]
fish: Document test1.img, test2.img etc used by -N option in FILES section.

10 years agofish: Create a separate FILES section in the manpage.
Richard Jones [Tue, 25 May 2010 12:51:58 +0000 (13:51 +0100)]
fish: Create a separate FILES section in the manpage.

10 years agofish: Move 'EXIT CODE' section to a more logical place in the documentation.
Richard Jones [Tue, 25 May 2010 12:41:39 +0000 (13:41 +0100)]
fish: Move 'EXIT CODE' section to a more logical place in the documentation.

10 years agoresize: Refresh the examples in the documentation.
Richard Jones [Tue, 25 May 2010 10:45:23 +0000 (11:45 +0100)]
resize: Refresh the examples in the documentation.

The documentation was previously very intimidating.  Bring some
common, simple examples up to the top of the page in a separate
section.

10 years agofish: Make the read/write warning more prominent.
Richard Jones [Tue, 25 May 2010 10:44:43 +0000 (11:44 +0100)]
fish: Make the read/write warning more prominent.

Follow the example on other manual pages by making the warning
more prominent.

10 years agofish: New command: 'supported'
Richard Jones [Tue, 25 May 2010 10:28:09 +0000 (11:28 +0100)]
fish: New command: 'supported'

This checks all available optional groups and prints out which
ones are supported by the daemon.  Note you must launch the appliance
first.

Example:

><fs> supported
      augeas yes
     inotify yes
 linuxfsuuid yes
linuxmodules yes
 linuxxattrs yes
        lvm2 yes
       mknod yes
      ntfs3g yes
   ntfsprogs yes
    realpath yes
       scrub yes
     selinux yes
          xz yes
    zerofree yes

10 years agoNew API: available-all-groups to return list of all optional groups.
Richard Jones [Tue, 25 May 2010 10:27:49 +0000 (11:27 +0100)]
New API: available-all-groups to return list of all optional groups.

10 years agoperl: Rerun configure if MAX_PROC_NR changes.
Richard Jones [Tue, 25 May 2010 10:25:12 +0000 (11:25 +0100)]
perl: Rerun configure if MAX_PROC_NR changes.

If MAX_PROC_NR changes (because a new API has been added to the
generator) then we need to rerun configure in order to set the
Makefile's ${MAX_PROC_NR} variable, in order to rebuild Makefile.PL.

10 years agoUpdate Polish translations (RHBZ#502533).
Piotr Drąg [Tue, 25 May 2010 08:41:20 +0000 (09:41 +0100)]
Update Polish translations (RHBZ#502533).

10 years agoVersion 1.3.14. 1.3.14
Richard Jones [Mon, 24 May 2010 12:35:31 +0000 (13:35 +0100)]
Version 1.3.14.

10 years agobuild: Remove install_kernel from EXTRA_DIST.
Richard Jones [Mon, 24 May 2010 12:34:33 +0000 (13:34 +0100)]
build: Remove install_kernel from EXTRA_DIST.

This updates commit a34fadf900625f1f7359ecf3ca760820ffa20815,
removing this now non-existent script from EXTRA_DIST.

10 years agobuild: For development releases, print a notice.
Richard Jones [Mon, 24 May 2010 11:09:38 +0000 (12:09 +0100)]
build: For development releases, print a notice.

10 years agoguestfs_version: Correct documentation.
Richard Jones [Sat, 22 May 2010 17:51:57 +0000 (18:51 +0100)]
guestfs_version: Correct documentation.

Remove reference to 'ELF weak linking tricks' and replace
with suggestion to use dl* functions.

10 years agoBuild workaround for Python 2.4.x in RHEL 5.
Richard W.M. Jones [Fri, 21 May 2010 17:20:28 +0000 (18:20 +0100)]
Build workaround for Python 2.4.x in RHEL 5.

See:
http://www.python.org/dev/peps/pep-0353/#conversion-guidelines

10 years agoC99 compatible build fix for RHEL 5.
Richard W.M. Jones [Fri, 21 May 2010 15:14:07 +0000 (16:14 +0100)]
C99 compatible build fix for RHEL 5.

10 years agoNew API: ntfsresize-size to allow shrinking NTFS (RHBZ#585223).
Richard Jones [Fri, 21 May 2010 13:14:59 +0000 (14:14 +0100)]
New API: ntfsresize-size to allow shrinking NTFS (RHBZ#585223).

10 years agoNew API: pvresize-size to allow shrinking PVs (RHBZ#585222).
Richard Jones [Fri, 21 May 2010 13:14:25 +0000 (14:14 +0100)]
New API: pvresize-size to allow shrinking PVs (RHBZ#585222).

10 years agoNew API: resize2fs-size to allow shrinking ext2 filesystems (RHBZ#585221).
Richard Jones [Fri, 21 May 2010 13:13:24 +0000 (14:13 +0100)]
New API: resize2fs-size to allow shrinking ext2 filesystems (RHBZ#585221).

10 years agofish: Allow suffixes on number parameters (eg. 1M)
Richard Jones [Fri, 21 May 2010 12:07:05 +0000 (13:07 +0100)]
fish: Allow suffixes on number parameters (eg. 1M)

This small change uses the gnulib xstrtoll functionality to
enable suffixes on integer parameters in guestfish.  For example:

 truncate-size /file 1G

(previously you would have had to given the full number).

This also applies to the 'alloc' and 'sparse' commands (and
indirectly to the -N option).  The specification for these commands
has changed slightly, in that 'alloc foo 1MB' would now use SI
units, allocating 1000000 bytes instead of a true megabyte.  All
existing uses would use 'alloc foo 1M' which still allocates true
megabytes.

10 years agofish: Fix '-N part' disk partition type sub-option.
Richard Jones [Fri, 21 May 2010 13:51:29 +0000 (14:51 +0100)]
fish: Fix '-N part' disk partition type sub-option.

10 years agoTODO: Suggest including undelete utility.
Richard Jones [Fri, 21 May 2010 10:25:36 +0000 (11:25 +0100)]
TODO: Suggest including undelete utility.

10 years agoFix name of update-bugs script in output file BUGS.
Richard Jones [Fri, 21 May 2010 10:25:19 +0000 (11:25 +0100)]
Fix name of update-bugs script in output file BUGS.

10 years agoubuntu: Use direct udevd method to start udev on Ubuntu.
Richard Jones [Thu, 20 May 2010 17:53:10 +0000 (18:53 +0100)]
ubuntu: Use direct udevd method to start udev on Ubuntu.

On Ubuntu, /etc/init.d/udev is a symlink to an upstart file,
but running that causes the appliance to hang.

Therefore detect if this is a symlink and fall through to the
direct start of udevd.  This shouldn't affect Debian because the
file is not a symlink on standard Debian.

10 years agoubuntu: Remove two FUSE packages from the default list.
Richard Jones [Thu, 20 May 2010 12:54:13 +0000 (13:54 +0100)]
ubuntu: Remove two FUSE packages from the default list.

fuse-utils (a dependency of these) cannot be installed under
debirf because it does something with the system udevd which is
not permitted.  Seems to be a bug either in fakeroot or in the
post install scripts for fuse-utils.

10 years agoubuntu: Ignore packages in packagelist.in which are missing.
Richard Jones [Thu, 20 May 2010 10:04:30 +0000 (11:04 +0100)]
ubuntu: Ignore packages in packagelist.in which are missing.

For distros using 'yum', packages which cannot be found are just
ignored.  This allows us to include for example 'e4fsprogs' on the
list even though that only exists on RHEL 5.

However for Debian-derived distros, missing packages would cause
apt to fail.  This was particularly a problem when building Ubuntu
since it doesn't have as complete a list of packages, and the list
changed a lot between releases.

This commit adds a check first for missing packages, ignoring those
and thus acting more like 'yum'.

10 years agoUbuntu: Use apt-get instead of aptitude when installing guestfsd.
Richard Jones [Mon, 21 Dec 2009 15:52:36 +0000 (15:52 +0000)]
Ubuntu: Use apt-get instead of aptitude when installing guestfsd.

10 years agoUbuntu: Revert install-kernel to debirf default script.
Richard Jones [Mon, 21 Dec 2009 15:50:59 +0000 (15:50 +0000)]
Ubuntu: Revert install-kernel to debirf default script.

10 years agogenerator: Make 'xz' into an optional group.
Richard Jones [Thu, 20 May 2010 09:39:44 +0000 (10:39 +0100)]
generator: Make 'xz' into an optional group.

On Ubuntu <= Karmic, xz-utils was not packaged, and therefore
any xz-related tests would fail.  Thus make this an optional
group so that we can test for this and avoid running the tests
if xz utils are not present.

10 years agogenerator: Check parameters are not NULL (RHBZ#501893).
Richard Jones [Wed, 19 May 2010 11:27:00 +0000 (12:27 +0100)]
generator: Check parameters are not NULL (RHBZ#501893).

This adds additional tests to check that several types of parameter
including String are not NULL when passed to the C functions.
Previously this would cause a segfault inside libguestfs.  With
this change, you get an error message / exception.

Of the possible pointer parameters, only OptString is now permitted
to be NULL.

This change does not affect the Perl bindings.  This is because Perl
XS code was already adding similar checks if you passed undef into
a parameter expecting a string.

10 years agogenerator: Some String parameters should be OptString (RHBZ#501894).
Richard Jones [Wed, 19 May 2010 11:25:03 +0000 (12:25 +0100)]
generator: Some String parameters should be OptString (RHBZ#501894).

I haven't checked the list of functions exhaustively, but
these are the obvious ones.

10 years agofuse: Implement write syscall (RHBZ#592883).
Richard Jones [Tue, 18 May 2010 22:49:43 +0000 (23:49 +0100)]
fuse: Implement write syscall (RHBZ#592883).

10 years agoNew API: Implement pwrite system call (partial fix for RHBZ#592883).
Richard Jones [Tue, 18 May 2010 22:20:30 +0000 (23:20 +0100)]
New API: Implement pwrite system call (partial fix for RHBZ#592883).

10 years agoNew API: write for creating files with fixed content (RHBZ#501889).
Richard Jones [Tue, 18 May 2010 20:51:05 +0000 (21:51 +0100)]
New API: write for creating files with fixed content (RHBZ#501889).

The guestfs_write call can be used to create small files with
arbitrary 8 bit content, including \0 bytes.

This replaces and deprecates write-file, which cannot be modified
to use BufferIn because of an unfortunate choice in the ABI: the
size parameter to write-file, if zero, means that the daemon tries
to calculate the length of the buffer using strlen.  However this
fails if we pass a zero-length buffer using BufferIn because then
the daemon tries to do strlen on a (really) zero length buffer, not
even containing a terminating \0 character, thus segfaulting.

10 years agogenerator: Implement BufferIn parameter type (RHBZ#501889).
Richard Jones [Tue, 18 May 2010 20:47:19 +0000 (21:47 +0100)]
generator: Implement BufferIn parameter type (RHBZ#501889).

The BufferIn argument turns into various things:

 in C      const char *, size_t parameter pair

 in XDR    an opaque<> type (instead of string) which allows \0 chars

 in other bindings
           mostly just a string, since most languages except for C
           permit strings to contain any 8 bit data

10 years agofish: Fix build error if built without readline.
Richard Jones [Thu, 20 May 2010 09:11:18 +0000 (10:11 +0100)]
fish: Fix build error if built without readline.

fish.c:1447: error: 'add_history_line' defined but not used [-Wunused-function]

(Reported by Matt Booth)

10 years agoappliance: Fix /etc/resolv.conf
Richard Jones [Tue, 18 May 2010 22:18:35 +0000 (23:18 +0100)]
appliance: Fix /etc/resolv.conf

Since changing to use link local address
(commit fbf29976b33a69c64dc7847c54454bf2cfa5fde6)
we have included an incorrect resolv.conf file in the appliance
which points to the old (qemu) DNS server.  This commit changes
to use the new DNS server.

10 years agoUpdate BUGS.
Richard Jones [Tue, 18 May 2010 20:54:17 +0000 (21:54 +0100)]
Update BUGS.

10 years agoUpdate Spanish translations (RHBZ#593292).
Daniel Cabrera [Tue, 18 May 2010 13:38:57 +0000 (14:38 +0100)]
Update Spanish translations (RHBZ#593292).

10 years agoappliance: Ignore utempter unreadable binaries (for RHEL 6).
Richard Jones [Tue, 18 May 2010 09:02:02 +0000 (10:02 +0100)]
appliance: Ignore utempter unreadable binaries (for RHEL 6).

10 years agoappliance: Change comment about unreadable binaries.
Richard Jones [Tue, 18 May 2010 09:01:45 +0000 (10:01 +0100)]
appliance: Change comment about unreadable binaries.

10 years agoVersion 1.3.13. 1.3.13
Richard Jones [Sat, 15 May 2010 19:54:26 +0000 (20:54 +0100)]
Version 1.3.13.

10 years agoUpdate BUGS
Richard Jones [Sat, 15 May 2010 12:49:55 +0000 (13:49 +0100)]
Update BUGS

10 years agoUpdate PO files.
Richard Jones [Sat, 15 May 2010 07:44:04 +0000 (08:44 +0100)]
Update PO files.

10 years agoGenerate BUGS file from Red Hat Bugzilla database.
Richard Jones [Sat, 15 May 2010 07:43:02 +0000 (08:43 +0100)]
Generate BUGS file from Red Hat Bugzilla database.

Add a script which generates the 'BUGS' file from Red Hat Bugzilla.
This is run whenever we do 'make dist' and deliberately stored in git.

10 years agovirt-df: Display domains in sorted order.
Richard Jones [Fri, 14 May 2010 18:42:48 +0000 (19:42 +0100)]
virt-df: Display domains in sorted order.

10 years agoUpdated Spanish translations (RHBZ#592360).
Richard Jones [Fri, 14 May 2010 16:41:39 +0000 (17:41 +0100)]
Updated Spanish translations (RHBZ#592360).

10 years agoEnsure ordinary appliance is updated before trying to build supermin appliance.
Richard Jones [Fri, 14 May 2010 14:15:47 +0000 (15:15 +0100)]
Ensure ordinary appliance is updated before trying to build supermin appliance.

10 years agoVersion 1.3.12, update PO files. 1.3.12
Richard Jones [Fri, 14 May 2010 11:38:39 +0000 (12:38 +0100)]
Version 1.3.12, update PO files.

10 years agoUnify supermin appliance building using febootstrap 2.7
Richard Jones [Thu, 13 May 2010 16:07:17 +0000 (17:07 +0100)]
Unify supermin appliance building using febootstrap 2.7

10 years agoImprove errors from tar-in/tgz-in commands (RHBZ#591155 RHBZ#591250).
Richard Jones [Thu, 13 May 2010 08:56:27 +0000 (09:56 +0100)]
Improve errors from tar-in/tgz-in commands (RHBZ#591155 RHBZ#591250).

This commit improves the error messages from the tar-in, tgz-in (etc)
commands by capturing the stderr from the tar command in a file and
sending that back in the error message.

The method used for the error file is primitive, and there is a case
for a more generic error file mechanism, but this will do for now.

Sample error messages after this change:

$ virt-tar -u /tmp/test1.img /tmp/not.tar /
tar_in: tar subcommand failed on directory: /: tar: This does not look like a tar archive
tar: Skipping to next header
tar: Exiting with failure status due to previous errors at /home/rjones/d/libguestfs/tools/virt-tar line 247.

$ virt-tar -u /tmp/test1.img /tmp/test.tar /
tar_in: tar subcommand failed on directory: /: tar: access.log: Cannot open: Read-only file system
tar: Exiting with failure status due to previous errors at /home/rjones/d/libguestfs/tools/virt-tar line 247.

10 years agoCombine common code in daemon/tar.c.
Richard Jones [Thu, 13 May 2010 09:17:48 +0000 (10:17 +0100)]
Combine common code in daemon/tar.c.

This commit shouldn't result in any change in the semantics
of the code.

10 years agoFix FileIn cmds losing synch if both ends send cancel messages (RHBZ#576879).
Richard Jones [Wed, 12 May 2010 18:55:06 +0000 (19:55 +0100)]
Fix FileIn cmds losing synch if both ends send cancel messages (RHBZ#576879).

During a FileIn command (eg. upload, tar-in) if both sides
experience errors, then both sides could send cancel messages,
the result being lost synchronization.

The reason for the lost synch was because the daemon was ignoring
this case and sending an error message back which the library side
(which had cancelled) was not expecting.

Fix this by checking in the daemon for the case where the library
also cancels during daemon cancellation, and not sending an error
messages.

This also includes an enhanced regression test which checks for this
case.

This extends the original fix in
commit 5922d7084d6b43f0a1a15b664c7082dfeaf584d0.

More details can be found here:
https://bugzilla.redhat.com/show_bug.cgi?id=576879#c5

10 years agoguestfish: Fix build error in 'print_shell_quote' function.
Richard Jones [Thu, 13 May 2010 16:05:41 +0000 (17:05 +0100)]
guestfish: Fix build error in 'print_shell_quote' function.

Amend commit 1c6ed48bd3cd471dc so the prototype of
'print_shell_quote' function is correct.

10 years agofish: Fix guestfish -N option when called with unknown image type.
Richard Jones [Wed, 12 May 2010 18:01:29 +0000 (19:01 +0100)]
fish: Fix guestfish -N option when called with unknown image type.

Previously it was falling off the end of the loop if you
called it with an unknown image type.

10 years agoImproved error if virt-inspector cannot find OSes in image (RHBZ#591142).
Richard Jones [Wed, 12 May 2010 17:11:37 +0000 (18:11 +0100)]
Improved error if virt-inspector cannot find OSes in image (RHBZ#591142).

10 years agoFix error message in string-e command (RHBZ#588651).
Richard Jones [Wed, 12 May 2010 15:55:59 +0000 (16:55 +0100)]
Fix error message in string-e command (RHBZ#588651).

10 years agoguestfish -i and virt-inspector work on filenames containing spaces (RHBZ#507810).
Richard Jones [Wed, 12 May 2010 14:58:00 +0000 (15:58 +0100)]
guestfish -i and virt-inspector work on filenames containing spaces (RHBZ#507810).

This commit fixes a long-standing bug which prevented guestfish -i
and virt-inspector from working on disk images which had a space
in the filename (or other unsafe characters).  It works by ensuring
that the strings passed between guestfish -i and virt-inspector are
quoted correctly in both directions.

Note that this commit adds a dependency from virt-inspector to
the perl module String::ShellQuote.  We have previously used this
module in virt-make-fs.

10 years agoAdd version numbers to Perl modules (RHBZ#521674).
Richard Jones [Wed, 12 May 2010 14:01:45 +0000 (15:01 +0100)]
Add version numbers to Perl modules (RHBZ#521674).

Sys::Guestfs now contains a version number which reflects the
ABI that we are compiled against, ie. '0.<MAX_PROC_NR>'.  This has
the beneficial side effect of causing an error if the user tries
to mix versions of the Perl module and the XS code.

Sys::Guestfs::Lib now contains a synthetic version number which
will reflect future changes in that module.

10 years agoUpdate PO files, including extra strings from Perl files.
Richard Jones [Wed, 12 May 2010 13:26:26 +0000 (14:26 +0100)]
Update PO files, including extra strings from Perl files.

10 years agopo: Include strings from Perl programs in the PO files (RHBZ#559963).
Richard Jones [Wed, 12 May 2010 13:24:23 +0000 (14:24 +0100)]
po: Include strings from Perl programs in the PO files (RHBZ#559963).

xgettext will only recognize '*.pl' as being a Perl file (otherwise
it treats it as a C file and does not correctly find any strings
in it).

This commit also fixes two actual bugs that xgettext found in the
strings in our Perl programs.

10 years agopo: Don't generate po/Makevars file and include Perl keywords (RHBZ#559963).
Richard Jones [Wed, 12 May 2010 13:19:50 +0000 (14:19 +0100)]
po: Don't generate po/Makevars file and include Perl keywords (RHBZ#559963).

I don't see a reason to autogenerate po/Makevars, and in the
earlier commit which changed this file to being autogenerated
we accidentally lost the special Perl keywords, copyright notice
and bug reporting address.  Fix all of that.

This partially reverts commit febff9d2a35c4f40abbaf8943146476bdeac671e.

10 years agoReduce imported functions in virt-df to ones which are actually used.
Richard Jones [Wed, 12 May 2010 17:10:58 +0000 (18:10 +0100)]
Reduce imported functions in virt-df to ones which are actually used.

10 years agoNew API: fill-pattern for creating files with predefined patterns.
Richard Jones [Wed, 12 May 2010 16:32:39 +0000 (17:32 +0100)]
New API: fill-pattern for creating files with predefined patterns.

10 years agoRun udev_settle() after swapon/swapoff (RHBZ#516096).
Richard Jones [Wed, 12 May 2010 15:12:07 +0000 (16:12 +0100)]
Run udev_settle() after swapon/swapoff (RHBZ#516096).

10 years agofish: With both '-x' and '-i', pass through '-x' to inferior process.
Richard Jones [Wed, 12 May 2010 14:29:03 +0000 (15:29 +0100)]
fish: With both '-x' and '-i', pass through '-x' to inferior process.

10 years agoVersion 1.3.11. 1.3.11
Richard Jones [Sat, 8 May 2010 19:12:55 +0000 (20:12 +0100)]
Version 1.3.11.

10 years agovirt-rescue: Add extra options.
Richard Jones [Sat, 8 May 2010 18:57:52 +0000 (19:57 +0100)]
virt-rescue: Add extra options.

This commit adds the extra options '--append', '--memsize' and '--selinux'.