10 years agoavailability: Add guestfs_available.
Richard Jones [Fri, 20 Nov 2009 13:06:49 +0000 (13:06 +0000)]
availability: Add guestfs_available.

Start a new API allowing groups of functions to be tested for

There are two reasons for this:

(1) If libguestfs is built with missing dependencies (eg. no Augeas lib)
then the corresponding functions are disabled in the appliance.  Up till
now there has been no way to test for this except to speculatively
issue commands and check for errors.

(2) When we port the daemon to Win32 it is likely that major pieces of
functionality won't be available (eg. LVM support).  This API gives
a way to test for that.

There is no change for existing clients: you still have to check for
errors from individual API calls.

For new clients, you will be able to test for availability of particular

Usage scenario (A): An LVM editing tool which requires
both the LVM API and inotify in order to function at all:

  char *apis[] = { "inotify", "lvm2", NULL };
  r = guestfs_available (g, apis);
  if (r == -1) {
    /* print an error and exit */

Usage scenario (B): A general purpose tool which optionally provides
configuration file editing, but this can be disabled, the result
merely being reduced functionality:

  char *apis[] = { "augeas", NULL };
  r = guestfs_available (g, apis);
  enable_config_edit_menus = r == 0;

10 years agodaemon/Win32: Use gnulib modules for first porting to Win32.
Richard Jones [Fri, 20 Nov 2009 11:48:51 +0000 (11:48 +0000)]
daemon/Win32: Use gnulib modules for first porting to Win32.

10 years agobuild: Add missing dependency>guestfs_protocol.h
Matthew Booth [Fri, 20 Nov 2009 16:48:38 +0000 (16:48 +0000)]
build: Add missing dependency>guestfs_protocol.h

10 years agobuild: correct sed transformation to work also on .git-module-status
Jim Meyering [Fri, 20 Nov 2009 15:25:00 +0000 (16:25 +0100)]
build: correct sed transformation to work also on .git-module-status

My patch was wrong.
I kept the sed transformation the same in the two places,
but it wasn't strict enough to also work on the file contents.
Sorry about that.  This fixes it.

>From 93927cc7b9f63c414e5bfeb7eba393fde3295601 Mon Sep 17 00:00:00 2001
From: Jim Meyering <>
Date: Fri, 20 Nov 2009 16:23:17 +0100
Subject: [PATCH libguestfs] build: correct sed transformation to work also on .git-module-status

* Use a more strict sed transformation so it works also
on the contents of .git-module-status, which has no prefix.
* (_submodule_hash): Use a stricter sed regexp.

10 years agobuild: make update .git-module-status, as it should
Jim Meyering [Fri, 20 Nov 2009 13:30:57 +0000 (14:30 +0100)]
build: make update .git-module-status, as it should

I ran, but then make was always failing like this:

    $ make *** gnulib update required; run ./ first.  Stop.

Here's the fix:

>From f743f32079fea2e8a17c7f5b59305e584c75dba0 Mon Sep 17 00:00:00 2001
From: Jim Meyering <>
Date: Fri, 20 Nov 2009 14:29:55 +0100
Subject: [PATCH libguestfs] build: make update .git-module-status, as it should

* Without this, "make" would always say "gnulib update
required; run ./ first", even after you'd run

10 years agomaint: use EXIT_* symbol (not constant, 2) to indicate key/path not found
Jim Meyering [Fri, 20 Nov 2009 11:18:06 +0000 (12:18 +0100)]
maint: use EXIT_* symbol (not constant, 2) to indicate key/path not found

* hivex/hivexget.c (EXIT_NOT_FOUND): Define.
(main): Use exit (EXIT_NOT_FOUND), not "exit (2)".

10 years agomaint: use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1 in "usage", too
Jim Meyering [Fri, 20 Nov 2009 11:15:14 +0000 (12:15 +0100)]
maint: use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1 in "usage", too

Convert by running these commands:
perl -pi -e 's/\b(usage ?)\(1\)/$1(EXIT_FAILURE)/' \
  fish/fish.c fuse/guestmount.c
perl -pi -e 's/\b(usage ?)\(0\)/$1(EXIT_SUCCESS)/' \
  fish/fish.c fuse/guestmount.c
* fish/fish.c (main): Replace 0/1 with EXIT_SUCCESS/EXIT_FAILURE.
* fuse/guestmount.c (main): Likewise.

10 years agomaint: use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1 to exit
Jim Meyering [Fri, 20 Nov 2009 11:09:42 +0000 (12:09 +0100)]
maint: use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1 to exit

Convert all uses automatically, via these two commands:
git grep -l '\<exit *(1)' \
  | grep -vEf .x-sc_prohibit_magic_number_exit \
  | xargs --no-run-if-empty \
    perl -pi -e 's/\b(exit ?)\(1\)/$1(EXIT_FAILURE)/'
git grep -l '\<exit *(0)' \
  | grep -vEf .x-sc_prohibit_magic_number_exit \
  | xargs --no-run-if-empty \
  perl -pi -e 's/\b(exit ?)\(0\)/$1(EXIT_SUCCESS)/'
* .x-sc_prohibit_magic_number_exit: New file.

Edit (RWMJ): Don't change Java code.

10 years agomaint: remove unnecessary include of openat.h
Jim Meyering [Fri, 20 Nov 2009 10:50:54 +0000 (11:50 +0100)]
maint: remove unnecessary include of openat.h

* daemon/realpath.c: Don't include "openat.h".  not used.

10 years agobuild: update gnulib submodule to latest
Richard Jones [Fri, 20 Nov 2009 10:44:38 +0000 (10:44 +0000)]
build: update gnulib submodule to latest

10 years agodaemon/gnulib: Include glob module.
Richard Jones [Fri, 20 Nov 2009 10:43:45 +0000 (10:43 +0000)]
daemon/gnulib: Include glob module.

10 years agodaemon/Win32: Don't include missing headers.
Richard Jones [Fri, 20 Nov 2009 10:41:07 +0000 (10:41 +0000)]
daemon/Win32: Don't include missing headers.

This is a partial fix for code in guestfsd.c where many of these
header files are missing on Win32.

10 years agodaemon/Win32: make some functions and fields optional.
Richard Jones [Fri, 20 Nov 2009 10:38:07 +0000 (10:38 +0000)]
daemon/Win32: make some functions and fields optional.

inotify: Make this optional on platforms that don't have this interface.

mknod, mkfifo etc.: Make these optional on non-Unix platforms.

readdir: If d_type field is missing on the platform, set the corresponding
field to 'u'.

stat: st_blocks and st_blksize are missing on non-Unix platforms, so
set these fields to -1 in the corresponding structures.

10 years agodaemon/Win32: NAME_MAX does not exist on Windows, use FILENAME_MAX instead.
Richard Jones [Fri, 20 Nov 2009 10:36:59 +0000 (10:36 +0000)]
daemon/Win32: NAME_MAX does not exist on Windows, use FILENAME_MAX instead.

10 years agodaemon: Missing #includes revealed by cross-compiling.
Richard Jones [Fri, 20 Nov 2009 10:36:21 +0000 (10:36 +0000)]
daemon: Missing #includes revealed by cross-compiling.

10 years agodaemon/Win32: Ignore mingw32-config.cache.
Richard Jones [Fri, 20 Nov 2009 10:33:27 +0000 (10:33 +0000)]
daemon/Win32: Ignore mingw32-config.cache.

The Fedora Windows cross-compiler 'mingw32-configure' script always
uses a configure cache.  Ignore that file.

10 years agogenerator: open Unix module by default.
Richard Jones [Thu, 19 Nov 2009 17:01:53 +0000 (17:01 +0000)]
generator: open Unix module by default.


  open Unix

at the top of the generator, which means that we don't need to
prefix any '' symbols (we can just use 'foo' instead).

Unfortunately the Unix module shadows one symbol in Pervasives
(the Pervasives module is opened by default in OCaml code).  That
symbol is 'stdout'.  So we replace this with 'Pervasives.stdout'
in two places.  Still a net reduction in code size.

10 years agosyntax-check: Fix tab-vs-space issue in the generator.
Richard Jones [Thu, 19 Nov 2009 16:59:56 +0000 (16:59 +0000)]
syntax-check: Fix tab-vs-space issue in the generator.

10 years agoUpdate PO files.
Richard Jones [Thu, 19 Nov 2009 16:50:19 +0000 (16:50 +0000)]
Update PO files.

10 years agoUpdate TODO file.
Richard Jones [Thu, 19 Nov 2009 16:50:04 +0000 (16:50 +0000)]
Update TODO file.

10 years agobuild: Fix parallel build of haskell bindings
Matthew Booth [Thu, 19 Nov 2009 16:10:01 +0000 (16:10 +0000)]
build: Fix parallel build of haskell bindings

ghc isn't clever enough not to stomp on itself when building dependencies. This
change makes the 1 dependency explicit.

It also adds a dependency on src/

10 years agobuild: Fix inter-directory dependencies
Matthew Booth [Thu, 19 Nov 2009 16:10:00 +0000 (16:10 +0000)]
build: Fix inter-directory dependencies

This change adds an explicit dependency on for every file it
generates, except java files. Java is left for another time because it's
considerably trickier.

It also adds a build rule for src/ so it can be rebuilt as required
from other directories.

It does this by creating a top level make file,, which can be
included from sub-directories. sub-directories need to define 'generator_built'
to include local files which are built by, and they will be updated

This fixes parallel make, and will automatically re-create generated files when
make is run from any directory.

It also fixes the problem which efad4f53 was targetting. Specifically,
src/guestfs_protocol.(c|h) had an erroneous dependency on stamp-generator, and
therefore, despite not being directly created by it. This caused
them to be recreated every time ran rather than only when
src/guestfs_protocol.x was updated, which cascaded into a daemon and therefore
appliance update.

This patch also changes the contents of the distribution tarball by including
files created by rpcgen.

10 years agogenerator: Acquire lock to prevent two parallel runs of the generator.
Richard Jones [Thu, 19 Nov 2009 13:48:59 +0000 (13:48 +0000)]
generator: Acquire lock to prevent two parallel runs of the generator.

This commit acquires a lock on a file to prevent two parallel runs of
the generator from stomping on each other.  The second run will wait
for the first to complete before starting.

The lock is acquired on the "HACKING" file because it's convenient --
we are already checking this file exists to make sure that we don't
start off in the wrong directory.

Tested by adding some artificial sleeps in the code to observe
locking behaviour between two parallel runs.

10 years agosyntax-check: expand TABs in
Jim Meyering [Thu, 19 Nov 2009 10:41:50 +0000 (11:41 +0100)]
syntax-check: expand TABs in

Jim Meyering wrote:
>>From 6f128e90afb055f9899011c4a592eb289e678936 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <>
> Date: Thu, 19 Nov 2009 11:39:10 +0100
> Subject: [PATCH libguestfs] syntax-check: expand TABs in
> * src/ Expand leading TABs to spaces.

That was incomplete.
Please use the following instead.
With it, now, "make syntax-check" now passes once again.

>From 716a30d0b692972aac8fbea1fb7ad3318ab3a0d8 Mon Sep 17 00:00:00 2001
From: Jim Meyering <>
Date: Thu, 19 Nov 2009 11:39:10 +0100
Subject: [PATCH libguestfs] syntax-check: expand leading TABs

* src/ Expand leading TABs to spaces.
* fuse/ Likewise.

10 years agosyntax-check: exempt *.pod from no-trailing-blank prohibition
Jim Meyering [Thu, 19 Nov 2009 10:37:13 +0000 (11:37 +0100)]
syntax-check: exempt *.pod from no-trailing-blank prohibition

* .x-sc_trailing_blank: Exempt *.pod.

10 years agoBUILT_SOURCES now depends on running the generator.
Richard Jones [Wed, 18 Nov 2009 17:41:41 +0000 (17:41 +0000)]
BUILT_SOURCES now depends on running the generator.

This completely reverts commit efad4f53923dcca94613e193d6383bd032e70498.

10 years agodaemon/RHEL: Choose correct udev settle script.
Richard Jones [Wed, 18 Nov 2009 16:02:53 +0000 (16:02 +0000)]
daemon/RHEL: Choose correct udev settle script.

On RHEL/CentOS 5.4, udevadm settle command does not work.  This didn't
affect us before, but now that we're using parted for partitioning, we
*do* need to wait for udev to settle (because parted isn't waiting for
this, unlike sfdisk).

This commit chooses the correct program to run.

10 years agofuse/RHEL: Don't require UTIME_{NOW,OMIT} to be defined.
Richard Jones [Wed, 18 Nov 2009 16:01:23 +0000 (16:01 +0000)]
fuse/RHEL: Don't require UTIME_{NOW,OMIT} to be defined.

These macros don't exist on RHEL/CentOS 5.4.  If the feature
is missing then just don't implement it in the FUSE layer.

10 years agoappliance: Print uptime.
Richard Jones [Wed, 18 Nov 2009 17:31:08 +0000 (17:31 +0000)]
appliance: Print uptime.

Print the uptime just before the init script runs the daemon, so we
have a good idea of how long the kernel boot + init script takes to run.

10 years agorecipes: Fix git URL. 1.0.79
Richard Jones [Wed, 18 Nov 2009 14:11:25 +0000 (14:11 +0000)]
recipes: Fix git URL.

10 years agoPrepare for version 1.0.79.
Richard Jones [Wed, 18 Nov 2009 13:40:32 +0000 (13:40 +0000)]
Prepare for version 1.0.79.

10 years agofuse: Add to EXTRA_DIST.
Richard Jones [Wed, 18 Nov 2009 13:40:04 +0000 (13:40 +0000)]
fuse: Add to EXTRA_DIST.

10 years agogenerator: Fix API of functions that return RBufferOut
Richard Jones [Wed, 18 Nov 2009 10:37:10 +0000 (10:37 +0000)]
generator: Fix API of functions that return RBufferOut

(NB: The API / ABI doesn't actually change here - it's just made much
simpler to use).

The API for RBufferOut functions was unexpectedly hard to use in the
case where a zero-length buffer might be returned.  For discussion on
this see:

This commit ensures that in the zero-length buffer case, the return
value is never NULL.  Thus code is now able to just check if the return
value == NULL to indicate an error, which is simpler for all concerned.

The implementation of this is, however, more complex because we have
to be careful about this case inside both the daemon and the library
code, which is what this commit does.

This has passed a full round of tests.

10 years agofuse: Add tests for guestmount.
Richard Jones [Tue, 17 Nov 2009 17:03:31 +0000 (17:03 +0000)]
fuse: Add tests for guestmount.

This script contains non-exhaustive tests for the system calls
implemented by guestmount.

10 years agofuse: Fix read for empty files.
Richard Jones [Tue, 17 Nov 2009 17:02:45 +0000 (17:02 +0000)]
fuse: Fix read for empty files.

Error handling for the guestfs_pread call was incorrect, which
meant that empty files could produce spurious error messages.

10 years agofish: Improve output of guestfish -h cmd
Richard Jones [Tue, 17 Nov 2009 20:00:17 +0000 (20:00 +0000)]
fish: Improve output of guestfish -h cmd

Display this output like a short manual page.

Don't put <..> around the parameters to the command.

10 years agoNew API call: fill - fill a file with octets
Richard Jones [Tue, 17 Nov 2009 19:51:29 +0000 (19:51 +0000)]
New API call: fill - fill a file with octets

10 years agofuse: Fix cache invalidation in rename operation.
Richard Jones [Tue, 17 Nov 2009 17:01:19 +0000 (17:01 +0000)]
fuse: Fix cache invalidation in rename operation.

We need to invalidate both parameters, otherwise the old (moved)
file can appear that it still exists after the move.

10 years agofuse: Fix hard link creation.
Richard Jones [Tue, 17 Nov 2009 17:02:15 +0000 (17:02 +0000)]
fuse: Fix hard link creation.

The parameters were swapped.  We also need to invalidate the
cache for both parameters.

10 years agofuse: Fix symlink creation (RHBZ#538069).
Richard Jones [Tue, 17 Nov 2009 16:59:52 +0000 (16:59 +0000)]
fuse: Fix symlink creation (RHBZ#538069).

The parameters were swapped, preventing symlinks from being created.

10 years agovirt-df: Ignore domains which have ID 0.
Richard Jones [Tue, 17 Nov 2009 14:21:54 +0000 (14:21 +0000)]
virt-df: Ignore domains which have ID 0.

This is the remainder of the fix for RHBZ#538041.  Domains
which have ID 0 are special domains.  libvirt defines it as
the "control plane OS".  Only Xen and HyperV have this
behaviour, and in both cases we should ignore those domains
for the purposes of virt-df (user can just run "df" if they
need that information for the dom0).

10 years agovirt-df: Turn errors into warnings when listing all domains.
Richard Jones [Tue, 17 Nov 2009 14:09:58 +0000 (14:09 +0000)]
virt-df: Turn errors into warnings when listing all domains.

This is a partial fix for RHBZ#538041.  When listing all domains,
don't die just because one domain fails, but keep trying for the

10 years agoDocs: copyediting
Richard W.M. Jones [Fri, 13 Nov 2009 22:23:08 +0000 (22:23 +0000)]
Docs: copyediting

10 years agoDocs: Add documentation about other language bindings to API overview.
Richard W.M. Jones [Fri, 13 Nov 2009 16:36:04 +0000 (16:36 +0000)]
Docs: Add documentation about other language bindings to API overview.

10 years agoDocs: line folding in example.
Richard W.M. Jones [Fri, 13 Nov 2009 16:35:51 +0000 (16:35 +0000)]
Docs: line folding in example.

10 years agoDocs: group preformatted sections of text together.
Richard W.M. Jones [Fri, 13 Nov 2009 15:57:32 +0000 (15:57 +0000)]
Docs: group preformatted sections of text together.

10 years agoDocs typo: limited -> limits
Richard W.M. Jones [Fri, 13 Nov 2009 15:09:10 +0000 (15:09 +0000)]
Docs typo: limited -> limits

10 years agoDocs: Add section on using multiple threads.
Richard W.M. Jones [Fri, 13 Nov 2009 14:47:32 +0000 (14:47 +0000)]
Docs: Add section on using multiple threads.

This section was missing from the previous documentation.

10 years agoDocs: Add/extend API overview.
Richard W.M. Jones [Fri, 13 Nov 2009 14:13:31 +0000 (14:13 +0000)]
Docs: Add/extend API overview.

10 years agoDocs: Remove incorrect statement from man page.
Richard W.M. Jones [Fri, 13 Nov 2009 12:15:09 +0000 (12:15 +0000)]
Docs: Remove incorrect statement from man page.

The low-level event-based API never existed so this statement
in the man page is wrong.  If you want an asynchronous API, use

10 years agobuild: revive the ocaml package tests
Jim Meyering [Thu, 12 Nov 2009 10:34:08 +0000 (11:34 +0100)]
build: revive the ocaml package tests

* Generalize the ocaml-package-existence test.
Remove the git-related part of the old test.

10 years agoGenerate guestfs_protocol.x when stamp-generator updates
Matthew Booth [Wed, 11 Nov 2009 13:50:24 +0000 (13:50 +0000)]
Generate guestfs_protocol.x when stamp-generator updates

This partially reverts efad4f53923dcca94613e193d6383bd032e70498.
guestfs_protocol.x wasn't being generated when building from a clean checkout.

10 years Remove test for ocaml etc from this script.
Richard Jones [Wed, 11 Nov 2009 13:40:04 +0000 (13:40 +0000)] Remove test for ocaml etc from this script.

This test seems to cause a lot of trouble.  We need to go back to
the drawing-board on this one.

10 years agoSet cpio blocksize to 64K.
Richard Jones [Wed, 11 Nov 2009 10:55:26 +0000 (10:55 +0000)]
Set cpio blocksize to 64K.


10 years agoDebian: don't depend on gfs-tools since these have depsolving problems.
Richard Jones [Tue, 10 Nov 2009 19:12:46 +0000 (19:12 +0000)]
Debian: don't depend on gfs-tools since these have depsolving problems.

10 years agoUpdate PO files for release. 1.0.78
Richard Jones [Tue, 10 Nov 2009 18:45:13 +0000 (18:45 +0000)]
Update PO files for release.

10 years agoCheck for ocaml-xml-light-devel (xml-light.cmxa)
Richard Jones [Tue, 10 Nov 2009 18:38:54 +0000 (18:38 +0000)]
Check for ocaml-xml-light-devel (xml-light.cmxa)

Also unquote $pkg since OCaml package names can never contain
spaces or other unfriendly characters.

10 years agoPrepare for version 1.0.78
Richard Jones [Tue, 10 Nov 2009 18:23:52 +0000 (18:23 +0000)]
Prepare for version 1.0.78

10 years agotell "make syntax-check" that examples/to-xml.c is exempt from some tests
Jim Meyering [Tue, 10 Nov 2009 17:49:42 +0000 (18:49 +0100)]
tell "make syntax-check" that examples/to-xml.c is exempt from some tests

* .x-sc_prohibit_strcmp: Exempt examples/to-xml.c.
* .x-sc_prohibit_strcmp_and_strncmp: Likewise.

10 years agoexamples: Don't use STREQ etc in the to-xml.c example.
Richard Jones [Tue, 10 Nov 2009 17:09:54 +0000 (17:09 +0000)]
examples: Don't use STREQ etc in the to-xml.c example.

10 years agoDon't export STREQ and friends in <guestfs.h>
Richard Jones [Tue, 10 Nov 2009 17:09:12 +0000 (17:09 +0000)]
Don't export STREQ and friends in <guestfs.h>

Move these to private header file(s) and other places as required
since these aren't part of the public API.

10 years agoFix problems found by 'make syntax check'
Richard Jones [Tue, 10 Nov 2009 16:46:31 +0000 (16:46 +0000)]
Fix problems found by 'make syntax check'

10 years agoPrint timestamped messages during appliance launch.
Richard Jones [Mon, 9 Nov 2009 14:42:55 +0000 (14:42 +0000)]
Print timestamped messages during appliance launch.

In verbose mode, print timestamped messages during guestfs_launch
so we can see how long each step takes.

10 years agoRecord time of guest launch.
Richard Jones [Mon, 9 Nov 2009 14:16:21 +0000 (14:16 +0000)]
Record time of guest launch.

The guest handle field start_t was previously used (when we
had the wait_ready call), but had fallen into disuse.  Note
that it could never be accessed through the API.

Rename this field as launch_t, convert it to a timeval, and
use it to measure the time since guestfs_launch was called
so that we can start profiling guest launch.

10 years agoappliance: Prefix kernel messages with timestamp.
Richard Jones [Mon, 9 Nov 2009 14:15:43 +0000 (14:15 +0000)]
appliance: Prefix kernel messages with timestamp.

10 years agoGeneric partition creation interface.
Richard Jones [Wed, 4 Nov 2009 23:15:26 +0000 (23:15 +0000)]
Generic partition creation interface.

This commit introduces a generic partition creation interface
which should be future-proof and extensible, and partially
replaces the old sfdisk-based interface.

The implementation is based on parted but is hopefully not too
dependent on the particulars of parted.

The following new calls are introduced:

    Initialize a disk with a partition table.  Unlike the sfdisk-
    based interface, we also support GPT and other partition
    types, which is essential to scale to devices larger than 2TB.

  guestfs_part_add: Add a partition to an existing disk.

    Convenience function which combines part_init & part_add,
    creating a single partition that covers the whole disk.

    Set various aspects of existing partitions.

    List partitions on a device.  This returns a programming-friendly
    list of partition structs (in contrast to sfdisk-l which cannot
    be parsed).

    Return the partition table type, eg. "msdos" or "gpt".

The following calls are planned, but not added currently:


10 years agoAdd ata_piix to kernel module whitelist (RHBZ#533886).
Richard Jones [Tue, 10 Nov 2009 11:41:39 +0000 (11:41 +0000)]
Add ata_piix to kernel module whitelist (RHBZ#533886).

10 years agoFix compilation if readline library is not present.
Richard Jones [Tue, 10 Nov 2009 12:34:27 +0000 (12:34 +0000)]
Fix compilation if readline library is not present.

10 years agoFix compilation when Augeas is not present.
Richard Jones [Tue, 10 Nov 2009 12:10:05 +0000 (12:10 +0000)]
Fix compilation when Augeas is not present.

It would complain that NEED_AUG macro was defined but not used.

10 years agoavoid "syntax-check" failure: hide cast of argument to free
Jim Meyering [Mon, 9 Nov 2009 14:06:36 +0000 (15:06 +0100)]
avoid "syntax-check" failure: hide cast of argument to free

* fuse/guestmount.c (fg_readlink): Perform cast in a
 separate statement to hide it from "make syntax-check".

10 years agobuild: die early if we lack ocaml, ocamlfind or ocaml-xml-light
Jim Meyering [Tue, 10 Nov 2009 13:31:42 +0000 (14:31 +0100)]
build: die early if we lack ocaml, ocamlfind or ocaml-xml-light

* Ensure that we fail very early when not building
from a tarball and when one of those is not installed.

10 years agotests: enable strcmp-related syntax-check tests
Jim Meyering [Mon, 9 Nov 2009 14:05:23 +0000 (15:05 +0100)]
tests: enable strcmp-related syntax-check tests

* (local-checks-to-skip): Don't skip these checks:
sc_prohibit_strcmp_and_strncmp, sc_prohibit_strcmp.

10 years agochange strncasecmp() == 0 to STRCASEEQLEN()
Jim Meyering [Mon, 9 Nov 2009 21:33:54 +0000 (22:33 +0100)]
change strncasecmp() == 0 to STRCASEEQLEN()

git grep -l 'strncasecmp *([^=]*== *0'|xargs \
  perl -pi -e 's/\bstrncasecmp( *\(.*?\)) *== *0\b/STRCASEEQLEN$1/g'

10 years agochange strncasecmp() == 0 to STRCASENEQLEN()
Jim Meyering [Mon, 9 Nov 2009 21:33:36 +0000 (22:33 +0100)]
change strncasecmp() == 0 to STRCASENEQLEN()

git grep -l 'strncasecmp *([^=]*!= *0'|xargs \
  perl -pi -e 's/\bstrncasecmp( *\(.*?\)) *!= *0\b/STRCASENEQLEN$1/g'

10 years agouse STREQ, not strcmp: part 2
Jim Meyering [Mon, 9 Nov 2009 14:03:01 +0000 (15:03 +0100)]
use STREQ, not strcmp: part 2

git grep -l 'strcmp *([^=]*!= *0'|xargs \
  perl -pi -e 's/\bstrcmp( *\(.*?\)) *!= *0\b/STRNEQ$1/g'

10 years agouse STREQ, not strcmp: part 1
Jim Meyering [Mon, 9 Nov 2009 13:30:11 +0000 (14:30 +0100)]
use STREQ, not strcmp: part 1

git grep -l 'strcmp *([^=]*== *0'|xargs \
  perl -pi -e 's/\bstrcmp( *\(.*?\)) *== *0/STREQ$1/g'

10 years agochange strncmp() == 0 to STREQLEN()
Jim Meyering [Mon, 9 Nov 2009 13:26:21 +0000 (14:26 +0100)]
change strncmp() == 0 to STREQLEN()

git grep -l 'strncmp *([^=]*== *0'|xargs \
  perl -pi -e 's/\bstrncmp( *\(.*?\)) *== *0\b/STREQLEN$1/g'

10 years agochange strncmp(...) != 0 to STRNEQLEN(...)
Jim Meyering [Mon, 9 Nov 2009 13:21:46 +0000 (14:21 +0100)]
change strncmp(...) != 0 to STRNEQLEN(...)

git grep -l 'strncmp *([^=]*!= *0'|xargs \
  perl -pi -e 's/\bstrncmp( *\(.*?\)) *!= *0/STRNEQLEN$1/g'

10 years agoconvert strcasecmp(...) != 0 to STRCASENEQ(...)
Jim Meyering [Mon, 9 Nov 2009 13:06:37 +0000 (14:06 +0100)]
convert strcasecmp(...) != 0 to STRCASENEQ(...)

git grep -E -l 'strcasecmp *\(.*!= ?0\b'|xargs \
  perl -pi -e 's/\bstrcasecmp( ?\(.*?\)) != 0/STRCASENEQ$1/g'

10 years agoconvert uses of strcasecmp to STRCASEEQ
Jim Meyering [Mon, 9 Nov 2009 12:58:42 +0000 (13:58 +0100)]
convert uses of strcasecmp to STRCASEEQ

git grep -l 'strcasecmp *([^=]*== *0'| xargs \
  perl -pi -e 's/\bstrcasecmp( *\(.*?\)) *== *0/STRCASEEQ$1/'

10 years agodefine STREQ, STRNEQ, STREQLEN, STRCASEQ, etc.
Jim Meyering [Mon, 9 Nov 2009 18:50:22 +0000 (19:50 +0100)]

* src/guestfs.h: Define STREQ and company.
* daemon/daemon.h: Likewise.
* hivex/hivex.h: Likewise.

10 years agoindent with spaces, not TABs
Jim Meyering [Mon, 9 Nov 2009 14:14:53 +0000 (15:14 +0100)]
indent with spaces, not TABs

* HACKING: Expand indentation TABs.
* Likewise.
* daemon/daemon.h: Likewise.
* daemon/guestfsd.c: Likewise.
* fuse/guestmount.c: Likewise.
* hivex/LICENSE: Likewise.
* src/ Likewise.
* tools/virt-win-reg: Likewise.

10 years agofix doc typo
Jim Meyering [Mon, 9 Nov 2009 14:09:35 +0000 (15:09 +0100)]
fix doc typo

* fuse/guestmount.pod: Avoid "the the".

10 years agoplacate 'make syntax-check'
Jim Meyering [Mon, 9 Nov 2009 14:08:09 +0000 (15:08 +0100)]
placate 'make syntax-check'

* hivex/hivex.c: Remove unused "#include <assert.h>".

10 years agoavoid syntax-check warning about isdigit use in example program
Jim Meyering [Mon, 9 Nov 2009 17:01:48 +0000 (18:01 +0100)]
avoid syntax-check warning about isdigit use in example program

* .x-sc_avoid_ctype_macros: New file.

10 years agoappliance: Enhance mkfs to support many more filesystem types.
Richard Jones [Sun, 8 Nov 2009 11:57:02 +0000 (11:57 +0000)]
appliance: Enhance mkfs to support many more filesystem types.

This fixes support for NTFS, and adds support for:
 - reiserfs
 - btrfs
 - GFS and GFS2
 - JFS
 - HFS and HFS+
 - OCFS2 (disabled)

We don't enable OCFS2 by default, because it pulls in about
140 extra packages into the appliance.

GFS & GFS2 default to single node (no lock manager etc).

10 years agoFix prototype of commandv to match prototype of commandrv.
Richard Jones [Sun, 8 Nov 2009 11:55:38 +0000 (11:55 +0000)]
Fix prototype of commandv to match prototype of commandrv.

10 years agodaemon: Always reflect command stderr to stderr when debugging.
Richard W.M. Jones [Fri, 6 Nov 2009 17:27:02 +0000 (17:27 +0000)]
daemon: Always reflect command stderr to stderr when debugging.

When debugging (ie. LIBGUESTFS_DEBUG=1 & verbose flag set in daemon)
always reflect any stderr output from commands that we run to
stderr of the daemon, so it is visible.

Previously if stderror == NULL in command*, stderr output was
just eaten and discarded which meant useful error messages could
be lost.

10 years agodaemon: Add flags argument to command*() functions.
Richard W.M. Jones [Fri, 6 Nov 2009 13:19:26 +0000 (13:19 +0000)]
daemon: Add flags argument to command*() functions.

This adds new variations of the command*() functions which
take a 'flags' argument.  Currently the only flag available
is defined as follows:

 COMMAND_FLAG_FOLD_STDOUT_ON_STDERR: For broken external commands
 that send error messages to stdout (hello, parted) but that don't
 have any useful stdout information, use this flag to capture the
 error messages in the *stderror buffer.  If using this flag,
 you should pass stdoutput as NULL because nothing could ever be
 captured in that buffer.

This patch also adds some documentation for command*()

10 years agohaskell: Disambiguate truncate symbol.
Richard Jones [Mon, 9 Nov 2009 11:03:25 +0000 (11:03 +0000)]
haskell: Disambiguate truncate symbol.

This is a hack, but GHC doesn't like it if we have a symbol
with the same name as one in the Haskell Prelude.  Therefore
we much hide the corresponding symbol in the Prelude when
building this module.

10 years agoocaml: Update dependencies file.
Richard Jones [Sun, 8 Nov 2009 11:57:54 +0000 (11:57 +0000)]
ocaml: Update dependencies file.

10 years agoocaml: Sort the dependencies so they are stable between machines.
Richard W.M. Jones [Fri, 6 Nov 2009 12:32:57 +0000 (12:32 +0000)]
ocaml: Sort the dependencies so they are stable between machines.

10 years agoocaml: General improvements to generated code.
Richard W.M. Jones [Fri, 6 Nov 2009 10:48:37 +0000 (10:48 +0000)]
ocaml: General improvements to generated code.

10 years agoFixes for compiling on 32 bit.
Richard W.M. Jones [Fri, 6 Nov 2009 09:14:31 +0000 (09:14 +0000)]
Fixes for compiling on 32 bit.

10 years agoDon't update appliance after running generator.
Richard Jones [Thu, 5 Nov 2009 10:03:59 +0000 (10:03 +0000)]
Don't update appliance after running generator.

I'm not sure why these dependencies exist, but they cause the
appliance to be updated every time the generator runs, which
appears to be unnecessary.

10 years agoappliance: Add xfsprogs to list of packages
Richard Jones [Thu, 5 Nov 2009 13:13:21 +0000 (13:13 +0000)]
appliance: Add xfsprogs to list of packages

10 years agofish: Allow <nn>P and <nn>E for petabyte and exabyte allocations.
Richard Jones [Wed, 4 Nov 2009 21:51:35 +0000 (21:51 +0000)]
fish: Allow <nn>P and <nn>E for petabyte and exabyte allocations.

10 years agofish: Allow <nn>T for terabyte allocations.
Richard Jones [Wed, 4 Nov 2009 18:03:58 +0000 (18:03 +0000)]
fish: Allow <nn>T for terabyte allocations.

10 years agofish: New command 'sparse', like 'alloc' but to generate sparse files.
Richard Jones [Wed, 4 Nov 2009 17:42:03 +0000 (17:42 +0000)]
fish: New command 'sparse', like 'alloc' but to generate sparse files.

With sparse you can make sparse files, which is fun because you
can experiment with really large devices:

  ><fs> sparse /tmp/test.img 100G
  ><fs> run
  ><fs> sfdiskM /dev/vda ,
  ><fs> mkfs ext2 /dev/vda1    # very long pause here ...
  ><fs> mount /dev/vda1 /

To see the real (ie. allocated) size of the sparse file, use the du
command, eg:

  ><fs> !du -h /tmp/test.img
  1.6G -rw-rw-r-- 1 rjones rjones 100G 2009-11-04 17:40 /tmp/test.img

10 years agodaemon: Build daemon with AC_SYS_LARGEFILE.
Richard Jones [Wed, 4 Nov 2009 17:23:11 +0000 (17:23 +0000)]
daemon: Build daemon with AC_SYS_LARGEFILE.