11 years agohivex: Small updates to the documentation.
Richard Jones [Thu, 14 Jan 2010 13:26:46 +0000 (13:26 +0000)]
hivex: Small updates to the documentation.

11 years agoFix generation of HTML documentation for website.
Richard Jones [Wed, 13 Jan 2010 14:55:04 +0000 (14:55 +0000)]
Fix generation of HTML documentation for website.

11 years agoAdd guestfs.pod and guestfish.pod to EXTRA_DIST. 1.0.81
Richard Jones [Wed, 13 Jan 2010 13:08:30 +0000 (13:08 +0000)]
Add guestfs.pod and guestfish.pod to EXTRA_DIST.

11 years agoPrepare for version 1.0.81.
Richard Jones [Wed, 13 Jan 2010 13:03:28 +0000 (13:03 +0000)]
Prepare for version 1.0.81.

11 years agoUpdate to latest Gnulib.
Richard Jones [Wed, 13 Jan 2010 11:24:44 +0000 (11:24 +0000)]
Update to latest Gnulib.

11 years agoqemu: Upstream regression of -stdio serial option.
Richard Jones [Thu, 7 Jan 2010 12:21:42 +0000 (12:21 +0000)]
qemu: Upstream regression of -stdio serial option.

Best explained by the comment in the code:

    /* Newer versions of qemu (from around 2009/12) changed the
     * behaviour of monitors so that an implicit '-monitor stdio' is
     * assumed if we are in -nographic mode and there is no other
     * -monitor option.  Only a single stdio device is allowed, so
     * this broke the '-serial stdio' option.  There is a new flag
     * called -nodefaults which gets rid of all this default crud, so
     * let's use that to avoid this and any future surprises.

11 years agoinspector: Update example XML and RNG schema.
Richard Jones [Wed, 6 Jan 2010 09:55:57 +0000 (09:55 +0000)]
inspector: Update example XML and RNG schema.

This updates commit a59dcdbd1b0a28c960e3792165a13f2daf4f6c35.

11 years agoinspector: Make RPM application data more specific (RHBZ#552718).
Richard Jones [Tue, 5 Jan 2010 23:04:57 +0000 (23:04 +0000)]
inspector: Make RPM application data more specific (RHBZ#552718).

List applications with epoch, release and arch data.

If epoch is 0, don't store this as an empty string, but as
undefined, and don't output empty <epoch/> element in the XML.

11 years agoUse linker script to control visibility of symbols.
Richard Jones [Mon, 4 Jan 2010 15:39:49 +0000 (15:39 +0000)]
Use linker script to control visibility of symbols.

11 years agogenerator: Move all library generation code together.
Richard Jones [Mon, 4 Jan 2010 14:55:24 +0000 (14:55 +0000)]
generator: Move all library generation code together.

11 years agogenerator: Print total lines of generated code.
Richard Jones [Mon, 4 Jan 2010 14:40:08 +0000 (14:40 +0000)]
generator: Print total lines of generated code.

11 years agoC#: Add documentation about experimental nature of these bindings.
Richard Jones [Mon, 4 Jan 2010 14:51:36 +0000 (14:51 +0000)]
C#: Add documentation about experimental nature of these bindings.

11 years agoExperimental C# bindings.
Richard Jones [Sat, 2 Jan 2010 19:46:20 +0000 (19:46 +0000)]
Experimental C# bindings.

Tested in only limited situations, with Mono on Linux.

11 years agoUpdate copyright years.
Richard Jones [Sat, 2 Jan 2010 19:47:37 +0000 (19:47 +0000)]
Update copyright years.

11 years agoMove guestfs(3) and guestfish(1) man pages into subdirectories.
Richard Jones [Thu, 31 Dec 2009 12:26:04 +0000 (12:26 +0000)]
Move guestfs(3) and guestfish(1) man pages into subdirectories.

These manual pages have for a very long time 'lived' in the top
source directory.

Clean up this situation by moving those manual pages (plus associated
generated files) into the src/ and fish/ subdirectories respectively.

11 years agogenerator: Move src/guestfs-bindtests.c next to other src/ files.
Richard Jones [Thu, 31 Dec 2009 12:16:10 +0000 (12:16 +0000)]
generator: Move src/guestfs-bindtests.c next to other src/ files.

11 years agogenerator: Use Continuation Passing Style (CPS) in output_to function.
Richard Jones [Thu, 31 Dec 2009 11:51:48 +0000 (11:51 +0000)]
generator: Use Continuation Passing Style (CPS) in output_to function.

This makes the code simpler, shorter and less error-prone.

11 years agogenerator: Rename GPLv2 to GPLv2plus, LGPLv2 to LGPLv2plus.
Richard Jones [Thu, 31 Dec 2009 11:29:49 +0000 (11:29 +0000)]
generator: Rename GPLv2 to GPLv2plus, LGPLv2 to LGPLv2plus.

The licenses are "any later version", so reflect this in the
naming of the parameter to generate_header.

11 years agogenerated code: Set copyright years to 2009-xxxx when current year > 2009.
Richard Jones [Thu, 31 Dec 2009 11:22:26 +0000 (11:22 +0000)]
generated code: Set copyright years to 2009-xxxx when current year > 2009.

11 years agoRemove separate, combine this with
Richard Jones [Thu, 31 Dec 2009 11:20:56 +0000 (11:20 +0000)]
Remove separate, combine this with

This commit combines the previously separate ""
program which generated bindings for virt-inspector.

Having two separate programs caused no end of troubles for developers,
so we now combine them into a single program.

NOTE: OCaml xml-light is now *required* in order to rebuild the
generated code.

11 years agogenerator: Comment and whitespace changes only.
Richard Jones [Thu, 31 Dec 2009 10:52:08 +0000 (10:52 +0000)]
generator: Comment and whitespace changes only.

11 years agodaemon: Work around udevsettle issue (RHBZ#548121).
Richard Jones [Fri, 18 Dec 2009 19:20:37 +0000 (19:20 +0000)]
daemon: Work around udevsettle issue (RHBZ#548121).

11 years agoPrepare for 1.0.80. 1.0.80
Richard Jones [Wed, 16 Dec 2009 11:53:48 +0000 (11:53 +0000)]
Prepare for 1.0.80.

11 years agoInclude latest Polish translations (Piotr Drąg, RHBZ#502533).
Richard Jones [Wed, 16 Dec 2009 11:57:51 +0000 (11:57 +0000)]
Include latest Polish translations (Piotr Drąg, RHBZ#502533).

11 years agoUpdate PO files.
Richard Jones [Wed, 16 Dec 2009 11:55:21 +0000 (11:55 +0000)]
Update PO files.

11 years agobuild: Fix typo in filename.
Richard Jones [Wed, 16 Dec 2009 11:54:53 +0000 (11:54 +0000)]
build: Fix typo in filename.

11 years agobuild: Remove references to old contrib/ files which were removed.
Richard Jones [Wed, 16 Dec 2009 11:53:30 +0000 (11:53 +0000)]
build: Remove references to old contrib/ files which were removed.

11 years agoappliance: Special case handling for libbfd in the supermin appliance.
Richard Jones [Wed, 16 Dec 2009 11:15:26 +0000 (11:15 +0000)]
appliance: Special case handling for libbfd in the supermin appliance.

The libbfd library has a constantly changing, non-standard and
very long name, eg:


Just add a special case to deal with this.  This fixes the guestfs_strings
command, which relies on the external strings binary which uses this

11 years agoappliance: Ignore unreadable dbus helper programs.
Richard Jones [Wed, 16 Dec 2009 11:04:10 +0000 (11:04 +0000)]
appliance: Ignore unreadable dbus helper programs.

11 years agolib: Link with $(LTLIBTHREAD), required by Gnulib lock module.
Richard Jones [Mon, 7 Dec 2009 11:28:21 +0000 (11:28 +0000)]
lib: Link with $(LTLIBTHREAD), required by Gnulib lock module.

This fixes commit cada248a53858341c91f70392e8f5b6e47d9b4fe.

11 years agoappliance: Fix code which gets list of kernels.
Matthew Booth [Fri, 4 Dec 2009 15:38:09 +0000 (15:38 +0000)]
appliance: Fix code which gets list of kernels.

The first 'ls' command was failing, so the second 'ls' command
would never run at all.

11 years agoaccommodate leading "+" in git submodule output
Jim Meyering [Fri, 4 Dec 2009 15:34:41 +0000 (15:34 +0000)]
accommodate leading "+" in git submodule output

* (_submodule_hash): Also filter out "+".
* Likewise.

11 years agolib: Add thread-safety to global list of handles.
Richard Jones [Fri, 4 Dec 2009 14:35:55 +0000 (14:35 +0000)]
lib: Add thread-safety to global list of handles.

This commit uses the Gnulib 'lock' module to implement a mutex on
the global list of handles which is stored by the library.

Note that Gnulib nicely avoids explicitly linking with -lpthread
unless the application program itself links to -lpthread.  Locks
are only enabled in multithreaded applications.

$ ldd src/.libs/ =>  (0x00007fffcb7ff000) => /lib64/ (0x00007f96a4e6c000)
/lib64/ (0x00007f96a544d000)

Please enter the commit message for your changes. Lines starting

11 years agodaemon error handling: Define a new function reply_with_perror_errno.
Richard Jones [Mon, 30 Nov 2009 14:11:20 +0000 (14:11 +0000)]
daemon error handling: Define a new function reply_with_perror_errno.

This allows you to save the errno from a previous call and
pass it to reply_with_perror.

For example, original code:

  r = some_system_call ();
  err = errno;
  do_cleanup ();
  errno = err;
  if (r == -1) {
    reply_with_perror ("failed");
    return -1;

can in future be changed to:

  r = some_system_call ();
  err = errno;
  do_cleanup ();
  if (r == -1) {
    reply_with_perror_errno (err, "failed");
    return -1;

11 years agodaemon error handling: recursive_mkdir shouldn't need to set errno.
Richard Jones [Fri, 27 Nov 2009 14:14:21 +0000 (14:14 +0000)]
daemon error handling: recursive_mkdir shouldn't need to set errno.

11 years agodaemon error handling: Clear errno before calling stub functions.
Richard Jones [Mon, 30 Nov 2009 13:55:04 +0000 (13:55 +0000)]
daemon error handling: Clear errno before calling stub functions.

This just ensures that we accurately report errors, even if our
error path code doesn't set errno.  We won't end up with a bogus
errno left over from a previous call.

11 years agoWhitespace change.
Richard Jones [Fri, 27 Nov 2009 13:42:43 +0000 (13:42 +0000)]
Whitespace change.

11 years agovirt-rescue: Freshen documentation.
Richard Jones [Thu, 26 Nov 2009 22:33:52 +0000 (22:33 +0000)]
virt-rescue: Freshen documentation.

11 years agoguestfish: Freshen documentation.
Richard Jones [Thu, 26 Nov 2009 22:32:15 +0000 (22:32 +0000)]
guestfish: Freshen documentation.

11 years agodaemon: Move prototypes around to keep functions grouped logically.
Richard Jones [Thu, 26 Nov 2009 15:38:48 +0000 (15:38 +0000)]
daemon: Move prototypes around to keep functions grouped logically.

11 years agoFix error handling in 'zero' function.
Richard Jones [Thu, 26 Nov 2009 16:06:03 +0000 (16:06 +0000)]
Fix error handling in 'zero' function.

11 years agodaemon/Win32: Add contributed test script to test daemon using Wine.
Richard Jones [Thu, 26 Nov 2009 15:17:37 +0000 (15:17 +0000)]
daemon/Win32: Add contributed test script to test daemon using Wine.

This test script allows you to test limited features of the
Windows daemon by running it on a standard Fedora host using

Read contrib/README and contrib/ in detail
before using.

11 years agoIgnore guestfsd.exe (Windows daemon).
Richard Jones [Thu, 26 Nov 2009 14:42:54 +0000 (14:42 +0000)]
Ignore guestfsd.exe (Windows daemon).

11 years agoRemove old contrib/febootstrap directory.
Richard Jones [Thu, 26 Nov 2009 14:34:35 +0000 (14:34 +0000)]
Remove old contrib/febootstrap directory.

11 years agoUpdate PO files.
Richard Jones [Thu, 26 Nov 2009 14:26:44 +0000 (14:26 +0000)]
Update PO files.

11 years agoMake realpath call optional, disable it for Windows.
Richard Jones [Thu, 26 Nov 2009 14:13:27 +0000 (14:13 +0000)]
Make realpath call optional, disable it for Windows.

11 years agobuild: update gnulib submodule to latest
Richard Jones [Thu, 26 Nov 2009 11:58:27 +0000 (11:58 +0000)]
build: update gnulib submodule to latest

11 years agodaemon: program_name must be defined for Gnulib error module.
Richard Jones [Thu, 26 Nov 2009 13:23:56 +0000 (13:23 +0000)]
daemon: program_name must be defined for Gnulib error module.

11 years agodaemon/Win32: use gnulib modules connect, socket and symlinkat (for readlinkat).
Richard Jones [Thu, 26 Nov 2009 11:52:28 +0000 (11:52 +0000)]
daemon/Win32: use gnulib modules connect, socket and symlinkat (for readlinkat).

11 years agodaemon/Win32: provide htonl, htons, ntohl, ntohs functions.
Richard Jones [Thu, 26 Nov 2009 11:26:40 +0000 (11:26 +0000)]
daemon/Win32: provide htonl, htons, ntohl, ntohs functions.

These functions are not available on Windows.

11 years agodaemon/Win32: Use Gnulib perror module.
Richard Jones [Thu, 26 Nov 2009 11:13:00 +0000 (11:13 +0000)]
daemon/Win32: Use Gnulib perror module.

11 years agodaemon: Link guestfs_protocol.[ch] into the daemon directory.
Richard Jones [Thu, 26 Nov 2009 11:01:01 +0000 (11:01 +0000)]
daemon: Link guestfs_protocol.[ch] into the daemon directory.

Instead of doing a recursive call into the src/ directory to build
the object files, hard link the source files into the daemon
directory and build them separately.


Thanks to Jim Meyering for noticing a typo in the original version.

11 years agodaemon: Typo generator_build -> generator_built
Richard Jones [Thu, 26 Nov 2009 10:52:37 +0000 (10:52 +0000)]
daemon: Typo generator_build -> generator_built

11 years agodaemon: Indent C macros to reflect nesting level.
Richard Jones [Thu, 26 Nov 2009 09:31:35 +0000 (09:31 +0000)]
daemon: Indent C macros to reflect nesting level.

11 years agodaemon/Win32: Win32 can't fork message moved to separate function (Jim Meyering)
Richard Jones [Thu, 26 Nov 2009 09:29:02 +0000 (09:29 +0000)]
daemon/Win32: Win32 can't fork message moved to separate function (Jim Meyering)

11 years agoguestfs documentation: Missing space.
Richard Jones [Wed, 25 Nov 2009 22:20:22 +0000 (22:20 +0000)]
guestfs documentation: Missing space.

11 years agoguestfs: Update architecture section of documentation.
Richard Jones [Wed, 25 Nov 2009 21:41:51 +0000 (21:41 +0000)]
guestfs: Update architecture section of documentation.

11 years agoUpdate PO files.
Richard Jones [Wed, 25 Nov 2009 17:12:00 +0000 (17:12 +0000)]
Update PO files.

11 years agodaemon: Fix build on Unix.
Richard Jones [Wed, 25 Nov 2009 17:10:33 +0000 (17:10 +0000)]
daemon: Fix build on Unix.

11 years agodaemon: Fix sync() call on Unix.
Richard Jones [Wed, 25 Nov 2009 16:54:46 +0000 (16:54 +0000)]
daemon: Fix sync() call on Unix.

11 years agodaemon/Win32: update comment
Richard Jones [Wed, 25 Nov 2009 16:33:00 +0000 (16:33 +0000)]
daemon/Win32: update comment

11 years agodaemon/Win32: Supply MAX macro for challenged platforms.
Richard Jones [Wed, 25 Nov 2009 15:00:19 +0000 (15:00 +0000)]
daemon/Win32: Supply MAX macro for challenged platforms.

11 years agodaemon/Win32: Windows can't daemonize.
Richard Jones [Wed, 25 Nov 2009 14:59:30 +0000 (14:59 +0000)]
daemon/Win32: Windows can't daemonize.

11 years agodaemon/Win32: Windows replacement for umask.
Richard Jones [Wed, 25 Nov 2009 14:56:42 +0000 (14:56 +0000)]
daemon/Win32: Windows replacement for umask.

11 years agodaemon/Win32: Replace setenv with Win32 equivalent.
Richard Jones [Wed, 25 Nov 2009 14:53:17 +0000 (14:53 +0000)]
daemon/Win32: Replace setenv with Win32 equivalent.

11 years agodaemon/Win32: Use xdr_u_int for PortableXDR compatibility.
Richard Jones [Wed, 25 Nov 2009 14:45:20 +0000 (14:45 +0000)]
daemon/Win32: Use xdr_u_int for PortableXDR compatibility.

PortableXDR didn't support xdr_uint32_t.  xdr_u_int is the same type.

11 years agodaemon/Win32: Don't bother blocking SIGPIPE on Win32.
Richard Jones [Wed, 25 Nov 2009 14:40:52 +0000 (14:40 +0000)]
daemon/Win32: Don't bother blocking SIGPIPE on Win32.

11 years agodaemon/Win32: Use gnulib getaddrinfo module.
Richard Jones [Wed, 25 Nov 2009 14:40:39 +0000 (14:40 +0000)]
daemon/Win32: Use gnulib getaddrinfo module.

11 years agodaemon/Win32: Implement statvfs using GetDiskFreeSpaceEx.
Richard Jones [Wed, 25 Nov 2009 13:07:05 +0000 (13:07 +0000)]
daemon/Win32: Implement statvfs using GetDiskFreeSpaceEx.

At the time of writing Gnulib didn't support Win32 for its
fsusage API.  Therefore this patch uses GetDiskFreeSpaceEx
if it's available (on Windows) otherwise falls back to using
Gnulib fsusage.

11 years agodaemon: Move statvfs code into separate file.
Richard Jones [Wed, 25 Nov 2009 12:24:01 +0000 (12:24 +0000)]
daemon: Move statvfs code into separate file.

This makes no functional change to the code.  It just moves the
statvfs-related code out of daemon/stat.c into a new file called

11 years agodaemon: Use gnulib futimens module.
Richard Jones [Wed, 25 Nov 2009 12:17:10 +0000 (12:17 +0000)]
daemon: Use gnulib futimens module.

Instead of checking for futimens support and falling back
(incorrectly in one case) to using futimes, use gnulib's

However the gnulib module does not yet support Win32, so
this change is only really useful on platforms like RHEL 5.

11 years agodaemon/Win32: Use gnulib pread module.
Richard Jones [Wed, 25 Nov 2009 11:59:20 +0000 (11:59 +0000)]
daemon/Win32: Use gnulib pread module.

11 years agosync: Windows implementation of sync() call.
Richard Jones [Wed, 25 Nov 2009 10:26:48 +0000 (10:26 +0000)]
sync: Windows implementation of sync() call.

Replace calls to sync() with calls to sync_disks() which supports
Win32 via FlushFileBuffers.

11 years agodaemon: Alternate implementation of posix_fallocate.
Richard Jones [Tue, 24 Nov 2009 16:16:08 +0000 (16:16 +0000)]
daemon: Alternate implementation of posix_fallocate.

If the posix_fallocate function is not available [ie. Windows]
use an alternate implementation that just loops and writes.

11 years agodd: Missing include of <string.h>
Richard Jones [Tue, 24 Nov 2009 16:10:13 +0000 (16:10 +0000)]
dd: Missing include of <string.h>

Breaks compilation on Windows.

11 years agodaemon/Windows: Define _WIN32_WINNT when compiling on Windows.
Richard Jones [Wed, 25 Nov 2009 11:38:44 +0000 (11:38 +0000)]
daemon/Windows: Define _WIN32_WINNT when compiling on Windows.

11 years agobuild: update gnulib submodule to latest
Richard Jones [Wed, 25 Nov 2009 16:24:49 +0000 (16:24 +0000)]
build: update gnulib submodule to latest

11 years agobuild: update gnulib submodule to latest
Richard Jones [Wed, 25 Nov 2009 15:29:39 +0000 (15:29 +0000)]
build: update gnulib submodule to latest

11 years agosupermin: Die with an error if no kernels found (RHBZ#539746).
Richard Jones [Tue, 24 Nov 2009 18:17:07 +0000 (18:17 +0000)]
supermin: Die with an error if no kernels found (RHBZ#539746).

Updated with a suggestion from Jim Meyering to use the '-d'
option to ls to avoid a future case of directories matching.

11 years agoNew tool: virt-list-filesystems
Richard Jones [Tue, 24 Nov 2009 15:19:08 +0000 (15:19 +0000)]
New tool: virt-list-filesystems

Use this program as a convenient way to list the filesystems
available in a disk image or libvirt guest.


  $ virt-list-filesystems /dev/vg_trick/Debian5x64

This is designed to make it easier for novices to use guestfish
and guestmount.  In particular with guestmount this acts as a way
to get a list of filesystems to use with the '-m' option.  ie:

  $ virt-list-filesystems unknowndisk.img
  $ guestmount -a unknowndisk.img -m /dev/sda1 /mnt

11 years agoavailability: Document how to check for single API calls
Richard Jones [Tue, 24 Nov 2009 14:27:56 +0000 (14:27 +0000)]
availability: Document how to check for single API calls

This documents how to use autotools and dlopen(3) to test for
the availability of single API calls at compile time and run time

11 years agoavailability: Add a test for this call.
Richard Jones [Tue, 24 Nov 2009 14:05:57 +0000 (14:05 +0000)]
availability: Add a test for this call.

Because all the tested groups are optional, there's not really
a group we can reliably test, therefore test against the
empty list (which should not fail).

11 years agoavailability: Clarify and fix documentation.
Richard Jones [Tue, 24 Nov 2009 14:00:34 +0000 (14:00 +0000)]
availability: Clarify and fix documentation.

11 years agogenerator: Passing "" to StringList tests should turn into empty list.
Richard Jones [Tue, 24 Nov 2009 14:04:28 +0000 (14:04 +0000)]
generator: Passing "" to StringList tests should turn into empty list.

This is a bug in the generator which wasn't being tickled.  If
you had a test which expected a StringList or DeviceList parameter,
and you passed "" to that test, then you'd (probably) expect to be
testing an empty list, but in fact you got a single element list
containing an empty string.  This fixes it so you get an empty list.

11 years agodaemon: Fix return value from aug_defnode.
Richard Jones [Tue, 24 Nov 2009 16:00:23 +0000 (16:00 +0000)]
daemon: Fix return value from aug_defnode.

Bug fix - the return value from this function was wrong
in the no-Augeas case.

11 years agoImplement 'dd' command.
Richard Jones [Sun, 22 Nov 2009 19:15:56 +0000 (19:15 +0000)]
Implement 'dd' command.

11 years agoUse STRPREFIX instead of STREQLEN.
Richard Jones [Sun, 22 Nov 2009 19:14:48 +0000 (19:14 +0000)]

11 years agogenerator: second parameter to upload is Dev_or_Path, not String.
Richard Jones [Sun, 22 Nov 2009 19:14:19 +0000 (19:14 +0000)]
generator: second parameter to upload is Dev_or_Path, not String.

11 years agobuild: Add missing dependencies in perl directory
Matthew Booth [Fri, 20 Nov 2009 18:45:22 +0000 (18:45 +0000)]
build: Add missing dependencies in perl directory

make all in the perl directory was missing a check that the library had been

make check in the perl directory was missing a check that the appliance and test
images had been built.

11 years agobuild: Ensure building appliance depends on guestfsd
Matthew Booth [Fri, 20 Nov 2009 18:43:20 +0000 (18:43 +0000)]
build: Ensure building appliance depends on guestfsd

Previously, only the rule checked the daemon had been built.
is called directly from within, so in that path the dependency was never
checked. This adds the daemon dependency explicitly to the rebuild-from-scratch

11 years agobuild: Don't re-check for each generator_built in daemon directory
Matthew Booth [Fri, 20 Nov 2009 18:05:49 +0000 (18:05 +0000)]
build: Don't re-check for each generator_built in daemon directory

11 years agobuild: Rebuild the daemon as necessary from other directories
Matthew Booth [Fri, 20 Nov 2009 17:52:27 +0000 (17:52 +0000)]
build: Rebuild the daemon as necessary from other directories

This change ensure that making the appliance will always rebuild the daemon if

11 years agoUpdate TODO file.
Richard Jones [Sat, 21 Nov 2009 21:11:44 +0000 (21:11 +0000)]
Update TODO file.

11 years agoperl: Add Sys::Guestfs::Lib::feature_available
Richard Jones [Fri, 20 Nov 2009 18:20:28 +0000 (18:20 +0000)]
perl: Add Sys::Guestfs::Lib::feature_available

This is a nicer Perl wrapper around $g->available call.

Update the other code in Sys::Guestfs::Lib to use it before using
LVM, Augeas.

11 years agoavailability: Skip tests when functions are not available.
Richard Jones [Fri, 20 Nov 2009 16:32:53 +0000 (16:32 +0000)]
availability: Skip tests when functions are not available.

11 years agoavailability: Add optional groups and implement guestfs_available call.
Richard Jones [Fri, 20 Nov 2009 14:10:06 +0000 (14:10 +0000)]
availability: Add optional groups and implement guestfs_available call.

The current groups are defined very conservatively using the
following criteria:
 (a) Would be impossible to implement on Windows because of
     sheer architectural differences (eg: mknod).
 (b) Already optional (augeas, inotify).
 (c) Not currently optional but not implemented on older RHEL and
     Debian releases (ntfs-3g.probe, scrub, zerofree).

The optional groups I've defined according to these criteria are:

 . augeas
 . inotify
 . linuxfsuuid
 . linuxmodules
 . linuxxattrs
 . lvm2
 . mknod
 . ntfs3g
 . scrub
 . selinux
 . zerofree

(Note that these choices don't prevent us from adding more
optional groups in future.  On the other hand to avoid breaking
ABIs we would not wish to change the above groups).

The rest of this large commit is really just implementation:

Each optional function is classified using Optional "group"
flag in the generator.

The daemon has to implement a function

  int optgroup_<name>_available (void);

for each optional group.  Some of these functions are fixed at
compile time, and some do simple run-time tests.

The do_available implementation in the daemon looks up the correct
function in a table and runs it.

We document the optional groups in the guestfs(3) man page.

Also: I added a NOT_AVAILABLE macro in order to unify all the
existing places where we had a message equivalent to
"function __func__ is not available".

11 years agoavailability: Add guestfs_available.
Richard Jones [Fri, 20 Nov 2009 13:06:49 +0000 (13:06 +0000)]
availability: Add guestfs_available.

Start a new API allowing groups of functions to be tested for

There are two reasons for this:

(1) If libguestfs is built with missing dependencies (eg. no Augeas lib)
then the corresponding functions are disabled in the appliance.  Up till
now there has been no way to test for this except to speculatively
issue commands and check for errors.

(2) When we port the daemon to Win32 it is likely that major pieces of
functionality won't be available (eg. LVM support).  This API gives
a way to test for that.

There is no change for existing clients: you still have to check for
errors from individual API calls.

For new clients, you will be able to test for availability of particular

Usage scenario (A): An LVM editing tool which requires
both the LVM API and inotify in order to function at all:

  char *apis[] = { "inotify", "lvm2", NULL };
  r = guestfs_available (g, apis);
  if (r == -1) {
    /* print an error and exit */

Usage scenario (B): A general purpose tool which optionally provides
configuration file editing, but this can be disabled, the result
merely being reduced functionality:

  char *apis[] = { "augeas", NULL };
  r = guestfs_available (g, apis);
  enable_config_edit_menus = r == 0;

11 years agodaemon/Win32: Use gnulib modules for first porting to Win32.
Richard Jones [Fri, 20 Nov 2009 11:48:51 +0000 (11:48 +0000)]
daemon/Win32: Use gnulib modules for first porting to Win32.

11 years agobuild: Add missing dependency>guestfs_protocol.h
Matthew Booth [Fri, 20 Nov 2009 16:48:38 +0000 (16:48 +0000)]
build: Add missing dependency>guestfs_protocol.h

11 years agobuild: correct sed transformation to work also on .git-module-status
Jim Meyering [Fri, 20 Nov 2009 15:25:00 +0000 (16:25 +0100)]
build: correct sed transformation to work also on .git-module-status

My patch was wrong.
I kept the sed transformation the same in the two places,
but it wasn't strict enough to also work on the file contents.
Sorry about that.  This fixes it.

>From 93927cc7b9f63c414e5bfeb7eba393fde3295601 Mon Sep 17 00:00:00 2001
From: Jim Meyering <>
Date: Fri, 20 Nov 2009 16:23:17 +0100
Subject: [PATCH libguestfs] build: correct sed transformation to work also on .git-module-status

* Use a more strict sed transformation so it works also
on the contents of .git-module-status, which has no prefix.
* (_submodule_hash): Use a stricter sed regexp.