13 years agoNew tool: virt-edit
Richard Jones [Wed, 23 Sep 2009 10:12:05 +0000 (11:12 +0100)]
New tool: virt-edit

Edit any file in a guest.  This was possibly previously
using guestfish, but having a separate command makes it

The usage is simply:

  virt-edit mydomain /some/file

It runs $EDITOR or vi on the file, and if the user changes
it, uploads the result back to the VM.

13 years agovirt-cat: Remove some unused Perl module includes.
Richard Jones [Wed, 23 Sep 2009 10:11:21 +0000 (11:11 +0100)]
virt-cat: Remove some unused Perl module includes.

13 years agoAdd 'virt-rescue' command.
Richard Jones [Tue, 22 Sep 2009 18:50:21 +0000 (19:50 +0100)]
Add 'virt-rescue' command.

This command runs a "rescue appliance" against a virtual machine
or disk image.  This is useful for making ad-hoc interactive
changes to virtual machines.

  $ virt-rescue --ro /dev/vg_trick/F11x64

  Welcome to virt-rescue, the libguestfs rescue shell.

  Note: The contents of / are the rescue appliance.
  You have to mount the guest's partitions under /sysroot
  before you will be able to examine them.

  bash: cannot set terminal process group (-1): Inappropriate ioctl for device
  bash: no job control in this shell
  ><rescue> mount /dev/vg_f11x64/lv_root /sysroot
  EXT4-fs (dm-0): barriers enabled
  kjournald2 starting: pid 269, dev dm-0:8, commit interval 5 seconds
  EXT4-fs (dm-0): internal journal on dm-0:8
  EXT4-fs (dm-0): delayed allocation enabled
  EXT4-fs: file extents enabled
  EXT4-fs: mballoc enabled
  EXT4-fs (dm-0): mounted filesystem with ordered data mode
  ><rescue> ls /sysroot/
  bin   dev  home  lib64       media  opt   root  selinux  sys  usr
  boot  etc  lib   lost+found  mnt    proc  sbin  srv      tmp  var
  ><rescue> exit

13 years agoAdd direct appliance mode flag and implementation.
Richard Jones [Tue, 22 Sep 2009 18:52:56 +0000 (19:52 +0100)]
Add direct appliance mode flag and implementation.

When the g->direct flag is set, the appliance stdin/stdout
are not connected to the library.  Instead they inherit the
stdin/stdout of the caller.

This is used to implement virt-rescue.

13 years agoTidy up appliance rescue code.
Richard Jones [Tue, 22 Sep 2009 18:51:47 +0000 (19:51 +0100)]
Tidy up appliance rescue code.

The appliance shouldn't run the daemon after we leave the
rescue shell.  It should just exit instead.

13 years agoRejig tests for qemu vmchannel support.
Richard Jones [Tue, 22 Sep 2009 12:34:50 +0000 (13:34 +0100)]
Rejig tests for qemu vmchannel support.

vmchannel is no longer required, so we shouldn't test for it.
However we should test instead for user mode networking support.

Also fix up the documentation / error messages.

Always test for vmchannel and user mode networking support in
qemu.  This gives us more troubleshooting information if people
report bugs.

13 years agoPrepare for 1.0.71. 1.0.71
Richard Jones [Tue, 22 Sep 2009 11:12:56 +0000 (12:12 +0100)]
Prepare for 1.0.71.

Update version number and update PO files.

Put latest version and release date on the website front page.

13 years agoChange handling of spaces on Linux kernel command line.
Richard Jones [Tue, 22 Sep 2009 09:41:05 +0000 (10:41 +0100)]
Change handling of spaces on Linux kernel command line.

13 years agoUpdate documentation of qemu / vmchannel.
Richard Jones [Mon, 21 Sep 2009 14:34:21 +0000 (15:34 +0100)]
Update documentation of qemu / vmchannel.

13 years agoImplement "null vmchannel" - no vmchannel needed!
Richard Jones [Mon, 21 Sep 2009 14:27:20 +0000 (15:27 +0100)]
Implement "null vmchannel" - no vmchannel needed!

This commit removes the requirement for vmchannel, although retaining
support for it.

In this configuration, known as "null vmchannel", the library
listens on a random loopback port.  It passes the number of this
port to the appliance (guestfs_vmchannel=tcp:, and
the daemon then connects back.  The library, instead of connecting,
listens and accepts the connection during guestfs_launch.

QEMU SLIRP (user mode networking) is still required to make this
work: SLIRP forwards the TCP connection transparently (instead of
explicitly as with guestfwd) to<port>

There is a window in which any other local process on the machine
could see the port number in the qemu command line and try to
connect to it.  This would be a devastating security hole, because
any local process could pretend to be the daemon and feed back
malicious replies to our remote procedure calls.  To prevent this,
we check the UID of the other side of the TCP connection.  If
the UID is different from the library's EUID, then we reject the
connection.  To do this we have to parse /proc/net/tcp.  (On Solaris
we could use getsockopt (SO_PEERCRED), but this doesn't work on
Linux TCP sockets).

Other vmchannel(s) are still supported.  This is important, because
we can't in general be sure the qemu will always support SLIRP.
In particular, in recent versions of qemu it is possible to compile
out SLIRP.

13 years agoGnulib: Add arpa-inet and netinet-in modules.
Richard Jones [Mon, 21 Sep 2009 14:27:02 +0000 (15:27 +0100)]
Gnulib: Add arpa-inet and netinet-in modules.

13 years agoFlexible guestfs_vmchannel parameter for future appliances.
Richard Jones [Mon, 21 Sep 2009 12:03:27 +0000 (13:03 +0100)]
Flexible guestfs_vmchannel parameter for future appliances.

This reimplements parts of commit da0a4f8d1f6ddd302ceba028d87c6e009589e503
in a different, but compatible way.

We pass guestfs_vmchannel=tcp:<ip>:<port> on the command line.  This
is intended to be used as follows (now and in future versions):

  tcp:    for guestfwd vmchannel
  tcp:<port>  for future "no vmchannel" implementation
  /dev/vcon4           for future virtio-console vmchannel*

It also accepts the old-style guestfs= parameter which
is sent by older libraries, and turns this transparently into the
correct format above.

If no guestfs_vmchannel is passed, then this defaults to the guestfwd
vmchannel which older libraries would expect.

* Maybe this last one should be dev:/dev/vcon4 or file:/dev/vcon4, but
we don't need to decide that now.

13 years agoRearrange and tidy up code in guestfsd.c
Richard Jones [Mon, 21 Sep 2009 11:32:25 +0000 (12:32 +0100)]
Rearrange and tidy up code in guestfsd.c

This just tidies up the main() function in the daemon.  There is
no longer a huge fixed-sized buffer used for the kernel command
line.  Variables are moved closer to where they are used.  Some
local variables turned out to be unused - these are removed.  Finally
the part that reads the kernel command line is moved into a separate

There is only minimal functional change here (it now prints out
the kernel command line).

Literal '4' replaced with 'sizeof' expression, at Jim Meyering's
suggestion during patch review.

13 years agoMake GUESTFWD_PORT into a string.
Richard Jones [Mon, 21 Sep 2009 11:11:51 +0000 (12:11 +0100)]
Make GUESTFWD_PORT into a string.

13 years agoRemove unnecessary extra space from qemu command line.
Richard Jones [Mon, 21 Sep 2009 11:11:01 +0000 (12:11 +0100)]
Remove unnecessary extra space from qemu command line.

13 years agoRemove guestfs_wait_ready (turn it into a no-op).
Richard Jones [Mon, 21 Sep 2009 10:52:53 +0000 (11:52 +0100)]
Remove guestfs_wait_ready (turn it into a no-op).

This commit changes guestfs_launch so that it both launches
the appliance and waits until it is ready (ie. the daemon communicates
back to us).

Since we removed the pretence that we could implement a low-level
asynchronous API, the need to call launch() followed by wait_ready()
has looked a bit silly.

Now guestfs_wait_ready() is basically a no-op.  It is left in the
API for backwards compatibility.  Any calls to guestfs_wait_ready()
can be removed from client code.

13 years agoCombine temporary buffers.
Richard Jones [Mon, 21 Sep 2009 11:01:11 +0000 (12:01 +0100)]
Combine temporary buffers.

buf[], append[] and memsize_str[] were all temporary buffers
used in non-overlapping code.

Combine them to use a single buffer (buf[]).

13 years agoRearrange qemu command line order (no functional change).
Richard Jones [Mon, 21 Sep 2009 10:07:47 +0000 (11:07 +0100)]
Rearrange qemu command line order (no functional change).

13 years agoEnable new-style -chardev ... guestfwd command line.
Richard Jones [Fri, 18 Sep 2009 13:06:07 +0000 (14:06 +0100)]
Enable new-style -chardev ... guestfwd command line.

Newer versions of qemu have changed the command line format
(again).  '-net channel' is now deprecated.  Instead we use:

    -chardev socket,id=guestfsvmc,path=/path/to/sock,server,nowait
    -net user,vlan=0,net=,guestfwd=tcp:
    -net nic,model=ne2k_pci,vlan=0

The old style format is still used if the new style is not
detected at runtime.

13 years agoFix code which looked for leaked FDs between each command.
Richard Jones [Thu, 17 Sep 2009 15:44:20 +0000 (16:44 +0100)]
Fix code which looked for leaked FDs between each command.

This code was not checking the return value from system()
so it failed if uncommented.  Add ignore_value() around the
call to system.  However, leave the code still disabled.

13 years agoRemove explicit guestfs= kernel command line parameter.
Richard Jones [Tue, 15 Sep 2009 16:14:44 +0000 (17:14 +0100)]
Remove explicit guestfs= kernel command line parameter.

Since we control the appliance tightly, we can just specify
that it will always use a particular host and port, and we
don't need to pass it on the command line each time.

Also the VMCHANNEL_* constants are only relevant to the
particular guestfwd vmchannel implementation, so we rename
them as GUESTFWD_*.

13 years agoDaemon: fix handling of errors from xread and xwrite.
Richard Jones [Thu, 17 Sep 2009 14:28:41 +0000 (15:28 +0100)]
Daemon: fix handling of errors from xread and xwrite.

If xread or xwrite returns -1, that indicates an error and we
should exit.  Note that xread/xwrite has already printed the
error message.

13 years agoFix verbose packet dumping functions.
Richard Jones [Thu, 17 Sep 2009 13:50:04 +0000 (14:50 +0100)]
Fix verbose packet dumping functions.

Add the configure parameter --enable-packet-dump so that this
code can be enabled without editing the source.

This code is normally commented out, because it is too verbose
unless you happen to be debugging the underlying protocol.  Because
it is normally commented out, I found it had bit-rotted slightly.
This commit also fixes the obvious problems.

13 years ago'len' should be an unsigned 32 bit int.
Richard Jones [Thu, 17 Sep 2009 13:49:06 +0000 (14:49 +0100)]
'len' should be an unsigned 32 bit int.

This only happened to work by accident before because 'unsigned len'
happens to be 32 bit on all platforms we support.

13 years agoDisable -Wunsafe-loop-optimizations
Richard Jones [Thu, 17 Sep 2009 13:39:42 +0000 (14:39 +0100)]
Disable -Wunsafe-loop-optimizations

This warning indicates that GCC could not do a particular sort
of loop optimization.  It pops up randomly in certain forms of
looping code, and seems safe to ignore.

13 years agoUpdate PO files (no functional change).
Richard Jones [Tue, 15 Sep 2009 16:13:24 +0000 (17:13 +0100)]
Update PO files (no functional change).

13 years agoPrepare for version 1.0.70. 1.0.70
Richard Jones [Tue, 15 Sep 2009 10:13:54 +0000 (11:13 +0100)]
Prepare for version 1.0.70.

13 years agoUpdate PO files.
Richard Jones [Tue, 15 Sep 2009 10:12:45 +0000 (11:12 +0100)]
Update PO files.

13 years agoSet minimum gettext version to 0.17.
Richard Jones [Tue, 15 Sep 2009 10:10:20 +0000 (11:10 +0100)]
Set minimum gettext version to 0.17.

This fixes the problem that the 1.0.69 tarball would fail in
the po/ subdirectory when installing:

make[1]: Entering directory `/builddir/build/BUILD/libguestfs-1.0.69/po'
/bin/sh @MKINSTALLDIRS@ /builddir/build/BUILDROOT/libguestfs-1.0.69-1.fc11.x86_64/usr/share
/bin/sh: @MKINSTALLDIRS@: No such file or directory
make[1]: Leaving directory `/builddir/build/BUILD/libguestfs-1.0.69/po'

RHEL 5.3 has gettext 0.14.6.  However the tarball will still
build (since it includes all the required code).  This may cause
a problem if RHEL users want to build from the git repository.

13 years agoFix comparison between signed and unsigned (for RHEL 5). 1.0.69
Richard Jones [Tue, 15 Sep 2009 08:23:49 +0000 (09:23 +0100)]
Fix comparison between signed and unsigned (for RHEL 5).

13 years agoMove decl out for C99 compliance.
Richard Jones [Mon, 14 Sep 2009 19:14:47 +0000 (20:14 +0100)]
Move decl out for C99 compliance.

13 years agoUpdate PO files.
Richard Jones [Mon, 14 Sep 2009 18:35:58 +0000 (19:35 +0100)]
Update PO files.

13 years agoMove guestfs-internal-actions.h to EXTRA_DIST.
Richard Jones [Mon, 14 Sep 2009 18:35:46 +0000 (19:35 +0100)]
Move guestfs-internal-actions.h to EXTRA_DIST.

13 years agoPrepare for 1.0.69.
Richard Jones [Mon, 14 Sep 2009 18:28:14 +0000 (19:28 +0100)]
Prepare for 1.0.69.

13 years agoRemove main loop.
Richard Jones [Fri, 11 Sep 2009 19:00:30 +0000 (20:00 +0100)]
Remove main loop.

This commit removes the external main loop, which never worked
and caused a number of bugs.  Requests are now done synchronously,
and if the user wants to have requests issued in the background
or to have a responsive GUI, then they'll just have to use threads.

The big change is to push all reads and writes through two
functions called send_to_daemon (for writes) and recv_from_daemon
(for reads) which operate synchronously.  These functions
read/write whole messages, and also handle checking for EOF
(ie. daemon died) and asynchronous log message events from
qemu (eg. from debug / dmesg printed by the guest).  A more
complete description of how these work can be found in the code.

This code passes a complete run of the tests.

Bugs believed to be fixed by this commit:
  internal error: reply callback called twice
  In virt-inspector: "download: guestfs_download reply failed, see earlier error messages"

I have tried to avoid reintroducing this:
  libguestfs: error: write: Broken pipe (guestfish only)

One other benefit of this is that 'set_busy/end_busy' calls
no longer appear in traces.

13 years agoDon't enable trace in set_trace test.
Richard Jones [Mon, 14 Sep 2009 15:21:04 +0000 (16:21 +0100)]
Don't enable trace in set_trace test.

This leaves trace enabled afterwards, resulting in some
ugly test messages.

13 years agoFix type punning warning about use of CMSG_DATA in Rawhide.
Richard Jones [Mon, 14 Sep 2009 14:43:23 +0000 (15:43 +0100)]
Fix type punning warning about use of CMSG_DATA in Rawhide.

13 years agoguestfish: Enable grouping in string lists
Matthew Booth [Fri, 11 Sep 2009 08:27:57 +0000 (09:27 +0100)]
guestfish: Enable grouping in string lists

This change adds the ability to group entries in a string list with single
quotes. So the string:
  "'foo bar'"
becomes 1 token rather than 2. Consequently single quotes must now be escaped:
resolves to a literal single quote.

Incidentally, this change also alters another, probably unintentional behaviour
of the previous implementation, in that tokens are separated by any amount of
whitespace rather than a single whitespace character. I.e.:
  "a  b"
resolves to:
  'a' 'b'
rather than:
  'a' '' 'b'
That last syntax can be used if an empty argument is still desired. Whitespace
is now also defined to include tabs.

parse_string_list can also now fail if it contains an unmatched open quote.

13 years agoIgnore localrepo/ directory.
Richard Jones [Mon, 14 Sep 2009 12:41:02 +0000 (13:41 +0100)]
Ignore localrepo/ directory.

This can be used by people building from source and packagers for
their own purposes.

13 years agoAdd command trace functionality.
Richard Jones [Wed, 9 Sep 2009 16:48:30 +0000 (17:48 +0100)]
Add command trace functionality.

Enable this by calling guestfs_trace (handle, 1) or by
setting the LIBGUESTFS_TRACE=1 environment variable.

13 years agoNon-daemon actions indirect through generated code.
Richard Jones [Wed, 9 Sep 2009 11:34:13 +0000 (12:34 +0100)]
Non-daemon actions indirect through generated code.

Previously non-daemon actions were called directly by
user code, eg:

/* Non-generated */
guestfs_set_verbose (guestfs_h *g, int v)
  g->verbose = !!v;
  return 0;

This changes these actions so they go indirectly via
some generated code, eg:

/* Generated */
int guestfs_set_verbose (guestfs_h *g,
int verbose)
  return guestfs__set_verbose (g, verbose);

/* Non-generated */
guestfs__set_verbose (guestfs_h *g, int v)
  g->verbose = !!v;
  return 0;

The aim is to have a place in the generated code where
we can add debug or tracing information for these non-
daemon calls.

13 years agoguestfish: Redirect stdout when executing remote commands
Matthew Booth [Fri, 11 Sep 2009 16:04:13 +0000 (17:04 +0100)]
guestfish: Redirect stdout when executing remote commands

guestfish --listen necessarily redirects its stdout to /dev/null so as not to
interfere with eval. The remote protocol doesn't contain any other provision for
collecting stdout for the caller, so executing guestfish --remote will never
generate any output.

This patch fixes that by forwarding the caller's STDOUT to the listener over the
unix socket connection. The listener redirects its STDOUT to the caller's STDOUT
for the duration of the command, then closes it again.

13 years agoUpdate TODO list
Richard Jones [Sat, 12 Sep 2009 08:45:44 +0000 (09:45 +0100)]
Update TODO list

13 years agoAdd diffutils package.
Richard Jones [Fri, 11 Sep 2009 19:21:37 +0000 (20:21 +0100)]
Add diffutils package.

On Fedora 12, /usr/bin/cmp is not pulled in unless we explicitly
add the diffutils package.

13 years agoAdd echo_daemon command
Matthew Booth [Fri, 11 Sep 2009 13:27:54 +0000 (14:27 +0100)]
Add echo_daemon command

echo_daemon is a simple echo which can be used to test connectivity between the
client and daemon.

13 years Fix string list memory leak
Matthew Booth [Fri, 11 Sep 2009 09:33:32 +0000 (10:33 +0100)] Fix string list memory leak

Parsed string lists are allocated by malloc, but were never freed.

13 years agoIgnore some more m4 files.
Richard Jones [Wed, 9 Sep 2009 11:03:10 +0000 (12:03 +0100)]
Ignore some more m4 files.

13 years agoDon't include gnulib files in
Richard Jones [Wed, 9 Sep 2009 11:01:42 +0000 (12:01 +0100)]
Don't include gnulib files in

13 years agoavoid build-from-scratch failure due to missing daemon/configure
Jim Meyering [Fri, 4 Sep 2009 16:00:23 +0000 (18:00 +0200)]
avoid build-from-scratch failure due to missing daemon/configure

* bootstrap: Don't use autoreconf's --norecursive
option.  We require the default --recursive behavior in order
to create daemon/configure.  Reported by Matthew Booth.

13 years agomaint: guestfs.c: avoid warning about possible NULL deref from llvm/clang
Jim Meyering [Mon, 31 Aug 2009 18:29:08 +0000 (20:29 +0200)]
maint: guestfs.c: avoid warning about possible NULL deref from llvm/clang

* src/guestfs.h (guestfs_abort_cb): Declare with attribute noreturn.

13 years agomaint: guestfs.c: remove unnecessary initialization
Jim Meyering [Mon, 31 Aug 2009 17:51:46 +0000 (19:51 +0200)]
maint: guestfs.c: remove unnecessary initialization

* src/guestfs.c (guestfs__receive_file_sync): Don't set "r",
only to ignore it.

13 years avoid a warning about signed overflow in tests.c
Jim Meyering [Fri, 28 Aug 2009 12:07:35 +0000 (14:07 +0200)] avoid a warning about signed overflow in tests.c

* src/ Emit "unsigned long int n_failed;" rather than
"int failed;", to avoid warning from gcc about "assuming signed
overflow does not occur when simplifying conditional to constant".

13 years avoid defined-but-not-used warnings in guestfs_c_actions.c
Jim Meyering [Fri, 28 Aug 2009 11:53:36 +0000 (13:53 +0200)] avoid defined-but-not-used warnings in guestfs_c_actions.c

* src/ (emit_ocaml_copy_list_function): New function.
Emit a function definition only if it will be used.

13 years avoid warnings in generated ocaml/guestfs_c_actions.c
Jim Meyering [Fri, 28 Aug 2009 11:43:16 +0000 (13:43 +0200)] avoid warnings in generated ocaml/guestfs_c_actions.c

* src/ Emit prototypes for ocaml_guestfs_* functions,
to avoid warnings from gcc -Wmissing-prototypes.  Normally we'd put
these somewhere else, but in this unusual case, they're not needed
anywhere else.  Handle the >5-argument case, too, for these:
ocaml_guestfs_test0_byte, ocaml_guestfs_sfdisk_byte,

13 years agobuild: enable gcc warnings in capitests/ and ocaml/
Jim Meyering [Mon, 24 Aug 2009 09:39:42 +0000 (11:39 +0200)]
build: enable gcc warnings in capitests/ and ocaml/

* capitests/ Use $(WARN_CFLAGS) and $(WERROR_CFLAGS).
* ocaml/ Likewise.

13 years agoocaml/guestfs_c.c: avoid warning about missing prototypes
Jim Meyering [Thu, 27 Aug 2009 11:23:20 +0000 (13:23 +0200)]
ocaml/guestfs_c.c: avoid warning about missing prototypes

* ocaml/guestfs_c.c (ocaml_guestfs_create, ocaml_guestfs_close): Declare.

13 years agoocaml/guestfs_c.c: avoid warning about initialization discarding "const"
Jim Meyering [Thu, 27 Aug 2009 10:36:25 +0000 (12:36 +0200)]
ocaml/guestfs_c.c: avoid warning about initialization discarding "const"

* ocaml/guestfs_c.c (guestfs_custom_operations): Add a cast.

13 years agoocaml/guestfs_c.c avoid signed/unsigned-comparison warning
Jim Meyering [Thu, 27 Aug 2009 10:34:38 +0000 (12:34 +0200)]
ocaml/guestfs_c.c avoid signed/unsigned-comparison warning

* ocaml/guestfs_c.c (ocaml_guestfs_strings_val): Declare index as
unsigned int.

13 years agobuild: use only one m4/ directory
Jim Meyering [Tue, 25 Aug 2009 14:21:48 +0000 (16:21 +0200)]
build: use only one m4/ directory

* (ACLOCAL_AMFLAGS): Specify only one include dir: m4.
* bootstrap: Tell gnulib-tool to put .m4 files in m4/, not gnulib/m4.
* Move autoreconf from here into...
* bootstrap:, so that it is run only when gnulib-tool is.
Also, tell it to skip the usual autopoint and libtoolize runs.
* m4/.gitignore: Update.

13 years agobuild: invoke autopoint with --force
Jim Meyering [Tue, 25 Aug 2009 07:10:21 +0000 (09:10 +0200)]
build: invoke autopoint with --force

* bootstrap: Invoke autopoint with --force, to avoid warning
about existing build-aux/config.rpath.
Invoke libtoolize before gnulib-tool, to avoid spurious warnings.
* Add comments.
Remove build-aux/config.rpath before running autoreconf.

13 years agobuild: update gnulib submodule to latest
Jim Meyering [Tue, 25 Aug 2009 07:43:04 +0000 (09:43 +0200)]
build: update gnulib submodule to latest

* .gnulib: Update to latest.

13 years agobuild: don't define _GNU_SOURCE manually
Jim Meyering [Fri, 21 Aug 2009 17:44:36 +0000 (19:44 +0200)]
build: don't define _GNU_SOURCE manually

Now that we're using gnulib in earnest, any manual definition
would provoke a redefinition warning.
* fish/fish.c (_GNU_SOURCE): Don't define.
* fish/destpaths.c (_GNU_SOURCE): Likewise.
* src/guestfs.c (_GNU_SOURCE): Likewise.
* bootstrap (modules): Add asprintf, strchrnul, strerror, strndup
and vasprintf.
* fish/fish.c (main): Set argv[0] to sanitized program_name, so
functions like getopt_long that use argv[0] use the clean name.

13 years agoguestfish: diagnose stdout write failure
Jim Meyering [Fri, 21 Aug 2009 17:19:39 +0000 (19:19 +0200)]
guestfish: diagnose stdout write failure

Use gnulib's closeout module to ensure any failure to write to
stdout is detected and reported.
* fish/fish.c: Include "closeout.h".
(main): Call atexit (close_stdout);
* bootstrap (modules): Add closeout.

13 years agoguestfish: don't try to diagnose getopt failure
Jim Meyering [Mon, 24 Aug 2009 09:32:17 +0000 (11:32 +0200)]
guestfish: don't try to diagnose getopt failure

* fish/fish.c: ... getopt_long already does that.  Instead, suggest
"Try `guestfish --help' for more information."

13 years agoguestfish: write --help to stdout, use gnulib's progname module
Jim Meyering [Fri, 21 Aug 2009 17:05:20 +0000 (19:05 +0200)]
guestfish: write --help to stdout, use gnulib's progname module

* fish/fish.c: Include "progname.h".
(main): Call set_program_name to initialize.
Don't hard-code guestfish everywhere.  Use program_name.
However, be careful when modifying argv[0], since it is used
in the hopes that it is an absolute file name.
(usage): Don't spew all of --help for a mis-typed option.
Split long lines.

13 years agobuild: avoid some autoconf warnings
Jim Meyering [Mon, 24 Aug 2009 09:34:22 +0000 (11:34 +0200)]
build: avoid some autoconf warnings

* Move gl_EARLY and gl_INIT to be earlier.

13 years agoTodo: ntfsclone.
Richard Jones [Mon, 24 Aug 2009 10:45:49 +0000 (11:45 +0100)]
Todo: ntfsclone.

13 years agoAdd waitpid along guestfs_close path (RHBZ#518747).
Richard Jones [Sat, 22 Aug 2009 09:40:42 +0000 (10:40 +0100)]
Add waitpid along guestfs_close path (RHBZ#518747).

13 years agofish/: enable -Werror and all of gcc's warning options
Jim Meyering [Thu, 20 Aug 2009 11:56:47 +0000 (13:56 +0200)]
fish/: enable -Werror and all of gcc's warning options


13 years avoid signed/unsigned-comparison warning in fish/cmds.c
Jim Meyering [Fri, 21 Aug 2009 13:04:32 +0000 (15:04 +0200)] avoid signed/unsigned-comparison warning in fish/cmds.c

* src/ (emit_print_list_function): Emit code that doesn't
evoke warnings.  s/int/unsigned int/
(emit print_*_indent): Likewise, s/int/unsigned int/

13 years agodestpaths.c: avoid signed/unsigned-comparison warning
Jim Meyering [Fri, 21 Aug 2009 13:02:16 +0000 (15:02 +0200)]
destpaths.c: avoid signed/unsigned-comparison warning

* fish/destpaths.c (free_words): Change param type: s/int/size_t/.

13 years agofish.c: don't perform arithmetic on void* pointers
Jim Meyering [Fri, 21 Aug 2009 12:59:49 +0000 (14:59 +0200)]
fish.c: don't perform arithmetic on void* pointers

* fish/fish.c (xwrite): Use char*.

13 years agofish.c: avoid signed/unsigned-comparison warning
Jim Meyering [Fri, 21 Aug 2009 12:58:20 +0000 (14:58 +0200)]
fish.c: avoid signed/unsigned-comparison warning

* fish/fish.c (script): Change type of index to "unsigned int".

13 years agofish.c: avoid "assignment discards qualifiers..." warning
Jim Meyering [Fri, 21 Aug 2009 12:55:39 +0000 (14:55 +0200)]
fish.c: avoid "assignment discards qualifiers..." warning

* fish/fish.c (main): Cast-away-const.
* fish/fish.h (bad_cast): Define.  Safer than using an actual cast.

13 years agotilde.c: avoid a warning
Jim Meyering [Fri, 21 Aug 2009 12:50:23 +0000 (14:50 +0200)]
tilde.c: avoid a warning

* fish/tilde.c (find_home_for_username): Change param type: s/int/size_t/
(try_tilde_expansion): Adjust caller.

13 years agofish.c: avoid warnings
Jim Meyering [Fri, 21 Aug 2009 12:45:13 +0000 (14:45 +0200)]
fish.c: avoid warnings

* fish/rc.c (UNIX_PATH_MAX): Remove unused definition.
* fish/fish.h (rc_listen): Declare with __attribute__((noreturn)).

13 years agoedit.c: avoid warning about signed/unsigned comparison
Jim Meyering [Fri, 21 Aug 2009 12:41:49 +0000 (14:41 +0200)]
edit.c: avoid warning about signed/unsigned comparison

* fish/edit.c (load_file): Change type of param from int to size_t.
(do_edit): Adjust caller.

13 years agoRemove virt-v2v. New repo:
Richard Jones [Thu, 20 Aug 2009 15:28:35 +0000 (16:28 +0100)]
Remove virt-v2v.  New repo:

13 years agodaemon: diagnose socket write failure
Jim Meyering [Thu, 20 Aug 2009 10:29:46 +0000 (12:29 +0200)]
daemon: diagnose socket write failure

* daemon/proto.c (send_chunk): Don't ignore socket-write error.
* daemon/proto.c (send_file_end): Return "int", not void,
so we can propagate send_chunk failure to caller.
* daemon/daemon.h (send_file_end): Update prototype.
* daemon/tar.c (do_tar_out, do_tgz_out): Update uses of send_file_end.
* daemon/upload.c (do_download): Likewise.

13 years agotests: Found three more references to the squashfs, replaced with ISO.
Richard W.M. Jones [Wed, 19 Aug 2009 20:37:56 +0000 (21:37 +0100)]
tests: Found three more references to the squashfs, replaced with ISO.

13 years agotests: namemax on ISO devices is 255 1.0.68
Richard Jones [Wed, 19 Aug 2009 16:51:40 +0000 (17:51 +0100)]
tests: namemax on ISO devices is 255

Was 256 for the old squashfs device.

13 years agoCleanup initialisation of hash entries in
Matthew Booth [Wed, 19 Aug 2009 14:51:27 +0000 (15:51 +0100)]
Cleanup initialisation of hash entries in

13 years agotests: Use ISO instead of squashfs.
Richard Jones [Wed, 19 Aug 2009 14:09:27 +0000 (15:09 +0100)]
tests: Use ISO instead of squashfs.

The squashfs format changes too much.  Use an ISO file for
the tests instead.

13 years agomke2fs: Use e4fsprogs programs if available.
Richard W.M. Jones [Wed, 19 Aug 2009 13:03:35 +0000 (14:03 +0100)]
mke2fs: Use e4fsprogs programs if available.

On RHEL 5, mke2fs is ancient, and there is a non-standard "mke4fs"
binary which acts like the more recent mke2fs on Fedora.  Since there
are several annoyances and actual bugs in the ancient RHEL 5 mke2fs,
use mke4fs instead if it's available.

13 years agotests: modprobe fat instead of ext2 module.
Richard W.M. Jones [Wed, 19 Aug 2009 13:02:08 +0000 (14:02 +0100)]
tests: modprobe fat instead of ext2 module.

On RHEL 5, ext2 is compiled into the kernel, so trying to modprobe
it will fail.  I've checked that fat.ko is always a module on the
platforms we care about (RHEL 5, Fedora 11, Debian), so use that
to test instead.

13 years agotests: Conditionally skip UUID tests.
Richard W.M. Jones [Wed, 19 Aug 2009 13:01:13 +0000 (14:01 +0100)]
tests: Conditionally skip UUID tests.

More tests introduced which break with old e2fsprogs that didn't
support UUIDs.  Skip those tests when the old platform is

Also tidy up this code a little.

13 years agoavoid build failure due to Haskell keyword clash
Jim Meyering [Wed, 19 Aug 2009 12:30:02 +0000 (14:30 +0200)]
avoid build failure due to Haskell keyword clash

* src/ Fix this particular problem by
renaming the "module" parameter to "modulename".
Avoid the general problem by ensuring that no parameter name is
in the set of nearly all Haskell, OCaml and C reserved words.
(zfile): Adjust one more offender: s/method/meth/.

13 years agoExport inspect_linux_kernel in
Matthew Booth [Wed, 19 Aug 2009 11:52:16 +0000 (12:52 +0100)]
Export inspect_linux_kernel in

13 years agoAdd boot/grub_fs to output
Matthew Booth [Wed, 19 Aug 2009 10:42:46 +0000 (11:42 +0100)]
Add boot/grub_fs to output

If present, this gives the mount point of the filesystem which contains grub.
All entries in grub.conf will be relative to this filesystem.

13 years agoguestfish: detect more failed syscalls
Jim Meyering [Wed, 19 Aug 2009 08:01:07 +0000 (10:01 +0200)]
guestfish: detect more failed syscalls

* fish/fish.c (issue_command): Detect/diagnose more failed syscalls.

13 years agoPrepare for version 1.0.68.
Richard Jones [Wed, 19 Aug 2009 08:44:51 +0000 (09:44 +0100)]
Prepare for version 1.0.68.

13 years agoguestfs_launch: Correct checks for dup failure.
Richard Jones [Wed, 19 Aug 2009 08:37:44 +0000 (09:37 +0100)]
guestfs_launch: Correct checks for dup failure.

13 years agoUpdated PO files.
Richard Jones [Wed, 19 Aug 2009 08:10:24 +0000 (09:10 +0100)]
Updated PO files.

13 years agobuild: Comment out some unused macros.
Richard Jones [Wed, 19 Aug 2009 08:09:47 +0000 (09:09 +0100)]
build: Comment out some unused macros.

GCC 4.4.1 warns about some unused macros.  Comment these out
while they are not used.

13 years agobuild: new configure-time option: --enable-gcc-warnings
Jim Meyering [Tue, 18 Aug 2009 12:56:48 +0000 (14:56 +0200)]
build: new configure-time option: --enable-gcc-warnings

* Define/configure it.
* src/ Use new variables.

13 years agosuppress warnings from -Wmissing-noreturn
Jim Meyering [Tue, 18 Aug 2009 13:39:26 +0000 (15:39 +0200)]
suppress warnings from -Wmissing-noreturn

Even though these functions are marked as "not implemented yet",
and they will surely return a value once implemented, ...
* src/guestfs.c (select_add_timeout): Declare with noreturn attribute.
(select_remove_timeout): Likewise.

13 years agosuppress a warning from -Wswitch-default
Jim Meyering [Tue, 18 Aug 2009 13:35:32 +0000 (15:35 +0200)]
suppress a warning from -Wswitch-default

* src/guestfs.c (guestfs_end_busy): Add a "default:" label.

13 years agosuppress signed/unsigned-comparison warnings
Jim Meyering [Tue, 18 Aug 2009 13:32:40 +0000 (15:32 +0200)]
suppress signed/unsigned-comparison warnings

* src/guestfs.c [struct guestfs_h] (msg_in_size, msg_in_allocated):
(msg_out_size, msg_out_allocated): Change type from int to unsigned int.

13 years agobuild: don't perform arithmetic on void* pointers
Jim Meyering [Tue, 18 Aug 2009 13:23:35 +0000 (15:23 +0200)]
build: don't perform arithmetic on void* pointers

* src/guestfs.c (receive_file_data_sync, xread, xwrite): Use char*.

13 years suppress signed/unsigned-compare warnings
Jim Meyering [Tue, 18 Aug 2009 13:12:26 +0000 (15:12 +0200)] suppress signed/unsigned-compare warnings

* src/ (check_reply_header): Emit parameter declarations
that are unsigned, so as to avoid signed/unsigned-compare warnings.