12 years agoRemove separate, combine this with
Richard Jones [Thu, 31 Dec 2009 11:20:56 +0000 (11:20 +0000)]
Remove separate, combine this with

This commit combines the previously separate ""
program which generated bindings for virt-inspector.

Having two separate programs caused no end of troubles for developers,
so we now combine them into a single program.

NOTE: OCaml xml-light is now *required* in order to rebuild the
generated code.

12 years agogenerator: Comment and whitespace changes only.
Richard Jones [Thu, 31 Dec 2009 10:52:08 +0000 (10:52 +0000)]
generator: Comment and whitespace changes only.

12 years agodaemon: Work around udevsettle issue (RHBZ#548121).
Richard Jones [Fri, 18 Dec 2009 19:20:37 +0000 (19:20 +0000)]
daemon: Work around udevsettle issue (RHBZ#548121).

12 years agoPrepare for 1.0.80. 1.0.80
Richard Jones [Wed, 16 Dec 2009 11:53:48 +0000 (11:53 +0000)]
Prepare for 1.0.80.

12 years agoInclude latest Polish translations (Piotr Drąg, RHBZ#502533).
Richard Jones [Wed, 16 Dec 2009 11:57:51 +0000 (11:57 +0000)]
Include latest Polish translations (Piotr Drąg, RHBZ#502533).

12 years agoUpdate PO files.
Richard Jones [Wed, 16 Dec 2009 11:55:21 +0000 (11:55 +0000)]
Update PO files.

12 years agobuild: Fix typo in filename.
Richard Jones [Wed, 16 Dec 2009 11:54:53 +0000 (11:54 +0000)]
build: Fix typo in filename.

12 years agobuild: Remove references to old contrib/ files which were removed.
Richard Jones [Wed, 16 Dec 2009 11:53:30 +0000 (11:53 +0000)]
build: Remove references to old contrib/ files which were removed.

12 years agoappliance: Special case handling for libbfd in the supermin appliance.
Richard Jones [Wed, 16 Dec 2009 11:15:26 +0000 (11:15 +0000)]
appliance: Special case handling for libbfd in the supermin appliance.

The libbfd library has a constantly changing, non-standard and
very long name, eg:


Just add a special case to deal with this.  This fixes the guestfs_strings
command, which relies on the external strings binary which uses this

12 years agoappliance: Ignore unreadable dbus helper programs.
Richard Jones [Wed, 16 Dec 2009 11:04:10 +0000 (11:04 +0000)]
appliance: Ignore unreadable dbus helper programs.

12 years agolib: Link with $(LTLIBTHREAD), required by Gnulib lock module.
Richard Jones [Mon, 7 Dec 2009 11:28:21 +0000 (11:28 +0000)]
lib: Link with $(LTLIBTHREAD), required by Gnulib lock module.

This fixes commit cada248a53858341c91f70392e8f5b6e47d9b4fe.

12 years agoappliance: Fix code which gets list of kernels.
Matthew Booth [Fri, 4 Dec 2009 15:38:09 +0000 (15:38 +0000)]
appliance: Fix code which gets list of kernels.

The first 'ls' command was failing, so the second 'ls' command
would never run at all.

12 years agoaccommodate leading "+" in git submodule output
Jim Meyering [Fri, 4 Dec 2009 15:34:41 +0000 (15:34 +0000)]
accommodate leading "+" in git submodule output

* (_submodule_hash): Also filter out "+".
* Likewise.

12 years agolib: Add thread-safety to global list of handles.
Richard Jones [Fri, 4 Dec 2009 14:35:55 +0000 (14:35 +0000)]
lib: Add thread-safety to global list of handles.

This commit uses the Gnulib 'lock' module to implement a mutex on
the global list of handles which is stored by the library.

Note that Gnulib nicely avoids explicitly linking with -lpthread
unless the application program itself links to -lpthread.  Locks
are only enabled in multithreaded applications.

$ ldd src/.libs/ =>  (0x00007fffcb7ff000) => /lib64/ (0x00007f96a4e6c000)
/lib64/ (0x00007f96a544d000)

Please enter the commit message for your changes. Lines starting

12 years agodaemon error handling: Define a new function reply_with_perror_errno.
Richard Jones [Mon, 30 Nov 2009 14:11:20 +0000 (14:11 +0000)]
daemon error handling: Define a new function reply_with_perror_errno.

This allows you to save the errno from a previous call and
pass it to reply_with_perror.

For example, original code:

  r = some_system_call ();
  err = errno;
  do_cleanup ();
  errno = err;
  if (r == -1) {
    reply_with_perror ("failed");
    return -1;

can in future be changed to:

  r = some_system_call ();
  err = errno;
  do_cleanup ();
  if (r == -1) {
    reply_with_perror_errno (err, "failed");
    return -1;

12 years agodaemon error handling: recursive_mkdir shouldn't need to set errno.
Richard Jones [Fri, 27 Nov 2009 14:14:21 +0000 (14:14 +0000)]
daemon error handling: recursive_mkdir shouldn't need to set errno.

12 years agodaemon error handling: Clear errno before calling stub functions.
Richard Jones [Mon, 30 Nov 2009 13:55:04 +0000 (13:55 +0000)]
daemon error handling: Clear errno before calling stub functions.

This just ensures that we accurately report errors, even if our
error path code doesn't set errno.  We won't end up with a bogus
errno left over from a previous call.

12 years agoWhitespace change.
Richard Jones [Fri, 27 Nov 2009 13:42:43 +0000 (13:42 +0000)]
Whitespace change.

12 years agovirt-rescue: Freshen documentation.
Richard Jones [Thu, 26 Nov 2009 22:33:52 +0000 (22:33 +0000)]
virt-rescue: Freshen documentation.

12 years agoguestfish: Freshen documentation.
Richard Jones [Thu, 26 Nov 2009 22:32:15 +0000 (22:32 +0000)]
guestfish: Freshen documentation.

12 years agodaemon: Move prototypes around to keep functions grouped logically.
Richard Jones [Thu, 26 Nov 2009 15:38:48 +0000 (15:38 +0000)]
daemon: Move prototypes around to keep functions grouped logically.

12 years agoFix error handling in 'zero' function.
Richard Jones [Thu, 26 Nov 2009 16:06:03 +0000 (16:06 +0000)]
Fix error handling in 'zero' function.

12 years agodaemon/Win32: Add contributed test script to test daemon using Wine.
Richard Jones [Thu, 26 Nov 2009 15:17:37 +0000 (15:17 +0000)]
daemon/Win32: Add contributed test script to test daemon using Wine.

This test script allows you to test limited features of the
Windows daemon by running it on a standard Fedora host using

Read contrib/README and contrib/ in detail
before using.

12 years agoIgnore guestfsd.exe (Windows daemon).
Richard Jones [Thu, 26 Nov 2009 14:42:54 +0000 (14:42 +0000)]
Ignore guestfsd.exe (Windows daemon).

12 years agoRemove old contrib/febootstrap directory.
Richard Jones [Thu, 26 Nov 2009 14:34:35 +0000 (14:34 +0000)]
Remove old contrib/febootstrap directory.

12 years agoUpdate PO files.
Richard Jones [Thu, 26 Nov 2009 14:26:44 +0000 (14:26 +0000)]
Update PO files.

12 years agoMake realpath call optional, disable it for Windows.
Richard Jones [Thu, 26 Nov 2009 14:13:27 +0000 (14:13 +0000)]
Make realpath call optional, disable it for Windows.

12 years agobuild: update gnulib submodule to latest
Richard Jones [Thu, 26 Nov 2009 11:58:27 +0000 (11:58 +0000)]
build: update gnulib submodule to latest

12 years agodaemon: program_name must be defined for Gnulib error module.
Richard Jones [Thu, 26 Nov 2009 13:23:56 +0000 (13:23 +0000)]
daemon: program_name must be defined for Gnulib error module.

12 years agodaemon/Win32: use gnulib modules connect, socket and symlinkat (for readlinkat).
Richard Jones [Thu, 26 Nov 2009 11:52:28 +0000 (11:52 +0000)]
daemon/Win32: use gnulib modules connect, socket and symlinkat (for readlinkat).

12 years agodaemon/Win32: provide htonl, htons, ntohl, ntohs functions.
Richard Jones [Thu, 26 Nov 2009 11:26:40 +0000 (11:26 +0000)]
daemon/Win32: provide htonl, htons, ntohl, ntohs functions.

These functions are not available on Windows.

12 years agodaemon/Win32: Use Gnulib perror module.
Richard Jones [Thu, 26 Nov 2009 11:13:00 +0000 (11:13 +0000)]
daemon/Win32: Use Gnulib perror module.

12 years agodaemon: Link guestfs_protocol.[ch] into the daemon directory.
Richard Jones [Thu, 26 Nov 2009 11:01:01 +0000 (11:01 +0000)]
daemon: Link guestfs_protocol.[ch] into the daemon directory.

Instead of doing a recursive call into the src/ directory to build
the object files, hard link the source files into the daemon
directory and build them separately.


Thanks to Jim Meyering for noticing a typo in the original version.

12 years agodaemon: Typo generator_build -> generator_built
Richard Jones [Thu, 26 Nov 2009 10:52:37 +0000 (10:52 +0000)]
daemon: Typo generator_build -> generator_built

12 years agodaemon: Indent C macros to reflect nesting level.
Richard Jones [Thu, 26 Nov 2009 09:31:35 +0000 (09:31 +0000)]
daemon: Indent C macros to reflect nesting level.

12 years agodaemon/Win32: Win32 can't fork message moved to separate function (Jim Meyering)
Richard Jones [Thu, 26 Nov 2009 09:29:02 +0000 (09:29 +0000)]
daemon/Win32: Win32 can't fork message moved to separate function (Jim Meyering)

12 years agoguestfs documentation: Missing space.
Richard Jones [Wed, 25 Nov 2009 22:20:22 +0000 (22:20 +0000)]
guestfs documentation: Missing space.

12 years agoguestfs: Update architecture section of documentation.
Richard Jones [Wed, 25 Nov 2009 21:41:51 +0000 (21:41 +0000)]
guestfs: Update architecture section of documentation.

12 years agoUpdate PO files.
Richard Jones [Wed, 25 Nov 2009 17:12:00 +0000 (17:12 +0000)]
Update PO files.

12 years agodaemon: Fix build on Unix.
Richard Jones [Wed, 25 Nov 2009 17:10:33 +0000 (17:10 +0000)]
daemon: Fix build on Unix.

12 years agodaemon: Fix sync() call on Unix.
Richard Jones [Wed, 25 Nov 2009 16:54:46 +0000 (16:54 +0000)]
daemon: Fix sync() call on Unix.

12 years agodaemon/Win32: update comment
Richard Jones [Wed, 25 Nov 2009 16:33:00 +0000 (16:33 +0000)]
daemon/Win32: update comment

12 years agodaemon/Win32: Supply MAX macro for challenged platforms.
Richard Jones [Wed, 25 Nov 2009 15:00:19 +0000 (15:00 +0000)]
daemon/Win32: Supply MAX macro for challenged platforms.

12 years agodaemon/Win32: Windows can't daemonize.
Richard Jones [Wed, 25 Nov 2009 14:59:30 +0000 (14:59 +0000)]
daemon/Win32: Windows can't daemonize.

12 years agodaemon/Win32: Windows replacement for umask.
Richard Jones [Wed, 25 Nov 2009 14:56:42 +0000 (14:56 +0000)]
daemon/Win32: Windows replacement for umask.

12 years agodaemon/Win32: Replace setenv with Win32 equivalent.
Richard Jones [Wed, 25 Nov 2009 14:53:17 +0000 (14:53 +0000)]
daemon/Win32: Replace setenv with Win32 equivalent.

12 years agodaemon/Win32: Use xdr_u_int for PortableXDR compatibility.
Richard Jones [Wed, 25 Nov 2009 14:45:20 +0000 (14:45 +0000)]
daemon/Win32: Use xdr_u_int for PortableXDR compatibility.

PortableXDR didn't support xdr_uint32_t.  xdr_u_int is the same type.

12 years agodaemon/Win32: Don't bother blocking SIGPIPE on Win32.
Richard Jones [Wed, 25 Nov 2009 14:40:52 +0000 (14:40 +0000)]
daemon/Win32: Don't bother blocking SIGPIPE on Win32.

12 years agodaemon/Win32: Use gnulib getaddrinfo module.
Richard Jones [Wed, 25 Nov 2009 14:40:39 +0000 (14:40 +0000)]
daemon/Win32: Use gnulib getaddrinfo module.

12 years agodaemon/Win32: Implement statvfs using GetDiskFreeSpaceEx.
Richard Jones [Wed, 25 Nov 2009 13:07:05 +0000 (13:07 +0000)]
daemon/Win32: Implement statvfs using GetDiskFreeSpaceEx.

At the time of writing Gnulib didn't support Win32 for its
fsusage API.  Therefore this patch uses GetDiskFreeSpaceEx
if it's available (on Windows) otherwise falls back to using
Gnulib fsusage.

12 years agodaemon: Move statvfs code into separate file.
Richard Jones [Wed, 25 Nov 2009 12:24:01 +0000 (12:24 +0000)]
daemon: Move statvfs code into separate file.

This makes no functional change to the code.  It just moves the
statvfs-related code out of daemon/stat.c into a new file called

12 years agodaemon: Use gnulib futimens module.
Richard Jones [Wed, 25 Nov 2009 12:17:10 +0000 (12:17 +0000)]
daemon: Use gnulib futimens module.

Instead of checking for futimens support and falling back
(incorrectly in one case) to using futimes, use gnulib's

However the gnulib module does not yet support Win32, so
this change is only really useful on platforms like RHEL 5.

12 years agodaemon/Win32: Use gnulib pread module.
Richard Jones [Wed, 25 Nov 2009 11:59:20 +0000 (11:59 +0000)]
daemon/Win32: Use gnulib pread module.

12 years agosync: Windows implementation of sync() call.
Richard Jones [Wed, 25 Nov 2009 10:26:48 +0000 (10:26 +0000)]
sync: Windows implementation of sync() call.

Replace calls to sync() with calls to sync_disks() which supports
Win32 via FlushFileBuffers.

12 years agodaemon: Alternate implementation of posix_fallocate.
Richard Jones [Tue, 24 Nov 2009 16:16:08 +0000 (16:16 +0000)]
daemon: Alternate implementation of posix_fallocate.

If the posix_fallocate function is not available [ie. Windows]
use an alternate implementation that just loops and writes.

12 years agodd: Missing include of <string.h>
Richard Jones [Tue, 24 Nov 2009 16:10:13 +0000 (16:10 +0000)]
dd: Missing include of <string.h>

Breaks compilation on Windows.

12 years agodaemon/Windows: Define _WIN32_WINNT when compiling on Windows.
Richard Jones [Wed, 25 Nov 2009 11:38:44 +0000 (11:38 +0000)]
daemon/Windows: Define _WIN32_WINNT when compiling on Windows.

12 years agobuild: update gnulib submodule to latest
Richard Jones [Wed, 25 Nov 2009 16:24:49 +0000 (16:24 +0000)]
build: update gnulib submodule to latest

12 years agobuild: update gnulib submodule to latest
Richard Jones [Wed, 25 Nov 2009 15:29:39 +0000 (15:29 +0000)]
build: update gnulib submodule to latest

12 years agosupermin: Die with an error if no kernels found (RHBZ#539746).
Richard Jones [Tue, 24 Nov 2009 18:17:07 +0000 (18:17 +0000)]
supermin: Die with an error if no kernels found (RHBZ#539746).

Updated with a suggestion from Jim Meyering to use the '-d'
option to ls to avoid a future case of directories matching.

12 years agoNew tool: virt-list-filesystems
Richard Jones [Tue, 24 Nov 2009 15:19:08 +0000 (15:19 +0000)]
New tool: virt-list-filesystems

Use this program as a convenient way to list the filesystems
available in a disk image or libvirt guest.


  $ virt-list-filesystems /dev/vg_trick/Debian5x64

This is designed to make it easier for novices to use guestfish
and guestmount.  In particular with guestmount this acts as a way
to get a list of filesystems to use with the '-m' option.  ie:

  $ virt-list-filesystems unknowndisk.img
  $ guestmount -a unknowndisk.img -m /dev/sda1 /mnt

12 years agoavailability: Document how to check for single API calls
Richard Jones [Tue, 24 Nov 2009 14:27:56 +0000 (14:27 +0000)]
availability: Document how to check for single API calls

This documents how to use autotools and dlopen(3) to test for
the availability of single API calls at compile time and run time

12 years agoavailability: Add a test for this call.
Richard Jones [Tue, 24 Nov 2009 14:05:57 +0000 (14:05 +0000)]
availability: Add a test for this call.

Because all the tested groups are optional, there's not really
a group we can reliably test, therefore test against the
empty list (which should not fail).

12 years agoavailability: Clarify and fix documentation.
Richard Jones [Tue, 24 Nov 2009 14:00:34 +0000 (14:00 +0000)]
availability: Clarify and fix documentation.

12 years agogenerator: Passing "" to StringList tests should turn into empty list.
Richard Jones [Tue, 24 Nov 2009 14:04:28 +0000 (14:04 +0000)]
generator: Passing "" to StringList tests should turn into empty list.

This is a bug in the generator which wasn't being tickled.  If
you had a test which expected a StringList or DeviceList parameter,
and you passed "" to that test, then you'd (probably) expect to be
testing an empty list, but in fact you got a single element list
containing an empty string.  This fixes it so you get an empty list.

12 years agodaemon: Fix return value from aug_defnode.
Richard Jones [Tue, 24 Nov 2009 16:00:23 +0000 (16:00 +0000)]
daemon: Fix return value from aug_defnode.

Bug fix - the return value from this function was wrong
in the no-Augeas case.

12 years agoImplement 'dd' command.
Richard Jones [Sun, 22 Nov 2009 19:15:56 +0000 (19:15 +0000)]
Implement 'dd' command.

12 years agoUse STRPREFIX instead of STREQLEN.
Richard Jones [Sun, 22 Nov 2009 19:14:48 +0000 (19:14 +0000)]

12 years agogenerator: second parameter to upload is Dev_or_Path, not String.
Richard Jones [Sun, 22 Nov 2009 19:14:19 +0000 (19:14 +0000)]
generator: second parameter to upload is Dev_or_Path, not String.

12 years agobuild: Add missing dependencies in perl directory
Matthew Booth [Fri, 20 Nov 2009 18:45:22 +0000 (18:45 +0000)]
build: Add missing dependencies in perl directory

make all in the perl directory was missing a check that the library had been

make check in the perl directory was missing a check that the appliance and test
images had been built.

12 years agobuild: Ensure building appliance depends on guestfsd
Matthew Booth [Fri, 20 Nov 2009 18:43:20 +0000 (18:43 +0000)]
build: Ensure building appliance depends on guestfsd

Previously, only the rule checked the daemon had been built.
is called directly from within, so in that path the dependency was never
checked. This adds the daemon dependency explicitly to the rebuild-from-scratch

12 years agobuild: Don't re-check for each generator_built in daemon directory
Matthew Booth [Fri, 20 Nov 2009 18:05:49 +0000 (18:05 +0000)]
build: Don't re-check for each generator_built in daemon directory

12 years agobuild: Rebuild the daemon as necessary from other directories
Matthew Booth [Fri, 20 Nov 2009 17:52:27 +0000 (17:52 +0000)]
build: Rebuild the daemon as necessary from other directories

This change ensure that making the appliance will always rebuild the daemon if

12 years agoUpdate TODO file.
Richard Jones [Sat, 21 Nov 2009 21:11:44 +0000 (21:11 +0000)]
Update TODO file.

12 years agoperl: Add Sys::Guestfs::Lib::feature_available
Richard Jones [Fri, 20 Nov 2009 18:20:28 +0000 (18:20 +0000)]
perl: Add Sys::Guestfs::Lib::feature_available

This is a nicer Perl wrapper around $g->available call.

Update the other code in Sys::Guestfs::Lib to use it before using
LVM, Augeas.

12 years agoavailability: Skip tests when functions are not available.
Richard Jones [Fri, 20 Nov 2009 16:32:53 +0000 (16:32 +0000)]
availability: Skip tests when functions are not available.

12 years agoavailability: Add optional groups and implement guestfs_available call.
Richard Jones [Fri, 20 Nov 2009 14:10:06 +0000 (14:10 +0000)]
availability: Add optional groups and implement guestfs_available call.

The current groups are defined very conservatively using the
following criteria:
 (a) Would be impossible to implement on Windows because of
     sheer architectural differences (eg: mknod).
 (b) Already optional (augeas, inotify).
 (c) Not currently optional but not implemented on older RHEL and
     Debian releases (ntfs-3g.probe, scrub, zerofree).

The optional groups I've defined according to these criteria are:

 . augeas
 . inotify
 . linuxfsuuid
 . linuxmodules
 . linuxxattrs
 . lvm2
 . mknod
 . ntfs3g
 . scrub
 . selinux
 . zerofree

(Note that these choices don't prevent us from adding more
optional groups in future.  On the other hand to avoid breaking
ABIs we would not wish to change the above groups).

The rest of this large commit is really just implementation:

Each optional function is classified using Optional "group"
flag in the generator.

The daemon has to implement a function

  int optgroup_<name>_available (void);

for each optional group.  Some of these functions are fixed at
compile time, and some do simple run-time tests.

The do_available implementation in the daemon looks up the correct
function in a table and runs it.

We document the optional groups in the guestfs(3) man page.

Also: I added a NOT_AVAILABLE macro in order to unify all the
existing places where we had a message equivalent to
"function __func__ is not available".

12 years agoavailability: Add guestfs_available.
Richard Jones [Fri, 20 Nov 2009 13:06:49 +0000 (13:06 +0000)]
availability: Add guestfs_available.

Start a new API allowing groups of functions to be tested for

There are two reasons for this:

(1) If libguestfs is built with missing dependencies (eg. no Augeas lib)
then the corresponding functions are disabled in the appliance.  Up till
now there has been no way to test for this except to speculatively
issue commands and check for errors.

(2) When we port the daemon to Win32 it is likely that major pieces of
functionality won't be available (eg. LVM support).  This API gives
a way to test for that.

There is no change for existing clients: you still have to check for
errors from individual API calls.

For new clients, you will be able to test for availability of particular

Usage scenario (A): An LVM editing tool which requires
both the LVM API and inotify in order to function at all:

  char *apis[] = { "inotify", "lvm2", NULL };
  r = guestfs_available (g, apis);
  if (r == -1) {
    /* print an error and exit */

Usage scenario (B): A general purpose tool which optionally provides
configuration file editing, but this can be disabled, the result
merely being reduced functionality:

  char *apis[] = { "augeas", NULL };
  r = guestfs_available (g, apis);
  enable_config_edit_menus = r == 0;

12 years agodaemon/Win32: Use gnulib modules for first porting to Win32.
Richard Jones [Fri, 20 Nov 2009 11:48:51 +0000 (11:48 +0000)]
daemon/Win32: Use gnulib modules for first porting to Win32.

12 years agobuild: Add missing dependency>guestfs_protocol.h
Matthew Booth [Fri, 20 Nov 2009 16:48:38 +0000 (16:48 +0000)]
build: Add missing dependency>guestfs_protocol.h

12 years agobuild: correct sed transformation to work also on .git-module-status
Jim Meyering [Fri, 20 Nov 2009 15:25:00 +0000 (16:25 +0100)]
build: correct sed transformation to work also on .git-module-status

My patch was wrong.
I kept the sed transformation the same in the two places,
but it wasn't strict enough to also work on the file contents.
Sorry about that.  This fixes it.

>From 93927cc7b9f63c414e5bfeb7eba393fde3295601 Mon Sep 17 00:00:00 2001
From: Jim Meyering <>
Date: Fri, 20 Nov 2009 16:23:17 +0100
Subject: [PATCH libguestfs] build: correct sed transformation to work also on .git-module-status

* Use a more strict sed transformation so it works also
on the contents of .git-module-status, which has no prefix.
* (_submodule_hash): Use a stricter sed regexp.

12 years agobuild: make update .git-module-status, as it should
Jim Meyering [Fri, 20 Nov 2009 13:30:57 +0000 (14:30 +0100)]
build: make update .git-module-status, as it should

I ran, but then make was always failing like this:

    $ make *** gnulib update required; run ./ first.  Stop.

Here's the fix:

>From f743f32079fea2e8a17c7f5b59305e584c75dba0 Mon Sep 17 00:00:00 2001
From: Jim Meyering <>
Date: Fri, 20 Nov 2009 14:29:55 +0100
Subject: [PATCH libguestfs] build: make update .git-module-status, as it should

* Without this, "make" would always say "gnulib update
required; run ./ first", even after you'd run

12 years agomaint: use EXIT_* symbol (not constant, 2) to indicate key/path not found
Jim Meyering [Fri, 20 Nov 2009 11:18:06 +0000 (12:18 +0100)]
maint: use EXIT_* symbol (not constant, 2) to indicate key/path not found

* hivex/hivexget.c (EXIT_NOT_FOUND): Define.
(main): Use exit (EXIT_NOT_FOUND), not "exit (2)".

12 years agomaint: use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1 in "usage", too
Jim Meyering [Fri, 20 Nov 2009 11:15:14 +0000 (12:15 +0100)]
maint: use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1 in "usage", too

Convert by running these commands:
perl -pi -e 's/\b(usage ?)\(1\)/$1(EXIT_FAILURE)/' \
  fish/fish.c fuse/guestmount.c
perl -pi -e 's/\b(usage ?)\(0\)/$1(EXIT_SUCCESS)/' \
  fish/fish.c fuse/guestmount.c
* fish/fish.c (main): Replace 0/1 with EXIT_SUCCESS/EXIT_FAILURE.
* fuse/guestmount.c (main): Likewise.

12 years agomaint: use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1 to exit
Jim Meyering [Fri, 20 Nov 2009 11:09:42 +0000 (12:09 +0100)]
maint: use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1 to exit

Convert all uses automatically, via these two commands:
git grep -l '\<exit *(1)' \
  | grep -vEf .x-sc_prohibit_magic_number_exit \
  | xargs --no-run-if-empty \
    perl -pi -e 's/\b(exit ?)\(1\)/$1(EXIT_FAILURE)/'
git grep -l '\<exit *(0)' \
  | grep -vEf .x-sc_prohibit_magic_number_exit \
  | xargs --no-run-if-empty \
  perl -pi -e 's/\b(exit ?)\(0\)/$1(EXIT_SUCCESS)/'
* .x-sc_prohibit_magic_number_exit: New file.

Edit (RWMJ): Don't change Java code.

12 years agomaint: remove unnecessary include of openat.h
Jim Meyering [Fri, 20 Nov 2009 10:50:54 +0000 (11:50 +0100)]
maint: remove unnecessary include of openat.h

* daemon/realpath.c: Don't include "openat.h".  not used.

12 years agobuild: update gnulib submodule to latest
Richard Jones [Fri, 20 Nov 2009 10:44:38 +0000 (10:44 +0000)]
build: update gnulib submodule to latest

12 years agodaemon/gnulib: Include glob module.
Richard Jones [Fri, 20 Nov 2009 10:43:45 +0000 (10:43 +0000)]
daemon/gnulib: Include glob module.

12 years agodaemon/Win32: Don't include missing headers.
Richard Jones [Fri, 20 Nov 2009 10:41:07 +0000 (10:41 +0000)]
daemon/Win32: Don't include missing headers.

This is a partial fix for code in guestfsd.c where many of these
header files are missing on Win32.

12 years agodaemon/Win32: make some functions and fields optional.
Richard Jones [Fri, 20 Nov 2009 10:38:07 +0000 (10:38 +0000)]
daemon/Win32: make some functions and fields optional.

inotify: Make this optional on platforms that don't have this interface.

mknod, mkfifo etc.: Make these optional on non-Unix platforms.

readdir: If d_type field is missing on the platform, set the corresponding
field to 'u'.

stat: st_blocks and st_blksize are missing on non-Unix platforms, so
set these fields to -1 in the corresponding structures.

12 years agodaemon/Win32: NAME_MAX does not exist on Windows, use FILENAME_MAX instead.
Richard Jones [Fri, 20 Nov 2009 10:36:59 +0000 (10:36 +0000)]
daemon/Win32: NAME_MAX does not exist on Windows, use FILENAME_MAX instead.

12 years agodaemon: Missing #includes revealed by cross-compiling.
Richard Jones [Fri, 20 Nov 2009 10:36:21 +0000 (10:36 +0000)]
daemon: Missing #includes revealed by cross-compiling.

12 years agodaemon/Win32: Ignore mingw32-config.cache.
Richard Jones [Fri, 20 Nov 2009 10:33:27 +0000 (10:33 +0000)]
daemon/Win32: Ignore mingw32-config.cache.

The Fedora Windows cross-compiler 'mingw32-configure' script always
uses a configure cache.  Ignore that file.

12 years agogenerator: open Unix module by default.
Richard Jones [Thu, 19 Nov 2009 17:01:53 +0000 (17:01 +0000)]
generator: open Unix module by default.


  open Unix

at the top of the generator, which means that we don't need to
prefix any '' symbols (we can just use 'foo' instead).

Unfortunately the Unix module shadows one symbol in Pervasives
(the Pervasives module is opened by default in OCaml code).  That
symbol is 'stdout'.  So we replace this with 'Pervasives.stdout'
in two places.  Still a net reduction in code size.

12 years agosyntax-check: Fix tab-vs-space issue in the generator.
Richard Jones [Thu, 19 Nov 2009 16:59:56 +0000 (16:59 +0000)]
syntax-check: Fix tab-vs-space issue in the generator.

12 years agoUpdate PO files.
Richard Jones [Thu, 19 Nov 2009 16:50:19 +0000 (16:50 +0000)]
Update PO files.

12 years agoUpdate TODO file.
Richard Jones [Thu, 19 Nov 2009 16:50:04 +0000 (16:50 +0000)]
Update TODO file.

12 years agobuild: Fix parallel build of haskell bindings
Matthew Booth [Thu, 19 Nov 2009 16:10:01 +0000 (16:10 +0000)]
build: Fix parallel build of haskell bindings

ghc isn't clever enough not to stomp on itself when building dependencies. This
change makes the 1 dependency explicit.

It also adds a dependency on src/

12 years agobuild: Fix inter-directory dependencies
Matthew Booth [Thu, 19 Nov 2009 16:10:00 +0000 (16:10 +0000)]
build: Fix inter-directory dependencies

This change adds an explicit dependency on for every file it
generates, except java files. Java is left for another time because it's
considerably trickier.

It also adds a build rule for src/ so it can be rebuilt as required
from other directories.

It does this by creating a top level make file,, which can be
included from sub-directories. sub-directories need to define 'generator_built'
to include local files which are built by, and they will be updated

This fixes parallel make, and will automatically re-create generated files when
make is run from any directory.

It also fixes the problem which efad4f53 was targetting. Specifically,
src/guestfs_protocol.(c|h) had an erroneous dependency on stamp-generator, and
therefore, despite not being directly created by it. This caused
them to be recreated every time ran rather than only when
src/guestfs_protocol.x was updated, which cascaded into a daemon and therefore
appliance update.

This patch also changes the contents of the distribution tarball by including
files created by rpcgen.

12 years agogenerator: Acquire lock to prevent two parallel runs of the generator.
Richard Jones [Thu, 19 Nov 2009 13:48:59 +0000 (13:48 +0000)]
generator: Acquire lock to prevent two parallel runs of the generator.

This commit acquires a lock on a file to prevent two parallel runs of
the generator from stomping on each other.  The second run will wait
for the first to complete before starting.

The lock is acquired on the "HACKING" file because it's convenient --
we are already checking this file exists to make sure that we don't
start off in the wrong directory.

Tested by adding some artificial sleeps in the code to observe
locking behaviour between two parallel runs.