11 years agoexamples/to-xml.c: Don't depend on Gnulib function.
Richard Jones [Mon, 2 Nov 2009 14:30:54 +0000 (14:30 +0000)]
examples/to-xml.c: Don't depend on Gnulib function.

Since this program is just an example, it shouldn't require
the Gnulib c-ctype functions.

11 years agoappliance: Don't rebuild the appliance every time configure runs.
Richard Jones [Fri, 30 Oct 2009 17:11:02 +0000 (17:11 +0000)]
appliance: Don't rebuild the appliance every time configure runs.

config.status touches each time it runs, even if the
resulting script would not change.  This causes the appliance
to get rebuilt much more frequently than is necessary.

There's no way to stop configure running, but we can move the
config.status command into a Makefile rule to stop this
undesirable behaviour.

11 years agoguestfish: Fix a third indentation problem.
Richard Jones [Mon, 2 Nov 2009 16:15:14 +0000 (16:15 +0000)]
guestfish: Fix a third indentation problem.

11 years agoguestfish: Another indentation fix.
Richard Jones [Mon, 2 Nov 2009 16:06:23 +0000 (16:06 +0000)]
guestfish: Another indentation fix.

11 years agoguestfish: Fix printing of buffers in structs.
Richard Jones [Sat, 31 Oct 2009 13:40:12 +0000 (13:40 +0000)]
guestfish: Fix printing of buffers in structs.

Somehow an 'indent' string crept in there, so it was printing:


instead of:


11 years agoFix rstructs_used handling in guestfish generated code.
Richard Jones [Sat, 31 Oct 2009 13:38:14 +0000 (13:38 +0000)]
Fix rstructs_used handling in guestfish generated code.

rstructs_used wasn't correctly generating code for guestfish
because guestfish doesn't make all functions visible.  Since the
calculation of rstructs_used was over all functions (including
ones not available in guestfish) it could have generated
unnecessary functions.

In fact this error didn't affect us before - but I discovered
it when I added some extra struct-returning functions (future

11 years agodaemon: Don't warn on -Wunsafe-loop-optimizations.
Richard Jones [Sat, 31 Oct 2009 13:37:04 +0000 (13:37 +0000)]
daemon: Don't warn on -Wunsafe-loop-optimizations.

Ignore -Wunsafe-loop-optimizations, same as in the top level
configure file.

11 years agoAdd hivex* documentation to website.
Richard Jones [Thu, 29 Oct 2009 20:35:59 +0000 (20:35 +0000)]
Add hivex* documentation to website.

11 years agoAdd HTML documentation to website.
Richard Jones [Thu, 29 Oct 2009 20:33:27 +0000 (20:33 +0000)]
Add HTML documentation to website.

11 years agoPrepare for 1.0.76. 1.0.76
Richard Jones [Thu, 29 Oct 2009 20:06:47 +0000 (20:06 +0000)]
Prepare for 1.0.76.

11 years agoFix misspelling in previous commit.
Richard Jones [Thu, 29 Oct 2009 18:46:46 +0000 (18:46 +0000)]
Fix misspelling in previous commit.

11 years agoRHEL 5: Also add le{16,64}toh functions
Richard Jones [Thu, 29 Oct 2009 18:36:12 +0000 (18:36 +0000)]
RHEL 5: Also add le{16,64}toh functions

11 years agoRHEL 5: Detect endianness functions and supply them.
Richard Jones [Thu, 29 Oct 2009 17:54:48 +0000 (17:54 +0000)]
RHEL 5: Detect endianness functions and supply them.

11 years agoAdd virt-win-reg to toplevel, fix 1.0.75
Richard Jones [Thu, 29 Oct 2009 16:54:18 +0000 (16:54 +0000)]
Add virt-win-reg to toplevel, fix

11 years agoPrepare for version 1.0.75.
Richard Jones [Thu, 29 Oct 2009 16:44:09 +0000 (16:44 +0000)]
Prepare for version 1.0.75.

11 years agoSupport for Windows Registry.
Richard Jones [Mon, 26 Oct 2009 11:03:07 +0000 (11:03 +0000)]
Support for Windows Registry.

In hivex/:  This mini-library allows us to extract Windows
Registry binary files ("hives").

There are also two tools: hivexml converts a hive to a
self-describing XML format.  hivexget can be used to extract
single subkeys from a hive.

New tool: virt-win-reg.  This is a wrapper around the library
functionality allowing you to pull out data from the registries
of Windows guests.

11 years agoNew API: vfs_type - get the Linux VFS driver for a mounted device.
Richard Jones [Mon, 26 Oct 2009 14:26:36 +0000 (14:26 +0000)]
New API: vfs_type - get the Linux VFS driver for a mounted device.

11 years agoModify Sys::Guestfs::Lib::resolve_windows_path to use case_sensitive_path.
Richard Jones [Mon, 26 Oct 2009 09:12:12 +0000 (09:12 +0000)]
Modify Sys::Guestfs::Lib::resolve_windows_path to use case_sensitive_path.

11 years agoguestfish: Add win: prefix to use Windows paths.
Richard Jones [Mon, 26 Oct 2009 09:04:42 +0000 (09:04 +0000)]
guestfish: Add win: prefix to use Windows paths.

Add a win: prefix for path arguments in guestfish:

><fs> file win:c:\windows\system32\config\system.log
MS Windows registry file, NT/2000 or above

11 years agodaemon: Change chdir to use openat/fdopendir.
Richard Jones [Mon, 26 Oct 2009 13:00:46 +0000 (13:00 +0000)]
daemon: Change chdir to use openat/fdopendir.

Uses Gnulib implementation of openat which should be portable.

11 years agoNew API: case-sensitive-path to return case sensitive path on NTFS 3g fs
Richard Jones [Mon, 26 Oct 2009 08:20:00 +0000 (08:20 +0000)]
New API: case-sensitive-path to return case sensitive path on NTFS 3g fs

This function handles an annoyance/peculiarity of the Linux
NTFS 3g driver, which is that it exports NTFS filesystems with
names case sensitive, even though under Windows they would be
case insensitive.

This causes problems because the location of (eg.) c:\windows
might appear as /windows or /WINDOWS (etc) depending on the
inconsequential details of how it was originally created.

Example of this problem on a real Windows guest:

  ><fs> file /windows/system32/config/system.log
  libguestfs: error: file: access: /windows/system32/config/system.log: No such file or directory
  ><fs> case-sensitive-path /windows/system32/config/system.log
  ><fs> file /WINDOWS/system32/config/system.LOG
  MS Windows registry file, NT/2000 or above

11 years agoinspector: Remove inaccurate paragraph from documentation.
Richard Jones [Mon, 26 Oct 2009 09:30:38 +0000 (09:30 +0000)]
inspector: Remove inaccurate paragraph from documentation.

11 years agoInclude HFS (Mac OS X) driver.
Richard Jones [Sun, 25 Oct 2009 21:43:37 +0000 (21:43 +0000)]
Include HFS (Mac OS X) driver.

11 years agoSet LC_ALL=C before running qemu.
Richard Jones [Wed, 21 Oct 2009 15:31:26 +0000 (16:31 +0100)]
Set LC_ALL=C before running qemu.

11 years agoinit: Check that start_udev succeeded
Matthew Booth [Wed, 21 Oct 2009 09:16:50 +0000 (10:16 +0100)]
init: Check that start_udev succeeded

If start_udev fails for any reason, notice and fall through to manual /dev

Patch from Charles Duffy <>

11 years agoVersion 1.0.74. 1.0.74
Richard Jones [Tue, 20 Oct 2009 14:37:40 +0000 (15:37 +0100)]
Version 1.0.74.

11 years agoTab to space fixes, now passes 'make syntax-check'
Richard Jones [Tue, 20 Oct 2009 14:03:16 +0000 (15:03 +0100)]
Tab to space fixes, now passes 'make syntax-check'

11 years agoguestfs_find: Fix memory leak of sysrootdir.
Richard Jones [Tue, 20 Oct 2009 09:19:21 +0000 (10:19 +0100)]
guestfs_find: Fix memory leak of sysrootdir.

11 years agovirt-ls: Modify to use find0 instead of find.
Richard Jones [Mon, 19 Oct 2009 16:59:00 +0000 (17:59 +0100)]
virt-ls: Modify to use find0 instead of find.

find0 is more scalable than find.  virt-ls will no longer
crash if asked to recursively list / on a Linux guest.

11 years agoNew API: find0 (unlimited version of find)
Richard Jones [Mon, 19 Oct 2009 16:44:16 +0000 (17:44 +0100)]
New API: find0 (unlimited version of find)

This adds a new API call guestfs_find0, which is like guestfs_find
but mainly doesn't suffer from the protocol limit of the earlier
command.  The earlier command is not deprecated because it is
still very useful.

guestfs_find0 uses a FileOut parameter and writes the results to
an external file.  The filenames in the output are separated by
ASCII NUL characters (so a bit like "find -print0").

There is also the addition of a regression test for this command.

11 years agoguestfs_find: Document protocol limits for this API call.
Richard Jones [Mon, 19 Oct 2009 15:57:54 +0000 (16:57 +0100)]
guestfs_find: Document protocol limits for this API call.

guestfs_find has to send the complete list of files in a single
protocol message (hence, limited to 2-4 MB).  Unfortunately on
a typical Linux guest, guestfs_find ("/") will exceed this limit
resulting in an error.

Therefore we should add an unlimited version of this call in a
future commit.  This commit just documents the current limit.

11 years agoNew tool: virt-ls
Richard Jones [Mon, 19 Oct 2009 11:16:00 +0000 (12:16 +0100)]
New tool: virt-ls

This tool makes available the functionality of "ls", "ll", and "find"
in a slightly simpler to use form.


  virt-ls -l myguest /tmp

11 years agoNew tool: virt-tar
Richard Jones [Mon, 19 Oct 2009 10:49:20 +0000 (11:49 +0100)]
New tool: virt-tar

This adds a new tool call virt-tar which is a general purpose
archive and uploading tool.  It doesn't add any functionality
which wasn't previously possible using guestfish, but makes it
simpler to access for some users.


 virt-tar -zx myguest /home home.tar.gz
 virt-tar -zu myguest uploadstuff.tar.gz /tmp

11 years agotools: Make warnings about running on live guests more prominent.
Richard Jones [Mon, 19 Oct 2009 09:45:44 +0000 (10:45 +0100)]
tools: Make warnings about running on live guests more prominent.

Add prominent warnings to the man pages about how it is dangerous
to run these tools against live guests.

11 years agoMove virt tools (virt-cat, virt-edit etc) into tools/ subdirectory.
Richard Jones [Mon, 19 Oct 2009 09:18:46 +0000 (10:18 +0100)]
Move virt tools (virt-cat, virt-edit etc) into tools/ subdirectory.

This moves the tool programs into a single directory:
  cat/* -> tools/virt-cat
  df/* -> tools/virt-df
  edit/* -> tools/virt-edit
  rescue/* -> tools/virt-rescue

This in itself simplifies the build process because we only need
one Makefile and one copy of 'run-locally'.

'run-*-locally' has become just 'run-locally' and takes an extra
parameter which is the name of the tool, eg:
  run-locally cat [virt-cat params...]

virt-inspector stays in its own directory, because this contains
more than just a single Perl script.

11 years agoComment: Describe the build order requirements for toplevel directories.
Richard Jones [Mon, 19 Oct 2009 08:10:15 +0000 (09:10 +0100)]
Comment: Describe the build order requirements for toplevel directories.

11 years agoPrepare for 1.0.73. 1.0.73
Richard Jones [Wed, 14 Oct 2009 10:24:52 +0000 (11:24 +0100)]
Prepare for 1.0.73.

11 years agoAdd some missing EXTRA_DIST files.
Richard Jones [Wed, 14 Oct 2009 10:24:33 +0000 (11:24 +0100)]
Add some missing EXTRA_DIST files.

11 years agoinspector: Generate language bindings for OCaml.
Richard Jones [Fri, 2 Oct 2009 14:42:14 +0000 (15:42 +0100)]
inspector: Generate language bindings for OCaml.

This commit adds a generic mechanism for deriving language bindings
for virt-inspector, and implements one concrete binding, for OCaml.

The bindings are generated from the RELAX NG schema (virt-inspector.rng)
which is supposed to be a correct and always up to date description
of the XML that the virt-inspector program can generate.

From the RNG we generate a set of types to describe the output of
virt-inspector for the language, plus an XML parser, plus some
glue code to actually run an external instance of virt-inspector
and parse the resulting XML.

At runtime, an external 'virt-inspector --xml <name>' command runs
and the XML is parsed into language-specific structures.

This has been tested on the four example files (inspector/example?.xml)

The only particular difficulty about the OCaml binding is the use of
Obj.magic, which is naughty but works because of the isomorphism
between the representation of tuples and records in OCaml.  This
seems to cause no problems in my test program.  Apart from this, the
OCaml binding is straightforward and could be adapted easily for any
other languages that want type-safe virt-inspector bindings.

It's important to keep virt-inspector.rng up to date with changes
to virt-inspector's XML output format.

11 years agobuild: avoid parallel ocaml/... build failure
Jim Meyering [Mon, 5 Oct 2009 10:25:15 +0000 (12:25 +0200)]
build: avoid parallel ocaml/... build failure

A parallel build could fail due to the use in ocaml/examples
of ocaml/guestfs.cmi before it was built.
* (SUBDIRS): Add both ocaml and ocaml/examples,
to ensure they're built in this order, and not in parallel.
* ocaml/ (SUBDIRS): Don't define.

11 years agoUpdated Polish translation
Piotr Drąg [Mon, 5 Oct 2009 11:20:53 +0000 (12:20 +0100)]
Updated Polish translation

11 years agoinspector: Fix inspector/
Richard Jones [Thu, 1 Oct 2009 15:59:28 +0000 (16:59 +0100)]
inspector: Fix inspector/

Accidentally pushed the older version of the patch in
commit 9d25e82491ddcf495e1d30694327e4bfd3a23445.

This includes Jim Meyering's suggested changes from

11 years agobuild: fix compile error
Jim Meyering [Fri, 2 Oct 2009 14:09:19 +0000 (16:09 +0200)]
build: fix compile error

Link demo scripts with just-build library, not the installed one.
* ocaml/examples/ (OCAMLFINDFLAGS): New variable.
(lvs, viewer): Use it.
This fix is based on a suggestion from Rich Jones.
This addresses RHBZ#526917.

11 years agoinspector: Add tests for RELAX NG schema.
Richard Jones [Thu, 1 Oct 2009 15:59:28 +0000 (16:59 +0100)]
inspector: Add tests for RELAX NG schema.

11 years agoinspector: Add RELAX NG schema for virt-inspector --xml output.
Richard Jones [Thu, 1 Oct 2009 15:58:38 +0000 (16:58 +0100)]
inspector: Add RELAX NG schema for virt-inspector --xml output.

11 years agoconfigure: Update comment about
Richard Jones [Fri, 2 Oct 2009 08:51:06 +0000 (09:51 +0100)]
configure: Update comment about

11 years agoinspector: Canonicalize device names (fix RHBZ#526717).
Richard Jones [Thu, 1 Oct 2009 15:06:17 +0000 (16:06 +0100)]
inspector: Canonicalize device names (fix RHBZ#526717).

Make filesystem device names canonical, so they are /dev/sd*
instead of /dev/vd*.

11 years agorun-*-locally: The programs are now virt-[tool], not virt-[tool].pl
Richard Jones [Thu, 1 Oct 2009 14:22:12 +0000 (15:22 +0100)]
run-*-locally: The programs are now virt-[tool], not virt-[tool].pl

This fixes commit b488436cc54288fcae8988493749f2e6c87f274c.

11 years agoinspector: Don't bomb if no kernels detected.
Richard Jones [Thu, 1 Oct 2009 14:20:14 +0000 (15:20 +0100)]
inspector: Don't bomb if no kernels detected.

If $os->{kernels} wasn't defined, virt-inspector would exit with
an error, leaving partial XML output.

Change the code so it doesn't die in this case, instead just
leaves out the <kernels> section.

11 years agoOCaml viewer: Use ocamlduce to replace xpath code.
Richard Jones [Wed, 30 Sep 2009 14:32:41 +0000 (15:32 +0100)]
OCaml viewer: Use ocamlduce to replace xpath code.

11 years agoOCaml viewer: Handle exceptions properly.
Richard Jones [Tue, 29 Sep 2009 10:56:26 +0000 (11:56 +0100)]
OCaml viewer: Handle exceptions properly.

11 years agoOCaml example: graphical disk usage viewer.
Richard Jones [Sat, 26 Sep 2009 11:45:37 +0000 (12:45 +0100)]
OCaml example: graphical disk usage viewer.

This is an example of how to write an app which uses libguestfs
and libvirt, and has a responsive user interface (using threads).
It is a Gtk-based "graphical virt-df".

Read the top of the '' file first for instructions on
how to compile.  This program is not compiled by default.

11 years agovirt-df: Add note about parsing CSV.
Richard Jones [Thu, 24 Sep 2009 10:22:17 +0000 (11:22 +0100)]
virt-df: Add note about parsing CSV.

11 years agoavoid use of all ctype macros
Jim Meyering [Thu, 24 Sep 2009 08:59:01 +0000 (10:59 +0200)]
avoid use of all ctype macros

* (disable_temporarily): Don't disable sc_avoid_ctype_macros.
* fish/tilde.c: Remove unnecessary inclusion of ctype.h.
* bootstrap: Add gnulib's c-ctype module to the list.
* daemon/m4/gnulib-cache.m4: Likewise.
* daemon/ext2.c: Include "c-ctype.h", not <ctype.h>.
Use c_isspace, etc, rather than isspace.
* daemon/guestfsd.c: Likewise.
* daemon/lvm.c: Likewise.
* daemon/proto.c: Likewise.
* fish/fish.c: Likewise.
* fish/tilde.c: Likewise.
* src/ Likewise.
* src/guestfs.c: Likewise.
* examples/to-xml.c: Likewise.
* examples/ (to_xml_CPPFLAGS): Add -I$(top_srcdir)/gnulib/lib
so inclusion of "c-ctype.h" works.
(to_xml_CPPFLAGS): Rename from to_xml_CFLAGS.

11 years agomaint: prune dead wood from list of skipped syntax-check rules
Jim Meyering [Thu, 24 Sep 2009 07:34:53 +0000 (09:34 +0200)]
maint: prune dead wood from list of skipped syntax-check rules

* (local-checks-to-skip): Remove now-passing and
no-longer-relevant rule names.

11 years agomaint: use spaces, not TABs for indentation
Jim Meyering [Thu, 24 Sep 2009 07:24:55 +0000 (09:24 +0200)]
maint: use spaces, not TABs for indentation

"make syntax-check" was failing.  This fixes it.
* HACKING: Indent with spaces, not TABs.
* Likewise.
* rescue/virt-rescue: Likewise.
* src/ Likewise.

11 years agoPrepare for 1.0.72. 1.0.72
Richard Jones [Wed, 23 Sep 2009 12:49:46 +0000 (13:49 +0100)]
Prepare for 1.0.72.

Also update PO files.

11 years agoMore HTMLFILES.
Richard Jones [Wed, 23 Sep 2009 13:23:47 +0000 (14:23 +0100)]

11 years agoInclude virt tools in EXTRA_DIST.
Richard Jones [Wed, 23 Sep 2009 13:01:28 +0000 (14:01 +0100)]
Include virt tools in EXTRA_DIST.

Partially revert b488436cc54288fcae8988493749f2e6c87f274c.
It turns out that automake doesn't automatically place bin_SCRIPTS

11 years agoRename virt-[tool].pl as virt-[tool]
Richard Jones [Wed, 23 Sep 2009 11:37:26 +0000 (12:37 +0100)]
Rename virt-[tool].pl as virt-[tool]

11 years agoCheck return value from readlink.
Richard Jones [Wed, 23 Sep 2009 11:09:26 +0000 (12:09 +0100)]
Check return value from readlink.

11 years agoCreate manpage atomically.
Richard Jones [Wed, 23 Sep 2009 11:05:55 +0000 (12:05 +0100)]
Create manpage atomically.

Don't fail with a partial file if disk full, etc.

11 years agoReplace @...@ with $(...) in these common files.
Richard Jones [Wed, 23 Sep 2009 11:04:25 +0000 (12:04 +0100)]
Replace @...@ with $(...) in these common files.

11 years agoguestfish: Update 'SEE ALSO' section of the manpage.
Richard Jones [Wed, 23 Sep 2009 10:50:49 +0000 (11:50 +0100)]
guestfish: Update 'SEE ALSO' section of the manpage.

11 years agoNew tool: virt-edit
Richard Jones [Wed, 23 Sep 2009 10:12:05 +0000 (11:12 +0100)]
New tool: virt-edit

Edit any file in a guest.  This was possibly previously
using guestfish, but having a separate command makes it

The usage is simply:

  virt-edit mydomain /some/file

It runs $EDITOR or vi on the file, and if the user changes
it, uploads the result back to the VM.

11 years agovirt-cat: Remove some unused Perl module includes.
Richard Jones [Wed, 23 Sep 2009 10:11:21 +0000 (11:11 +0100)]
virt-cat: Remove some unused Perl module includes.

11 years agoAdd 'virt-rescue' command.
Richard Jones [Tue, 22 Sep 2009 18:50:21 +0000 (19:50 +0100)]
Add 'virt-rescue' command.

This command runs a "rescue appliance" against a virtual machine
or disk image.  This is useful for making ad-hoc interactive
changes to virtual machines.

  $ virt-rescue --ro /dev/vg_trick/F11x64

  Welcome to virt-rescue, the libguestfs rescue shell.

  Note: The contents of / are the rescue appliance.
  You have to mount the guest's partitions under /sysroot
  before you will be able to examine them.

  bash: cannot set terminal process group (-1): Inappropriate ioctl for device
  bash: no job control in this shell
  ><rescue> mount /dev/vg_f11x64/lv_root /sysroot
  EXT4-fs (dm-0): barriers enabled
  kjournald2 starting: pid 269, dev dm-0:8, commit interval 5 seconds
  EXT4-fs (dm-0): internal journal on dm-0:8
  EXT4-fs (dm-0): delayed allocation enabled
  EXT4-fs: file extents enabled
  EXT4-fs: mballoc enabled
  EXT4-fs (dm-0): mounted filesystem with ordered data mode
  ><rescue> ls /sysroot/
  bin   dev  home  lib64       media  opt   root  selinux  sys  usr
  boot  etc  lib   lost+found  mnt    proc  sbin  srv      tmp  var
  ><rescue> exit

11 years agoAdd direct appliance mode flag and implementation.
Richard Jones [Tue, 22 Sep 2009 18:52:56 +0000 (19:52 +0100)]
Add direct appliance mode flag and implementation.

When the g->direct flag is set, the appliance stdin/stdout
are not connected to the library.  Instead they inherit the
stdin/stdout of the caller.

This is used to implement virt-rescue.

11 years agoTidy up appliance rescue code.
Richard Jones [Tue, 22 Sep 2009 18:51:47 +0000 (19:51 +0100)]
Tidy up appliance rescue code.

The appliance shouldn't run the daemon after we leave the
rescue shell.  It should just exit instead.

11 years agoRejig tests for qemu vmchannel support.
Richard Jones [Tue, 22 Sep 2009 12:34:50 +0000 (13:34 +0100)]
Rejig tests for qemu vmchannel support.

vmchannel is no longer required, so we shouldn't test for it.
However we should test instead for user mode networking support.

Also fix up the documentation / error messages.

Always test for vmchannel and user mode networking support in
qemu.  This gives us more troubleshooting information if people
report bugs.

11 years agoPrepare for 1.0.71. 1.0.71
Richard Jones [Tue, 22 Sep 2009 11:12:56 +0000 (12:12 +0100)]
Prepare for 1.0.71.

Update version number and update PO files.

Put latest version and release date on the website front page.

11 years agoChange handling of spaces on Linux kernel command line.
Richard Jones [Tue, 22 Sep 2009 09:41:05 +0000 (10:41 +0100)]
Change handling of spaces on Linux kernel command line.

11 years agoUpdate documentation of qemu / vmchannel.
Richard Jones [Mon, 21 Sep 2009 14:34:21 +0000 (15:34 +0100)]
Update documentation of qemu / vmchannel.

11 years agoImplement "null vmchannel" - no vmchannel needed!
Richard Jones [Mon, 21 Sep 2009 14:27:20 +0000 (15:27 +0100)]
Implement "null vmchannel" - no vmchannel needed!

This commit removes the requirement for vmchannel, although retaining
support for it.

In this configuration, known as "null vmchannel", the library
listens on a random loopback port.  It passes the number of this
port to the appliance (guestfs_vmchannel=tcp:, and
the daemon then connects back.  The library, instead of connecting,
listens and accepts the connection during guestfs_launch.

QEMU SLIRP (user mode networking) is still required to make this
work: SLIRP forwards the TCP connection transparently (instead of
explicitly as with guestfwd) to<port>

There is a window in which any other local process on the machine
could see the port number in the qemu command line and try to
connect to it.  This would be a devastating security hole, because
any local process could pretend to be the daemon and feed back
malicious replies to our remote procedure calls.  To prevent this,
we check the UID of the other side of the TCP connection.  If
the UID is different from the library's EUID, then we reject the
connection.  To do this we have to parse /proc/net/tcp.  (On Solaris
we could use getsockopt (SO_PEERCRED), but this doesn't work on
Linux TCP sockets).

Other vmchannel(s) are still supported.  This is important, because
we can't in general be sure the qemu will always support SLIRP.
In particular, in recent versions of qemu it is possible to compile
out SLIRP.

11 years agoGnulib: Add arpa-inet and netinet-in modules.
Richard Jones [Mon, 21 Sep 2009 14:27:02 +0000 (15:27 +0100)]
Gnulib: Add arpa-inet and netinet-in modules.

11 years agoFlexible guestfs_vmchannel parameter for future appliances.
Richard Jones [Mon, 21 Sep 2009 12:03:27 +0000 (13:03 +0100)]
Flexible guestfs_vmchannel parameter for future appliances.

This reimplements parts of commit da0a4f8d1f6ddd302ceba028d87c6e009589e503
in a different, but compatible way.

We pass guestfs_vmchannel=tcp:<ip>:<port> on the command line.  This
is intended to be used as follows (now and in future versions):

  tcp:    for guestfwd vmchannel
  tcp:<port>  for future "no vmchannel" implementation
  /dev/vcon4           for future virtio-console vmchannel*

It also accepts the old-style guestfs= parameter which
is sent by older libraries, and turns this transparently into the
correct format above.

If no guestfs_vmchannel is passed, then this defaults to the guestfwd
vmchannel which older libraries would expect.

* Maybe this last one should be dev:/dev/vcon4 or file:/dev/vcon4, but
we don't need to decide that now.

11 years agoRearrange and tidy up code in guestfsd.c
Richard Jones [Mon, 21 Sep 2009 11:32:25 +0000 (12:32 +0100)]
Rearrange and tidy up code in guestfsd.c

This just tidies up the main() function in the daemon.  There is
no longer a huge fixed-sized buffer used for the kernel command
line.  Variables are moved closer to where they are used.  Some
local variables turned out to be unused - these are removed.  Finally
the part that reads the kernel command line is moved into a separate

There is only minimal functional change here (it now prints out
the kernel command line).

Literal '4' replaced with 'sizeof' expression, at Jim Meyering's
suggestion during patch review.

11 years agoMake GUESTFWD_PORT into a string.
Richard Jones [Mon, 21 Sep 2009 11:11:51 +0000 (12:11 +0100)]
Make GUESTFWD_PORT into a string.

11 years agoRemove unnecessary extra space from qemu command line.
Richard Jones [Mon, 21 Sep 2009 11:11:01 +0000 (12:11 +0100)]
Remove unnecessary extra space from qemu command line.

11 years agoRemove guestfs_wait_ready (turn it into a no-op).
Richard Jones [Mon, 21 Sep 2009 10:52:53 +0000 (11:52 +0100)]
Remove guestfs_wait_ready (turn it into a no-op).

This commit changes guestfs_launch so that it both launches
the appliance and waits until it is ready (ie. the daemon communicates
back to us).

Since we removed the pretence that we could implement a low-level
asynchronous API, the need to call launch() followed by wait_ready()
has looked a bit silly.

Now guestfs_wait_ready() is basically a no-op.  It is left in the
API for backwards compatibility.  Any calls to guestfs_wait_ready()
can be removed from client code.

11 years agoCombine temporary buffers.
Richard Jones [Mon, 21 Sep 2009 11:01:11 +0000 (12:01 +0100)]
Combine temporary buffers.

buf[], append[] and memsize_str[] were all temporary buffers
used in non-overlapping code.

Combine them to use a single buffer (buf[]).

11 years agoRearrange qemu command line order (no functional change).
Richard Jones [Mon, 21 Sep 2009 10:07:47 +0000 (11:07 +0100)]
Rearrange qemu command line order (no functional change).

11 years agoEnable new-style -chardev ... guestfwd command line.
Richard Jones [Fri, 18 Sep 2009 13:06:07 +0000 (14:06 +0100)]
Enable new-style -chardev ... guestfwd command line.

Newer versions of qemu have changed the command line format
(again).  '-net channel' is now deprecated.  Instead we use:

    -chardev socket,id=guestfsvmc,path=/path/to/sock,server,nowait
    -net user,vlan=0,net=,guestfwd=tcp:
    -net nic,model=ne2k_pci,vlan=0

The old style format is still used if the new style is not
detected at runtime.

11 years agoFix code which looked for leaked FDs between each command.
Richard Jones [Thu, 17 Sep 2009 15:44:20 +0000 (16:44 +0100)]
Fix code which looked for leaked FDs between each command.

This code was not checking the return value from system()
so it failed if uncommented.  Add ignore_value() around the
call to system.  However, leave the code still disabled.

11 years agoRemove explicit guestfs= kernel command line parameter.
Richard Jones [Tue, 15 Sep 2009 16:14:44 +0000 (17:14 +0100)]
Remove explicit guestfs= kernel command line parameter.

Since we control the appliance tightly, we can just specify
that it will always use a particular host and port, and we
don't need to pass it on the command line each time.

Also the VMCHANNEL_* constants are only relevant to the
particular guestfwd vmchannel implementation, so we rename
them as GUESTFWD_*.

11 years agoDaemon: fix handling of errors from xread and xwrite.
Richard Jones [Thu, 17 Sep 2009 14:28:41 +0000 (15:28 +0100)]
Daemon: fix handling of errors from xread and xwrite.

If xread or xwrite returns -1, that indicates an error and we
should exit.  Note that xread/xwrite has already printed the
error message.

11 years agoFix verbose packet dumping functions.
Richard Jones [Thu, 17 Sep 2009 13:50:04 +0000 (14:50 +0100)]
Fix verbose packet dumping functions.

Add the configure parameter --enable-packet-dump so that this
code can be enabled without editing the source.

This code is normally commented out, because it is too verbose
unless you happen to be debugging the underlying protocol.  Because
it is normally commented out, I found it had bit-rotted slightly.
This commit also fixes the obvious problems.

11 years ago'len' should be an unsigned 32 bit int.
Richard Jones [Thu, 17 Sep 2009 13:49:06 +0000 (14:49 +0100)]
'len' should be an unsigned 32 bit int.

This only happened to work by accident before because 'unsigned len'
happens to be 32 bit on all platforms we support.

11 years agoDisable -Wunsafe-loop-optimizations
Richard Jones [Thu, 17 Sep 2009 13:39:42 +0000 (14:39 +0100)]
Disable -Wunsafe-loop-optimizations

This warning indicates that GCC could not do a particular sort
of loop optimization.  It pops up randomly in certain forms of
looping code, and seems safe to ignore.

11 years agoUpdate PO files (no functional change).
Richard Jones [Tue, 15 Sep 2009 16:13:24 +0000 (17:13 +0100)]
Update PO files (no functional change).

11 years agoPrepare for version 1.0.70. 1.0.70
Richard Jones [Tue, 15 Sep 2009 10:13:54 +0000 (11:13 +0100)]
Prepare for version 1.0.70.

11 years agoUpdate PO files.
Richard Jones [Tue, 15 Sep 2009 10:12:45 +0000 (11:12 +0100)]
Update PO files.

11 years agoSet minimum gettext version to 0.17.
Richard Jones [Tue, 15 Sep 2009 10:10:20 +0000 (11:10 +0100)]
Set minimum gettext version to 0.17.

This fixes the problem that the 1.0.69 tarball would fail in
the po/ subdirectory when installing:

make[1]: Entering directory `/builddir/build/BUILD/libguestfs-1.0.69/po'
/bin/sh @MKINSTALLDIRS@ /builddir/build/BUILDROOT/libguestfs-1.0.69-1.fc11.x86_64/usr/share
/bin/sh: @MKINSTALLDIRS@: No such file or directory
make[1]: Leaving directory `/builddir/build/BUILD/libguestfs-1.0.69/po'

RHEL 5.3 has gettext 0.14.6.  However the tarball will still
build (since it includes all the required code).  This may cause
a problem if RHEL users want to build from the git repository.

11 years agoFix comparison between signed and unsigned (for RHEL 5). 1.0.69
Richard Jones [Tue, 15 Sep 2009 08:23:49 +0000 (09:23 +0100)]
Fix comparison between signed and unsigned (for RHEL 5).

11 years agoMove decl out for C99 compliance.
Richard Jones [Mon, 14 Sep 2009 19:14:47 +0000 (20:14 +0100)]
Move decl out for C99 compliance.

11 years agoUpdate PO files.
Richard Jones [Mon, 14 Sep 2009 18:35:58 +0000 (19:35 +0100)]
Update PO files.

11 years agoMove guestfs-internal-actions.h to EXTRA_DIST.
Richard Jones [Mon, 14 Sep 2009 18:35:46 +0000 (19:35 +0100)]
Move guestfs-internal-actions.h to EXTRA_DIST.

11 years agoPrepare for 1.0.69.
Richard Jones [Mon, 14 Sep 2009 18:28:14 +0000 (19:28 +0100)]
Prepare for 1.0.69.

11 years agoRemove main loop.
Richard Jones [Fri, 11 Sep 2009 19:00:30 +0000 (20:00 +0100)]
Remove main loop.

This commit removes the external main loop, which never worked
and caused a number of bugs.  Requests are now done synchronously,
and if the user wants to have requests issued in the background
or to have a responsive GUI, then they'll just have to use threads.

The big change is to push all reads and writes through two
functions called send_to_daemon (for writes) and recv_from_daemon
(for reads) which operate synchronously.  These functions
read/write whole messages, and also handle checking for EOF
(ie. daemon died) and asynchronous log message events from
qemu (eg. from debug / dmesg printed by the guest).  A more
complete description of how these work can be found in the code.

This code passes a complete run of the tests.

Bugs believed to be fixed by this commit:
  internal error: reply callback called twice
  In virt-inspector: "download: guestfs_download reply failed, see earlier error messages"

I have tried to avoid reintroducing this:
  libguestfs: error: write: Broken pipe (guestfish only)

One other benefit of this is that 'set_busy/end_busy' calls
no longer appear in traces.

11 years agoDon't enable trace in set_trace test.
Richard Jones [Mon, 14 Sep 2009 15:21:04 +0000 (16:21 +0100)]
Don't enable trace in set_trace test.

This leaves trace enabled afterwards, resulting in some
ugly test messages.