Coverity: Don't return freed pointers from command* along error path.
authorRichard W.M. Jones <rjones@redhat.com>
Thu, 9 Jun 2011 08:39:54 +0000 (09:39 +0100)
committerRichard W.M. Jones <rjones@redhat.com>
Thu, 9 Jun 2011 09:53:51 +0000 (10:53 +0100)
commit29453a58d818df24c238d0a08a68886ebe4029dd
treed026ae2bc677f2b0c8844dc4163893c75761ff08
parent7a091a11d7aeddc170e4d1b833fd9d7d18c00841
Coverity: Don't return freed pointers from command* along error path.

If the external command failed to run, we could free up the allocated
*stdoutput and *stderror pointers, but then return those freed
pointers to the caller.  The caller usually tries to print and free
*stderror, so this is a serious error.

Instead, return *stdoutput as NULL, and *stderror pointing to a
generic error message.
daemon/guestfsd.c