virt-df: Disallow -h and --csv options together (RHBZ#600977).
authorRichard Jones <rjones@redhat.com>
Tue, 8 Jun 2010 15:44:18 +0000 (16:44 +0100)
committerRichard Jones <rjones@redhat.com>
Mon, 12 Jul 2010 07:34:25 +0000 (08:34 +0100)
commit2373ba34c24f6efcf287042feaa7664d423f63c7
tree6aed67ab3a6157965c5174e96af1af2847296d15
parent3b1f3d64dedcfffde2b7ae40d48244c24d5bbd71
virt-df: Disallow -h and --csv options together (RHBZ#600977).

Before this commit, if you used the -h and --csv options together
you would get these warnings from virt-df:

$ virt-df -h --csv Guest
Virtual Machine,Filesystem,Size,Used,Available,Use%
Argument "13.5G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "4.7G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "8.1G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
"/dev/vg_trick/RHEL55x64","/dev/VolGroup00/LogVol00",13,4,8,34.8%
Argument "98.7M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "18.8M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "74.9M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
"/dev/vg_trick/RHEL55x64","/dev/vda1",98,18,74,19.0%

We could fix this so that the human-readable numbers get written
into the CSV file.  However would probably be wrong for most uses
of the CSV format (databases and spreadsheets) since they would not
be able to interpret these human-readable numbers, or worse could
misinterpret, eg. thinking that "1M" and "1G" are both 1.

Therefore this commit disallows this combination of options.
(cherry picked from commit aaf03a51a26ee501f5dbf2720bbb8a5e3b4e1e6b)
tools/virt-df