Fix networking in the appliance.

[libguestfs.git] / tools / virt-list-filesystems

diff --git a/tools/virt-list-filesystems b/tools/virt-list-filesystems
index 50024aa..5f545cf 100755 (executable)
--- a/tools/virt-list-filesystems
+++ b/tools/virt-list-filesystems
@@ -24,7 +24,6 @@ use Sys::Guestfs::Lib qw(open_guest get_partitions);
 use Pod::Usage;
 use Getopt::Long;
 use Locale::TextDomain 'libguestfs';
-use File::Temp qw/tempdir/;
 
 =encoding utf8
 
@@ -82,6 +81,23 @@ at all.
 
 =cut
 
+my $format;
+
+=item B<--format> raw
+
+Specify the format of disk images given on the command line.  If this
+is omitted then the format is autodetected from the content of the
+disk image.
+
+If disk images are requested from libvirt, then this program asks
+libvirt for this information.  In this case, the value of the format
+parameter is ignored.
+
+If working with untrusted raw-format guest disk images, you should
+ensure the format is always specified.
+
+=cut
+
 my $long;
 
 =item B<-l> | B<--long>
@@ -108,6 +124,7 @@ Getopt::Long::Configure ("bundling");
 GetOptions ("help|?" => \$help,
             "version" => \$version,
             "connect|c=s" => \$uri,
+            "format=s" => \$format,
             "long|l" => \$long,
             "all|a" => \$all,
     ) or pod2usage (2);
@@ -124,9 +141,9 @@ pod2usage (__"virt-list-filesystems: no image or VM name given")
 
 my $g;
 if ($uri) {
-    $g = open_guest (\@ARGV, address => $uri);
+    $g = open_guest (\@ARGV, address => $uri, format => $format);
 } else {
-    $g = open_guest (\@ARGV);
+    $g = open_guest (\@ARGV, format => $format);
 }
 
 $g->launch ();
@@ -144,22 +161,22 @@ foreach $dev (@partitions) {
     my $mountable = $@ ? 0 : 1;
     $g->umount_all ();
     if ($mountable) {
-       push @fses, $dev;
+        push @fses, $dev;
     } else {
-       push @not_mountable, $dev;
+        push @not_mountable, $dev;
     }
 }
 
 foreach $dev (@fses) {
     print canonicalize($dev);
     if ($long) {
-       my $fstype;
-       eval { $fstype = $g->vfs_type ($dev); };
-       if ($fstype) {
-           print " $fstype";
-       } else {
-           print " unknown";
-       }
+        my $fstype;
+        eval { $fstype = $g->vfs_type ($dev); };
+        if ($fstype) {
+            print " $fstype";
+        } else {
+            print " unknown";
+        }
     }
     print "\n";
 }
@@ -167,13 +184,13 @@ foreach $dev (@fses) {
 # If asked, look in the not_mountable list for potential swap devices.
 if ($all) {
     foreach $dev (@not_mountable) {
-       my $file;
-       eval { $file = $g->file ($dev); };
-       if ($file && $file =~ /\bswap\b/) {
-           print canonicalize($dev);
-           print " swap" if $long;
-           print "\n"
-       }
+        my $file;
+        eval { $file = $g->file ($dev); };
+        if ($file && $file =~ /\bswap\b/) {
+            print canonicalize($dev);
+            print " swap" if $long;
+            print "\n"
+        }
     }
 }
 
@@ -184,17 +201,25 @@ sub canonicalize
     local $_ = shift;
 
     if (m{^/dev/[hv]d([a-z]\d)$}) {
-       return "/dev/sd$1";
+        return "/dev/sd$1";
     }
     $_;
 }
 
+=head1 SHELL QUOTING
+
+Libvirt guest names can contain arbitrary characters, some of which
+have meaning to the shell such as C<#> and space.  You may need to
+quote or escape these characters on the command line.  See the shell
+manual page L<sh(1)> for details.
+
 =head1 SEE ALSO
 
 L<guestfs(3)>,
 L<guestfish(1)>,
 L<virt-cat(1)>,
 L<virt-tar(1)>,
+L<virt-list-partitions(1)>,
 L<Sys::Guestfs(3)>,
 L<Sys::Guestfs::Lib(3)>,
 L<Sys::Virt(3)>,
@@ -202,7 +227,7 @@ L<http://libguestfs.org/>.
 
 =head1 AUTHOR
 
-Richard W.M. Jones L<http://et.redhat.com/~rjones/>
+Richard W.M. Jones L<http://people.redhat.com/~rjones/>
 
 =head1 COPYRIGHT