git.annexia.org
/
libguestfs.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Coverity: Ignore return value from guestfs_launch in virt-rescue.
[libguestfs.git]
/
rescue
/
virt-rescue.c
diff --git
a/rescue/virt-rescue.c
b/rescue/virt-rescue.c
index
58be96b
..
dd033aa
100644
(file)
--- a/
rescue/virt-rescue.c
+++ b/
rescue/virt-rescue.c
@@
-1,5
+1,5
@@
/* virt-rescue
/* virt-rescue
- * Copyright (C) 2010 Red Hat Inc.
+ * Copyright (C) 2010
-2011
Red Hat Inc.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@
-20,12
+20,16
@@
#include <stdio.h>
#include <stdlib.h>
#include <stdio.h>
#include <stdlib.h>
+#include <string.h>
#include <inttypes.h>
#include <unistd.h>
#include <getopt.h>
#include <errno.h>
#include <inttypes.h>
#include <unistd.h>
#include <getopt.h>
#include <errno.h>
+#include <locale.h>
#include <assert.h>
#include <assert.h>
+#include <libintl.h>
+#include "ignore-value.h"
#include "progname.h"
#include "xvasprintf.h"
#include "progname.h"
#include "xvasprintf.h"
@@
-75,6
+79,7
@@
usage (int status)
" --selinux Enable SELinux\n"
" -v|--verbose Verbose messages\n"
" -V|--version Display version and exit\n"
" --selinux Enable SELinux\n"
" -v|--verbose Verbose messages\n"
" -V|--version Display version and exit\n"
+ " -w|--rw Mount read-write\n"
" -x Trace libguestfs API calls\n"
"For more information, see the manpage %s(1).\n"),
program_name, program_name, program_name,
" -x Trace libguestfs API calls\n"
"For more information, see the manpage %s(1).\n"),
program_name, program_name, program_name,
@@
-93,6
+98,8
@@
main (int argc, char *argv[])
bindtextdomain (PACKAGE, LOCALEBASEDIR);
textdomain (PACKAGE);
bindtextdomain (PACKAGE, LOCALEBASEDIR);
textdomain (PACKAGE);
+ parse_config ();
+
enum { HELP_OPTION = CHAR_MAX + 1 };
static const char *options = "a:c:d:m:rvVx";
enum { HELP_OPTION = CHAR_MAX + 1 };
static const char *options = "a:c:d:m:rvVx";
@@
-106,6
+113,7
@@
main (int argc, char *argv[])
{ "memsize", 1, 0, 'm' },
{ "network", 0, 0, 0 },
{ "ro", 0, 0, 'r' },
{ "memsize", 1, 0, 'm' },
{ "network", 0, 0, 0 },
{ "ro", 0, 0, 'r' },
+ { "rw", 0, 0, 'w' },
{ "selinux", 0, 0, 0 },
{ "verbose", 0, 0, 'v' },
{ "version", 0, 0, 'V' },
{ "selinux", 0, 0, 0 },
{ "verbose", 0, 0, 'v' },
{ "version", 0, 0, 'V' },
@@
-188,6
+196,10
@@
main (int argc, char *argv[])
OPTION_V;
break;
OPTION_V;
break;
+ case 'w':
+ OPTION_w;
+ break;
+
case 'x':
OPTION_x;
break;
case 'x':
OPTION_x;
break;
@@
-278,7
+290,9
@@
main (int argc, char *argv[])
* appliance.
*/
guestfs_set_error_handler (g, NULL, NULL);
* appliance.
*/
guestfs_set_error_handler (g, NULL, NULL);
- guestfs_launch (g);
+
+ /* We expect launch to fail, so ignore the return value. */
+ ignore_value (guestfs_launch (g));
/* launch() expects guestfsd to start. However, virt-rescue doesn't
* run guestfsd, so this will always fail with ECHILD when the
/* launch() expects guestfsd to start. However, virt-rescue doesn't
* run guestfsd, so this will always fail with ECHILD when the