fish: Fix segfault in '-a' option.

[libguestfs.git] / daemon / checksum.c

diff --git a/daemon/checksum.c b/daemon/checksum.c
index bb30b05..13719fd 100644 (file)
--- a/daemon/checksum.c
+++ b/daemon/checksum.c
@@ -27,47 +27,34 @@
 #include "daemon.h"
 #include "actions.h"
 
-char *
-do_checksum (char *csumtype, char *path)
+static char *
+checksum (const char *csumtype, const char *path)
 {
   const char *program;
-  char *buf;
   char *out, *err;
-  int r, len;
-
-  NEED_ROOT (NULL);
-  ABS_PATH (path, NULL);
+  int r;
+  int len;
 
-  if (strcasecmp (csumtype, "crc") == 0)
+  if (STRCASEEQ (csumtype, "crc"))
     program = "cksum";
-  else if (strcasecmp (csumtype, "md5") == 0)
+  else if (STRCASEEQ (csumtype, "md5"))
     program = "md5sum";
-  else if (strcasecmp (csumtype, "sha1") == 0)
+  else if (STRCASEEQ (csumtype, "sha1"))
     program = "sha1sum";
-  else if (strcasecmp (csumtype, "sha224") == 0)
+  else if (STRCASEEQ (csumtype, "sha224"))
     program = "sha224sum";
-  else if (strcasecmp (csumtype, "sha256") == 0)
+  else if (STRCASEEQ (csumtype, "sha256"))
     program = "sha256sum";
-  else if (strcasecmp (csumtype, "sha384") == 0)
+  else if (STRCASEEQ (csumtype, "sha384"))
     program = "sha384sum";
-  else if (strcasecmp (csumtype, "sha512") == 0)
+  else if (STRCASEEQ (csumtype, "sha512"))
     program = "sha512sum";
   else {
     reply_with_error ("unknown checksum type, expecting crc|md5|sha1|sha224|sha256|sha384|sha512");
     return NULL;
   }
 
-  /* Make the path relative to /sysroot. */
-  len = strlen (path) + 9;
-  buf = malloc (len);
-  if (!buf) {
-    reply_with_perror ("malloc");
-    return NULL;
-  }
-  snprintf (buf, len, "/sysroot%s", path);
-
-  r = command (&out, &err, program, buf, NULL);
-  free (buf);
+  r = command (&out, &err, program, path, NULL);
   if (r == -1) {
     reply_with_error ("%s: %s", program, err);
     free (out);
@@ -83,3 +70,24 @@ do_checksum (char *csumtype, char *path)
 
   return out;                  /* Caller frees. */
 }
+
+char *
+do_checksum (const char *csumtype, const char *path)
+{
+  /* Make the path relative to /sysroot. */
+  char *buf = sysroot_path (path);
+  if (!buf) {
+    reply_with_perror ("malloc");
+    return NULL;
+  }
+
+  char *r = checksum (csumtype, buf);
+  free (buf);
+  return r;
+}
+
+char *
+do_checksum_device (const char *csumtype, const char *device)
+{
+  return checksum (csumtype, device);
+}