libguestfs.git
15 years agobuild: remove more files added by ./autogen.sh
Jim Meyering [Tue, 4 Aug 2009 11:49:19 +0000 (13:49 +0200)]
build: remove more files added by ./autogen.sh

* po/LINGUAS: Remove file.
* po/Makefile.in.in: Likewise.
* po/Makevars: Likewise.
* po/Rules-quot: Likewise.
* po/boldquot.sed: Likewise.
* po/en@boldquot.header: Likewise.
* po/en@quot.header: Likewise.
* po/insert-header.sin: Likewise.
* po/quot.sed: Likewise.
* po/remove-potcdate.sin: Likewise.

15 years agobuild: tell aclocal to search gnulib/m4, too
Jim Meyering [Tue, 4 Aug 2009 08:47:17 +0000 (04:47 -0400)]
build: tell aclocal to search gnulib/m4, too

* Makefile.am (ACLOCAL_AMFLAGS): Append "-I gnulib/m4".

15 years agoDocument and enforce the new spaces-only indentation policy.
Jim Meyering [Mon, 3 Aug 2009 14:55:34 +0000 (10:55 -0400)]
Document and enforce the new spaces-only indentation policy.

* cfg.mk (disable_temporarily): Remove sc_TAB_in_indentation,
to enable the "make syntax-check" that enforces this.
* .x-sc_TAB_in_indentation: New file.  Exceptions.
* HACKING: Document the policy, with tips on how to conform.

15 years agoConvert all TABs-as-indentation to spaces.
Jim Meyering [Mon, 3 Aug 2009 15:10:13 +0000 (11:10 -0400)]
Convert all TABs-as-indentation to spaces.

Do it by running this command:
[exempted files are matched via .x-sc_TAB_in_indentation]

  git ls-files \
    | pcregrep -vf .x-sc_TAB_in_indentation \
    | xargs pcregrep -l '^ *\t' \
    | xargs perl -MText::Tabs -ni -le \
      '$m=/^( *\t[ \t]*)(.*)/; print $m ? expand($1) . $2 : $_'

15 years agoRemove files imported via autogen.sh.
Jim Meyering [Mon, 3 Aug 2009 15:00:22 +0000 (11:00 -0400)]
Remove files imported via autogen.sh.

* m4/.gitignore: Ignore these files.
* m4/codeset.m4: Remove file.
* m4/gettext.m4: Likewise.
* m4/glibc2.m4: Likewise.
* m4/glibc21.m4: Likewise.
* m4/iconv.m4: Likewise.
* m4/intdiv0.m4: Likewise.
* m4/intl.m4: Likewise.
* m4/intldir.m4: Likewise.
* m4/intlmacosx.m4: Likewise.
* m4/intltool.m4: Likewise.
* m4/inttypes-pri.m4: Likewise.
* m4/inttypes.m4: Likewise.
* m4/inttypes_h.m4: Likewise.
* m4/isc-posix.m4: Likewise.
* m4/lcmessage.m4: Likewise.
* m4/lib-ld.m4: Likewise.
* m4/lib-link.m4: Likewise.
* m4/lib-prefix.m4: Likewise.
* m4/lock.m4: Likewise.
* m4/longdouble.m4: Likewise.
* m4/longlong.m4: Likewise.
* m4/nls.m4: Likewise.
* m4/po.m4: Likewise.
* m4/printf-posix.m4: Likewise.
* m4/progtest.m4: Likewise.
* m4/signed.m4: Likewise.
* m4/size_max.m4: Likewise.
* m4/stdint_h.m4: Likewise.
* m4/uintmax_t.m4: Likewise.
* m4/ulonglong.m4: Likewise.
* m4/visibility.m4: Likewise.
* m4/wchar_t.m4: Likewise.
* m4/wint_t.m4: Likewise.
* m4/xsize.m4: Likewise.

15 years agoallow use of #if HAVE_CONFIG_H, for example code
Jim Meyering [Mon, 3 Aug 2009 15:09:13 +0000 (11:09 -0400)]
allow use of #if HAVE_CONFIG_H, for example code

* .x-sc_prohibit_have_config_h: New file, to exempt examples.

15 years agoguestfs: fix typo in my recent change
Jim Meyering [Mon, 3 Aug 2009 13:39:09 +0000 (15:39 +0200)]
guestfs: fix typo in my recent change

* src/guestfs.c (guestfs_perrorf): Rename former err to errnum,
to avoid compilation error.

15 years agoGuard #inclusion of config.h in examples.
Jim Meyering [Mon, 3 Aug 2009 13:21:44 +0000 (15:21 +0200)]
Guard #inclusion of config.h in examples.

* examples/hello.c [HAVE_CONFIG_H]: Include <config.h> conditionally.
* examples/to-xml.c: Likewise.

15 years agobuild: reenable "syntax-check" rule: sc_const_long_option
Jim Meyering [Mon, 3 Aug 2009 12:32:44 +0000 (08:32 -0400)]
build: reenable "syntax-check" rule: sc_const_long_option

* cfg.mk (disable_temporarily): Remove sc_const_long_option.
* daemon/guestfsd.c (main): Declare long_options to be "const".
* fish/fish.c (main): Likewise.
* test-tool/test-tool.c (main): Likewise.

15 years agobuild: temporarily disable failing "syntax-check" rules
Jim Meyering [Mon, 3 Aug 2009 09:53:26 +0000 (05:53 -0400)]
build: temporarily disable failing "syntax-check" rules

* cfg.mk (disable_temporarily): Define.

15 years agomaint: use a git submodule for gnulib
Jim Meyering [Mon, 3 Aug 2009 09:18:10 +0000 (05:18 -0400)]
maint: use a git submodule for gnulib

* .gitmodules: New file, to track gnulib.
* .gnulib: Submodule directory.
* Makefile.am (EXTRA_DIST): Don't list config.rpath or
gitlog-to-changelog.
* autogen.sh: Adapt to use the new submodule.
* cfg.mk: New file.
(SUBDIRS): Add gnulib/lib and gnulib/tests.
(dist-hook): Reflect new location of getlog-to-changelog.
* configure.ac: Set build-aux/ as AUX_DIR.
Invoke gl_EARLY and gl_INIT.
(AC_CONFIG_FILES): Add gnulib/lib/Makefile and gnulib/tests/Makefile.

15 years agoalways include <config.h>
Jim Meyering [Mon, 3 Aug 2009 09:33:35 +0000 (05:33 -0400)]
always include <config.h>

* ocaml/guestfs_c.c: Include <config.h>.
* examples/to-xml.c: Likewise.
* examples/hello.c: Likewise.

15 years agobuild: add -I option to get config.h.
Jim Meyering [Mon, 3 Aug 2009 10:58:16 +0000 (06:58 -0400)]
build: add -I option to get config.h.

* ocaml/Makefile.am (AM_CPPFLAGS): Define.
(guestfs_c.o, guestfs_c_actions.o): Use it.

15 years agoguestfs: don't fault upon failed vasprintf
Jim Meyering [Mon, 3 Aug 2009 12:43:54 +0000 (08:43 -0400)]
guestfs: don't fault upon failed vasprintf

* src/guestfs.c (guestfs_perrorf): Handle failed vasprintf.

15 years agoCleanup whitespace warnings in Lib.pm
Matthew Booth [Mon, 3 Aug 2009 10:43:38 +0000 (11:43 +0100)]
Cleanup whitespace warnings in Lib.pm

15 years agoUse grub entries to find Linux kernels
Matthew Booth [Fri, 31 Jul 2009 16:31:54 +0000 (17:31 +0100)]
Use grub entries to find Linux kernels

This change adds grub parsing to Lib.pm. It adds the following structure to $os:
  {boot}
  ->{configs}
    ->[0]
      ->{title}   = "Fedora (2.6.29.6-213.fc11.i686.PAE)"
      ->{kernel}  = \kernel
      ->{cmdline} = "ro root=/dev/mapper/vg_mbooth-lv_root rhgb"
      ->{initrd}  = \initrd
  ->{default} = 0

The kernel and initrd entries are just references to their top level entries
under kernels and initrd_modules respectively.

It also changes the way Linux kernels and initrd are discovered. Instead of
searching /lib/modules and /boot for files with matching names, kernels and
initrds are scanned as they are discovered in grub.conf.

Additionally, the following attributes are added to the kernels top level entry:
* path
    The path to the kernel's vmlinuz file.
* package
    The name of the package which installed the kernel.

The xml output of virt-inspector is updated to reflect all of the above changes.

15 years agoguestfish: Display RStructList results more pleasantly.
Richard W.M. Jones [Fri, 31 Jul 2009 22:24:11 +0000 (23:24 +0100)]
guestfish: Display RStructList results more pleasantly.

15 years agoAdd interface to Linux 'inotify' API.
Richard W.M. Jones [Fri, 31 Jul 2009 21:31:05 +0000 (22:31 +0100)]
Add interface to Linux 'inotify' API.

15 years agolib: Add selinux=0 to default kernel command line.
Richard W.M. Jones [Fri, 31 Jul 2009 14:57:46 +0000 (15:57 +0100)]
lib: Add selinux=0 to default kernel command line.

SELinux exists in a very disturbed state if it is enabled at
boot time, but no policy is loaded.  In particular, it messes
up the security.selinux extended attributes on files in a
not-very-useful way.

We can't enable SELinux because we don't know what policy
can or should be loaded.  Therefore it's best to disable it
completely.

15 years agoUpdate incorrect comment in Lib.pm
Matthew Booth [Fri, 31 Jul 2009 13:30:09 +0000 (14:30 +0100)]
Update incorrect comment in Lib.pm

Related: change the name of the function the comment describes to be more
accurate.

15 years agoImprove warnings about missing tests.
Richard W.M. Jones [Fri, 31 Jul 2009 11:12:29 +0000 (12:12 +0100)]
Improve warnings about missing tests.

Don't warn where a command just has no tests.

Instead check other commands' tests so we get a definitive
(and much smaller) list of commands that are not tested anywhere.

15 years agoNew commands: swapon-*, swapoff-*, mkswap-file.
Richard W.M. Jones [Fri, 31 Jul 2009 10:55:38 +0000 (11:55 +0100)]
New commands: swapon-*, swapoff-*, mkswap-file.

swapon-device
swapoff-device
swapon-file
swapoff-file
swapon-label
swapoff-label
swapon-uuid
swapoff-uuid
mkswap-file

15 years agoNew command: 'fallocate' to (pre-)allocate sized files.
Richard W.M. Jones [Fri, 31 Jul 2009 07:57:10 +0000 (08:57 +0100)]
New command: 'fallocate' to (pre-)allocate sized files.

15 years agoNew commands: 'ln', 'ln-f', 'ln-s', 'ln-sf' and 'readlink'.
Richard W.M. Jones [Fri, 31 Jul 2009 07:39:43 +0000 (08:39 +0100)]
New commands: 'ln', 'ln-f', 'ln-s', 'ln-sf' and 'readlink'.

These commands can be used to make hard and symbolic links.  The
readlink command is used to read existing symbolic links.

15 years agoAdd 'realpath' command.
Richard W.M. Jones [Fri, 31 Jul 2009 06:39:30 +0000 (07:39 +0100)]
Add 'realpath' command.

15 years agoIgnore failure of 'mv' commands in appliance Makefile.
Richard W.M. Jones [Fri, 31 Jul 2009 06:40:57 +0000 (07:40 +0100)]
Ignore failure of 'mv' commands in appliance Makefile.

A lot of people report these as 'errors' when they are not.
Hide the error messages.

15 years agoconfigure.ac: more quoting
Jim Meyering [Thu, 30 Jul 2009 12:03:48 +0000 (14:03 +0200)]
configure.ac: more quoting

Also, prohibit an invalid value of $JAVA_HOME,
since it must be used unquoted below.

15 years agobuild: If guestfwd test fails, need to print AC_MSG_RESULT 'no'
Richard Jones [Thu, 30 Jul 2009 11:10:52 +0000 (12:10 +0100)]
build: If guestfwd test fails, need to print AC_MSG_RESULT 'no'

15 years agobuild: fix test for --nocompress option
Jim Meyering [Thu, 30 Jul 2009 08:50:49 +0000 (10:50 +0200)]
build: fix test for --nocompress option

Richard W.M. Jones wrote:
> On Wed, Jul 29, 2009 at 10:50:44PM +0200, Jim Meyering wrote:
>> The test for febootstrap-to-initramfs' --nocompress option
>> was always failing for me on F11.  Here's why:
> [...]
>
> Ouch that's obscure.  I've applied this patch and the previous
> one you sent too.  Thanks!

Our messages crossed.
Rebasing my fixed patch and adjusting the log:

>From 9e7846da50ceeee57187f703835bd3975e789719 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 29 Jul 2009 16:33:02 -0400
Subject: [PATCH] build: quote the other option test similarly

* configure.ac: Quote properly.

15 years agobuild: fix test for --nocompress option
Jim Meyering [Wed, 29 Jul 2009 20:50:44 +0000 (22:50 +0200)]
build: fix test for --nocompress option

The test for febootstrap-to-initramfs' --nocompress option
was always failing for me on F11.  Here's why:

  $ bash                               ~/w/co/libguestfs:210-comment-fix
  $ t=`febootstrap-to-initramfs 2>&1`
  [Exit 1]
  $ if ! echo $t|grep -sq -- --nocompress; then echo not found; fi
  not found

Notice: without quotes, the [--nocompress] term expands to "k",
because I happen to have a temporary file named "k":

  $ echo $t
  Usage: febootstrap-to-initramfs [--files=filelist] k DIR Please read
  febootstrap-to-initramfs(8) man page for more information.
  $ echo "$t"
  Usage: febootstrap-to-initramfs [--files=filelist] [--nocompress] DIR
  Please read febootstrap-to-initramfs(8) man page for more information.

a simpler example gives a clue:

  $ touch a b c
  $ echo [--z]
  a b c
  $ echo [--a]
  a
  $ echo [--b]
  a b

it's interpreting [--nocompress] as a range: "-" through "n", plus
the other characters, ocmpres.  "k" falls in the --n range.

Anyhow, here's the fix:

>From 84855642ed41828d01d55123cfab8d8dede759c1 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 29 Jul 2009 16:33:02 -0400
Subject: [PATCH] build: fix test for --nocompress option

* configure.ac: Fix underquoting bug that would cause the test
for febootstrap-to-initramfs' --nocompress option always to fail
with certain-letter-named files in the top directory.

15 years agofix comments; move declarations
Jim Meyering [Wed, 29 Jul 2009 18:48:45 +0000 (14:48 -0400)]
fix comments; move declarations

* daemon/devsparts.c (do_list_devices, do_list_partitions):
Remove stray words in comments.
Move declarations down to definition.

15 years agoWhitespace and comment changes.
Richard Jones [Wed, 29 Jul 2009 22:02:42 +0000 (23:02 +0100)]
Whitespace and comment changes.

15 years agodf: Fix alignment of columns.
Richard Jones [Wed, 29 Jul 2009 21:53:23 +0000 (22:53 +0100)]
df: Fix alignment of columns.

15 years agoguestfish: Make more strings translatable.
Richard Jones [Wed, 29 Jul 2009 20:34:06 +0000 (21:34 +0100)]
guestfish: Make more strings translatable.

However this doesn't yet attempt to translate the POD
command documentation.  We need a plan to do that.

15 years agotests: Use squashfs for static data where possible.
Richard Jones [Wed, 29 Jul 2009 17:46:55 +0000 (18:46 +0100)]
tests: Use squashfs for static data where possible.

Instead of creating a new InitBasicFS for just about every test,
where a test doesn't need to write to the filesystem it is far
faster to use prepared data on an InitSquashFS instead.

This commit changes as many tests as possible to make this so,
making the tests much faster.

15 years agotests: Fix read_file test.
Richard Jones [Wed, 29 Jul 2009 17:44:46 +0000 (18:44 +0100)]
tests: Fix read_file test.

The test ignored the fact that this function returns a (char *, size_t)
pair, and just treated the char * as a string.  This of course would
fail if the string didn't happen to be nul-terminated.

The tests are updated to add a new TestOutputBuffer type which should
be used with functions that return RBufferOut.

15 years agoImplement '*grep*' family of commands.
Richard Jones [Wed, 29 Jul 2009 17:10:48 +0000 (18:10 +0100)]
Implement '*grep*' family of commands.

15 years agoUpdated Polish translations (Piotr Drąg).
Richard Jones [Wed, 29 Jul 2009 15:51:10 +0000 (16:51 +0100)]
Updated Polish translations (Piotr Drąg).

15 years agoVersion 1.0.65. 1.0.65
Richard Jones [Wed, 29 Jul 2009 15:09:29 +0000 (16:09 +0100)]
Version 1.0.65.

15 years agoUpdated PO files.
Richard Jones [Wed, 29 Jul 2009 14:59:28 +0000 (15:59 +0100)]
Updated PO files.

15 years agobuild: avoid locale-specific changes in generated, VC'd file
Jim Meyering [Wed, 29 Jul 2009 12:16:03 +0000 (14:16 +0200)]
build: avoid locale-specific changes in generated, VC'd file

When I build with LC_ALL=C in my environment,
the all-local rule generates po/POTFILES.in that
is sorted differently from the on that is checked in:

    diff --git a/po/POTFILES.in b/po/POTFILES.in
    index ca01b3d..154915a 100644
    --- a/po/POTFILES.in
    +++ b/po/POTFILES.in
    @@ -63,12 +63,11 @@ fish/tilde.c
     fish/time.c
     inspector/virt-inspector.pl
     java/com_redhat_et_libguestfs_GuestFS.c
    -ocaml/guestfs_c_actions.c
     ocaml/guestfs_c.c
    +ocaml/guestfs_c_actions.c
     perl/bindtests.pl
    -perl/Guestfs.c
    -perl/lib/Sys/Guestfs/Lib.pm
     perl/lib/Sys/Guestfs.pm
    +perl/lib/Sys/Guestfs/Lib.pm
     python/guestfs-py.c
     ruby/ext/guestfs/_guestfs.c
     src/guestfs-actions.c

If we generate that file so that sort always uses the C locale, then,
this type of difference will not arise.  Here's the patch to fix the
rule as well as to reflect the change in the generated file:

>From 609e1d1840da25614a7c9e8954e5356050c9f2ad Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 29 Jul 2009 08:13:35 -0400
Subject: [PATCH] build: avoid locale-specific changes in generated, VC'd file

* Makefile.am (all-local): Use LC_ALL=C to sort in C locale.
* po/POTFILES.in: Regenerate.

15 years agoOn RHEL 5, 'file' command prints 'AMD x86-64' for 'x86-64' arch.
Richard W.M. Jones [Wed, 29 Jul 2009 15:01:23 +0000 (16:01 +0100)]
On RHEL 5, 'file' command prints 'AMD x86-64' for 'x86-64' arch.

15 years agoRun cpio with --quiet option so it doesn't print 'xx blocks'
Richard Jones [Wed, 29 Jul 2009 14:55:17 +0000 (15:55 +0100)]
Run cpio with --quiet option so it doesn't print 'xx blocks'

15 years agoLib.pm: Skip tests if perl-libintl module is not available.
Richard Jones [Wed, 29 Jul 2009 14:49:48 +0000 (15:49 +0100)]
Lib.pm: Skip tests if perl-libintl module is not available.

15 years agoLib.pm: Use Perl backtick instead of slurp (Aron Griffis).
Richard Jones [Wed, 29 Jul 2009 14:33:22 +0000 (15:33 +0100)]
Lib.pm: Use Perl backtick instead of slurp (Aron Griffis).

15 years agoDon't show empty CD devices (RHBZ#514505).
Richard Jones [Wed, 29 Jul 2009 14:02:16 +0000 (15:02 +0100)]
Don't show empty CD devices (RHBZ#514505).

15 years agoocaml: Rebuild the tests from source if the main library changes.
Richard Jones [Wed, 29 Jul 2009 11:45:11 +0000 (12:45 +0100)]
ocaml: Rebuild the tests from source if the main library changes.

15 years agoinspector: Determine guest architecture.
Richard Jones [Wed, 29 Jul 2009 08:48:08 +0000 (09:48 +0100)]
inspector: Determine guest architecture.

This commit adds kernel and userspace architecture detection
(fully for Linux, partially for Windows).  It adds an architecture
for each kernel detected, and an architecture for each root (ie.
userspace) found.

15 years agoLib.pm: Add file_architecture command.
Richard Jones [Tue, 28 Jul 2009 16:55:35 +0000 (17:55 +0100)]
Lib.pm: Add file_architecture command.

This command detects the architecture of some types of binaries,
libraries, kernel modules and initrd images.

15 years agoLib: Document the $ro parameter for mount_operating_system properly.
Richard Jones [Wed, 29 Jul 2009 09:15:06 +0000 (10:15 +0100)]
Lib: Document the $ro parameter for mount_operating_system properly.

15 years agoMention related tools in the manual page.
Richard Jones [Wed, 29 Jul 2009 08:39:02 +0000 (09:39 +0100)]
Mention related tools in the manual page.

15 years agoWhitespace: indent some names in images/Makefile.am correctly.
Richard Jones [Tue, 28 Jul 2009 16:14:14 +0000 (17:14 +0100)]
Whitespace: indent some names in images/Makefile.am correctly.

15 years agoLib.pm: Use 'file' as replacement for 'zfile'.
Richard Jones [Tue, 28 Jul 2009 14:43:14 +0000 (15:43 +0100)]
Lib.pm: Use 'file' as replacement for 'zfile'.

15 years agoPass '-z' parameter to 'file' command so it looks inside compressed files.
Richard Jones [Tue, 28 Jul 2009 14:29:23 +0000 (15:29 +0100)]
Pass '-z' parameter to 'file' command so it looks inside compressed files.

Also we deprecate the old 'zfile' command.

15 years agoAdd DeprecatedBy flag to mark functions which are deprecated.
Richard Jones [Tue, 28 Jul 2009 14:24:44 +0000 (15:24 +0100)]
Add DeprecatedBy flag to mark functions which are deprecated.

15 years agoNeed to declare asprintf_nowarn as inline to avoid gcc complaining.
Richard Jones [Tue, 28 Jul 2009 14:23:28 +0000 (15:23 +0100)]
Need to declare asprintf_nowarn as inline to avoid gcc complaining.

15 years agoReplace shell_quote function with %Q and %R printf specifiers.
Richard Jones [Mon, 27 Jul 2009 21:27:45 +0000 (22:27 +0100)]
Replace shell_quote function with %Q and %R printf specifiers.

%Q => simple shell quoted string
%R => path will be prefixed by /sysroot

eg. snprintf (cmd, sizeof cmd, "cat %R", path); system (cmd);

15 years agoAdd InitSquashFS test type, for tests that just use the squashfs (/dev/sdd).
Richard Jones [Mon, 27 Jul 2009 15:39:02 +0000 (16:39 +0100)]
Add InitSquashFS test type, for tests that just use the squashfs (/dev/sdd).

This also speeds up those tests because we don't have to wait
to create a filesystem which is never used.

15 years agoMake read-only optional in mount_operating_system()
Matthew Booth [Fri, 24 Jul 2009 13:56:38 +0000 (14:56 +0100)]
Make read-only optional in mount_operating_system()

15 years agoMore ideas on a quick Perl one-liner syntax for TODO file.
Richard W.M. Jones [Fri, 24 Jul 2009 17:29:42 +0000 (18:29 +0100)]
More ideas on a quick Perl one-liner syntax for TODO file.

15 years agoguestfish -iv should print virt-inspector command (for debugging).
Richard W.M. Jones [Fri, 24 Jul 2009 14:46:15 +0000 (15:46 +0100)]
guestfish -iv should print virt-inspector command (for debugging).

15 years agoReformat the TODO file.
Richard W.M. Jones [Fri, 24 Jul 2009 13:36:50 +0000 (14:36 +0100)]
Reformat the TODO file.

15 years agoPass cgroup_disable=memory, saves ~ 5MB of RAM.
Richard Jones [Fri, 24 Jul 2009 08:31:49 +0000 (09:31 +0100)]
Pass cgroup_disable=memory, saves ~ 5MB of RAM.

15 years agoget_append call can return NULL, but bindings didn't handle it.
Richard Jones [Thu, 23 Jul 2009 17:57:05 +0000 (18:57 +0100)]
get_append call can return NULL, but bindings didn't handle it.

It's not a good idea because there is no way to return an error
indication.  However at least this means it won't segfault.

15 years agoRHEL 5 thinks squashfs is HFS+ filesystem, unless we specify the type explicitly.
Richard Jones [Thu, 23 Jul 2009 11:45:12 +0000 (12:45 +0100)]
RHEL 5 thinks squashfs is HFS+ filesystem, unless we specify the type explicitly.

15 years agoRemove hard-coded qemu-kvm, replace with $QEMU. 1.0.64
Richard Jones [Thu, 23 Jul 2009 10:16:15 +0000 (11:16 +0100)]
Remove hard-coded qemu-kvm, replace with $QEMU.

15 years agoVersion 1.0.63 1.0.63
Richard Jones [Thu, 23 Jul 2009 09:45:36 +0000 (10:45 +0100)]
Version 1.0.63

15 years agoAdd libguestfs-test-tool.
Richard Jones [Wed, 22 Jul 2009 19:58:39 +0000 (20:58 +0100)]
Add libguestfs-test-tool.

This is an end-user testing tool, designed to test basic functionality
of libguestfs/qemu/kernel combination on the end-user's final host
machine.

It does not perform a thorough test, but should be enough to find
most booting issues.

Also this is intended to be used when reporting bugs.

15 years agoFix typo in error message.
Richard Jones [Wed, 22 Jul 2009 20:18:01 +0000 (21:18 +0100)]
Fix typo in error message.

15 years agoRevert "Add 'set-kernel'/'get-kernel'/LIBGUESTFS_KERNEL to override appliance kernel."
Richard Jones [Wed, 22 Jul 2009 20:11:10 +0000 (21:11 +0100)]
Revert "Add 'set-kernel'/'get-kernel'/LIBGUESTFS_KERNEL to override appliance kernel."

This reverts commit 34d2df41626f1ee4172a6d40b06d72d6ed9d6348.

15 years agoset-append and set-kernel parameters are both nullable.
Richard Jones [Wed, 22 Jul 2009 12:42:51 +0000 (13:42 +0100)]
set-append and set-kernel parameters are both nullable.

(So are the return values, but leave that bug for another day).

15 years agoAdd 'set-kernel'/'get-kernel'/LIBGUESTFS_KERNEL to override appliance kernel.
Richard Jones [Wed, 22 Jul 2009 12:35:48 +0000 (13:35 +0100)]
Add 'set-kernel'/'get-kernel'/LIBGUESTFS_KERNEL to override appliance kernel.

This allows you to override the appliance kernel with an easy
command or environment variable.

15 years agoTodo: Suggestion for 'replace' command.
Richard Jones [Wed, 22 Jul 2009 11:39:21 +0000 (12:39 +0100)]
Todo: Suggestion for 'replace' command.

15 years agoAdd commented-out support for alternate guestfwd syntax.
Richard W.M. Jones [Tue, 21 Jul 2009 15:01:04 +0000 (16:01 +0100)]
Add commented-out support for alternate guestfwd syntax.

This commit just moves code around.  The new support is not enabled
because it doesn't work.  See qemu-devel, subject
"guestfwd option doesn't allow supplementary ,server,nowait"

15 years agoconfigure: Detect new-style guestfwd support (RHBZ#512957)
Richard W.M. Jones [Tue, 21 Jul 2009 14:59:35 +0000 (15:59 +0100)]
configure: Detect new-style guestfwd support (RHBZ#512957)

However new qemu 0.10.5 still doesn't work.

15 years agoLibrary: Pass more options on the Linux kernel command line.
Richard W.M. Jones [Tue, 21 Jul 2009 12:34:46 +0000 (13:34 +0100)]
Library: Pass more options on the Linux kernel command line.

Always pass:
  noapic             (APIC causes problems for lots of people)
  udevtimeout=300    (for very slow qemu using softemu)
  acpi=off           (ACPI is troublesome and unnecessary, so turn it off)

15 years agoSplit $os->{version} into $os->{major_version} and $os->{minor_version}
Matthew Booth [Tue, 21 Jul 2009 10:46:24 +0000 (11:46 +0100)]
Split $os->{version} into $os->{major_version} and $os->{minor_version}

15 years agoAllow TMPDIR to override directory used for temporary files (RHBZ#512905).
Richard W.M. Jones [Tue, 21 Jul 2009 10:47:57 +0000 (11:47 +0100)]
Allow TMPDIR to override directory used for temporary files (RHBZ#512905).

15 years agoGenerator: Implement RBufferOut and "read-file" call.
Richard W.M. Jones [Tue, 21 Jul 2009 10:00:47 +0000 (11:00 +0100)]
Generator: Implement RBufferOut and "read-file" call.

This commit implements the RBufferOut type for returning
arbitrary 8 bit data from calls.

We also implement the guestfs_read_file call to read a
whole file that can contain any 8 bit content, but up to
a limit of ~ 2 MB.

15 years agoDocs: Fully document the guestfs_readdir ftyp return field.
Richard W.M. Jones [Tue, 21 Jul 2009 10:10:19 +0000 (11:10 +0100)]
Docs: Fully document the guestfs_readdir ftyp return field.

15 years agoDocs: Add "API Overview" section to guestfs(3) manpage.
Richard W.M. Jones [Tue, 21 Jul 2009 09:59:51 +0000 (10:59 +0100)]
Docs: Add "API Overview" section to guestfs(3) manpage.

This section collects together related API calls, to provide
more coherent documentation about different ways to carry
out actions such as uploading and downloading.

15 years agoGenerator: Improve accuracy of a comment.
Richard Jones [Mon, 20 Jul 2009 18:04:40 +0000 (19:04 +0100)]
Generator: Improve accuracy of a comment.

15 years agovirt-inspector --fish: Fix incorrect '-a' parameter (RHBZ#512709)
Richard Jones [Mon, 20 Jul 2009 14:09:11 +0000 (15:09 +0100)]
virt-inspector --fish: Fix incorrect '-a' parameter (RHBZ#512709)

virt-inspector --fish dom
virt-inspector --ro-fish dom

Both of the above commands give incorrect results if run on a
libvirt domain, eg:

$ virt-inspector --ro-fish RHEL54Betax64
==> --ro -a RHEL54Betax64 -m /dev/VolGroup00/LogVol00:/ -m /dev/sda1:/boot
            ^^^^^^^^^^^^^

This is because the current code just prints back the original @ARGV
parameters.

This patch fixes this by getting the image names instead.

15 years agoReplace 'distrofamily' with feature tags
Matthew Booth [Mon, 20 Jul 2009 10:16:55 +0000 (11:16 +0100)]
Replace 'distrofamily' with feature tags

It turns out that the distribution hierarchy is not as reliable concept as you
might think. This patch removes distrofamily again.

Instead of distrofamily, we will add feature tags. This patch adds 2 feature
tags for Linux distributions:

package_format (eg rpm/dpkg)
package_management (eg rhn/yum/apt)

This change is reflected in the output of virt-inspector

15 years agoadd nls_base.ko and nls_cp437.ko for vfat
Guido Günther [Sat, 18 Jul 2009 16:20:29 +0000 (18:20 +0200)]
add nls_base.ko and nls_cp437.ko for vfat

15 years agoMake /sysroot path configurable.
Richard Jones [Sat, 18 Jul 2009 09:43:52 +0000 (10:43 +0100)]
Make /sysroot path configurable.

Currently /sysroot is hard-coded throughout the daemon code.

This patch turns the path into a variable so that we can change
it in future, for example to allow standalone mode to be implemented.

This patch was tested by running all the C API tests successfully.

15 years agoVersion 1.0.62. 1.0.62
Richard Jones [Fri, 17 Jul 2009 16:40:30 +0000 (17:40 +0100)]
Version 1.0.62.

15 years agoMerge branch 'master' of git+ssh://g-rjones@et.redhat.com/git/libguestfs
Richard Jones [Fri, 17 Jul 2009 15:33:30 +0000 (16:33 +0100)]
Merge branch 'master' of git+ssh://g-rjones@et.redhat.com/git/libguestfs

15 years agoRHEL 5.4 fix: Check for qemu-kvm binary in /usr/libexec
Richard W.M. Jones [Fri, 17 Jul 2009 15:32:05 +0000 (16:32 +0100)]
RHEL 5.4 fix: Check for qemu-kvm binary in /usr/libexec

15 years agoDifferentiate 'distro' and 'distrofamily' in Sys::Guestfs::Lib
Matthew Booth [Thu, 16 Jul 2009 22:48:25 +0000 (23:48 +0100)]
Differentiate 'distro' and 'distrofamily' in Sys::Guestfs::Lib

Change distro in the output formally known as virt-inspector to reflect the
actual distro. Possible values are now: fedora, rhel, centos, scientific,
debian.

Add new distrofamily entry which is one of: redhat, debian. Currently all
distros except 'debian' are in the redhat family.

This allows you to, for example, select a RHEL/CentOS/Scientific Linux specific
kernel for installation rather than assuming they're all the same.

Note this also changes the behaviour of virt-inspector --query. It will now only
return rhel=yes for RHEL.

15 years agocat: Example of finding DHCP IP address of a VM.
Richard Jones [Fri, 17 Jul 2009 08:37:37 +0000 (09:37 +0100)]
cat: Example of finding DHCP IP address of a VM.

15 years agoFix non-srcdir builds: Ignore perl/Makefile-pl.old
Richard Jones [Fri, 17 Jul 2009 08:37:18 +0000 (09:37 +0100)]
Fix non-srcdir builds: Ignore perl/Makefile-pl.old

15 years agoFix non-srcdir builds: further fixes to OCaml build rules.
Richard Jones [Fri, 17 Jul 2009 08:36:28 +0000 (09:36 +0100)]
Fix non-srcdir builds: further fixes to OCaml build rules.

15 years agoFixes for non-srcdir builds: Only include POTFILES from SUBDIRS directories.
Richard Jones [Thu, 16 Jul 2009 18:29:47 +0000 (19:29 +0100)]
Fixes for non-srcdir builds: Only include POTFILES from SUBDIRS directories.

15 years agoFix non-srcdir builds: fix OCaml build rules.
Richard Jones [Thu, 16 Jul 2009 18:27:16 +0000 (19:27 +0100)]
Fix non-srcdir builds: fix OCaml build rules.

15 years agoFix non-srcdir builds: Files generated by configure should be in the tarball.
Richard Jones [Thu, 16 Jul 2009 17:52:44 +0000 (18:52 +0100)]
Fix non-srcdir builds: Files generated by configure should be in the tarball.

15 years agoFix non-srcdir builds: Don't include generated *_protocol.c files in POTFILES.
Richard Jones [Thu, 16 Jul 2009 17:32:57 +0000 (18:32 +0100)]
Fix non-srcdir builds: Don't include generated *_protocol.c files in POTFILES.

15 years agoDon't clean up some non-generated files.
Richard Jones [Thu, 16 Jul 2009 17:31:25 +0000 (18:31 +0100)]
Don't clean up some non-generated files.

15 years agoFix for non-srcdir builds: more misc fixes.
Richard Jones [Thu, 16 Jul 2009 17:23:53 +0000 (18:23 +0100)]
Fix for non-srcdir builds: more misc fixes.

15 years agoFix for non-srcdir builds: Run src/generator.ml from the srcdir.
Richard Jones [Thu, 16 Jul 2009 17:08:44 +0000 (18:08 +0100)]
Fix for non-srcdir builds: Run src/generator.ml from the srcdir.

Note that files generated by src/generator.ml are stored in
the srcdir, *not* the builddir.  The reason is so that they
can be included in the tarball and will appear in the srcdir
for tarball builds.