libguestfs.git
13 years agoNote that additional memory may be required to typecheck Augeas lenses (RHBZ#729887).
Richard W.M. Jones [Fri, 12 Aug 2011 10:17:16 +0000 (11:17 +0100)]
Note that additional memory may be required to typecheck Augeas lenses (RHBZ#729887).
(cherry picked from commit 7739d7f471f9575828bd32489695d92dde005a9c)

13 years agofish: Document that remote run in cmd substitution context hangs.
Richard W.M. Jones [Fri, 12 Aug 2011 10:08:57 +0000 (11:08 +0100)]
fish: Document that remote run in cmd substitution context hangs.

This documents bug 592910.
(cherry picked from commit 6cabc1cd02e181063596b48df55c3f6db51a6bb9)

13 years agoFix 'unknown filesystem' warnings in old inspection code (RHBZ#678231 RHBZ#666578).
Richard W.M. Jones [Thu, 11 Aug 2011 10:45:25 +0000 (11:45 +0100)]
Fix 'unknown filesystem' warnings in old inspection code (RHBZ#678231 RHBZ#666578).

This is a comprehensive fix for the warnings from the old (and
obsolete) Perl inspection code.  For a full description and
reproducer, see:

https://bugzilla.redhat.com/show_bug.cgi?id=678231#c5
(cherry picked from commit b9838001015a06a69a08b69d9f013d82f0ea3139)

13 years agobuild: Set TMPDIR for local testing.
Richard W.M. Jones [Mon, 8 Aug 2011 11:41:54 +0000 (12:41 +0100)]
build: Set TMPDIR for local testing.

This avoids conflicts with the globally installed libguestfs
appliance, or lets us build in multiple local directories at the same
time without conflicts.

Cherry picked from commit f7d18c84dde596699ffc5100fec2cf7b0d582450
and backported to stable-1.8.

13 years agofish: Add fish-cmds.h to generator_built.
Richard W.M. Jones [Wed, 17 Aug 2011 11:41:41 +0000 (12:41 +0100)]
fish: Add fish-cmds.h to generator_built.

This updates commit 3064277680ad11f887691646d0fa17bb35f38c19.
(cherry picked from commit 85efbc6aa70d522af066a38fd1aae05b790c46d3)

13 years agofish: Declare run_* functions in a generated header file.
Richard W.M. Jones [Sun, 7 Aug 2011 20:04:00 +0000 (21:04 +0100)]
fish: Declare run_* functions in a generated header file.

Calls to these functions are generated, so there is no need to declare
the functions by hand.

Cherry picked from commit 3064277680ad11f887691646d0fa17bb35f38c19
and backported to stable-1.8 branch.

13 years agoVersion 1.8.11. 1.8.11
Richard W.M. Jones [Sun, 7 Aug 2011 22:21:06 +0000 (23:21 +0100)]
Version 1.8.11.

13 years agodocs: Fix function names in deprecation notices.
Richard W.M. Jones [Sat, 6 Aug 2011 14:57:21 +0000 (15:57 +0100)]
docs: Fix function names in deprecation notices.
(cherry picked from commit 60adf092a8900323c048c94f3f0934be416a3eb6)

13 years agodocs: guestfs_set_out_of_memory_handler returns void, not int.
Richard W.M. Jones [Sat, 6 Aug 2011 14:53:15 +0000 (15:53 +0100)]
docs: guestfs_set_out_of_memory_handler returns void, not int.

It always has done.  The documentation was wrong.
(cherry picked from commit 70f44cc0ea0bcdd025ed657461e07f6778be44ba)

13 years agodebian: bash is required to run libtool replacement script.
Richard W.M. Jones [Fri, 5 Aug 2011 09:49:45 +0000 (10:49 +0100)]
debian: bash is required to run libtool replacement script.

This was failing on Debian where $(SHELL) is the minimal dash shell.
(cherry picked from commit 6a98ed953b1e3b0d3251385f0ca2dd1dee80b63d)

13 years agodebian: Add gawk to packagelist.
Richard W.M. Jones [Tue, 2 Aug 2011 10:03:50 +0000 (11:03 +0100)]
debian: Add gawk to packagelist.

It's already included, but implicitly.
(cherry picked from commit 5f9c168d9135fa81ee2f3a15461467fe04c26888)

13 years agovirt-tar test: Stable ordering of test output.
Richard W.M. Jones [Mon, 1 Aug 2011 14:13:08 +0000 (15:13 +0100)]
virt-tar test: Stable ordering of test output.

The files could be listed in any order, resulting in the test failing
for no reason.  Sort the output of tar.
(cherry picked from commit 995b3fecb9af7a8bd52b238bad2a631a1193c83a)

13 years agoChange link, since PostgreSQL switched to using git.
Richard W.M. Jones [Mon, 1 Aug 2011 09:35:18 +0000 (10:35 +0100)]
Change link, since PostgreSQL switched to using git.
(cherry picked from commit 3cf31c2fe0b356ea5c04117c5235b0a3cfe34971)

13 years agoDon't fail if HOSTNAME field is missing on Red Hat guests (RHBZ#726739).
Richard W.M. Jones [Fri, 29 Jul 2011 16:38:43 +0000 (17:38 +0100)]
Don't fail if HOSTNAME field is missing on Red Hat guests (RHBZ#726739).

Cherry picked from commit bad3f4b54a959685f3c0697238fc5753096834fb.

13 years agoVersion 1.8.10. 1.8.10
Richard W.M. Jones [Wed, 27 Jul 2011 14:48:38 +0000 (15:48 +0100)]
Version 1.8.10.

13 years agoperl: Fix another place where qw() was used as parentheses.
Richard W.M. Jones [Wed, 27 Jul 2011 14:43:12 +0000 (15:43 +0100)]
perl: Fix another place where qw() was used as parentheses.

This is a fix for Perl 5.14.

See previous commit 5c3c7e8825341e18c9449976f8a321a04cc78d79.
(cherry picked from commit c70532ab4b3d977ed7484e473107808b22d90a2a)

13 years agoocaml: Fix locking in event callbacks.
Richard W.M. Jones [Tue, 26 Jul 2011 17:57:19 +0000 (18:57 +0100)]
ocaml: Fix locking in event callbacks.

We weren't acquiring the GC lock around some allocations, resulting in
segfaults when an event callback ran at the same time as a main thread
allocation or garbage collection.

In particular this fixes a noticable crash in guestfs-browser.

(Cherry picked from commit 2b8b3f9794ceb43eabd3083e225c669896d8b186)

13 years agovirt-df: Re-add documentation for --csv option.
Richard W.M. Jones [Tue, 26 Jul 2011 11:39:54 +0000 (12:39 +0100)]
virt-df: Re-add documentation for --csv option.

The documentation for the --csv option disappeared between 1.6 and 1.8
when we rewrote virt-df in C.  Re-add it from 1.6 sources.
(cherry picked from commit 01f6bce19dbfaf42fa4908683f3cc8785585d023)

13 years agotest-tool: Print FEBOOTSTRAP_* environment variables (RHBZ#671082).
Richard W.M. Jones [Mon, 25 Jul 2011 10:21:48 +0000 (11:21 +0100)]
test-tool: Print FEBOOTSTRAP_* environment variables (RHBZ#671082).
(cherry picked from commit 15289d4b726d7c38702794df23c61ae40879a46c)

13 years agoperl: Fix CCFLAGS for Perl 5.14.
Richard W.M. Jones [Fri, 22 Jul 2011 10:12:52 +0000 (11:12 +0100)]
perl: Fix CCFLAGS for Perl 5.14.

A change to ExtUtils::CBuilder in Perl 5.14 causes CCFLAGS to
completely replace, rather than appending, the C flags.

The unfortunate consequence of this is that vital flags such as
-D_FILE_OFFSET_BITS=64 are missing.  For 32 bit code, this means you
get binary-incompatible code that completely fails to load.

For further analysis see:

http://www.nntp.perl.org/group/perl.perl5.porters/2011/04/msg171535.html

This commit changes CCFLAGS so that it appends to the existing
$Config{ccflags} instead of replacing it.  On earlier versions of Perl
this means we get two copies of the flags, which is unfortunate but
should be safe.
(cherry picked from commit 8386a57458aceb768f0e59aa090a15a544f7466e)

13 years agobuild: Redirect ./configure errors in general to config.log.
Richard W.M. Jones [Thu, 21 Jul 2011 16:59:34 +0000 (17:59 +0100)]
build: Redirect ./configure errors in general to config.log.
(cherry picked from commit 71eb0bf45649eefa1f0cd4b1372cfc2653c8e7a5)

13 years agobuild: Send failed Perl test configure output to config.log.
Richard W.M. Jones [Thu, 21 Jul 2011 16:00:48 +0000 (17:00 +0100)]
build: Send failed Perl test configure output to config.log.
(cherry picked from commit 610642491a4846f45c7b233060ffde46f6ca09f0)

13 years agobuild: Allow 'make quickcheck' test-tool args to be overridden.
Richard W.M. Jones [Thu, 21 Jul 2011 09:50:40 +0000 (10:50 +0100)]
build: Allow 'make quickcheck' test-tool args to be overridden.

A typical use for this is for packagers who want to increase
the default timeout:

  make quickcheck QUICKCHECK_TEST_TOOL_ARGS="-t 300"

(Cherry picked from commit 806b6e01506dea4eae68ac3e468d9398d63cafcb)

13 years agoblkid: Use -c /dev/null option to kill the cache.
Richard W.M. Jones [Wed, 20 Jul 2011 13:41:39 +0000 (14:41 +0100)]
blkid: Use -c /dev/null option to kill the cache.

On recent Debian, /etc/blkid.tab is now a symlink to /dev/.blkid.tab.
Rather than chasing the cache file around (it may move to /run in future)
use the -c /dev/null option to stop blkid from reading the cache.
(cherry picked from commit 1d0f398d8e3c74ce6a70cbbb8d9b8ae07c6d7ef6)

13 years agoblkid: Detect when value not found and return empty string.
Richard W.M. Jones [Wed, 20 Jul 2011 13:25:32 +0000 (14:25 +0100)]
blkid: Detect when value not found and return empty string.

If the blkid command returns 2, that means the value was not found.

Note that this changes the output of the vfs-type API when the
filesystem has no type (eg when it is empty).  Previously this would
return an error.  Now it returns empty string "".

We did not document this either way.  Making it return empty string is
consistent with vfs-label and vfs-uuid.

This change broke list-filesystems, since that code was assuming that
vfs-type could only return a filesystem type or an error.
(cherry picked from commit 168fd4ad5d1e5da93e11388095d41aaa8f804ceb)

13 years agoappliance: Capture stderr from qemu to the event system.
Richard W.M. Jones [Wed, 20 Jul 2011 11:07:30 +0000 (12:07 +0100)]
appliance: Capture stderr from qemu to the event system.
(cherry picked from commit 8b2e60ce4b46e86da093ee64d4e0b0ae3c998d55)

13 years agoappliance: Document pipe fds.
Richard W.M. Jones [Wed, 20 Jul 2011 11:05:40 +0000 (12:05 +0100)]
appliance: Document pipe fds.
(cherry picked from commit 70daccfe4e9939078436c2830928d8e53432dd84)

13 years agobuild: Fix virtio-serial test for qemu 0.15.
Richard W.M. Jones [Tue, 19 Jul 2011 18:55:24 +0000 (19:55 +0100)]
build: Fix virtio-serial test for qemu 0.15.

(Cherry picked and combined
commit d82438431c1551610eb7d9945fa76d6387534582 and
commit 5dec7842655dd872bb0fd9fe07f6a9eab6b13bfd)

13 years agomkfs: Don't die if mke2fs is not available.
Richard W.M. Jones [Thu, 14 Jul 2011 10:27:24 +0000 (11:27 +0100)]
mkfs: Don't die if mke2fs is not available.

Allow other types of filesystems to be created.
(cherry picked from commit c6340f45007b0ab7e1c5391cf78afc10a816553f)

13 years agopart-get-bootable: Fix when partitions are missing or unordered (RHBZ#602997).
Richard W.M. Jones [Tue, 12 Jul 2011 16:18:48 +0000 (17:18 +0100)]
part-get-bootable: Fix when partitions are missing or unordered (RHBZ#602997).
(cherry picked from commit 511c82df46f5c6f4a7f984fdb81d4691038ed6da)

13 years agoVersion 1.8.9. 1.8.9
Richard W.M. Jones [Sat, 16 Jul 2011 08:44:28 +0000 (09:44 +0100)]
Version 1.8.9.

13 years agoDocument that ntfsresize cannot be used multiple times (RHBZ#685009).
Richard W.M. Jones [Tue, 12 Jul 2011 13:13:57 +0000 (14:13 +0100)]
Document that ntfsresize cannot be used multiple times (RHBZ#685009).
(cherry picked from commit 2ba2ddf2113db7bb2afe3f739dc3cbaa5416a4ba)

13 years agoprotocol: Force optargs_bitmask to be passed as 0 for non-opt actions.
Richard W.M. Jones [Tue, 12 Jul 2011 17:17:35 +0000 (18:17 +0100)]
protocol: Force optargs_bitmask to be passed as 0 for non-opt actions.

If the action doesn't take optional arguments, nevertheless force the
optargs_bitmask field in the header to be passed as 0, and give an
error if not.
(cherry picked from commit 0344248af55802bbbd816b349ec1ba9305996f6e)

13 years agoAdd caution subdirectory containing safety and liveness tests.
Richard W.M. Jones [Thu, 30 Jun 2011 11:57:31 +0000 (12:57 +0100)]
Add caution subdirectory containing safety and liveness tests.

Not that I'm paranoid about qemu breaking snapshots of anything like
that ...

Cherry picked from commit f3ada2c7653866f2529c9f18aaa99f76cd984844.

13 years agoinspector: Fix comment in virt-inspector.rng.
Richard W.M. Jones [Tue, 28 Jun 2011 16:02:46 +0000 (17:02 +0100)]
inspector: Fix comment in virt-inspector.rng.

The comment referred to the command line syntax of the old
virt-inspector.
(cherry picked from commit ea96c7acf7a332c08c2214796add647224a2ede0)

13 years agoRevert "Lib.pm: unknown filesystem label SWAP-sda2 (RHBZ#666578)"
Richard W.M. Jones [Mon, 27 Jun 2011 17:14:15 +0000 (18:14 +0100)]
Revert "Lib.pm: unknown filesystem label SWAP-sda2 (RHBZ#666578)"

This reverts commit 5cab0d6c807d8a3bf9690375c663d11a10e21656.
(cherry picked from commit 123610f1b5133a9e541a245467f60d065ea96575)

13 years agotrace: Print empty list correctly.
Richard W.M. Jones [Wed, 22 Jun 2011 09:36:44 +0000 (10:36 +0100)]
trace: Print empty list correctly.

Empty lists returned by RStringList and RHashtable functions
were incorrectly printed as [""].

Fix this so they are printed as [] instead.

Cherry picked from commit 56b94f5f6aa7981533ad867cc908c6e9cca2ba42.

13 years agoperl: Ignore MYMETA.yml.
Richard W.M. Jones [Sat, 18 Jun 2011 12:04:18 +0000 (13:04 +0100)]
perl: Ignore MYMETA.yml.

This file is created by one of the build tools used by Perl 5.14.
(cherry picked from commit cabfaa857fbd325bd0303fa56b28df8ce52aab33)

13 years agoperl: Don't use qw() as parentheses.
Richard W.M. Jones [Sat, 18 Jun 2011 12:00:00 +0000 (13:00 +0100)]
perl: Don't use qw() as parentheses.

In Perl 5.14:

Use of qw(...) as parentheses is deprecated at perl/blib/lib/Sys/Guestfs/Lib.pm line 1111.
(cherry picked from commit 5c3c7e8825341e18c9449976f8a321a04cc78d79)

13 years agogenerator: Rewrite UUIDs that begin with zero byte.
Richard W.M. Jones [Mon, 13 Jun 2011 17:58:53 +0000 (18:58 +0100)]
generator: Rewrite UUIDs that begin with zero byte.

In util-linux <= 2.19, mkswap -U cannot handle the first byte of the
UUID being zero, so we artificially rewrite such UUIDs.

See: http://article.gmane.org/gmane.linux.utilities.util-linux-ng/4273
(cherry picked from commit 4ee190628bc05f0c8fad1f6d9c3e85619a91e8b8)

13 years agoVersion 1.8.8. 1.8.8
Richard W.M. Jones [Mon, 13 Jun 2011 13:13:34 +0000 (14:13 +0100)]
Version 1.8.8.

13 years agodaemon: Keep Coverity happy by ignoring some return values.
Richard W.M. Jones [Thu, 9 Jun 2011 09:10:50 +0000 (10:10 +0100)]
daemon: Keep Coverity happy by ignoring some return values.
(cherry picked from commit f5096dd546ac43c7288b3ab7aec1562f070f78f6)

13 years agoCoverity: Don't return freed pointers from command* along error path.
Richard W.M. Jones [Thu, 9 Jun 2011 08:39:54 +0000 (09:39 +0100)]
Coverity: Don't return freed pointers from command* along error path.

If the external command failed to run, we could free up the allocated
*stdoutput and *stderror pointers, but then return those freed
pointers to the caller.  The caller usually tries to print and free
*stderror, so this is a serious error.

Instead, return *stdoutput as NULL, and *stderror pointing to a
generic error message.
(cherry picked from commit 29453a58d818df24c238d0a08a68886ebe4029dd)

13 years agoCoverity: Missing return on error path.
Richard W.M. Jones [Wed, 8 Jun 2011 21:38:53 +0000 (22:38 +0100)]
Coverity: Missing return on error path.
(cherry picked from commit 7a091a11d7aeddc170e4d1b833fd9d7d18c00841)

13 years agoCoverity: Ensure fp is closed along all error paths.
Richard W.M. Jones [Wed, 8 Jun 2011 21:30:24 +0000 (22:30 +0100)]
Coverity: Ensure fp is closed along all error paths.
(cherry picked from commit 346c5b0ebf58c81f657540eeb72abaa41bfc4e3f)

13 years agoCoverity: Close directory handle along error paths.
Richard W.M. Jones [Wed, 8 Jun 2011 21:27:01 +0000 (22:27 +0100)]
Coverity: Close directory handle along error paths.
(cherry picked from commit 7c020a14802255c966b2b402b983551b86a08bba)

13 years agoCoverity: Don't leak argv arrays.
Richard W.M. Jones [Wed, 8 Jun 2011 21:25:21 +0000 (22:25 +0100)]
Coverity: Don't leak argv arrays.
(cherry picked from commit 869c11b30c72c57e48dd63c4641087a06abe80d5)

13 years agoCoverity: Don't leak error strings.
Richard W.M. Jones [Wed, 8 Jun 2011 21:16:59 +0000 (22:16 +0100)]
Coverity: Don't leak error strings.

(Cherry picked from commit 3135b8c378f9f98ae66e37fd79d305764334980d).

13 years agoCoverity: Check return value of sysroot_path.
Richard W.M. Jones [Wed, 8 Jun 2011 21:14:21 +0000 (22:14 +0100)]
Coverity: Check return value of sysroot_path.

For some reason we were checking the parameter!
(cherry picked from commit 7fae594df719d1d81a043c4d0280b359f750facb)

13 years agoCoverity: Check return value of malloc.
Richard W.M. Jones [Wed, 8 Jun 2011 21:07:36 +0000 (22:07 +0100)]
Coverity: Check return value of malloc.
(cherry picked from commit 3a5bd5aba23583e64bfaabc906ca95b0f9d37578)

13 years agoCoverity: Don't close fd_cwd if fd_cwd == -1.
Richard W.M. Jones [Wed, 8 Jun 2011 21:04:25 +0000 (22:04 +0100)]
Coverity: Don't close fd_cwd if fd_cwd == -1.
(cherry picked from commit 76dfb74324fa0daa343d7edf89bd05e1fe7b4db0)

13 years agoCoverity: Avoid calling sort_strings (NULL, 0) on empty list.
Richard W.M. Jones [Wed, 8 Jun 2011 21:01:41 +0000 (22:01 +0100)]
Coverity: Avoid calling sort_strings (NULL, 0) on empty list.
(cherry picked from commit 3ed8d5122026f37dd96cc7e8503c4f3ecf0afbb7)

13 years agoCoverity: Don't call free_strings (NULL).
Richard W.M. Jones [Wed, 8 Jun 2011 20:56:56 +0000 (21:56 +0100)]
Coverity: Don't call free_strings (NULL).
(cherry picked from commit 48ebf50f3136ac27f4252662e351230ffa2b15e5)

13 years agoCoverity: Remove unreachable code.
Richard W.M. Jones [Wed, 8 Jun 2011 20:53:07 +0000 (21:53 +0100)]
Coverity: Remove unreachable code.
(cherry picked from commit 9160eec4fbf12643d8d5fa13465066822b2fed92)

13 years agoinit: Remove timeout in udevadm settle command.
Richard W.M. Jones [Wed, 8 Jun 2011 12:12:01 +0000 (13:12 +0100)]
init: Remove timeout in udevadm settle command.

The given timeout (10s) was too low if the appliance was
running slowly, which caused a cascade of other failures
during tests.

Note that in udev-171 and above on Fedora, /sbin/start_udev
no longer exists, so now we are using this manual method to
start udevd.
(cherry picked from commit bfc02f78f36d88543f8435e450e28c986b667a94)

13 years agoprotocol: Enhance "unexpected end of file when reading from daemon" error.
Richard W.M. Jones [Tue, 7 Jun 2011 11:36:02 +0000 (12:36 +0100)]
protocol: Enhance "unexpected end of file when reading from daemon" error.

Make this error more informative, since it is a common error when the
appliance fails to start up.
(cherry picked from commit 2f73ea343cc4a3433f20e99a7835152767a70f80)

13 years agoOnly include date, not time, in BUGS file.
Richard W.M. Jones [Sat, 4 Jun 2011 21:47:52 +0000 (22:47 +0100)]
Only include date, not time, in BUGS file.

This is so the file does not change so often when using 'make dist'.
(cherry picked from commit cdd11b758f2601f7eeda4fca684638b0335d531a)

13 years agovirt-ls: Small fix for output of --help option.
Richard W.M. Jones [Fri, 3 Jun 2011 13:49:19 +0000 (14:49 +0100)]
virt-ls: Small fix for output of --help option.
(cherry picked from commit 7177340a6f0e3ac1f238c69b0ad5267e18252fe2)

13 years agodaemon: Fix error message.
Nikita A Menkovich [Fri, 20 May 2011 10:26:09 +0000 (11:26 +0100)]
daemon: Fix error message.
(cherry picked from commit 08bc8e40cea750bd35493ecab514e8e37c883a0a)

13 years agoguestfs-examples(3): Remove link to OCaml homepage.
Richard W.M. Jones [Wed, 18 May 2011 14:32:59 +0000 (15:32 +0100)]
guestfs-examples(3): Remove link to OCaml homepage.
(cherry picked from commit 95368927219f2888aeb1232c7ec950dde538bc39)

13 years agoDocument that guestfs_file output depends on file(1) command.
Richard W.M. Jones [Tue, 17 May 2011 19:57:56 +0000 (20:57 +0100)]
Document that guestfs_file output depends on file(1) command.

And therefore practically it cannot be part of the ABI since
the output of file(1) itself changes from time to time.
(cherry picked from commit ef6f877b9df261fad1fbf361b8ce7af1055dfbb7)

13 years agoVersion 1.8.7. 1.8.7
Richard W.M. Jones [Wed, 18 May 2011 10:34:58 +0000 (11:34 +0100)]
Version 1.8.7.

13 years agoinspect: Look for %systemroot%/system32 for Windows heuristic.
Richard W.M. Jones [Thu, 21 Apr 2011 16:33:48 +0000 (17:33 +0100)]
inspect: Look for %systemroot%/system32 for Windows heuristic.

The virt-v2v transfer ISO had a /windows directory.  The core
inspection code thought this was a Windows root filesystem.

Cherry picked and backported from
commit 0da6f55a6745686ca056c6bc8ebf647f111cb8e8.

13 years agolist-applications: If software hive is missing, this is an error.
Richard W.M. Jones [Thu, 21 Apr 2011 16:29:44 +0000 (17:29 +0100)]
list-applications: If software hive is missing, this is an error.

virt-inspector would exit silently if list-applications failed along
this error path.

Cherry picked and backported from
commit 782f3a36469ca396dbf998ea82af2699153be3ed.

13 years agozero: Disable file test because of bug in file command.
Richard W.M. Jones [Wed, 18 May 2011 09:04:05 +0000 (10:04 +0100)]
zero: Disable file test because of bug in file command.

See: https://bugzilla.redhat.com/show_bug.cgi?id=705499
(cherry picked from commit f55b32b2db83495fc0987f0fe0e979818704dff1)

13 years agoVersion 1.8.6. 1.8.6
Richard W.M. Jones [Mon, 18 Apr 2011 22:13:25 +0000 (23:13 +0100)]
Version 1.8.6.

13 years agopython: Release Python GIL while running libguestfs calls.
Richard W.M. Jones [Mon, 18 Apr 2011 15:56:08 +0000 (16:56 +0100)]
python: Release Python GIL while running libguestfs calls.

Release the Python global interpreter lock while running libguestfs
calls.

We don't release it around guestfs_create() because that is a short
call that just allocates memory.  We do release it around
guestfs_close() since that is a potentially long-running (it can call
wait(2) amongst other things).  We also release it around all the
other generated Python calls.

We don't yet support callbacks into Python code (ie. the new event
API).  But when we do in future, we will need to also handle the GIL
around those callbacks.

This code is adapted from libvirt's python/typewrappers.h.  Thanks to
Dan Berrange for showing us how to do this properly.
(cherry picked from commit 08dc4a87b92435678780e9c49fe3bc1e7465d99f)

13 years agofish: Fix typo in guestfish man page (--format option).
Richard W.M. Jones [Sat, 16 Apr 2011 20:26:15 +0000 (21:26 +0100)]
fish: Fix typo in guestfish man page (--format option).
(cherry picked from commit 4c2bb8b301970e8853a8feaa95e3698224640fba)

13 years agoinspector: Handle write failures when creating example-*.xml.
Richard W.M. Jones [Thu, 14 Apr 2011 17:19:04 +0000 (18:19 +0100)]
inspector: Handle write failures when creating example-*.xml.
(cherry picked from commit 0108d7861d4cc9a1f0d87d89080d1be7750e54b5)

13 years agoinspector: Include <hostname> in output.
Richard W.M. Jones [Thu, 14 Apr 2011 16:58:51 +0000 (17:58 +0100)]
inspector: Include <hostname> in output.

Cherry picked from commit 36d3a4ce53317b104d48b60c9fe1ed679065d1d4
and rebased for stable-1.8 branch.

13 years agoVersion 1.8.5. 1.8.5
Richard W.M. Jones [Mon, 11 Apr 2011 10:36:31 +0000 (11:36 +0100)]
Version 1.8.5.

13 years agoCompile rpcgen-generated files with -fno-strict-aliasing
Matthew Booth [Thu, 7 Apr 2011 14:30:54 +0000 (15:30 +0100)]
Compile rpcgen-generated files with -fno-strict-aliasing

rpcgen generates source which can't be safely compiled with strict-aliasing
enabled.
(cherry picked from commit 3a84e0784e1e3ab7b56850d0f8c9aa42f1ae3da1)

13 years agoRename resolve_windows_path_silently to case_sensitive_path_silently.
Richard W.M. Jones [Tue, 5 Apr 2011 17:44:55 +0000 (18:44 +0100)]
Rename resolve_windows_path_silently to case_sensitive_path_silently.

A more accurate description of what this function does.

This is just code motion.
(cherry picked from commit f3eea44f97340f747e46b0df6931a04b53abaf01)

13 years agoedit: Move 'exit 0' to end of file.
Richard W.M. Jones [Tue, 5 Apr 2011 16:46:23 +0000 (17:46 +0100)]
edit: Move 'exit 0' to end of file.

This is just code motion.
(cherry picked from commit 60cdf446063a0ae61c52140355677d7da2327fa2)

13 years agoedit: Let $root == $roots[0].
Richard W.M. Jones [Tue, 5 Apr 2011 16:45:41 +0000 (17:45 +0100)]
edit: Let $root == $roots[0].

This is just code motion.
(cherry picked from commit aed8f220d279e910e0f398fea6fa674cc6a63783)

13 years agocat, edit: Reference guestfish equivalent commands in the manual pages.
Richard W.M. Jones [Tue, 5 Apr 2011 16:44:41 +0000 (17:44 +0100)]
cat, edit: Reference guestfish equivalent commands in the manual pages.
(cherry picked from commit 4de124debf181ff6af38617b80c2355627e38d35)

13 years agopython: Convert any iterable argument to a list (RHBZ#693324).
Richard W.M. Jones [Mon, 4 Apr 2011 11:48:02 +0000 (12:48 +0100)]
python: Convert any iterable argument to a list (RHBZ#693324).

Thanks to Erez Shinan.
(cherry picked from commit afa17809599f3ebc82c3feef025ca812fb26c9fe)

13 years agodaemon: When running commands, restart select if we receive a signal.
Richard W.M. Jones [Fri, 1 Apr 2011 14:27:46 +0000 (15:27 +0100)]
daemon: When running commands, restart select if we receive a signal.
(cherry picked from commit 6e5f64089631622167e60df25ee009ef83df5170)

13 years agodaemon: Reset SIGPIPE to default before running subprocesses.
Richard W.M. Jones [Fri, 1 Apr 2011 14:26:46 +0000 (15:26 +0100)]
daemon: Reset SIGPIPE to default before running subprocesses.
(cherry picked from commit 42938f6faf9e724130be28f8e67d3c291bb81cba)

13 years agoAdd prototype for timeval_diff.
Richard W.M. Jones [Fri, 1 Apr 2011 12:30:24 +0000 (13:30 +0100)]
Add prototype for timeval_diff.

This is just code motion.

Cherry picked from commit 1e6be6afe58de5bfb1ac056b80d3210888edfead.

13 years agodocs: Progress messages don't necessarily reach 100% in the error case.
Richard W.M. Jones [Fri, 1 Apr 2011 12:54:18 +0000 (13:54 +0100)]
docs: Progress messages don't necessarily reach 100% in the error case.

This should be obvious, and now it is documented to avoid any
confusion.
(cherry picked from commit 05dbe09a5c5be3d5f68dc6eb033c4f642fbac8bf)

13 years agoexamples: Use WARN_CFLAGS, WERROR_CFLAGS macros instead of -Wall
Richard W.M. Jones [Thu, 31 Mar 2011 19:18:23 +0000 (20:18 +0100)]
examples: Use WARN_CFLAGS, WERROR_CFLAGS macros instead of -Wall
(cherry picked from commit b41e73008a939ef493d2bfb82c9bd07b0f74736a)

13 years agoexamples: size_t-correctness change in inspect_vm.c
Richard W.M. Jones [Thu, 31 Mar 2011 19:17:02 +0000 (20:17 +0100)]
examples: size_t-correctness change in inspect_vm.c
(cherry picked from commit d5eb5216aae0cb83fae686f490d1c3c37c2c074e)

13 years agocontrib: Fix URLs in README file.
Richard W.M. Jones [Thu, 31 Mar 2011 17:20:08 +0000 (18:20 +0100)]
contrib: Fix URLs in README file.
(cherry picked from commit 1612201a83e732eec7d98d1679dd9dd426bcd10d)

13 years agorescue: Add -w|--rw option.
Richard W.M. Jones [Wed, 30 Mar 2011 15:33:14 +0000 (16:33 +0100)]
rescue: Add -w|--rw option.

Note this has been backported to the 1.8 branch to allow us to write
documentation which refers to the virt-rescue --rw option.  The option
does nothing in 1.8.

(cherry picked from commit 4155d20014b24b2203c4dd8b00e2e19450a7e3bb)

13 years agofuse: Document -w flag in --help output.
Richard W.M. Jones [Wed, 30 Mar 2011 15:32:33 +0000 (16:32 +0100)]
fuse: Document -w flag in --help output.
(cherry picked from commit 3824935411e8a046f0359578978447dd5a0a1a16)

13 years agoExclude po-docs directory completely if po4a not available.
Richard W.M. Jones [Tue, 29 Mar 2011 15:07:21 +0000 (16:07 +0100)]
Exclude po-docs directory completely if po4a not available.

Lift the if HAVE_PO4A ... endif completely out of the po-docs
subdirectory, and just exclude the whole subdirectory if the po4a
program is not available.
(cherry picked from commit 58f7a5a4ac8cce77dfaded1c29f3ad382b4cc9a8)

13 years agotests: Don't fail when compiled without support for NTFS.
Richard W.M. Jones [Tue, 29 Mar 2011 15:03:29 +0000 (16:03 +0100)]
tests: Don't fail when compiled without support for NTFS.
(cherry picked from commit edb7501d60a03107c21f023b256d2b01cf116437)

13 years agoVersion 1.8.4. 1.8.4
Richard W.M. Jones [Tue, 29 Mar 2011 20:36:00 +0000 (21:36 +0100)]
Version 1.8.4.

13 years agoperl: Canonicalize /dev/vd* paths in old inspection code (RHBZ#691724).
Richard W.M. Jones [Tue, 29 Mar 2011 11:20:57 +0000 (12:20 +0100)]
perl: Canonicalize /dev/vd* paths in old inspection code (RHBZ#691724).
(cherry picked from commit 759f4369de965f46f4a93b3a75dada050f87e223)

13 years agoREADME: Note that getfacl, getfattr are optional dependencies.
Richard W.M. Jones [Mon, 28 Mar 2011 16:18:24 +0000 (17:18 +0100)]
README: Note that getfacl, getfattr are optional dependencies.
(cherry picked from commit d82d6f0633f63d4a884147b1e85851e96ff8f58d)

13 years agofuse: Fix getxattr, listxattr calls and add a regression test (RHBZ#691389).
Richard W.M. Jones [Mon, 28 Mar 2011 13:45:23 +0000 (14:45 +0100)]
fuse: Fix getxattr, listxattr calls and add a regression test (RHBZ#691389).

The documentation for the getxattr and listxattr calls is not very
clear and as a result we were always returning something different
from that which the Linux kernel would usually return.

This fixes these calls, at least far enough that both the 'getfattr'
and 'getfacl' programs now work fine on FUSE-mounted filesystems.

Note that SELinux attrs are *not* passed through.  This appears to be
a known bug between SELinux and FUSE.  For more information see:

http://www.spinics.net/lists/selinux/msg09460.html

Cherry picked from commit 0d6fd9e1d2488841c912c5351086e536772837ef:
  - rebased on stable-1.8 branch
  - removed unintended hunk (which changed -m documentation in
      guestmount --help output)
  - removed parts of test-fuse.sh which will fail because
      there is no support for passing acl,user_xattr options in
      an extended -m option

13 years agoRHEL 5: Use mke4fs on RHEL 5 as replacement for mke2fs.
Richard W.M. Jones [Fri, 25 Mar 2011 14:42:40 +0000 (14:42 +0000)]
RHEL 5: Use mke4fs on RHEL 5 as replacement for mke2fs.
(cherry picked from commit a0e3b2183733c7440ad017c4ffe361935672339b)

13 years agomkfs: Force mke2fs to create a filesystem even on raw IDE device (RHBZ#690819).
Richard W.M. Jones [Fri, 25 Mar 2011 14:34:31 +0000 (14:34 +0000)]
mkfs: Force mke2fs to create a filesystem even on raw IDE device (RHBZ#690819).
(cherry picked from commit 227bea6c7ef89b707fe2c01c4d0d0fb9081e8c04)

13 years agoRename $tmpdir/sock to $tmpdir/guestfsd.sock.
Richard W.M. Jones [Fri, 25 Mar 2011 12:32:08 +0000 (12:32 +0000)]
Rename $tmpdir/sock to $tmpdir/guestfsd.sock.

No functional change; this simply makes the purpose of the
socket clearer.
(cherry picked from commit 110bfe1fcc9964b82acf7df6d4d60774471f9157)

13 years agofish: Add better quick help to --help output.
Richard W.M. Jones [Tue, 22 Mar 2011 11:50:26 +0000 (11:50 +0000)]
fish: Add better quick help to --help output.
(cherry picked from commit 0daf7e81a659bcdc1ce327151cc1207b124a35a1)

13 years agofish: Add -w|--rw option to --help output.
Richard W.M. Jones [Tue, 22 Mar 2011 11:50:03 +0000 (11:50 +0000)]
fish: Add -w|--rw option to --help output.
(cherry picked from commit c8faa5d0b0a17689d27bd33bc787ba0fe9a3f076)

13 years agoinspect: Don't fail for Windows guests with multiple disks (RHBZ#674130).
Richard W.M. Jones [Tue, 22 Mar 2011 11:20:38 +0000 (11:20 +0000)]
inspect: Don't fail for Windows guests with multiple disks (RHBZ#674130).

Cherry picked from commit d06fee159c14d4fe7654a02bae8849c4f82565f8
and backported to stable-1.8 branch.

13 years agoinspect: Simplify Windows root heuristic code.
Richard W.M. Jones [Tue, 22 Mar 2011 11:05:21 +0000 (11:05 +0000)]
inspect: Simplify Windows root heuristic code.

Add special is_file_nocase and is_dir_nocase functions and
remove the duplicate checks for files and directories with
different cases.
(cherry picked from commit 5776c145d411e5ae00072ecf422055f3d0bd29e2)

13 years agoVersion 1.8.3. 1.8.3
Richard W.M. Jones [Mon, 21 Mar 2011 11:58:47 +0000 (11:58 +0000)]
Version 1.8.3.