Richard Jones [Fri, 22 Jan 2010 11:01:06 +0000 (11:01 +0000)]
guestfish: Use xstrtol to parse integers (RHBZ#557655).
Current code uses atoi to parse the generator Int type and
atoll to parse the generator Int64 type. The problem with the
ato* functions is that they don't cope with errors very well,
and they cannot parse numbers that begin with 0.. or 0x..
for octal and hexadecimal respectively.
This replaces the atoi call with a call to Gnulib xstrtol
and the atoll call with a call to Gnulib xstrtoll.
The generated code looks like this for all Int arguments:
{
strtol_error xerr;
long r;
xerr = xstrtol (argv[0], NULL, 0, &r, "");
if (xerr != LONGINT_OK) {
fprintf (stderr,
_("%s: %s: invalid integer parameter (%s returned %d)\n"),
cmd, "memsize", "xstrtol", xerr);
return -1;
}
/* The Int type in the generator is a signed 31 bit int. */
if (r < (-(2LL<<30)) || r > ((2LL<<30)-1)) {
fprintf (stderr, _("%s: %s: integer out of range\n"), cmd, "memsize");
return -1;
}
/* The check above should ensure this assignment does not overflow. */
memsize = r;
}
and like this for all Int64 arguments (note we don't need the
range check for these):
{
strtol_error xerr;
long long r;
xerr = xstrtoll (argv[1], NULL, 0, &r, "");
if (xerr != LONGINT_OK) {
fprintf (stderr,
_("%s: %s: invalid integer parameter (%s returned %d)\n"),
cmd, "size", "xstrtoll", xerr);
return -1;
}
size = r;
}
Note this also fixes an unrelated bug in guestfish handling of
RBufferOut. We were using 'fwrite' without checking the return
value, and this could have caused silent failures, eg. in the case
where there was not enough disk space to store the resulting file,
or even if the program was interrupted (but continued) during the
write.
Replace this with Gnulib 'full-write', and check the return value
and report errors.
Richard Jones [Mon, 25 Jan 2010 11:34:56 +0000 (11:34 +0000)]
Add 'filesize' call.
Returns the size of a file. You can already do this with 'stat',
but this call is good for scripting.
Richard Jones [Thu, 21 Jan 2010 10:54:34 +0000 (10:54 +0000)]
Missing crc kernel module on RHEL 6 / Linux 2.6.32 (fixes RHBZ#557195)
Richard Jones [Fri, 15 Jan 2010 14:06:32 +0000 (14:06 +0000)]
hivex: Various improvements in header parsing, thanks to better documentation.
Richard Jones [Fri, 15 Jan 2010 12:42:02 +0000 (12:42 +0000)]
hivex: Print header fields. Print all offsets in hex (in debug output).
Richard Jones [Fri, 15 Jan 2010 12:41:34 +0000 (12:41 +0000)]
hivex: Reenable checksum calculations, but don't check result.
Richard Jones [Fri, 15 Jan 2010 12:40:56 +0000 (12:40 +0000)]
hivex: Update documentation.
Richard Jones [Thu, 14 Jan 2010 16:46:13 +0000 (16:46 +0000)]
hivex: Send all debug messages to stderr.
Richard Jones [Thu, 14 Jan 2010 16:45:59 +0000 (16:45 +0000)]
hivex: Remove stray debugging message.
Richard Jones [Thu, 14 Jan 2010 16:29:47 +0000 (16:29 +0000)]
hivex: Documentation: Add environment variables section.
Richard Jones [Thu, 14 Jan 2010 16:29:40 +0000 (16:29 +0000)]
hivex: Whitespace change.
Richard Jones [Thu, 14 Jan 2010 16:21:47 +0000 (16:21 +0000)]
hivex: Move STR* macros into C file.
Don't pollute the public header file with these macros.
Richard Jones [Thu, 14 Jan 2010 13:26:46 +0000 (13:26 +0000)]
hivex: Small updates to the documentation.
Richard Jones [Wed, 13 Jan 2010 14:55:04 +0000 (14:55 +0000)]
Fix generation of HTML documentation for website.
Richard Jones [Wed, 13 Jan 2010 13:08:30 +0000 (13:08 +0000)]
Add guestfs.pod and guestfish.pod to EXTRA_DIST.
Richard Jones [Wed, 13 Jan 2010 13:03:28 +0000 (13:03 +0000)]
Prepare for version 1.0.81.
Richard Jones [Wed, 13 Jan 2010 11:24:44 +0000 (11:24 +0000)]
Update to latest Gnulib.
Richard Jones [Thu, 7 Jan 2010 12:21:42 +0000 (12:21 +0000)]
qemu: Upstream regression of -stdio serial option.
Best explained by the comment in the code:
/* Newer versions of qemu (from around 2009/12) changed the
* behaviour of monitors so that an implicit '-monitor stdio' is
* assumed if we are in -nographic mode and there is no other
* -monitor option. Only a single stdio device is allowed, so
* this broke the '-serial stdio' option. There is a new flag
* called -nodefaults which gets rid of all this default crud, so
* let's use that to avoid this and any future surprises.
*/
Richard Jones [Wed, 6 Jan 2010 09:55:57 +0000 (09:55 +0000)]
inspector: Update example XML and RNG schema.
This updates commit
a59dcdbd1b0a28c960e3792165a13f2daf4f6c35.
Richard Jones [Tue, 5 Jan 2010 23:04:57 +0000 (23:04 +0000)]
inspector: Make RPM application data more specific (RHBZ#552718).
List applications with epoch, release and arch data.
If epoch is 0, don't store this as an empty string, but as
undefined, and don't output empty <epoch/> element in the XML.
Richard Jones [Mon, 4 Jan 2010 15:39:49 +0000 (15:39 +0000)]
Use linker script to control visibility of symbols.
Richard Jones [Mon, 4 Jan 2010 14:55:24 +0000 (14:55 +0000)]
generator: Move all library generation code together.
Richard Jones [Mon, 4 Jan 2010 14:40:08 +0000 (14:40 +0000)]
generator: Print total lines of generated code.
Richard Jones [Mon, 4 Jan 2010 14:51:36 +0000 (14:51 +0000)]
C#: Add documentation about experimental nature of these bindings.
Richard Jones [Sat, 2 Jan 2010 19:46:20 +0000 (19:46 +0000)]
Experimental C# bindings.
Tested in only limited situations, with Mono on Linux.
Richard Jones [Sat, 2 Jan 2010 19:47:37 +0000 (19:47 +0000)]
Update copyright years.
Richard Jones [Thu, 31 Dec 2009 12:26:04 +0000 (12:26 +0000)]
Move guestfs(3) and guestfish(1) man pages into subdirectories.
These manual pages have for a very long time 'lived' in the top
source directory.
Clean up this situation by moving those manual pages (plus associated
generated files) into the src/ and fish/ subdirectories respectively.
Richard Jones [Thu, 31 Dec 2009 12:16:10 +0000 (12:16 +0000)]
generator: Move src/guestfs-bindtests.c next to other src/ files.
Richard Jones [Thu, 31 Dec 2009 11:51:48 +0000 (11:51 +0000)]
generator: Use Continuation Passing Style (CPS) in output_to function.
This makes the code simpler, shorter and less error-prone.
Richard Jones [Thu, 31 Dec 2009 11:29:49 +0000 (11:29 +0000)]
generator: Rename GPLv2 to GPLv2plus, LGPLv2 to LGPLv2plus.
The licenses are "any later version", so reflect this in the
naming of the parameter to generate_header.
Richard Jones [Thu, 31 Dec 2009 11:22:26 +0000 (11:22 +0000)]
generated code: Set copyright years to 2009-xxxx when current year > 2009.
Richard Jones [Thu, 31 Dec 2009 11:20:56 +0000 (11:20 +0000)]
Remove separate inspector_generator.ml, combine this with generator.ml.
This commit combines the previously separate "inspector_generator.ml"
program which generated bindings for virt-inspector.
Having two separate programs caused no end of troubles for developers,
so we now combine them into a single program.
NOTE: OCaml xml-light is now *required* in order to rebuild the
generated code.
Richard Jones [Thu, 31 Dec 2009 10:52:08 +0000 (10:52 +0000)]
generator: Comment and whitespace changes only.
Richard Jones [Fri, 18 Dec 2009 19:20:37 +0000 (19:20 +0000)]
daemon: Work around udevsettle issue (RHBZ#548121).
Richard Jones [Wed, 16 Dec 2009 11:53:48 +0000 (11:53 +0000)]
Prepare for 1.0.80.
Richard Jones [Wed, 16 Dec 2009 11:57:51 +0000 (11:57 +0000)]
Include latest Polish translations (Piotr Drąg, RHBZ#502533).
Richard Jones [Wed, 16 Dec 2009 11:55:21 +0000 (11:55 +0000)]
Update PO files.
Richard Jones [Wed, 16 Dec 2009 11:54:53 +0000 (11:54 +0000)]
build: Fix typo in filename.
Richard Jones [Wed, 16 Dec 2009 11:53:30 +0000 (11:53 +0000)]
build: Remove references to old contrib/ files which were removed.
Richard Jones [Wed, 16 Dec 2009 11:15:26 +0000 (11:15 +0000)]
appliance: Special case handling for libbfd in the supermin appliance.
The libbfd library has a constantly changing, non-standard and
very long name, eg:
/usr/lib64/libbfd-2.20.51.0.2-7.fc13.so
Just add a special case to deal with this. This fixes the guestfs_strings
command, which relies on the external strings binary which uses this
library.
Richard Jones [Wed, 16 Dec 2009 11:04:10 +0000 (11:04 +0000)]
appliance: Ignore unreadable dbus helper programs.
Richard Jones [Mon, 7 Dec 2009 11:28:21 +0000 (11:28 +0000)]
lib: Link with $(LTLIBTHREAD), required by Gnulib lock module.
This fixes commit
cada248a53858341c91f70392e8f5b6e47d9b4fe.
Matthew Booth [Fri, 4 Dec 2009 15:38:09 +0000 (15:38 +0000)]
appliance: Fix code which gets list of kernels.
The first 'ls' command was failing, so the second 'ls' command
would never run at all.
Jim Meyering [Fri, 4 Dec 2009 15:34:41 +0000 (15:34 +0000)]
accommodate leading "+" in git submodule output
* cfg.mk (_submodule_hash): Also filter out "+".
* autogen.sh: Likewise.
Richard Jones [Fri, 4 Dec 2009 14:35:55 +0000 (14:35 +0000)]
lib: Add thread-safety to global list of handles.
This commit uses the Gnulib 'lock' module to implement a mutex on
the global list of handles which is stored by the library.
Note that Gnulib nicely avoids explicitly linking with -lpthread
unless the application program itself links to -lpthread. Locks
are only enabled in multithreaded applications.
$ ldd src/.libs/libguestfs.so.0.217.0
linux-vdso.so.1 => (0x00007fffcb7ff000)
libc.so.6 => /lib64/libc.so.6 (0x00007f96a4e6c000)
/lib64/ld-linux-x86-64.so.2 (0x00007f96a544d000)
Please enter the commit message for your changes. Lines starting
Richard Jones [Mon, 30 Nov 2009 14:11:20 +0000 (14:11 +0000)]
daemon error handling: Define a new function reply_with_perror_errno.
This allows you to save the errno from a previous call and
pass it to reply_with_perror.
For example, original code:
r = some_system_call ();
err = errno;
do_cleanup ();
errno = err;
if (r == -1) {
reply_with_perror ("failed");
return -1;
}
can in future be changed to:
r = some_system_call ();
err = errno;
do_cleanup ();
if (r == -1) {
reply_with_perror_errno (err, "failed");
return -1;
}
Richard Jones [Fri, 27 Nov 2009 14:14:21 +0000 (14:14 +0000)]
daemon error handling: recursive_mkdir shouldn't need to set errno.
Richard Jones [Mon, 30 Nov 2009 13:55:04 +0000 (13:55 +0000)]
daemon error handling: Clear errno before calling stub functions.
This just ensures that we accurately report errors, even if our
error path code doesn't set errno. We won't end up with a bogus
errno left over from a previous call.
Richard Jones [Fri, 27 Nov 2009 13:42:43 +0000 (13:42 +0000)]
Whitespace change.
Richard Jones [Thu, 26 Nov 2009 22:33:52 +0000 (22:33 +0000)]
virt-rescue: Freshen documentation.
Richard Jones [Thu, 26 Nov 2009 22:32:15 +0000 (22:32 +0000)]
guestfish: Freshen documentation.
Richard Jones [Thu, 26 Nov 2009 15:38:48 +0000 (15:38 +0000)]
daemon: Move prototypes around to keep functions grouped logically.
Richard Jones [Thu, 26 Nov 2009 16:06:03 +0000 (16:06 +0000)]
Fix error handling in 'zero' function.
Richard Jones [Thu, 26 Nov 2009 15:17:37 +0000 (15:17 +0000)]
daemon/Win32: Add contributed test script to test daemon using Wine.
This test script allows you to test limited features of the
Windows daemon by running it on a standard Fedora host using
Wine.
Read contrib/README and contrib/guestfsd-in-wine.sh in detail
before using.
Richard Jones [Thu, 26 Nov 2009 14:42:54 +0000 (14:42 +0000)]
Ignore guestfsd.exe (Windows daemon).
Richard Jones [Thu, 26 Nov 2009 14:34:35 +0000 (14:34 +0000)]
Remove old contrib/febootstrap directory.
Richard Jones [Thu, 26 Nov 2009 14:26:44 +0000 (14:26 +0000)]
Update PO files.
Richard Jones [Thu, 26 Nov 2009 14:13:27 +0000 (14:13 +0000)]
Make realpath call optional, disable it for Windows.
Richard Jones [Thu, 26 Nov 2009 11:58:27 +0000 (11:58 +0000)]
build: update gnulib submodule to latest
Richard Jones [Thu, 26 Nov 2009 13:23:56 +0000 (13:23 +0000)]
daemon: program_name must be defined for Gnulib error module.
Richard Jones [Thu, 26 Nov 2009 11:52:28 +0000 (11:52 +0000)]
daemon/Win32: use gnulib modules connect, socket and symlinkat (for readlinkat).
Richard Jones [Thu, 26 Nov 2009 11:26:40 +0000 (11:26 +0000)]
daemon/Win32: provide htonl, htons, ntohl, ntohs functions.
These functions are not available on Windows.
Richard Jones [Thu, 26 Nov 2009 11:13:00 +0000 (11:13 +0000)]
daemon/Win32: Use Gnulib perror module.
Richard Jones [Thu, 26 Nov 2009 11:01:01 +0000 (11:01 +0000)]
daemon: Link guestfs_protocol.[ch] into the daemon directory.
Instead of doing a recursive call into the src/ directory to build
the object files, hard link the source files into the daemon
directory and build them separately.
See:
http://www.redhat.com/archives/libguestfs/2009-November/msg00254.html
Thanks to Jim Meyering for noticing a typo in the original version.
Richard Jones [Thu, 26 Nov 2009 10:52:37 +0000 (10:52 +0000)]
daemon: Typo generator_build -> generator_built
Richard Jones [Thu, 26 Nov 2009 09:31:35 +0000 (09:31 +0000)]
daemon: Indent C macros to reflect nesting level.
Richard Jones [Thu, 26 Nov 2009 09:29:02 +0000 (09:29 +0000)]
daemon/Win32: Win32 can't fork message moved to separate function (Jim Meyering)
Richard Jones [Wed, 25 Nov 2009 22:20:22 +0000 (22:20 +0000)]
guestfs documentation: Missing space.
Richard Jones [Wed, 25 Nov 2009 21:41:51 +0000 (21:41 +0000)]
guestfs: Update architecture section of documentation.
Richard Jones [Wed, 25 Nov 2009 17:12:00 +0000 (17:12 +0000)]
Update PO files.
Richard Jones [Wed, 25 Nov 2009 17:10:33 +0000 (17:10 +0000)]
daemon: Fix build on Unix.
Richard Jones [Wed, 25 Nov 2009 16:54:46 +0000 (16:54 +0000)]
daemon: Fix sync() call on Unix.
Richard Jones [Wed, 25 Nov 2009 16:33:00 +0000 (16:33 +0000)]
daemon/Win32: update comment
Richard Jones [Wed, 25 Nov 2009 15:00:19 +0000 (15:00 +0000)]
daemon/Win32: Supply MAX macro for challenged platforms.
Richard Jones [Wed, 25 Nov 2009 14:59:30 +0000 (14:59 +0000)]
daemon/Win32: Windows can't daemonize.
Richard Jones [Wed, 25 Nov 2009 14:56:42 +0000 (14:56 +0000)]
daemon/Win32: Windows replacement for umask.
Richard Jones [Wed, 25 Nov 2009 14:53:17 +0000 (14:53 +0000)]
daemon/Win32: Replace setenv with Win32 equivalent.
Richard Jones [Wed, 25 Nov 2009 14:45:20 +0000 (14:45 +0000)]
daemon/Win32: Use xdr_u_int for PortableXDR compatibility.
PortableXDR didn't support xdr_uint32_t. xdr_u_int is the same type.
Richard Jones [Wed, 25 Nov 2009 14:40:52 +0000 (14:40 +0000)]
daemon/Win32: Don't bother blocking SIGPIPE on Win32.
Richard Jones [Wed, 25 Nov 2009 14:40:39 +0000 (14:40 +0000)]
daemon/Win32: Use gnulib getaddrinfo module.
Richard Jones [Wed, 25 Nov 2009 13:07:05 +0000 (13:07 +0000)]
daemon/Win32: Implement statvfs using GetDiskFreeSpaceEx.
At the time of writing Gnulib didn't support Win32 for its
fsusage API. Therefore this patch uses GetDiskFreeSpaceEx
if it's available (on Windows) otherwise falls back to using
Gnulib fsusage.
Richard Jones [Wed, 25 Nov 2009 12:24:01 +0000 (12:24 +0000)]
daemon: Move statvfs code into separate file.
This makes no functional change to the code. It just moves the
statvfs-related code out of daemon/stat.c into a new file called
daemon/statvfs.c.
Richard Jones [Wed, 25 Nov 2009 12:17:10 +0000 (12:17 +0000)]
daemon: Use gnulib futimens module.
Instead of checking for futimens support and falling back
(incorrectly in one case) to using futimes, use gnulib's
module.
However the gnulib module does not yet support Win32, so
this change is only really useful on platforms like RHEL 5.
Richard Jones [Wed, 25 Nov 2009 11:59:20 +0000 (11:59 +0000)]
daemon/Win32: Use gnulib pread module.
Richard Jones [Wed, 25 Nov 2009 10:26:48 +0000 (10:26 +0000)]
sync: Windows implementation of sync() call.
Replace calls to sync() with calls to sync_disks() which supports
Win32 via FlushFileBuffers.
Richard Jones [Tue, 24 Nov 2009 16:16:08 +0000 (16:16 +0000)]
daemon: Alternate implementation of posix_fallocate.
If the posix_fallocate function is not available [ie. Windows]
use an alternate implementation that just loops and writes.
Richard Jones [Tue, 24 Nov 2009 16:10:13 +0000 (16:10 +0000)]
dd: Missing include of <string.h>
Breaks compilation on Windows.
Richard Jones [Wed, 25 Nov 2009 11:38:44 +0000 (11:38 +0000)]
daemon/Windows: Define _WIN32_WINNT when compiling on Windows.
Richard Jones [Wed, 25 Nov 2009 16:24:49 +0000 (16:24 +0000)]
build: update gnulib submodule to latest
Richard Jones [Wed, 25 Nov 2009 15:29:39 +0000 (15:29 +0000)]
build: update gnulib submodule to latest
Richard Jones [Tue, 24 Nov 2009 18:17:07 +0000 (18:17 +0000)]
supermin: Die with an error if no kernels found (RHBZ#539746).
Updated with a suggestion from Jim Meyering to use the '-d'
option to ls to avoid a future case of directories matching.
Richard Jones [Tue, 24 Nov 2009 15:19:08 +0000 (15:19 +0000)]
New tool: virt-list-filesystems
Use this program as a convenient way to list the filesystems
available in a disk image or libvirt guest.
Example:
$ virt-list-filesystems /dev/vg_trick/Debian5x64
/dev/debian5x64/home
/dev/debian5x64/root
/dev/debian5x64/tmp
/dev/debian5x64/usr
/dev/debian5x64/var
/dev/sda1
This is designed to make it easier for novices to use guestfish
and guestmount. In particular with guestmount this acts as a way
to get a list of filesystems to use with the '-m' option. ie:
$ virt-list-filesystems unknowndisk.img
/dev/sda1
/dev/sda2
$ guestmount -a unknowndisk.img -m /dev/sda1 /mnt
Richard Jones [Tue, 24 Nov 2009 14:27:56 +0000 (14:27 +0000)]
availability: Document how to check for single API calls
This documents how to use autotools and dlopen(3) to test for
the availability of single API calls at compile time and run time
respectively.
Richard Jones [Tue, 24 Nov 2009 14:05:57 +0000 (14:05 +0000)]
availability: Add a test for this call.
Because all the tested groups are optional, there's not really
a group we can reliably test, therefore test against the
empty list (which should not fail).
Richard Jones [Tue, 24 Nov 2009 14:00:34 +0000 (14:00 +0000)]
availability: Clarify and fix documentation.
Richard Jones [Tue, 24 Nov 2009 14:04:28 +0000 (14:04 +0000)]
generator: Passing "" to StringList tests should turn into empty list.
This is a bug in the generator which wasn't being tickled. If
you had a test which expected a StringList or DeviceList parameter,
and you passed "" to that test, then you'd (probably) expect to be
testing an empty list, but in fact you got a single element list
containing an empty string. This fixes it so you get an empty list.
Richard Jones [Tue, 24 Nov 2009 16:00:23 +0000 (16:00 +0000)]
daemon: Fix return value from aug_defnode.
Bug fix - the return value from this function was wrong
in the no-Augeas case.
Richard Jones [Sun, 22 Nov 2009 19:15:56 +0000 (19:15 +0000)]
Implement 'dd' command.
Richard Jones [Sun, 22 Nov 2009 19:14:48 +0000 (19:14 +0000)]
Use STRPREFIX instead of STREQLEN.
Richard Jones [Sun, 22 Nov 2009 19:14:19 +0000 (19:14 +0000)]
generator: second parameter to upload is Dev_or_Path, not String.