Richard W.M. Jones [Fri, 6 May 2011 16:23:00 +0000 (12:23 -0400)]
fish: Allow -d UUID (specify libvirt domains by UUID).
This applies in all the commands which use the common C option parsing
code, ie:
* guestfish
* guestmount
* virt-cat
* virt-df
* virt-filesystems
* virt-inspector
* virt-ls
* virt-rescue
Richard W.M. Jones [Fri, 6 May 2011 16:21:01 +0000 (12:21 -0400)]
add-domain: Add allowuuid flag to allow UUIDs to be used for names.
This makes a backwards-compatible change to the add-domain API. If
the optional allowuuid flag is true then UUIDs can be used instead of
names in the domain name parameter.
Richard W.M. Jones [Fri, 6 May 2011 16:32:59 +0000 (12:32 -0400)]
add-domain: Suppress libvirt errors on stderr.
Install an error handler on the libvirt error connection so that
errors are not printed on stderr (instead they go up through the usual
libguestfs error mechanism).
Unfortunately this doesn't suppress initial connection error messages
to stderr. I cannot see how to do this without affecting the global
libvirt error handler, which is not acceptable for a library to be
doing.
Richard W.M. Jones [Sun, 1 May 2011 21:41:20 +0000 (17:41 -0400)]
doc: Use I<-...> for cross-references to command line options.
This is now used consistently across all the documentation.
Richard W.M. Jones [Sun, 1 May 2011 18:53:23 +0000 (14:53 -0400)]
df: Refresh virt-df(1) man page.
Add examples.
Refresh description.
Use I<...> to refer to command line options.
Richard W.M. Jones [Sun, 1 May 2011 00:11:21 +0000 (20:11 -0400)]
guestfs(3): Note that host file size limits affect guest disk limits.
Richard W.M. Jones [Sat, 30 Apr 2011 23:38:20 +0000 (19:38 -0400)]
guestfs(3): Refresh documentation for private data area keys.
Richard W.M. Jones [Sat, 30 Apr 2011 23:26:08 +0000 (19:26 -0400)]
guestfs(3): Document that old callback functions still work.
Richard W.M. Jones [Sat, 30 Apr 2011 23:10:52 +0000 (19:10 -0400)]
guestfs(3): Referenced section is above, not below.
Richard W.M. Jones [Sat, 30 Apr 2011 23:10:25 +0000 (19:10 -0400)]
guestfs(3): Refresh autosync gotcha documentation.
Richard W.M. Jones [Sat, 30 Apr 2011 22:45:56 +0000 (18:45 -0400)]
guestfs(3): Writing to a file descriptor, not just a pipe.
Richard W.M. Jones [Sat, 30 Apr 2011 22:31:06 +0000 (18:31 -0400)]
guestfs(3): Refresh documentation for guestfs_create, guestfs_close.
Richard W.M. Jones [Sat, 30 Apr 2011 09:55:27 +0000 (05:55 -0400)]
Add a trace message to guestfs_close.
Only the "first half" (ie. the call) is traced, because by the time
the function returns the handle has gone and there's no way to
generate events.
You should see:
libguestfs: trace: close
Richard W.M. Jones [Sat, 30 Apr 2011 09:49:06 +0000 (05:49 -0400)]
internal: Use size_t instead of int for command line size.
Richard W.M. Jones [Sat, 30 Apr 2011 09:45:26 +0000 (05:45 -0400)]
guestfs_close: Move local variables close to code that uses them.
This is just code motion.
Richard W.M. Jones [Sat, 30 Apr 2011 09:42:43 +0000 (05:42 -0400)]
guestfs_close: Remove unused local variable.
Richard W.M. Jones [Wed, 27 Apr 2011 19:10:24 +0000 (20:10 +0100)]
guestfs(3): Document limits.
Richard W.M. Jones [Tue, 26 Apr 2011 10:00:10 +0000 (11:00 +0100)]
todo: Integrate with CMDBs (thanks Quinten Laureijs).
Richard W.M. Jones [Fri, 22 Apr 2011 21:53:07 +0000 (22:53 +0100)]
python: Ensure Python GIL state is correct during callback.
This updates commit
2cac52000a6a96a583af72e289a4296c596047d5.
Richard W.M. Jones [Fri, 22 Apr 2011 21:26:02 +0000 (22:26 +0100)]
Version 1.11.3.
Richard W.M. Jones [Fri, 22 Apr 2011 20:36:41 +0000 (21:36 +0100)]
python: Implement new event API.
This implements set_event_callback and delete_event_callback so that
Python programs can use the new event mechanism.
Richard W.M. Jones [Fri, 22 Apr 2011 18:58:29 +0000 (19:58 +0100)]
python: Rearrange C files for bindings.
Move the hand-written functions into two new files:
guestfs-py.h and guestfs-py-byhand.c
This is just code motion.
Richard W.M. Jones [Fri, 22 Apr 2011 20:34:08 +0000 (21:34 +0100)]
perl: Decrement refcount in $g->delete_event_callback.
This updates commit
bc468c87d04b34faacd208c49cca4a5096e5103c.
Richard W.M. Jones [Thu, 21 Apr 2011 16:33:48 +0000 (17:33 +0100)]
inspect: Look for %systemroot%/system32 for Windows heuristic.
The virt-v2v transfer ISO had a /windows directory. The core
inspection code thought this was a Windows root filesystem.
Richard W.M. Jones [Thu, 21 Apr 2011 16:29:44 +0000 (17:29 +0100)]
list-applications: If software hive is missing, this is an error.
virt-inspector would exit silently if list-applications failed along
this error path.
Richard W.M. Jones [Thu, 21 Apr 2011 14:09:11 +0000 (15:09 +0100)]
inspect: "centos" and "scientificlinux" are now separate distros.
Previously we returned "rhel" for these, which was not accurate.
Richard W.M. Jones [Thu, 21 Apr 2011 13:47:57 +0000 (14:47 +0100)]
Update TODO.
Richard W.M. Jones [Mon, 18 Apr 2011 20:47:45 +0000 (21:47 +0100)]
Version 1.11.2.
Richard W.M. Jones [Mon, 18 Apr 2011 15:56:08 +0000 (16:56 +0100)]
python: Release Python GIL while running libguestfs calls.
Release the Python global interpreter lock while running libguestfs
calls.
We don't release it around guestfs_create() because that is a short
call that just allocates memory. We do release it around
guestfs_close() since that is a potentially long-running (it can call
wait(2) amongst other things). We also release it around all the
other generated Python calls.
We don't yet support callbacks into Python code (ie. the new event
API). But when we do in future, we will need to also handle the GIL
around those callbacks.
This code is adapted from libvirt's python/typewrappers.h. Thanks to
Dan Berrange for showing us how to do this properly.
Richard W.M. Jones [Sat, 16 Apr 2011 20:35:11 +0000 (21:35 +0100)]
fish: --rw option will be mandatory in 1.12 not 1.10.
Richard W.M. Jones [Sat, 16 Apr 2011 20:26:15 +0000 (21:26 +0100)]
fish: Fix typo in guestfish man page (--format option).
Richard W.M. Jones [Sat, 16 Apr 2011 20:12:53 +0000 (21:12 +0100)]
inspector: Refresh the virt-inspector(1) manpage.
Richard W.M. Jones [Sat, 16 Apr 2011 14:29:58 +0000 (15:29 +0100)]
run script: Don't depend on libtool being installed.
Also use 'exec' to run the program.
Richard W.M. Jones [Sat, 16 Apr 2011 13:57:33 +0000 (14:57 +0100)]
Version 1.11.1.
Richard W.M. Jones [Sat, 16 Apr 2011 13:56:38 +0000 (14:56 +0100)]
Add images/guestfs-aux/fedora-packages.db{,.txt} to EXTRA_DIST.
This updates commit
d95874db3dc6c415061b86275d03770b4f28ffbb.
Richard W.M. Jones [Sat, 16 Apr 2011 06:28:47 +0000 (07:28 +0100)]
Remove local LIBGUESTFS_PATH detection from guestfish and guestmount.
Remove the hack that let you run ./fish/guestfish or
./fuse/guestmount. You now have to do:
./run ./fish/guestfish
or
./run ./fuse/guestmount
to run these programs without installing.
Richard W.M. Jones [Fri, 15 Apr 2011 20:43:20 +0000 (21:43 +0100)]
Remove ad-hoc run*locally scripts, replace with './run'
Remove all the run*locally scripts and replace with a single top level
./run shell script.
Richard W.M. Jones [Thu, 14 Apr 2011 17:19:04 +0000 (18:19 +0100)]
inspector: Handle write failures when creating example-*.xml.
Richard W.M. Jones [Thu, 14 Apr 2011 17:17:43 +0000 (18:17 +0100)]
Delete file so db_load doesn't run incrementally.
It turns out that db_load incrementally updates the database (instead
of writing a new one). Remove the old database to force db_load to
write a new one.
This also ensures that we handle write failure gracefully.
Richard W.M. Jones [Thu, 14 Apr 2011 16:58:51 +0000 (17:58 +0100)]
inspector: Include <hostname> in output.
Richard W.M. Jones [Thu, 14 Apr 2011 16:53:48 +0000 (17:53 +0100)]
inspect: Get version and release of RPM packages.
This commit downloads the Packages RPM database allowing us to find
other details about installed RPM packages (via
inspect-list-applications). This adds version and release. Epoch
cannot yet be found.
This commit also updates the Fedora example image so that it contains
a dummy RPM Packages database with some data.
Richard W.M. Jones [Thu, 14 Apr 2011 12:28:02 +0000 (13:28 +0100)]
inspect: Abstract out db_dump code for listing RPM applications.
There are two changes here:
(1) The code for listing RPM applications ran db_dump and parsed the
output. We abstract out that parsing code into a separate reusable
module (src/dbdump.c).
(2) The old db_dump parsing code used db_dump -p (printable) format.
Instead use db_dump -k (hex) format so we can read binary fields.
Richard W.M. Jones [Wed, 13 Apr 2011 22:27:05 +0000 (23:27 +0100)]
inspect: Split code into separate files.
The src/inspect.c file had grown rather large -- 3,500 lines. Split
it across several files according to function.
This is just moving code.
After the split the files are more evenly divided:
536 src/inspect_apps.c
766 src/inspect.c
537 src/inspect_fs.c
404 src/inspect_fs_cd.c
785 src/inspect_fs_unix.c
535 src/inspect_fs_windows.c
3563 total
Richard W.M. Jones [Wed, 13 Apr 2011 22:02:45 +0000 (23:02 +0100)]
inspect: Move shared PCRE match functions to separate file.
This is just moving code around.
Richard W.M. Jones [Wed, 13 Apr 2011 21:35:35 +0000 (22:35 +0100)]
inspect: Cache downloaded files in the handle g->tmpdir.
During inspection we download various files such as the Windows
'software' and 'system' registries. Previously these were downloaded
as temporary files and discarded immediately after use. This meant
that the 'software' registry was being downloaded twice by
virt-inspector (it's required once for basic OS inspection, and a
second time to list Windows applications).
This commit changes this so that these files are cached in g->tmpdir,
and thus the second time we just reuse the file we've already
downloaded.
Callers shouldn't be relying on inspect-list-applications to reread
the actual registry from the VM (unless you close and reopen the
handle). It says in the documentation that the results of inspection
may be cached in the handle.
Richard W.M. Jones [Wed, 13 Apr 2011 21:02:08 +0000 (22:02 +0100)]
Remove temporary directory containing arbitrary files.
In preparation for caching inspection information in the temporary
directory (g->tmpdir), allow the temporary directory to contain
arbitrary files, and remove all of them when the handle is closed.
This just generalizes the previous method of cleaning up the tmpdir.
Jim Meyering [Wed, 13 Apr 2011 13:17:32 +0000 (15:17 +0200)]
Include string.h and libintl.h, as needed.
* df/df.c: As above.
* df/main.c: As above.
* df/output.c: As above.
* fuse/guestmount.c: As above.
* inspector/virt-inspector.c: As above.
* rescue/virt-rescue.c: As above.
Jim Meyering [Wed, 13 Apr 2011 11:15:39 +0000 (13:15 +0200)]
Add more missing include directives.
* cat/virt-cat.c: Include string.h and libintl.h.
* cat/virt-filesystems.c: Likewise.
* cat/virt-ls.c: Likewise.
Nikita A Menkovich [Wed, 13 Apr 2011 11:41:27 +0000 (12:41 +0100)]
debian: Add dependency on libpcre-ocaml-dev.
Jim Meyering [Wed, 13 Apr 2011 11:00:06 +0000 (13:00 +0200)]
Add missing include directives.
* fish/config.c: Include string.h, for use of strlen.
* fish/keys.c: Likewise, but for use of memcpy.
* fish/man.c: Likewise, but for use of memset.
Jim Meyering [Wed, 13 Apr 2011 09:11:42 +0000 (11:11 +0200)]
Avoid warning about implicit declaration of strlen.
* src/events.c: Include <string.h>, for use of strlen.
Richard W.M. Jones [Tue, 12 Apr 2011 21:45:39 +0000 (22:45 +0100)]
debian: libguestfs-test-tool-helper no longer exists.
Richard W.M. Jones [Tue, 12 Apr 2011 21:45:18 +0000 (22:45 +0100)]
resize: Include stamp file for manpage in CLEANFILES.
Richard W.M. Jones [Tue, 12 Apr 2011 19:14:51 +0000 (20:14 +0100)]
Version 1.11.0.
Richard W.M. Jones [Tue, 12 Apr 2011 18:36:25 +0000 (19:36 +0100)]
Update RELEASE-NOTES for 1.10 release.
Richard W.M. Jones [Tue, 12 Apr 2011 18:36:00 +0000 (19:36 +0100)]
Update ROADMAP for 1.12 and beyond.
Richard W.M. Jones [Tue, 12 Apr 2011 18:35:27 +0000 (19:35 +0100)]
README: virtio-serial is required.
Richard W.M. Jones [Tue, 12 Apr 2011 17:49:31 +0000 (18:49 +0100)]
guestfs(3): Fix documentation for drive letters.
We can now get drive letter mappings through the inspection API.
Richard W.M. Jones [Tue, 12 Apr 2011 17:05:35 +0000 (18:05 +0100)]
inspect: Fix some small memory leaks in Windows inspection.
Found using valgrind.
Richard W.M. Jones [Tue, 12 Apr 2011 16:03:14 +0000 (17:03 +0100)]
fish: Allows win:... paths to work with drives mounted anywhere.
This allows you to mount disks on (eg) /c and /e and have the
guestfish win:... path mechanism map drive letters to the
right places.
Richard W.M. Jones [Mon, 11 Apr 2011 11:33:21 +0000 (12:33 +0100)]
todo: guestfish drive letters.
Richard W.M. Jones [Sun, 10 Apr 2011 20:10:19 +0000 (21:10 +0100)]
resize: Update dependencies.
Richard W.M. Jones [Sun, 10 Apr 2011 19:42:42 +0000 (20:42 +0100)]
resize: Don't build this directory in parallel.
Richard W.M. Jones [Sun, 10 Apr 2011 10:12:03 +0000 (11:12 +0100)]
resize: Consistent use of 'part' in help output.
Richard W.M. Jones [Sun, 10 Apr 2011 10:06:58 +0000 (11:06 +0100)]
resize: Missing \n after version.
Richard W.M. Jones [Sat, 9 Apr 2011 21:50:15 +0000 (22:50 +0100)]
resize: Link with local copy of guestfs.
Richard W.M. Jones [Sat, 9 Apr 2011 16:11:57 +0000 (17:11 +0100)]
Version 1.9.18.
Richard W.M. Jones [Sat, 9 Apr 2011 18:55:05 +0000 (19:55 +0100)]
Update POT file.
Richard W.M. Jones [Sat, 9 Apr 2011 17:01:11 +0000 (18:01 +0100)]
Include po/Makefile.in.in in git, to avoid needing to rerun gettextize.
Richard W.M. Jones [Sat, 9 Apr 2011 20:11:47 +0000 (21:11 +0100)]
build: virt-resize manpage.
Richard W.M. Jones [Fri, 8 Apr 2011 13:07:26 +0000 (14:07 +0100)]
Rewrite virt-resize in OCaml.
This is a fairly straightforward translation of Perl virt-resize into
OCaml. It is bug-for-bug and feature-for-feature identical to the
Perl version, except as noted below.
The motivation is to have a more solid, high-level, statically safe
compiled language to go forwards with fixing some of the harder bugs
in virt-resize. In particular contracts between different parts of
the program are now handled by statically typed structures checked at
compile time, instead of the very ad-hoc unchecked hash tables used by
the Perl version.
OCaml and the ocaml-pcre library (Perl-Compatible Regular Expressions
bindings for OCaml) are required.
Extra features in this version:
- 32 bit hosts are now supported.
- We try hard to handle the case where the target disk is not "clean"
(ie. all zeroes). It usually works for this case, whereas the
previous version would usually fail. However it is still
recommended that the system administrator creates a fresh blank disk
for the target before running the program.
- User messages are a bit more verbose and helpful. You can turn
these off with the -q (--quiet) option.
There is one lost feature:
- Ability to specify >= T (terabytes) sizes in command line size
expressions has been removed. This probably didn't work in the Perl
version.
Other differences:
- The first partition on the target is no longer aligned; instead we
place it at the same sector as on the source. I suspect that
aligning it was causing the bootloader failures.
- Because it's easier, we do more sanity checking on the source disk.
This might lead to more failures, but they'd be failures you'd want
to know about.
- The order in which operations are performed has been changed to make
it more logical. The user should not notice any functional
difference, but debug messages will be quite a bit different.
- virt-resize is a compiled binary, not a script.
Matthew Booth [Thu, 7 Apr 2011 14:30:54 +0000 (15:30 +0100)]
Compile rpcgen-generated files with -fno-strict-aliasing
rpcgen generates source which can't be safely compiled with strict-aliasing
enabled.
Richard W.M. Jones [Wed, 6 Apr 2011 18:45:46 +0000 (19:45 +0100)]
test-tool: Don't use static binary helper program, nor ISO.
This simplifies the libguestfs-test-tool program down to essentials.
Bugs most commonly occur when starting the appliance, so what we
should concentrate on test is just that.
Previously the test tool built a special static binary helper program,
packaged it up in an ISO, then ran this inside the appliance. None of
this really tested useful failure modes, but they did make the test
tool itself harder to build, harder for users to run, and more
brittle.
This change also adds some more debugging of libguestfs state.
Richard W.M. Jones [Wed, 6 Apr 2011 10:52:20 +0000 (11:52 +0100)]
Update RELEASE-NOTES file.
Richard W.M. Jones [Tue, 5 Apr 2011 20:24:51 +0000 (21:24 +0100)]
Version 1.9.17.
Richard W.M. Jones [Tue, 5 Apr 2011 18:44:16 +0000 (19:44 +0100)]
fish: copy-in, copy-out, edit, more commands can use win:... prefix.
Richard W.M. Jones [Tue, 5 Apr 2011 18:43:30 +0000 (19:43 +0100)]
fish: Enhance guestfish win:... parsing to understand drive letters.
Richard W.M. Jones [Tue, 5 Apr 2011 17:23:39 +0000 (18:23 +0100)]
edit: Allow Windows-style drive letters and paths to be used.
Richard W.M. Jones [Tue, 5 Apr 2011 13:03:08 +0000 (14:03 +0100)]
New API: inspect-get-drive-mappings
This returns the drive mappings from the Windows Registry.
virt-inspector displays the drive mappings, giving output
similar to this:
<drive_mappings>
<drive_mapping name="C">/dev/sda2</drive_mapping>
<drive_mapping name="E">/dev/sdb1</drive_mapping>
</drive_mappings>
Richard W.M. Jones [Tue, 5 Apr 2011 11:44:34 +0000 (12:44 +0100)]
New API: inspect-get-windows-current-control-set
This returns the actual registry key corresponding to
CurrentControlSet (eg. it might be "ControlSet001").
Previously the inspection code was hard-coding ControlSet001. Now we
use the correct control set, and also make it available to callers
through the API.
This commit also updates the virt-dhcp-address example so it uses this
new API.
virt-inspector displays the current control set when available.
Richard W.M. Jones [Tue, 5 Apr 2011 18:42:00 +0000 (19:42 +0100)]
daemon: Reimplement 'mounts' and 'mountpoints' commands.
Reimplement these so they read /proc/mounts instead of trying to parse
the output of the 'mount' external command.
One consequence of this is that these commands now work again for
ntfs-3g filesystems.
Richard W.M. Jones [Tue, 5 Apr 2011 17:44:55 +0000 (18:44 +0100)]
Rename resolve_windows_path_silently to case_sensitive_path_silently.
A more accurate description of what this function does.
This is just code motion.
Richard W.M. Jones [Tue, 5 Apr 2011 16:46:23 +0000 (17:46 +0100)]
edit: Move 'exit 0' to end of file.
This is just code motion.
Richard W.M. Jones [Tue, 5 Apr 2011 16:45:41 +0000 (17:45 +0100)]
edit: Let $root == $roots[0].
This is just code motion.
Richard W.M. Jones [Tue, 5 Apr 2011 16:44:41 +0000 (17:44 +0100)]
cat, edit: Reference guestfish equivalent commands in the manual pages.
Richard W.M. Jones [Mon, 4 Apr 2011 11:48:02 +0000 (12:48 +0100)]
python: Convert any iterable argument to a list (RHBZ#693324).
Thanks to Erez Shinan.
Richard W.M. Jones [Sat, 2 Apr 2011 21:32:36 +0000 (22:32 +0100)]
fish: Add 'pulse mode' to the progress bar.
Richard W.M. Jones [Sat, 2 Apr 2011 21:31:41 +0000 (22:31 +0100)]
fish: Move variable decls to top of function.
This is just code motion.
Nikita A Menkovich [Sat, 2 Apr 2011 10:05:19 +0000 (11:05 +0100)]
debian: Add missing deps: ocaml-findlib, libstring-shellquote-perl.
Nikita A Menkovich [Sat, 2 Apr 2011 10:04:47 +0000 (11:04 +0100)]
mkisofs is obsolete. Require genisoimage everywhere instead.
Richard W.M. Jones [Sat, 2 Apr 2011 08:14:41 +0000 (09:14 +0100)]
Pull translations from Transifex.
New Ukrainian po-docs translation added.
Richard W.M. Jones [Fri, 1 Apr 2011 19:37:01 +0000 (20:37 +0100)]
Version 1.9.16.
Richard W.M. Jones [Fri, 1 Apr 2011 15:03:14 +0000 (16:03 +0100)]
du: Add pulse mode progress messages.
Richard W.M. Jones [Fri, 1 Apr 2011 17:37:29 +0000 (18:37 +0100)]
cpmv: Add pulse mode progress messages.
Richard W.M. Jones [Fri, 1 Apr 2011 17:37:39 +0000 (18:37 +0100)]
checksum: Add pulse mode progress messages.
Richard W.M. Jones [Fri, 1 Apr 2011 14:50:33 +0000 (15:50 +0100)]
daemon: Introduce "pulse mode" progress events.
This introduces a new form of progress event, where we don't know how
much of the operation has taken place, but we nevertheless want to
send back some indication of activity. Some progress bar indicators
directly support this, eg. GtkProgressBar where it is known as "pulse
mode".
A pulse mode progress message is a special backwards-compatible form
of the ordinary progress message. No change is required in callers,
unless they want to add support for pulse mode.
The daemon sends:
- zero or more progress messages with position = 0, total = 1
- a single final progress message with position = total = 1
Note that the final progress message may not be sent if the call fails
and returns an error. This is consistent with the behaviour of
ordinary progress messages.
The daemon allows two types of implementation. Either you can just
call notify_progress (0, 1); ...; notify_progress (1, 1) as usual.
Or you can call the functions pulse_mode_start, pulse_mode_end and/or
pulse_mode_cancel (see documentation in daemon/daemon.h). For this
second form of call, the guarantee is very weak: it *just* says the
daemon is still capable of doing something, and it doesn't imply that
if there is a subprocess that it is doing anything. However this does
make it very easy to add pulse mode progress messages to all sorts of
existing calls that depend on long-running external commands.
To do: add a third variant that monitors a subprocess and only sends
back progress messages if it's doing something, where "doing
something" might indicate it's using CPU time or it's printing output.
Richard W.M. Jones [Fri, 1 Apr 2011 14:27:46 +0000 (15:27 +0100)]
daemon: When running commands, restart select if we receive a signal.
Richard W.M. Jones [Fri, 1 Apr 2011 14:26:46 +0000 (15:26 +0100)]
daemon: Reset SIGPIPE to default before running subprocesses.
Richard W.M. Jones [Fri, 1 Apr 2011 12:30:48 +0000 (13:30 +0100)]
Generate progress messages during launch.
This commit generates approximate progress messages during the
guestfs_launch call. Currently this code generates:
0 / 12: launch clock starts
3 / 12: appliance created
6 / 12: detected that guest kernel started
9 / 12: detected that /init script is running
12 / 12: launch completed successfully
(Note this is not an ABI and may be changed or removed in a future
version).
Progress messages are only generated at all if 5 seconds have elapsed
since the launch, and they are only generated for the ordinary
appliance (not if using attach-method to attach to an existing virtio
serial port).
Richard W.M. Jones [Fri, 1 Apr 2011 12:29:06 +0000 (13:29 +0100)]
protocol: Sleep for 1ms before reading log messages.
As explained in the comment:
/* QEMU's console emulates a 16550A serial port. The real 16550A
* device has a small FIFO buffer (16 bytes) which means here we see
* lots of small reads of 1-16 bytes in length, usually single
* bytes. Sleeping here for a very brief period groups reads
* together (so we usually get a few lines of output at once) and
* improves overall throughput, as well as making the event
* interface a bit more sane for callers. With a virtio-serial
* based console (not yet implemented) we may be able to remove
* this. XXX
*/