libguestfs.git
13 years agoexamples: Use WARN_CFLAGS, WERROR_CFLAGS macros instead of -Wall
Richard W.M. Jones [Thu, 31 Mar 2011 19:18:23 +0000 (20:18 +0100)]
examples: Use WARN_CFLAGS, WERROR_CFLAGS macros instead of -Wall
(cherry picked from commit b41e73008a939ef493d2bfb82c9bd07b0f74736a)

13 years agoexamples: size_t-correctness change in inspect_vm.c
Richard W.M. Jones [Thu, 31 Mar 2011 19:17:02 +0000 (20:17 +0100)]
examples: size_t-correctness change in inspect_vm.c
(cherry picked from commit d5eb5216aae0cb83fae686f490d1c3c37c2c074e)

13 years agocontrib: Fix URLs in README file.
Richard W.M. Jones [Thu, 31 Mar 2011 17:20:08 +0000 (18:20 +0100)]
contrib: Fix URLs in README file.
(cherry picked from commit 1612201a83e732eec7d98d1679dd9dd426bcd10d)

13 years agorescue: Add -w|--rw option.
Richard W.M. Jones [Wed, 30 Mar 2011 15:33:14 +0000 (16:33 +0100)]
rescue: Add -w|--rw option.

Note this has been backported to the 1.8 branch to allow us to write
documentation which refers to the virt-rescue --rw option.  The option
does nothing in 1.8.

(cherry picked from commit 4155d20014b24b2203c4dd8b00e2e19450a7e3bb)

13 years agofuse: Document -w flag in --help output.
Richard W.M. Jones [Wed, 30 Mar 2011 15:32:33 +0000 (16:32 +0100)]
fuse: Document -w flag in --help output.
(cherry picked from commit 3824935411e8a046f0359578978447dd5a0a1a16)

13 years agoExclude po-docs directory completely if po4a not available.
Richard W.M. Jones [Tue, 29 Mar 2011 15:07:21 +0000 (16:07 +0100)]
Exclude po-docs directory completely if po4a not available.

Lift the if HAVE_PO4A ... endif completely out of the po-docs
subdirectory, and just exclude the whole subdirectory if the po4a
program is not available.
(cherry picked from commit 58f7a5a4ac8cce77dfaded1c29f3ad382b4cc9a8)

13 years agotests: Don't fail when compiled without support for NTFS.
Richard W.M. Jones [Tue, 29 Mar 2011 15:03:29 +0000 (16:03 +0100)]
tests: Don't fail when compiled without support for NTFS.
(cherry picked from commit edb7501d60a03107c21f023b256d2b01cf116437)

13 years agoVersion 1.8.4. 1.8.4
Richard W.M. Jones [Tue, 29 Mar 2011 20:36:00 +0000 (21:36 +0100)]
Version 1.8.4.

13 years agoperl: Canonicalize /dev/vd* paths in old inspection code (RHBZ#691724).
Richard W.M. Jones [Tue, 29 Mar 2011 11:20:57 +0000 (12:20 +0100)]
perl: Canonicalize /dev/vd* paths in old inspection code (RHBZ#691724).
(cherry picked from commit 759f4369de965f46f4a93b3a75dada050f87e223)

13 years agoREADME: Note that getfacl, getfattr are optional dependencies.
Richard W.M. Jones [Mon, 28 Mar 2011 16:18:24 +0000 (17:18 +0100)]
README: Note that getfacl, getfattr are optional dependencies.
(cherry picked from commit d82d6f0633f63d4a884147b1e85851e96ff8f58d)

13 years agofuse: Fix getxattr, listxattr calls and add a regression test (RHBZ#691389).
Richard W.M. Jones [Mon, 28 Mar 2011 13:45:23 +0000 (14:45 +0100)]
fuse: Fix getxattr, listxattr calls and add a regression test (RHBZ#691389).

The documentation for the getxattr and listxattr calls is not very
clear and as a result we were always returning something different
from that which the Linux kernel would usually return.

This fixes these calls, at least far enough that both the 'getfattr'
and 'getfacl' programs now work fine on FUSE-mounted filesystems.

Note that SELinux attrs are *not* passed through.  This appears to be
a known bug between SELinux and FUSE.  For more information see:

http://www.spinics.net/lists/selinux/msg09460.html

Cherry picked from commit 0d6fd9e1d2488841c912c5351086e536772837ef:
  - rebased on stable-1.8 branch
  - removed unintended hunk (which changed -m documentation in
      guestmount --help output)
  - removed parts of test-fuse.sh which will fail because
      there is no support for passing acl,user_xattr options in
      an extended -m option

13 years agoRHEL 5: Use mke4fs on RHEL 5 as replacement for mke2fs.
Richard W.M. Jones [Fri, 25 Mar 2011 14:42:40 +0000 (14:42 +0000)]
RHEL 5: Use mke4fs on RHEL 5 as replacement for mke2fs.
(cherry picked from commit a0e3b2183733c7440ad017c4ffe361935672339b)

13 years agomkfs: Force mke2fs to create a filesystem even on raw IDE device (RHBZ#690819).
Richard W.M. Jones [Fri, 25 Mar 2011 14:34:31 +0000 (14:34 +0000)]
mkfs: Force mke2fs to create a filesystem even on raw IDE device (RHBZ#690819).
(cherry picked from commit 227bea6c7ef89b707fe2c01c4d0d0fb9081e8c04)

13 years agoRename $tmpdir/sock to $tmpdir/guestfsd.sock.
Richard W.M. Jones [Fri, 25 Mar 2011 12:32:08 +0000 (12:32 +0000)]
Rename $tmpdir/sock to $tmpdir/guestfsd.sock.

No functional change; this simply makes the purpose of the
socket clearer.
(cherry picked from commit 110bfe1fcc9964b82acf7df6d4d60774471f9157)

13 years agofish: Add better quick help to --help output.
Richard W.M. Jones [Tue, 22 Mar 2011 11:50:26 +0000 (11:50 +0000)]
fish: Add better quick help to --help output.
(cherry picked from commit 0daf7e81a659bcdc1ce327151cc1207b124a35a1)

13 years agofish: Add -w|--rw option to --help output.
Richard W.M. Jones [Tue, 22 Mar 2011 11:50:03 +0000 (11:50 +0000)]
fish: Add -w|--rw option to --help output.
(cherry picked from commit c8faa5d0b0a17689d27bd33bc787ba0fe9a3f076)

13 years agoinspect: Don't fail for Windows guests with multiple disks (RHBZ#674130).
Richard W.M. Jones [Tue, 22 Mar 2011 11:20:38 +0000 (11:20 +0000)]
inspect: Don't fail for Windows guests with multiple disks (RHBZ#674130).

Cherry picked from commit d06fee159c14d4fe7654a02bae8849c4f82565f8
and backported to stable-1.8 branch.

13 years agoinspect: Simplify Windows root heuristic code.
Richard W.M. Jones [Tue, 22 Mar 2011 11:05:21 +0000 (11:05 +0000)]
inspect: Simplify Windows root heuristic code.

Add special is_file_nocase and is_dir_nocase functions and
remove the duplicate checks for files and directories with
different cases.
(cherry picked from commit 5776c145d411e5ae00072ecf422055f3d0bd29e2)

13 years agoVersion 1.8.3. 1.8.3
Richard W.M. Jones [Mon, 21 Mar 2011 11:58:47 +0000 (11:58 +0000)]
Version 1.8.3.

13 years agoguestfs(3): 'kernel' -> 'supermin appliance'.
Richard W.M. Jones [Sat, 19 Mar 2011 18:41:23 +0000 (18:41 +0000)]
guestfs(3): 'kernel' -> 'supermin appliance'.
(cherry picked from commit 1541f3a564f8ff14c1a63298120e4dc618ea3274)

13 years agoguestfs(3): Indent line to keep code together.
Richard W.M. Jones [Sat, 19 Mar 2011 18:18:56 +0000 (18:18 +0000)]
guestfs(3): Indent line to keep code together.
(cherry picked from commit cf6f380c544456ee3e84fd41a480ea4cab3d94dd)

13 years agofish: Add all stamp-*.pod files to CLEANFILES.
Richard W.M. Jones [Fri, 18 Mar 2011 20:02:29 +0000 (20:02 +0000)]
fish: Add all stamp-*.pod files to CLEANFILES.
(cherry picked from commit c6310bd242ddaa7b0801df9da7e4fba7346dc53e)

13 years agoproto: Fix both-ends-cancel case.
Richard W.M. Jones [Fri, 18 Mar 2011 18:27:21 +0000 (18:27 +0000)]
proto: Fix both-ends-cancel case.

In the case where both ends cancel at the same time (eg. both ends
realize there are errors before or during the transfer), previously we
skipped sending back an error from the daemon, on the spurious basis
that the library would not need it (the library is cancelling because
of its own error).

However this is wrong: we should always send back an error message
from the daemon in order to preserve synchronization of the protocol.

A simple test case is:

  $ guestfish -N fs -m /dev/sda1 upload nosuchfile /
  libguestfs: error: open: nosuchfile: No such file or directory
  libguestfs: error: unexpected procedure number (66/282)

(Notice two things: there are errors at both ends, and the
loss of synchronization).

After applying this commit, the loss of synchronization does not occur
and we just see the library error:

  $ guestfish -N fs -m /dev/sda1 upload nosuchfile /
  libguestfs: error: open: nosuchfile: No such file or directory

The choice of displaying the library or the daemon error is fairly
arbitrary in this case -- it would be valid to display either or even
to combine them into one error.  Displaying the library error only
makes the code considerably simpler.

This commit also (re-)enables a test for this case.

Cherry picked and rebased from
commit f4d996fd26762053d68f46de5790aae893f03d38.

13 years agoproto: Fix FileIn ops that abort during the chunk upload stage.
Richard W.M. Jones [Fri, 18 Mar 2011 17:17:30 +0000 (17:17 +0000)]
proto: Fix FileIn ops that abort during the chunk upload stage.

As a previous, incorrect attempt to fix RHBZ#576879 we tried to
prevent the daemon from sending an error reply if the daemon had
cancelled the transfer.  This is wrong: the daemon should send an
error reply in these cases.

A simple test case is this:

  guestfish -N fs -m /dev/sda1 upload big-file /

(This fails because the target "/" is a directory, not a file.)
Prior to this commit, libguestfs would hang instead of printing an
error.  With this commit, libguestfs prints an error.

What is happening is:

  (1) Library is uploading
  a file                          (2) In the middle of the long
                                  upload, daemon detects an error.
                                  Daemon cancels.
  (3) Library detects cancel,
  sends cancel chunk, then waits
  for the error reply from the
  daemon.                         (4) Daemon is supposed to send
                                  an error reply message.

Because step (4) wasn't happening, uploads that failed like this would
hang in the library (waiting for the error message, while the daemon
was waiting for the next request).

This also adds a regression test.

This temporarily breaks the "both ends cancel" case (RHBZ#576879c5).
Therefore the test for that is disabled, and this is fixed in the next
patch in the series.

This partially reverts commit dc706a639eec16084c0618baf7bfde00c6565f63.

Cherry picked and rebased from
commit 33b638109ed66ea360b53b80b1f407b3a5f5ec39.

13 years agoproto: Don't drop outgoing message when daemon cancels (RHBZ#576879).
Richard Jones [Fri, 18 Mar 2011 16:18:37 +0000 (16:18 +0000)]
proto: Don't drop outgoing message when daemon cancels (RHBZ#576879).

This is a (potential) fix for the long standing protocol bug
which causes loss of synchronization when a FileIn action
fails very early on the daemon side.  The canonical example
would be the 'upload' action failing immediately if no filesystem
is mounted.

What's supposed to happen is this:

  (1) library sends
  request message              (2) daemon processes request
  first chunk of data          and sees that it will fail,
                               sends cancellation
                               (3) discards chunks of data
  (4) library sees daemon
  cancellation and stops
  sending chunks

It was going wrong in step (1), in guestfs___send_to_daemon.
In some (timing related) circumstances, send_to_daemon could
receive the cancellation before sending the first chunk, at
which point it would exit, *discarding the first chunk*.
This causes the daemon to fail in step (3) since it reads the
next request as if it was a chunk, thus losing synchronization.
(The protocol specifies that you always have to send at least
one chunk if there is a FileIn or FileOut parameter).

The patch changes guestfs___send_to_daemon so that if it detects
cancellation, it sends the remaining data in its output buffer
instead of discarding it.  (This also fixes another edge case
to do with sending partial data although I don't think we
ever saw that in practice).
(cherry picked from commit c7368ce167d6dbfd3e69ba208301c5af3f17a8a1)

13 years agoregressions: Enable both tests for bug 576879 (not fixed).
Richard W.M. Jones [Fri, 18 Mar 2011 11:22:25 +0000 (11:22 +0000)]
regressions: Enable both tests for bug 576879 (not fixed).
(cherry picked from commit dc8e4b057ecd3984d7c27c8ece54048b6a06d662)

13 years agohaskell: Small fixes for ghc 7.
Richard W.M. Jones [Fri, 18 Mar 2011 11:19:31 +0000 (11:19 +0000)]
haskell: Small fixes for ghc 7.
(cherry picked from commit 502a98948c1bade2969758aff3db09869481105a)

13 years agoregressions: Rename the file we are uploading too.
Richard W.M. Jones [Thu, 17 Mar 2011 12:46:57 +0000 (12:46 +0000)]
regressions: Rename the file we are uploading too.

This updates commit cbd8da6d4dd2e4cbc3b87fbc7cb7d6129eb69172.
(cherry picked from commit e34fc32092e18b38282306558dcef66263a0fb10)

13 years agoregressions: Split the test rhbz576879.sh into two halves.
Richard W.M. Jones [Thu, 17 Mar 2011 11:57:40 +0000 (11:57 +0000)]
regressions: Split the test rhbz576879.sh into two halves.

We suspect that there are in fact two separate bugs.  In any
case it makes sense for the two tests to be done separately.

Note that these tests still fail.
(cherry picked from commit cbd8da6d4dd2e4cbc3b87fbc7cb7d6129eb69172)

13 years agocheck the pid is > 0 before calling waitpid()
Angus Salkeld [Tue, 15 Mar 2011 11:43:02 +0000 (22:43 +1100)]
check the pid is > 0 before calling waitpid()

Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
(cherry picked from commit d1f1f74e5f45fa5b94ebb096fa65fa33ecc23d09)

13 years agocheck the pid is > 0 before calling waitpid()
Angus Salkeld [Mon, 14 Mar 2011 11:40:12 +0000 (22:40 +1100)]
check the pid is > 0 before calling waitpid()

Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
(cherry picked from commit 6f7c1a9f9d76bdf9f112e12e1508531fb41abfb2)

13 years agoRHEL5: Old pod2man didn't have --stderr or -u options.
Richard W.M. Jones [Fri, 11 Mar 2011 10:47:05 +0000 (10:47 +0000)]
RHEL5: Old pod2man didn't have --stderr or -u options.
(cherry picked from commit eb304e9689ca474834207605ed52c369bcdec6ea)

13 years agoconfigure: Remove unnecessary variable assignment.
Richard W.M. Jones [Fri, 11 Mar 2011 10:23:58 +0000 (10:23 +0000)]
configure: Remove unnecessary variable assignment.

Left over from pre-virtio-serial days.
(cherry picked from commit 97eab125fa8e3dc481c1f1ba1a847cf43d537585)

13 years agoRHEL5: Make use of 'futimens' function optional.
Richard W.M. Jones [Fri, 11 Mar 2011 10:22:58 +0000 (10:22 +0000)]
RHEL5: Make use of 'futimens' function optional.
(cherry picked from commit 003fbdfe5d8b237f42f575199b742c8dde9b8a11)

13 years agoVersion 1.8.2. 1.8.2
Richard W.M. Jones [Tue, 8 Mar 2011 15:27:26 +0000 (15:27 +0000)]
Version 1.8.2.

13 years agoDetect Red Hat Desktop as 'rhel' distro (RHBZ#682979).
Richard W.M. Jones [Tue, 8 Mar 2011 08:10:19 +0000 (08:10 +0000)]
Detect Red Hat Desktop as 'rhel' distro (RHBZ#682979).

/etc/redhat-release on Red Hat Desktop contains the following
string:
  Red Hat Desktop release 4 (Nahant Update 8)

Previously we matched against the string "Red Hat Enterprise Linux"
but since this does not contain that string, this distro wasn't being
detected correctly.

Note this also changes the obsolete Perl code, for the benefit of
virt-v2v.
(cherry picked from commit c1a227a960066fb9552e0c225bc473be365b67b0)

13 years agoInclude <locale.h> in compilation units that use setlocale function.
Richard W.M. Jones [Mon, 7 Mar 2011 19:30:31 +0000 (19:30 +0000)]
Include <locale.h> in compilation units that use setlocale function.

Fix required by gcc 4.6.0.
(cherry picked from commit a9d6b948b590f58023a97dddd76302e40d49d2e2)

13 years agogenerator: Introduce error code (errcode) concept.
Richard W.M. Jones [Mon, 7 Mar 2011 19:28:30 +0000 (19:28 +0000)]
generator: Introduce error code (errcode) concept.

There was a lot of repeated code to map return types (eg. RErr)
to error cases (eg. -1 or NULL).

This commit introduces an error code type and two functions to
map return types to error codes and error codes to strings.

Cherry picked from commit 8037da06feea097716ce700f38c0eac0d5411a7c
and rebased against stable 1.8 branch.

13 years agodebian: Rename nilfs2-tools to nilfs-tools.
Richard W.M. Jones [Sat, 5 Mar 2011 09:17:41 +0000 (09:17 +0000)]
debian: Rename nilfs2-tools to nilfs-tools.
(cherry picked from commit 1c772c921186be34331c7610992f57a69d20d908)

13 years agovirt-make-fs: Round disk size to integer, fix for qemu-img 0.14.
Richard W.M. Jones [Fri, 4 Mar 2011 12:13:32 +0000 (12:13 +0000)]
virt-make-fs: Round disk size to integer, fix for qemu-img 0.14.

qemu-img used to allow you to specify a fractional image size in bytes
(or at least, it used to ignore the part after the decimal place).  In
qemu-img 0.14 it no longer does this so we round down the size to a
whole number of bytes.
(cherry picked from commit eda9826d25336bcf661700270c580d4d62128750)

13 years agovirt-make-fs: In debug mode, print qemu-img command line.
Richard W.M. Jones [Fri, 4 Mar 2011 12:13:12 +0000 (12:13 +0000)]
virt-make-fs: In debug mode, print qemu-img command line.
(cherry picked from commit 29b3ffdad5d6774f988fd0e25f9c8242e5dd577a)

13 years agoFix inspection code when PCRE or hivex is missing.
Richard W.M. Jones [Thu, 3 Mar 2011 13:23:23 +0000 (13:23 +0000)]
Fix inspection code when PCRE or hivex is missing.
(cherry picked from commit 2b26c7f721fc8ed2e6f64963289981ac286c02aa)

13 years agojava: Add a test of g.list_filesystems (a function that returns a Map).
Richard W.M. Jones [Wed, 2 Mar 2011 05:11:10 +0000 (05:11 +0000)]
java: Add a test of g.list_filesystems (a function that returns a Map).
(cherry picked from commit 21fef55ca4907aa9872754f20320c24c7f8a5fac)

13 years agojava: Fix generated functions that return RHashtable.
Richard W.M. Jones [Wed, 2 Mar 2011 04:49:12 +0000 (04:49 +0000)]
java: Fix generated functions that return RHashtable.

Creating a HashMap directly from JNI is possible but very tedious
(see: http://java.sun.com/docs/books/jni/html/fldmeth.html#26254)

Instead we use the existing code to return hashes from JNI as plain
String[], then add some code in the Java wrapper to convert these to
HashMap<String,String>.
(cherry picked from commit eb54a7ede43d9275f10db6fce1472256550da0eb)

13 years agojava: Return Map<String,String> for RHashtable functions.
Richard W.M. Jones [Wed, 2 Mar 2011 04:33:39 +0000 (04:33 +0000)]
java: Return Map<String,String> for RHashtable functions.

There's no point returning the specific HashMap type here.
Return the generic interface type instead.

Note that no users are actually calling these functions yet,
since at present they always fail.
(cherry picked from commit 0b2e45da609002d44cbbf689cfdee252e6806648)

13 years agojava: Fix a minor whitespace error in generated code.
Richard W.M. Jones [Wed, 2 Mar 2011 04:30:30 +0000 (04:30 +0000)]
java: Fix a minor whitespace error in generated code.

In functions that don't have javadoc, the function prototype wasn't
being indented correctly.
(cherry picked from commit ec62f1127ec4f8609745f9d08b62c65e0ccbd154)

13 years agojava: Remove old test file if one was left around.
Richard W.M. Jones [Wed, 2 Mar 2011 05:10:31 +0000 (05:10 +0000)]
java: Remove old test file if one was left around.

If a test.img file was left over from a previous run, then it
would cause the subsequent test to fail.  Therefore remove any
old test.img file.
(cherry picked from commit 80aad709954cc4a3a294200e242876599047cef8)

13 years agojava: Enable assertions when doing 'make check'.
Richard W.M. Jones [Wed, 2 Mar 2011 05:08:20 +0000 (05:08 +0000)]
java: Enable assertions when doing 'make check'.

It turns out that Java assertions are disabled by default.  You have
to add the 'java -ea' flag to the JVM.  Who knew ..?

Because of this oversight, the tests weren't actually performing the
assertions that we wanted (although in fact none of the assertions
were failing).

This change enables assertions when running the tests.
(cherry picked from commit db98ac041ec36c4e2ce322d336f5792fa8e6922d)

13 years agodaemon: Ignore return value from chdir.
Richard W.M. Jones [Thu, 3 Feb 2011 19:33:30 +0000 (19:33 +0000)]
daemon: Ignore return value from chdir.

This updates commit 7eb012f3710bb554d5fc2c4229036901b0b5ad90.
(cherry picked from commit 8d7d7c4ecfd202e04d18736718e9c5bb125ce4f0)

13 years agodaemon: change to root directory
Richard W.M. Jones [Thu, 3 Feb 2011 18:49:35 +0000 (18:49 +0000)]
daemon: change to root directory

Ensure the daemon always starts with current directory == root.
(cherry picked from commit 7eb012f3710bb554d5fc2c4229036901b0b5ad90)

13 years agolib: Move appliance launching to separate function.
Richard W.M. Jones [Thu, 27 Jan 2011 10:12:34 +0000 (10:12 +0000)]
lib: Move appliance launching to separate function.

This is just code motion.
(cherry picked from commit 99f0d8859fdc8f6c81873d4cdd1c8c780ac25e84)

13 years agophp: Ignore another generated file in php/extension directory.
Richard W.M. Jones [Thu, 3 Feb 2011 10:56:01 +0000 (10:56 +0000)]
php: Ignore another generated file in php/extension directory.
(cherry picked from commit 5ae752559284efd925fb7959c5760d4fee25f1d6)

13 years agovirt-make-fs: Fix typo in man page.
Richard W.M. Jones [Sun, 30 Jan 2011 23:53:04 +0000 (23:53 +0000)]
virt-make-fs: Fix typo in man page.
(cherry picked from commit 0089575d4bd50a7ca55d7c3c8caa8a12ae09d40a)

13 years agoperl: Ignore internal_* functions in POD coverage test.
Richard W.M. Jones [Sat, 29 Jan 2011 07:01:06 +0000 (07:01 +0000)]
perl: Ignore internal_* functions in POD coverage test.

This updates commit 1d999540bddd7aea7c2d0fef8b15223d4acc645f.
(cherry picked from commit 6975e87153f593fddd5c27435c2e6347825daca9)

13 years agolib: Fix use-after-free bug in XPath parsing code.
Richard W.M. Jones [Fri, 28 Jan 2011 17:11:40 +0000 (17:11 +0000)]
lib: Fix use-after-free bug in XPath parsing code.
(cherry picked from commit 82f5fdb0dbbc0c7b04861edeadf70c86c9342df2)

13 years agodaemon: Add perror to two exit paths to make errors clearer.
Richard W.M. Jones [Thu, 27 Jan 2011 15:54:00 +0000 (15:54 +0000)]
daemon: Add perror to two exit paths to make errors clearer.
(cherry picked from commit e85fbee7bff9422a370d3f437594d262c043d89b)

13 years agodebian: Include actual shared libraries in python-guestfs package.
Richard W.M. Jones [Thu, 27 Jan 2011 09:23:01 +0000 (09:23 +0000)]
debian: Include actual shared libraries in python-guestfs package.
(cherry picked from commit 8a406c7bee521289c6f8704549f1f144b5bbbbd9)

13 years agomkfs-opts: Add a note about blocksize param and UFS filesystems.
Nikita A Menkovich [Wed, 26 Jan 2011 15:32:18 +0000 (15:32 +0000)]
mkfs-opts: Add a note about blocksize param and UFS filesystems.
(cherry picked from commit dd653336cc34c2e8640aa7e19174a3e339049dc2)

13 years agogenerator: Fix generation of library-side stubs with optional String arguments.
Richard W.M. Jones [Wed, 26 Jan 2011 14:15:23 +0000 (14:15 +0000)]
generator: Fix generation of library-side stubs with optional String arguments.
(cherry picked from commit 2110f6fa8c397f74e38408612d5514a42f3b9cee)

13 years agopackagelist: Add ufsutils for Debian and Ubuntu.
Richard W.M. Jones [Wed, 26 Jan 2011 10:00:44 +0000 (10:00 +0000)]
packagelist: Add ufsutils for Debian and Ubuntu.

Note there is no mkfs.ufs available for Fedora (see RHBZ#541618
for details).
(cherry picked from commit c76f155496717c526ef0b5e72083bb0034f61d3c)

13 years agofish: Fix typo in error message (copy-in should be copy-out).
Richard W.M. Jones [Sat, 22 Jan 2011 14:46:37 +0000 (14:46 +0000)]
fish: Fix typo in error message (copy-in should be copy-out).
(cherry picked from commit e8ab05b12c6b1c13278e549883efd47900a4bac1)

13 years agofish: Initialize pcmd structure.
Richard W.M. Jones [Tue, 18 Jan 2011 22:38:05 +0000 (22:38 +0000)]
fish: Initialize pcmd structure.

On Debian we get this warning which I'm pretty sure is bogus:

fish.c:690: error: 'pcmd.cmd' may be used uninitialized in this
function [-Wuninitialized]
(cherry picked from commit 316ad8311a41869cf5f253225137dd03d1211ce7)

13 years agofish: Factor out command line parsing.
Richard W.M. Jones [Tue, 18 Jan 2011 11:24:38 +0000 (11:24 +0000)]
fish: Factor out command line parsing.

Factor out the code which splits a string into a command line.
(cherry picked from commit 61a4db138e4f85033c655bf6b24df0949683c24c)

13 years agofish: Make exit_on_error into a completely local variable.
Richard W.M. Jones [Tue, 18 Jan 2011 10:33:01 +0000 (10:33 +0000)]
fish: Make exit_on_error into a completely local variable.

Note that 'time' and 'glob' (which both run subcommands) do not
correctly pass the exit_on_error flag in the remote case.  This is not
a regression: the current code doesn't work either.
(cherry picked from commit 4bcb267a248977c6b044e18a72266d665102de30)

13 years agofish: exit_on_error is a local variable.
Richard W.M. Jones [Tue, 18 Jan 2011 10:21:49 +0000 (10:21 +0000)]
fish: exit_on_error is a local variable.
(cherry picked from commit f6a21c1e0d44f9db409ce6583be7b5bc694767a8)

13 years agoinspect: Add macros for file size limits.
Richard W.M. Jones [Sat, 15 Jan 2011 13:18:36 +0000 (13:18 +0000)]
inspect: Add macros for file size limits.

This also bumps the file size limit for "small text files"
up to 2 MB, since we want to parse Windows CD txtsetup.sif
files that are usually around 500K in size.
(cherry picked from commit 4402e6048fb2a56461f9e4d474fc2f1391248781)

13 years agodf: Skip final '/' character when calculating basename.
Richard W.M. Jones [Tue, 11 Jan 2011 13:55:23 +0000 (13:55 +0000)]
df: Skip final '/' character when calculating basename.

Previously it was including the final '/' character when calculating
the basename for the -a option eg:

Filesystem                                Size       Used  Available  Use%
/Ubuntu1010x64:/dev/sda1                  9.4G       2.3G       6.6G   25%

With this patch the '/' is not printed.
(cherry picked from commit e5220b26f51d5912371424ab6dfbdb46ce6aa170)

13 years agofish: Don't fail if some mountpoints in /etc/fstab are bogus (RHBZ#668574).
Richard W.M. Jones [Tue, 11 Jan 2011 10:43:51 +0000 (10:43 +0000)]
fish: Don't fail if some mountpoints in /etc/fstab are bogus (RHBZ#668574).

Fix guestfish (and other C tools) so that they ignore errors
when /etc/fstab contains bogus entries.

Update the documentation for inspect-get-mountpoints to emphasize
that callers must be aware of this when mounting the returned
values.

Add a regression test.

Update the example code ("inspect_vm") to reflect the way this
API ought to be called.

For more detail see:
https://bugzilla.redhat.com/show_bug.cgi?id=668574
(cherry picked from commit 0c60e4d9dd6549c2135699490ba8a9ec1dd50ab9)

13 years agoVersion 1.8.1. 1.8.1
Richard W.M. Jones [Mon, 10 Jan 2011 09:42:43 +0000 (09:42 +0000)]
Version 1.8.1.

13 years agovirt-filesystems: Ignore errors when getting label and UUID (RHBZ#668112).
Richard W.M. Jones [Sat, 8 Jan 2011 10:15:39 +0000 (10:15 +0000)]
virt-filesystems: Ignore errors when getting label and UUID (RHBZ#668112).

If virt-filesystems was pointed to an image that contained
bogus or blank filesystems, then calls to vfs-label and/or vfs-uuid
could fail, resulting in errors like this:

libguestfs: error: vfs_label: /dev/vda1:

These errors can be ignored and shouldn't stop virt-filesystems
from working.
(cherry picked from commit 97339a0f43d687efac6f7edafdf21e4b8d9b35e8)

13 years agoresize: Fix typo in man page (thanks avesh@IRC).
Richard W.M. Jones [Fri, 7 Jan 2011 20:38:55 +0000 (20:38 +0000)]
resize: Fix typo in man page (thanks avesh@IRC).
(cherry picked from commit 7e1114445e713c4a15f3f2cede5842044de1735a)

13 years agofish: fails to tilde expand '~' when $HOME env is unset (RHBZ#617440).
Richard W.M. Jones [Tue, 4 Jan 2011 16:05:11 +0000 (16:05 +0000)]
fish: fails to tilde expand '~' when $HOME env is unset (RHBZ#617440).

This also adds a regression test.
(cherry picked from commit 7ce627fce02eae8c7db36b4090fa0ce1bf69bf44)

13 years agofish: Fix off-by-one bug in tilde expansion.
Richard W.M. Jones [Tue, 4 Jan 2011 16:02:48 +0000 (16:02 +0000)]
fish: Fix off-by-one bug in tilde expansion.

Although this doesn't seem to cause a crash, valgrind confirms
that this is a genuine off-by-one bug.  It could potentially
cause a crash if you did:

  echo 'echo ~root/foo' | guestfish
(cherry picked from commit a9802509184341e731de5c9af363184a9964a8a7)

13 years ago.gitignore: Use full paths for some ignored files.
Richard W.M. Jones [Mon, 3 Jan 2011 17:17:54 +0000 (17:17 +0000)]
.gitignore: Use full paths for some ignored files.
(cherry picked from commit 72f4b2e7493bf81b111ecd83490c9d3ad2480382)

13 years agodocs: Add QMP to ROADMAP file.
Richard W.M. Jones [Mon, 3 Jan 2011 14:36:19 +0000 (14:36 +0000)]
docs: Add QMP to ROADMAP file.
(cherry picked from commit 1b1db82d64a9664f0da1c628ee896a113a605739)

13 years agofilesystems: Document the columns in --long output.
Richard W.M. Jones [Sun, 2 Jan 2011 22:55:48 +0000 (22:55 +0000)]
filesystems: Document the columns in --long output.
(cherry picked from commit 440cd23f54f44132b8ff3d1e5b0b05b9dd5cc1c0)

13 years agoAdd initial announcement to release notes.
Richard W.M. Jones [Sun, 2 Jan 2011 21:43:22 +0000 (21:43 +0000)]
Add initial announcement to release notes.
(cherry picked from commit 9ae4168c30b8be57909f5b0104c5e925743c6cc0)

13 years agoinspector: Apps in Windows VMs are now listed - update documentation.
Richard W.M. Jones [Sun, 2 Jan 2011 21:01:41 +0000 (21:01 +0000)]
inspector: Apps in Windows VMs are now listed - update documentation.
(cherry picked from commit dd7ad7c7ebd7b3cf7fbcc03d3baadbb77bf4203a)

13 years agoLib.pm: unknown filesystem /dev/hd{x} (cdrom) (RHBZ#666577)
Douglas Schilling Landgraf [Sun, 2 Jan 2011 18:55:12 +0000 (18:55 +0000)]
Lib.pm: unknown filesystem /dev/hd{x} (cdrom) (RHBZ#666577)

This a purpose patch to avoid the message "unknown filesystem /dev/hdc".
Where /dev/hdc is an entry in fstab for CDROM.

Example of fstab:
/dev/hdc                /media/cdrom            auto
pamconsole,exec,noauto,managed 0 0

https://bugzilla.redhat.com/show_bug.cgi?id=666577

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
(cherry picked from commit f07a0b6f1e01f12db0286ae49744deee0efcb5b9)

13 years agoLib.pm: unknown filesystem label SWAP-sda2 (RHBZ#666578)
Douglas Schilling Landgraf [Sun, 2 Jan 2011 18:53:55 +0000 (18:53 +0000)]
Lib.pm: unknown filesystem label SWAP-sda2 (RHBZ#666578)

Hi,

This is a purpose patch to avoid the message: unknown filesystem label
SWAP-sda2.

Instead of validate the label with 'eq', use '=~' and /$label/i.

https://bugzilla.redhat.com/show_bug.cgi?id=666578

Thanks
Douglas
(cherry picked from commit 5cab0d6c807d8a3bf9690375c663d11a10e21656)

13 years agoLib.pm: avoid message "unknown filesystem /dev/fd0" (RHBZ#666577)
Douglas Schilling Landgraf [Sun, 2 Jan 2011 18:52:52 +0000 (18:52 +0000)]
Lib.pm: avoid message "unknown filesystem /dev/fd0" (RHBZ#666577)

This patch to avoid the message "unknown filesystem /dev/fd0".
https://bugzilla.redhat.com/show_bug.cgi?id=666577

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Thanks
Douglas
(cherry picked from commit e99ac0394acbba2923e361d84511b9646f464585)

13 years agopodwrapper: Fix up the HTML output so most inter-page links work.
Richard W.M. Jones [Fri, 31 Dec 2010 11:11:02 +0000 (11:11 +0000)]
podwrapper: Fix up the HTML output so most inter-page links work.
(cherry picked from commit 5c9e8a65fe89e5e6baca8651000885d8467356ff)

13 years agopodwrapper: Fix script indentation.
Richard W.M. Jones [Fri, 31 Dec 2010 10:44:32 +0000 (10:44 +0000)]
podwrapper: Fix script indentation.
(cherry picked from commit d71faf98624c1fb2c760e0e9f55205beb06b7644)

13 years agopodwrapper: 'builddir' was not defined - use a properly defined path.
Richard W.M. Jones [Fri, 31 Dec 2010 10:39:05 +0000 (10:39 +0000)]
podwrapper: 'builddir' was not defined - use a properly defined path.
(cherry picked from commit 7a8c60e1c8fbaf09fb2fa2fe10b50df39c0d9650)

13 years agodocs: add-domain: Remove ref to not impl add-libvirt-dom API call.
Richard W.M. Jones [Thu, 30 Dec 2010 23:32:09 +0000 (23:32 +0000)]
docs: add-domain: Remove ref to not impl add-libvirt-dom API call.
(cherry picked from commit ce85a6a82ae80fdfb3eb7c2c2251658f8aadc241)

13 years agodocs: Refresh programming language list in guestfs(3).
Richard W.M. Jones [Thu, 30 Dec 2010 23:14:12 +0000 (23:14 +0000)]
docs: Refresh programming language list in guestfs(3).
(cherry picked from commit 86a53e17de672a79a994b905676b4566da9f072c)

13 years agodocs: Refresh programming language equivalence example in guestfs(3).
Richard W.M. Jones [Thu, 30 Dec 2010 23:08:18 +0000 (23:08 +0000)]
docs: Refresh programming language equivalence example in guestfs(3).
(cherry picked from commit 33e9639f2037540a89a9bbaf7212683e8a60fe84)

13 years agodocs: Fix missing g handle in guestfs(3) man page.
Richard W.M. Jones [Thu, 30 Dec 2010 22:56:25 +0000 (22:56 +0000)]
docs: Fix missing g handle in guestfs(3) man page.
(cherry picked from commit cdc798ac3558e416dc756a0fcefad2af5ca307e0)

13 years agodocs: Refresh guestfs(3)/DOWNLOADING.
Richard W.M. Jones [Thu, 30 Dec 2010 22:56:07 +0000 (22:56 +0000)]
docs: Refresh guestfs(3)/DOWNLOADING.
(cherry picked from commit 22042693cc1e0455a4a503dba93a9fedc9c74f04)

13 years agodocs: Refresh guestfs(3)/MOUNTING
Richard W.M. Jones [Thu, 30 Dec 2010 22:46:29 +0000 (22:46 +0000)]
docs: Refresh guestfs(3)/MOUNTING
(cherry picked from commit 1a9b7df8f2092701fdc5a77a4d9edfcaa1a20acf)

13 years agorecipes: Refresh guestfish recipes.
Richard W.M. Jones [Tue, 21 Dec 2010 17:23:08 +0000 (17:23 +0000)]
recipes: Refresh guestfish recipes.
(cherry picked from commit 49b2ae2e69e1a273b4d4a8746a872ec00b91c86f)

13 years agofish: --ro will be default in 1.10, not 1.8.
Richard W.M. Jones [Mon, 20 Dec 2010 22:33:45 +0000 (22:33 +0000)]
fish: --ro will be default in 1.10, not 1.8.
(cherry picked from commit 327442119ff1f1791a0682928e59b0c4b4752007)

13 years agodocs: Update API support.
Richard W.M. Jones [Mon, 10 Jan 2011 09:37:55 +0000 (09:37 +0000)]
docs: Update API support.

13 years agoapi-support: Fix detection of similar APIs.
Richard W.M. Jones [Sun, 19 Dec 2010 22:08:49 +0000 (22:08 +0000)]
api-support: Fix detection of similar APIs.

Because we didn't match on word boundaries, the previous
code would get confused by similar APIs, eg. getxattr vs getxattrs.
(cherry picked from commit 7ba1b55aa79c56ded770f8ea46716eb054fbfe78)

13 years agodocs: Obsolete HACKING file, move content into guestfs(3) man page.
Richard W.M. Jones [Sun, 19 Dec 2010 21:53:09 +0000 (21:53 +0000)]
docs: Obsolete HACKING file, move content into guestfs(3) man page.

Add a new section called "EXTENDING LIBGUESTFS" to the
guestfs manual page which contains all the information
previously in "HACKING".
(cherry picked from commit d2400da92e5e2cc7fd5e33e61220a33214d5241c)

13 years agodocs: Refresh README file.
Richard W.M. Jones [Sun, 19 Dec 2010 21:52:46 +0000 (21:52 +0000)]
docs: Refresh README file.
(cherry picked from commit 84fbe21855b5b304413075fecb444135397591e6)

13 years agoUpdate PO files along stable branch.
Richard W.M. Jones [Sun, 19 Dec 2010 15:57:30 +0000 (15:57 +0000)]
Update PO files along stable branch.

13 years agoUpdate BUGS, PO files for 1.8.0. 1.8.0
Richard W.M. Jones [Sun, 19 Dec 2010 15:39:04 +0000 (15:39 +0000)]
Update BUGS, PO files for 1.8.0.

13 years agoPrepare for next stable branch: version 1.8.0.
Richard W.M. Jones [Sun, 19 Dec 2010 14:31:01 +0000 (14:31 +0000)]
Prepare for next stable branch: version 1.8.0.

13 years agoUpdate RELEASE-NOTES.
Richard W.M. Jones [Sun, 19 Dec 2010 14:25:50 +0000 (14:25 +0000)]
Update RELEASE-NOTES.