libguestfs.git
13 years agoappliance: Add systemd to get /sbin/reboot for virt-rescue (RHBZ#661280).
Richard W.M. Jones [Wed, 13 Jul 2011 13:27:28 +0000 (14:27 +0100)]
appliance: Add systemd to get /sbin/reboot for virt-rescue (RHBZ#661280).
(cherry picked from commit aa8a9ebf29b7fdc97467e911560a1a7a774e9e1f)

13 years agopart-get-bootable: Fix when partitions are missing or unordered (RHBZ#602997).
Richard W.M. Jones [Tue, 12 Jul 2011 16:18:48 +0000 (17:18 +0100)]
part-get-bootable: Fix when partitions are missing or unordered (RHBZ#602997).
(cherry picked from commit 511c82df46f5c6f4a7f984fdb81d4691038ed6da)

13 years agoDocument that ntfsresize cannot be used multiple times (RHBZ#685009).
Richard W.M. Jones [Tue, 12 Jul 2011 13:13:57 +0000 (14:13 +0100)]
Document that ntfsresize cannot be used multiple times (RHBZ#685009).
(cherry picked from commit 2ba2ddf2113db7bb2afe3f739dc3cbaa5416a4ba)

13 years agoprotocol: Force optargs_bitmask to be passed as 0 for non-opt actions.
Richard W.M. Jones [Tue, 12 Jul 2011 17:17:35 +0000 (18:17 +0100)]
protocol: Force optargs_bitmask to be passed as 0 for non-opt actions.

If the action doesn't take optional arguments, nevertheless force the
optargs_bitmask field in the header to be passed as 0, and give an
error if not.
(cherry picked from commit 0344248af55802bbbd816b349ec1ba9305996f6e)

13 years agocapitests: Allow tests to properly test optional arguments.
Richard W.M. Jones [Wed, 6 Jul 2011 09:50:25 +0000 (10:50 +0100)]
capitests: Allow tests to properly test optional arguments.

For optional arguments, you can now specify empty string to mean no
argument, except for String optional arguments where you must use
"NOARG" (empty string meaning a supplied empty string argument).
(cherry picked from commit f7a11c60437afa700775eaa86a9be1a543427959)

13 years agoAdd caution subdirectory containing safety and liveness tests.
Richard W.M. Jones [Thu, 30 Jun 2011 11:57:31 +0000 (12:57 +0100)]
Add caution subdirectory containing safety and liveness tests.

Not that I'm paranoid about qemu breaking snapshots of anything like
that ...
(cherry picked from commit f3ada2c7653866f2529c9f18aaa99f76cd984844)

13 years agoChange download_to_tmp so it can work with multi-root operating systems.
Richard W.M. Jones [Mon, 27 Jun 2011 15:10:25 +0000 (16:10 +0100)]
Change download_to_tmp so it can work with multi-root operating systems.

The previous guestfs___download_to_tmp function did not handle
multiboot correctly.  In particular it used the same cache name
for downloaded files from different roots, which could have caused
things like applications in each root to be confused.

This changes the function so that the cache filename is prefixed
with the root / fs number, eg. $tmpdir/0-Name instead of $tmpdir/Name.

This change also requires the function to return the new name, so
all places in the code which called this function had to be
updated.

This updates and fixes commit 3c1f762abed92f7a358f3bc93e3396d0606b18ad.

(Cherry picked and backported from
commit 5f26270c343bf543a7bf20cf3e6f182f6282f8ea)

13 years agogenerator: Fix functions with both RBufferOut and optional args.
Richard W.M. Jones [Tue, 28 Jun 2011 07:50:14 +0000 (08:50 +0100)]
generator: Fix functions with both RBufferOut and optional args.

No current function returns RBufferOut and has optional args.  Such
functions would be generated incorrectly.

RBufferOut implies a silent "size_t *size_r" argument is added after
the regular arguments and before the optional arguments.  Various
changes to the code generator need to be made to take this into
account.
(cherry picked from commit adb5db58d850ce6d15380177a63c68276f863c98)

13 years agoinspector: Fix comment in virt-inspector.rng.
Richard W.M. Jones [Tue, 28 Jun 2011 16:02:46 +0000 (17:02 +0100)]
inspector: Fix comment in virt-inspector.rng.

The comment referred to the command line syntax of the old
virt-inspector.
(cherry picked from commit ea96c7acf7a332c08c2214796add647224a2ede0)

13 years agoRevert "Lib.pm: unknown filesystem label SWAP-sda2 (RHBZ#666578)"
Richard W.M. Jones [Mon, 27 Jun 2011 17:14:15 +0000 (18:14 +0100)]
Revert "Lib.pm: unknown filesystem label SWAP-sda2 (RHBZ#666578)"

This reverts commit 5cab0d6c807d8a3bf9690375c663d11a10e21656.
(cherry picked from commit 123610f1b5133a9e541a245467f60d065ea96575)

13 years agotrace: Print empty list correctly.
Richard W.M. Jones [Wed, 22 Jun 2011 09:36:44 +0000 (10:36 +0100)]
trace: Print empty list correctly.

Empty lists returned by RStringList and RHashtable functions
were incorrectly printed as [""].

Fix this so they are printed as [] instead.
(cherry picked from commit 56b94f5f6aa7981533ad867cc908c6e9cca2ba42)

13 years agoperl: Ignore MYMETA.yml.
Richard W.M. Jones [Sat, 18 Jun 2011 12:04:18 +0000 (13:04 +0100)]
perl: Ignore MYMETA.yml.

This file is created by one of the build tools used by Perl 5.14.
(cherry picked from commit cabfaa857fbd325bd0303fa56b28df8ce52aab33)

13 years agoperl: Don't use qw() as parentheses.
Richard W.M. Jones [Sat, 18 Jun 2011 12:00:00 +0000 (13:00 +0100)]
perl: Don't use qw() as parentheses.

In Perl 5.14:

Use of qw(...) as parentheses is deprecated at perl/blib/lib/Sys/Guestfs/Lib.pm line 1111.
(cherry picked from commit 5c3c7e8825341e18c9449976f8a321a04cc78d79)

13 years agoVersion 1.10.4. 1.10.4
Richard W.M. Jones [Mon, 13 Jun 2011 13:23:17 +0000 (14:23 +0100)]
Version 1.10.4.

13 years agogenerator: Rewrite UUIDs that begin with zero byte.
Richard W.M. Jones [Mon, 13 Jun 2011 17:58:53 +0000 (18:58 +0100)]
generator: Rewrite UUIDs that begin with zero byte.

In util-linux <= 2.19, mkswap -U cannot handle the first byte of the
UUID being zero, so we artificially rewrite such UUIDs.

See: http://article.gmane.org/gmane.linux.utilities.util-linux-ng/4273
(cherry picked from commit 4ee190628bc05f0c8fad1f6d9c3e85619a91e8b8)

13 years agobuild: include <string.h> for src/match.c's use of strlen
Jim Meyering [Fri, 10 Jun 2011 09:57:20 +0000 (11:57 +0200)]
build: include <string.h> for src/match.c's use of strlen
(cherry picked from commit daf55c07978cd29fe6675911bf76da0b056fdae1)

13 years agodaemon: Keep Coverity happy by ignoring some return values.
Richard W.M. Jones [Thu, 9 Jun 2011 09:10:50 +0000 (10:10 +0100)]
daemon: Keep Coverity happy by ignoring some return values.
(cherry picked from commit f5096dd546ac43c7288b3ab7aec1562f070f78f6)

13 years agoCoverity: Don't return freed pointers from command* along error path.
Richard W.M. Jones [Thu, 9 Jun 2011 08:39:54 +0000 (09:39 +0100)]
Coverity: Don't return freed pointers from command* along error path.

If the external command failed to run, we could free up the allocated
*stdoutput and *stderror pointers, but then return those freed
pointers to the caller.  The caller usually tries to print and free
*stderror, so this is a serious error.

Instead, return *stdoutput as NULL, and *stderror pointing to a
generic error message.
(cherry picked from commit 29453a58d818df24c238d0a08a68886ebe4029dd)

13 years agoCoverity: Missing return on error path.
Richard W.M. Jones [Wed, 8 Jun 2011 21:38:53 +0000 (22:38 +0100)]
Coverity: Missing return on error path.
(cherry picked from commit 7a091a11d7aeddc170e4d1b833fd9d7d18c00841)

13 years agoCoverity: Ensure fp is closed along all error paths.
Richard W.M. Jones [Wed, 8 Jun 2011 21:30:24 +0000 (22:30 +0100)]
Coverity: Ensure fp is closed along all error paths.
(cherry picked from commit 346c5b0ebf58c81f657540eeb72abaa41bfc4e3f)

13 years agoCoverity: Close directory handle along error paths.
Richard W.M. Jones [Wed, 8 Jun 2011 21:27:01 +0000 (22:27 +0100)]
Coverity: Close directory handle along error paths.
(cherry picked from commit 7c020a14802255c966b2b402b983551b86a08bba)

13 years agoCoverity: Don't leak argv arrays.
Richard W.M. Jones [Wed, 8 Jun 2011 21:25:21 +0000 (22:25 +0100)]
Coverity: Don't leak argv arrays.
(cherry picked from commit 869c11b30c72c57e48dd63c4641087a06abe80d5)

13 years agoCoverity: Don't leak error strings.
Richard W.M. Jones [Wed, 8 Jun 2011 21:16:59 +0000 (22:16 +0100)]
Coverity: Don't leak error strings.
(cherry picked from commit 3135b8c378f9f98ae66e37fd79d305764334980d)

13 years agoCoverity: Check return value of sysroot_path.
Richard W.M. Jones [Wed, 8 Jun 2011 21:14:21 +0000 (22:14 +0100)]
Coverity: Check return value of sysroot_path.

For some reason we were checking the parameter!
(cherry picked from commit 7fae594df719d1d81a043c4d0280b359f750facb)

13 years agoCoverity: Check return value of malloc.
Richard W.M. Jones [Wed, 8 Jun 2011 21:07:36 +0000 (22:07 +0100)]
Coverity: Check return value of malloc.
(cherry picked from commit 3a5bd5aba23583e64bfaabc906ca95b0f9d37578)

13 years agoCoverity: Don't close fd_cwd if fd_cwd == -1.
Richard W.M. Jones [Wed, 8 Jun 2011 21:04:25 +0000 (22:04 +0100)]
Coverity: Don't close fd_cwd if fd_cwd == -1.
(cherry picked from commit 76dfb74324fa0daa343d7edf89bd05e1fe7b4db0)

13 years agoCoverity: Avoid calling sort_strings (NULL, 0) on empty list.
Richard W.M. Jones [Wed, 8 Jun 2011 21:01:41 +0000 (22:01 +0100)]
Coverity: Avoid calling sort_strings (NULL, 0) on empty list.
(cherry picked from commit 3ed8d5122026f37dd96cc7e8503c4f3ecf0afbb7)

13 years agoCoverity: Don't call free_strings (NULL).
Richard W.M. Jones [Wed, 8 Jun 2011 20:56:56 +0000 (21:56 +0100)]
Coverity: Don't call free_strings (NULL).
(cherry picked from commit 48ebf50f3136ac27f4252662e351230ffa2b15e5)

13 years agoCoverity: Remove unreachable code.
Richard W.M. Jones [Wed, 8 Jun 2011 20:53:07 +0000 (21:53 +0100)]
Coverity: Remove unreachable code.
(cherry picked from commit 9160eec4fbf12643d8d5fa13465066822b2fed92)

13 years agoinit: Remove timeout in udevadm settle command.
Richard W.M. Jones [Wed, 8 Jun 2011 12:12:01 +0000 (13:12 +0100)]
init: Remove timeout in udevadm settle command.

The given timeout (10s) was too low if the appliance was
running slowly, which caused a cascade of other failures
during tests.

Note that in udev-171 and above on Fedora, /sbin/start_udev
no longer exists, so now we are using this manual method to
start udevd.
(cherry picked from commit bfc02f78f36d88543f8435e450e28c986b667a94)

13 years agoprotocol: Enhance "unexpected end of file when reading from daemon" error.
Richard W.M. Jones [Tue, 7 Jun 2011 11:36:02 +0000 (12:36 +0100)]
protocol: Enhance "unexpected end of file when reading from daemon" error.

Make this error more informative, since it is a common error when the
appliance fails to start up.
(cherry picked from commit 2f73ea343cc4a3433f20e99a7835152767a70f80)

13 years agoOnly include date, not time, in BUGS file.
Richard W.M. Jones [Sat, 4 Jun 2011 21:47:52 +0000 (22:47 +0100)]
Only include date, not time, in BUGS file.

This is so the file does not change so often when using 'make dist'.
(cherry picked from commit cdd11b758f2601f7eeda4fca684638b0335d531a)

13 years agovirt-ls: Refactor mode selection code.
Richard W.M. Jones [Fri, 3 Jun 2011 14:19:05 +0000 (15:19 +0100)]
virt-ls: Refactor mode selection code.

This is just code motion.
(cherry picked from commit bb965ded274f911fb5d7889f88db9adaad1d2a52)

13 years agovirt-ls: Small fix for output of --help option.
Richard W.M. Jones [Fri, 3 Jun 2011 13:49:19 +0000 (14:49 +0100)]
virt-ls: Small fix for output of --help option.
(cherry picked from commit 7177340a6f0e3ac1f238c69b0ad5267e18252fe2)

13 years agoUbuntu: Fix compilation of virt-resize if old libguestfs already installed.
Richard W.M. Jones [Sat, 4 Jun 2011 12:13:11 +0000 (13:13 +0100)]
Ubuntu: Fix compilation of virt-resize if old libguestfs already installed.
(cherry picked from commit 418842518bf856144e2ab33abb6de417d1b60753)

13 years agodaemon: Fix error message.
Nikita A Menkovich [Fri, 20 May 2011 10:26:09 +0000 (11:26 +0100)]
daemon: Fix error message.
(cherry picked from commit 08bc8e40cea750bd35493ecab514e8e37c883a0a)

13 years agodebian: Add build dependencies: dpkg-dev, devscripts, gperf.
Nikita A Menkovich [Fri, 20 May 2011 09:35:06 +0000 (10:35 +0100)]
debian: Add build dependencies: dpkg-dev, devscripts, gperf.
(cherry picked from commit b85b4fafe1e23dc99d10647f6d35cd37b0a3f02a)

13 years agodaemon: Make sysroot_len be size_t instead of int.
Richard W.M. Jones [Thu, 19 May 2011 13:44:02 +0000 (14:44 +0100)]
daemon: Make sysroot_len be size_t instead of int.
(cherry picked from commit 4b91462bad010a0b214e808f94a916002be65b91)

13 years agoguestfs-examples(3): Remove link to OCaml homepage.
Richard W.M. Jones [Wed, 18 May 2011 14:32:59 +0000 (15:32 +0100)]
guestfs-examples(3): Remove link to OCaml homepage.
(cherry picked from commit 95368927219f2888aeb1232c7ec950dde538bc39)

13 years agoDocument that guestfs_file output depends on file(1) command.
Richard W.M. Jones [Tue, 17 May 2011 19:57:56 +0000 (20:57 +0100)]
Document that guestfs_file output depends on file(1) command.

And therefore practically it cannot be part of the ABI since
the output of file(1) itself changes from time to time.
(cherry picked from commit ef6f877b9df261fad1fbf361b8ce7af1055dfbb7)

13 years agofuse: Add note about allowing other users to see filesystem (RHBZ#705200).
Richard W.M. Jones [Tue, 17 May 2011 18:51:37 +0000 (19:51 +0100)]
fuse: Add note about allowing other users to see filesystem (RHBZ#705200).
(cherry picked from commit b777a5a64926e9bf9b7109a0e4fb1332b20fa37f)

13 years agogenerator: Mark sfdisk functions as deprecated.
Richard W.M. Jones [Tue, 17 May 2011 14:52:28 +0000 (15:52 +0100)]
generator: Mark sfdisk functions as deprecated.

Point to the part-* API calls as replacements.
(cherry picked from commit 12414ddc020f94e75a791815d2c1ac2b0d76eaf1)

13 years agogenerator: Mark mount as deprecated.
Richard W.M. Jones [Tue, 17 May 2011 14:52:16 +0000 (15:52 +0100)]
generator: Mark mount as deprecated.

Callers should use 'mount_options' or 'mount_vfs' instead.

See also:
http://libguestfs.org/guestfs.3.html#libguestfs_gotchas
(cherry picked from commit 4ec8fd189dc8404e713c00bcfc36de358f5cdca3)

13 years agogenerator: Mark wait_ready as deprecated.
Richard W.M. Jones [Tue, 17 May 2011 14:51:25 +0000 (15:51 +0100)]
generator: Mark wait_ready as deprecated.

The function has been a no op for a very long time.  By marking
it as deprecated we make it clear that you shouldn't call it
in new code.
(cherry picked from commit 31de91f6d2605899b3a797b73b358eec9c0b1196)

13 years agogenerator: Check the flags fields.
Richard W.M. Jones [Tue, 17 May 2011 14:50:16 +0000 (15:50 +0100)]
generator: Check the flags fields.
(cherry picked from commit b43482964a8c7e19f47943506872cd58601c28e9)

13 years agofish: fuse: Remove redundant -DGUESTFS_DEFAULT_PATH.
Richard W.M. Jones [Tue, 17 May 2011 13:46:16 +0000 (14:46 +0100)]
fish: fuse: Remove redundant -DGUESTFS_DEFAULT_PATH.

This was left over from earlier code.  It is used in the base library,
but not in guestfish or guestmount.
(cherry picked from commit 8c0aca8d9280fb87027826fe89d70cc2701e7f8b)

13 years agolib: Add GCC version macro to the header file.
Richard W.M. Jones [Tue, 17 May 2011 13:41:34 +0000 (14:41 +0100)]
lib: Add GCC version macro to the header file.

This will be used to internally enable various GCC enhancements.
(cherry picked from commit 33adb59b60b1358656439a757f319ba8ce81e26c)

13 years agolib: Add vertical space between each function in <guestfs.h>.
Richard W.M. Jones [Tue, 17 May 2011 13:43:48 +0000 (14:43 +0100)]
lib: Add vertical space between each function in <guestfs.h>.
(cherry picked from commit 36b236fc97880c04e2ceeac502ff07a5e9993e28)

13 years agoappliance: Use qemu -machine option where available (RHBZ#700369).
Richard W.M. Jones [Tue, 17 May 2011 12:58:20 +0000 (13:58 +0100)]
appliance: Use qemu -machine option where available (RHBZ#700369).

(Cherry picked from commit 64841fe8957f798df12a38bd81843c7011f2c278)

13 years agodebian: Note that libconfig-dev ought to be required.
Richard W.M. Jones [Thu, 12 May 2011 15:04:16 +0000 (16:04 +0100)]
debian: Note that libconfig-dev ought to be required.

However it doesn't appear to be in Debian at the moment.
(cherry picked from commit e95671d69e697f5b44775f797f1ef9fc0829d313)

13 years agodebian: Include debian/ directory in tarball.
Richard W.M. Jones [Thu, 12 May 2011 12:52:27 +0000 (13:52 +0100)]
debian: Include debian/ directory in tarball.

This makes it simpler to build Debian and Ubuntu packages from the
tarballs.
(cherry picked from commit 91ea9c1805112233140a463256c89072121fc182)

13 years agoVersion 1.10.3. 1.10.3
Richard W.M. Jones [Wed, 18 May 2011 10:40:08 +0000 (11:40 +0100)]
Version 1.10.3.

13 years agobuild: Sort EXTRA_DIST into lexicographic order.
Richard W.M. Jones [Thu, 12 May 2011 12:50:38 +0000 (13:50 +0100)]
build: Sort EXTRA_DIST into lexicographic order.
(cherry picked from commit 48c91ac03cb0a6ac351822fe70200abb8ac7f761)

13 years agodaemon: Remove some less useful debugging messages.
Richard W.M. Jones [Sun, 8 May 2011 20:59:50 +0000 (21:59 +0100)]
daemon: Remove some less useful debugging messages.

Remove some debug messages which were basically left over from when
the code was being developed.

However we leave debug messages where it is printing an external
command that is about to be executed, since those are useful.
(cherry picked from commit 5ce759bfdc70c97121ef34ab4d5c918d568f2474)

13 years agoFix guestfs___rollback_cmdline when pos == 0.
Richard W.M. Jones [Sun, 8 May 2011 14:13:23 +0000 (15:13 +0100)]
Fix guestfs___rollback_cmdline when pos == 0.

Because of the previous change to size_t, when pos == 0 the loop would
wrap around and cause a segmentation fault.

This fixes a regression introduced by
commit 10167cea98f93a74abe63f0a54d3a662997e7489.
(cherry picked from commit 607aa95de927b5b8e4b212655c71bf21acbba372)

13 years agoconfigure: Sort output files in AC_CONFIG_FILES section.
Richard W.M. Jones [Fri, 6 May 2011 21:33:44 +0000 (17:33 -0400)]
configure: Sort output files in AC_CONFIG_FILES section.
(cherry picked from commit 8ee0ad0caf2f90f4883909cd9b61c4dd6f9cffbf)

13 years agodoc: Use I<-...> for cross-references to command line options.
Richard W.M. Jones [Sun, 1 May 2011 21:41:20 +0000 (17:41 -0400)]
doc: Use I<-...> for cross-references to command line options.

This is now used consistently across all the documentation.
(cherry picked from commit c49fc3831d12788c27b90d12f06a1cd69a88e3be)

13 years agodf: Refresh virt-df(1) man page.
Richard W.M. Jones [Sun, 1 May 2011 18:53:23 +0000 (14:53 -0400)]
df: Refresh virt-df(1) man page.

Add examples.

Refresh description.

Use I<...> to refer to command line options.
(cherry picked from commit 988a8784647a66adbece3c9fb470c06a4cce3cdd)

13 years agoguestfs(3): Note that host file size limits affect guest disk limits.
Richard W.M. Jones [Sun, 1 May 2011 00:11:21 +0000 (20:11 -0400)]
guestfs(3): Note that host file size limits affect guest disk limits.
(cherry picked from commit 805e6dbc15eae5a4f85eea3c37e295aefaefeb69)

13 years agoguestfs(3): Refresh documentation for private data area keys.
Richard W.M. Jones [Sat, 30 Apr 2011 23:38:20 +0000 (19:38 -0400)]
guestfs(3): Refresh documentation for private data area keys.
(cherry picked from commit 40f2b698ac765128bfcda5f0db893c95d09ae89a)

13 years agoguestfs(3): Referenced section is above, not below.
Richard W.M. Jones [Sat, 30 Apr 2011 23:10:52 +0000 (19:10 -0400)]
guestfs(3): Referenced section is above, not below.
(cherry picked from commit 108d7a134c5d26b967fa7162d9b80b40112c2869)

13 years agoguestfs(3): Refresh autosync gotcha documentation.
Richard W.M. Jones [Sat, 30 Apr 2011 23:10:25 +0000 (19:10 -0400)]
guestfs(3): Refresh autosync gotcha documentation.
(cherry picked from commit a5e421570cc840f70f2931e24b3df40c9a14cd2d)

13 years agoguestfs(3): Writing to a file descriptor, not just a pipe.
Richard W.M. Jones [Sat, 30 Apr 2011 22:45:56 +0000 (18:45 -0400)]
guestfs(3): Writing to a file descriptor, not just a pipe.
(cherry picked from commit 470e373eea218c8d46b0c63dda93ee9ece48940f)

13 years agoguestfs(3): Refresh documentation for guestfs_create, guestfs_close.
Richard W.M. Jones [Sat, 30 Apr 2011 22:31:06 +0000 (18:31 -0400)]
guestfs(3): Refresh documentation for guestfs_create, guestfs_close.
(cherry picked from commit dd86183f3f6d4d5ad28e1f12c56ba920934e7ad0)

13 years agointernal: Use size_t instead of int for command line size.
Richard W.M. Jones [Sat, 30 Apr 2011 09:49:06 +0000 (05:49 -0400)]
internal: Use size_t instead of int for command line size.
(cherry picked from commit 10167cea98f93a74abe63f0a54d3a662997e7489)

13 years agoguestfs_close: Move local variables close to code that uses them.
Richard W.M. Jones [Sat, 30 Apr 2011 09:45:26 +0000 (05:45 -0400)]
guestfs_close: Move local variables close to code that uses them.

This is just code motion.
(cherry picked from commit 478b2d80ed1d613f621e89a97a0b140004ebac29)

13 years agoguestfs_close: Remove unused local variable.
Richard W.M. Jones [Sat, 30 Apr 2011 09:42:43 +0000 (05:42 -0400)]
guestfs_close: Remove unused local variable.
(cherry picked from commit b2f8627ab59daeb03f036dde6c66fb9da736950c)

13 years agoguestfs(3): Document limits.
Richard W.M. Jones [Wed, 27 Apr 2011 19:10:24 +0000 (20:10 +0100)]
guestfs(3): Document limits.
(cherry picked from commit c0f96e9c6eda77e5e99de862dd4366010e4a1ab8)

13 years agozero: Disable file test because of bug in file command.
Richard W.M. Jones [Wed, 18 May 2011 09:04:05 +0000 (10:04 +0100)]
zero: Disable file test because of bug in file command.

See: https://bugzilla.redhat.com/show_bug.cgi?id=705499
(cherry picked from commit f55b32b2db83495fc0987f0fe0e979818704dff1)

13 years agoVersion 1.10.2. 1.10.2
Richard W.M. Jones [Sun, 24 Apr 2011 08:54:55 +0000 (09:54 +0100)]
Version 1.10.2.

13 years agopython: Rearrange C files for bindings.
Richard W.M. Jones [Fri, 22 Apr 2011 18:58:29 +0000 (19:58 +0100)]
python: Rearrange C files for bindings.

Move the hand-written functions into two new files:
guestfs-py.h and guestfs-py-byhand.c

This is just code motion.
(cherry picked from commit 16da7589e91b0030fb5564553447f80b97c0b18c)

13 years agoperl: Decrement refcount in $g->delete_event_callback.
Richard W.M. Jones [Fri, 22 Apr 2011 20:34:08 +0000 (21:34 +0100)]
perl: Decrement refcount in $g->delete_event_callback.

This updates commit bc468c87d04b34faacd208c49cca4a5096e5103c.
(cherry picked from commit 3acf732c2f23d8508f692efb2b222169914bfcdc)

13 years agoinspect: Look for %systemroot%/system32 for Windows heuristic.
Richard W.M. Jones [Thu, 21 Apr 2011 16:33:48 +0000 (17:33 +0100)]
inspect: Look for %systemroot%/system32 for Windows heuristic.

The virt-v2v transfer ISO had a /windows directory.  The core
inspection code thought this was a Windows root filesystem.
(cherry picked from commit 0da6f55a6745686ca056c6bc8ebf647f111cb8e8)

13 years agolist-applications: If software hive is missing, this is an error.
Richard W.M. Jones [Thu, 21 Apr 2011 16:29:44 +0000 (17:29 +0100)]
list-applications: If software hive is missing, this is an error.

virt-inspector would exit silently if list-applications failed along
this error path.
(cherry picked from commit 782f3a36469ca396dbf998ea82af2699153be3ed)

13 years agoinspect: "centos" and "scientificlinux" are now separate distros.
Richard W.M. Jones [Thu, 21 Apr 2011 14:09:11 +0000 (15:09 +0100)]
inspect: "centos" and "scientificlinux" are now separate distros.

Previously we returned "rhel" for these, which was not accurate.
(cherry picked from commit 2b0ca7e7b8d369a42a51b1feec72ae8f17257c78)

13 years agoVersion 1.10.1 1.10.1
Richard W.M. Jones [Mon, 18 Apr 2011 21:40:04 +0000 (22:40 +0100)]
Version 1.10.1

13 years agopython: Release Python GIL while running libguestfs calls.
Richard W.M. Jones [Mon, 18 Apr 2011 15:56:08 +0000 (16:56 +0100)]
python: Release Python GIL while running libguestfs calls.

Release the Python global interpreter lock while running libguestfs
calls.

We don't release it around guestfs_create() because that is a short
call that just allocates memory.  We do release it around
guestfs_close() since that is a potentially long-running (it can call
wait(2) amongst other things).  We also release it around all the
other generated Python calls.

We don't yet support callbacks into Python code (ie. the new event
API).  But when we do in future, we will need to also handle the GIL
around those callbacks.

This code is adapted from libvirt's python/typewrappers.h.  Thanks to
Dan Berrange for showing us how to do this properly.
(cherry picked from commit 08dc4a87b92435678780e9c49fe3bc1e7465d99f)

13 years agofish: --rw option will be mandatory in 1.12 not 1.10.
Richard W.M. Jones [Sat, 16 Apr 2011 20:35:11 +0000 (21:35 +0100)]
fish: --rw option will be mandatory in 1.12 not 1.10.
(cherry picked from commit a3cce465570bf192e993a67feedfbab7e662c75a)

13 years agofish: Fix typo in guestfish man page (--format option).
Richard W.M. Jones [Sat, 16 Apr 2011 20:26:15 +0000 (21:26 +0100)]
fish: Fix typo in guestfish man page (--format option).
(cherry picked from commit 4c2bb8b301970e8853a8feaa95e3698224640fba)

13 years agoinspector: Refresh the virt-inspector(1) manpage.
Richard W.M. Jones [Sat, 16 Apr 2011 20:12:53 +0000 (21:12 +0100)]
inspector: Refresh the virt-inspector(1) manpage.
(cherry picked from commit 34d9fed24ad6a2d2e13bb817820e31373f6756e1)

13 years agorun script: Don't depend on libtool being installed.
Richard W.M. Jones [Sat, 16 Apr 2011 14:29:58 +0000 (15:29 +0100)]
run script: Don't depend on libtool being installed.

Also use 'exec' to run the program.
(cherry picked from commit 5d139fa8a4a7f9ff65e7b936fd7376f661c72f48)

13 years agoRemove local LIBGUESTFS_PATH detection from guestfish and guestmount.
Richard W.M. Jones [Sat, 16 Apr 2011 06:28:47 +0000 (07:28 +0100)]
Remove local LIBGUESTFS_PATH detection from guestfish and guestmount.

Remove the hack that let you run ./fish/guestfish or
./fuse/guestmount.  You now have to do:

  ./run ./fish/guestfish
or
  ./run ./fuse/guestmount

to run these programs without installing.
(cherry picked from commit 33a2c184e12c0bdbf061a9f36c87d76c28444712)

13 years agoRemove ad-hoc run*locally scripts, replace with './run'
Richard W.M. Jones [Fri, 15 Apr 2011 20:43:20 +0000 (21:43 +0100)]
Remove ad-hoc run*locally scripts, replace with './run'

Remove all the run*locally scripts and replace with a single top level
./run shell script.
(cherry picked from commit 5790f5bfafb12cc2ed9365461bf66e0fdfde7150)

13 years agoinspector: Handle write failures when creating example-*.xml.
Richard W.M. Jones [Thu, 14 Apr 2011 17:19:04 +0000 (18:19 +0100)]
inspector: Handle write failures when creating example-*.xml.
(cherry picked from commit 0108d7861d4cc9a1f0d87d89080d1be7750e54b5)

13 years agoDelete file so db_load doesn't run incrementally.
Richard W.M. Jones [Thu, 14 Apr 2011 17:17:43 +0000 (18:17 +0100)]
Delete file so db_load doesn't run incrementally.

It turns out that db_load incrementally updates the database (instead
of writing a new one).  Remove the old database to force db_load to
write a new one.

This also ensures that we handle write failure gracefully.

Cherry picked from commit 67493bfca44d436143d825b155bf2bc38990ea82
and backported to stable-1.10 branch.

13 years agoinspector: Include <hostname> in output.
Richard W.M. Jones [Thu, 14 Apr 2011 16:58:51 +0000 (17:58 +0100)]
inspector: Include <hostname> in output.
(cherry picked from commit 36d3a4ce53317b104d48b60c9fe1ed679065d1d4)

13 years agoinspect: Abstract out db_dump code for listing RPM applications.
Richard W.M. Jones [Thu, 14 Apr 2011 12:28:02 +0000 (13:28 +0100)]
inspect: Abstract out db_dump code for listing RPM applications.

There are two changes here:

(1) The code for listing RPM applications ran db_dump and parsed the
output.  We abstract out that parsing code into a separate reusable
module (src/dbdump.c).

(2) The old db_dump parsing code used db_dump -p (printable) format.
Instead use db_dump -k (hex) format so we can read binary fields.
(cherry picked from commit a986e8dadb0c70634f6d1d89dd3e7bb5d9af3078)

13 years agoinspect: Split code into separate files.
Richard W.M. Jones [Wed, 13 Apr 2011 22:27:05 +0000 (23:27 +0100)]
inspect: Split code into separate files.

The src/inspect.c file had grown rather large -- 3,500 lines.  Split
it across several files according to function.

This is just moving code.

After the split the files are more evenly divided:

  536 src/inspect_apps.c
  766 src/inspect.c
  537 src/inspect_fs.c
  404 src/inspect_fs_cd.c
  785 src/inspect_fs_unix.c
  535 src/inspect_fs_windows.c
 3563 total
(cherry picked from commit 3336b5448f12c9eb25bf7a0cecda1315c4cf07ea)

13 years agoinspect: Move shared PCRE match functions to separate file.
Richard W.M. Jones [Wed, 13 Apr 2011 22:02:45 +0000 (23:02 +0100)]
inspect: Move shared PCRE match functions to separate file.

This is just moving code around.
(cherry picked from commit 439a42efdb052748c8457f866b2c68a581034826)

13 years agoinspect: Cache downloaded files in the handle g->tmpdir.
Richard W.M. Jones [Wed, 13 Apr 2011 21:35:35 +0000 (22:35 +0100)]
inspect: Cache downloaded files in the handle g->tmpdir.

During inspection we download various files such as the Windows
'software' and 'system' registries.  Previously these were downloaded
as temporary files and discarded immediately after use.  This meant
that the 'software' registry was being downloaded twice by
virt-inspector (it's required once for basic OS inspection, and a
second time to list Windows applications).

This commit changes this so that these files are cached in g->tmpdir,
and thus the second time we just reuse the file we've already
downloaded.

Callers shouldn't be relying on inspect-list-applications to reread
the actual registry from the VM (unless you close and reopen the
handle).  It says in the documentation that the results of inspection
may be cached in the handle.
(cherry picked from commit 3c1f762abed92f7a358f3bc93e3396d0606b18ad)

13 years agoRemove temporary directory containing arbitrary files.
Richard W.M. Jones [Wed, 13 Apr 2011 21:02:08 +0000 (22:02 +0100)]
Remove temporary directory containing arbitrary files.

In preparation for caching inspection information in the temporary
directory (g->tmpdir), allow the temporary directory to contain
arbitrary files, and remove all of them when the handle is closed.

This just generalizes the previous method of cleaning up the tmpdir.
(cherry picked from commit 70975981bed8e0c01b5966c10b507bb82086e5f8)

13 years agoInclude string.h and libintl.h, as needed.
Jim Meyering [Wed, 13 Apr 2011 13:17:32 +0000 (15:17 +0200)]
Include string.h and libintl.h, as needed.

* df/df.c: As above.
* df/main.c: As above.
* df/output.c: As above.
* fuse/guestmount.c: As above.
* inspector/virt-inspector.c: As above.
* rescue/virt-rescue.c: As above.
(cherry picked from commit 6740028b333840eec5e8e46e8512f8155728b037)

13 years agoAdd more missing include directives.
Jim Meyering [Wed, 13 Apr 2011 11:15:39 +0000 (13:15 +0200)]
Add more missing include directives.

* cat/virt-cat.c: Include string.h and libintl.h.
* cat/virt-filesystems.c: Likewise.
* cat/virt-ls.c: Likewise.
(cherry picked from commit ace1795d1045be96f92a68e6b61ffdee60431fef)

13 years agodebian: Add dependency on libpcre-ocaml-dev.
Nikita A Menkovich [Wed, 13 Apr 2011 11:41:27 +0000 (12:41 +0100)]
debian: Add dependency on libpcre-ocaml-dev.
(cherry picked from commit 173c374bd01e84deafdaf1f9aa65b0f623e86470)

13 years agoAdd missing include directives.
Jim Meyering [Wed, 13 Apr 2011 11:00:06 +0000 (13:00 +0200)]
Add missing include directives.

* fish/config.c: Include string.h, for use of strlen.
* fish/keys.c: Likewise, but for use of memcpy.
* fish/man.c: Likewise, but for use of memset.
(cherry picked from commit 0db662eae54b21fccadabe817afbc0fa89d980b2)

13 years agoAvoid warning about implicit declaration of strlen.
Jim Meyering [Wed, 13 Apr 2011 09:11:42 +0000 (11:11 +0200)]
Avoid warning about implicit declaration of strlen.

* src/events.c: Include <string.h>, for use of strlen.
(cherry picked from commit a53833fdd21cd573fe8fd02d7a11a3a5e9764ce0)

13 years agodebian: libguestfs-test-tool-helper no longer exists.
Richard W.M. Jones [Tue, 12 Apr 2011 21:45:39 +0000 (22:45 +0100)]
debian: libguestfs-test-tool-helper no longer exists.
(cherry picked from commit 6ec2ed20cbbad871a8b48389cbe5785bb929c99f)

13 years agoresize: Include stamp file for manpage in CLEANFILES.
Richard W.M. Jones [Tue, 12 Apr 2011 21:45:18 +0000 (22:45 +0100)]
resize: Include stamp file for manpage in CLEANFILES.
(cherry picked from commit 0d9f2c7311b005b2cfe2ecb3ff9fb57d4576ef7b)

13 years agoVersion 1.10.0. 1.10.0
Richard W.M. Jones [Tue, 12 Apr 2011 19:15:01 +0000 (20:15 +0100)]
Version 1.10.0.

13 years agoUpdate RELEASE-NOTES for 1.10 release.
Richard W.M. Jones [Tue, 12 Apr 2011 18:36:25 +0000 (19:36 +0100)]
Update RELEASE-NOTES for 1.10 release.