pclose: Fix other places where we only tested pclose == -1.

pclose can return > 0 when the status of the command was non-zero.

diff --git a/fish/fish.c b/fish/fish.c
index efc74b2..c132911 100644 (file)
--- a/fish/fish.c
+++ b/fish/fish.c
@@ -995,7 +995,7 @@ execute_and_inline (const char *cmd, int global_exit_on_error)
 
   free (line);
 
-  if (pclose (pp) == -1) {
+  if (pclose (pp) != 0) {
     perror ("pclose");
     return -1;
   }

diff --git a/generator/generator_capitests.ml b/generator/generator_capitests.ml
index 963ed51..2cad2ae 100644 (file)
--- a/generator/generator_capitests.ml
+++ b/generator/generator_capitests.ml
@@ -106,7 +106,7 @@ md5sum (const char *filename, char *result)
     perror (\"md5sum: fread\");
     exit (EXIT_FAILURE);
   }
-  if (pclose (pp) == -1) {
+  if (pclose (pp) != 0) {
     perror (\"pclose\");
     exit (EXIT_FAILURE);
   }

diff --git a/src/appliance.c b/src/appliance.c
index 1df8c36..9f86954 100644 (file)
--- a/src/appliance.c
+++ b/src/appliance.c
@@ -241,7 +241,7 @@ calculate_supermin_checksum (guestfs_h *g, const char *supermin_path)
     return NULL;
   }
 
-  if (pclose (pp) == -1) {
+  if (pclose (pp) != 0) {
     warning (g, "pclose: %m");
     return NULL;
   }

diff --git a/src/dbdump.c b/src/dbdump.c
index caf6376..45c67c6 100644 (file)
--- a/src/dbdump.c
+++ b/src/dbdump.c
@@ -129,7 +129,7 @@ guestfs___read_db_dump (guestfs_h *g,
   }
 
   /* Catch errors from the db_dump command. */
-  if (pclose (pp) == -1) {
+  if (pclose (pp) != 0) {
     perrorf (g, "pclose: %s", cmd);
     goto out;
   }