Don't need to include XDR headers in <guestfs.h>.

Include the XDR headers in the internal guestfs-internal.h instead.

This is knock-on effects to several other source files which
were implicitly relying on indirectly loaded headers.

diff --git a/fish/copy.c b/fish/copy.c
index f5edad1..9f3f3df 100644 (file)
--- a/fish/copy.c
+++ b/fish/copy.c
@@ -22,6 +22,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
+#include <limits.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <sys/wait.h>

diff --git a/fish/progress.c b/fish/progress.c
index f196786..27dfbec 100644 (file)
--- a/fish/progress.c
+++ b/fish/progress.c
@@ -22,6 +22,7 @@
 #include <stdlib.h>
 #include <inttypes.h>
 #include <math.h>
+#include <sys/time.h>
 
 #include <guestfs.h>
 

diff --git a/fish/time.c b/fish/time.c
index 48cf100..931403f 100644 (file)
--- a/fish/time.c
+++ b/fish/time.c
@@ -22,6 +22,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
+#include <sys/time.h>
 
 #include "fish.h"
 

diff --git a/generator/generator_c.ml b/generator/generator_c.ml
index caf73c3..0194e0c 100644 (file)
--- a/generator/generator_c.ml
+++ b/generator/generator_c.ml
@@ -360,10 +360,9 @@ and generate_guestfs_h () =
 extern \"C\" {
 #endif
 
+#include <stddef.h>
 #include <stdint.h>
 #include <stdarg.h>
-#include <rpc/types.h>
-#include <rpc/xdr.h>
 
 /* The handle. */
 #ifndef GUESTFS_TYPEDEF_H

diff --git a/generator/generator_fish.ml b/generator/generator_fish.ml
index f59c520..0c81dfc 100644 (file)
--- a/generator/generator_fish.ml
+++ b/generator/generator_fish.ml
@@ -909,6 +909,8 @@ and generate_fish_prep_options_c () =
   generate_header CStyle GPLv2plus;
 
   pr "\
+#include <stdio.h>
+
 #include \"fish.h\"
 #include \"prepopts.h\"
 

diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h
index f8b3e94..6dbbeec 100644 (file)
--- a/src/guestfs-internal.h
+++ b/src/guestfs-internal.h
@@ -19,6 +19,9 @@
 #ifndef GUESTFS_INTERNAL_H_
 #define GUESTFS_INTERNAL_H_
 
+#include <rpc/types.h>
+#include <rpc/xdr.h>
+
 #ifdef HAVE_PCRE
 #include <pcre.h>
 #endif