Use mount-options instead of mount to avoid implicit -o sync.
authorRichard Jones <rjones@redhat.com>
Tue, 9 Feb 2010 18:00:24 +0000 (18:00 +0000)
committerRichard Jones <rjones@redhat.com>
Wed, 10 Feb 2010 10:46:23 +0000 (10:46 +0000)
commitf93cbe5756cf052cce8049087afdcf714a3fc70c
treec8caeeeb48f4293aa3aa7781fa3ae013b146728a
parent245ac5673700f54479e9408e8659cb68f80c344a
Use mount-options instead of mount to avoid implicit -o sync.

guestfs_mount adds -o sync implicitly.  This causes a very large
performance problem for write-intensive programs (eg. virt-v2v).

Document this as a "gotcha".

Change the tests, guestfish, Sys::Guestfs::Lib, guestmount to use
mount-options instead.

(Note that this gotcha does not affect mount-ro).

The source of the performance problem was first identified by
Matthew Booth.
fish/fish.c
fuse/guestmount.c
perl/lib/Sys/Guestfs/Lib.pm
perl/t/060-readdir.t
regressions/rhbz503169c10.sh
regressions/rhbz503169c13.sh
regressions/test-cancellation-upload-daemoncancels.sh
regressions/test-remote.sh
src/generator.ml
src/guestfs.pod
test-tool/test-tool.c