Non-existant files and images throw 404, instead of 500, errors.

[cocanwiki.git] / scripts / image.ml

diff --git a/scripts/image.ml b/scripts/image.ml
index bfffbfd..0558950 100644 (file)
--- a/scripts/image.ml
+++ b/scripts/image.ml
@@ -1,7 +1,7 @@
 (* COCANWIKI - a wiki written in Objective CAML.
  * Written by Richard W.M. Jones <rich@merjis.com>.
  * Copyright (C) 2004 Merjis Ltd.
- * $Id: image.ml,v 1.9 2004/10/23 12:00:23 rich Exp $
+ * $Id: image.ml,v 1.11 2004/10/24 11:34:37 rich Exp $
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -50,10 +50,13 @@ let run r (q : cgi) (dbh : Dbi.connection) hostid _ _ =
   sth#execute args;
 
   let data, mime_type, deleted =
-    match sth#fetch1 () with
-       [ `Binary data; `String mime_type; `Bool deleted ] ->
-         data, mime_type, deleted
-      | _ -> assert false in
+    try
+      (match sth#fetch1 () with
+          [ `Binary data; `String mime_type; `Bool deleted ] ->
+            data, mime_type, deleted
+        | _ -> assert false)
+    with
+       Not_found -> raise (HttpError cHTTP_NOT_FOUND) in
 
   (* If deleted, refuse to serve this image except if called from the
    * deleted images page.
@@ -65,8 +68,10 @@ let run r (q : cgi) (dbh : Dbi.connection) hostid _ _ =
       try String.find referer "/_images?deleted"; true
       with String.Invalid_string -> false in
 
-    if not ok then
-      failwith "image.ml: bandwidth theft avoided"
+    if not ok then (
+      prerr_endline "image.ml: bandwidth theft avoided";
+      raise (HttpError cHTTP_NOT_FOUND)
+    )
   );
 
   if version <> None then