Version 0.1.3.

[guestfs-browser.git] / filetree_markup.ml

diff --git a/filetree_markup.ml b/filetree_markup.ml
index beb41b2..a890cca 100644 (file)
--- a/filetree_markup.ml
+++ b/filetree_markup.ml
@@ -90,7 +90,6 @@ and markup_of_regkey ?(visited = false) h node =
 
 (* Mark up a registry value. *)
 and markup_of_regvalue ?(visited = false) h value =
-  debug "markup_of_regvalue";
   let k = Hivex.value_key h value in
   let k = if k = "" then "@" else k in
   let t, v = Hivex.value_value h value in
@@ -98,56 +97,13 @@ and markup_of_regvalue ?(visited = false) h value =
   (* Ignore long values. *)
   let len = String.length v in
   let v =
-    if len >= 256 then
-      sprintf "<%d bytes not printed>" len
-    else (
-      (* Deal as best we can with printing the value. *)
-      match t with
-      | Hivex.REG_NONE -> if v = "" then "" else markup_hex_data v
-      | Hivex.REG_SZ -> markup_windows_string v
-      | Hivex.REG_EXPAND_SZ -> markup_windows_string v
-      | Hivex.REG_BINARY -> markup_hex_data v
-      | Hivex.REG_DWORD ->
-          (bitmatch Bitstring.bitstring_of_string v with
-           | { i : 32 : littleendian } -> sprintf "%08lx" i
-           | { _ } -> markup_hex_data v)
-      | Hivex.REG_DWORD_BIG_ENDIAN ->
-          (bitmatch Bitstring.bitstring_of_string v with
-           | { i : 32 : bigendian } -> sprintf "%08lx" i
-           | { _ } -> markup_hex_data v)
-      | Hivex.REG_LINK -> markup_hex_data v
-      | Hivex.REG_MULTI_SZ -> (* XXX could do better with this *)
-          markup_hex_data v
-      | Hivex.REG_RESOURCE_LIST -> markup_hex_data v
-      | Hivex.REG_FULL_RESOURCE_DESCRIPTOR -> markup_hex_data v
-      | Hivex.REG_RESOURCE_REQUIREMENTS_LIST -> markup_hex_data v
-      | Hivex.REG_QWORD ->
-          (bitmatch Bitstring.bitstring_of_string v with
-           | { i : 64 : littleendian } -> sprintf "%016Lx" i
-           | { _ } -> markup_hex_data v)
-      | Hivex.REG_UNKNOWN i32 -> markup_hex_data v
-    ) in
+    if len >= 512 then sprintf "<%d bytes not printed>" len
+    else markup_escape (printable_hivex_value ~split_long_lines:true t v) in
 
   let fg = if not visited then normal file_color else darken file_color in
   sprintf "<span fgcolor=\"%s\">%s</span>=<span fgcolor=\"%s\">%s</span>"
     fg (markup_escape k) fg v
 
-(* Mark up registry value as hex data. *)
-and markup_hex_data v =
-  let vs = String.explode v in
-  let vs = List.mapi (
-    fun i c ->
-      sprintf "%s%02x" (if i mod 16 = 0 then "\n" else "") (int_of_char c)
-  ) vs in
-  String.concat "," vs
-
-(* Best guess the format of the string and convert to UTF-8. *)
-and markup_windows_string v =
-  try markup_escape (windows_string_to_utf8 v)
-  with CharEncoding.Malformed_code | CharEncoding.Out_of_range ->
-    (* Fallback to displaying the string as hex. *)
-    markup_hex_data v
-
 and normal (r, g, b) =
   let r = if r < 0 then 0 else if r > 255 then 255 else r in
   let g = if g < 0 then 0 else if g > 255 then 255 else g in