1 PLEASE LOOK AT THE TOP OF EACH FILE BEFORE EDITING TO SEE WHETHER IT
2 IS AUTOMATICALLY GENERATED OR NOT.
5 ----------------------------------------------------------------------
7 All action functions are generated automatically, so there are only
8 two files you need to edit:
10 (1) src/generator.ml: Add your new action, parameters, description,
11 etc. to the big list called 'functions' at the top of this file.
13 (2) Edit/create a C file in daemon/ subdirectory which implements your
14 'do_action' function. Take a look at one of the numerous examples
18 ----------------------------------------------------------------------
20 Try to use GNU / Emacs default formatting, following the convention
21 used elsewhere in the source.
23 Please make sure that the code compiles without warnings.
25 Please test any changes.
28 ----------------------------------------------------------------------
29 Our C source code generally adheres to some basic code-formatting
30 conventions. The existing code base is not totally consistent on this
31 front, but we do prefer that contributed code be formatted similarly.
32 In short, use spaces-not-TABs for indentation, use 2 spaces for each
33 indentation level, and other than that, follow the K&R style.
35 If you use Emacs, add the following to one of one of your start-up files
36 (e.g., ~/.emacs), to help ensure that you get indentation right:
38 ;;; In libguestfs, indent with spaces everywhere (not TABs).
39 ;;; Exceptions: Makefile and ChangeLog modes.
40 (add-hook 'find-file-hook
41 '(lambda () (if (and buffer-file-name
42 (string-match "/libguestfs\\>" (buffer-file-name))
43 (not (string-equal mode-name "Change Log"))
44 (not (string-equal mode-name "Makefile")))
45 (setq indent-tabs-mode nil))))
47 ;;; When editing C sources in libguestfs, use this style.
48 (defun libguestfs-c-mode ()
49 "C mode with adjusted defaults for use with libguestfs."
52 (setq c-indent-level 2)
53 (setq c-basic-offset 2))
54 (add-hook 'c-mode-hook
55 '(lambda () (if (string-match "/libguestfs\\>" (buffer-file-name))
56 (libguestfs-c-mode))))
59 ----------------------------------------------------------------------
62 The qemu appliance, build scripts and so on.
68 Automated tests of the C API.
71 Outside contributions, experimental parts.
74 The daemon that runs inside the guest and carries out actions.
83 Guestfish (the command-line program / shell)
89 Some guest images to test against. These are gzipped to save
90 space. You have to unzip them before use.
92 Also contains some files used by the test suite.
95 Virtual machine image inspector (virt-inspector).
101 M4 macros used by autoconf.
122 Source code to the C library.
123 Also contains the crucial generator program.
126 Interactive qemu/kernel test tool.
129 Xen to KVM (V2V) conversion tool.
132 ----------------------------------------------------------------------
134 It's a good idea to use guestfish to try out new commands.
136 Debugging the daemon is a problem because it runs inside a minimal
137 qemu environment. However you can print messages from the daemon, and
138 they will show up if you use 'guestfish -v'.
141 ----------------------------------------------------------------------
143 Submit patches to the mailing list:
144 http://www.redhat.com/mailman/listinfo/libguestfs
145 and CC to rjones@redhat.com
148 ----------------------------------------------------------------------
150 We support i18n (gettext anyhow) in the library.
152 However many messages come from the daemon, and we don't translate
153 those at the moment. One reason is that the appliance generally has
154 all locale files removed from it, because they take up a lot of space.
155 So we'd have to readd some of those, as well as copying our PO files
158 Debugging messages are never translated, since they are intended for
162 ----------------------------------------------------------------------
164 In the daemon code we have created custom printf formatters %Q and %R,
165 which are used to do shell quoting.
167 %Q => Simple shell quoted string. Any spaces or other shell characters
170 %R => Same as %Q except the string is treated as a path which is prefixed
175 asprintf (&cmd, "cat %R", path);
176 ==> "cat /sysroot/some\ path\ with\ spaces"
178 Note: Do NOT use these when you are passing parameters to the
179 command{,r,v,rv}() functions. These parameters do NOT need to be
180 quoted because they are not passed via the shell (instead, straight to
181 exec). You probably want to use the sysroot_path() function however.