From d278ef8ad9090441a713c7334804199318aeb3e1 Mon Sep 17 00:00:00 2001 From: Richard Jones Date: Tue, 29 Sep 2009 11:56:26 +0100 Subject: [PATCH] OCaml viewer: Handle exceptions properly. --- ocaml/examples/viewer.ml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/ocaml/examples/viewer.ml b/ocaml/examples/viewer.ml index 20fa608..ef6627b 100644 --- a/ocaml/examples/viewer.ml +++ b/ocaml/examples/viewer.ml @@ -227,6 +227,7 @@ end = struct *) debug "Slave.slave_loop: command failed"; + !busy_cb `Idle; with_lock q_lock (fun () -> Q.clear q); GtkThread.async !failure_cb exn ); @@ -383,7 +384,13 @@ type display_state = { * necessary to turn the exception into an error message. *) let failure ds exn = - debug "failure callback: %s" (Printexc.to_string exn) + let title = "Error" in + let msg = Printexc.to_string exn in + debug "failure callback: %s" msg; + let icon = GMisc.image () in + icon#set_stock `DIALOG_ERROR; + icon#set_icon_size `DIALOG; + GToolbox.message_box ~title ~icon msg (* This is called in the main thread when the slave thread transitions * to busy or idle. -- 1.8.3.1