From 089ccb28aee2f025bf73ae03d3fae558296a9b62 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Fri, 22 Oct 2010 12:13:07 +0100 Subject: [PATCH] inspector: Add comment about why --fish option implies write mode. (cherry picked from commit 2109d8d86aeb66093e0a9f41d3693693e3df66d5) --- inspector/virt-inspector | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/inspector/virt-inspector b/inspector/virt-inspector index 33a9b3c..49bf082 100755 --- a/inspector/virt-inspector +++ b/inspector/virt-inspector @@ -199,7 +199,15 @@ if ($version) { pod2usage (__"virt-inspector: no image or VM names given") if @ARGV == 0; my $rw = 0; + +# XXX This is a bug: Originally we intended to open the guest with +# rw=>1 in order to tell Sys::Guestfs::Lib that we should disallow +# active domains. However this also has the effect of opening the +# disk image in write mode, and in any case we don't use this option +# in guestfish any more since we moved all the inspection code into +# the core library. We should drop the fish output modes completely. $rw = 1 if $output eq "fish"; + my $g; my @images; if ($uri) { -- 1.8.3.1