From: Richard Jones <rjones@redhat.com>
Date: Tue, 5 Jan 2010 23:04:57 +0000 (+0000)
Subject: inspector: Make RPM application data more specific (RHBZ#552718).
X-Git-Tag: 1.0.81~5
X-Git-Url: http://git.annexia.org/?p=libguestfs.git;a=commitdiff_plain;h=a59dcdbd1b0a28c960e3792165a13f2daf4f6c35

inspector: Make RPM application data more specific (RHBZ#552718).

List applications with epoch, release and arch data.

If epoch is 0, don't store this as an empty string, but as
undefined, and don't output empty <epoch/> element in the XML.
---

diff --git a/inspector/virt-inspector b/inspector/virt-inspector
index d000510..cb892c0 100755
--- a/inspector/virt-inspector
+++ b/inspector/virt-inspector
@@ -519,7 +519,10 @@ sub output_xml_os
     foreach (@apps) {
         $xml->startTag("application");
         $xml->dataElement("name", $_->{name});
+        $xml->dataElement("epoch", $_->{epoch}) if defined $_->{epoch};
         $xml->dataElement("version", $_->{version});
+        $xml->dataElement("release", $_->{release});
+        $xml->dataElement("arch", $_->{arch});
         $xml->endTag("application");
     }
     $xml->endTag("applications");
diff --git a/perl/lib/Sys/Guestfs/Lib.pm b/perl/lib/Sys/Guestfs/Lib.pm
index c97fae3..49c08b3 100644
--- a/perl/lib/Sys/Guestfs/Lib.pm
+++ b/perl/lib/Sys/Guestfs/Lib.pm
@@ -1426,7 +1426,7 @@ sub _check_for_applications
             foreach (@lines) {
                 if (m/^(.*) (.*) (.*) (.*) (.*)$/) {
                     my $epoch = $2;
-                    $epoch = "" if $epoch eq "(none)";
+                    undef $epoch if $epoch eq "(none)";
                     my $app = {
                         name => $1,
                         epoch => $epoch,