From: Richard W.M. Jones <rjones@redhat.com>
Date: Sun, 8 May 2011 14:13:23 +0000 (+0100)
Subject: Fix guestfs___rollback_cmdline when pos == 0.
X-Git-Tag: 1.11.4~1
X-Git-Url: http://git.annexia.org/?p=libguestfs.git;a=commitdiff_plain;h=607aa95de927b5b8e4b212655c71bf21acbba372;hp=8ee0ad0caf2f90f4883909cd9b61c4dd6f9cffbf

Fix guestfs___rollback_cmdline when pos == 0.

Because of the previous change to size_t, when pos == 0 the loop would
wrap around and cause a segmentation fault.

This fixes a regression introduced by
commit 10167cea98f93a74abe63f0a54d3a662997e7489.
---

diff --git a/src/launch.c b/src/launch.c
index 8dfeb31..ecc0464 100644
--- a/src/launch.c
+++ b/src/launch.c
@@ -117,7 +117,7 @@ guestfs___rollback_cmdline (guestfs_h *g, size_t pos)
 
   assert (g->cmdline_size >= pos);
 
-  for (i = g->cmdline_size - 1; i >= pos; --i)
+  for (i = pos; i < g->cmdline_size; ++i)
     free (g->cmdline[i]);
 
   g->cmdline_size = pos;