From: Richard W.M. Jones <rjones@redhat.com>
Date: Tue, 18 Jan 2011 22:38:05 +0000 (+0000)
Subject: fish: Initialize pcmd structure.
X-Git-Tag: 1.9.6~3
X-Git-Url: http://git.annexia.org/?p=libguestfs.git;a=commitdiff_plain;h=316ad8311a41869cf5f253225137dd03d1211ce7

fish: Initialize pcmd structure.

On Debian we get this warning which I'm pretty sure is bogus:

fish.c:690: error: 'pcmd.cmd' may be used uninitialized in this
function [-Wuninitialized]
---

diff --git a/fish/fish.c b/fish/fish.c
index 4a960dc..10f645f 100644
--- a/fish/fish.c
+++ b/fish/fish.c
@@ -678,7 +678,10 @@ parse_command_line (char *buf, int *exit_on_error_rtn)
   int r;
   const size_t argv_len = sizeof pcmd.argv / sizeof pcmd.argv[0];
 
-  pcmd.pipe = NULL;
+  /* Note that pcmd.pipe must be set to NULL for correct usage.  Other
+   * fields do not need to be, but this silences a gcc warning.
+   */
+  memset (&pcmd, 0, sizeof pcmd);
 
  again:
   /* Skip any initial whitespace before the command. */