X-Git-Url: http://git.annexia.org/?p=libguestfs.git;a=blobdiff_plain;f=daemon%2Ftar.c;h=30085741c7f787e3a6439ff68472eb1d006caf88;hp=4d9feaa0d094e42c528491efaaa0601ca626a451;hb=10258cadd0067cb49b89faf1ce424b1c01f5a7c3;hpb=887290e949d54c6ac4c9b787231e588f84f2367c diff --git a/daemon/tar.c b/daemon/tar.c index 4d9feaa..3008574 100644 --- a/daemon/tar.c +++ b/daemon/tar.c @@ -1,5 +1,5 @@ /* libguestfs - the guestfsd daemon - * Copyright (C) 2009 Red Hat Inc. + * Copyright (C) 2009 Red Hat Inc. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -49,7 +49,7 @@ do_tar_in (char *dir) } /* "tar -C /sysroot%s -xf -" but we have to quote the dir. */ - len = 2 * strlen (dir) + 32; + len = 2 * strlen (dir) + sysroot_len + 32; cmd = malloc (len); if (!cmd) { err = errno; @@ -58,7 +58,8 @@ do_tar_in (char *dir) reply_with_perror ("malloc"); return -1; } - strcpy (cmd, "tar -C /sysroot"); + strcpy (cmd, "tar -C "); + strcat (cmd, sysroot); shell_quote (cmd+15, len-15, dir); strcat (cmd, " -xf -"); @@ -88,7 +89,7 @@ do_tar_in (char *dir) return -1; } - if (pclose (fp) == -1) { + if (pclose (fp) != 0) { err = errno; cancel_receive (); errno = err; @@ -112,13 +113,14 @@ do_tar_out (char *dir) ABS_PATH (dir, -1); /* "tar -C /sysroot%s -cf - ." but we have to quote the dir. */ - len = 2 * strlen (dir) + 32; + len = 2 * strlen (dir) + sysroot_len + 32; cmd = malloc (len); if (!cmd) { reply_with_perror ("malloc"); return -1; } - strcpy (cmd, "tar -C /sysroot"); + strcpy (cmd, "tar -C "); + strcat (cmd, sysroot); shell_quote (cmd+15, len-15, dir); strcat (cmd, " -cf - ."); @@ -150,7 +152,7 @@ do_tar_out (char *dir) return -1; } - if (pclose (fp) == -1) { + if (pclose (fp) != 0) { perror (dir); send_file_end (1); /* Cancel. */ return -1; @@ -175,7 +177,7 @@ do_tgz_in (char *dir) } /* "tar -C /sysroot%s -zxf -" but we have to quote the dir. */ - len = 2 * strlen (dir) + 32; + len = 2 * strlen (dir) + sysroot_len + 32; cmd = malloc (len); if (!cmd) { err = errno; @@ -184,7 +186,8 @@ do_tgz_in (char *dir) reply_with_perror ("malloc"); return -1; } - strcpy (cmd, "tar -C /sysroot"); + strcpy (cmd, "tar -C "); + strcat (cmd, sysroot); shell_quote (cmd+15, len-15, dir); strcat (cmd, " -zxf -"); @@ -214,7 +217,7 @@ do_tgz_in (char *dir) return -1; } - if (pclose (fp) == -1) { + if (pclose (fp) != 0) { err = errno; cancel_receive (); errno = err; @@ -238,13 +241,14 @@ do_tgz_out (char *dir) ABS_PATH (dir, -1); /* "tar -C /sysroot%s -zcf - ." but we have to quote the dir. */ - len = 2 * strlen (dir) + 32; + len = 2 * strlen (dir) + sysroot_len + 32; cmd = malloc (len); if (!cmd) { reply_with_perror ("malloc"); return -1; } - strcpy (cmd, "tar -C /sysroot"); + strcpy (cmd, "tar -C "); + strcat (cmd, sysroot); shell_quote (cmd+15, len-15, dir); strcat (cmd, " -zcf - ."); @@ -276,7 +280,7 @@ do_tgz_out (char *dir) return -1; } - if (pclose (fp) == -1) { + if (pclose (fp) != 0) { perror (dir); send_file_end (1); /* Cancel. */ return -1;