X-Git-Url: http://git.annexia.org/?p=libguestfs.git;a=blobdiff_plain;f=daemon%2Fdir.c;h=300bb4ce8a6a91557386f039fb10e19f18d106e4;hp=7892682f63476eec2eefd57b370732c842406b7f;hb=4b4e0d0d07bd34f4368c6a213ff757d4ebf98411;hpb=44da812b424f5e10e268d47149d012d49edf858b diff --git a/daemon/dir.c b/daemon/dir.c index 7892682..300bb4c 100644 --- a/daemon/dir.c +++ b/daemon/dir.c @@ -1,5 +1,5 @@ /* libguestfs - the guestfsd daemon - * Copyright (C) 2009 Red Hat Inc. + * Copyright (C) 2009 Red Hat Inc. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -34,9 +34,6 @@ do_rmdir (const char *path) { int r; - NEED_ROOT (-1); - ABS_PATH (path, -1); - CHROOT_IN; r = rmdir (path); CHROOT_OUT; @@ -56,27 +53,21 @@ do_rmdir (const char *path) int do_rm_rf (const char *path) { - int r, len; + int r; char *buf, *err; - NEED_ROOT (-1); - ABS_PATH (path, -1); - - if (strcmp (path, "/") == 0) { + if (STREQ (path, "/")) { reply_with_error ("rm -rf: cannot remove root directory"); return -1; } - len = strlen (path) + 9; - buf = malloc (len); + buf = sysroot_path (path); if (buf == NULL) { reply_with_perror ("malloc"); return -1; } - snprintf (buf, len, "/sysroot%s", path); - - r = command (NULL, &err, "rm", "-rf", buf); + r = command (NULL, &err, "rm", "-rf", buf, NULL); free (buf); /* rm -rf is never supposed to fail. I/O errors perhaps? */ @@ -96,9 +87,6 @@ do_mkdir (const char *path) { int r; - NEED_ROOT (-1); - ABS_PATH (path, -1); - CHROOT_IN; r = mkdir (path, 0777); CHROOT_OUT; @@ -111,16 +99,46 @@ do_mkdir (const char *path) return 0; } +int +do_mkdir_mode (const char *path, int mode) +{ + int r; + + CHROOT_IN; + r = mkdir (path, mode); + CHROOT_OUT; + + if (r == -1) { + reply_with_perror ("mkdir_mode: %s", path); + return -1; + } + + return 0; +} + +/* Returns: + * 0 if everything was OK, + * -1 for a general error (sets errno), + * -2 if an existing path element was not a directory. + */ static int recursive_mkdir (const char *path) { int loop = 0; int r; char *ppath, *p; + struct stat buf; again: r = mkdir (path, 0777); if (r == -1) { + if (errno == EEXIST) { /* Something exists here, might not be a dir. */ + r = lstat (path, &buf); + if (r == -1) return -1; + if (!S_ISDIR (buf.st_mode)) return -2; + return 0; /* OK - directory exists here already. */ + } + if (!loop && errno == ENOENT) { loop = 1; /* Stops it looping forever. */ @@ -137,7 +155,7 @@ recursive_mkdir (const char *path) r = recursive_mkdir (ppath); free (ppath); - if (r == -1) return -1; + if (r != 0) return r; goto again; } else /* Failed for some other reason, so return error. */ @@ -151,9 +169,6 @@ do_mkdir_p (const char *path) { int r; - NEED_ROOT (-1); - ABS_PATH (path, -1); - CHROOT_IN; r = recursive_mkdir (path); CHROOT_OUT; @@ -162,6 +177,53 @@ do_mkdir_p (const char *path) reply_with_perror ("mkdir -p: %s", path); return -1; } + if (r == -2) { + reply_with_error ("mkdir -p: %s: a path element was not a directory", path); + return -1; + } return 0; } + +int +do_is_dir (const char *path) +{ + int r; + struct stat buf; + + CHROOT_IN; + r = lstat (path, &buf); + CHROOT_OUT; + + if (r == -1) { + if (errno != ENOENT && errno != ENOTDIR) { + reply_with_perror ("stat: %s", path); + return -1; + } + else + return 0; /* Not a directory. */ + } + + return S_ISDIR (buf.st_mode); +} + +char * +do_mkdtemp (const char *template) +{ + char *writable = strdup (template); + if (writable == NULL) { + reply_with_perror ("strdup"); + return NULL; + } + + CHROOT_IN; + char *r = mkdtemp (writable); + CHROOT_OUT; + + if (r == NULL) { + reply_with_perror ("mkdtemp: %s", template); + free (writable); + } + + return r; +}