X-Git-Url: http://git.annexia.org/?p=libguestfs.git;a=blobdiff_plain;f=HACKING;h=7156bf7072d399efbd0cc0bff193624c3a95d017;hp=815ee16e8608a1b481bceaaed32ccf070671a217;hb=f9071160c1a5fe21a825398a81ba3ca584892a4e;hpb=4c2c2793bad56ce05caf6244e10fd5bcd7023383 diff --git a/HACKING b/HACKING index 815ee16..7156bf7 100644 --- a/HACKING +++ b/HACKING @@ -24,6 +24,13 @@ Please make sure that the code compiles without warnings. Please test any changes. +Useful targets: + make syntax-check Checks the syntax of the C code. + make check Runs the test suite. + +Enable warnings, and fix any you find: + ./configure --enable-gcc-warnings + Code indentation ---------------------------------------------------------------------- Our C source code generally adheres to some basic code-formatting @@ -35,17 +42,25 @@ indentation level, and other than that, follow the K&R style. If you use Emacs, add the following to one of one of your start-up files (e.g., ~/.emacs), to help ensure that you get indentation right: + ;;; In libguestfs, indent with spaces everywhere (not TABs). + ;;; Exceptions: Makefile and ChangeLog modes. + (add-hook 'find-file-hook + '(lambda () (if (and buffer-file-name + (string-match "/libguestfs\\>" (buffer-file-name)) + (not (string-equal mode-name "Change Log")) + (not (string-equal mode-name "Makefile"))) + (setq indent-tabs-mode nil)))) + ;;; When editing C sources in libguestfs, use this style. (defun libguestfs-c-mode () "C mode with adjusted defaults for use with libguestfs." (interactive) (c-set-style "K&R") - (setq indent-tabs-mode nil) ; indent using spaces, not TABs (setq c-indent-level 2) (setq c-basic-offset 2)) (add-hook 'c-mode-hook - '(lambda () (if (string-match "/libguestfs" (buffer-file-name)) - (libguestfs-c-mode)))) + '(lambda () (if (string-match "/libguestfs\\>" (buffer-file-name)) + (libguestfs-c-mode)))) Directories ---------------------------------------------------------------------- @@ -117,9 +132,6 @@ src/ test-tool/ Interactive qemu/kernel test tool. -v2v/ - Xen to KVM (V2V) conversion tool. - Debugging ----------------------------------------------------------------------