From 6b600812d52dd14146de4dc3e83c39f54f3b27cc Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Sat, 26 Apr 2014 11:51:25 +0100 Subject: [PATCH] Add a note about clearing the input buffer in mexp_expect. --- miniexpect.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/miniexpect.c b/miniexpect.c index fef03fd..eca8e9a 100644 --- a/miniexpect.c +++ b/miniexpect.c @@ -208,6 +208,10 @@ mexp_expect (mexp_h *h, const mexp_regexp *regexps, int *ovector, int ovecsize) time (&start_t); /* Clear the read buffer. */ + /* XXX This is possibly incorrect because it throws away inputs that + * may not have been matched yet. A better idea is to record the + * end of the previous match and only throw that away. + */ clear_buffer (h); for (;;) { -- 1.8.3.1