From df4dce74a887e013a6aec51e241a90cfb7d3b36a Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Thu, 21 Apr 2011 17:29:44 +0100 Subject: [PATCH] list-applications: If software hive is missing, this is an error. virt-inspector would exit silently if list-applications failed along this error path. Cherry picked and backported from commit 782f3a36469ca396dbf998ea82af2699153be3ed. --- src/inspect.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/inspect.c b/src/inspect.c index 900b6f4..370220b 100644 --- a/src/inspect.c +++ b/src/inspect.c @@ -2003,11 +2003,11 @@ list_applications_windows (guestfs_h *g, struct inspect_fs *fs) fs->windows_systemroot); char *software_path = case_sensitive_path_silently (g, software); - if (!software_path) - /* If the software hive doesn't exist, just accept that we cannot - * find product_name etc. - */ - return 0; + if (!software_path) { + /* Missing software hive is a problem. */ + error (g, "no HKLM\\SOFTWARE hive found in the guest"); + return NULL; + } struct guestfs_application_list *apps = NULL, *ret = NULL; hive_h *h = NULL; -- 1.8.3.1