From 9671726e2cd37d41a914461b060847e9a56540ae Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Tue, 23 Aug 2011 19:50:11 +0100 Subject: [PATCH] Coverity: fix memory leak along error path. (cherry picked from commit ce18be33cd5279a8d4120eedd037400c275585c0) --- src/appliance.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/appliance.c b/src/appliance.c index 6629abb..822fe77 100644 --- a/src/appliance.c +++ b/src/appliance.c @@ -401,6 +401,12 @@ check_for_cached_appliance (guestfs_h *g, /* Releases the lock on checksum. */ if (close (fd) == -1) { perrorf (g, "close"); + /* Allocated in hard_link_to_cached_appliance above, must be + * freed along this error path. + */ + free (*kernel); + free (*initrd); + free (*appliance); return -1; } @@ -539,6 +545,12 @@ build_supermin_appliance (guestfs_h *g, /* Releases the lock on checksum. */ if (close (fd) == -1) { perrorf (g, "close"); + /* Allocated in hard_link_to_cached_appliance above, must be + * freed along this error path. + */ + free (*kernel); + free (*initrd); + free (*appliance); return -1; } -- 1.8.3.1