From 8e9e6725b4d2eb349240e321b3a8298ce88c10d7 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Thu, 25 Aug 2011 13:56:09 +0100 Subject: [PATCH] ruby: Check Ruby callback exists before we call it (RHBZ#733297). (cherry picked from commit 1a4f1df77eecee053eaae35d5544f151d37342e2) --- generator/generator_ruby.ml | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/generator/generator_ruby.ml b/generator/generator_ruby.ml index 9ac35d7..d055157 100644 --- a/generator/generator_ruby.ml +++ b/generator/generator_ruby.ml @@ -246,13 +246,21 @@ ruby_event_callback_wrapper_wrapper (VALUE argvv) VALUE fn, eventv, event_handlev, bufv, arrayv; fn = argv[0]; - eventv = argv[1]; - event_handlev = argv[2]; - bufv = argv[3]; - arrayv = argv[4]; - rb_funcall (fn, rb_intern (\"call\"), 4, - eventv, event_handlev, bufv, arrayv); + /* Check the Ruby callback still exists. For reasons which are not + * fully understood, even though we registered this as a global root, + * it is still possible for the callback to go away (fn value remains + * but its type changes from T_DATA to T_NONE). (RHBZ#733297) + */ + if (rb_type (fn) != T_NONE) { + eventv = argv[1]; + event_handlev = argv[2]; + bufv = argv[3]; + arrayv = argv[4]; + + rb_funcall (fn, rb_intern (\"call\"), 4, + eventv, event_handlev, bufv, arrayv); + } return Qnil; } -- 1.8.3.1