From 210c4ccefbf41e0608bea3dff40181ecbdaca082 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Wed, 8 Jun 2011 22:01:41 +0100 Subject: [PATCH] Coverity: Avoid calling sort_strings (NULL, 0) on empty list. (cherry picked from commit 3ed8d5122026f37dd96cc7e8503c4f3ecf0afbb7) --- daemon/devsparts.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/daemon/devsparts.c b/daemon/devsparts.c index 1781def..c8f0256 100644 --- a/daemon/devsparts.c +++ b/daemon/devsparts.c @@ -105,8 +105,9 @@ foreach_block_device (block_dev_func_t func) return NULL; } - /* Sort the devices */ - sort_strings (r, size); + /* Sort the devices. Note that r might be NULL if there are no devices. */ + if (r != NULL) + sort_strings (r, size); /* NULL terminate the list */ if (add_string (&r, &size, &alloc, NULL) == -1) { -- 1.8.3.1